/mandos/trunk

To get this branch, use:
bzr branch http://bzr.recompile.se/loggerhead/mandos/trunk

  • Committer: Teddy Hogeborn
  • Date: 2021-02-03 23:10:42 UTC
  • Revision ID: teddy@recompile.se-20210203231042-2z3egrvpo1zt7nej
mandos-ctl: Fix bad test for command.Remove and related minor issues

The test for command.Remove removes all clients from the spy server,
and then loops over all clients, looking for the corresponding Remove
command as recorded by the spy server.  But since since there aren't
any clients left after they were removed, no assertions are made, and
the test therefore does nothing.  Fix this.

In tests for command.Approve and command.Deny, add checks that clients
were not somehow removed by the command (in which case, likewise, no
assertions are made).

Add related checks to TestPropertySetterCmd.runTest; i.e. test that a
sequence is not empty before looping over it and making assertions.

* mandos-ctl (TestBaseCommands.test_Remove): Save a copy of the
  original "clients" dict, and loop over those instead.  Add assertion
  that all clients were indeed removed.  Also fix the code which looks
  for the Remove command, which now needs to actually work.
  (TestBaseCommands.test_Approve, TestBaseCommands.test_Deny): Add
  assertion that there are still clients before looping over them.
  (TestPropertySetterCmd.runTest): Add assertion that the list of
  values to get is not empty before looping over them.  Also add check
  that there are still clients before looping over clients.
Filename Latest Rev Last Changed Committer Comment Size
..
de.po 1155 4 years ago Teddy Hogeborn From: Chris Leick <c.leick@vollbio.de> Add German 5.9 KB Diff Download File
en_US.po 1150 4 years ago Teddy Hogeborn Create a debconf translation file * debian/mandos 5.4 KB Diff Download File
fr.po 1232 3 years ago Teddy Hogeborn Fix issue with french translation Initial white s 5.9 KB Diff Download File
nl.po 1194 4 years ago teddy at recompile From: Frans Spiesschaert <Frans.Spiesschaert@yucom 5.8 KB Diff Download File
POTFILES.in 1128 4 years ago Teddy Hogeborn Add debconf translation support * debian/mandos-c 93 bytes Diff Download File
pt.po 1180 4 years ago Teddy Hogeborn From: Américo Monteiro <a_monteiro@gmx.com> Add P 5.7 KB Diff Download File
sv.po 1157 4 years ago Teddy Hogeborn Add Swedish debconf translation * debian/po/sv.po 5.7 KB Diff Download File
templates.pot 1150 4 years ago Teddy Hogeborn Create a debconf translation file * debian/mandos 3.5 KB Diff Download File