/mandos/release

To get this branch, use:
bzr branch http://bzr.recompile.se/loggerhead/mandos/release

« back to all changes in this revision

Viewing changes to plugins.d/usplash.c

Fixes for sscanf usage:

* plugin-runner.c (main): Parse numbers correctly and portably using
                          an intermediate "intmax_t".  Cast "pid_t" to
                          "intmax_t" before passing it to "printf()".
* plugins.d/mandos-client.c (main): Parse numbers correctly and
                                    portably using an intermediate
                                    "intmax_t".  Bug fix: cast
                                    "AvahiIfIndex" to "intmax_t" and
                                    use "PRIdMAX" instead of using
                                    "PRIu16", and use "PRIu16" to
                                    format port number.
* plugins.d/splashy.c (main): Parse numbers correctly and portably
                              using an intermediate "intmax_t".
* plugins.d/usplash.c (main): - '' -

Show diffs side-by-side

added added

removed removed

Lines of Context:
plugins.d/usplash.c
46
46
                                   EXIT_SUCCESS, malloc(), _exit() */
47
47
#include <stdlib.h>             /* getenv() */
48
48
#include <dirent.h>             /* opendir(), readdir(), closedir() */
 
49
#include <inttypes.h>           /* intmax_t, SCNdMAX */
49
50
#include <sys/stat.h>           /* struct stat, lstat(), S_ISLNK */
50
51
 
51
52
sig_atomic_t interrupted_by_signal = 0;
170
171
        proc_ent != NULL;
171
172
        proc_ent = readdir(proc_dir)){
172
173
      pid_t pid;
173
 
      /* In the GNU C library, pid_t is always int */
174
 
      ret = sscanf(proc_ent->d_name, "%d", &pid);
175
 
      if(ret != 1){
176
 
        /* Not a process */
177
 
        continue;
 
174
      {
 
175
        intmax_t tmpmax;
 
176
        int numchars;
 
177
        ret = sscanf(proc_ent->d_name, "%" SCNdMAX "%n", &tmpmax,
 
178
                     &numchars);
 
179
        if(ret < 1 or tmpmax != (pid_t)tmpmax
 
180
           or proc_ent->d_name[numchars] != '\0'){
 
181
          /* Not a process */
 
182
          continue;
 
183
        }
 
184
        pid = (pid_t)tmpmax;
178
185
      }
179
186
      /* Find the executable name by doing readlink() on the
180
187
         /proc/<pid>/exe link */