/mandos/trunk

To get this branch, use:
bzr branch http://bzr.recompile.se/loggerhead/mandos/trunk

  • Committer: Teddy Hogeborn
  • Date: 2021-02-03 23:10:42 UTC
  • Revision ID: teddy@recompile.se-20210203231042-2z3egrvpo1zt7nej
mandos-ctl: Fix bad test for command.Remove and related minor issues

The test for command.Remove removes all clients from the spy server,
and then loops over all clients, looking for the corresponding Remove
command as recorded by the spy server.  But since since there aren't
any clients left after they were removed, no assertions are made, and
the test therefore does nothing.  Fix this.

In tests for command.Approve and command.Deny, add checks that clients
were not somehow removed by the command (in which case, likewise, no
assertions are made).

Add related checks to TestPropertySetterCmd.runTest; i.e. test that a
sequence is not empty before looping over it and making assertions.

* mandos-ctl (TestBaseCommands.test_Remove): Save a copy of the
  original "clients" dict, and loop over those instead.  Add assertion
  that all clients were indeed removed.  Also fix the code which looks
  for the Remove command, which now needs to actually work.
  (TestBaseCommands.test_Approve, TestBaseCommands.test_Deny): Add
  assertion that there are still clients before looping over them.
  (TestPropertySetterCmd.runTest): Add assertion that the list of
  values to get is not empty before looping over them.  Also add check
  that there are still clients before looping over clients.
Filename Latest Rev Last Changed Committer Comment Size
..
ask-password-mandos.path 1127 5 years ago Teddy Hogeborn Add dracut(8) support Add support for the dracut( 1.8 KB Diff Download File
ask-password-mandos.service 1218 4 years ago teddy at recompile Update copyright year * DBUS-API: Update copyrigh 2.2 KB Diff Download File
File cmdline-mandos.sh 1127 5 years ago Teddy Hogeborn Add dracut(8) support Add support for the dracut( 2.8 KB Diff Download File
File module-setup.sh 1201 4 years ago teddy at recompile Allow users to alter ask-password-mandos.service 7.7 KB Diff Download File
password-agent.c 1234 3 years ago Teddy Hogeborn Update copyright year * debian/copyright: Update 263 KB Diff Download File
password-agent.xml 1234 3 years ago Teddy Hogeborn Update copyright year * debian/copyright: Update 14.5 KB Diff Download File