/mandos/trunk

To get this branch, use:
bzr branch http://bzr.recompile.se/loggerhead/mandos/trunk

« back to all changes in this revision

Viewing changes to mandos-ctl

  • Committer: Teddy Hogeborn
  • Date: 2019-02-28 18:54:11 UTC
  • Revision ID: teddy@recompile.se-20190228185411-71f49cg8plsvdkub
Add tests to mandos-ctl's milliseconds_to_string function

* mandos-ctl (Test_milliseconds_to_string): New.

Show diffs side-by-side

added added

removed removed

Lines of Context:
41
41
import collections
42
42
import json
43
43
import unittest
44
 
import logging
45
44
 
46
45
import dbus
47
46
 
48
 
# Show warnings by default
49
 
if not sys.warnoptions:
50
 
    import warnings
51
 
    warnings.simplefilter("default")
52
 
 
53
 
log = logging.getLogger(sys.argv[0])
54
 
logging.basicConfig(level="INFO", # Show info level messages
55
 
                    format="%(message)s") # Show basic log messages
56
 
 
57
 
logging.captureWarnings(True)   # Show warnings via the logging system
58
 
 
59
47
if sys.version_info.major == 2:
60
48
    str = unicode
61
49
 
62
50
locale.setlocale(locale.LC_ALL, "")
63
51
 
 
52
tablewords = {
 
53
    "Name": "Name",
 
54
    "Enabled": "Enabled",
 
55
    "Timeout": "Timeout",
 
56
    "LastCheckedOK": "Last Successful Check",
 
57
    "LastApprovalRequest": "Last Approval Request",
 
58
    "Created": "Created",
 
59
    "Interval": "Interval",
 
60
    "Host": "Host",
 
61
    "Fingerprint": "Fingerprint",
 
62
    "KeyID": "Key ID",
 
63
    "CheckerRunning": "Check Is Running",
 
64
    "LastEnabled": "Last Enabled",
 
65
    "ApprovalPending": "Approval Is Pending",
 
66
    "ApprovedByDefault": "Approved By Default",
 
67
    "ApprovalDelay": "Approval Delay",
 
68
    "ApprovalDuration": "Approval Duration",
 
69
    "Checker": "Checker",
 
70
    "ExtendedTimeout": "Extended Timeout",
 
71
    "Expires": "Expires",
 
72
    "LastCheckerStatus": "Last Checker Status",
 
73
}
 
74
defaultkeywords = ("Name", "Enabled", "Timeout", "LastCheckedOK")
64
75
domain = "se.recompile"
65
76
busname = domain + ".Mandos"
66
77
server_path = "/"
93
104
    datetime.timedelta(0, 60)
94
105
    >>> rfc3339_duration_to_delta("PT60M")
95
106
    datetime.timedelta(0, 3600)
96
 
    >>> rfc3339_duration_to_delta("P60M")
97
 
    datetime.timedelta(1680)
98
107
    >>> rfc3339_duration_to_delta("PT24H")
99
108
    datetime.timedelta(1)
100
109
    >>> rfc3339_duration_to_delta("P1W")
103
112
    datetime.timedelta(0, 330)
104
113
    >>> rfc3339_duration_to_delta("P1DT3M20S")
105
114
    datetime.timedelta(1, 200)
106
 
    >>> # Can not be empty:
107
 
    >>> rfc3339_duration_to_delta("")
108
 
    Traceback (most recent call last):
109
 
    ...
110
 
    ValueError: Invalid RFC 3339 duration: u''
111
 
    >>> # Must start with "P":
112
 
    >>> rfc3339_duration_to_delta("1D")
113
 
    Traceback (most recent call last):
114
 
    ...
115
 
    ValueError: Invalid RFC 3339 duration: u'1D'
116
 
    >>> # Must use correct order
117
 
    >>> rfc3339_duration_to_delta("PT1S2M")
118
 
    Traceback (most recent call last):
119
 
    ...
120
 
    ValueError: Invalid RFC 3339 duration: u'PT1S2M'
121
 
    >>> # Time needs time marker
122
 
    >>> rfc3339_duration_to_delta("P1H2S")
123
 
    Traceback (most recent call last):
124
 
    ...
125
 
    ValueError: Invalid RFC 3339 duration: u'P1H2S'
126
 
    >>> # Weeks can not be combined with anything else
127
 
    >>> rfc3339_duration_to_delta("P1D2W")
128
 
    Traceback (most recent call last):
129
 
    ...
130
 
    ValueError: Invalid RFC 3339 duration: u'P1D2W'
131
 
    >>> rfc3339_duration_to_delta("P2W2H")
132
 
    Traceback (most recent call last):
133
 
    ...
134
 
    ValueError: Invalid RFC 3339 duration: u'P2W2H'
135
115
    """
136
116
 
137
117
    # Parsing an RFC 3339 duration with regular expressions is not
215
195
 
216
196
 
217
197
def string_to_delta(interval):
218
 
    """Parse a string and return a datetime.timedelta"""
 
198
    """Parse a string and return a datetime.timedelta
 
199
 
 
200
    >>> string_to_delta('7d')
 
201
    datetime.timedelta(7)
 
202
    >>> string_to_delta('60s')
 
203
    datetime.timedelta(0, 60)
 
204
    >>> string_to_delta('60m')
 
205
    datetime.timedelta(0, 3600)
 
206
    >>> string_to_delta('24h')
 
207
    datetime.timedelta(1)
 
208
    >>> string_to_delta('1w')
 
209
    datetime.timedelta(7)
 
210
    >>> string_to_delta('5m 30s')
 
211
    datetime.timedelta(0, 330)
 
212
    """
219
213
 
220
214
    try:
221
215
        return rfc3339_duration_to_delta(interval)
222
 
    except ValueError as e:
223
 
        log.warning("%s - Parsing as pre-1.6.1 interval instead",
224
 
                    ' '.join(e.args))
225
 
    return parse_pre_1_6_1_interval(interval)
226
 
 
227
 
 
228
 
def parse_pre_1_6_1_interval(interval):
229
 
    """Parse an interval string as documented by Mandos before 1.6.1,
230
 
    and return a datetime.timedelta
231
 
 
232
 
    >>> parse_pre_1_6_1_interval('7d')
233
 
    datetime.timedelta(7)
234
 
    >>> parse_pre_1_6_1_interval('60s')
235
 
    datetime.timedelta(0, 60)
236
 
    >>> parse_pre_1_6_1_interval('60m')
237
 
    datetime.timedelta(0, 3600)
238
 
    >>> parse_pre_1_6_1_interval('24h')
239
 
    datetime.timedelta(1)
240
 
    >>> parse_pre_1_6_1_interval('1w')
241
 
    datetime.timedelta(7)
242
 
    >>> parse_pre_1_6_1_interval('5m 30s')
243
 
    datetime.timedelta(0, 330)
244
 
    >>> parse_pre_1_6_1_interval('')
245
 
    datetime.timedelta(0)
246
 
    >>> # Ignore unknown characters, allow any order and repetitions
247
 
    >>> parse_pre_1_6_1_interval('2dxy7zz11y3m5m')
248
 
    datetime.timedelta(2, 480, 18000)
249
 
 
250
 
    """
 
216
    except ValueError:
 
217
        pass
251
218
 
252
219
    value = datetime.timedelta(0)
253
220
    regexp = re.compile(r"(\d+)([dsmhw]?)")
268
235
    return value
269
236
 
270
237
 
271
 
## Classes for commands.
272
 
 
273
 
# Abstract classes first
274
 
class Command(object):
275
 
    """Abstract class for commands"""
276
 
    def run(self, mandos, clients):
277
 
        """Normal commands should implement run_on_one_client(), but
278
 
        commands which want to operate on all clients at the same time
279
 
        can override this run() method instead."""
280
 
        self.mandos = mandos
281
 
        for client in clients:
282
 
            self.run_on_one_client(client)
283
 
 
284
 
class PrintCmd(Command):
285
 
    """Abstract class for commands printing client details"""
286
 
    all_keywords = ("Name", "Enabled", "Timeout", "LastCheckedOK",
287
 
                    "Created", "Interval", "Host", "KeyID",
288
 
                    "Fingerprint", "CheckerRunning", "LastEnabled",
289
 
                    "ApprovalPending", "ApprovedByDefault",
290
 
                    "LastApprovalRequest", "ApprovalDelay",
291
 
                    "ApprovalDuration", "Checker", "ExtendedTimeout",
292
 
                    "Expires", "LastCheckerStatus")
293
 
    def run(self, mandos, clients):
294
 
        print(self.output(clients))
295
 
 
296
 
class PropertyCmd(Command):
297
 
    """Abstract class for Actions for setting one client property"""
298
 
    def run_on_one_client(self, client):
299
 
        """Set the Client's D-Bus property"""
300
 
        client.Set(client_interface, self.property, self.value_to_set,
301
 
                   dbus_interface=dbus.PROPERTIES_IFACE)
302
 
 
303
 
class ValueArgumentMixIn(object):
304
 
    """Mixin class for commands taking a value as argument"""
305
 
    def __init__(self, value):
306
 
        self.value_to_set = value
307
 
 
308
 
class MillisecondsValueArgumentMixIn(ValueArgumentMixIn):
309
 
    """Mixin class for commands taking a value argument as
310
 
    milliseconds."""
311
 
    @property
312
 
    def value_to_set(self):
313
 
        return self._vts
314
 
    @value_to_set.setter
315
 
    def value_to_set(self, value):
316
 
        """When setting, convert value to a datetime.timedelta"""
317
 
        self._vts = string_to_delta(value).total_seconds() * 1000
318
 
 
319
 
# Actual (non-abstract) command classes
320
 
 
321
 
class PrintTableCmd(PrintCmd):
322
 
    def __init__(self, verbose=False):
323
 
        self.verbose = verbose
324
 
 
325
 
    def output(self, clients):
326
 
        if self.verbose:
327
 
            keywords = self.all_keywords
328
 
        else:
329
 
            keywords = ("Name", "Enabled", "Timeout", "LastCheckedOK")
330
 
        return str(self.TableOfClients(clients.values(), keywords))
331
 
 
332
 
    class TableOfClients(object):
333
 
        tableheaders = {
334
 
            "Name": "Name",
335
 
            "Enabled": "Enabled",
336
 
            "Timeout": "Timeout",
337
 
            "LastCheckedOK": "Last Successful Check",
338
 
            "LastApprovalRequest": "Last Approval Request",
339
 
            "Created": "Created",
340
 
            "Interval": "Interval",
341
 
            "Host": "Host",
342
 
            "Fingerprint": "Fingerprint",
343
 
            "KeyID": "Key ID",
344
 
            "CheckerRunning": "Check Is Running",
345
 
            "LastEnabled": "Last Enabled",
346
 
            "ApprovalPending": "Approval Is Pending",
347
 
            "ApprovedByDefault": "Approved By Default",
348
 
            "ApprovalDelay": "Approval Delay",
349
 
            "ApprovalDuration": "Approval Duration",
350
 
            "Checker": "Checker",
351
 
            "ExtendedTimeout": "Extended Timeout",
352
 
            "Expires": "Expires",
353
 
            "LastCheckerStatus": "Last Checker Status",
354
 
        }
355
 
 
356
 
        def __init__(self, clients, keywords, tableheaders=None):
357
 
            self.clients = clients
358
 
            self.keywords = keywords
359
 
            if tableheaders is not None:
360
 
                self.tableheaders = tableheaders
361
 
 
362
 
        def __str__(self):
363
 
            return "\n".join(self.rows())
364
 
 
365
 
        if sys.version_info.major == 2:
366
 
            __unicode__ = __str__
367
 
            def __str__(self):
368
 
                return str(self).encode(locale.getpreferredencoding())
369
 
 
370
 
        def rows(self):
371
 
            format_string = self.row_formatting_string()
372
 
            rows = [self.header_line(format_string)]
373
 
            rows.extend(self.client_line(client, format_string)
374
 
                        for client in self.clients)
375
 
            return rows
376
 
 
377
 
        def row_formatting_string(self):
378
 
            "Format string used to format table rows"
379
 
            return " ".join("{{{key}:{width}}}".format(
380
 
                width=max(len(self.tableheaders[key]),
381
 
                          *(len(self.string_from_client(client, key))
382
 
                            for client in self.clients)),
383
 
                key=key)
384
 
                            for key in self.keywords)
385
 
 
386
 
        def string_from_client(self, client, key):
387
 
            return self.valuetostring(client[key], key)
388
 
 
389
 
        @staticmethod
390
 
        def valuetostring(value, keyword):
391
 
            if isinstance(value, dbus.Boolean):
392
 
                return "Yes" if value else "No"
393
 
            if keyword in ("Timeout", "Interval", "ApprovalDelay",
394
 
                           "ApprovalDuration", "ExtendedTimeout"):
395
 
                return milliseconds_to_string(value)
396
 
            return str(value)
397
 
 
398
 
        def header_line(self, format_string):
399
 
            return format_string.format(**self.tableheaders)
400
 
 
401
 
        def client_line(self, client, format_string):
402
 
            return format_string.format(
403
 
                **{key: self.string_from_client(client, key)
404
 
                   for key in self.keywords})
405
 
 
406
 
 
407
 
 
408
 
class DumpJSONCmd(PrintCmd):
409
 
    def output(self, clients):
410
 
        data = {client["Name"]:
411
 
                {key: self.dbus_boolean_to_bool(client[key])
412
 
                 for key in self.all_keywords}
413
 
                for client in clients.values()}
414
 
        return json.dumps(data, indent=4, separators=(',', ': '))
415
 
    @staticmethod
416
 
    def dbus_boolean_to_bool(value):
417
 
        if isinstance(value, dbus.Boolean):
418
 
            value = bool(value)
419
 
        return value
420
 
 
421
 
class IsEnabledCmd(Command):
422
 
    def run_on_one_client(self, client):
423
 
        if self.is_enabled(client):
424
 
            sys.exit(0)
425
 
        sys.exit(1)
426
 
    def is_enabled(self, client):
427
 
        return client.Get(client_interface, "Enabled",
428
 
                          dbus_interface=dbus.PROPERTIES_IFACE)
429
 
 
430
 
class RemoveCmd(Command):
431
 
    def run_on_one_client(self, client):
432
 
        self.mandos.RemoveClient(client.__dbus_object_path__)
433
 
 
434
 
class ApproveCmd(Command):
435
 
    def run_on_one_client(self, client):
436
 
        client.Approve(dbus.Boolean(True),
437
 
                       dbus_interface=client_interface)
438
 
 
439
 
class DenyCmd(Command):
440
 
    def run_on_one_client(self, client):
441
 
        client.Approve(dbus.Boolean(False),
442
 
                       dbus_interface=client_interface)
443
 
 
444
 
class EnableCmd(PropertyCmd):
445
 
    property = "Enabled"
446
 
    value_to_set = dbus.Boolean(True)
447
 
 
448
 
class DisableCmd(PropertyCmd):
449
 
    property = "Enabled"
450
 
    value_to_set = dbus.Boolean(False)
451
 
 
452
 
class BumpTimeoutCmd(PropertyCmd):
453
 
    property = "LastCheckedOK"
454
 
    value_to_set = ""
455
 
 
456
 
class StartCheckerCmd(PropertyCmd):
457
 
    property = "CheckerRunning"
458
 
    value_to_set = dbus.Boolean(True)
459
 
 
460
 
class StopCheckerCmd(PropertyCmd):
461
 
    property = "CheckerRunning"
462
 
    value_to_set = dbus.Boolean(False)
463
 
 
464
 
class ApproveByDefaultCmd(PropertyCmd):
465
 
    property = "ApprovedByDefault"
466
 
    value_to_set = dbus.Boolean(True)
467
 
 
468
 
class DenyByDefaultCmd(PropertyCmd):
469
 
    property = "ApprovedByDefault"
470
 
    value_to_set = dbus.Boolean(False)
471
 
 
472
 
class SetCheckerCmd(PropertyCmd, ValueArgumentMixIn):
473
 
    property = "Checker"
474
 
 
475
 
class SetHostCmd(PropertyCmd, ValueArgumentMixIn):
476
 
    property = "Host"
477
 
 
478
 
class SetSecretCmd(PropertyCmd, ValueArgumentMixIn):
479
 
    property = "Secret"
480
 
 
481
 
class SetTimeoutCmd(PropertyCmd, MillisecondsValueArgumentMixIn):
482
 
    property = "Timeout"
483
 
 
484
 
class SetExtendedTimeoutCmd(PropertyCmd,
485
 
                            MillisecondsValueArgumentMixIn):
486
 
    property = "ExtendedTimeout"
487
 
 
488
 
class SetIntervalCmd(PropertyCmd, MillisecondsValueArgumentMixIn):
489
 
    property = "Interval"
490
 
 
491
 
class SetApprovalDelayCmd(PropertyCmd,
492
 
                          MillisecondsValueArgumentMixIn):
493
 
    property = "ApprovalDelay"
494
 
 
495
 
class SetApprovalDurationCmd(PropertyCmd,
496
 
                             MillisecondsValueArgumentMixIn):
497
 
    property = "ApprovalDuration"
 
238
def print_clients(clients, keywords):
 
239
    def valuetostring(value, keyword):
 
240
        if type(value) is dbus.Boolean:
 
241
            return "Yes" if value else "No"
 
242
        if keyword in ("Timeout", "Interval", "ApprovalDelay",
 
243
                       "ApprovalDuration", "ExtendedTimeout"):
 
244
            return milliseconds_to_string(value)
 
245
        return str(value)
 
246
 
 
247
    # Create format string to print table rows
 
248
    format_string = " ".join("{{{key}:{width}}}".format(
 
249
        width=max(len(tablewords[key]),
 
250
                  max(len(valuetostring(client[key], key))
 
251
                      for client in clients)),
 
252
        key=key)
 
253
                             for key in keywords)
 
254
    # Print header line
 
255
    print(format_string.format(**tablewords))
 
256
    for client in clients:
 
257
        print(format_string
 
258
              .format(**{key: valuetostring(client[key], key)
 
259
                         for key in keywords}))
 
260
 
498
261
 
499
262
def has_actions(options):
500
263
    return any((options.enable,
517
280
                options.deny))
518
281
 
519
282
 
520
 
def commands_and_clients_from_options(args=None):
521
 
    if args is None:
522
 
        args=sys.argv[1:]
 
283
def main():
523
284
    parser = argparse.ArgumentParser()
524
285
    parser.add_argument("--version", action="version",
525
286
                        version="%(prog)s {}".format(version),
530
291
                        help="Print all fields")
531
292
    parser.add_argument("-j", "--dump-json", action="store_true",
532
293
                        help="Dump client data in JSON format")
533
 
    enable_disable = parser.add_mutually_exclusive_group()
534
 
    enable_disable.add_argument("-e", "--enable", action="store_true",
535
 
                                help="Enable client")
536
 
    enable_disable.add_argument("-d", "--disable",
537
 
                                action="store_true",
538
 
                                help="disable client")
 
294
    parser.add_argument("-e", "--enable", action="store_true",
 
295
                        help="Enable client")
 
296
    parser.add_argument("-d", "--disable", action="store_true",
 
297
                        help="disable client")
539
298
    parser.add_argument("-b", "--bump-timeout", action="store_true",
540
299
                        help="Bump timeout for client")
541
 
    start_stop_checker = parser.add_mutually_exclusive_group()
542
 
    start_stop_checker.add_argument("--start-checker",
543
 
                                    action="store_true",
544
 
                                    help="Start checker for client")
545
 
    start_stop_checker.add_argument("--stop-checker",
546
 
                                    action="store_true",
547
 
                                    help="Stop checker for client")
 
300
    parser.add_argument("--start-checker", action="store_true",
 
301
                        help="Start checker for client")
 
302
    parser.add_argument("--stop-checker", action="store_true",
 
303
                        help="Stop checker for client")
548
304
    parser.add_argument("-V", "--is-enabled", action="store_true",
549
305
                        help="Check if client is enabled")
550
306
    parser.add_argument("-r", "--remove", action="store_true",
557
313
                        help="Set extended timeout for client")
558
314
    parser.add_argument("-i", "--interval",
559
315
                        help="Set checker interval for client")
560
 
    approve_deny_default = parser.add_mutually_exclusive_group()
561
 
    approve_deny_default.add_argument(
562
 
        "--approve-by-default", action="store_true",
563
 
        default=None, dest="approved_by_default",
564
 
        help="Set client to be approved by default")
565
 
    approve_deny_default.add_argument(
566
 
        "--deny-by-default", action="store_false",
567
 
        dest="approved_by_default",
568
 
        help="Set client to be denied by default")
 
316
    parser.add_argument("--approve-by-default", action="store_true",
 
317
                        default=None, dest="approved_by_default",
 
318
                        help="Set client to be approved by default")
 
319
    parser.add_argument("--deny-by-default", action="store_false",
 
320
                        dest="approved_by_default",
 
321
                        help="Set client to be denied by default")
569
322
    parser.add_argument("--approval-delay",
570
323
                        help="Set delay before client approve/deny")
571
324
    parser.add_argument("--approval-duration",
574
327
    parser.add_argument("-s", "--secret",
575
328
                        type=argparse.FileType(mode="rb"),
576
329
                        help="Set password blob (file) for client")
577
 
    approve_deny = parser.add_mutually_exclusive_group()
578
 
    approve_deny.add_argument(
579
 
        "-A", "--approve", action="store_true",
580
 
        help="Approve any current client request")
581
 
    approve_deny.add_argument("-D", "--deny", action="store_true",
582
 
                              help="Deny any current client request")
 
330
    parser.add_argument("-A", "--approve", action="store_true",
 
331
                        help="Approve any current client request")
 
332
    parser.add_argument("-D", "--deny", action="store_true",
 
333
                        help="Deny any current client request")
583
334
    parser.add_argument("--check", action="store_true",
584
335
                        help="Run self-test")
585
336
    parser.add_argument("client", nargs="*", help="Client name")
586
 
    options = parser.parse_args(args=args)
 
337
    options = parser.parse_args()
587
338
 
588
339
    if has_actions(options) and not (options.client or options.all):
589
340
        parser.error("Options require clients names or --all.")
594
345
        parser.error("--dump-json can only be used alone.")
595
346
    if options.all and not has_actions(options):
596
347
        parser.error("--all requires an action.")
597
 
    if options.is_enabled and len(options.client) > 1:
598
 
            parser.error("--is-enabled requires exactly one client")
599
 
 
600
 
    commands = []
601
 
 
602
 
    if options.dump_json:
603
 
        commands.append(DumpJSONCmd())
604
 
 
605
 
    if options.enable:
606
 
        commands.append(EnableCmd())
607
 
 
608
 
    if options.disable:
609
 
        commands.append(DisableCmd())
610
 
 
611
 
    if options.bump_timeout:
612
 
        commands.append(BumpTimeoutCmd(options.bump_timeout))
613
 
 
614
 
    if options.start_checker:
615
 
        commands.append(StartCheckerCmd())
616
 
 
617
 
    if options.stop_checker:
618
 
        commands.append(StopCheckerCmd())
619
 
 
620
 
    if options.is_enabled:
621
 
        commands.append(IsEnabledCmd())
622
 
 
623
 
    if options.remove:
624
 
        commands.append(RemoveCmd())
625
 
 
626
 
    if options.checker is not None:
627
 
        commands.append(SetCheckerCmd())
628
 
 
629
 
    if options.timeout is not None:
630
 
        commands.append(SetTimeoutCmd(options.timeout))
631
 
 
632
 
    if options.extended_timeout:
633
 
        commands.append(
634
 
            SetExtendedTimeoutCmd(options.extended_timeout))
635
 
 
636
 
    if options.interval is not None:
637
 
        command.append(SetIntervalCmd(options.interval))
638
 
 
639
 
    if options.approved_by_default is not None:
640
 
        if options.approved_by_default:
641
 
            command.append(ApproveByDefaultCmd())
642
 
        else:
643
 
            command.append(DenyByDefaultCmd())
644
 
 
645
 
    if options.approval_delay is not None:
646
 
        command.append(SetApprovalDelayCmd(options.approval_delay))
647
 
 
648
 
    if options.approval_duration is not None:
649
 
        command.append(
650
 
            SetApprovalDurationCmd(options.approval_duration))
651
 
 
652
 
    if options.host is not None:
653
 
        command.append(SetHostCmd(options.host))
654
 
 
655
 
    if options.secret is not None:
656
 
        command.append(SetSecretCmd(options.secret))
657
 
 
658
 
    if options.approve:
659
 
        commands.append(ApproveCmd())
660
 
 
661
 
    if options.deny:
662
 
        commands.append(DenyCmd())
663
 
 
664
 
    # If no command option has been given, show table of clients,
665
 
    # optionally verbosely
666
 
    if not commands:
667
 
        commands.append(PrintTableCmd(verbose=options.verbose))
668
 
 
669
 
    return commands, options.client
670
 
 
671
 
 
672
 
def main():
673
 
    commands, clientnames = commands_and_clients_from_options()
674
348
 
675
349
    try:
676
350
        bus = dbus.SystemBus()
677
351
        mandos_dbus_objc = bus.get_object(busname, server_path)
678
352
    except dbus.exceptions.DBusException:
679
 
        log.critical("Could not connect to Mandos server")
 
353
        print("Could not connect to Mandos server", file=sys.stderr)
680
354
        sys.exit(1)
681
355
 
682
356
    mandos_serv = dbus.Interface(mandos_dbus_objc,
684
358
    mandos_serv_object_manager = dbus.Interface(
685
359
        mandos_dbus_objc, dbus_interface=dbus.OBJECT_MANAGER_IFACE)
686
360
 
687
 
    # Filter out log message from dbus module
688
 
    dbus_logger = logging.getLogger("dbus.proxies")
689
 
    class NullFilter(logging.Filter):
690
 
        def filter(self, record):
691
 
            return False
692
 
    dbus_filter = NullFilter()
693
 
    dbus_logger.addFilter(dbus_filter)
 
361
    # block stderr since dbus library prints to stderr
 
362
    null = os.open(os.path.devnull, os.O_RDWR)
 
363
    stderrcopy = os.dup(sys.stderr.fileno())
 
364
    os.dup2(null, sys.stderr.fileno())
 
365
    os.close(null)
694
366
    try:
695
367
        try:
696
368
            mandos_clients = {path: ifs_and_props[client_interface]
699
371
                              .GetManagedObjects().items()
700
372
                              if client_interface in ifs_and_props}
701
373
        finally:
702
 
            # restore dbus logger
703
 
            dbus_logger.removeFilter(dbus_filter)
 
374
            # restore stderr
 
375
            os.dup2(stderrcopy, sys.stderr.fileno())
 
376
            os.close(stderrcopy)
704
377
    except dbus.exceptions.DBusException as e:
705
 
        log.critical("Failed to access Mandos server through D-Bus:"
706
 
                     "\n%s", e)
 
378
        print("Access denied: "
 
379
              "Accessing mandos server through D-Bus: {}".format(e),
 
380
              file=sys.stderr)
707
381
        sys.exit(1)
708
382
 
709
383
    # Compile dict of (clients: properties) to process
710
384
    clients = {}
711
385
 
712
 
    if not clientnames:
 
386
    if options.all or not options.client:
713
387
        clients = {bus.get_object(busname, path): properties
714
388
                   for path, properties in mandos_clients.items()}
715
389
    else:
716
 
        for name in clientnames:
 
390
        for name in options.client:
717
391
            for path, client in mandos_clients.items():
718
392
                if client["Name"] == name:
719
393
                    client_objc = bus.get_object(busname, path)
720
394
                    clients[client_objc] = client
721
395
                    break
722
396
            else:
723
 
                log.critical("Client not found on server: %r", name)
 
397
                print("Client not found on server: {!r}"
 
398
                      .format(name), file=sys.stderr)
724
399
                sys.exit(1)
725
400
 
726
 
    # Run all commands on clients
727
 
    for command in commands:
728
 
        command.run(mandos_serv, clients)
 
401
    if not has_actions(options) and clients:
 
402
        if options.verbose or options.dump_json:
 
403
            keywords = ("Name", "Enabled", "Timeout", "LastCheckedOK",
 
404
                        "Created", "Interval", "Host", "KeyID",
 
405
                        "Fingerprint", "CheckerRunning",
 
406
                        "LastEnabled", "ApprovalPending",
 
407
                        "ApprovedByDefault", "LastApprovalRequest",
 
408
                        "ApprovalDelay", "ApprovalDuration",
 
409
                        "Checker", "ExtendedTimeout", "Expires",
 
410
                        "LastCheckerStatus")
 
411
        else:
 
412
            keywords = defaultkeywords
 
413
 
 
414
        if options.dump_json:
 
415
            json.dump({client["Name"]: {key:
 
416
                                        bool(client[key])
 
417
                                        if isinstance(client[key],
 
418
                                                      dbus.Boolean)
 
419
                                        else client[key]
 
420
                                        for key in keywords}
 
421
                       for client in clients.values()},
 
422
                      fp=sys.stdout, indent=4,
 
423
                      separators=(',', ': '))
 
424
            print()
 
425
        else:
 
426
            print_clients(clients.values(), keywords)
 
427
    else:
 
428
        # Process each client in the list by all selected options
 
429
        for client in clients:
 
430
 
 
431
            def set_client_prop(prop, value):
 
432
                """Set a Client D-Bus property"""
 
433
                client.Set(client_interface, prop, value,
 
434
                           dbus_interface=dbus.PROPERTIES_IFACE)
 
435
 
 
436
            def set_client_prop_ms(prop, value):
 
437
                """Set a Client D-Bus property, converted
 
438
                from a string to milliseconds."""
 
439
                set_client_prop(prop,
 
440
                                string_to_delta(value).total_seconds()
 
441
                                * 1000)
 
442
 
 
443
            if options.remove:
 
444
                mandos_serv.RemoveClient(client.__dbus_object_path__)
 
445
            if options.enable:
 
446
                set_client_prop("Enabled", dbus.Boolean(True))
 
447
            if options.disable:
 
448
                set_client_prop("Enabled", dbus.Boolean(False))
 
449
            if options.bump_timeout:
 
450
                set_client_prop("LastCheckedOK", "")
 
451
            if options.start_checker:
 
452
                set_client_prop("CheckerRunning", dbus.Boolean(True))
 
453
            if options.stop_checker:
 
454
                set_client_prop("CheckerRunning", dbus.Boolean(False))
 
455
            if options.is_enabled:
 
456
                if client.Get(client_interface, "Enabled",
 
457
                              dbus_interface=dbus.PROPERTIES_IFACE):
 
458
                    sys.exit(0)
 
459
                else:
 
460
                    sys.exit(1)
 
461
            if options.checker is not None:
 
462
                set_client_prop("Checker", options.checker)
 
463
            if options.host is not None:
 
464
                set_client_prop("Host", options.host)
 
465
            if options.interval is not None:
 
466
                set_client_prop_ms("Interval", options.interval)
 
467
            if options.approval_delay is not None:
 
468
                set_client_prop_ms("ApprovalDelay",
 
469
                                   options.approval_delay)
 
470
            if options.approval_duration is not None:
 
471
                set_client_prop_ms("ApprovalDuration",
 
472
                                   options.approval_duration)
 
473
            if options.timeout is not None:
 
474
                set_client_prop_ms("Timeout", options.timeout)
 
475
            if options.extended_timeout is not None:
 
476
                set_client_prop_ms("ExtendedTimeout",
 
477
                                   options.extended_timeout)
 
478
            if options.secret is not None:
 
479
                set_client_prop("Secret",
 
480
                                dbus.ByteArray(options.secret.read()))
 
481
            if options.approved_by_default is not None:
 
482
                set_client_prop("ApprovedByDefault",
 
483
                                dbus.Boolean(options
 
484
                                             .approved_by_default))
 
485
            if options.approve:
 
486
                client.Approve(dbus.Boolean(True),
 
487
                               dbus_interface=client_interface)
 
488
            elif options.deny:
 
489
                client.Approve(dbus.Boolean(False),
 
490
                               dbus_interface=client_interface)
729
491
 
730
492
 
731
493
class Test_milliseconds_to_string(unittest.TestCase):
741
503
        self.assertEqual(milliseconds_to_string(900), "00:00:00")
742
504
        self.assertEqual(milliseconds_to_string(1900), "00:00:01")
743
505
 
744
 
class Test_string_to_delta(unittest.TestCase):
745
 
    def test_handles_basic_rfc3339(self):
746
 
        self.assertEqual(string_to_delta("PT2H"),
747
 
                         datetime.timedelta(0, 7200))
748
 
    def test_falls_back_to_pre_1_6_1_with_warning(self):
749
 
        # assertLogs only exists in Python 3.4
750
 
        if hasattr(self, "assertLogs"):
751
 
            with self.assertLogs(log, logging.WARNING):
752
 
                value = string_to_delta("2h")
753
 
        else:
754
 
            class WarningFilter(logging.Filter):
755
 
                """Don't show, but record the presence of, warnings"""
756
 
                def filter(self, record):
757
 
                    is_warning = record.levelno >= logging.WARNING
758
 
                    self.found = is_warning or getattr(self, "found",
759
 
                                                       False)
760
 
                    return not is_warning
761
 
            warning_filter = WarningFilter()
762
 
            log.addFilter(warning_filter)
763
 
            try:
764
 
                value = string_to_delta("2h")
765
 
            finally:
766
 
                log.removeFilter(warning_filter)
767
 
            self.assertTrue(getattr(warning_filter, "found", False))
768
 
        self.assertEqual(value, datetime.timedelta(0, 7200))
769
 
 
770
 
 
771
 
class TestCmd(unittest.TestCase):
772
 
    """Abstract class for tests of command classes"""
773
 
    def setUp(self):
774
 
        testcase = self
775
 
        class MockClient(object):
776
 
            def __init__(self, name, **attributes):
777
 
                self.__dbus_object_path__ = "objpath_{}".format(name)
778
 
                self.attributes = attributes
779
 
                self.attributes["Name"] = name
780
 
            def Set(interface, property, value,
781
 
                    properties_interface):
782
 
                testcase.assertEqual(interface, client_interface)
783
 
                testcase.assertEqual(properties_interface,
784
 
                                     dbus.PROPERTIES_IFACE)
785
 
                self.attributes[property] = value
786
 
            def Get(interface, property, properties_interface):
787
 
                testcase.assertEqual(interface, client_interface)
788
 
                testcase.assertEqual(properties_interface,
789
 
                                     dbus.PROPERTIES_IFACE)
790
 
                return self.attributes[property]
791
 
            def __getitem__(self, key):
792
 
                return self.attributes[key]
793
 
        self.clients = collections.OrderedDict([
794
 
            ("foo",
795
 
             MockClient(
796
 
                 "foo",
797
 
                 KeyID=("92ed150794387c03ce684574b1139a65"
798
 
                        "94a34f895daaaf09fd8ea90a27cddb12"),
799
 
                 Secret=b"secret",
800
 
                 Host="foo.example.org",
801
 
                 Enabled=dbus.Boolean(True),
802
 
                 Timeout=300000,
803
 
                 LastCheckedOK="2019-02-03T00:00:00",
804
 
                 Created="2019-01-02T00:00:00",
805
 
                 Interval=120000,
806
 
                 Fingerprint=("778827225BA7DE539C5A"
807
 
                              "7CFA59CFF7CDBD9A5920"),
808
 
                 CheckerRunning=dbus.Boolean(False),
809
 
                 LastEnabled="2019-01-03T00:00:00",
810
 
                 ApprovalPending=dbus.Boolean(False),
811
 
                 ApprovedByDefault=dbus.Boolean(True),
812
 
                 LastApprovalRequest="",
813
 
                 ApprovalDelay=0,
814
 
                 ApprovalDuration=1000,
815
 
                 Checker="fping -q -- %(host)s",
816
 
                 ExtendedTimeout=900000,
817
 
                 Expires="2019-02-04T00:00:00",
818
 
                 LastCheckerStatus=0)),
819
 
            ("barbar",
820
 
             MockClient(
821
 
                 "barbar",
822
 
                 KeyID=("0558568eedd67d622f5c83b35a115f79"
823
 
                        "6ab612cff5ad227247e46c2b020f441c"),
824
 
                 Secret=b"secretbar",
825
 
                 Host="192.0.2.3",
826
 
                 Enabled=dbus.Boolean(True),
827
 
                 Timeout=300000,
828
 
                 LastCheckedOK="2019-02-04T00:00:00",
829
 
                 Created="2019-01-03T00:00:00",
830
 
                 Interval=120000,
831
 
                 Fingerprint=("3E393AEAEFB84C7E89E2"
832
 
                              "F547B3A107558FCA3A27"),
833
 
                 CheckerRunning=dbus.Boolean(True),
834
 
                 LastEnabled="2019-01-04T00:00:00",
835
 
                 ApprovalPending=dbus.Boolean(False),
836
 
                 ApprovedByDefault=dbus.Boolean(False),
837
 
                 LastApprovalRequest="2019-01-03T00:00:00",
838
 
                 ApprovalDelay=30000,
839
 
                 ApprovalDuration=1000,
840
 
                 Checker=":",
841
 
                 ExtendedTimeout=900000,
842
 
                 Expires="2019-02-05T00:00:00",
843
 
                 LastCheckerStatus=-2)),
844
 
            ])
845
 
 
846
 
class TestPrintTableCmd(TestCmd):
847
 
    def test_normal(self):
848
 
        output = PrintTableCmd().output(self.clients)
849
 
        expected_output = """
850
 
Name   Enabled Timeout  Last Successful Check
851
 
foo    Yes     00:05:00 2019-02-03T00:00:00  
852
 
barbar Yes     00:05:00 2019-02-04T00:00:00  
853
 
"""[1:-1]
854
 
        self.assertEqual(output, expected_output)
855
 
    def test_verbose(self):
856
 
        output = PrintTableCmd(verbose=True).output(self.clients)
857
 
        expected_output = """
858
 
Name   Enabled Timeout  Last Successful Check Created             Interval Host            Key ID                                                           Fingerprint                              Check Is Running Last Enabled        Approval Is Pending Approved By Default Last Approval Request Approval Delay Approval Duration Checker              Extended Timeout Expires             Last Checker Status
859
 
foo    Yes     00:05:00 2019-02-03T00:00:00   2019-01-02T00:00:00 00:02:00 foo.example.org 92ed150794387c03ce684574b1139a6594a34f895daaaf09fd8ea90a27cddb12 778827225BA7DE539C5A7CFA59CFF7CDBD9A5920 No               2019-01-03T00:00:00 No                  Yes                                       00:00:00       00:00:01          fping -q -- %(host)s 00:15:00         2019-02-04T00:00:00 0                  
860
 
barbar Yes     00:05:00 2019-02-04T00:00:00   2019-01-03T00:00:00 00:02:00 192.0.2.3       0558568eedd67d622f5c83b35a115f796ab612cff5ad227247e46c2b020f441c 3E393AEAEFB84C7E89E2F547B3A107558FCA3A27 Yes              2019-01-04T00:00:00 No                  No                  2019-01-03T00:00:00   00:00:30       00:00:01          :                    00:15:00         2019-02-05T00:00:00 -2                 
861
 
"""[1:-1]
862
 
        self.assertEqual(output, expected_output)
863
 
    def test_one_client(self):
864
 
        output = PrintTableCmd().output({"foo": self.clients["foo"]})
865
 
        expected_output = """
866
 
Name Enabled Timeout  Last Successful Check
867
 
foo  Yes     00:05:00 2019-02-03T00:00:00  
868
 
"""[1:-1]
869
 
        self.assertEqual(output, expected_output)
870
 
 
871
 
 
872
506
 
873
507
def should_only_run_tests():
874
508
    parser = argparse.ArgumentParser(add_help=False)