612
412
"ApprovalDelay", "ApprovalDuration",
613
413
"Checker", "ExtendedTimeout", "Expires",
614
414
"LastCheckerStatus")
616
def run(self, clients, bus=None, mandos=None):
617
print(self.output(clients.values()))
619
def output(self, clients):
620
raise NotImplementedError()
623
class DumpJSON(Output):
624
def output(self, clients):
625
data = {client["Name"]:
626
{key: self.dbus_boolean_to_bool(client[key])
627
for key in self.all_keywords}
628
for client in clients}
629
return json.dumps(data, indent=4, separators=(',', ': '))
632
def dbus_boolean_to_bool(value):
633
if isinstance(value, dbus.Boolean):
638
class PrintTable(Output):
639
def __init__(self, verbose=False):
640
self.verbose = verbose
642
def output(self, clients):
643
default_keywords = ("Name", "Enabled", "Timeout",
645
keywords = default_keywords
647
keywords = self.all_keywords
648
return str(self.TableOfClients(clients, keywords))
650
class TableOfClients(object):
653
"Enabled": "Enabled",
654
"Timeout": "Timeout",
655
"LastCheckedOK": "Last Successful Check",
656
"LastApprovalRequest": "Last Approval Request",
657
"Created": "Created",
658
"Interval": "Interval",
660
"Fingerprint": "Fingerprint",
662
"CheckerRunning": "Check Is Running",
663
"LastEnabled": "Last Enabled",
664
"ApprovalPending": "Approval Is Pending",
665
"ApprovedByDefault": "Approved By Default",
666
"ApprovalDelay": "Approval Delay",
667
"ApprovalDuration": "Approval Duration",
668
"Checker": "Checker",
669
"ExtendedTimeout": "Extended Timeout",
670
"Expires": "Expires",
671
"LastCheckerStatus": "Last Checker Status",
674
def __init__(self, clients, keywords):
675
self.clients = clients
676
self.keywords = keywords
679
return "\n".join(self.rows())
681
if sys.version_info.major == 2:
682
__unicode__ = __str__
684
return str(self).encode(
685
locale.getpreferredencoding())
688
format_string = self.row_formatting_string()
689
rows = [self.header_line(format_string)]
690
rows.extend(self.client_line(client, format_string)
691
for client in self.clients)
694
def row_formatting_string(self):
695
"Format string used to format table rows"
696
return " ".join("{{{key}:{width}}}".format(
697
width=max(len(self.tableheaders[key]),
698
*(len(self.string_from_client(client,
700
for client in self.clients)),
702
for key in self.keywords)
704
def string_from_client(self, client, key):
705
return self.valuetostring(client[key], key)
708
def valuetostring(cls, value, keyword):
709
if isinstance(value, dbus.Boolean):
710
return "Yes" if value else "No"
711
if keyword in ("Timeout", "Interval", "ApprovalDelay",
712
"ApprovalDuration", "ExtendedTimeout"):
713
return cls.milliseconds_to_string(value)
716
def header_line(self, format_string):
717
return format_string.format(**self.tableheaders)
719
def client_line(self, client, format_string):
720
return format_string.format(
721
**{key: self.string_from_client(client, key)
722
for key in self.keywords})
725
def milliseconds_to_string(ms):
726
td = datetime.timedelta(0, 0, 0, ms)
727
return ("{days}{hours:02}:{minutes:02}:{seconds:02}"
728
.format(days="{}T".format(td.days)
730
hours=td.seconds // 3600,
731
minutes=(td.seconds % 3600) // 60,
732
seconds=td.seconds % 60))
735
class Property(Base):
736
"Abstract class for Actions for setting one client property"
738
def run_on_one_client(self, client, properties):
739
"""Set the Client's D-Bus property"""
740
log.debug("D-Bus: %s:%s:%s.Set(%r, %r, %r)", dbus_busname,
741
client.__dbus_object_path__,
742
dbus.PROPERTIES_IFACE, client_dbus_interface,
743
self.propname, self.value_to_set
744
if not isinstance(self.value_to_set,
746
else bool(self.value_to_set))
747
client.Set(client_dbus_interface, self.propname,
749
dbus_interface=dbus.PROPERTIES_IFACE)
753
raise NotImplementedError()
756
class Enable(Property):
758
value_to_set = dbus.Boolean(True)
761
class Disable(Property):
763
value_to_set = dbus.Boolean(False)
766
class BumpTimeout(Property):
767
propname = "LastCheckedOK"
771
class StartChecker(Property):
772
propname = "CheckerRunning"
773
value_to_set = dbus.Boolean(True)
776
class StopChecker(Property):
777
propname = "CheckerRunning"
778
value_to_set = dbus.Boolean(False)
781
class ApproveByDefault(Property):
782
propname = "ApprovedByDefault"
783
value_to_set = dbus.Boolean(True)
786
class DenyByDefault(Property):
787
propname = "ApprovedByDefault"
788
value_to_set = dbus.Boolean(False)
791
class PropertyValue(Property):
792
"Abstract class for Property recieving a value as argument"
793
def __init__(self, value):
794
self.value_to_set = value
797
class SetChecker(PropertyValue):
801
class SetHost(PropertyValue):
805
class SetSecret(PropertyValue):
809
def value_to_set(self):
813
def value_to_set(self, value):
814
"""When setting, read data from supplied file object"""
815
self._vts = value.read()
819
class MillisecondsPropertyValueArgument(PropertyValue):
820
"""Abstract class for PropertyValue taking a value argument as
821
a datetime.timedelta() but should store it as milliseconds."""
824
def value_to_set(self):
828
def value_to_set(self, value):
829
"When setting, convert value from a datetime.timedelta"
830
self._vts = int(round(value.total_seconds() * 1000))
833
class SetTimeout(MillisecondsPropertyValueArgument):
837
class SetExtendedTimeout(MillisecondsPropertyValueArgument):
838
propname = "ExtendedTimeout"
841
class SetInterval(MillisecondsPropertyValueArgument):
842
propname = "Interval"
845
class SetApprovalDelay(MillisecondsPropertyValueArgument):
846
propname = "ApprovalDelay"
849
class SetApprovalDuration(MillisecondsPropertyValueArgument):
850
propname = "ApprovalDuration"
854
class TestCaseWithAssertLogs(unittest.TestCase):
855
"""unittest.TestCase.assertLogs only exists in Python 3.4"""
857
if not hasattr(unittest.TestCase, "assertLogs"):
858
@contextlib.contextmanager
859
def assertLogs(self, logger, level=logging.INFO):
860
capturing_handler = self.CapturingLevelHandler(level)
861
old_level = logger.level
862
old_propagate = logger.propagate
863
logger.addHandler(capturing_handler)
864
logger.setLevel(level)
865
logger.propagate = False
867
yield capturing_handler.watcher
869
logger.propagate = old_propagate
870
logger.removeHandler(capturing_handler)
871
logger.setLevel(old_level)
872
self.assertGreater(len(capturing_handler.watcher.records),
875
class CapturingLevelHandler(logging.Handler):
876
def __init__(self, level, *args, **kwargs):
877
logging.Handler.__init__(self, *args, **kwargs)
878
self.watcher = self.LoggingWatcher([], [])
879
def emit(self, record):
880
self.watcher.records.append(record)
881
self.watcher.output.append(self.format(record))
883
LoggingWatcher = collections.namedtuple("LoggingWatcher",
888
class Test_string_to_delta(TestCaseWithAssertLogs):
889
# Just test basic RFC 3339 functionality here, the doc string for
890
# rfc3339_duration_to_delta() already has more comprehensive
891
# tests, which is run by doctest.
893
def test_rfc3339_zero_seconds(self):
894
self.assertEqual(datetime.timedelta(),
895
string_to_delta("PT0S"))
897
def test_rfc3339_zero_days(self):
898
self.assertEqual(datetime.timedelta(), string_to_delta("P0D"))
900
def test_rfc3339_one_second(self):
901
self.assertEqual(datetime.timedelta(0, 1),
902
string_to_delta("PT1S"))
904
def test_rfc3339_two_hours(self):
905
self.assertEqual(datetime.timedelta(0, 7200),
906
string_to_delta("PT2H"))
908
def test_falls_back_to_pre_1_6_1_with_warning(self):
909
with self.assertLogs(log, logging.WARNING):
910
value = string_to_delta("2h")
911
self.assertEqual(datetime.timedelta(0, 7200), value)
914
class Test_check_option_syntax(unittest.TestCase):
916
self.parser = argparse.ArgumentParser()
917
add_command_line_options(self.parser)
919
def test_actions_requires_client_or_all(self):
920
for action, value in self.actions.items():
921
options = self.parser.parse_args()
922
setattr(options, action, value)
923
with self.assertParseError():
924
self.check_option_syntax(options)
926
# This mostly corresponds to the definition from has_actions() in
927
# check_option_syntax()
929
# The actual values set here are not that important, but we do
930
# at least stick to the correct types, even though they are
934
"bump_timeout": True,
935
"start_checker": True,
936
"stop_checker": True,
940
"timeout": datetime.timedelta(),
941
"extended_timeout": datetime.timedelta(),
942
"interval": datetime.timedelta(),
943
"approved_by_default": True,
944
"approval_delay": datetime.timedelta(),
945
"approval_duration": datetime.timedelta(),
947
"secret": io.BytesIO(b"x"),
952
@contextlib.contextmanager
953
def assertParseError(self):
954
with self.assertRaises(SystemExit) as e:
955
with self.redirect_stderr_to_devnull():
957
# Exit code from argparse is guaranteed to be "2". Reference:
958
# https://docs.python.org/3/library
959
# /argparse.html#exiting-methods
960
self.assertEqual(2, e.exception.code)
963
@contextlib.contextmanager
964
def redirect_stderr_to_devnull():
965
null = os.open(os.path.devnull, os.O_RDWR)
966
stderrcopy = os.dup(sys.stderr.fileno())
967
os.dup2(null, sys.stderr.fileno())
973
os.dup2(stderrcopy, sys.stderr.fileno())
976
def check_option_syntax(self, options):
977
check_option_syntax(self.parser, options)
979
def test_actions_all_conflicts_with_verbose(self):
980
for action, value in self.actions.items():
981
options = self.parser.parse_args()
982
setattr(options, action, value)
984
options.verbose = True
985
with self.assertParseError():
986
self.check_option_syntax(options)
988
def test_actions_with_client_conflicts_with_verbose(self):
989
for action, value in self.actions.items():
990
options = self.parser.parse_args()
991
setattr(options, action, value)
992
options.verbose = True
993
options.client = ["foo"]
994
with self.assertParseError():
995
self.check_option_syntax(options)
997
def test_dump_json_conflicts_with_verbose(self):
998
options = self.parser.parse_args()
999
options.dump_json = True
1000
options.verbose = True
1001
with self.assertParseError():
1002
self.check_option_syntax(options)
1004
def test_dump_json_conflicts_with_action(self):
1005
for action, value in self.actions.items():
1006
options = self.parser.parse_args()
1007
setattr(options, action, value)
1008
options.dump_json = True
1009
with self.assertParseError():
1010
self.check_option_syntax(options)
1012
def test_all_can_not_be_alone(self):
1013
options = self.parser.parse_args()
1015
with self.assertParseError():
1016
self.check_option_syntax(options)
1018
def test_all_is_ok_with_any_action(self):
1019
for action, value in self.actions.items():
1020
options = self.parser.parse_args()
1021
setattr(options, action, value)
1023
self.check_option_syntax(options)
1025
def test_any_action_is_ok_with_one_client(self):
1026
for action, value in self.actions.items():
1027
options = self.parser.parse_args()
1028
setattr(options, action, value)
1029
options.client = ["foo"]
1030
self.check_option_syntax(options)
1032
def test_one_client_with_all_actions_except_is_enabled(self):
1033
options = self.parser.parse_args()
1034
for action, value in self.actions.items():
1035
if action == "is_enabled":
1037
setattr(options, action, value)
1038
options.client = ["foo"]
1039
self.check_option_syntax(options)
1041
def test_two_clients_with_all_actions_except_is_enabled(self):
1042
options = self.parser.parse_args()
1043
for action, value in self.actions.items():
1044
if action == "is_enabled":
1046
setattr(options, action, value)
1047
options.client = ["foo", "barbar"]
1048
self.check_option_syntax(options)
1050
def test_two_clients_are_ok_with_actions_except_is_enabled(self):
1051
for action, value in self.actions.items():
1052
if action == "is_enabled":
1054
options = self.parser.parse_args()
1055
setattr(options, action, value)
1056
options.client = ["foo", "barbar"]
1057
self.check_option_syntax(options)
1059
def test_is_enabled_fails_without_client(self):
1060
options = self.parser.parse_args()
1061
options.is_enabled = True
1062
with self.assertParseError():
1063
self.check_option_syntax(options)
1065
def test_is_enabled_fails_with_two_clients(self):
1066
options = self.parser.parse_args()
1067
options.is_enabled = True
1068
options.client = ["foo", "barbar"]
1069
with self.assertParseError():
1070
self.check_option_syntax(options)
1072
def test_remove_can_only_be_combined_with_action_deny(self):
1073
for action, value in self.actions.items():
1074
if action in {"remove", "deny"}:
1076
options = self.parser.parse_args()
1077
setattr(options, action, value)
1079
options.remove = True
1080
with self.assertParseError():
1081
self.check_option_syntax(options)
1084
class Test_get_mandos_dbus_object(TestCaseWithAssertLogs):
1085
def test_calls_and_returns_get_object_on_bus(self):
1086
class MockBus(object):
1088
def get_object(mockbus_self, busname, dbus_path):
1089
# Note that "self" is still the testcase instance,
1090
# this MockBus instance is in "mockbus_self".
1091
self.assertEqual(dbus_busname, busname)
1092
self.assertEqual(server_dbus_path, dbus_path)
1093
mockbus_self.called = True
1096
mockbus = get_mandos_dbus_object(bus=MockBus())
1097
self.assertIsInstance(mockbus, MockBus)
1098
self.assertTrue(mockbus.called)
1100
def test_logs_and_exits_on_dbus_error(self):
1101
class MockBusFailing(object):
1102
def get_object(self, busname, dbus_path):
1103
raise dbus.exceptions.DBusException("Test")
1105
with self.assertLogs(log, logging.CRITICAL):
1106
with self.assertRaises(SystemExit) as e:
1107
bus = get_mandos_dbus_object(bus=MockBusFailing())
1109
if isinstance(e.exception.code, int):
1110
self.assertNotEqual(0, e.exception.code)
1112
self.assertIsNotNone(e.exception.code)
1115
class Test_get_managed_objects(TestCaseWithAssertLogs):
1116
def test_calls_and_returns_GetManagedObjects(self):
1117
managed_objects = {"/clients/foo": { "Name": "foo"}}
1118
class MockObjectManager(object):
1119
def GetManagedObjects(self):
1120
return managed_objects
1121
retval = get_managed_objects(MockObjectManager())
1122
self.assertDictEqual(managed_objects, retval)
1124
def test_logs_and_exits_on_dbus_error(self):
1125
dbus_logger = logging.getLogger("dbus.proxies")
1127
class MockObjectManagerFailing(object):
1128
def GetManagedObjects(self):
1129
dbus_logger.error("Test")
1130
raise dbus.exceptions.DBusException("Test")
1132
class CountingHandler(logging.Handler):
1134
def emit(self, record):
1137
counting_handler = CountingHandler()
1139
dbus_logger.addHandler(counting_handler)
1142
with self.assertLogs(log, logging.CRITICAL) as watcher:
1143
with self.assertRaises(SystemExit) as e:
1144
get_managed_objects(MockObjectManagerFailing())
1146
dbus_logger.removeFilter(counting_handler)
1148
# Make sure the dbus logger was suppressed
1149
self.assertEqual(0, counting_handler.count)
1151
# Test that the dbus_logger still works
1152
with self.assertLogs(dbus_logger, logging.ERROR):
1153
dbus_logger.error("Test")
1155
if isinstance(e.exception.code, int):
1156
self.assertNotEqual(0, e.exception.code)
1158
self.assertIsNotNone(e.exception.code)
1161
class Test_commands_from_options(unittest.TestCase):
1163
self.parser = argparse.ArgumentParser()
1164
add_command_line_options(self.parser)
1166
def test_is_enabled(self):
1167
self.assert_command_from_args(["--is-enabled", "foo"],
1170
def assert_command_from_args(self, args, command_cls,
1172
"""Assert that parsing ARGS should result in an instance of
1173
COMMAND_CLS with (optionally) all supplied attributes (CMD_ATTRS)."""
1174
options = self.parser.parse_args(args)
1175
check_option_syntax(self.parser, options)
1176
commands = commands_from_options(options)
1177
self.assertEqual(1, len(commands))
1178
command = commands[0]
1179
self.assertIsInstance(command, command_cls)
1180
for key, value in cmd_attrs.items():
1181
self.assertEqual(value, getattr(command, key))
1183
def test_is_enabled_short(self):
1184
self.assert_command_from_args(["-V", "foo"],
1187
def test_approve(self):
1188
self.assert_command_from_args(["--approve", "foo"],
1191
def test_approve_short(self):
1192
self.assert_command_from_args(["-A", "foo"], command.Approve)
1194
def test_deny(self):
1195
self.assert_command_from_args(["--deny", "foo"], command.Deny)
1197
def test_deny_short(self):
1198
self.assert_command_from_args(["-D", "foo"], command.Deny)
1200
def test_remove(self):
1201
self.assert_command_from_args(["--remove", "foo"],
1204
def test_deny_before_remove(self):
1205
options = self.parser.parse_args(["--deny", "--remove",
1207
check_option_syntax(self.parser, options)
1208
commands = commands_from_options(options)
1209
self.assertEqual(2, len(commands))
1210
self.assertIsInstance(commands[0], command.Deny)
1211
self.assertIsInstance(commands[1], command.Remove)
1213
def test_deny_before_remove_reversed(self):
1214
options = self.parser.parse_args(["--remove", "--deny",
1216
check_option_syntax(self.parser, options)
1217
commands = commands_from_options(options)
1218
self.assertEqual(2, len(commands))
1219
self.assertIsInstance(commands[0], command.Deny)
1220
self.assertIsInstance(commands[1], command.Remove)
1222
def test_remove_short(self):
1223
self.assert_command_from_args(["-r", "foo"], command.Remove)
1225
def test_dump_json(self):
1226
self.assert_command_from_args(["--dump-json"],
1229
def test_enable(self):
1230
self.assert_command_from_args(["--enable", "foo"],
1233
def test_enable_short(self):
1234
self.assert_command_from_args(["-e", "foo"], command.Enable)
1236
def test_disable(self):
1237
self.assert_command_from_args(["--disable", "foo"],
1240
def test_disable_short(self):
1241
self.assert_command_from_args(["-d", "foo"], command.Disable)
1243
def test_bump_timeout(self):
1244
self.assert_command_from_args(["--bump-timeout", "foo"],
1245
command.BumpTimeout)
1247
def test_bump_timeout_short(self):
1248
self.assert_command_from_args(["-b", "foo"],
1249
command.BumpTimeout)
1251
def test_start_checker(self):
1252
self.assert_command_from_args(["--start-checker", "foo"],
1253
command.StartChecker)
1255
def test_stop_checker(self):
1256
self.assert_command_from_args(["--stop-checker", "foo"],
1257
command.StopChecker)
1259
def test_approve_by_default(self):
1260
self.assert_command_from_args(["--approve-by-default", "foo"],
1261
command.ApproveByDefault)
1263
def test_deny_by_default(self):
1264
self.assert_command_from_args(["--deny-by-default", "foo"],
1265
command.DenyByDefault)
1267
def test_checker(self):
1268
self.assert_command_from_args(["--checker", ":", "foo"],
1272
def test_checker_empty(self):
1273
self.assert_command_from_args(["--checker", "", "foo"],
1277
def test_checker_short(self):
1278
self.assert_command_from_args(["-c", ":", "foo"],
1282
def test_host(self):
1283
self.assert_command_from_args(["--host", "foo.example.org",
1284
"foo"], command.SetHost,
1285
value_to_set="foo.example.org")
1287
def test_host_short(self):
1288
self.assert_command_from_args(["-H", "foo.example.org",
1289
"foo"], command.SetHost,
1290
value_to_set="foo.example.org")
1292
def test_secret_devnull(self):
1293
self.assert_command_from_args(["--secret", os.path.devnull,
1294
"foo"], command.SetSecret,
1297
def test_secret_tempfile(self):
1298
with tempfile.NamedTemporaryFile(mode="r+b") as f:
1299
value = b"secret\0xyzzy\nbar"
1302
self.assert_command_from_args(["--secret", f.name,
1303
"foo"], command.SetSecret,
1306
def test_secret_devnull_short(self):
1307
self.assert_command_from_args(["-s", os.path.devnull, "foo"],
1311
def test_secret_tempfile_short(self):
1312
with tempfile.NamedTemporaryFile(mode="r+b") as f:
1313
value = b"secret\0xyzzy\nbar"
1316
self.assert_command_from_args(["-s", f.name, "foo"],
1320
def test_timeout(self):
1321
self.assert_command_from_args(["--timeout", "PT5M", "foo"],
1323
value_to_set=300000)
1325
def test_timeout_short(self):
1326
self.assert_command_from_args(["-t", "PT5M", "foo"],
1328
value_to_set=300000)
1330
def test_extended_timeout(self):
1331
self.assert_command_from_args(["--extended-timeout", "PT15M",
1333
command.SetExtendedTimeout,
1334
value_to_set=900000)
1336
def test_interval(self):
1337
self.assert_command_from_args(["--interval", "PT2M", "foo"],
1338
command.SetInterval,
1339
value_to_set=120000)
1341
def test_interval_short(self):
1342
self.assert_command_from_args(["-i", "PT2M", "foo"],
1343
command.SetInterval,
1344
value_to_set=120000)
1346
def test_approval_delay(self):
1347
self.assert_command_from_args(["--approval-delay", "PT30S",
1349
command.SetApprovalDelay,
1352
def test_approval_duration(self):
1353
self.assert_command_from_args(["--approval-duration", "PT1S",
1355
command.SetApprovalDuration,
1358
def test_print_table(self):
1359
self.assert_command_from_args([], command.PrintTable,
1362
def test_print_table_verbose(self):
1363
self.assert_command_from_args(["--verbose"],
1367
def test_print_table_verbose_short(self):
1368
self.assert_command_from_args(["-v"], command.PrintTable,
1372
class TestCommand(unittest.TestCase):
1373
"""Abstract class for tests of command classes"""
1377
class MockClient(object):
1378
def __init__(self, name, **attributes):
1379
self.__dbus_object_path__ = "/clients/{}".format(name)
1380
self.attributes = attributes
1381
self.attributes["Name"] = name
1383
def Set(self, interface, propname, value, dbus_interface):
1384
testcase.assertEqual(client_dbus_interface, interface)
1385
testcase.assertEqual(dbus.PROPERTIES_IFACE,
1387
self.attributes[propname] = value
1388
def Approve(self, approve, dbus_interface):
1389
testcase.assertEqual(client_dbus_interface,
1391
self.calls.append(("Approve", (approve,
1393
self.client = MockClient(
1395
KeyID=("92ed150794387c03ce684574b1139a65"
1396
"94a34f895daaaf09fd8ea90a27cddb12"),
1398
Host="foo.example.org",
1399
Enabled=dbus.Boolean(True),
1401
LastCheckedOK="2019-02-03T00:00:00",
1402
Created="2019-01-02T00:00:00",
1404
Fingerprint=("778827225BA7DE539C5A"
1405
"7CFA59CFF7CDBD9A5920"),
1406
CheckerRunning=dbus.Boolean(False),
1407
LastEnabled="2019-01-03T00:00:00",
1408
ApprovalPending=dbus.Boolean(False),
1409
ApprovedByDefault=dbus.Boolean(True),
1410
LastApprovalRequest="",
1412
ApprovalDuration=1000,
1413
Checker="fping -q -- %(host)s",
1414
ExtendedTimeout=900000,
1415
Expires="2019-02-04T00:00:00",
1416
LastCheckerStatus=0)
1417
self.other_client = MockClient(
1419
KeyID=("0558568eedd67d622f5c83b35a115f79"
1420
"6ab612cff5ad227247e46c2b020f441c"),
1421
Secret=b"secretbar",
1423
Enabled=dbus.Boolean(True),
1425
LastCheckedOK="2019-02-04T00:00:00",
1426
Created="2019-01-03T00:00:00",
1428
Fingerprint=("3E393AEAEFB84C7E89E2"
1429
"F547B3A107558FCA3A27"),
1430
CheckerRunning=dbus.Boolean(True),
1431
LastEnabled="2019-01-04T00:00:00",
1432
ApprovalPending=dbus.Boolean(False),
1433
ApprovedByDefault=dbus.Boolean(False),
1434
LastApprovalRequest="2019-01-03T00:00:00",
1435
ApprovalDelay=30000,
1436
ApprovalDuration=93785000,
1438
ExtendedTimeout=900000,
1439
Expires="2019-02-05T00:00:00",
1440
LastCheckerStatus=-2)
1441
self.clients = collections.OrderedDict(
1443
("/clients/foo", self.client.attributes),
1444
("/clients/barbar", self.other_client.attributes),
1446
self.one_client = {"/clients/foo": self.client.attributes}
1452
def get_object(client_bus_name, path):
1453
self.assertEqual(dbus_busname, client_bus_name)
1455
# Note: "self" here is the TestCmd instance, not
1456
# the Bus instance, since this is a static method!
1457
"/clients/foo": self.client,
1458
"/clients/barbar": self.other_client,
1463
class TestBaseCommands(TestCommand):
1465
def test_IsEnabled_exits_successfully(self):
1466
with self.assertRaises(SystemExit) as e:
1467
command.IsEnabled().run(self.one_client)
1468
if e.exception.code is not None:
1469
self.assertEqual(0, e.exception.code)
1471
self.assertIsNone(e.exception.code)
1473
def test_IsEnabled_exits_with_failure(self):
1474
self.client.attributes["Enabled"] = dbus.Boolean(False)
1475
with self.assertRaises(SystemExit) as e:
1476
command.IsEnabled().run(self.one_client)
1477
if isinstance(e.exception.code, int):
1478
self.assertNotEqual(0, e.exception.code)
1480
self.assertIsNotNone(e.exception.code)
1482
def test_Approve(self):
1483
command.Approve().run(self.clients, self.bus)
1484
for clientpath in self.clients:
1485
client = self.bus.get_object(dbus_busname, clientpath)
1486
self.assertIn(("Approve", (True, client_dbus_interface)),
1489
def test_Deny(self):
1490
command.Deny().run(self.clients, self.bus)
1491
for clientpath in self.clients:
1492
client = self.bus.get_object(dbus_busname, clientpath)
1493
self.assertIn(("Approve", (False, client_dbus_interface)),
1496
def test_Remove(self):
1497
class MockMandos(object):
1500
def RemoveClient(self, dbus_path):
1501
self.calls.append(("RemoveClient", (dbus_path,)))
1502
mandos = MockMandos()
1503
command.Remove().run(self.clients, self.bus, mandos)
1504
for clientpath in self.clients:
1505
self.assertIn(("RemoveClient", (clientpath,)),
1511
"KeyID": ("92ed150794387c03ce684574b1139a65"
1512
"94a34f895daaaf09fd8ea90a27cddb12"),
1513
"Host": "foo.example.org",
1516
"LastCheckedOK": "2019-02-03T00:00:00",
1517
"Created": "2019-01-02T00:00:00",
1519
"Fingerprint": ("778827225BA7DE539C5A"
1520
"7CFA59CFF7CDBD9A5920"),
1521
"CheckerRunning": False,
1522
"LastEnabled": "2019-01-03T00:00:00",
1523
"ApprovalPending": False,
1524
"ApprovedByDefault": True,
1525
"LastApprovalRequest": "",
1527
"ApprovalDuration": 1000,
1528
"Checker": "fping -q -- %(host)s",
1529
"ExtendedTimeout": 900000,
1530
"Expires": "2019-02-04T00:00:00",
1531
"LastCheckerStatus": 0,
1535
"KeyID": ("0558568eedd67d622f5c83b35a115f79"
1536
"6ab612cff5ad227247e46c2b020f441c"),
1537
"Host": "192.0.2.3",
1540
"LastCheckedOK": "2019-02-04T00:00:00",
1541
"Created": "2019-01-03T00:00:00",
1543
"Fingerprint": ("3E393AEAEFB84C7E89E2"
1544
"F547B3A107558FCA3A27"),
1545
"CheckerRunning": True,
1546
"LastEnabled": "2019-01-04T00:00:00",
1547
"ApprovalPending": False,
1548
"ApprovedByDefault": False,
1549
"LastApprovalRequest": "2019-01-03T00:00:00",
1550
"ApprovalDelay": 30000,
1551
"ApprovalDuration": 93785000,
1553
"ExtendedTimeout": 900000,
1554
"Expires": "2019-02-05T00:00:00",
1555
"LastCheckerStatus": -2,
1559
def test_DumpJSON_normal(self):
1560
output = command.DumpJSON().output(self.clients.values())
1561
json_data = json.loads(output)
1562
self.assertDictEqual(self.expected_json, json_data)
1564
def test_DumpJSON_one_client(self):
1565
output = command.DumpJSON().output(self.one_client.values())
1566
json_data = json.loads(output)
1567
expected_json = {"foo": self.expected_json["foo"]}
1568
self.assertDictEqual(expected_json, json_data)
1570
def test_PrintTable_normal(self):
1571
output = command.PrintTable().output(self.clients.values())
1572
expected_output = "\n".join((
1573
"Name Enabled Timeout Last Successful Check",
1574
"foo Yes 00:05:00 2019-02-03T00:00:00 ",
1575
"barbar Yes 00:05:00 2019-02-04T00:00:00 ",
1577
self.assertEqual(expected_output, output)
1579
def test_PrintTable_verbose(self):
1580
output = command.PrintTable(verbose=True).output(
1581
self.clients.values())
1596
"Last Successful Check ",
1597
"2019-02-03T00:00:00 ",
1598
"2019-02-04T00:00:00 ",
1601
"2019-01-02T00:00:00 ",
1602
"2019-01-03T00:00:00 ",
1614
("92ed150794387c03ce684574b1139a6594a34f895daaaf09fd8"
1616
("0558568eedd67d622f5c83b35a115f796ab612cff5ad227247e"
1620
"778827225BA7DE539C5A7CFA59CFF7CDBD9A5920 ",
1621
"3E393AEAEFB84C7E89E2F547B3A107558FCA3A27 ",
1623
"Check Is Running ",
1628
"2019-01-03T00:00:00 ",
1629
"2019-01-04T00:00:00 ",
1631
"Approval Is Pending ",
1635
"Approved By Default ",
1639
"Last Approval Request ",
1641
"2019-01-03T00:00:00 ",
1647
"Approval Duration ",
1652
"fping -q -- %(host)s ",
1655
"Extended Timeout ",
1660
"2019-02-04T00:00:00 ",
1661
"2019-02-05T00:00:00 ",
1663
"Last Checker Status",
1668
num_lines = max(len(rows) for rows in columns)
1669
expected_output = "\n".join("".join(rows[line]
1670
for rows in columns)
1671
for line in range(num_lines))
1672
self.assertEqual(expected_output, output)
1674
def test_PrintTable_one_client(self):
1675
output = command.PrintTable().output(self.one_client.values())
1676
expected_output = "\n".join((
1677
"Name Enabled Timeout Last Successful Check",
1678
"foo Yes 00:05:00 2019-02-03T00:00:00 ",
1680
self.assertEqual(expected_output, output)
1683
class TestPropertyCmd(TestCommand):
1684
"""Abstract class for tests of command.Property classes"""
1686
if not hasattr(self, "command"):
1688
values_to_get = getattr(self, "values_to_get",
1690
for value_to_set, value_to_get in zip(self.values_to_set,
1692
for clientpath in self.clients:
1693
client = self.bus.get_object(dbus_busname, clientpath)
1694
old_value = client.attributes[self.propname]
1695
client.attributes[self.propname] = self.Unique()
1696
self.run_command(value_to_set, self.clients)
1697
for clientpath in self.clients:
1698
client = self.bus.get_object(dbus_busname, clientpath)
1699
value = client.attributes[self.propname]
1700
self.assertNotIsInstance(value, self.Unique)
1701
self.assertEqual(value_to_get, value)
1703
class Unique(object):
1704
"""Class for objects which exist only to be unique objects,
1705
since unittest.mock.sentinel only exists in Python 3.3"""
1707
def run_command(self, value, clients):
1708
self.command().run(clients, self.bus)
1711
class TestEnableCmd(TestPropertyCmd):
1712
command = command.Enable
1713
propname = "Enabled"
1714
values_to_set = [dbus.Boolean(True)]
1717
class TestDisableCmd(TestPropertyCmd):
1718
command = command.Disable
1719
propname = "Enabled"
1720
values_to_set = [dbus.Boolean(False)]
1723
class TestBumpTimeoutCmd(TestPropertyCmd):
1724
command = command.BumpTimeout
1725
propname = "LastCheckedOK"
1726
values_to_set = [""]
1729
class TestStartCheckerCmd(TestPropertyCmd):
1730
command = command.StartChecker
1731
propname = "CheckerRunning"
1732
values_to_set = [dbus.Boolean(True)]
1735
class TestStopCheckerCmd(TestPropertyCmd):
1736
command = command.StopChecker
1737
propname = "CheckerRunning"
1738
values_to_set = [dbus.Boolean(False)]
1741
class TestApproveByDefaultCmd(TestPropertyCmd):
1742
command = command.ApproveByDefault
1743
propname = "ApprovedByDefault"
1744
values_to_set = [dbus.Boolean(True)]
1747
class TestDenyByDefaultCmd(TestPropertyCmd):
1748
command = command.DenyByDefault
1749
propname = "ApprovedByDefault"
1750
values_to_set = [dbus.Boolean(False)]
1753
class TestPropertyValueCmd(TestPropertyCmd):
1754
"""Abstract class for tests of PropertyValueCmd classes"""
1757
if type(self) is TestPropertyValueCmd:
1759
return super(TestPropertyValueCmd, self).runTest()
1761
def run_command(self, value, clients):
1762
self.command(value).run(clients, self.bus)
1765
class TestSetCheckerCmd(TestPropertyValueCmd):
1766
command = command.SetChecker
1767
propname = "Checker"
1768
values_to_set = ["", ":", "fping -q -- %s"]
1771
class TestSetHostCmd(TestPropertyValueCmd):
1772
command = command.SetHost
1774
values_to_set = ["192.0.2.3", "foo.example.org"]
1777
class TestSetSecretCmd(TestPropertyValueCmd):
1778
command = command.SetSecret
1780
values_to_set = [io.BytesIO(b""),
1781
io.BytesIO(b"secret\0xyzzy\nbar")]
1782
values_to_get = [b"", b"secret\0xyzzy\nbar"]
1785
class TestSetTimeoutCmd(TestPropertyValueCmd):
1786
command = command.SetTimeout
1787
propname = "Timeout"
1788
values_to_set = [datetime.timedelta(),
1789
datetime.timedelta(minutes=5),
1790
datetime.timedelta(seconds=1),
1791
datetime.timedelta(weeks=1),
1792
datetime.timedelta(weeks=52)]
1793
values_to_get = [0, 300000, 1000, 604800000, 31449600000]
1796
class TestSetExtendedTimeoutCmd(TestPropertyValueCmd):
1797
command = command.SetExtendedTimeout
1798
propname = "ExtendedTimeout"
1799
values_to_set = [datetime.timedelta(),
1800
datetime.timedelta(minutes=5),
1801
datetime.timedelta(seconds=1),
1802
datetime.timedelta(weeks=1),
1803
datetime.timedelta(weeks=52)]
1804
values_to_get = [0, 300000, 1000, 604800000, 31449600000]
1807
class TestSetIntervalCmd(TestPropertyValueCmd):
1808
command = command.SetInterval
1809
propname = "Interval"
1810
values_to_set = [datetime.timedelta(),
1811
datetime.timedelta(minutes=5),
1812
datetime.timedelta(seconds=1),
1813
datetime.timedelta(weeks=1),
1814
datetime.timedelta(weeks=52)]
1815
values_to_get = [0, 300000, 1000, 604800000, 31449600000]
1818
class TestSetApprovalDelayCmd(TestPropertyValueCmd):
1819
command = command.SetApprovalDelay
1820
propname = "ApprovalDelay"
1821
values_to_set = [datetime.timedelta(),
1822
datetime.timedelta(minutes=5),
1823
datetime.timedelta(seconds=1),
1824
datetime.timedelta(weeks=1),
1825
datetime.timedelta(weeks=52)]
1826
values_to_get = [0, 300000, 1000, 604800000, 31449600000]
1829
class TestSetApprovalDurationCmd(TestPropertyValueCmd):
1830
command = command.SetApprovalDuration
1831
propname = "ApprovalDuration"
1832
values_to_set = [datetime.timedelta(),
1833
datetime.timedelta(minutes=5),
1834
datetime.timedelta(seconds=1),
1835
datetime.timedelta(weeks=1),
1836
datetime.timedelta(weeks=52)]
1837
values_to_get = [0, 300000, 1000, 604800000, 31449600000]
1841
def should_only_run_tests():
1842
parser = argparse.ArgumentParser(add_help=False)
1843
parser.add_argument("--check", action='store_true')
1844
args, unknown_args = parser.parse_known_args()
1845
run_tests = args.check
1847
# Remove --check argument from sys.argv
1848
sys.argv[1:] = unknown_args
1851
# Add all tests from doctest strings
1852
def load_tests(loader, tests, none):
1854
tests.addTests(doctest.DocTestSuite())
416
keywords = defaultkeywords
418
if options.dump_json:
419
json.dump({client["Name"]: {key:
421
if isinstance(client[key],
425
for client in clients.values()},
426
fp=sys.stdout, indent=4,
427
separators=(',', ': '))
430
print_clients(clients.values(), keywords)
432
# Process each client in the list by all selected options
433
for client in clients:
435
def set_client_prop(prop, value):
436
"""Set a Client D-Bus property"""
437
client.Set(client_interface, prop, value,
438
dbus_interface=dbus.PROPERTIES_IFACE)
440
def set_client_prop_ms(prop, value):
441
"""Set a Client D-Bus property, converted
442
from a string to milliseconds."""
443
set_client_prop(prop,
444
string_to_delta(value).total_seconds()
448
mandos_serv.RemoveClient(client.__dbus_object_path__)
450
set_client_prop("Enabled", dbus.Boolean(True))
452
set_client_prop("Enabled", dbus.Boolean(False))
453
if options.bump_timeout:
454
set_client_prop("LastCheckedOK", "")
455
if options.start_checker:
456
set_client_prop("CheckerRunning", dbus.Boolean(True))
457
if options.stop_checker:
458
set_client_prop("CheckerRunning", dbus.Boolean(False))
459
if options.is_enabled:
460
if client.Get(client_interface, "Enabled",
461
dbus_interface=dbus.PROPERTIES_IFACE):
465
if options.checker is not None:
466
set_client_prop("Checker", options.checker)
467
if options.host is not None:
468
set_client_prop("Host", options.host)
469
if options.interval is not None:
470
set_client_prop_ms("Interval", options.interval)
471
if options.approval_delay is not None:
472
set_client_prop_ms("ApprovalDelay",
473
options.approval_delay)
474
if options.approval_duration is not None:
475
set_client_prop_ms("ApprovalDuration",
476
options.approval_duration)
477
if options.timeout is not None:
478
set_client_prop_ms("Timeout", options.timeout)
479
if options.extended_timeout is not None:
480
set_client_prop_ms("ExtendedTimeout",
481
options.extended_timeout)
482
if options.secret is not None:
483
set_client_prop("Secret",
484
dbus.ByteArray(options.secret.read()))
485
if options.approved_by_default is not None:
486
set_client_prop("ApprovedByDefault",
488
.approved_by_default))
490
client.Approve(dbus.Boolean(True),
491
dbus_interface=client_interface)
493
client.Approve(dbus.Boolean(False),
494
dbus_interface=client_interface)
1857
497
if __name__ == "__main__":
1859
if should_only_run_tests():
1860
# Call using ./tdd-python-script --check [--verbose]