/mandos/trunk

To get this branch, use:
bzr branch http://bzr.recompile.se/loggerhead/mandos/trunk

« back to all changes in this revision

Viewing changes to mandos-ctl

  • Committer: Teddy Hogeborn
  • Date: 2019-02-09 23:23:26 UTC
  • Revision ID: teddy@recompile.se-20190209232326-z1z2kzpgfixz7iaj
Add support for using raw public keys in TLS (RFC 7250)

Since GnuTLS removed support for OpenPGP keys in TLS (RFC 6091), and
no other library supports it, we have to change the protocol to use
something else.  We choose to use "raw public keys" (RFC 7250).  Since
we still use OpenPGP keys to decrypt the secret password, this means
that each client will have two keys: One OpenPGP key and one TLS
public/private key, and the key ID of the latter key is used to
identify clients instead of the fingerprint of the OpenPGP key.

Note that this code is still compatible with GnuTLS before version
3.6.0 (when OpenPGP key support was removed).  This commit merely adds
support for using raw pulic keys instead with GnuTLS 3.6.6. or later.

* DBUS-API (Signals/ClientNotFound): Change name of first parameter
                                     from "Fingerprint" to "KeyID".
  (Mandos Client Interface/Properties/KeyID): New.
* INSTALL: Document conflict with GnuTLS 3.6.0 (which removed OpenPGP
           key support) up until 3.6.6, when support for raw public
           keys was added.  Also document new dependency of client on
           "gnutls-bin" package (for certtool).
* Makefile (run-client): Depend on TLS key files, and also pass them
                         as arguments to client.
  (keydir/tls-privkey.pem, keydir/tls-pubkey.pem): New.
  (confdir/clients.conf): Add dependency on TLS public key.
  (purge-client): Add removal of TLS key files.
* clients.conf ([foo]/key_id, [bar]/key_id): New.
* debian/control (Source: mandos/Build-Depends): Also allow
                                                 libgnutls30 (>= 3.6.6)
  (Package: mandos/Depends): - '' -
  (Package: mandos/Description): Alter description to match new
                                 design.
  (Package: mandos-client/Description): - '' -
  (Package: mandos-client/Depends): Move "gnutls-bin | openssl" to
                                    here from "Recommends".
* debian/mandos-client.README.Debian: Add --tls-privkey and
                                      --tls-pubkey options to test
                                      command.
* debian/mandos-client.postinst (create_key): Renamed to "create_keys"
                                             (all callers changed),
                                             and also create TLS key.
* debian/mandos-client.postrm (purge): Also remove TLS key files.
* intro.xml (DESCRIPTION): Describe new dual-key design.
* mandos (GnuTLS): Define different functions depending on whether
                   support for raw public keys is detected.
  (Client.key_id): New attribute.
  (ClientDBus.KeyID_dbus_property): New method.
  (ProxyClient.__init__): Take new "key_id" parameter.
  (ClientHandler.handle): Use key IDs when using raw public keys and
                          use fingerprints when using OpenPGP keys.
  (ClientHandler.peer_certificate): Also handle raw public keys.
  (ClientHandler.key_id): New.
  (MandosServer.handle_ipc): Pass key ID over the pipe IPC.  Also
                             check for key ID matches when looking up
                             clients.
  (main): Default GnuTLS priority string depends on whether we are
          using raw public keys or not.  When unpickling clients, set
          key_id if not set in the pickle.
  (main/MandosDBusService.ClientNotFound): Change name of first
                                           parameter from
                                           "Fingerprint" to "KeyID".
* mandos-clients.conf.xml (OPTIONS): Document new "key_id" option.
  (OPTIONS/secret): Mention new key ID matchning.
  (EXPANSION/RUNTIME EXPANSION): Add new "key_id" option.
  (EXAMPLE): - '' -
* mandos-ctl (tablewords, main/keywords): Add new "KeyID" property.
* mandos-keygen: Create TLS key files.  New "--tls-keytype" (-T)
                 option.  Alter help text to be more clear about key
                 types.  When in password mode, also output "key_id"
                 option.
* mandos-keygen.xml (SYNOPSIS): Add new "--tls-keytype" (-T) option.
  (DESCRIPTION): Alter to match new dual-key design.
  (OVERVIEW): - '' -
  (FILES): Add TLS key files.
* mandos-options.xml (priority): Document new default priority string
                                 when using raw public keys.
* mandos.xml (NETWORK PROTOCOL): Describe new protocol using key ID.
  (BUGS): Remove issue about checking expire times of OpenPGP keys,
          since TLS public keys do not have expiration times.
  (SECURITY/CLIENT): Alter description to match new design.
  (SEE ALSO/GnuTLS): - '' -
  (SEE ALSO): Add reference to RFC 7250, and alter description of when
              RFC 6091 is used.
* overview.xml: Alter text to match new design.
* plugin-runner.xml (EXAMPLE): Add --tls-pubkey and --tls-privkey
                               options to mandos-client options.
* plugins.d/mandos-client.c: Use raw public keys when compiling with
                             supporting GnuTLS versions. Add new
                             "--tls-pubkey" and "--tls-privkey"
                             options (which do nothing if GnuTLS
                             library does not support raw public
                             keys).  Alter text throughout to reflect
                             new design.  Only generate new DH
                             parameters (based on size of OpenPGP key)
                             when using OpenPGP in TLS.  Default
                             GnuTLS priority string depends on whether
                             we are using raw public keys or not.
* plugins.d/mandos-client.xml (SYNOPSIS): Add new "--tls-privkey" (-t)
                                          and "--tls-pubkey" (-T)
                                          options.
  (DESCRIPTION): Describe new dual-key design.
  (OPTIONS): Document new "--tls-privkey" (-t) and "--tls-pubkey" (-T)
             options.
  (OPTIONS/--dh-bits): No longer necessarily depends on OpenPGP key
                       size.
  (FILES): Add default locations for TLS public and private key files.
  (EXAMPLE): Use new --tls-pubkey and --tls-privkey options.
  (SECURITY): Alter wording slightly to reflect new dual-key design.
  (SEE ALSO/GnuTLS): Alter description to match new design.
  (SEE ALSO): Add reference to RFC 7250, and alter description of when
              RFC 6091 is used.

Show diffs side-by-side

added added

removed removed

Lines of Context:
mandos-ctl
1
1
#!/usr/bin/python
2
 
# -*- mode: python; coding: utf-8; after-save-hook: (lambda () (let ((command (if (and (boundp 'tramp-file-name-structure) (string-match (car tramp-file-name-structure) (buffer-file-name))) (tramp-file-name-localname (tramp-dissect-file-name (buffer-file-name))) (buffer-file-name)))) (if (= (shell-command (format "%s --check" (shell-quote-argument command)) "*Test*") 0) (let ((w (get-buffer-window "*Test*"))) (if w (delete-window w)) (kill-buffer "*Test*")) (display-buffer "*Test*")))); -*-
 
2
# -*- mode: python; coding: utf-8 -*-
3
3
#
4
4
# Mandos Monitor - Control and monitor the Mandos server
5
5
#
6
 
# Copyright © 2008-2019 Teddy Hogeborn
7
 
# Copyright © 2008-2019 Björn Påhlsson
 
6
# Copyright © 2008-2018 Teddy Hogeborn
 
7
# Copyright © 2008-2018 Björn Påhlsson
8
8
#
9
9
# This file is part of Mandos.
10
10
#
40
40
import os
41
41
import collections
42
42
import json
43
 
import unittest
44
 
import logging
45
43
 
46
44
import dbus
47
45
 
48
 
# Show warnings by default
49
 
if not sys.warnoptions:
50
 
    import warnings
51
 
    warnings.simplefilter("default")
52
 
 
53
 
log = logging.getLogger(sys.argv[0])
54
 
logging.basicConfig(level="INFO", # Show info level messages
55
 
                    format="%(message)s") # Show basic log messages
56
 
 
57
 
logging.captureWarnings(True)   # Show warnings via the logging system
58
 
 
59
46
if sys.version_info.major == 2:
60
47
    str = unicode
61
48
 
62
49
locale.setlocale(locale.LC_ALL, "")
63
50
 
 
51
tablewords = {
 
52
    "Name": "Name",
 
53
    "Enabled": "Enabled",
 
54
    "Timeout": "Timeout",
 
55
    "LastCheckedOK": "Last Successful Check",
 
56
    "LastApprovalRequest": "Last Approval Request",
 
57
    "Created": "Created",
 
58
    "Interval": "Interval",
 
59
    "Host": "Host",
 
60
    "Fingerprint": "Fingerprint",
 
61
    "KeyID": "Key ID",
 
62
    "CheckerRunning": "Check Is Running",
 
63
    "LastEnabled": "Last Enabled",
 
64
    "ApprovalPending": "Approval Is Pending",
 
65
    "ApprovedByDefault": "Approved By Default",
 
66
    "ApprovalDelay": "Approval Delay",
 
67
    "ApprovalDuration": "Approval Duration",
 
68
    "Checker": "Checker",
 
69
    "ExtendedTimeout": "Extended Timeout",
 
70
    "Expires": "Expires",
 
71
    "LastCheckerStatus": "Last Checker Status",
 
72
}
 
73
defaultkeywords = ("Name", "Enabled", "Timeout", "LastCheckedOK")
64
74
domain = "se.recompile"
65
75
busname = domain + ".Mandos"
66
76
server_path = "/"
67
77
server_interface = domain + ".Mandos"
68
78
client_interface = domain + ".Mandos.Client"
69
 
version = "1.8.3"
 
79
version = "1.7.20"
70
80
 
71
81
 
72
82
try:
93
103
    datetime.timedelta(0, 60)
94
104
    >>> rfc3339_duration_to_delta("PT60M")
95
105
    datetime.timedelta(0, 3600)
96
 
    >>> rfc3339_duration_to_delta("P60M")
97
 
    datetime.timedelta(1680)
98
106
    >>> rfc3339_duration_to_delta("PT24H")
99
107
    datetime.timedelta(1)
100
108
    >>> rfc3339_duration_to_delta("P1W")
103
111
    datetime.timedelta(0, 330)
104
112
    >>> rfc3339_duration_to_delta("P1DT3M20S")
105
113
    datetime.timedelta(1, 200)
106
 
    >>> # Can not be empty:
107
 
    >>> rfc3339_duration_to_delta("")
108
 
    Traceback (most recent call last):
109
 
    ...
110
 
    ValueError: Invalid RFC 3339 duration: u''
111
 
    >>> # Must start with "P":
112
 
    >>> rfc3339_duration_to_delta("1D")
113
 
    Traceback (most recent call last):
114
 
    ...
115
 
    ValueError: Invalid RFC 3339 duration: u'1D'
116
 
    >>> # Must use correct order
117
 
    >>> rfc3339_duration_to_delta("PT1S2M")
118
 
    Traceback (most recent call last):
119
 
    ...
120
 
    ValueError: Invalid RFC 3339 duration: u'PT1S2M'
121
 
    >>> # Time needs time marker
122
 
    >>> rfc3339_duration_to_delta("P1H2S")
123
 
    Traceback (most recent call last):
124
 
    ...
125
 
    ValueError: Invalid RFC 3339 duration: u'P1H2S'
126
 
    >>> # Weeks can not be combined with anything else
127
 
    >>> rfc3339_duration_to_delta("P1D2W")
128
 
    Traceback (most recent call last):
129
 
    ...
130
 
    ValueError: Invalid RFC 3339 duration: u'P1D2W'
131
 
    >>> rfc3339_duration_to_delta("P2W2H")
132
 
    Traceback (most recent call last):
133
 
    ...
134
 
    ValueError: Invalid RFC 3339 duration: u'P2W2H'
135
114
    """
136
115
 
137
116
    # Parsing an RFC 3339 duration with regular expressions is not
215
194
 
216
195
 
217
196
def string_to_delta(interval):
218
 
    """Parse a string and return a datetime.timedelta"""
 
197
    """Parse a string and return a datetime.timedelta
 
198
 
 
199
    >>> string_to_delta('7d')
 
200
    datetime.timedelta(7)
 
201
    >>> string_to_delta('60s')
 
202
    datetime.timedelta(0, 60)
 
203
    >>> string_to_delta('60m')
 
204
    datetime.timedelta(0, 3600)
 
205
    >>> string_to_delta('24h')
 
206
    datetime.timedelta(1)
 
207
    >>> string_to_delta('1w')
 
208
    datetime.timedelta(7)
 
209
    >>> string_to_delta('5m 30s')
 
210
    datetime.timedelta(0, 330)
 
211
    """
219
212
 
220
213
    try:
221
214
        return rfc3339_duration_to_delta(interval)
222
 
    except ValueError as e:
223
 
        log.warning("%s - Parsing as pre-1.6.1 interval instead",
224
 
                    ' '.join(e.args))
225
 
    return parse_pre_1_6_1_interval(interval)
226
 
 
227
 
 
228
 
def parse_pre_1_6_1_interval(interval):
229
 
    """Parse an interval string as documented by Mandos before 1.6.1,
230
 
    and return a datetime.timedelta
231
 
 
232
 
    >>> parse_pre_1_6_1_interval('7d')
233
 
    datetime.timedelta(7)
234
 
    >>> parse_pre_1_6_1_interval('60s')
235
 
    datetime.timedelta(0, 60)
236
 
    >>> parse_pre_1_6_1_interval('60m')
237
 
    datetime.timedelta(0, 3600)
238
 
    >>> parse_pre_1_6_1_interval('24h')
239
 
    datetime.timedelta(1)
240
 
    >>> parse_pre_1_6_1_interval('1w')
241
 
    datetime.timedelta(7)
242
 
    >>> parse_pre_1_6_1_interval('5m 30s')
243
 
    datetime.timedelta(0, 330)
244
 
    >>> parse_pre_1_6_1_interval('')
245
 
    datetime.timedelta(0)
246
 
    >>> # Ignore unknown characters, allow any order and repetitions
247
 
    >>> parse_pre_1_6_1_interval('2dxy7zz11y3m5m')
248
 
    datetime.timedelta(2, 480, 18000)
249
 
 
250
 
    """
 
215
    except ValueError:
 
216
        pass
251
217
 
252
218
    value = datetime.timedelta(0)
253
219
    regexp = re.compile(r"(\d+)([dsmhw]?)")
268
234
    return value
269
235
 
270
236
 
271
 
class TableOfClients(object):
272
 
    tableheaders = {
273
 
        "Name": "Name",
274
 
        "Enabled": "Enabled",
275
 
        "Timeout": "Timeout",
276
 
        "LastCheckedOK": "Last Successful Check",
277
 
        "LastApprovalRequest": "Last Approval Request",
278
 
        "Created": "Created",
279
 
        "Interval": "Interval",
280
 
        "Host": "Host",
281
 
        "Fingerprint": "Fingerprint",
282
 
        "KeyID": "Key ID",
283
 
        "CheckerRunning": "Check Is Running",
284
 
        "LastEnabled": "Last Enabled",
285
 
        "ApprovalPending": "Approval Is Pending",
286
 
        "ApprovedByDefault": "Approved By Default",
287
 
        "ApprovalDelay": "Approval Delay",
288
 
        "ApprovalDuration": "Approval Duration",
289
 
        "Checker": "Checker",
290
 
        "ExtendedTimeout": "Extended Timeout",
291
 
        "Expires": "Expires",
292
 
        "LastCheckerStatus": "Last Checker Status",
293
 
    }
294
 
 
295
 
    def __init__(self, clients, keywords, tableheaders=None):
296
 
        self.clients = clients
297
 
        self.keywords = keywords
298
 
        if tableheaders is not None:
299
 
            self.tableheaders = tableheaders
300
 
 
301
 
    def __str__(self):
302
 
        return "\n".join(self.rows())
303
 
 
304
 
    if sys.version_info.major == 2:
305
 
        __unicode__ = __str__
306
 
        def __str__(self):
307
 
            return str(self).encode(locale.getpreferredencoding())
308
 
 
309
 
    def rows(self):
310
 
        format_string = self.row_formatting_string()
311
 
        rows = [self.header_line(format_string)]
312
 
        rows.extend(self.client_line(client, format_string)
313
 
                    for client in self.clients)
314
 
        return rows
315
 
 
316
 
    def row_formatting_string(self):
317
 
        "Format string used to format table rows"
318
 
        return " ".join("{{{key}:{width}}}".format(
319
 
            width=max(len(self.tableheaders[key]),
320
 
                      *(len(self.string_from_client(client, key))
321
 
                        for client in self.clients)),
322
 
            key=key)
323
 
                        for key in self.keywords)
324
 
 
325
 
    def string_from_client(self, client, key):
326
 
        return self.valuetostring(client[key], key)
327
 
 
328
 
    @staticmethod
 
237
def print_clients(clients, keywords):
329
238
    def valuetostring(value, keyword):
330
 
        if isinstance(value, dbus.Boolean):
 
239
        if type(value) is dbus.Boolean:
331
240
            return "Yes" if value else "No"
332
241
        if keyword in ("Timeout", "Interval", "ApprovalDelay",
333
242
                       "ApprovalDuration", "ExtendedTimeout"):
334
243
            return milliseconds_to_string(value)
335
244
        return str(value)
336
245
 
337
 
    def header_line(self, format_string):
338
 
        return format_string.format(**self.tableheaders)
339
 
 
340
 
    def client_line(self, client, format_string):
341
 
        return format_string.format(
342
 
            **{key: self.string_from_client(client, key)
343
 
               for key in self.keywords})
344
 
 
345
 
 
346
 
## Classes for commands.
347
 
 
348
 
# Abstract classes first
349
 
class Command(object):
350
 
    """Abstract class for commands"""
351
 
    def run(self, mandos, clients):
352
 
        """Normal commands should implement run_on_one_client(), but
353
 
        commands which want to operate on all clients at the same time
354
 
        can override this run() method instead."""
355
 
        self.mandos = mandos
356
 
        for client in clients:
357
 
            self.run_on_one_client(client)
358
 
 
359
 
class PrintCmd(Command):
360
 
    """Abstract class for commands printing client details"""
361
 
    all_keywords = ("Name", "Enabled", "Timeout", "LastCheckedOK",
362
 
                    "Created", "Interval", "Host", "KeyID",
363
 
                    "Fingerprint", "CheckerRunning", "LastEnabled",
364
 
                    "ApprovalPending", "ApprovedByDefault",
365
 
                    "LastApprovalRequest", "ApprovalDelay",
366
 
                    "ApprovalDuration", "Checker", "ExtendedTimeout",
367
 
                    "Expires", "LastCheckerStatus")
368
 
    def run(self, mandos, clients):
369
 
        print(self.output(clients))
370
 
 
371
 
class PropertyCmd(Command):
372
 
    """Abstract class for Actions for setting one client property"""
373
 
    def run_on_one_client(self, client):
374
 
        """Set the Client's D-Bus property"""
375
 
        client.Set(client_interface, self.property, self.value_to_set,
376
 
                   dbus_interface=dbus.PROPERTIES_IFACE)
377
 
 
378
 
class ValueArgumentMixIn(object):
379
 
    """Mixin class for commands taking a value as argument"""
380
 
    def __init__(self, value):
381
 
        self.value_to_set = value
382
 
 
383
 
class MillisecondsValueArgumentMixIn(ValueArgumentMixIn):
384
 
    """Mixin class for commands taking a value argument as
385
 
    milliseconds."""
386
 
    @property
387
 
    def value_to_set(self):
388
 
        return self._vts
389
 
    @value_to_set.setter
390
 
    def value_to_set(self, value):
391
 
        """When setting, convert value to a datetime.timedelta"""
392
 
        self._vts = string_to_delta(value).total_seconds() * 1000
393
 
 
394
 
# Actual (non-abstract) command classes
395
 
 
396
 
class PrintTableCmd(PrintCmd):
397
 
    def __init__(self, verbose=False):
398
 
        self.verbose = verbose
399
 
    def output(self, clients):
400
 
        if self.verbose:
401
 
            keywords = self.all_keywords
402
 
        else:
403
 
            keywords = ("Name", "Enabled", "Timeout", "LastCheckedOK")
404
 
        return str(TableOfClients(clients.values(), keywords))
405
 
 
406
 
class DumpJSONCmd(PrintCmd):
407
 
    def output(self, clients):
408
 
        data = {client["Name"]:
409
 
                {key: self.dbus_boolean_to_bool(client[key])
410
 
                 for key in self.all_keywords}
411
 
                for client in clients.values()}
412
 
        return json.dumps(data, indent=4, separators=(',', ': '))
413
 
    @staticmethod
414
 
    def dbus_boolean_to_bool(value):
415
 
        if isinstance(value, dbus.Boolean):
416
 
            value = bool(value)
417
 
        return value
418
 
 
419
 
class IsEnabledCmd(Command):
420
 
    def run_on_one_client(self, client):
421
 
        if self.is_enabled(client):
422
 
            sys.exit(0)
423
 
        sys.exit(1)
424
 
    def is_enabled(self, client):
425
 
        return client.Get(client_interface, "Enabled",
426
 
                          dbus_interface=dbus.PROPERTIES_IFACE)
427
 
 
428
 
class RemoveCmd(Command):
429
 
    def run_on_one_client(self, client):
430
 
        self.mandos.RemoveClient(client.__dbus_object_path__)
431
 
 
432
 
class ApproveCmd(Command):
433
 
    def run_on_one_client(self, client):
434
 
        client.Approve(dbus.Boolean(True),
435
 
                       dbus_interface=client_interface)
436
 
 
437
 
class DenyCmd(Command):
438
 
    def run_on_one_client(self, client):
439
 
        client.Approve(dbus.Boolean(False),
440
 
                       dbus_interface=client_interface)
441
 
 
442
 
class EnableCmd(PropertyCmd):
443
 
    property = "Enabled"
444
 
    value_to_set = dbus.Boolean(True)
445
 
 
446
 
class DisableCmd(PropertyCmd):
447
 
    property = "Enabled"
448
 
    value_to_set = dbus.Boolean(False)
449
 
 
450
 
class BumpTimeoutCmd(PropertyCmd):
451
 
    property = "LastCheckedOK"
452
 
    value_to_set = ""
453
 
 
454
 
class StartCheckerCmd(PropertyCmd):
455
 
    property = "CheckerRunning"
456
 
    value_to_set = dbus.Boolean(True)
457
 
 
458
 
class StopCheckerCmd(PropertyCmd):
459
 
    property = "CheckerRunning"
460
 
    value_to_set = dbus.Boolean(False)
461
 
 
462
 
class ApproveByDefaultCmd(PropertyCmd):
463
 
    property = "ApprovedByDefault"
464
 
    value_to_set = dbus.Boolean(True)
465
 
 
466
 
class DenyByDefaultCmd(PropertyCmd):
467
 
    property = "ApprovedByDefault"
468
 
    value_to_set = dbus.Boolean(False)
469
 
 
470
 
class SetCheckerCmd(PropertyCmd, ValueArgumentMixIn):
471
 
    property = "Checker"
472
 
 
473
 
class SetHostCmd(PropertyCmd, ValueArgumentMixIn):
474
 
    property = "Host"
475
 
 
476
 
class SetSecretCmd(PropertyCmd, ValueArgumentMixIn):
477
 
    property = "Secret"
478
 
 
479
 
class SetTimeoutCmd(PropertyCmd, MillisecondsValueArgumentMixIn):
480
 
    property = "Timeout"
481
 
 
482
 
class SetExtendedTimeoutCmd(PropertyCmd,
483
 
                            MillisecondsValueArgumentMixIn):
484
 
    property = "ExtendedTimeout"
485
 
 
486
 
class SetIntervalCmd(PropertyCmd, MillisecondsValueArgumentMixIn):
487
 
    property = "Interval"
488
 
 
489
 
class SetApprovalDelayCmd(PropertyCmd,
490
 
                          MillisecondsValueArgumentMixIn):
491
 
    property = "ApprovalDelay"
492
 
 
493
 
class SetApprovalDurationCmd(PropertyCmd,
494
 
                             MillisecondsValueArgumentMixIn):
495
 
    property = "ApprovalDuration"
 
246
    # Create format string to print table rows
 
247
    format_string = " ".join("{{{key}:{width}}}".format(
 
248
        width=max(len(tablewords[key]),
 
249
                  max(len(valuetostring(client[key], key))
 
250
                      for client in clients)),
 
251
        key=key)
 
252
                             for key in keywords)
 
253
    # Print header line
 
254
    print(format_string.format(**tablewords))
 
255
    for client in clients:
 
256
        print(format_string
 
257
              .format(**{key: valuetostring(client[key], key)
 
258
                         for key in keywords}))
 
259
 
496
260
 
497
261
def has_actions(options):
498
262
    return any((options.enable,
526
290
                        help="Print all fields")
527
291
    parser.add_argument("-j", "--dump-json", action="store_true",
528
292
                        help="Dump client data in JSON format")
529
 
    enable_disable = parser.add_mutually_exclusive_group()
530
 
    enable_disable.add_argument("-e", "--enable", action="store_true",
531
 
                                help="Enable client")
532
 
    enable_disable.add_argument("-d", "--disable",
533
 
                                action="store_true",
534
 
                                help="disable client")
 
293
    parser.add_argument("-e", "--enable", action="store_true",
 
294
                        help="Enable client")
 
295
    parser.add_argument("-d", "--disable", action="store_true",
 
296
                        help="disable client")
535
297
    parser.add_argument("-b", "--bump-timeout", action="store_true",
536
298
                        help="Bump timeout for client")
537
 
    start_stop_checker = parser.add_mutually_exclusive_group()
538
 
    start_stop_checker.add_argument("--start-checker",
539
 
                                    action="store_true",
540
 
                                    help="Start checker for client")
541
 
    start_stop_checker.add_argument("--stop-checker",
542
 
                                    action="store_true",
543
 
                                    help="Stop checker for client")
 
299
    parser.add_argument("--start-checker", action="store_true",
 
300
                        help="Start checker for client")
 
301
    parser.add_argument("--stop-checker", action="store_true",
 
302
                        help="Stop checker for client")
544
303
    parser.add_argument("-V", "--is-enabled", action="store_true",
545
304
                        help="Check if client is enabled")
546
305
    parser.add_argument("-r", "--remove", action="store_true",
553
312
                        help="Set extended timeout for client")
554
313
    parser.add_argument("-i", "--interval",
555
314
                        help="Set checker interval for client")
556
 
    approve_deny_default = parser.add_mutually_exclusive_group()
557
 
    approve_deny_default.add_argument(
558
 
        "--approve-by-default", action="store_true",
559
 
        default=None, dest="approved_by_default",
560
 
        help="Set client to be approved by default")
561
 
    approve_deny_default.add_argument(
562
 
        "--deny-by-default", action="store_false",
563
 
        dest="approved_by_default",
564
 
        help="Set client to be denied by default")
 
315
    parser.add_argument("--approve-by-default", action="store_true",
 
316
                        default=None, dest="approved_by_default",
 
317
                        help="Set client to be approved by default")
 
318
    parser.add_argument("--deny-by-default", action="store_false",
 
319
                        dest="approved_by_default",
 
320
                        help="Set client to be denied by default")
565
321
    parser.add_argument("--approval-delay",
566
322
                        help="Set delay before client approve/deny")
567
323
    parser.add_argument("--approval-duration",
570
326
    parser.add_argument("-s", "--secret",
571
327
                        type=argparse.FileType(mode="rb"),
572
328
                        help="Set password blob (file) for client")
573
 
    approve_deny = parser.add_mutually_exclusive_group()
574
 
    approve_deny.add_argument(
575
 
        "-A", "--approve", action="store_true",
576
 
        help="Approve any current client request")
577
 
    approve_deny.add_argument("-D", "--deny", action="store_true",
578
 
                              help="Deny any current client request")
 
329
    parser.add_argument("-A", "--approve", action="store_true",
 
330
                        help="Approve any current client request")
 
331
    parser.add_argument("-D", "--deny", action="store_true",
 
332
                        help="Deny any current client request")
579
333
    parser.add_argument("--check", action="store_true",
580
334
                        help="Run self-test")
581
335
    parser.add_argument("client", nargs="*", help="Client name")
590
344
        parser.error("--dump-json can only be used alone.")
591
345
    if options.all and not has_actions(options):
592
346
        parser.error("--all requires an action.")
593
 
    if options.is_enabled and len(options.client) > 1:
594
 
            parser.error("--is-enabled requires exactly one client")
 
347
 
 
348
    if options.check:
 
349
        import doctest
 
350
        fail_count, test_count = doctest.testmod()
 
351
        sys.exit(os.EX_OK if fail_count == 0 else 1)
595
352
 
596
353
    try:
597
354
        bus = dbus.SystemBus()
598
355
        mandos_dbus_objc = bus.get_object(busname, server_path)
599
356
    except dbus.exceptions.DBusException:
600
 
        log.critical("Could not connect to Mandos server")
 
357
        print("Could not connect to Mandos server", file=sys.stderr)
601
358
        sys.exit(1)
602
359
 
603
360
    mandos_serv = dbus.Interface(mandos_dbus_objc,
605
362
    mandos_serv_object_manager = dbus.Interface(
606
363
        mandos_dbus_objc, dbus_interface=dbus.OBJECT_MANAGER_IFACE)
607
364
 
608
 
    commands = []
609
 
 
610
 
    if options.dump_json:
611
 
        commands.append(DumpJSONCmd())
612
 
 
613
 
    if options.enable:
614
 
        commands.append(EnableCmd())
615
 
 
616
 
    if options.disable:
617
 
        commands.append(DisableCmd())
618
 
 
619
 
    if options.bump_timeout:
620
 
        commands.append(BumpTimeoutCmd(options.bump_timeout))
621
 
 
622
 
    if options.start_checker:
623
 
        commands.append(StartCheckerCmd())
624
 
 
625
 
    if options.stop_checker:
626
 
        commands.append(StopCheckerCmd())
627
 
 
628
 
    if options.is_enabled:
629
 
        commands.append(IsEnabledCmd())
630
 
 
631
 
    if options.remove:
632
 
        commands.append(RemoveCmd())
633
 
 
634
 
    if options.checker is not None:
635
 
        commands.append(SetCheckerCmd())
636
 
 
637
 
    if options.timeout is not None:
638
 
        commands.append(SetTimeoutCmd(options.timeout))
639
 
 
640
 
    if options.extended_timeout:
641
 
        commands.append(
642
 
            SetExtendedTimeoutCmd(options.extended_timeout))
643
 
 
644
 
    if options.interval is not None:
645
 
        command.append(SetIntervalCmd(options.interval))
646
 
 
647
 
    if options.approved_by_default is not None:
648
 
        if options.approved_by_default:
649
 
            command.append(ApproveByDefaultCmd())
650
 
        else:
651
 
            command.append(DenyByDefaultCmd())
652
 
 
653
 
    if options.approval_delay is not None:
654
 
        command.append(SetApprovalDelayCmd(options.approval_delay))
655
 
 
656
 
    if options.approval_duration is not None:
657
 
        command.append(
658
 
            SetApprovalDurationCmd(options.approval_duration))
659
 
 
660
 
    if options.host is not None:
661
 
        command.append(SetHostCmd(options.host))
662
 
 
663
 
    if options.secret is not None:
664
 
        command.append(SetSecretCmd(options.secret))
665
 
 
666
 
    if options.approve:
667
 
        commands.append(ApproveCmd())
668
 
 
669
 
    if options.deny:
670
 
        commands.append(DenyCmd())
671
 
 
672
 
    # If no command option has been given, show table of clients,
673
 
    # optionally verbosely
674
 
    if not commands:
675
 
        commands.append(PrintTableCmd(verbose=options.verbose))
676
 
 
677
 
    # Filter out log message from dbus module
678
 
    dbus_logger = logging.getLogger("dbus.proxies")
679
 
    class NullFilter(logging.Filter):
680
 
        def filter(self, record):
681
 
            return False
682
 
    dbus_filter = NullFilter()
683
 
    dbus_logger.addFilter(dbus_filter)
 
365
    # block stderr since dbus library prints to stderr
 
366
    null = os.open(os.path.devnull, os.O_RDWR)
 
367
    stderrcopy = os.dup(sys.stderr.fileno())
 
368
    os.dup2(null, sys.stderr.fileno())
 
369
    os.close(null)
684
370
    try:
685
371
        try:
686
372
            mandos_clients = {path: ifs_and_props[client_interface]
689
375
                              .GetManagedObjects().items()
690
376
                              if client_interface in ifs_and_props}
691
377
        finally:
692
 
            # restore dbus logger
693
 
            dbus_logger.removeFilter(dbus_filter)
 
378
            # restore stderr
 
379
            os.dup2(stderrcopy, sys.stderr.fileno())
 
380
            os.close(stderrcopy)
694
381
    except dbus.exceptions.DBusException as e:
695
 
        log.critical("Failed to access Mandos server through D-Bus:"
696
 
                     "\n%s", e)
 
382
        print("Access denied: "
 
383
              "Accessing mandos server through D-Bus: {}".format(e),
 
384
              file=sys.stderr)
697
385
        sys.exit(1)
698
386
 
699
387
    # Compile dict of (clients: properties) to process
710
398
                    clients[client_objc] = client
711
399
                    break
712
400
            else:
713
 
                log.critical("Client not found on server: %r", name)
 
401
                print("Client not found on server: {!r}"
 
402
                      .format(name), file=sys.stderr)
714
403
                sys.exit(1)
715
404
 
716
 
    # Run all commands on clients
717
 
    for command in commands:
718
 
        command.run(mandos_serv, clients)
719
 
 
720
 
 
721
 
class Test_milliseconds_to_string(unittest.TestCase):
722
 
    def test_all(self):
723
 
        self.assertEqual(milliseconds_to_string(93785000),
724
 
                         "1T02:03:05")
725
 
    def test_no_days(self):
726
 
        self.assertEqual(milliseconds_to_string(7385000), "02:03:05")
727
 
    def test_all_zero(self):
728
 
        self.assertEqual(milliseconds_to_string(0), "00:00:00")
729
 
    def test_no_fractional_seconds(self):
730
 
        self.assertEqual(milliseconds_to_string(400), "00:00:00")
731
 
        self.assertEqual(milliseconds_to_string(900), "00:00:00")
732
 
        self.assertEqual(milliseconds_to_string(1900), "00:00:01")
733
 
 
734
 
class Test_string_to_delta(unittest.TestCase):
735
 
    def test_handles_basic_rfc3339(self):
736
 
        self.assertEqual(string_to_delta("PT2H"),
737
 
                         datetime.timedelta(0, 7200))
738
 
    def test_falls_back_to_pre_1_6_1_with_warning(self):
739
 
        # assertLogs only exists in Python 3.4
740
 
        if hasattr(self, "assertLogs"):
741
 
            with self.assertLogs(log, logging.WARNING):
742
 
                value = string_to_delta("2h")
743
 
        else:
744
 
            class WarningFilter(logging.Filter):
745
 
                """Don't show, but record the presence of, warnings"""
746
 
                def filter(self, record):
747
 
                    is_warning = record.levelno >= logging.WARNING
748
 
                    self.found = is_warning or getattr(self, "found",
749
 
                                                       False)
750
 
                    return not is_warning
751
 
            warning_filter = WarningFilter()
752
 
            log.addFilter(warning_filter)
753
 
            try:
754
 
                value = string_to_delta("2h")
755
 
            finally:
756
 
                log.removeFilter(warning_filter)
757
 
            self.assertTrue(getattr(warning_filter, "found", False))
758
 
        self.assertEqual(value, datetime.timedelta(0, 7200))
759
 
 
760
 
class Test_TableOfClients(unittest.TestCase):
761
 
    def setUp(self):
762
 
        self.tableheaders = {
763
 
            "Attr1": "X",
764
 
            "AttrTwo": "Yy",
765
 
            "AttrThree": "Zzz",
766
 
            "Bool": "A D-BUS Boolean",
767
 
            "NonDbusBoolean": "A Non-D-BUS Boolean",
768
 
            "Integer": "An Integer",
769
 
            "Timeout": "Timedelta 1",
770
 
            "Interval": "Timedelta 2",
771
 
            "ApprovalDelay": "Timedelta 3",
772
 
            "ApprovalDuration": "Timedelta 4",
773
 
            "ExtendedTimeout": "Timedelta 5",
774
 
            "String": "A String",
775
 
        }
776
 
        self.keywords = ["Attr1", "AttrTwo"]
777
 
        self.clients = [
778
 
            {
779
 
                "Attr1": "x1",
780
 
                "AttrTwo": "y1",
781
 
                "AttrThree": "z1",
782
 
                "Bool": dbus.Boolean(False),
783
 
                "NonDbusBoolean": False,
784
 
                "Integer": 0,
785
 
                "Timeout": 0,
786
 
                "Interval": 1000,
787
 
                "ApprovalDelay": 2000,
788
 
                "ApprovalDuration": 3000,
789
 
                "ExtendedTimeout": 4000,
790
 
                "String": "",
791
 
            },
792
 
            {
793
 
                "Attr1": "x2",
794
 
                "AttrTwo": "y2",
795
 
                "AttrThree": "z2",
796
 
                "Bool": dbus.Boolean(True),
797
 
                "NonDbusBoolean": True,
798
 
                "Integer": 1,
799
 
                "Timeout": 93785000,
800
 
                "Interval": 93786000,
801
 
                "ApprovalDelay": 93787000,
802
 
                "ApprovalDuration": 93788000,
803
 
                "ExtendedTimeout": 93789000,
804
 
                "String": "A huge string which will not fit," * 10,
805
 
            },
806
 
        ]
807
 
    def test_short_header(self):
808
 
        text = str(TableOfClients(self.clients, self.keywords,
809
 
                                  self.tableheaders))
810
 
        expected_text = """
811
 
X  Yy
812
 
x1 y1
813
 
x2 y2
814
 
"""[1:-1]
815
 
        self.assertEqual(text, expected_text)
816
 
    def test_booleans(self):
817
 
        keywords = ["Bool", "NonDbusBoolean"]
818
 
        text = str(TableOfClients(self.clients, keywords,
819
 
                                  self.tableheaders))
820
 
        expected_text = """
821
 
A D-BUS Boolean A Non-D-BUS Boolean
822
 
No              False              
823
 
Yes             True               
824
 
"""[1:-1]
825
 
        self.assertEqual(text, expected_text)
826
 
    def test_milliseconds_detection(self):
827
 
        keywords = ["Integer", "Timeout", "Interval", "ApprovalDelay",
828
 
                    "ApprovalDuration", "ExtendedTimeout"]
829
 
        text = str(TableOfClients(self.clients, keywords,
830
 
                                  self.tableheaders))
831
 
        expected_text = """
832
 
An Integer Timedelta 1 Timedelta 2 Timedelta 3 Timedelta 4 Timedelta 5
833
 
0          00:00:00    00:00:01    00:00:02    00:00:03    00:00:04   
834
 
1          1T02:03:05  1T02:03:06  1T02:03:07  1T02:03:08  1T02:03:09 
835
 
"""[1:-1]
836
 
        self.assertEqual(text, expected_text)
837
 
    def test_empty_and_long_string_values(self):
838
 
        keywords = ["String"]
839
 
        text = str(TableOfClients(self.clients, keywords,
840
 
                                  self.tableheaders))
841
 
        expected_text = """
842
 
A String                                                                                                                                                                                                                                                                                                                                  
843
 
                                                                                                                                                                                                                                                                                                                                          
844
 
A huge string which will not fit,A huge string which will not fit,A huge string which will not fit,A huge string which will not fit,A huge string which will not fit,A huge string which will not fit,A huge string which will not fit,A huge string which will not fit,A huge string which will not fit,A huge string which will not fit,
845
 
"""[1:-1]
846
 
        self.assertEqual(text, expected_text)
847
 
 
848
 
 
849
 
 
850
 
def should_only_run_tests():
851
 
    parser = argparse.ArgumentParser(add_help=False)
852
 
    parser.add_argument("--check", action='store_true')
853
 
    args, unknown_args = parser.parse_known_args()
854
 
    run_tests = args.check
855
 
    if run_tests:
856
 
        # Remove --check argument from sys.argv
857
 
        sys.argv[1:] = unknown_args
858
 
    return run_tests
859
 
 
860
 
# Add all tests from doctest strings
861
 
def load_tests(loader, tests, none):
862
 
    import doctest
863
 
    tests.addTests(doctest.DocTestSuite())
864
 
    return tests
 
405
    if not has_actions(options) and clients:
 
406
        if options.verbose or options.dump_json:
 
407
            keywords = ("Name", "Enabled", "Timeout", "LastCheckedOK",
 
408
                        "Created", "Interval", "Host", "KeyID",
 
409
                        "Fingerprint", "CheckerRunning",
 
410
                        "LastEnabled", "ApprovalPending",
 
411
                        "ApprovedByDefault", "LastApprovalRequest",
 
412
                        "ApprovalDelay", "ApprovalDuration",
 
413
                        "Checker", "ExtendedTimeout", "Expires",
 
414
                        "LastCheckerStatus")
 
415
        else:
 
416
            keywords = defaultkeywords
 
417
 
 
418
        if options.dump_json:
 
419
            json.dump({client["Name"]: {key:
 
420
                                        bool(client[key])
 
421
                                        if isinstance(client[key],
 
422
                                                      dbus.Boolean)
 
423
                                        else client[key]
 
424
                                        for key in keywords}
 
425
                       for client in clients.values()},
 
426
                      fp=sys.stdout, indent=4,
 
427
                      separators=(',', ': '))
 
428
            print()
 
429
        else:
 
430
            print_clients(clients.values(), keywords)
 
431
    else:
 
432
        # Process each client in the list by all selected options
 
433
        for client in clients:
 
434
 
 
435
            def set_client_prop(prop, value):
 
436
                """Set a Client D-Bus property"""
 
437
                client.Set(client_interface, prop, value,
 
438
                           dbus_interface=dbus.PROPERTIES_IFACE)
 
439
 
 
440
            def set_client_prop_ms(prop, value):
 
441
                """Set a Client D-Bus property, converted
 
442
                from a string to milliseconds."""
 
443
                set_client_prop(prop,
 
444
                                string_to_delta(value).total_seconds()
 
445
                                * 1000)
 
446
 
 
447
            if options.remove:
 
448
                mandos_serv.RemoveClient(client.__dbus_object_path__)
 
449
            if options.enable:
 
450
                set_client_prop("Enabled", dbus.Boolean(True))
 
451
            if options.disable:
 
452
                set_client_prop("Enabled", dbus.Boolean(False))
 
453
            if options.bump_timeout:
 
454
                set_client_prop("LastCheckedOK", "")
 
455
            if options.start_checker:
 
456
                set_client_prop("CheckerRunning", dbus.Boolean(True))
 
457
            if options.stop_checker:
 
458
                set_client_prop("CheckerRunning", dbus.Boolean(False))
 
459
            if options.is_enabled:
 
460
                if client.Get(client_interface, "Enabled",
 
461
                              dbus_interface=dbus.PROPERTIES_IFACE):
 
462
                    sys.exit(0)
 
463
                else:
 
464
                    sys.exit(1)
 
465
            if options.checker is not None:
 
466
                set_client_prop("Checker", options.checker)
 
467
            if options.host is not None:
 
468
                set_client_prop("Host", options.host)
 
469
            if options.interval is not None:
 
470
                set_client_prop_ms("Interval", options.interval)
 
471
            if options.approval_delay is not None:
 
472
                set_client_prop_ms("ApprovalDelay",
 
473
                                   options.approval_delay)
 
474
            if options.approval_duration is not None:
 
475
                set_client_prop_ms("ApprovalDuration",
 
476
                                   options.approval_duration)
 
477
            if options.timeout is not None:
 
478
                set_client_prop_ms("Timeout", options.timeout)
 
479
            if options.extended_timeout is not None:
 
480
                set_client_prop_ms("ExtendedTimeout",
 
481
                                   options.extended_timeout)
 
482
            if options.secret is not None:
 
483
                set_client_prop("Secret",
 
484
                                dbus.ByteArray(options.secret.read()))
 
485
            if options.approved_by_default is not None:
 
486
                set_client_prop("ApprovedByDefault",
 
487
                                dbus.Boolean(options
 
488
                                             .approved_by_default))
 
489
            if options.approve:
 
490
                client.Approve(dbus.Boolean(True),
 
491
                               dbus_interface=client_interface)
 
492
            elif options.deny:
 
493
                client.Approve(dbus.Boolean(False),
 
494
                               dbus_interface=client_interface)
 
495
 
865
496
 
866
497
if __name__ == "__main__":
867
 
    if should_only_run_tests():
868
 
        # Call using ./tdd-python-script --check [--verbose]
869
 
        unittest.main()
870
 
    else:
871
 
        main()
 
498
    main()