1
/* -*- coding: utf-8 -*- */
1
/* -*- coding: utf-8; mode: c; mode: orgtbl -*- */
3
3
* Mandos plugin runner - Run Mandos plugins
5
* Copyright © 2008 Teddy Hogeborn
6
* Copyright © 2008 Björn Påhlsson
8
* This program is free software: you can redistribute it and/or
9
* modify it under the terms of the GNU General Public License as
10
* published by the Free Software Foundation, either version 3 of the
11
* License, or (at your option) any later version.
13
* This program is distributed in the hope that it will be useful, but
5
* Copyright © 2008-2018 Teddy Hogeborn
6
* Copyright © 2008-2018 Björn Påhlsson
8
* This file is part of Mandos.
10
* Mandos is free software: you can redistribute it and/or modify it
11
* under the terms of the GNU General Public License as published by
12
* the Free Software Foundation, either version 3 of the License, or
13
* (at your option) any later version.
15
* Mandos is distributed in the hope that it will be useful, but
14
16
* WITHOUT ANY WARRANTY; without even the implied warranty of
15
17
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
16
18
* General Public License for more details.
18
20
* You should have received a copy of the GNU General Public License
19
* along with this program. If not, see
20
* <http://www.gnu.org/licenses/>.
21
* along with Mandos. If not, see <http://www.gnu.org/licenses/>.
22
* Contact the authors at <mandos@fukt.bsnet.se>.
23
* Contact the authors at <mandos@recompile.se>.
25
26
#define _GNU_SOURCE /* TEMP_FAILURE_RETRY(), getline(),
27
28
#include <stddef.h> /* size_t, NULL */
28
#include <stdlib.h> /* malloc(), exit(), EXIT_FAILURE,
29
EXIT_SUCCESS, realloc() */
29
#include <stdlib.h> /* malloc(), exit(), EXIT_SUCCESS,
30
31
#include <stdbool.h> /* bool, true, false */
31
#include <stdio.h> /* perror, fileno(), fprintf(),
32
stderr, STDOUT_FILENO */
33
#include <sys/types.h> /* DIR, opendir(), stat(), struct
34
stat, waitpid(), WIFEXITED(),
35
WEXITSTATUS(), wait(), pid_t,
36
uid_t, gid_t, getuid(), getgid(),
32
#include <stdio.h> /* fileno(), fprintf(),
33
stderr, STDOUT_FILENO, fclose() */
34
#include <sys/types.h> /* fstat(), struct stat, waitpid(),
35
WIFEXITED(), WEXITSTATUS(), wait(),
36
pid_t, uid_t, gid_t, getuid(),
38
38
#include <sys/select.h> /* fd_set, select(), FD_ZERO(),
39
39
FD_SET(), FD_ISSET(), FD_CLR */
40
40
#include <sys/wait.h> /* wait(), waitpid(), WIFEXITED(),
42
#include <sys/stat.h> /* struct stat, stat(), S_ISREG() */
41
WEXITSTATUS(), WTERMSIG() */
42
#include <sys/stat.h> /* struct stat, fstat(), S_ISREG() */
43
43
#include <iso646.h> /* and, or, not */
44
#include <dirent.h> /* DIR, struct dirent, opendir(),
45
readdir(), closedir(), dirfd() */
46
#include <unistd.h> /* struct stat, stat(), S_ISREG(),
47
fcntl(), setuid(), setgid(),
48
F_GETFD, F_SETFD, FD_CLOEXEC,
49
access(), pipe(), fork(), close()
50
dup2(), STDOUT_FILENO, _exit(),
51
execv(), write(), read(),
44
#include <dirent.h> /* struct dirent, scandirat() */
45
#include <unistd.h> /* fcntl(), F_GETFD, F_SETFD,
46
FD_CLOEXEC, write(), STDOUT_FILENO,
47
struct stat, fstat(), close(),
48
setgid(), setuid(), S_ISREG(),
49
faccessat() pipe2(), fork(),
50
_exit(), dup2(), fexecve(), read()
53
52
#include <fcntl.h> /* fcntl(), F_GETFD, F_SETFD,
55
#include <string.h> /* strsep, strlen(), asprintf() */
53
FD_CLOEXEC, openat(), scandirat(),
55
#include <string.h> /* strsep, strlen(), strsignal(),
56
strcmp(), strncmp() */
56
57
#include <errno.h> /* errno */
57
58
#include <argp.h> /* struct argp_option, struct
58
59
argp_state, struct argp,
98
107
/* Gets an existing plugin based on name,
99
108
or if none is found, creates a new one */
109
__attribute__((warn_unused_result))
100
110
static plugin *getplugin(char *name){
101
/* Check for exiting plugin with that name */
102
for (plugin *p = plugin_list; p != NULL; p = p->next){
103
if ((p->name == name)
104
or (p->name and name and (strcmp(p->name, name) == 0))){
111
/* Check for existing plugin with that name */
112
for(plugin *p = plugin_list; p != NULL; p = p->next){
114
or (p->name and name and (strcmp(p->name, name) == 0))){
108
118
/* Create a new plugin */
109
plugin *new_plugin = malloc(sizeof(plugin));
110
if (new_plugin == NULL){
119
plugin *new_plugin = NULL;
121
new_plugin = malloc(sizeof(plugin));
122
} while(new_plugin == NULL and errno == EINTR);
123
if(new_plugin == NULL){
113
126
char *copy_name = NULL;
114
127
if(name != NULL){
115
copy_name = strdup(name);
129
copy_name = strdup(name);
130
} while(copy_name == NULL and errno == EINTR);
116
131
if(copy_name == NULL){
121
*new_plugin = (plugin) { .name = copy_name,
124
.next = plugin_list };
139
*new_plugin = (plugin){ .name = copy_name,
142
.next = plugin_list };
126
new_plugin->argv = malloc(sizeof(char *) * 2);
127
if (new_plugin->argv == NULL){
145
new_plugin->argv = malloc(sizeof(char *) * 2);
146
} while(new_plugin->argv == NULL and errno == EINTR);
147
if(new_plugin->argv == NULL){
129
150
free(new_plugin);
132
154
new_plugin->argv[0] = copy_name;
133
155
new_plugin->argv[1] = NULL;
135
new_plugin->environ = malloc(sizeof(char *));
158
new_plugin->environ = malloc(sizeof(char *));
159
} while(new_plugin->environ == NULL and errno == EINTR);
136
160
if(new_plugin->environ == NULL){
138
163
free(new_plugin->argv);
139
164
free(new_plugin);
142
168
new_plugin->environ[0] = NULL;
368
416
.doc = "Group ID the plugins will run as", .group = 3 },
369
417
{ .name = "debug", .key = 132,
370
418
.doc = "Debug mode", .group = 4 },
419
{ .name = "plugin-helper-dir", .key = 133,
421
.doc = "Specify a different plugin helper directory",
424
* These reproduce what we would get without ARGP_NO_HELP
426
{ .name = "help", .key = '?',
427
.doc = "Give this help list", .group = -1 },
428
{ .name = "usage", .key = -3,
429
.doc = "Give a short usage message", .group = -1 },
430
{ .name = "version", .key = 'V',
431
.doc = "Print program version", .group = -1 },
374
error_t parse_opt (int key, char *arg, __attribute__((unused))
375
struct argp_state *state) {
435
__attribute__((nonnull(3)))
436
error_t parse_opt(int key, char *arg, struct argp_state *state){
377
441
case 'g': /* --global-options */
380
while((p = strsep(&arg, ",")) != NULL){
384
if(not add_argument(getplugin(NULL), p)){
385
perror("add_argument");
386
return ARGP_ERR_UNKNOWN;
444
while((plugin_option = strsep(&arg, ",")) != NULL){
445
if(not add_argument(getplugin(NULL), plugin_option)){
391
452
case 'G': /* --global-env */
395
if(not add_environment(getplugin(NULL), arg, true)){
396
perror("add_environment");
453
if(add_environment(getplugin(NULL), arg, true)){
399
457
case 'o': /* --options-for */
401
char *p_name = strsep(&arg, ":");
402
if(p_name[0] == '\0' or arg == NULL){
405
char *opt = strsep(&arg, ":");
406
if(opt[0] == '\0' or opt == NULL){
410
while((p = strsep(&opt, ",")) != NULL){
414
if(not add_argument(getplugin(p_name), p)){
415
perror("add_argument");
416
return ARGP_ERR_UNKNOWN;
459
char *option_list = strchr(arg, ':');
460
if(option_list == NULL){
461
argp_error(state, "No colon in \"%s\"", arg);
468
argp_error(state, "Empty plugin name");
473
while((option = strsep(&option_list, ",")) != NULL){
474
if(not add_argument(getplugin(arg), option)){
421
481
case 'E': /* --env-for */
426
483
char *envdef = strchr(arg, ':');
427
484
if(envdef == NULL){
485
argp_error(state, "No colon in \"%s\"", arg);
431
if(not add_environment(getplugin(arg), envdef+1, true)){
432
perror("add_environment");
492
argp_error(state, "Empty plugin name");
496
if(add_environment(getplugin(arg), envdef, true)){
436
501
case 'd': /* --disable */
438
503
plugin *p = getplugin(arg);
440
return ARGP_ERR_UNKNOWN;
445
510
case 'e': /* --enable */
447
512
plugin *p = getplugin(arg);
449
return ARGP_ERR_UNKNOWN;
454
519
case 128: /* --plugin-dir */
456
521
plugindir = strdup(arg);
457
if(plugindir == NULL){
522
if(plugindir != NULL){
461
526
case 129: /* --config-file */
462
527
/* This is already done by parse_opt_config_file() */
464
529
case 130: /* --userid */
465
uid = (uid_t)strtol(arg, NULL, 10);
530
tmp_id = strtoimax(arg, &tmp, 10);
531
if(errno != 0 or tmp == arg or *tmp != '\0'
532
or tmp_id != (uid_t)tmp_id){
533
argp_error(state, "Bad user ID number: \"%s\", using %"
534
PRIdMAX, arg, (intmax_t)uid);
467
540
case 131: /* --groupid */
468
gid = (gid_t)strtol(arg, NULL, 10);
541
tmp_id = strtoimax(arg, &tmp, 10);
542
if(errno != 0 or tmp == arg or *tmp != '\0'
543
or tmp_id != (gid_t)tmp_id){
544
argp_error(state, "Bad group ID number: \"%s\", using %"
545
PRIdMAX, arg, (intmax_t)gid);
470
551
case 132: /* --debug */
554
case 133: /* --plugin-helper-dir */
555
free(pluginhelperdir);
556
pluginhelperdir = strdup(arg);
557
if(pluginhelperdir != NULL){
562
* These reproduce what we would get without ARGP_NO_HELP
564
case '?': /* --help */
565
state->flags &= ~(unsigned int)ARGP_NO_EXIT; /* force exit */
566
argp_state_help(state, state->out_stream, ARGP_HELP_STD_HELP);
567
case -3: /* --usage */
568
state->flags &= ~(unsigned int)ARGP_NO_EXIT; /* force exit */
569
argp_state_help(state, state->out_stream,
570
ARGP_HELP_USAGE | ARGP_HELP_EXIT_OK);
571
case 'V': /* --version */
572
fprintf(state->out_stream, "%s\n", argp_program_version);
576
* When adding more options before this line, remember to also add a
577
* "case" to the "parse_opt_config_file" function below.
473
579
case ARGP_KEY_ARG:
474
580
/* Cryptsetup always passes an argument, which is an empty
475
581
string if "none" was specified in /etc/crypttab. So if
476
582
argument was empty, we ignore it silently. */
478
fprintf(stderr, "Ignoring unknown argument \"%s\"\n", arg);
484
588
return ARGP_ERR_UNKNOWN;
590
return errno; /* Set to 0 at start */
489
593
/* This option parser is the same as parse_opt() above, except it
490
594
ignores everything but the --config-file option. */
491
error_t parse_opt_config_file (int key, char *arg,
492
__attribute__((unused))
493
struct argp_state *state) {
595
error_t parse_opt_config_file(int key, char *arg,
596
__attribute__((unused))
597
struct argp_state *state){
495
600
case 'g': /* --global-options */
496
601
case 'G': /* --global-env */
497
602
case 'o': /* --options-for */
577
694
new_arg = strdup(p);
578
695
if(new_arg == NULL){
580
exitstatus = EXIT_FAILURE;
696
error(0, errno, "strdup");
697
exitstatus = EX_OSERR;
585
702
custom_argc += 1;
586
custom_argv = realloc(custom_argv, sizeof(char *)
587
* ((unsigned int) custom_argc + 1));
588
if(custom_argv == NULL){
590
exitstatus = EXIT_FAILURE;
704
char **new_argv = realloc(custom_argv, sizeof(char *)
705
* ((size_t)custom_argc + 1));
706
if(new_argv == NULL){
707
error(0, errno, "realloc");
708
exitstatus = EX_OSERR;
713
custom_argv = new_argv;
594
716
custom_argv[custom_argc-1] = new_arg;
595
custom_argv[custom_argc] = NULL;
717
custom_argv[custom_argc] = NULL;
721
ret = fclose(conffp);
722
} while(ret == EOF and errno == EINTR);
724
error(0, errno, "fclose");
725
exitstatus = EX_IOERR;
600
730
/* Check for harmful errors and go to fallback. Other errors might
601
731
not affect opening plugins */
602
if (errno == EMFILE or errno == ENFILE or errno == ENOMEM){
604
exitstatus = EXIT_FAILURE;
732
if(errno == EMFILE or errno == ENFILE or errno == ENOMEM){
733
error(0, errno, "fopen");
734
exitstatus = EX_OSERR;
608
/* If there was any arguments from configuration file,
609
pass them to parser as command arguments */
738
/* If there were any arguments from the configuration file, pass
739
them to parser as command line arguments */
610
740
if(custom_argv != NULL){
611
ret = argp_parse (&argp, custom_argc, custom_argv, ARGP_IN_ORDER,
613
if (ret == ARGP_ERR_UNKNOWN){
614
fprintf(stderr, "Unknown error while parsing arguments\n");
615
exitstatus = EXIT_FAILURE;
741
ret = argp_parse(&argp, custom_argc, custom_argv,
742
ARGP_IN_ORDER | ARGP_NO_EXIT | ARGP_NO_HELP,
750
error(0, errno, "argp_parse");
751
exitstatus = EX_OSERR;
754
exitstatus = EX_CONFIG;
620
759
/* Parse actual command line arguments, to let them override the
622
ret = argp_parse (&argp, argc, argv, ARGP_IN_ORDER, 0, NULL);
623
if (ret == ARGP_ERR_UNKNOWN){
624
fprintf(stderr, "Unknown error while parsing arguments\n");
625
exitstatus = EXIT_FAILURE;
761
ret = argp_parse(&argp, argc, argv,
762
ARGP_IN_ORDER | ARGP_NO_EXIT | ARGP_NO_HELP,
770
error(0, errno, "argp_parse");
771
exitstatus = EX_OSERR;
774
exitstatus = EX_USAGE;
779
char *pluginhelperenv;
781
ret = asprintf(&pluginhelperenv, "MANDOSPLUGINHELPERDIR=%s",
782
pluginhelperdir != NULL ? pluginhelperdir : PHDIR);
784
bret = add_environment(getplugin(NULL), pluginhelperenv, true);
786
if(ret == -1 or not bret){
787
error(0, errno, "Failed to set MANDOSPLUGINHELPERDIR"
788
" environment variable to \"%s\" for all plugins\n",
789
pluginhelperdir != NULL ? pluginhelperdir : PHDIR);
792
free(pluginhelperenv);
630
for(plugin *p = plugin_list; p != NULL; p=p->next){
797
for(plugin *p = plugin_list; p != NULL; p = p->next){
631
798
fprintf(stderr, "Plugin: %s has %d arguments\n",
632
799
p->name ? p->name : "Global", p->argc - 1);
633
800
for(char **a = p->argv; *a != NULL; a++){
634
801
fprintf(stderr, "\tArg: %s\n", *a);
636
fprintf(stderr, "...and %u environment variables\n", p->envc);
803
fprintf(stderr, "...and %d environment variables\n", p->envc);
637
804
for(char **a = p->environ; *a != NULL; a++){
638
805
fprintf(stderr, "\t%s\n", *a);
643
/* Strip permissions down to nobody */
811
/* Work around Debian bug #633582:
812
<https://bugs.debian.org/633582> */
813
int plugindir_fd = open(/* plugindir or */ PDIR, O_RDONLY);
814
if(plugindir_fd == -1){
816
error(0, errno, "open(\"" PDIR "\")");
819
ret = (int)TEMP_FAILURE_RETRY(fstat(plugindir_fd, &st));
821
error(0, errno, "fstat");
823
if(S_ISDIR(st.st_mode) and st.st_uid == 0 and st.st_gid == 0){
824
ret = fchown(plugindir_fd, uid, gid);
826
error(0, errno, "fchown");
834
/* Lower permissions */
837
error(0, errno, "setgid");
644
839
ret = setuid(uid);
653
if (plugindir == NULL){
656
dir = opendir(plugindir);
660
perror("Could not open plugin dir");
661
exitstatus = EXIT_FAILURE;
665
/* Set the FD_CLOEXEC flag on the directory, if possible */
841
error(0, errno, "setuid");
844
/* Open plugin directory with close_on_exec flag */
667
int dir_fd = dirfd(dir);
669
ret = set_cloexec_flag(dir_fd);
671
perror("set_cloexec_flag");
672
exitstatus = EXIT_FAILURE;
846
dir_fd = open(plugindir != NULL ? plugindir : PDIR, O_RDONLY |
849
#else /* not O_CLOEXEC */
851
#endif /* not O_CLOEXEC */
854
error(0, errno, "Could not open plugin dir");
855
exitstatus = EX_UNAVAILABLE;
860
/* Set the FD_CLOEXEC flag on the directory */
861
ret = set_cloexec_flag(dir_fd);
863
error(0, errno, "set_cloexec_flag");
864
exitstatus = EX_OSERR;
867
#endif /* O_CLOEXEC */
870
int good_name(const struct dirent * const dirent){
871
const char * const patterns[] = { ".*", "#*#", "*~", "*.dpkg-new",
872
"*.dpkg-old", "*.dpkg-bak",
873
"*.dpkg-divert", NULL };
875
#pragma GCC diagnostic push
876
#pragma GCC diagnostic ignored "-Wcast-qual"
878
for(const char **pat = (const char **)patterns;
879
*pat != NULL; pat++){
881
#pragma GCC diagnostic pop
883
if(fnmatch(*pat, dirent->d_name, FNM_FILE_NAME | FNM_PERIOD)
886
fprintf(stderr, "Ignoring plugin dir entry \"%s\""
887
" matching pattern %s\n", dirent->d_name, *pat);
895
int numplugins = scandirat(dir_fd, ".", &direntries, good_name,
897
if(numplugins == -1){
898
error(0, errno, "Could not scan plugin dir");
900
exitstatus = EX_OSERR;
678
904
FD_ZERO(&rfds_all);
680
906
/* Read and execute any executable in the plugin directory*/
682
dirst = readdir(dir);
684
/* All directory entries have been processed */
688
exitstatus = EXIT_FAILURE;
694
d_name_len = strlen(dirst->d_name);
696
/* Ignore dotfiles, backup files and other junk */
698
bool bad_name = false;
700
const char const *bad_prefixes[] = { ".", "#", NULL };
702
const char const *bad_suffixes[] = { "~", "#", ".dpkg-new",
705
".dpkg-divert", NULL };
706
for(const char **pre = bad_prefixes; *pre != NULL; pre++){
707
size_t pre_len = strlen(*pre);
708
if((d_name_len >= pre_len)
709
and strncmp((dirst->d_name), *pre, pre_len) == 0){
711
fprintf(stderr, "Ignoring plugin dir entry \"%s\""
712
" with bad prefix %s\n", dirst->d_name, *pre);
721
for(const char **suf = bad_suffixes; *suf != NULL; suf++){
722
size_t suf_len = strlen(*suf);
723
if((d_name_len >= suf_len)
724
and (strcmp((dirst->d_name)+d_name_len-suf_len, *suf)
727
fprintf(stderr, "Ignoring plugin dir entry \"%s\""
728
" with bad suffix %s\n", dirst->d_name, *suf);
741
if(plugindir == NULL){
742
ret = asprintf(&filename, PDIR "/%s", dirst->d_name);
744
ret = asprintf(&filename, "%s/%s", plugindir, dirst->d_name);
751
ret = stat(filename, &st);
907
for(int i = 0; i < numplugins; i++){
909
int plugin_fd = openat(dir_fd, direntries[i]->d_name, O_RDONLY);
911
error(0, errno, "Could not open plugin");
915
ret = (int)TEMP_FAILURE_RETRY(fstat(plugin_fd, &st));
917
error(0, errno, "stat");
758
923
/* Ignore non-executable files */
759
if (not S_ISREG(st.st_mode) or (access(filename, X_OK) != 0)){
924
if(not S_ISREG(st.st_mode)
925
or (TEMP_FAILURE_RETRY(faccessat(dir_fd, direntries[i]->d_name,
761
fprintf(stderr, "Ignoring plugin dir entry \"%s\""
762
" with bad type or mode\n", filename);
928
fprintf(stderr, "Ignoring plugin dir entry \"%s/%s\""
929
" with bad type or mode\n",
930
plugindir != NULL ? plugindir : PDIR,
931
direntries[i]->d_name);
768
plugin *p = getplugin(dirst->d_name);
938
plugin *p = getplugin(direntries[i]->d_name);
940
error(0, errno, "getplugin");
776
947
fprintf(stderr, "Ignoring disabled plugin \"%s\"\n",
948
direntries[i]->d_name);
786
958
for(char **a = g->argv + 1; *a != NULL; a++){
787
959
if(not add_argument(p, *a)){
788
perror("add_argument");
960
error(0, errno, "add_argument");
791
963
/* Add global environment variables */
792
964
for(char **e = g->environ; *e != NULL; e++){
793
965
if(not add_environment(p, *e, false)){
794
perror("add_environment");
966
error(0, errno, "add_environment");
799
/* If this plugin has any environment variables, we will call
800
using execve and need to duplicate the environment from this
971
/* If this plugin has any environment variables, we need to
972
duplicate the environment from this process, too. */
802
973
if(p->environ[0] != NULL){
803
974
for(char **e = environ; *e != NULL; e++){
804
975
if(not add_environment(p, *e, false)){
805
perror("add_environment");
976
error(0, errno, "add_environment");
814
exitstatus = EXIT_FAILURE;
983
ret = (int)TEMP_FAILURE_RETRY(pipe(pipefd));
984
#else /* O_CLOEXEC */
985
ret = (int)TEMP_FAILURE_RETRY(pipe2(pipefd, O_CLOEXEC));
986
#endif /* O_CLOEXEC */
988
error(0, errno, "pipe");
989
exitstatus = EX_OSERR;
993
if(pipefd[0] >= FD_SETSIZE){
994
fprintf(stderr, "pipe()[0] (%d) >= FD_SETSIZE (%d)", pipefd[0],
998
exitstatus = EX_OSERR;
817
1003
/* Ask OS to automatic close the pipe on exec */
818
1004
ret = set_cloexec_flag(pipefd[0]);
820
perror("set_cloexec_flag");
821
exitstatus = EXIT_FAILURE;
1006
error(0, errno, "set_cloexec_flag");
1009
exitstatus = EX_OSERR;
1010
free(direntries[i]);
824
1013
ret = set_cloexec_flag(pipefd[1]);
826
perror("set_cloexec_flag");
827
exitstatus = EXIT_FAILURE;
1015
error(0, errno, "set_cloexec_flag");
1018
exitstatus = EX_OSERR;
1019
free(direntries[i]);
1022
#endif /* not O_CLOEXEC */
830
1023
/* Block SIGCHLD until process is safely in process list */
831
ret = sigprocmask (SIG_BLOCK, &sigchld_action.sa_mask, NULL);
1024
ret = (int)TEMP_FAILURE_RETRY(sigprocmask(SIG_BLOCK,
1025
&sigchld_action.sa_mask,
833
perror("sigprocmask");
834
exitstatus = EXIT_FAILURE;
1028
error(0, errno, "sigprocmask");
1029
exitstatus = EX_OSERR;
1030
free(direntries[i]);
837
1033
/* Starting a new process to be watched */
1037
} while(pid == -1 and errno == EINTR);
841
exitstatus = EXIT_FAILURE;
1039
error(0, errno, "fork");
1040
TEMP_FAILURE_RETRY(sigprocmask(SIG_UNBLOCK,
1041
&sigchld_action.sa_mask, NULL));
1044
exitstatus = EX_OSERR;
1045
free(direntries[i]);
845
1049
/* this is the child process */
846
1050
ret = sigaction(SIGCHLD, &old_sigchld_action, NULL);
1052
error(0, errno, "sigaction");
851
1055
ret = sigprocmask(SIG_UNBLOCK, &sigchld_action.sa_mask, NULL);
853
perror("sigprocmask");
1057
error(0, errno, "sigprocmask");
857
1061
ret = dup2(pipefd[1], STDOUT_FILENO); /* replace our stdout */
1063
error(0, errno, "dup2");
864
/* If dir has no file descriptor, we could not set FD_CLOEXEC
865
above and must now close it manually here. */
868
if(p->environ[0] == NULL){
869
if(execv(filename, p->argv) < 0){
874
if(execve(filename, p->argv, p->environ) < 0){
1067
if(fexecve(plugin_fd, p->argv,
1068
(p->environ[0] != NULL) ? p->environ : environ) < 0){
1069
error(0, errno, "fexecve for %s/%s",
1070
plugindir != NULL ? plugindir : PDIR,
1071
direntries[i]->d_name);
881
1076
/* Parent process */
882
1077
close(pipefd[1]); /* Close unused write end of pipe */
884
plugin *new_plugin = getplugin(dirst->d_name);
885
if (new_plugin == NULL){
887
ret = sigprocmask (SIG_UNBLOCK, &sigchld_action.sa_mask, NULL);
1079
plugin *new_plugin = getplugin(direntries[i]->d_name);
1080
if(new_plugin == NULL){
1081
error(0, errno, "getplugin");
1082
ret = (int)(TEMP_FAILURE_RETRY
1083
(sigprocmask(SIG_UNBLOCK, &sigchld_action.sa_mask,
889
perror("sigprocmask");
1086
error(0, errno, "sigprocmask");
891
exitstatus = EXIT_FAILURE;
1088
exitstatus = EX_OSERR;
1089
free(direntries[i]);
1092
free(direntries[i]);
895
1094
new_plugin->pid = pid;
896
1095
new_plugin->fd = pipefd[0];
898
1097
/* Unblock SIGCHLD so signal handler can be run if this process
899
1098
has already completed */
900
ret = sigprocmask (SIG_UNBLOCK, &sigchld_action.sa_mask, NULL);
1099
ret = (int)TEMP_FAILURE_RETRY(sigprocmask(SIG_UNBLOCK,
1100
&sigchld_action.sa_mask,
902
perror("sigprocmask");
903
exitstatus = EXIT_FAILURE;
1103
error(0, errno, "sigprocmask");
1104
exitstatus = EX_OSERR;
907
1108
FD_SET(new_plugin->fd, &rfds_all);
909
if (maxfd < new_plugin->fd){
1110
if(maxfd < new_plugin->fd){
910
1111
maxfd = new_plugin->fd;
1119
free_plugin(getplugin(NULL));
917
1121
for(plugin *p = plugin_list; p != NULL; p = p->next){
918
1122
if(p->pid != 0){
929
1133
while(plugin_list){
930
1134
fd_set rfds = rfds_all;
931
1135
int select_ret = select(maxfd+1, &rfds, NULL, NULL, NULL);
932
if (select_ret == -1){
934
exitstatus = EXIT_FAILURE;
1136
if(select_ret == -1 and errno != EINTR){
1137
error(0, errno, "select");
1138
exitstatus = EX_OSERR;
937
1141
/* OK, now either a process completed, or something can be read
938
1142
from one of them */
939
1143
for(plugin *proc = plugin_list; proc != NULL;){
940
1144
/* Is this process completely done? */
941
if(proc->eof and proc->completed){
1145
if(proc->completed and proc->eof){
942
1146
/* Only accept the plugin output if it exited cleanly */
943
1147
if(not WIFEXITED(proc->status)
944
1148
or WEXITSTATUS(proc->status) != 0){
945
1149
/* Bad exit by plugin */
948
1152
if(WIFEXITED(proc->status)){
949
fprintf(stderr, "Plugin %u exited with status %d\n",
950
(unsigned int) (proc->pid),
1153
fprintf(stderr, "Plugin %s [%" PRIdMAX "] exited with"
1154
" status %d\n", proc->name,
1155
(intmax_t) (proc->pid),
951
1156
WEXITSTATUS(proc->status));
952
} else if(WIFSIGNALED(proc->status)) {
953
fprintf(stderr, "Plugin %u killed by signal %d\n",
954
(unsigned int) (proc->pid),
955
WTERMSIG(proc->status));
956
} else if(WCOREDUMP(proc->status)){
957
fprintf(stderr, "Plugin %d dumped core\n",
958
(unsigned int) (proc->pid));
1157
} else if(WIFSIGNALED(proc->status)){
1158
fprintf(stderr, "Plugin %s [%" PRIdMAX "] killed by"
1159
" signal %d: %s\n", proc->name,
1160
(intmax_t) (proc->pid),
1161
WTERMSIG(proc->status),
1162
strsignal(WTERMSIG(proc->status)));
962
1166
/* Remove the plugin */
963
1167
FD_CLR(proc->fd, &rfds_all);
965
1169
/* Block signal while modifying process_list */
966
ret = sigprocmask(SIG_BLOCK, &sigchld_action.sa_mask, NULL);
1170
ret = (int)TEMP_FAILURE_RETRY(sigprocmask
1172
&sigchld_action.sa_mask,
968
perror("sigprocmask");
969
exitstatus = EXIT_FAILURE;
1175
error(0, errno, "sigprocmask");
1176
exitstatus = EX_OSERR;