To get this branch, use:
bzr branch
http://bzr.recompile.se/loggerhead/mandos/trunk
« back to all changes in this revision
Viewing changes to plugin-runner.c
- browse files at revision 906
- compare with another revision
- download diff
- download tarball
- view history from revision 906
- Committer: Teddy Hogeborn
- Date: 2017-08-20 14:41:20 UTC
- Revision ID: teddy@recompile.se-20170820144120-ee0hsyhvo1geg8ms
Handle multiple lines better in cryptroot file.
* initramfs-tools-script: Avoid running plugin-runner more than once
if the root file system device is specially marked in the cryptroot
file. Also never run plugin-runner for a resume (usually swap)
device.
* initramfs-tools-script: Avoid running plugin-runner more than once
if the root file system device is specially marked in the cryptroot
file. Also never run plugin-runner for a resume (usually swap)
device.
- files added:
- DBUS-API
- debian/source
- debian/upstream
- network-hooks.d
- plugin-helpers
- files modified:
- .bzrignore
added
removed
plugin-runner.c
1
/* -*- coding: utf-8 -*- */
1
/* -*- coding: utf-8; mode: c; mode: orgtbl -*- */
2
2
/*
3
3
* Mandos plugin runner - Run Mandos plugins
4
4
*
5
* Copyright © 2008,2009 Teddy Hogeborn
6
* Copyright © 2008,2009 Björn Påhlsson
5
* Copyright © 2008-2017 Teddy Hogeborn
6
* Copyright © 2008-2017 Björn Påhlsson
7
7
*
8
8
* This program is free software: you can redistribute it and/or
9
9
* modify it under the terms of the GNU General Public License as
19
19
* along with this program. If not, see
20
20
* <http://www.gnu.org/licenses/>.
21
21
*
22
* Contact the authors at <mandos@fukt.bsnet.se>.
22
* Contact the authors at <mandos@recompile.se>.
23
23
*/
24
24
25
25
#define _GNU_SOURCE /* TEMP_FAILURE_RETRY(), getline(),
26
asprintf() */
26
O_CLOEXEC, pipe2() */
27
27
#include <stddef.h> /* size_t, NULL */
28
#include <stdlib.h> /* malloc(), exit(), EXIT_FAILURE,
29
EXIT_SUCCESS, realloc() */
28
#include <stdlib.h> /* malloc(), exit(), EXIT_SUCCESS,
29
realloc() */
30
30
#include <stdbool.h> /* bool, true, false */
31
#include <stdio.h> /* perror, fileno(), fprintf(),
32
stderr, STDOUT_FILENO */
33
#include <sys/types.h> /* DIR, opendir(), stat(), struct
34
stat, waitpid(), WIFEXITED(),
35
WEXITSTATUS(), wait(), pid_t,
36
uid_t, gid_t, getuid(), getgid(),
37
dirfd() */
31
#include <stdio.h> /* fileno(), fprintf(),
32
stderr, STDOUT_FILENO, fclose() */
33
#include <sys/types.h> /* fstat(), struct stat, waitpid(),
34
WIFEXITED(), WEXITSTATUS(), wait(),
35
pid_t, uid_t, gid_t, getuid(),
36
getgid() */
38
37
#include <sys/select.h> /* fd_set, select(), FD_ZERO(),
39
38
FD_SET(), FD_ISSET(), FD_CLR */
40
39
#include <sys/wait.h> /* wait(), waitpid(), WIFEXITED(),
41
WEXITSTATUS(), WTERMSIG(),
42
WCOREDUMP() */
43
#include <sys/stat.h> /* struct stat, stat(), S_ISREG() */
40
WEXITSTATUS(), WTERMSIG() */
41
#include <sys/stat.h> /* struct stat, fstat(), S_ISREG() */
44
42
#include <iso646.h> /* and, or, not */
45
#include <dirent.h> /* DIR, struct dirent, opendir(),
46
readdir(), closedir(), dirfd() */
47
#include <unistd.h> /* struct stat, stat(), S_ISREG(),
48
fcntl(), setuid(), setgid(),
49
F_GETFD, F_SETFD, FD_CLOEXEC,
50
access(), pipe(), fork(), close()
51
dup2(), STDOUT_FILENO, _exit(),
52
execv(), write(), read(),
53
close() */
43
#include <dirent.h> /* struct dirent, scandirat() */
44
#include <unistd.h> /* fcntl(), F_GETFD, F_SETFD,
45
FD_CLOEXEC, write(), STDOUT_FILENO,
46
struct stat, fstat(), close(),
47
setgid(), setuid(), S_ISREG(),
48
faccessat() pipe2(), fork(),
49
_exit(), dup2(), fexecve(), read()
50
*/
54
51
#include <fcntl.h> /* fcntl(), F_GETFD, F_SETFD,
55
FD_CLOEXEC */
56
#include <string.h> /* strsep, strlen(), asprintf(),
57
strsignal() */
52
FD_CLOEXEC, openat(), scandirat(),
53
pipe2() */
54
#include <string.h> /* strsep, strlen(), strsignal(),
55
strcmp(), strncmp() */
58
56
#include <errno.h> /* errno */
59
57
#include <argp.h> /* struct argp_option, struct
60
58
argp_state, struct argp,
68
66
*/
69
67
#include <errno.h> /* errno, EBADF */
70
68
#include <inttypes.h> /* intmax_t, PRIdMAX, strtoimax() */
69
#include <sysexits.h> /* EX_OSERR, EX_USAGE, EX_IOERR,
70
EX_CONFIG, EX_UNAVAILABLE, EX_OK */
71
#include <errno.h> /* errno */
72
#include <error.h> /* error() */
73
#include <fnmatch.h> /* fnmatch() */
71
74
72
75
#define BUFFER_SIZE 256
73
76
74
77
#define PDIR "/lib/mandos/plugins.d"
78
#define PHDIR "/lib/mandos/plugin-helpers"
75
79
#define AFILE "/conf/conf.d/mandos/plugin-runner.conf"
76
80
77
81
const char *argp_program_version = "plugin-runner " VERSION;
78
const char *argp_program_bug_address = "<mandos@fukt.bsnet.se>";
82
const char *argp_program_bug_address = "<mandos@recompile.se>";
79
83
80
84
typedef struct plugin{
81
85
char *name; /* can be NULL or any plugin name */
101
105
102
106
/* Gets an existing plugin based on name,
103
107
or if none is found, creates a new one */
108
__attribute__((warn_unused_result))
104
109
static plugin *getplugin(char *name){
105
/* Check for exiting plugin with that name */
110
/* Check for existing plugin with that name */
106
111
for(plugin *p = plugin_list; p != NULL; p = p->next){
107
112
if((p->name == name)
108
113
or (p->name and name and (strcmp(p->name, name) == 0))){
110
115
}
111
116
}
112
117
/* Create a new plugin */
113
plugin *new_plugin = malloc(sizeof(plugin));
118
plugin *new_plugin = NULL;
119
do {
120
new_plugin = malloc(sizeof(plugin));
121
} while(new_plugin == NULL and errno == EINTR);
114
122
if(new_plugin == NULL){
115
123
return NULL;
116
124
}
117
125
char *copy_name = NULL;
118
126
if(name != NULL){
119
copy_name = strdup(name);
127
do {
128
copy_name = strdup(name);
129
} while(copy_name == NULL and errno == EINTR);
120
130
if(copy_name == NULL){
131
int e = errno;
121
132
free(new_plugin);
133
errno = e;
122
134
return NULL;
123
135
}
124
136
}
128
140
.disabled = false,
129
141
.next = plugin_list };
130
142
131
new_plugin->argv = malloc(sizeof(char *) * 2);
143
do {
144
new_plugin->argv = malloc(sizeof(char *) * 2);
145
} while(new_plugin->argv == NULL and errno == EINTR);
132
146
if(new_plugin->argv == NULL){
147
int e = errno;
133
148
free(copy_name);
134
149
free(new_plugin);
150
errno = e;
135
151
return NULL;
136
152
}
137
153
new_plugin->argv[0] = copy_name;
138
154
new_plugin->argv[1] = NULL;
139
155
140
new_plugin->environ = malloc(sizeof(char *));
156
do {
157
new_plugin->environ = malloc(sizeof(char *));
158
} while(new_plugin->environ == NULL and errno == EINTR);
141
159
if(new_plugin->environ == NULL){
160
int e = errno;
142
161
free(copy_name);
143
162
free(new_plugin->argv);
144
163
free(new_plugin);
164
errno = e;
145
165
return NULL;
146
166
}
147
167
new_plugin->environ[0] = NULL;
152
172
}
153
173
154
174
/* Helper function for add_argument and add_environment */
175
__attribute__((nonnull, warn_unused_result))
155
176
static bool add_to_char_array(const char *new, char ***array,
156
177
int *len){
157
178
/* Resize the pointed-to array to hold one more pointer */
158
*array = realloc(*array, sizeof(char *)
159
* (size_t) ((*len) + 2));
179
char **new_array = NULL;
180
do {
181
new_array = realloc(*array, sizeof(char *)
182
* (size_t) ((*len) + 2));
183
} while(new_array == NULL and errno == EINTR);
160
184
/* Malloc check */
161
if(*array == NULL){
185
if(new_array == NULL){
162
186
return false;
163
187
}
188
*array = new_array;
164
189
/* Make a copy of the new string */
165
char *copy = strdup(new);
190
char *copy;
191
do {
192
copy = strdup(new);
193
} while(copy == NULL and errno == EINTR);
166
194
if(copy == NULL){
167
195
return false;
168
196
}
175
203
}
176
204
177
205
/* Add to a plugin's argument vector */
206
__attribute__((nonnull(2), warn_unused_result))
178
207
static bool add_argument(plugin *p, const char *arg){
179
208
if(p == NULL){
180
209
return false;
183
212
}
184
213
185
214
/* Add to a plugin's environment */
215
__attribute__((nonnull(2), warn_unused_result))
186
216
static bool add_environment(plugin *p, const char *def, bool replace){
187
217
if(p == NULL){
188
218
return false;
190
220
/* namelen = length of name of environment variable */
191
221
size_t namelen = (size_t)(strchrnul(def, '=') - def);
192
222
/* Search for this environment variable */
193
for(char **e = p->environ; *e != NULL; e++){
194
if(strncmp(*e, def, namelen + 1) == 0){
223
for(char **envdef = p->environ; *envdef != NULL; envdef++){
224
if(strncmp(*envdef, def, namelen + 1) == 0){
195
225
/* It already exists */
196
226
if(replace){
197
char *new = realloc(*e, strlen(def) + 1);
198
if(new == NULL){
227
char *new_envdef;
228
do {
229
new_envdef = realloc(*envdef, strlen(def) + 1);
230
} while(new_envdef == NULL and errno == EINTR);
231
if(new_envdef == NULL){
199
232
return false;
200
233
}
201
*e = new;
202
strcpy(*e, def);
234
*envdef = new_envdef;
235
strcpy(*envdef, def);
203
236
}
204
237
return true;
205
238
}
207
240
return add_to_char_array(def, &(p->environ), &(p->envc));
208
241
}
209
242
243
#ifndef O_CLOEXEC
210
244
/*
211
245
* Based on the example in the GNU LibC manual chapter 13.13 "File
212
246
* Descriptor Flags".
213
* *Note File Descriptor Flags:(libc)Descriptor Flags.
247
| [[info:libc:Descriptor%20Flags][File Descriptor Flags]] |
214
248
*/
249
__attribute__((warn_unused_result))
215
250
static int set_cloexec_flag(int fd){
216
int ret = fcntl(fd, F_GETFD, 0);
251
int ret = (int)TEMP_FAILURE_RETRY(fcntl(fd, F_GETFD, 0));
217
252
/* If reading the flags failed, return error indication now. */
218
253
if(ret < 0){
219
254
return ret;
220
255
}
221
256
/* Store modified flag word in the descriptor. */
222
return fcntl(fd, F_SETFD, ret | FD_CLOEXEC);
257
return (int)TEMP_FAILURE_RETRY(fcntl(fd, F_SETFD,
258
ret | FD_CLOEXEC));
223
259
}
260
#endif /* not O_CLOEXEC */
224
261
225
262
226
263
/* Mark processes as completed when they exit, and save their exit
240
277
/* No child processes */
241
278
break;
242
279
}
243
perror("waitpid");
280
error(0, errno, "waitpid");
244
281
}
245
282
246
283
/* A child exited, find it in process_list */
258
295
}
259
296
260
297
/* Prints out a password to stdout */
298
__attribute__((nonnull, warn_unused_result))
261
299
static bool print_out_password(const char *buffer, size_t length){
262
300
ssize_t ret;
263
301
for(size_t written = 0; written < length; written += (size_t)ret){
271
309
}
272
310
273
311
/* Removes and free a plugin from the plugin list */
312
__attribute__((nonnull))
274
313
static void free_plugin(plugin *plugin_node){
275
314
276
315
for(char **arg = plugin_node->argv; *arg != NULL; arg++){
308
347
309
348
int main(int argc, char *argv[]){
310
349
char *plugindir = NULL;
350
char *pluginhelperdir = NULL;
311
351
char *argfile = NULL;
312
352
FILE *conffp;
313
size_t d_name_len;
314
DIR *dir = NULL;
315
struct dirent *dirst;
353
struct dirent **direntries = NULL;
316
354
struct stat st;
317
355
fd_set rfds_all;
318
356
int ret, maxfd = 0;
319
357
ssize_t sret;
320
intmax_t tmpmax;
321
358
uid_t uid = 65534;
322
359
gid_t gid = 65534;
323
360
bool debug = false;
327
364
.sa_flags = SA_NOCLDSTOP };
328
365
char **custom_argv = NULL;
329
366
int custom_argc = 0;
367
int dir_fd = -1;
330
368
331
369
/* Establish a signal handler */
332
370
sigemptyset(&sigchld_action.sa_mask);
333
371
ret = sigaddset(&sigchld_action.sa_mask, SIGCHLD);
334
372
if(ret == -1){
335
perror("sigaddset");
336
exitstatus = EXIT_FAILURE;
373
error(0, errno, "sigaddset");
374
exitstatus = EX_OSERR;
337
375
goto fallback;
338
376
}
339
377
ret = sigaction(SIGCHLD, &sigchld_action, &old_sigchld_action);
340
378
if(ret == -1){
341
perror("sigaction");
342
exitstatus = EXIT_FAILURE;
379
error(0, errno, "sigaction");
380
exitstatus = EX_OSERR;
343
381
goto fallback;
344
382
}
345
383
377
415
.doc = "Group ID the plugins will run as", .group = 3 },
378
416
{ .name = "debug", .key = 132,
379
417
.doc = "Debug mode", .group = 4 },
418
{ .name = "plugin-helper-dir", .key = 133,
419
.arg = "DIRECTORY",
420
.doc = "Specify a different plugin helper directory",
421
.group = 2 },
422
/*
423
* These reproduce what we would get without ARGP_NO_HELP
424
*/
425
{ .name = "help", .key = '?',
426
.doc = "Give this help list", .group = -1 },
427
{ .name = "usage", .key = -3,
428
.doc = "Give a short usage message", .group = -1 },
429
{ .name = "version", .key = 'V',
430
.doc = "Print program version", .group = -1 },
380
431
{ .name = NULL }
381
432
};
382
433
383
error_t parse_opt(int key, char *arg, __attribute__((unused))
384
struct argp_state *state){
385
char *tmp;
434
__attribute__((nonnull(3)))
435
error_t parse_opt(int key, char *arg, struct argp_state *state){
436
errno = 0;
386
437
switch(key){
438
char *tmp;
439
intmax_t tmp_id;
387
440
case 'g': /* --global-options */
388
if(arg != NULL){
441
{
389
442
char *plugin_option;
390
443
while((plugin_option = strsep(&arg, ",")) != NULL){
391
if(plugin_option[0] == '\0'){
392
continue;
393
}
394
444
if(not add_argument(getplugin(NULL), plugin_option)){
395
perror("add_argument");
396
return ARGP_ERR_UNKNOWN;
445
break;
397
446
}
398
447
}
448
errno = 0;
399
449
}
400
450
break;
401
451
case 'G': /* --global-env */
402
if(arg == NULL){
403
break;
404
}
405
if(not add_environment(getplugin(NULL), arg, true)){
406
perror("add_environment");
452
if(add_environment(getplugin(NULL), arg, true)){
453
errno = 0;
407
454
}
408
455
break;
409
456
case 'o': /* --options-for */
410
if(arg != NULL){
411
char *plugin_name = strsep(&arg, ":");
412
if(plugin_name[0] == '\0'){
413
break;
414
}
415
char *plugin_option;
416
while((plugin_option = strsep(&arg, ",")) != NULL){
417
if(not add_argument(getplugin(plugin_name), plugin_option)){
418
perror("add_argument");
419
return ARGP_ERR_UNKNOWN;
457
{
458
char *option_list = strchr(arg, ':');
459
if(option_list == NULL){
460
argp_error(state, "No colon in \"%s\"", arg);
461
errno = EINVAL;
462
break;
463
}
464
*option_list = '\0';
465
option_list++;
466
if(arg[0] == '\0'){
467
argp_error(state, "Empty plugin name");
468
errno = EINVAL;
469
break;
470
}
471
char *option;
472
while((option = strsep(&option_list, ",")) != NULL){
473
if(not add_argument(getplugin(arg), option)){
474
break;
420
475
}
421
476
}
477
errno = 0;
422
478
}
423
479
break;
424
480
case 'E': /* --env-for */
425
if(arg == NULL){
426
break;
427
}
428
481
{
429
482
char *envdef = strchr(arg, ':');
430
483
if(envdef == NULL){
484
argp_error(state, "No colon in \"%s\"", arg);
485
errno = EINVAL;
431
486
break;
432
487
}
433
488
*envdef = '\0';
434
if(not add_environment(getplugin(arg), envdef+1, true)){
435
perror("add_environment");
489
envdef++;
490
if(arg[0] == '\0'){
491
argp_error(state, "Empty plugin name");
492
errno = EINVAL;
493
break;
494
}
495
if(add_environment(getplugin(arg), envdef, true)){
496
errno = 0;
436
497
}
437
498
}
438
499
break;
439
500
case 'd': /* --disable */
440
if(arg != NULL){
501
{
441
502
plugin *p = getplugin(arg);
442
if(p == NULL){
443
return ARGP_ERR_UNKNOWN;
503
if(p != NULL){
504
p->disabled = true;
505
errno = 0;
444
506
}
445
p->disabled = true;
446
507
}
447
508
break;
448
509
case 'e': /* --enable */
449
if(arg != NULL){
510
{
450
511
plugin *p = getplugin(arg);
451
if(p == NULL){
452
return ARGP_ERR_UNKNOWN;
512
if(p != NULL){
513
p->disabled = false;
514
errno = 0;
453
515
}
454
p->disabled = false;
455
516
}
456
517
break;
457
518
case 128: /* --plugin-dir */
458
519
free(plugindir);
459
520
plugindir = strdup(arg);
460
if(plugindir == NULL){
461
perror("strdup");
521
if(plugindir != NULL){
522
errno = 0;
462
523
}
463
524
break;
464
525
case 129: /* --config-file */
465
526
/* This is already done by parse_opt_config_file() */
466
527
break;
467
528
case 130: /* --userid */
468
errno = 0;
469
tmpmax = strtoimax(arg, &tmp, 10);
529
tmp_id = strtoimax(arg, &tmp, 10);
470
530
if(errno != 0 or tmp == arg or *tmp != '\0'
471
or tmpmax != (uid_t)tmpmax){
472
fprintf(stderr, "Bad user ID number: \"%s\", using %"
473
PRIdMAX "\n", arg, (intmax_t)uid);
474
} else {
475
uid = (uid_t)tmpmax;
531
or tmp_id != (uid_t)tmp_id){
532
argp_error(state, "Bad user ID number: \"%s\", using %"
533
PRIdMAX, arg, (intmax_t)uid);
534
break;
476
535
}
536
uid = (uid_t)tmp_id;
537
errno = 0;
477
538
break;
478
539
case 131: /* --groupid */
479
errno = 0;
480
tmpmax = strtoimax(arg, &tmp, 10);
540
tmp_id = strtoimax(arg, &tmp, 10);
481
541
if(errno != 0 or tmp == arg or *tmp != '\0'
482
or tmpmax != (gid_t)tmpmax){
483
fprintf(stderr, "Bad group ID number: \"%s\", using %"
484
PRIdMAX "\n", arg, (intmax_t)gid);
485
} else {
486
gid = (gid_t)tmpmax;
542
or tmp_id != (gid_t)tmp_id){
543
argp_error(state, "Bad group ID number: \"%s\", using %"
544
PRIdMAX, arg, (intmax_t)gid);
545
break;
487
546
}
547
gid = (gid_t)tmp_id;
548
errno = 0;
488
549
break;
489
550
case 132: /* --debug */
490
551
debug = true;
491
552
break;
553
case 133: /* --plugin-helper-dir */
554
free(pluginhelperdir);
555
pluginhelperdir = strdup(arg);
556
if(pluginhelperdir != NULL){
557
errno = 0;
558
}
559
break;
560
/*
561
* These reproduce what we would get without ARGP_NO_HELP
562
*/
563
case '?': /* --help */
564
state->flags &= ~(unsigned int)ARGP_NO_EXIT; /* force exit */
565
argp_state_help(state, state->out_stream, ARGP_HELP_STD_HELP);
566
case -3: /* --usage */
567
state->flags &= ~(unsigned int)ARGP_NO_EXIT; /* force exit */
568
argp_state_help(state, state->out_stream,
569
ARGP_HELP_USAGE | ARGP_HELP_EXIT_OK);
570
case 'V': /* --version */
571
fprintf(state->out_stream, "%s\n", argp_program_version);
572
exit(EXIT_SUCCESS);
573
break;
492
574
/*
493
575
* When adding more options before this line, remember to also add a
494
576
* "case" to the "parse_opt_config_file" function below.
497
579
/* Cryptsetup always passes an argument, which is an empty
498
580
string if "none" was specified in /etc/crypttab. So if
499
581
argument was empty, we ignore it silently. */
500
if(arg[0] != '\0'){
501
fprintf(stderr, "Ignoring unknown argument \"%s\"\n", arg);
582
if(arg[0] == '\0'){
583
break;
502
584
}
503
break;
504
case ARGP_KEY_END:
505
break;
506
585
default:
507
586
return ARGP_ERR_UNKNOWN;
508
587
}
509
return 0;
588
return errno; /* Set to 0 at start */
510
589
}
511
590
512
591
/* This option parser is the same as parse_opt() above, except it
514
593
error_t parse_opt_config_file(int key, char *arg,
515
594
__attribute__((unused))
516
595
struct argp_state *state){
596
errno = 0;
517
597
switch(key){
518
598
case 'g': /* --global-options */
519
599
case 'G': /* --global-env */
526
606
case 129: /* --config-file */
527
607
free(argfile);
528
608
argfile = strdup(arg);
529
if(argfile == NULL){
530
perror("strdup");
609
if(argfile != NULL){
610
errno = 0;
531
611
}
532
612
break;
533
613
case 130: /* --userid */
534
614
case 131: /* --groupid */
535
615
case 132: /* --debug */
616
case 133: /* --plugin-helper-dir */
617
case '?': /* --help */
618
case -3: /* --usage */
619
case 'V': /* --version */
536
620
case ARGP_KEY_ARG:
537
case ARGP_KEY_END:
538
621
break;
539
622
default:
540
623
return ARGP_ERR_UNKNOWN;
541
624
}
542
return 0;
625
return errno;
543
626
}
544
627
545
628
struct argp argp = { .options = options,
549
632
550
633
/* Parse using parse_opt_config_file() in order to get the custom
551
634
config file location, if any. */
552
ret = argp_parse(&argp, argc, argv, ARGP_IN_ORDER, 0, NULL);
553
if(ret == ARGP_ERR_UNKNOWN){
554
fprintf(stderr, "Unknown error while parsing arguments\n");
555
exitstatus = EXIT_FAILURE;
635
ret = argp_parse(&argp, argc, argv,
636
ARGP_IN_ORDER | ARGP_NO_EXIT | ARGP_NO_HELP,
637
NULL, NULL);
638
switch(ret){
639
case 0:
640
break;
641
case ENOMEM:
642
default:
643
errno = ret;
644
error(0, errno, "argp_parse");
645
exitstatus = EX_OSERR;
646
goto fallback;
647
case EINVAL:
648
exitstatus = EX_USAGE;
556
649
goto fallback;
557
650
}
558
651
575
668
custom_argc = 1;
576
669
custom_argv = malloc(sizeof(char*) * 2);
577
670
if(custom_argv == NULL){
578
perror("malloc");
579
exitstatus = EXIT_FAILURE;
671
error(0, errno, "malloc");
672
exitstatus = EX_OSERR;
580
673
goto fallback;
581
674
}
582
675
custom_argv[0] = argv[0];
598
691
}
599
692
new_arg = strdup(p);
600
693
if(new_arg == NULL){
601
perror("strdup");
602
exitstatus = EXIT_FAILURE;
694
error(0, errno, "strdup");
695
exitstatus = EX_OSERR;
603
696
free(org_line);
604
697
goto fallback;
605
698
}
606
699
607
700
custom_argc += 1;
608
custom_argv = realloc(custom_argv, sizeof(char *)
609
* ((unsigned int) custom_argc + 1));
610
if(custom_argv == NULL){
611
perror("realloc");
612
exitstatus = EXIT_FAILURE;
613
free(org_line);
614
goto fallback;
701
{
702
char **new_argv = realloc(custom_argv, sizeof(char *)
703
* ((size_t)custom_argc + 1));
704
if(new_argv == NULL){
705
error(0, errno, "realloc");
706
exitstatus = EX_OSERR;
707
free(new_arg);
708
free(org_line);
709
goto fallback;
710
} else {
711
custom_argv = new_argv;
712
}
615
713
}
616
714
custom_argv[custom_argc-1] = new_arg;
617
715
custom_argv[custom_argc] = NULL;
618
716
}
619
717
}
718
do {
719
ret = fclose(conffp);
720
} while(ret == EOF and errno == EINTR);
721
if(ret == EOF){
722
error(0, errno, "fclose");
723
exitstatus = EX_IOERR;
724
goto fallback;
725
}
620
726
free(org_line);
621
727
} else {
622
728
/* Check for harmful errors and go to fallback. Other errors might
623
729
not affect opening plugins */
624
730
if(errno == EMFILE or errno == ENFILE or errno == ENOMEM){
625
perror("fopen");
626
exitstatus = EXIT_FAILURE;
731
error(0, errno, "fopen");
732
exitstatus = EX_OSERR;
627
733
goto fallback;
628
734
}
629
735
}
630
/* If there was any arguments from configuration file,
631
pass them to parser as command arguments */
736
/* If there were any arguments from the configuration file, pass
737
them to parser as command line arguments */
632
738
if(custom_argv != NULL){
633
ret = argp_parse(&argp, custom_argc, custom_argv, ARGP_IN_ORDER,
634
0, NULL);
635
if(ret == ARGP_ERR_UNKNOWN){
636
fprintf(stderr, "Unknown error while parsing arguments\n");
637
exitstatus = EXIT_FAILURE;
739
ret = argp_parse(&argp, custom_argc, custom_argv,
740
ARGP_IN_ORDER | ARGP_NO_EXIT | ARGP_NO_HELP,
741
NULL, NULL);
742
switch(ret){
743
case 0:
744
break;
745
case ENOMEM:
746
default:
747
errno = ret;
748
error(0, errno, "argp_parse");
749
exitstatus = EX_OSERR;
750
goto fallback;
751
case EINVAL:
752
exitstatus = EX_CONFIG;
638
753
goto fallback;
639
754
}
640
755
}
641
756
642
757
/* Parse actual command line arguments, to let them override the
643
758
config file */
644
ret = argp_parse(&argp, argc, argv, ARGP_IN_ORDER, 0, NULL);
645
if(ret == ARGP_ERR_UNKNOWN){
646
fprintf(stderr, "Unknown error while parsing arguments\n");
647
exitstatus = EXIT_FAILURE;
648
goto fallback;
759
ret = argp_parse(&argp, argc, argv,
760
ARGP_IN_ORDER | ARGP_NO_EXIT | ARGP_NO_HELP,
761
NULL, NULL);
762
switch(ret){
763
case 0:
764
break;
765
case ENOMEM:
766
default:
767
errno = ret;
768
error(0, errno, "argp_parse");
769
exitstatus = EX_OSERR;
770
goto fallback;
771
case EINVAL:
772
exitstatus = EX_USAGE;
773
goto fallback;
774
}
775
776
{
777
char *pluginhelperenv;
778
bool bret = true;
779
ret = asprintf(&pluginhelperenv, "MANDOSPLUGINHELPERDIR=%s",
780
pluginhelperdir != NULL ? pluginhelperdir : PHDIR);
781
if(ret != -1){
782
bret = add_environment(getplugin(NULL), pluginhelperenv, true);
783
}
784
if(ret == -1 or not bret){
785
error(0, errno, "Failed to set MANDOSPLUGINHELPERDIR"
786
" environment variable to \"%s\" for all plugins\n",
787
pluginhelperdir != NULL ? pluginhelperdir : PHDIR);
788
}
789
if(ret != -1){
790
free(pluginhelperenv);
791
}
649
792
}
650
793
651
794
if(debug){
652
for(plugin *p = plugin_list; p != NULL; p=p->next){
795
for(plugin *p = plugin_list; p != NULL; p = p->next){
653
796
fprintf(stderr, "Plugin: %s has %d arguments\n",
654
797
p->name ? p->name : "Global", p->argc - 1);
655
798
for(char **a = p->argv; *a != NULL; a++){
662
805
}
663
806
}
664
807
665
/* Strip permissions down to nobody */
666
setgid(gid);
808
if(getuid() == 0){
809
/* Work around Debian bug #633582:
810
<https://bugs.debian.org/633582> */
811
int plugindir_fd = open(/* plugindir or */ PDIR, O_RDONLY);
812
if(plugindir_fd == -1){
813
if(errno != ENOENT){
814
error(0, errno, "open(\"" PDIR "\")");
815
}
816
} else {
817
ret = (int)TEMP_FAILURE_RETRY(fstat(plugindir_fd, &st));
818
if(ret == -1){
819
error(0, errno, "fstat");
820
} else {
821
if(S_ISDIR(st.st_mode) and st.st_uid == 0 and st.st_gid == 0){
822
ret = fchown(plugindir_fd, uid, gid);
823
if(ret == -1){
824
error(0, errno, "fchown");
825
}
826
}
827
}
828
close(plugindir_fd);
829
}
830
}
831
832
/* Lower permissions */
833
ret = setgid(gid);
667
834
if(ret == -1){
668
perror("setgid");
835
error(0, errno, "setgid");
669
836
}
670
837
ret = setuid(uid);
671
838
if(ret == -1){
672
perror("setuid");
673
}
674
675
if(plugindir == NULL){
676
dir = opendir(PDIR);
677
} else {
678
dir = opendir(plugindir);
679
}
680
681
if(dir == NULL){
682
perror("Could not open plugin dir");
683
exitstatus = EXIT_FAILURE;
684
goto fallback;
685
}
686
687
/* Set the FD_CLOEXEC flag on the directory, if possible */
839
error(0, errno, "setuid");
840
}
841
842
/* Open plugin directory with close_on_exec flag */
688
843
{
689
int dir_fd = dirfd(dir);
690
if(dir_fd >= 0){
691
ret = set_cloexec_flag(dir_fd);
692
if(ret < 0){
693
perror("set_cloexec_flag");
694
exitstatus = EXIT_FAILURE;
695
goto fallback;
844
dir_fd = open(plugindir != NULL ? plugindir : PDIR, O_RDONLY |
845
#ifdef O_CLOEXEC
846
O_CLOEXEC
847
#else /* not O_CLOEXEC */
848
0
849
#endif /* not O_CLOEXEC */
850
);
851
if(dir_fd == -1){
852
error(0, errno, "Could not open plugin dir");
853
exitstatus = EX_UNAVAILABLE;
854
goto fallback;
855
}
856
857
#ifndef O_CLOEXEC
858
/* Set the FD_CLOEXEC flag on the directory */
859
ret = set_cloexec_flag(dir_fd);
860
if(ret < 0){
861
error(0, errno, "set_cloexec_flag");
862
exitstatus = EX_OSERR;
863
goto fallback;
864
}
865
#endif /* O_CLOEXEC */
866
}
867
868
int good_name(const struct dirent * const dirent){
869
const char * const patterns[] = { ".*", "#*#", "*~", "*.dpkg-new",
870
"*.dpkg-old", "*.dpkg-bak",
871
"*.dpkg-divert", NULL };
872
#ifdef __GNUC__
873
#pragma GCC diagnostic push
874
#pragma GCC diagnostic ignored "-Wcast-qual"
875
#endif
876
for(const char **pat = (const char **)patterns;
877
*pat != NULL; pat++){
878
#ifdef __GNUC__
879
#pragma GCC diagnostic pop
880
#endif
881
if(fnmatch(*pat, dirent->d_name, FNM_FILE_NAME | FNM_PERIOD)
882
!= FNM_NOMATCH){
883
if(debug){
884
fprintf(stderr, "Ignoring plugin dir entry \"%s\""
885
" matching pattern %s\n", dirent->d_name, *pat);
886
}
887
return 0;
696
888
}
697
889
}
890
return 1;
891
}
892
893
int numplugins = scandirat(dir_fd, ".", &direntries, good_name,
894
alphasort);
895
if(numplugins == -1){
896
error(0, errno, "Could not scan plugin dir");
897
direntries = NULL;
898
exitstatus = EX_OSERR;
899
goto fallback;
698
900
}
699
901
700
902
FD_ZERO(&rfds_all);
701
903
702
904
/* Read and execute any executable in the plugin directory*/
703
while(true){
704
dirst = readdir(dir);
705
706
/* All directory entries have been processed */
707
if(dirst == NULL){
708
if(errno == EBADF){
709
perror("readdir");
710
exitstatus = EXIT_FAILURE;
711
goto fallback;
712
}
713
break;
714
}
715
716
d_name_len = strlen(dirst->d_name);
717
718
/* Ignore dotfiles, backup files and other junk */
719
{
720
bool bad_name = false;
721
722
const char const *bad_prefixes[] = { ".", "#", NULL };
723
724
const char const *bad_suffixes[] = { "~", "#", ".dpkg-new",
725
".dpkg-old",
726
".dpkg-bak",
727
".dpkg-divert", NULL };
728
for(const char **pre = bad_prefixes; *pre != NULL; pre++){
729
size_t pre_len = strlen(*pre);
730
if((d_name_len >= pre_len)
731
and strncmp((dirst->d_name), *pre, pre_len) == 0){
732
if(debug){
733
fprintf(stderr, "Ignoring plugin dir entry \"%s\""
734
" with bad prefix %s\n", dirst->d_name, *pre);
735
}
736
bad_name = true;
737
break;
738
}
739
}
740
if(bad_name){
741
continue;
742
}
743
for(const char **suf = bad_suffixes; *suf != NULL; suf++){
744
size_t suf_len = strlen(*suf);
745
if((d_name_len >= suf_len)
746
and (strcmp((dirst->d_name)+d_name_len-suf_len, *suf)
747
== 0)){
748
if(debug){
749
fprintf(stderr, "Ignoring plugin dir entry \"%s\""
750
" with bad suffix %s\n", dirst->d_name, *suf);
751
}
752
bad_name = true;
753
break;
754
}
755
}
756
757
if(bad_name){
758
continue;
759
}
760
}
761
762
char *filename;
763
if(plugindir == NULL){
764
ret = asprintf(&filename, PDIR "/%s", dirst->d_name);
765
} else {
766
ret = asprintf(&filename, "%s/%s", plugindir, dirst->d_name);
767
}
768
if(ret < 0){
769
perror("asprintf");
905
for(int i = 0; i < numplugins; i++){
906
907
int plugin_fd = openat(dir_fd, direntries[i]->d_name, O_RDONLY);
908
if(plugin_fd == -1){
909
error(0, errno, "Could not open plugin");
910
free(direntries[i]);
770
911
continue;
771
912
}
772
773
ret = stat(filename, &st);
913
ret = (int)TEMP_FAILURE_RETRY(fstat(plugin_fd, &st));
774
914
if(ret == -1){
775
perror("stat");
776
free(filename);
915
error(0, errno, "stat");
916
close(plugin_fd);
917
free(direntries[i]);
777
918
continue;
778
919
}
779
920
780
921
/* Ignore non-executable files */
781
if(not S_ISREG(st.st_mode) or (access(filename, X_OK) != 0)){
922
if(not S_ISREG(st.st_mode)
923
or (TEMP_FAILURE_RETRY(faccessat(dir_fd, direntries[i]->d_name,
924
X_OK, 0)) != 0)){
782
925
if(debug){
783
fprintf(stderr, "Ignoring plugin dir entry \"%s\""
784
" with bad type or mode\n", filename);
926
fprintf(stderr, "Ignoring plugin dir entry \"%s/%s\""
927
" with bad type or mode\n",
928
plugindir != NULL ? plugindir : PDIR,
929
direntries[i]->d_name);
785
930
}
786
free(filename);
931
close(plugin_fd);
932
free(direntries[i]);
787
933
continue;
788
934
}
789
935
790
plugin *p = getplugin(dirst->d_name);
936
plugin *p = getplugin(direntries[i]->d_name);
791
937
if(p == NULL){
792
perror("getplugin");
793
free(filename);
938
error(0, errno, "getplugin");
939
close(plugin_fd);
940
free(direntries[i]);
794
941
continue;
795
942
}
796
943
if(p->disabled){
797
944
if(debug){
798
945
fprintf(stderr, "Ignoring disabled plugin \"%s\"\n",
799
dirst->d_name);
946
direntries[i]->d_name);
800
947
}
801
free(filename);
948
close(plugin_fd);
949
free(direntries[i]);
802
950
continue;
803
951
}
804
952
{
807
955
if(g != NULL){
808
956
for(char **a = g->argv + 1; *a != NULL; a++){
809
957
if(not add_argument(p, *a)){
810
perror("add_argument");
958
error(0, errno, "add_argument");
811
959
}
812
960
}
813
961
/* Add global environment variables */
814
962
for(char **e = g->environ; *e != NULL; e++){
815
963
if(not add_environment(p, *e, false)){
816
perror("add_environment");
964
error(0, errno, "add_environment");
817
965
}
818
966
}
819
967
}
820
968
}
821
/* If this plugin has any environment variables, we will call
822
using execve and need to duplicate the environment from this
823
process, too. */
969
/* If this plugin has any environment variables, we need to
970
duplicate the environment from this process, too. */
824
971
if(p->environ[0] != NULL){
825
972
for(char **e = environ; *e != NULL; e++){
826
973
if(not add_environment(p, *e, false)){
827
perror("add_environment");
974
error(0, errno, "add_environment");
828
975
}
829
976
}
830
977
}
831
978
832
979
int pipefd[2];
833
ret = pipe(pipefd);
980
#ifndef O_CLOEXEC
981
ret = (int)TEMP_FAILURE_RETRY(pipe(pipefd));
982
#else /* O_CLOEXEC */
983
ret = (int)TEMP_FAILURE_RETRY(pipe2(pipefd, O_CLOEXEC));
984
#endif /* O_CLOEXEC */
834
985
if(ret == -1){
835
perror("pipe");
836
exitstatus = EXIT_FAILURE;
837
goto fallback;
838
}
986
error(0, errno, "pipe");
987
exitstatus = EX_OSERR;
988
free(direntries[i]);
989
goto fallback;
990
}
991
if(pipefd[0] >= FD_SETSIZE){
992
fprintf(stderr, "pipe()[0] (%d) >= FD_SETSIZE (%d)", pipefd[0],
993
FD_SETSIZE);
994
close(pipefd[0]);
995
close(pipefd[1]);
996
exitstatus = EX_OSERR;
997
free(direntries[i]);
998
goto fallback;
999
}
1000
#ifndef O_CLOEXEC
839
1001
/* Ask OS to automatic close the pipe on exec */
840
1002
ret = set_cloexec_flag(pipefd[0]);
841
1003
if(ret < 0){
842
perror("set_cloexec_flag");
843
exitstatus = EXIT_FAILURE;
1004
error(0, errno, "set_cloexec_flag");
1005
close(pipefd[0]);
1006
close(pipefd[1]);
1007
exitstatus = EX_OSERR;
1008
free(direntries[i]);
844
1009
goto fallback;
845
1010
}
846
1011
ret = set_cloexec_flag(pipefd[1]);
847
1012
if(ret < 0){
848
perror("set_cloexec_flag");
849
exitstatus = EXIT_FAILURE;
1013
error(0, errno, "set_cloexec_flag");
1014
close(pipefd[0]);
1015
close(pipefd[1]);
1016
exitstatus = EX_OSERR;
1017
free(direntries[i]);
850
1018
goto fallback;
851
1019
}
1020
#endif /* not O_CLOEXEC */
852
1021
/* Block SIGCHLD until process is safely in process list */
853
ret = sigprocmask(SIG_BLOCK, &sigchld_action.sa_mask, NULL);
1022
ret = (int)TEMP_FAILURE_RETRY(sigprocmask(SIG_BLOCK,
1023
&sigchld_action.sa_mask,
1024
NULL));
854
1025
if(ret < 0){
855
perror("sigprocmask");
856
exitstatus = EXIT_FAILURE;
1026
error(0, errno, "sigprocmask");
1027
exitstatus = EX_OSERR;
1028
free(direntries[i]);
857
1029
goto fallback;
858
1030
}
859
1031
/* Starting a new process to be watched */
860
pid_t pid = fork();
1032
pid_t pid;
1033
do {
1034
pid = fork();
1035
} while(pid == -1 and errno == EINTR);
861
1036
if(pid == -1){
862
perror("fork");
863
exitstatus = EXIT_FAILURE;
1037
error(0, errno, "fork");
1038
TEMP_FAILURE_RETRY(sigprocmask(SIG_UNBLOCK,
1039
&sigchld_action.sa_mask, NULL));
1040
close(pipefd[0]);
1041
close(pipefd[1]);
1042
exitstatus = EX_OSERR;
1043
free(direntries[i]);
864
1044
goto fallback;
865
1045
}
866
1046
if(pid == 0){
867
1047
/* this is the child process */
868
1048
ret = sigaction(SIGCHLD, &old_sigchld_action, NULL);
869
1049
if(ret < 0){
870
perror("sigaction");
871
_exit(EXIT_FAILURE);
1050
error(0, errno, "sigaction");
1051
_exit(EX_OSERR);
872
1052
}
873
1053
ret = sigprocmask(SIG_UNBLOCK, &sigchld_action.sa_mask, NULL);
874
1054
if(ret < 0){
875
perror("sigprocmask");
876
_exit(EXIT_FAILURE);
1055
error(0, errno, "sigprocmask");
1056
_exit(EX_OSERR);
877
1057
}
878
1058
879
1059
ret = dup2(pipefd[1], STDOUT_FILENO); /* replace our stdout */
880
1060
if(ret == -1){
881
perror("dup2");
882
_exit(EXIT_FAILURE);
1061
error(0, errno, "dup2");
1062
_exit(EX_OSERR);
883
1063
}
884
1064
885
if(dirfd(dir) < 0){
886
/* If dir has no file descriptor, we could not set FD_CLOEXEC
887
above and must now close it manually here. */
888
closedir(dir);
889
}
890
if(p->environ[0] == NULL){
891
if(execv(filename, p->argv) < 0){
892
perror("execv");
893
_exit(EXIT_FAILURE);
894
}
895
} else {
896
if(execve(filename, p->argv, p->environ) < 0){
897
perror("execve");
898
_exit(EXIT_FAILURE);
899
}
1065
if(fexecve(plugin_fd, p->argv,
1066
(p->environ[0] != NULL) ? p->environ : environ) < 0){
1067
error(0, errno, "fexecve for %s/%s",
1068
plugindir != NULL ? plugindir : PDIR,
1069
direntries[i]->d_name);
1070
_exit(EX_OSERR);
900
1071
}
901
1072
/* no return */
902
1073
}
903
1074
/* Parent process */
904
1075
close(pipefd[1]); /* Close unused write end of pipe */
905
free(filename);
906
plugin *new_plugin = getplugin(dirst->d_name);
1076
close(plugin_fd);
1077
plugin *new_plugin = getplugin(direntries[i]->d_name);
907
1078
if(new_plugin == NULL){
908
perror("getplugin");
909
ret = sigprocmask(SIG_UNBLOCK, &sigchld_action.sa_mask, NULL);
1079
error(0, errno, "getplugin");
1080
ret = (int)(TEMP_FAILURE_RETRY
1081
(sigprocmask(SIG_UNBLOCK, &sigchld_action.sa_mask,
1082
NULL)));
910
1083
if(ret < 0){
911
perror("sigprocmask");
1084
error(0, errno, "sigprocmask");
912
1085
}
913
exitstatus = EXIT_FAILURE;
1086
exitstatus = EX_OSERR;
1087
free(direntries[i]);
914
1088
goto fallback;
915
1089
}
1090
free(direntries[i]);
916
1091
917
1092
new_plugin->pid = pid;
918
1093
new_plugin->fd = pipefd[0];
919
1094
920
1095
/* Unblock SIGCHLD so signal handler can be run if this process
921
1096
has already completed */
922
ret = sigprocmask(SIG_UNBLOCK, &sigchld_action.sa_mask, NULL);
1097
ret = (int)TEMP_FAILURE_RETRY(sigprocmask(SIG_UNBLOCK,
1098
&sigchld_action.sa_mask,
1099
NULL));
923
1100
if(ret < 0){
924
perror("sigprocmask");
925
exitstatus = EXIT_FAILURE;
1101
error(0, errno, "sigprocmask");
1102
exitstatus = EX_OSERR;
926
1103
goto fallback;
927
1104
}
928
1105
933
1110
}
934
1111
}
935
1112
936
closedir(dir);
937
dir = NULL;
1113
free(direntries);
1114
direntries = NULL;
1115
close(dir_fd);
1116
dir_fd = -1;
938
1117
free_plugin(getplugin(NULL));
939
1118
940
1119
for(plugin *p = plugin_list; p != NULL; p = p->next){
952
1131
while(plugin_list){
953
1132
fd_set rfds = rfds_all;
954
1133
int select_ret = select(maxfd+1, &rfds, NULL, NULL, NULL);
955
if(select_ret == -1){
956
perror("select");
957
exitstatus = EXIT_FAILURE;
1134
if(select_ret == -1 and errno != EINTR){
1135
error(0, errno, "select");
1136
exitstatus = EX_OSERR;
958
1137
goto fallback;
959
1138
}
960
1139
/* OK, now either a process completed, or something can be read
979
1158
(intmax_t) (proc->pid),
980
1159
WTERMSIG(proc->status),
981
1160
strsignal(WTERMSIG(proc->status)));
982
} else if(WCOREDUMP(proc->status)){
983
fprintf(stderr, "Plugin %s [%" PRIdMAX "] dumped"
984
" core\n", proc->name, (intmax_t) (proc->pid));
985
1161
}
986
1162
}
987
1163
989
1165
FD_CLR(proc->fd, &rfds_all);
990
1166
991
1167
/* Block signal while modifying process_list */
992
ret = sigprocmask(SIG_BLOCK, &sigchld_action.sa_mask, NULL);
1168
ret = (int)TEMP_FAILURE_RETRY(sigprocmask
1169
(SIG_BLOCK,
1170
&sigchld_action.sa_mask,
1171
NULL));
993
1172
if(ret < 0){
994
perror("sigprocmask");
995
exitstatus = EXIT_FAILURE;
1173
error(0, errno, "sigprocmask");
1174
exitstatus = EX_OSERR;
996
1175
goto fallback;
997
1176
}
998
1177
1001
1180
proc = next_plugin;
1002
1181
1003
1182
/* We are done modifying process list, so unblock signal */
1004
ret = sigprocmask(SIG_UNBLOCK, &sigchld_action.sa_mask,
1005
NULL);
1183
ret = (int)(TEMP_FAILURE_RETRY
1184
(sigprocmask(SIG_UNBLOCK,
1185
&sigchld_action.sa_mask, NULL)));
1006
1186
if(ret < 0){
1007
perror("sigprocmask");
1008
exitstatus = EXIT_FAILURE;
1187
error(0, errno, "sigprocmask");
1188
exitstatus = EX_OSERR;
1009
1189
goto fallback;
1010
1190
}
1011
1191
1021
1201
bool bret = print_out_password(proc->buffer,
1022
1202
proc->buffer_length);
1023
1203
if(not bret){
1024
perror("print_out_password");
1025
exitstatus = EXIT_FAILURE;
1204
error(0, errno, "print_out_password");
1205
exitstatus = EX_IOERR;
1026
1206
}
1027
1207
goto fallback;
1028
1208
}
1035
1215
}
1036
1216
/* Before reading, make the process' data buffer large enough */
1037
1217
if(proc->buffer_length + BUFFER_SIZE > proc->buffer_size){
1038
proc->buffer = realloc(proc->buffer, proc->buffer_size
1039
+ (size_t) BUFFER_SIZE);
1040
if(proc->buffer == NULL){
1041
perror("malloc");
1042
exitstatus = EXIT_FAILURE;
1218
char *new_buffer = realloc(proc->buffer, proc->buffer_size
1219
+ (size_t) BUFFER_SIZE);
1220
if(new_buffer == NULL){
1221
error(0, errno, "malloc");
1222
exitstatus = EX_OSERR;
1043
1223
goto fallback;
1044
1224
}
1225
proc->buffer = new_buffer;
1045
1226
proc->buffer_size += BUFFER_SIZE;
1046
1227
}
1047
1228
/* Read from the process */
1048
sret = read(proc->fd, proc->buffer + proc->buffer_length,
1049
BUFFER_SIZE);
1229
sret = TEMP_FAILURE_RETRY(read(proc->fd,
1230
proc->buffer
1231
+ proc->buffer_length,
1232
BUFFER_SIZE));
1050
1233
if(sret < 0){
1051
1234
/* Read error from this process; ignore the error */
1052
1235
proc = proc->next;
1064
1247
1065
1248
fallback:
1066
1249
1067
if(plugin_list == NULL or exitstatus != EXIT_SUCCESS){
1250
if(plugin_list == NULL or (exitstatus != EXIT_SUCCESS
1251
and exitstatus != EX_OK)){
1068
1252
/* Fallback if all plugins failed, none are found or an error
1069
1253
occured */
1070
1254
bool bret;
1078
1262
}
1079
1263
bret = print_out_password(passwordbuffer, len);
1080
1264
if(not bret){
1081
perror("print_out_password");
1082
exitstatus = EXIT_FAILURE;
1265
error(0, errno, "print_out_password");
1266
exitstatus = EX_IOERR;
1083
1267
}
1084
1268
}
1085
1269
1086
1270
/* Restore old signal handler */
1087
1271
ret = sigaction(SIGCHLD, &old_sigchld_action, NULL);
1088
1272
if(ret == -1){
1089
perror("sigaction");
1090
exitstatus = EXIT_FAILURE;
1273
error(0, errno, "sigaction");
1274
exitstatus = EX_OSERR;
1091
1275
}
1092
1276
1093
1277
if(custom_argv != NULL){
1097
1281
free(custom_argv);
1098
1282
}
1099
1283
1100
if(dir != NULL){
1101
closedir(dir);
1284
free(direntries);
1285
1286
if(dir_fd != -1){
1287
close(dir_fd);
1102
1288
}
1103
1289
1104
1290
/* Kill the processes */
1108
1294
ret = kill(p->pid, SIGTERM);
1109
1295
if(ret == -1 and errno != ESRCH){
1110
1296
/* Set-uid proccesses might not get closed */
1111
perror("kill");
1297
error(0, errno, "kill");
1112
1298
}
1113
1299
}
1114
1300
}
1115
1301
1116
1302
/* Wait for any remaining child processes to terminate */
1117
do{
1303
do {
1118
1304
ret = wait(NULL);
1119
1305
} while(ret >= 0);
1120
1306
if(errno != ECHILD){
1121
perror("wait");
1307
error(0, errno, "wait");
1122
1308
}
1123
1309
1124
1310
free_plugin_list();
1125
1311
1126
1312
free(plugindir);
1313
free(pluginhelperdir);
1127
1314
free(argfile);
1128
1315
1129
1316
return exitstatus;
Loggerhead is a web-based interface for Breezy
Version: 2.0.2.dev0