/mandos/trunk

To get this branch, use:
bzr branch http://bzr.recompile.se/loggerhead/mandos/trunk

« back to all changes in this revision

Viewing changes to Makefile

  • Committer: Teddy Hogeborn
  • Date: 2016-10-05 19:56:40 UTC
  • Revision ID: teddy@recompile.se-20161005195640-yrjxv8kkx662usr0
Fix bug where Mandos client would crash on exit

* plugins.d/mandos-client.c (init_gnutls_global): Fix memory leak by
  doing free(params.data) after import.

Show diffs side-by-side

added added

removed removed

Lines of Context:
Makefile
1
 
WARN=-O -Wall -Wformat=2 -Winit-self -Wmissing-include-dirs \
2
 
        -Wswitch-default -Wswitch-enum -Wunused-parameter \
3
 
        -Wstrict-aliasing=1 -Wextra -Wfloat-equal -Wundef -Wshadow \
 
1
WARN=-O -Wall -Wextra -Wdouble-promotion -Wformat=2 -Winit-self \
 
2
        -Wmissing-include-dirs -Wswitch-default -Wswitch-enum \
 
3
        -Wunused -Wuninitialized -Wstrict-overflow=5 \
 
4
        -Wsuggest-attribute=pure -Wsuggest-attribute=const \
 
5
        -Wsuggest-attribute=noreturn -Wfloat-equal -Wundef -Wshadow \
4
6
        -Wunsafe-loop-optimizations -Wpointer-arith \
5
7
        -Wbad-function-cast -Wcast-qual -Wcast-align -Wwrite-strings \
6
 
        -Wconversion -Wstrict-prototypes -Wold-style-definition \
7
 
        -Wpacked -Wnested-externs -Winline -Wvolatile-register-var
8
 
#       -Wunreachable-code
9
 
#DEBUG=-ggdb3
10
 
# For info about _FORTIFY_SOURCE, see
11
 
# <http://www.kernel.org/doc/man-pages/online/pages/man7/feature_test_macros.7.html>
12
 
# and <http://gcc.gnu.org/ml/gcc-patches/2004-09/msg02055.html>.
 
8
        -Wconversion -Wlogical-op -Waggregate-return \
 
9
        -Wstrict-prototypes -Wold-style-definition \
 
10
        -Wmissing-format-attribute -Wnormalized=nfc -Wpacked \
 
11
        -Wredundant-decls -Wnested-externs -Winline -Wvla \
 
12
        -Wvolatile-register-var -Woverlength-strings
 
13
#DEBUG=-ggdb3 -fsanitize=address 
 
14
# For info about _FORTIFY_SOURCE, see feature_test_macros(7)
 
15
# and <https://gcc.gnu.org/ml/gcc-patches/2004-09/msg02055.html>.
13
16
FORTIFY=-D_FORTIFY_SOURCE=2 -fstack-protector-all -fPIC
 
17
# <https://developerblog.redhat.com/2014/10/16/gcc-undefined-behavior-sanitizer-ubsan/>
 
18
ALL_SANITIZE_OPTIONS:=-fsanitize=leak -fsanitize=undefined \
 
19
        -fsanitize=shift -fsanitize=integer-divide-by-zero \
 
20
        -fsanitize=unreachable -fsanitize=vla-bound -fsanitize=null \
 
21
        -fsanitize=return -fsanitize=signed-integer-overflow \
 
22
        -fsanitize=bounds -fsanitize=alignment \
 
23
        -fsanitize=object-size -fsanitize=float-divide-by-zero \
 
24
        -fsanitize=float-cast-overflow -fsanitize=nonnull-attribute \
 
25
        -fsanitize=returns-nonnull-attribute -fsanitize=bool \
 
26
        -fsanitize=enum
 
27
# Check which sanitizing options can be used
 
28
SANITIZE:=$(foreach option,$(ALL_SANITIZE_OPTIONS),$(shell \
 
29
        echo 'int main(){}' | $(CC) --language=c $(option) /dev/stdin \
 
30
        -o /dev/null >/dev/null 2>&1 && echo $(option)))
14
31
LINK_FORTIFY_LD=-z relro -z now
15
32
LINK_FORTIFY=
16
33
 
20
37
LINK_FORTIFY += -pie
21
38
endif
22
39
#COVERAGE=--coverage
23
 
OPTIMIZE=-Os
24
 
LANGUAGE=-std=gnu99
 
40
OPTIMIZE=-Os -fno-strict-aliasing
 
41
LANGUAGE=-std=gnu11
25
42
htmldir=man
26
 
version=1.6.0
 
43
version=1.7.11
27
44
SED=sed
28
45
 
29
46
USER=$(firstword $(subst :, ,$(shell getent passwd _mandos || getent passwd nobody || echo 65534)))
30
 
GROUP=$(firstword $(subst :, ,$(shell getent group _mandos || getent group nobody || echo 65534)))
 
47
GROUP=$(firstword $(subst :, ,$(shell getent group _mandos || getent group nogroup || echo 65534)))
31
48
 
32
49
## Use these settings for a traditional /usr/local install
33
50
# PREFIX=$(DESTDIR)/usr/local
36
53
# MANDIR=$(PREFIX)/man
37
54
# INITRAMFSTOOLS=$(DESTDIR)/etc/initramfs-tools
38
55
# STATEDIR=$(DESTDIR)/var/lib/mandos
 
56
# LIBDIR=$(PREFIX)/lib
39
57
##
40
58
 
41
59
## These settings are for a package-type install
45
63
MANDIR=$(PREFIX)/share/man
46
64
INITRAMFSTOOLS=$(DESTDIR)/usr/share/initramfs-tools
47
65
STATEDIR=$(DESTDIR)/var/lib/mandos
 
66
LIBDIR=$(shell \
 
67
        for d in \
 
68
        "/usr/lib/`dpkg-architecture -qDEB_HOST_MULTIARCH 2>/dev/null`" \
 
69
        "`rpm --eval='%{_libdir}' 2>/dev/null`" /usr/lib; do \
 
70
                if [ -d "$$d" -a "$$d" = "$${d%/}" ]; then \
 
71
                        echo "$(DESTDIR)$$d"; \
 
72
                        break; \
 
73
                fi; \
 
74
        done)
48
75
##
49
76
 
 
77
SYSTEMD=$(DESTDIR)$(shell pkg-config systemd --variable=systemdsystemunitdir)
 
78
TMPFILES=$(DESTDIR)$(shell pkg-config systemd --variable=tmpfilesdir)
 
79
 
50
80
GNUTLS_CFLAGS=$(shell pkg-config --cflags-only-I gnutls)
51
81
GNUTLS_LIBS=$(shell pkg-config --libs gnutls)
52
82
AVAHI_CFLAGS=$(shell pkg-config --cflags-only-I avahi-core)
54
84
GPGME_CFLAGS=$(shell gpgme-config --cflags; getconf LFS_CFLAGS)
55
85
GPGME_LIBS=$(shell gpgme-config --libs; getconf LFS_LIBS; \
56
86
        getconf LFS_LDFLAGS)
 
87
LIBNL3_CFLAGS=$(shell pkg-config --cflags-only-I libnl-route-3.0)
 
88
LIBNL3_LIBS=$(shell pkg-config --libs libnl-route-3.0)
57
89
 
58
90
# Do not change these two
59
 
CFLAGS=$(WARN) $(DEBUG) $(FORTIFY) $(COVERAGE) $(OPTIMIZE) \
60
 
        $(LANGUAGE) $(GNUTLS_CFLAGS) $(AVAHI_CFLAGS) $(GPGME_CFLAGS) \
61
 
        -DVERSION='"$(version)"'
62
 
LDFLAGS=-Xlinker --as-needed $(COVERAGE) $(LINK_FORTIFY) $(foreach flag,$(LINK_FORTIFY_LD),-Xlinker $(flag))
 
91
CFLAGS+=$(WARN) $(DEBUG) $(FORTIFY) $(SANITIZE) $(COVERAGE) \
 
92
        $(OPTIMIZE) $(LANGUAGE) $(GNUTLS_CFLAGS) $(AVAHI_CFLAGS) \
 
93
        $(GPGME_CFLAGS) -DVERSION='"$(version)"'
 
94
LDFLAGS+=-Xlinker --as-needed $(COVERAGE) $(LINK_FORTIFY) $(foreach flag,$(LINK_FORTIFY_LD),-Xlinker $(flag))
63
95
 
64
96
# Commands to format a DocBook <refentry> document into a manual page
65
97
DOCBOOKTOMAN=$(strip cd $(dir $<); xsltproc --nonet --xinclude \
70
102
        --param man.authors.section.enabled     0 \
71
103
        /usr/share/xml/docbook/stylesheet/nwalsh/manpages/docbook.xsl \
72
104
        $(notdir $<); \
73
 
        $(MANPOST) $(notdir $@);\
74
105
        if locale --all 2>/dev/null | grep --regexp='^en_US\.utf8$$' \
75
106
        && type man 2>/dev/null; then LANG=en_US.UTF-8 MANWIDTH=80 \
76
107
        man --warnings --encoding=UTF-8 --local-file $(notdir $@); \
77
108
        fi >/dev/null)
78
 
# DocBook-to-man post-processing to fix a '\n' escape bug
79
 
MANPOST=$(SED) --in-place --expression='s,\\\\en,\\en,g;s,\\n,\\en,g'
80
109
 
81
110
DOCBOOKTOHTML=$(strip xsltproc --nonet --xinclude \
82
111
        --param make.year.ranges                1 \
94
123
PLUGINS=plugins.d/password-prompt plugins.d/mandos-client \
95
124
        plugins.d/usplash plugins.d/splashy plugins.d/askpass-fifo \
96
125
        plugins.d/plymouth
97
 
CPROGS=plugin-runner $(PLUGINS)
 
126
PLUGIN_HELPERS=plugin-helpers/mandos-client-iprouteadddel
 
127
CPROGS=plugin-runner $(PLUGINS) $(PLUGIN_HELPERS)
98
128
PROGS=mandos mandos-keygen mandos-ctl mandos-monitor $(CPROGS)
99
129
DOCS=mandos.8 mandos-keygen.8 mandos-monitor.8 mandos-ctl.8 \
100
130
        mandos.conf.5 mandos-clients.conf.5 plugin-runner.8mandos \
227
257
        $(LINK.c) $^ -lrt $(GNUTLS_LIBS) $(AVAHI_LIBS) $(strip\
228
258
                ) $(GPGME_LIBS) $(LOADLIBES) $(LDLIBS) -o $@
229
259
 
230
 
.PHONY : all doc html clean distclean run-client run-server install \
231
 
        install-server install-client uninstall uninstall-server \
232
 
        uninstall-client purge purge-server purge-client
 
260
plugin-helpers/mandos-client-iprouteadddel: plugin-helpers/mandos-client-iprouteadddel.c
 
261
        $(LINK.c) $(LIBNL3_CFLAGS) $^ $(LIBNL3_LIBS) $(strip\
 
262
                ) $(LOADLIBES) $(LDLIBS) -o $@
 
263
 
 
264
.PHONY : all doc html clean distclean mostlyclean maintainer-clean \
 
265
        check run-client run-server install install-html \
 
266
        install-server install-client-nokey install-client uninstall \
 
267
        uninstall-server uninstall-client purge purge-server \
 
268
        purge-client
233
269
 
234
270
clean:
235
271
        -rm --force $(CPROGS) $(objects) $(htmldocs) $(DOCS) core
250
286
        @echo "# ignored.  The messages are caused by not running as root, but   #"
251
287
        @echo "# you should NOT run \"make run-client\" as root unless you also    #"
252
288
        @echo "# unpacked and compiled Mandos as root, which is NOT recommended. #"
253
 
        @echo "# From plugin-runner: setuid: Operation not permitted             #"
 
289
        @echo "# From plugin-runner: setgid: Operation not permitted             #"
 
290
        @echo "#                     setuid: Operation not permitted             #"
254
291
        @echo "# From askpass-fifo:  mkfifo: Permission denied                   #"
255
 
        @echo "# From mandos-client: setuid: Operation not permitted             #"
256
 
        @echo "#                     seteuid: Operation not permitted            #"
257
 
        @echo "#                     klogctl: Operation not permitted            #"
 
292
        @echo "# From mandos-client:                                             #"
 
293
        @echo "#             Failed to raise privileges: Operation not permitted #"
 
294
        @echo "#             Warning: network hook \"*\" exited with status *      #"
258
295
        @echo "###################################################################"
 
296
# We set GNOME_KEYRING_CONTROL to block pam_gnome_keyring
259
297
        ./plugin-runner --plugin-dir=plugins.d \
 
298
                --plugin-helper-dir=plugin-helpers \
260
299
                --config-file=plugin-runner.conf \
261
300
                --options-for=mandos-client:--seckey=keydir/seckey.txt,--pubkey=keydir/pubkey.txt,--network-hook-dir=network-hooks.d \
 
301
                --env-for=mandos-client:GNOME_KEYRING_CONTROL= \
262
302
                $(CLIENTARGS)
263
303
 
264
304
# Used by run-client
279
319
        install --directory confdir
280
320
        install --mode=u=rw $< $@
281
321
# Add a client password
282
 
        ./mandos-keygen --dir keydir --password >> $@
 
322
        ./mandos-keygen --dir keydir --password --no-ssh >> $@
283
323
statedir:
284
324
        install --directory statedir
285
325
 
292
332
 
293
333
install-server: doc
294
334
        install --directory $(CONFDIR)
295
 
        install --directory --mode=u=rwx --owner=$(USER) \
296
 
                --group=$(GROUP) $(STATEDIR)
 
335
        if install --directory --mode=u=rwx --owner=$(USER) \
 
336
                --group=$(GROUP) $(STATEDIR); then \
 
337
                :; \
 
338
        elif install --directory --mode=u=rwx $(STATEDIR); then \
 
339
                chown -- $(USER):$(GROUP) $(STATEDIR) || :; \
 
340
        fi
 
341
        if [ "$(TMPFILES)" != "$(DESTDIR)" -a -d "$(TMPFILES)" ]; then \
 
342
                install --mode=u=rw,go=r tmpfiles.d-mandos.conf \
 
343
                        $(TMPFILES)/mandos.conf; \
 
344
        fi
297
345
        install --mode=u=rwx,go=rx mandos $(PREFIX)/sbin/mandos
298
346
        install --mode=u=rwx,go=rx --target-directory=$(PREFIX)/sbin \
299
347
                mandos-ctl
307
355
                $(DESTDIR)/etc/dbus-1/system.d/mandos.conf
308
356
        install --mode=u=rwx,go=rx init.d-mandos \
309
357
                $(DESTDIR)/etc/init.d/mandos
 
358
        if [ "$(SYSTEMD)" != "$(DESTDIR)" -a -d "$(SYSTEMD)" ]; then \
 
359
                install --mode=u=rw,go=r mandos.service $(SYSTEMD); \
 
360
        fi
310
361
        install --mode=u=rw,go=r default-mandos \
311
362
                $(DESTDIR)/etc/default/mandos
312
363
        if [ -z $(DESTDIR) ]; then \
326
377
                > $(MANDIR)/man8/intro.8mandos.gz
327
378
 
328
379
install-client-nokey: all doc
329
 
        install --directory $(PREFIX)/lib/mandos $(CONFDIR)
 
380
        install --directory $(LIBDIR)/mandos $(CONFDIR)
330
381
        install --directory --mode=u=rwx $(KEYDIR) \
331
 
                $(PREFIX)/lib/mandos/plugins.d
332
 
        if [ "$(CONFDIR)" != "$(PREFIX)/lib/mandos" ]; then \
 
382
                $(LIBDIR)/mandos/plugins.d \
 
383
                $(LIBDIR)/mandos/plugin-helpers
 
384
        if [ "$(CONFDIR)" != "$(LIBDIR)/mandos" ]; then \
333
385
                install --mode=u=rwx \
334
 
                        --directory "$(CONFDIR)/plugins.d"; \
 
386
                        --directory "$(CONFDIR)/plugins.d" \
 
387
                        "$(CONFDIR)/plugin-helpers"; \
335
388
        fi
336
389
        install --mode=u=rwx,go=rx --directory \
337
390
                "$(CONFDIR)/network-hooks.d"
338
391
        install --mode=u=rwx,go=rx \
339
 
                --target-directory=$(PREFIX)/lib/mandos plugin-runner
 
392
                --target-directory=$(LIBDIR)/mandos plugin-runner
340
393
        install --mode=u=rwx,go=rx --target-directory=$(PREFIX)/sbin \
341
394
                mandos-keygen
342
395
        install --mode=u=rwx,go=rx \
343
 
                --target-directory=$(PREFIX)/lib/mandos/plugins.d \
 
396
                --target-directory=$(LIBDIR)/mandos/plugins.d \
344
397
                plugins.d/password-prompt
345
398
        install --mode=u=rwxs,go=rx \
346
 
                --target-directory=$(PREFIX)/lib/mandos/plugins.d \
 
399
                --target-directory=$(LIBDIR)/mandos/plugins.d \
347
400
                plugins.d/mandos-client
348
401
        install --mode=u=rwxs,go=rx \
349
 
                --target-directory=$(PREFIX)/lib/mandos/plugins.d \
 
402
                --target-directory=$(LIBDIR)/mandos/plugins.d \
350
403
                plugins.d/usplash
351
404
        install --mode=u=rwxs,go=rx \
352
 
                --target-directory=$(PREFIX)/lib/mandos/plugins.d \
 
405
                --target-directory=$(LIBDIR)/mandos/plugins.d \
353
406
                plugins.d/splashy
354
407
        install --mode=u=rwxs,go=rx \
355
 
                --target-directory=$(PREFIX)/lib/mandos/plugins.d \
 
408
                --target-directory=$(LIBDIR)/mandos/plugins.d \
356
409
                plugins.d/askpass-fifo
357
410
        install --mode=u=rwxs,go=rx \
358
 
                --target-directory=$(PREFIX)/lib/mandos/plugins.d \
 
411
                --target-directory=$(LIBDIR)/mandos/plugins.d \
359
412
                plugins.d/plymouth
 
413
        install --mode=u=rwx,go=rx \
 
414
                --target-directory=$(LIBDIR)/mandos/plugin-helpers \
 
415
                plugin-helpers/mandos-client-iprouteadddel
360
416
        install initramfs-tools-hook \
361
417
                $(INITRAMFSTOOLS)/hooks/mandos
362
418
        install --mode=u=rw,go=r initramfs-tools-hook-conf \
407
463
        ! grep --regexp='^ *[^ #].*keyscript=[^,=]*/mandos/' \
408
464
                $(DESTDIR)/etc/crypttab
409
465
        -rm --force $(PREFIX)/sbin/mandos-keygen \
410
 
                $(PREFIX)/lib/mandos/plugin-runner \
411
 
                $(PREFIX)/lib/mandos/plugins.d/password-prompt \
412
 
                $(PREFIX)/lib/mandos/plugins.d/mandos-client \
413
 
                $(PREFIX)/lib/mandos/plugins.d/usplash \
414
 
                $(PREFIX)/lib/mandos/plugins.d/splashy \
415
 
                $(PREFIX)/lib/mandos/plugins.d/askpass-fifo \
416
 
                $(PREFIX)/lib/mandos/plugins.d/plymouth \
 
466
                $(LIBDIR)/mandos/plugin-runner \
 
467
                $(LIBDIR)/mandos/plugins.d/password-prompt \
 
468
                $(LIBDIR)/mandos/plugins.d/mandos-client \
 
469
                $(LIBDIR)/mandos/plugins.d/usplash \
 
470
                $(LIBDIR)/mandos/plugins.d/splashy \
 
471
                $(LIBDIR)/mandos/plugins.d/askpass-fifo \
 
472
                $(LIBDIR)/mandos/plugins.d/plymouth \
417
473
                $(INITRAMFSTOOLS)/hooks/mandos \
418
474
                $(INITRAMFSTOOLS)/conf-hooks.d/mandos \
419
475
                $(INITRAMFSTOOLS)/scripts/init-premount/mandos \
425
481
                $(MANDIR)/man8/splashy.8mandos.gz \
426
482
                $(MANDIR)/man8/askpass-fifo.8mandos.gz \
427
483
                $(MANDIR)/man8/plymouth.8mandos.gz \
428
 
        -rmdir $(PREFIX)/lib/mandos/plugins.d $(CONFDIR)/plugins.d \
429
 
                 $(PREFIX)/lib/mandos $(CONFDIR) $(KEYDIR)
 
484
        -rmdir $(LIBDIR)/mandos/plugins.d $(CONFDIR)/plugins.d \
 
485
                 $(LIBDIR)/mandos $(CONFDIR) $(KEYDIR)
430
486
        update-initramfs -k all -u
431
487
 
432
488
purge: purge-server purge-client
436
492
                $(DESTDIR)/etc/dbus-1/system.d/mandos.conf
437
493
                $(DESTDIR)/etc/default/mandos \
438
494
                $(DESTDIR)/etc/init.d/mandos \
 
495
                $(SYSTEMD)/mandos.service \
 
496
                $(DESTDIR)/run/mandos.pid \
439
497
                $(DESTDIR)/var/run/mandos.pid
440
498
        -rmdir $(CONFDIR)
441
499