/mandos/trunk

To get this branch, use:
bzr branch http://bzr.recompile.se/loggerhead/mandos/trunk

« back to all changes in this revision

Viewing changes to Makefile

  • Committer: Teddy Hogeborn
  • Date: 2016-10-05 19:56:40 UTC
  • Revision ID: teddy@recompile.se-20161005195640-yrjxv8kkx662usr0
Fix bug where Mandos client would crash on exit

* plugins.d/mandos-client.c (init_gnutls_global): Fix memory leak by
  doing free(params.data) after import.

Show diffs side-by-side

added added

removed removed

Lines of Context:
Makefile
1
 
WARN=-O -Wall -Wformat=2 -Winit-self -Wmissing-include-dirs \
2
 
        -Wswitch-default -Wswitch-enum -Wunused-parameter \
3
 
        -Wstrict-aliasing=1 -Wextra -Wfloat-equal -Wundef -Wshadow \
 
1
WARN=-O -Wall -Wextra -Wdouble-promotion -Wformat=2 -Winit-self \
 
2
        -Wmissing-include-dirs -Wswitch-default -Wswitch-enum \
 
3
        -Wunused -Wuninitialized -Wstrict-overflow=5 \
 
4
        -Wsuggest-attribute=pure -Wsuggest-attribute=const \
 
5
        -Wsuggest-attribute=noreturn -Wfloat-equal -Wundef -Wshadow \
4
6
        -Wunsafe-loop-optimizations -Wpointer-arith \
5
7
        -Wbad-function-cast -Wcast-qual -Wcast-align -Wwrite-strings \
6
 
        -Wconversion -Wstrict-prototypes -Wold-style-definition \
7
 
        -Wpacked -Wnested-externs -Winline -Wvolatile-register-var
8
 
#       -Wunreachable-code 
9
 
#DEBUG=-ggdb3
10
 
# For info about _FORTIFY_SOURCE, see
11
 
# <http://www.kernel.org/doc/man-pages/online/pages/man7/feature_test_macros.7.html>
12
 
# and <http://gcc.gnu.org/ml/gcc-patches/2004-09/msg02055.html>.
 
8
        -Wconversion -Wlogical-op -Waggregate-return \
 
9
        -Wstrict-prototypes -Wold-style-definition \
 
10
        -Wmissing-format-attribute -Wnormalized=nfc -Wpacked \
 
11
        -Wredundant-decls -Wnested-externs -Winline -Wvla \
 
12
        -Wvolatile-register-var -Woverlength-strings
 
13
#DEBUG=-ggdb3 -fsanitize=address 
 
14
# For info about _FORTIFY_SOURCE, see feature_test_macros(7)
 
15
# and <https://gcc.gnu.org/ml/gcc-patches/2004-09/msg02055.html>.
13
16
FORTIFY=-D_FORTIFY_SOURCE=2 -fstack-protector-all -fPIC
 
17
# <https://developerblog.redhat.com/2014/10/16/gcc-undefined-behavior-sanitizer-ubsan/>
 
18
ALL_SANITIZE_OPTIONS:=-fsanitize=leak -fsanitize=undefined \
 
19
        -fsanitize=shift -fsanitize=integer-divide-by-zero \
 
20
        -fsanitize=unreachable -fsanitize=vla-bound -fsanitize=null \
 
21
        -fsanitize=return -fsanitize=signed-integer-overflow \
 
22
        -fsanitize=bounds -fsanitize=alignment \
 
23
        -fsanitize=object-size -fsanitize=float-divide-by-zero \
 
24
        -fsanitize=float-cast-overflow -fsanitize=nonnull-attribute \
 
25
        -fsanitize=returns-nonnull-attribute -fsanitize=bool \
 
26
        -fsanitize=enum
 
27
# Check which sanitizing options can be used
 
28
SANITIZE:=$(foreach option,$(ALL_SANITIZE_OPTIONS),$(shell \
 
29
        echo 'int main(){}' | $(CC) --language=c $(option) /dev/stdin \
 
30
        -o /dev/null >/dev/null 2>&1 && echo $(option)))
14
31
LINK_FORTIFY_LD=-z relro -z now
15
32
LINK_FORTIFY=
16
33
 
20
37
LINK_FORTIFY += -pie
21
38
endif
22
39
#COVERAGE=--coverage
23
 
OPTIMIZE=-Os
24
 
LANGUAGE=-std=gnu99
 
40
OPTIMIZE=-Os -fno-strict-aliasing
 
41
LANGUAGE=-std=gnu11
25
42
htmldir=man
26
 
version=1.2.3
 
43
version=1.7.11
27
44
SED=sed
28
45
 
 
46
USER=$(firstword $(subst :, ,$(shell getent passwd _mandos || getent passwd nobody || echo 65534)))
 
47
GROUP=$(firstword $(subst :, ,$(shell getent group _mandos || getent group nogroup || echo 65534)))
 
48
 
29
49
## Use these settings for a traditional /usr/local install
30
50
# PREFIX=$(DESTDIR)/usr/local
31
51
# CONFDIR=$(DESTDIR)/etc/mandos
32
52
# KEYDIR=$(DESTDIR)/etc/mandos/keys
33
53
# MANDIR=$(PREFIX)/man
34
54
# INITRAMFSTOOLS=$(DESTDIR)/etc/initramfs-tools
 
55
# STATEDIR=$(DESTDIR)/var/lib/mandos
 
56
# LIBDIR=$(PREFIX)/lib
35
57
##
36
58
 
37
59
## These settings are for a package-type install
40
62
KEYDIR=$(DESTDIR)/etc/keys/mandos
41
63
MANDIR=$(PREFIX)/share/man
42
64
INITRAMFSTOOLS=$(DESTDIR)/usr/share/initramfs-tools
 
65
STATEDIR=$(DESTDIR)/var/lib/mandos
 
66
LIBDIR=$(shell \
 
67
        for d in \
 
68
        "/usr/lib/`dpkg-architecture -qDEB_HOST_MULTIARCH 2>/dev/null`" \
 
69
        "`rpm --eval='%{_libdir}' 2>/dev/null`" /usr/lib; do \
 
70
                if [ -d "$$d" -a "$$d" = "$${d%/}" ]; then \
 
71
                        echo "$(DESTDIR)$$d"; \
 
72
                        break; \
 
73
                fi; \
 
74
        done)
43
75
##
44
76
 
 
77
SYSTEMD=$(DESTDIR)$(shell pkg-config systemd --variable=systemdsystemunitdir)
 
78
TMPFILES=$(DESTDIR)$(shell pkg-config systemd --variable=tmpfilesdir)
 
79
 
45
80
GNUTLS_CFLAGS=$(shell pkg-config --cflags-only-I gnutls)
46
81
GNUTLS_LIBS=$(shell pkg-config --libs gnutls)
47
82
AVAHI_CFLAGS=$(shell pkg-config --cflags-only-I avahi-core)
49
84
GPGME_CFLAGS=$(shell gpgme-config --cflags; getconf LFS_CFLAGS)
50
85
GPGME_LIBS=$(shell gpgme-config --libs; getconf LFS_LIBS; \
51
86
        getconf LFS_LDFLAGS)
 
87
LIBNL3_CFLAGS=$(shell pkg-config --cflags-only-I libnl-route-3.0)
 
88
LIBNL3_LIBS=$(shell pkg-config --libs libnl-route-3.0)
52
89
 
53
90
# Do not change these two
54
 
CFLAGS=$(WARN) $(DEBUG) $(FORTIFY) $(COVERAGE) $(OPTIMIZE) \
55
 
        $(LANGUAGE) $(GNUTLS_CFLAGS) $(AVAHI_CFLAGS) $(GPGME_CFLAGS) \
56
 
        -DVERSION='"$(version)"'
57
 
LDFLAGS=$(COVERAGE) $(LINK_FORTIFY) $(foreach flag,$(LINK_FORTIFY_LD),-Xlinker $(flag))
 
91
CFLAGS+=$(WARN) $(DEBUG) $(FORTIFY) $(SANITIZE) $(COVERAGE) \
 
92
        $(OPTIMIZE) $(LANGUAGE) $(GNUTLS_CFLAGS) $(AVAHI_CFLAGS) \
 
93
        $(GPGME_CFLAGS) -DVERSION='"$(version)"'
 
94
LDFLAGS+=-Xlinker --as-needed $(COVERAGE) $(LINK_FORTIFY) $(foreach flag,$(LINK_FORTIFY_LD),-Xlinker $(flag))
58
95
 
59
96
# Commands to format a DocBook <refentry> document into a manual page
60
97
DOCBOOKTOMAN=$(strip cd $(dir $<); xsltproc --nonet --xinclude \
63
100
        --param make.single.year.ranges         1 \
64
101
        --param man.output.quietly              1 \
65
102
        --param man.authors.section.enabled     0 \
66
 
         /usr/share/xml/docbook/stylesheet/nwalsh/manpages/docbook.xsl \
 
103
        /usr/share/xml/docbook/stylesheet/nwalsh/manpages/docbook.xsl \
67
104
        $(notdir $<); \
68
 
        $(MANPOST) $(notdir $@))
69
 
# DocBook-to-man post-processing to fix a '\n' escape bug
70
 
MANPOST=$(SED) --in-place --expression='s,\\\\en,\\en,g;s,\\n,\\en,g'
 
105
        if locale --all 2>/dev/null | grep --regexp='^en_US\.utf8$$' \
 
106
        && type man 2>/dev/null; then LANG=en_US.UTF-8 MANWIDTH=80 \
 
107
        man --warnings --encoding=UTF-8 --local-file $(notdir $@); \
 
108
        fi >/dev/null)
71
109
 
72
110
DOCBOOKTOHTML=$(strip xsltproc --nonet --xinclude \
73
111
        --param make.year.ranges                1 \
85
123
PLUGINS=plugins.d/password-prompt plugins.d/mandos-client \
86
124
        plugins.d/usplash plugins.d/splashy plugins.d/askpass-fifo \
87
125
        plugins.d/plymouth
88
 
CPROGS=plugin-runner $(PLUGINS)
 
126
PLUGIN_HELPERS=plugin-helpers/mandos-client-iprouteadddel
 
127
CPROGS=plugin-runner $(PLUGINS) $(PLUGIN_HELPERS)
89
128
PROGS=mandos mandos-keygen mandos-ctl mandos-monitor $(CPROGS)
90
129
DOCS=mandos.8 mandos-keygen.8 mandos-monitor.8 mandos-ctl.8 \
91
130
        mandos.conf.5 mandos-clients.conf.5 plugin-runner.8mandos \
92
131
        plugins.d/mandos-client.8mandos \
93
132
        plugins.d/password-prompt.8mandos plugins.d/usplash.8mandos \
94
133
        plugins.d/splashy.8mandos plugins.d/askpass-fifo.8mandos \
95
 
        plugins.d/plymouth.8mandos
 
134
        plugins.d/plymouth.8mandos intro.8mandos
96
135
 
97
136
htmldocs=$(addsuffix .xhtml,$(DOCS))
98
137
 
119
158
%.8mandos.xhtml: %.xml common.ent legalnotice.xml
120
159
        $(DOCBOOKTOHTML)
121
160
 
 
161
intro.8mandos: intro.xml common.ent legalnotice.xml
 
162
        $(DOCBOOKTOMAN)
 
163
intro.8mandos.xhtml: intro.xml common.ent legalnotice.xml
 
164
        $(DOCBOOKTOHTML)
 
165
 
122
166
mandos.8: mandos.xml common.ent mandos-options.xml overview.xml \
123
167
                legalnotice.xml
124
168
        $(DOCBOOKTOMAN)
210
254
                $@)
211
255
 
212
256
plugins.d/mandos-client: plugins.d/mandos-client.c
213
 
        $(LINK.c) $(GNUTLS_LIBS) $(AVAHI_LIBS) $(GPGME_LIBS) $(strip\
214
 
                ) $(COMMON) $^ $(LOADLIBES) $(LDLIBS) -o $@
215
 
 
216
 
.PHONY : all doc html clean distclean run-client run-server install \
217
 
        install-server install-client uninstall uninstall-server \
218
 
        uninstall-client purge purge-server purge-client
 
257
        $(LINK.c) $^ -lrt $(GNUTLS_LIBS) $(AVAHI_LIBS) $(strip\
 
258
                ) $(GPGME_LIBS) $(LOADLIBES) $(LDLIBS) -o $@
 
259
 
 
260
plugin-helpers/mandos-client-iprouteadddel: plugin-helpers/mandos-client-iprouteadddel.c
 
261
        $(LINK.c) $(LIBNL3_CFLAGS) $^ $(LIBNL3_LIBS) $(strip\
 
262
                ) $(LOADLIBES) $(LDLIBS) -o $@
 
263
 
 
264
.PHONY : all doc html clean distclean mostlyclean maintainer-clean \
 
265
        check run-client run-server install install-html \
 
266
        install-server install-client-nokey install-client uninstall \
 
267
        uninstall-server uninstall-client purge purge-server \
 
268
        purge-client
219
269
 
220
270
clean:
221
271
        -rm --force $(CPROGS) $(objects) $(htmldocs) $(DOCS) core
223
273
distclean: clean
224
274
mostlyclean: clean
225
275
maintainer-clean: clean
226
 
        -rm --force --recursive keydir confdir
 
276
        -rm --force --recursive keydir confdir statedir
227
277
 
228
278
check:  all
229
279
        ./mandos --check
 
280
        ./mandos-ctl --check
230
281
 
231
282
# Run the client with a local config and key
232
283
run-client: all keydir/seckey.txt keydir/pubkey.txt
235
286
        @echo "# ignored.  The messages are caused by not running as root, but   #"
236
287
        @echo "# you should NOT run \"make run-client\" as root unless you also    #"
237
288
        @echo "# unpacked and compiled Mandos as root, which is NOT recommended. #"
238
 
        @echo "# From plugin-runner: setuid: Operation not permitted             #"
 
289
        @echo "# From plugin-runner: setgid: Operation not permitted             #"
 
290
        @echo "#                     setuid: Operation not permitted             #"
239
291
        @echo "# From askpass-fifo:  mkfifo: Permission denied                   #"
240
 
        @echo "# From mandos-client: setuid: Operation not permitted             #"
241
 
        @echo "#                     seteuid: Operation not permitted            #"
242
 
        @echo "#                     klogctl: Operation not permitted            #"
 
292
        @echo "# From mandos-client:                                             #"
 
293
        @echo "#             Failed to raise privileges: Operation not permitted #"
 
294
        @echo "#             Warning: network hook \"*\" exited with status *      #"
243
295
        @echo "###################################################################"
 
296
# We set GNOME_KEYRING_CONTROL to block pam_gnome_keyring
244
297
        ./plugin-runner --plugin-dir=plugins.d \
 
298
                --plugin-helper-dir=plugin-helpers \
245
299
                --config-file=plugin-runner.conf \
246
 
                --options-for=mandos-client:--seckey=keydir/seckey.txt,--pubkey=keydir/pubkey.txt \
 
300
                --options-for=mandos-client:--seckey=keydir/seckey.txt,--pubkey=keydir/pubkey.txt,--network-hook-dir=network-hooks.d \
 
301
                --env-for=mandos-client:GNOME_KEYRING_CONTROL= \
247
302
                $(CLIENTARGS)
248
303
 
249
304
# Used by run-client
252
307
        ./mandos-keygen --dir keydir --force
253
308
 
254
309
# Run the server with a local config
255
 
run-server: confdir/mandos.conf confdir/clients.conf
256
 
        @echo "#################################################################"
257
 
        @echo "# NOTE: Please IGNORE the error about \"Could not open file      #"
258
 
        @echo "# u'/var/run/mandos.pid'\" -  it is harmless and is caused by    #"
259
 
        @echo "# the server not running as root.  Do NOT run \"make run-server\" #"
260
 
        @echo "# server as root if you didn't also unpack and compile it thus. #"
261
 
        @echo "#################################################################"
262
 
        ./mandos --debug --no-dbus --configdir=confdir $(SERVERARGS)
 
310
run-server: confdir/mandos.conf confdir/clients.conf statedir
 
311
        ./mandos --debug --no-dbus --configdir=confdir \
 
312
                --statedir=statedir $(SERVERARGS)
263
313
 
264
314
# Used by run-server
265
315
confdir/mandos.conf: mandos.conf
269
319
        install --directory confdir
270
320
        install --mode=u=rw $< $@
271
321
# Add a client password
272
 
        ./mandos-keygen --dir keydir --password >> $@
 
322
        ./mandos-keygen --dir keydir --password --no-ssh >> $@
 
323
statedir:
 
324
        install --directory statedir
273
325
 
274
326
install: install-server install-client-nokey
275
327
 
280
332
 
281
333
install-server: doc
282
334
        install --directory $(CONFDIR)
 
335
        if install --directory --mode=u=rwx --owner=$(USER) \
 
336
                --group=$(GROUP) $(STATEDIR); then \
 
337
                :; \
 
338
        elif install --directory --mode=u=rwx $(STATEDIR); then \
 
339
                chown -- $(USER):$(GROUP) $(STATEDIR) || :; \
 
340
        fi
 
341
        if [ "$(TMPFILES)" != "$(DESTDIR)" -a -d "$(TMPFILES)" ]; then \
 
342
                install --mode=u=rw,go=r tmpfiles.d-mandos.conf \
 
343
                        $(TMPFILES)/mandos.conf; \
 
344
        fi
283
345
        install --mode=u=rwx,go=rx mandos $(PREFIX)/sbin/mandos
284
346
        install --mode=u=rwx,go=rx --target-directory=$(PREFIX)/sbin \
285
347
                mandos-ctl
293
355
                $(DESTDIR)/etc/dbus-1/system.d/mandos.conf
294
356
        install --mode=u=rwx,go=rx init.d-mandos \
295
357
                $(DESTDIR)/etc/init.d/mandos
 
358
        if [ "$(SYSTEMD)" != "$(DESTDIR)" -a -d "$(SYSTEMD)" ]; then \
 
359
                install --mode=u=rw,go=r mandos.service $(SYSTEMD); \
 
360
        fi
296
361
        install --mode=u=rw,go=r default-mandos \
297
362
                $(DESTDIR)/etc/default/mandos
298
363
        if [ -z $(DESTDIR) ]; then \
308
373
                > $(MANDIR)/man5/mandos.conf.5.gz
309
374
        gzip --best --to-stdout mandos-clients.conf.5 \
310
375
                > $(MANDIR)/man5/mandos-clients.conf.5.gz
 
376
        gzip --best --to-stdout intro.8mandos \
 
377
                > $(MANDIR)/man8/intro.8mandos.gz
311
378
 
312
379
install-client-nokey: all doc
313
 
        install --directory $(PREFIX)/lib/mandos $(CONFDIR)
 
380
        install --directory $(LIBDIR)/mandos $(CONFDIR)
314
381
        install --directory --mode=u=rwx $(KEYDIR) \
315
 
                $(PREFIX)/lib/mandos/plugins.d
316
 
        if [ "$(CONFDIR)" != "$(PREFIX)/lib/mandos" ]; then \
 
382
                $(LIBDIR)/mandos/plugins.d \
 
383
                $(LIBDIR)/mandos/plugin-helpers
 
384
        if [ "$(CONFDIR)" != "$(LIBDIR)/mandos" ]; then \
317
385
                install --mode=u=rwx \
318
 
                        --directory "$(CONFDIR)/plugins.d"; \
 
386
                        --directory "$(CONFDIR)/plugins.d" \
 
387
                        "$(CONFDIR)/plugin-helpers"; \
319
388
        fi
 
389
        install --mode=u=rwx,go=rx --directory \
 
390
                "$(CONFDIR)/network-hooks.d"
320
391
        install --mode=u=rwx,go=rx \
321
 
                --target-directory=$(PREFIX)/lib/mandos plugin-runner
 
392
                --target-directory=$(LIBDIR)/mandos plugin-runner
322
393
        install --mode=u=rwx,go=rx --target-directory=$(PREFIX)/sbin \
323
394
                mandos-keygen
324
395
        install --mode=u=rwx,go=rx \
325
 
                --target-directory=$(PREFIX)/lib/mandos/plugins.d \
 
396
                --target-directory=$(LIBDIR)/mandos/plugins.d \
326
397
                plugins.d/password-prompt
327
398
        install --mode=u=rwxs,go=rx \
328
 
                --target-directory=$(PREFIX)/lib/mandos/plugins.d \
 
399
                --target-directory=$(LIBDIR)/mandos/plugins.d \
329
400
                plugins.d/mandos-client
330
401
        install --mode=u=rwxs,go=rx \
331
 
                --target-directory=$(PREFIX)/lib/mandos/plugins.d \
 
402
                --target-directory=$(LIBDIR)/mandos/plugins.d \
332
403
                plugins.d/usplash
333
404
        install --mode=u=rwxs,go=rx \
334
 
                --target-directory=$(PREFIX)/lib/mandos/plugins.d \
 
405
                --target-directory=$(LIBDIR)/mandos/plugins.d \
335
406
                plugins.d/splashy
336
407
        install --mode=u=rwxs,go=rx \
337
 
                --target-directory=$(PREFIX)/lib/mandos/plugins.d \
 
408
                --target-directory=$(LIBDIR)/mandos/plugins.d \
338
409
                plugins.d/askpass-fifo
339
410
        install --mode=u=rwxs,go=rx \
340
 
                --target-directory=$(PREFIX)/lib/mandos/plugins.d \
 
411
                --target-directory=$(LIBDIR)/mandos/plugins.d \
341
412
                plugins.d/plymouth
 
413
        install --mode=u=rwx,go=rx \
 
414
                --target-directory=$(LIBDIR)/mandos/plugin-helpers \
 
415
                plugin-helpers/mandos-client-iprouteadddel
342
416
        install initramfs-tools-hook \
343
417
                $(INITRAMFSTOOLS)/hooks/mandos
344
418
        install --mode=u=rw,go=r initramfs-tools-hook-conf \
389
463
        ! grep --regexp='^ *[^ #].*keyscript=[^,=]*/mandos/' \
390
464
                $(DESTDIR)/etc/crypttab
391
465
        -rm --force $(PREFIX)/sbin/mandos-keygen \
392
 
                $(PREFIX)/lib/mandos/plugin-runner \
393
 
                $(PREFIX)/lib/mandos/plugins.d/password-prompt \
394
 
                $(PREFIX)/lib/mandos/plugins.d/mandos-client \
395
 
                $(PREFIX)/lib/mandos/plugins.d/usplash \
396
 
                $(PREFIX)/lib/mandos/plugins.d/splashy \
397
 
                $(PREFIX)/lib/mandos/plugins.d/askpass-fifo \
398
 
                $(PREFIX)/lib/mandos/plugins.d/plymouth \
 
466
                $(LIBDIR)/mandos/plugin-runner \
 
467
                $(LIBDIR)/mandos/plugins.d/password-prompt \
 
468
                $(LIBDIR)/mandos/plugins.d/mandos-client \
 
469
                $(LIBDIR)/mandos/plugins.d/usplash \
 
470
                $(LIBDIR)/mandos/plugins.d/splashy \
 
471
                $(LIBDIR)/mandos/plugins.d/askpass-fifo \
 
472
                $(LIBDIR)/mandos/plugins.d/plymouth \
399
473
                $(INITRAMFSTOOLS)/hooks/mandos \
400
474
                $(INITRAMFSTOOLS)/conf-hooks.d/mandos \
401
475
                $(INITRAMFSTOOLS)/scripts/init-premount/mandos \
407
481
                $(MANDIR)/man8/splashy.8mandos.gz \
408
482
                $(MANDIR)/man8/askpass-fifo.8mandos.gz \
409
483
                $(MANDIR)/man8/plymouth.8mandos.gz \
410
 
        -rmdir $(PREFIX)/lib/mandos/plugins.d $(CONFDIR)/plugins.d \
411
 
                 $(PREFIX)/lib/mandos $(CONFDIR) $(KEYDIR)
 
484
        -rmdir $(LIBDIR)/mandos/plugins.d $(CONFDIR)/plugins.d \
 
485
                 $(LIBDIR)/mandos $(CONFDIR) $(KEYDIR)
412
486
        update-initramfs -k all -u
413
487
 
414
488
purge: purge-server purge-client
418
492
                $(DESTDIR)/etc/dbus-1/system.d/mandos.conf
419
493
                $(DESTDIR)/etc/default/mandos \
420
494
                $(DESTDIR)/etc/init.d/mandos \
 
495
                $(SYSTEMD)/mandos.service \
 
496
                $(DESTDIR)/run/mandos.pid \
421
497
                $(DESTDIR)/var/run/mandos.pid
422
498
        -rmdir $(CONFDIR)
423
499