/mandos/trunk

To get this branch, use:
bzr branch http://bzr.recompile.se/loggerhead/mandos/trunk

« back to all changes in this revision

Viewing changes to mandos-monitor

  • Committer: Teddy Hogeborn
  • Date: 2016-03-05 21:42:56 UTC
  • Revision ID: teddy@recompile.se-20160305214256-79progf0wfkd9068
Add bug reporting information to manual pages

* bugs.xml: New file.
* intro.xml (BUGS): New section; include "bugs.xml".
* mandos-clients.conf.xml (BUGS): Include "bugs.xml".
* mandos-ctl.xml (BUGS): Uncommented; include "bugs.xml".
* mandos-keygen.xml (BUGS): - '' -
* mandos-monitor.xml (BUGS): Include "bugs.xml".
* mandos.conf.xml (BUGS): - '' -
* mandos.xml (BUGS): - '' -
* plugin-runner.xml (BUGS): - '' -
* plugins.d/askpass-fifo.xml (BUGS): New section; include
                                     "../bugs.xml".
* plugins.d/mandos-client.xml (BUGS): Uncommented; include
                                     "../bugs.xml".
* plugins.d/password-prompt.xml (BUGS): Include "../bugs.xml".
* plugins.d/plymouth.xml (BUGS): - '' -
* plugins.d/splashy.xml (BUGS): - '' -
* plugins.d/usplash.xml (BUGS): - '' -

Show diffs side-by-side

added added

removed removed

Lines of Context:
mandos-monitor
3
3
# 
4
4
# Mandos Monitor - Control and monitor the Mandos server
5
5
# 
6
 
# Copyright © 2009-2012 Teddy Hogeborn
7
 
# Copyright © 2009-2012 Björn Påhlsson
 
6
# Copyright © 2009-2016 Teddy Hogeborn
 
7
# Copyright © 2009-2016 Björn Påhlsson
8
8
# 
9
9
# This program is free software: you can redistribute it and/or modify
10
10
# it under the terms of the GNU General Public License as published by
17
17
#     GNU General Public License for more details.
18
18
# 
19
19
# You should have received a copy of the GNU General Public License
20
 
# along with this program.  If not, see <http://www.gnu.org/licenses/>.
 
20
# along with this program.  If not, see
 
21
# <http://www.gnu.org/licenses/>.
21
22
# 
22
23
# Contact the authors at <mandos@recompile.se>.
23
24
# 
24
25
 
25
26
from __future__ import (division, absolute_import, print_function,
26
27
                        unicode_literals)
 
28
try:
 
29
    from future_builtins import *
 
30
except ImportError:
 
31
    pass
27
32
 
28
33
import sys
29
34
import os
30
 
import signal
31
35
 
32
36
import datetime
33
37
 
35
39
import urwid
36
40
 
37
41
from dbus.mainloop.glib import DBusGMainLoop
38
 
import gobject
 
42
try:
 
43
    from gi.repository import GObject
 
44
except ImportError:
 
45
    import gobject as GObject
39
46
 
40
47
import dbus
41
48
 
42
 
import UserList
43
 
 
44
49
import locale
45
50
 
 
51
if sys.version_info.major == 2:
 
52
    str = unicode
 
53
 
46
54
locale.setlocale(locale.LC_ALL, '')
47
55
 
48
56
import logging
52
60
domain = 'se.recompile'
53
61
server_interface = domain + '.Mandos'
54
62
client_interface = domain + '.Mandos.Client'
55
 
version = "1.5.3"
56
 
 
57
 
# Always run in monochrome mode
58
 
urwid.curses_display.curses.has_colors = lambda : False
59
 
 
60
 
# Urwid doesn't support blinking, but we want it.  Since we have no
61
 
# use for underline on its own, we make underline also always blink.
62
 
urwid.curses_display.curses.A_UNDERLINE |= (
63
 
    urwid.curses_display.curses.A_BLINK)
 
63
version = "1.7.3"
 
64
 
 
65
try:
 
66
    dbus.OBJECT_MANAGER_IFACE
 
67
except AttributeError:
 
68
    dbus.OBJECT_MANAGER_IFACE = "org.freedesktop.DBus.ObjectManager"
64
69
 
65
70
def isoformat_to_datetime(iso):
66
71
    "Parse an ISO 8601 date string to a datetime.datetime()"
83
88
    properties and calls a hook function when any of them are
84
89
    changed.
85
90
    """
86
 
    def __init__(self, proxy_object=None, *args, **kwargs):
 
91
    def __init__(self, proxy_object=None, properties=None, **kwargs):
87
92
        self.proxy = proxy_object # Mandos Client proxy object
88
 
        
89
 
        self.properties = dict()
 
93
        self.properties = dict() if properties is None else properties
90
94
        self.property_changed_match = (
91
 
            self.proxy.connect_to_signal("PropertyChanged",
92
 
                                         self.property_changed,
93
 
                                         client_interface,
 
95
            self.proxy.connect_to_signal("PropertiesChanged",
 
96
                                         self.properties_changed,
 
97
                                         dbus.PROPERTIES_IFACE,
94
98
                                         byte_arrays=True))
95
99
        
96
 
        self.properties.update(
97
 
            self.proxy.GetAll(client_interface,
98
 
                              dbus_interface = dbus.PROPERTIES_IFACE))
99
 
 
100
 
        #XXX This breaks good super behaviour
101
 
#        super(MandosClientPropertyCache, self).__init__(
102
 
#            *args, **kwargs)
 
100
        if properties is None:
 
101
            self.properties.update(
 
102
                self.proxy.GetAll(client_interface,
 
103
                                  dbus_interface
 
104
                                  = dbus.PROPERTIES_IFACE))
 
105
        
 
106
        super(MandosClientPropertyCache, self).__init__(**kwargs)
103
107
    
104
 
    def property_changed(self, property=None, value=None):
105
 
        """This is called whenever we get a PropertyChanged signal
106
 
        It updates the changed property in the "properties" dict.
 
108
    def properties_changed(self, interface, properties, invalidated):
 
109
        """This is called whenever we get a PropertiesChanged signal
 
110
        It updates the changed properties in the "properties" dict.
107
111
        """
108
112
        # Update properties dict with new value
109
 
        self.properties[property] = value
 
113
        if interface == client_interface:
 
114
            self.properties.update(properties)
110
115
    
111
 
    def delete(self, *args, **kwargs):
 
116
    def delete(self):
112
117
        self.property_changed_match.remove()
113
 
        super(MandosClientPropertyCache, self).__init__(
114
 
            *args, **kwargs)
115
118
 
116
119
 
117
120
class MandosClientWidget(urwid.FlowWidget, MandosClientPropertyCache):
119
122
    """
120
123
    
121
124
    def __init__(self, server_proxy_object=None, update_hook=None,
122
 
                 delete_hook=None, logger=None, *args, **kwargs):
 
125
                 delete_hook=None, logger=None, **kwargs):
123
126
        # Called on update
124
127
        self.update_hook = update_hook
125
128
        # Called on delete
130
133
        self.logger = logger
131
134
        
132
135
        self._update_timer_callback_tag = None
133
 
        self._update_timer_callback_lock = 0
134
136
        
135
137
        # The widget shown normally
136
138
        self._text_widget = urwid.Text("")
137
139
        # The widget shown when we have focus
138
140
        self._focus_text_widget = urwid.Text("")
139
 
        super(MandosClientWidget, self).__init__(
140
 
            update_hook=update_hook, delete_hook=delete_hook,
141
 
            *args, **kwargs)
 
141
        super(MandosClientWidget, self).__init__(**kwargs)
142
142
        self.update()
143
143
        self.opened = False
144
144
        
145
 
        last_checked_ok = isoformat_to_datetime(self.properties
146
 
                                                ["LastCheckedOK"])
147
 
        
148
 
        if self.properties ["LastCheckerStatus"] != 0:
149
 
            self.using_timer(True)
150
 
        
151
 
        if self.need_approval:
152
 
            self.using_timer(True)
153
 
        
154
145
        self.match_objects = (
155
146
            self.proxy.connect_to_signal("CheckerCompleted",
156
147
                                         self.checker_completed,
172
163
                                         self.rejected,
173
164
                                         client_interface,
174
165
                                         byte_arrays=True))
175
 
        #self.logger('Created client {0}'
176
 
        #            .format(self.properties["Name"]))
177
 
    
178
 
    def property_changed(self, property=None, value=None):
179
 
        super(self, MandosClientWidget).property_changed(property,
180
 
                                                         value)
181
 
        if property == "ApprovalPending":
182
 
            using_timer(bool(value))
183
 
        if property == "LastCheckerStatus":
184
 
            using_timer(value != 0)
185
 
            #self.logger('Checker for client {0} (command "{1}") was '
186
 
            #            ' successful'.format(self.properties["Name"],
187
 
            #                                 command))
 
166
        self.logger('Created client {}'
 
167
                    .format(self.properties["Name"]), level=0)
188
168
    
189
169
    def using_timer(self, flag):
190
170
        """Call this method with True or False when timer should be
191
171
        activated or deactivated.
192
172
        """
193
 
        old = self._update_timer_callback_lock
194
 
        if flag:
195
 
            self._update_timer_callback_lock += 1
196
 
        else:
197
 
            self._update_timer_callback_lock -= 1
198
 
        if old == 0 and self._update_timer_callback_lock:
 
173
        if flag and self._update_timer_callback_tag is None:
199
174
            # Will update the shown timer value every second
200
 
            self._update_timer_callback_tag = (gobject.timeout_add
 
175
            self._update_timer_callback_tag = (GObject.timeout_add
201
176
                                               (1000,
202
177
                                                self.update_timer))
203
 
        elif old and self._update_timer_callback_lock == 0:
204
 
            gobject.source_remove(self._update_timer_callback_tag)
 
178
        elif not (flag or self._update_timer_callback_tag is None):
 
179
            GObject.source_remove(self._update_timer_callback_tag)
205
180
            self._update_timer_callback_tag = None
206
181
    
207
182
    def checker_completed(self, exitstatus, condition, command):
208
183
        if exitstatus == 0:
 
184
            self.logger('Checker for client {} (command "{}")'
 
185
                        ' succeeded'.format(self.properties["Name"],
 
186
                                            command), level=0)
209
187
            self.update()
210
188
            return
211
189
        # Checker failed
212
190
        if os.WIFEXITED(condition):
213
 
            self.logger('Checker for client {0} (command "{1}")'
214
 
                        ' failed with exit code {2}'
 
191
            self.logger('Checker for client {} (command "{}") failed'
 
192
                        ' with exit code {}'
215
193
                        .format(self.properties["Name"], command,
216
194
                                os.WEXITSTATUS(condition)))
217
195
        elif os.WIFSIGNALED(condition):
218
 
            self.logger('Checker for client {0} (command "{1}") was'
219
 
                        ' killed by signal {2}'
 
196
            self.logger('Checker for client {} (command "{}") was'
 
197
                        ' killed by signal {}'
220
198
                        .format(self.properties["Name"], command,
221
199
                                os.WTERMSIG(condition)))
222
 
        elif os.WCOREDUMP(condition):
223
 
            self.logger('Checker for client {0} (command "{1}")'
224
 
                        ' dumped core'
225
 
                        .format(self.properties["Name"], command))
226
 
        else:
227
 
            self.logger('Checker for client {0} completed'
228
 
                        ' mysteriously'
229
 
                        .format(self.properties["Name"]))
230
200
        self.update()
231
201
    
232
202
    def checker_started(self, command):
233
 
        """Server signals that a checker started. This could be useful
234
 
           to log in the future. """
235
 
        #self.logger('Client {0} started checker "{1}"'
236
 
        #            .format(self.properties["Name"],
237
 
        #                    unicode(command)))
238
 
        pass
 
203
        """Server signals that a checker started."""
 
204
        self.logger('Client {} started checker "{}"'
 
205
                    .format(self.properties["Name"],
 
206
                            command), level=0)
239
207
    
240
208
    def got_secret(self):
241
 
        self.logger('Client {0} received its secret'
 
209
        self.logger('Client {} received its secret'
242
210
                    .format(self.properties["Name"]))
243
211
    
244
212
    def need_approval(self, timeout, default):
245
213
        if not default:
246
 
            message = 'Client {0} needs approval within {1} seconds'
 
214
            message = 'Client {} needs approval within {} seconds'
247
215
        else:
248
 
            message = 'Client {0} will get its secret in {1} seconds'
 
216
            message = 'Client {} will get its secret in {} seconds'
249
217
        self.logger(message.format(self.properties["Name"],
250
218
                                   timeout/1000))
251
 
        self.using_timer(True)
252
219
    
253
220
    def rejected(self, reason):
254
 
        self.logger('Client {0} was rejected; reason: {1}'
 
221
        self.logger('Client {} was rejected; reason: {}'
255
222
                    .format(self.properties["Name"], reason))
256
223
    
257
224
    def selectable(self):
280
247
                          "bold-underline-blink":
281
248
                              "bold-underline-blink-standout",
282
249
                          }
283
 
 
 
250
        
284
251
        # Rebuild focus and non-focus widgets using current properties
285
 
 
 
252
        
286
253
        # Base part of a client. Name!
287
254
        base = '{name}: '.format(name=self.properties["Name"])
288
255
        if not self.properties["Enabled"]:
289
256
            message = "DISABLED"
 
257
            self.using_timer(False)
290
258
        elif self.properties["ApprovalPending"]:
291
259
            timeout = datetime.timedelta(milliseconds
292
260
                                         = self.properties
294
262
            last_approval_request = isoformat_to_datetime(
295
263
                self.properties["LastApprovalRequest"])
296
264
            if last_approval_request is not None:
297
 
                timer = timeout - (datetime.datetime.utcnow()
298
 
                                   - last_approval_request)
 
265
                timer = max(timeout - (datetime.datetime.utcnow()
 
266
                                       - last_approval_request),
 
267
                            datetime.timedelta())
299
268
            else:
300
269
                timer = datetime.timedelta()
301
270
            if self.properties["ApprovedByDefault"]:
302
 
                message = "Approval in {0}. (d)eny?"
 
271
                message = "Approval in {}. (d)eny?"
303
272
            else:
304
 
                message = "Denial in {0}. (a)pprove?"
305
 
            message = message.format(unicode(timer).rsplit(".", 1)[0])
 
273
                message = "Denial in {}. (a)pprove?"
 
274
            message = message.format(str(timer).rsplit(".", 1)[0])
 
275
            self.using_timer(True)
306
276
        elif self.properties["LastCheckerStatus"] != 0:
307
 
            # When checker has failed, print a timer until client expires
 
277
            # When checker has failed, show timer until client expires
308
278
            expires = self.properties["Expires"]
309
279
            if expires == "":
310
280
                timer = datetime.timedelta(0)
311
281
            else:
312
 
                expires = datetime.datetime.strptime(expires,
313
 
                                                     '%Y-%m-%dT%H:%M:%S.%f')
314
 
                timer = expires - datetime.datetime.utcnow()
 
282
                expires = (datetime.datetime.strptime
 
283
                           (expires, '%Y-%m-%dT%H:%M:%S.%f'))
 
284
                timer = max(expires - datetime.datetime.utcnow(),
 
285
                            datetime.timedelta())
315
286
            message = ('A checker has failed! Time until client'
316
 
                       ' gets disabled: {0}'
317
 
                       .format(unicode(timer).rsplit(".", 1)[0]))
 
287
                       ' gets disabled: {}'
 
288
                       .format(str(timer).rsplit(".", 1)[0]))
 
289
            self.using_timer(True)
318
290
        else:
319
291
            message = "enabled"
320
 
        self._text = "{0}{1}".format(base, message)
321
 
            
 
292
            self.using_timer(False)
 
293
        self._text = "{}{}".format(base, message)
 
294
        
322
295
        if not urwid.supports_unicode():
323
296
            self._text = self._text.encode("ascii", "replace")
324
297
        textlist = [("normal", self._text)]
336
309
            self.update_hook()
337
310
    
338
311
    def update_timer(self):
339
 
        """called by gobject. Will indefinitely loop until
340
 
        gobject.source_remove() on tag is called"""
 
312
        """called by GObject. Will indefinitely loop until
 
313
        GObject.source_remove() on tag is called"""
341
314
        self.update()
342
315
        return True             # Keep calling this
343
316
    
344
 
    def delete(self, *args, **kwargs):
 
317
    def delete(self, **kwargs):
345
318
        if self._update_timer_callback_tag is not None:
346
 
            gobject.source_remove(self._update_timer_callback_tag)
 
319
            GObject.source_remove(self._update_timer_callback_tag)
347
320
            self._update_timer_callback_tag = None
348
321
        for match in self.match_objects:
349
322
            match.remove()
350
323
        self.match_objects = ()
351
324
        if self.delete_hook is not None:
352
325
            self.delete_hook(self)
353
 
        return super(MandosClientWidget, self).delete(*args, **kwargs)
 
326
        return super(MandosClientWidget, self).delete(**kwargs)
354
327
    
355
328
    def render(self, maxcolrow, focus=False):
356
329
        """Render differently if we have focus.
362
335
        """Handle keys.
363
336
        This overrides the method from urwid.FlowWidget"""
364
337
        if key == "+":
365
 
            self.proxy.Enable(dbus_interface = client_interface,
366
 
                              ignore_reply=True)
 
338
            self.proxy.Set(client_interface, "Enabled",
 
339
                           dbus.Boolean(True), ignore_reply = True,
 
340
                           dbus_interface = dbus.PROPERTIES_IFACE)
367
341
        elif key == "-":
368
 
            self.proxy.Disable(dbus_interface = client_interface,
369
 
                               ignore_reply=True)
 
342
            self.proxy.Set(client_interface, "Enabled", False,
 
343
                           ignore_reply = True,
 
344
                           dbus_interface = dbus.PROPERTIES_IFACE)
370
345
        elif key == "a":
371
346
            self.proxy.Approve(dbus.Boolean(True, variant_level=1),
372
347
                               dbus_interface = client_interface,
380
355
                                                  .object_path,
381
356
                                                  ignore_reply=True)
382
357
        elif key == "s":
383
 
            self.proxy.StartChecker(dbus_interface = client_interface,
384
 
                                    ignore_reply=True)
 
358
            self.proxy.Set(client_interface, "CheckerRunning",
 
359
                           dbus.Boolean(True), ignore_reply = True,
 
360
                           dbus_interface = dbus.PROPERTIES_IFACE)
385
361
        elif key == "S":
386
 
            self.proxy.StopChecker(dbus_interface = client_interface,
387
 
                                   ignore_reply=True)
 
362
            self.proxy.Set(client_interface, "CheckerRunning",
 
363
                           dbus.Boolean(False), ignore_reply = True,
 
364
                           dbus_interface = dbus.PROPERTIES_IFACE)
388
365
        elif key == "C":
389
366
            self.proxy.CheckedOK(dbus_interface = client_interface,
390
367
                                 ignore_reply=True)
398
375
        else:
399
376
            return key
400
377
    
401
 
    def property_changed(self, property=None, value=None,
402
 
                         *args, **kwargs):
403
 
        """Call self.update() if old value is not new value.
 
378
    def properties_changed(self, interface, properties, invalidated):
 
379
        """Call self.update() if any properties changed.
404
380
        This overrides the method from MandosClientPropertyCache"""
405
 
        property_name = unicode(property)
406
 
        old_value = self.properties.get(property_name)
407
 
        super(MandosClientWidget, self).property_changed(
408
 
            property=property, value=value, *args, **kwargs)
409
 
        if self.properties.get(property_name) != old_value:
 
381
        old_values = { key: self.properties.get(key)
 
382
                       for key in properties.keys() }
 
383
        super(MandosClientWidget, self).properties_changed(
 
384
            interface, properties, invalidated)
 
385
        if any(old_values[key] != self.properties.get(key)
 
386
               for key in old_values):
410
387
            self.update()
411
388
 
412
389
 
415
392
    "down" key presses, thus not allowing any containing widgets to
416
393
    use them as an excuse to shift focus away from this widget.
417
394
    """
418
 
    def keypress(self, maxcolrow, key):
419
 
        ret = super(ConstrainedListBox, self).keypress(maxcolrow, key)
 
395
    def keypress(self, *args, **kwargs):
 
396
        ret = super(ConstrainedListBox, self).keypress(*args, **kwargs)
420
397
        if ret in ("up", "down"):
421
398
            return
422
399
        return ret
426
403
    """This is the entire user interface - the whole screen
427
404
    with boxes, lists of client widgets, etc.
428
405
    """
429
 
    def __init__(self, max_log_length=1000):
 
406
    def __init__(self, max_log_length=1000, log_level=1):
430
407
        DBusGMainLoop(set_as_default=True)
431
408
        
432
409
        self.screen = urwid.curses_display.Screen()
435
412
                ("normal",
436
413
                 "default", "default", None),
437
414
                ("bold",
438
 
                 "default", "default", "bold"),
 
415
                 "bold", "default", "bold"),
439
416
                ("underline-blink",
440
 
                 "default", "default", "underline"),
 
417
                 "underline,blink", "default", "underline,blink"),
441
418
                ("standout",
442
 
                 "default", "default", "standout"),
 
419
                 "standout", "default", "standout"),
443
420
                ("bold-underline-blink",
444
 
                 "default", "default", ("bold", "underline")),
 
421
                 "bold,underline,blink", "default", "bold,underline,blink"),
445
422
                ("bold-standout",
446
 
                 "default", "default", ("bold", "standout")),
 
423
                 "bold,standout", "default", "bold,standout"),
447
424
                ("underline-blink-standout",
448
 
                 "default", "default", ("underline", "standout")),
 
425
                 "underline,blink,standout", "default",
 
426
                 "underline,blink,standout"),
449
427
                ("bold-underline-blink-standout",
450
 
                 "default", "default", ("bold", "underline",
451
 
                                          "standout")),
 
428
                 "bold,underline,blink,standout", "default",
 
429
                 "bold,underline,blink,standout"),
452
430
                ))
453
431
        
454
432
        if urwid.supports_unicode():
469
447
        self.log = []
470
448
        self.max_log_length = max_log_length
471
449
        
 
450
        self.log_level = log_level
 
451
        
472
452
        # We keep a reference to the log widget so we can remove it
473
453
        # from the ListWalker without it getting destroyed
474
454
        self.logbox = ConstrainedListBox(self.log)
485
465
                              "q: Quit  ?: Help"))
486
466
        
487
467
        self.busname = domain + '.Mandos'
488
 
        self.main_loop = gobject.MainLoop()
 
468
        self.main_loop = GObject.MainLoop()
489
469
    
490
470
    def client_not_found(self, fingerprint, address):
491
 
        self.log_message("Client with address {0} and fingerprint"
492
 
                         " {1} could not be found"
 
471
        self.log_message("Client with address {} and fingerprint {}"
 
472
                         " could not be found"
493
473
                         .format(address, fingerprint))
494
474
    
495
475
    def rebuild(self):
508
488
            self.uilist.append(self.logbox)
509
489
        self.topwidget = urwid.Pile(self.uilist)
510
490
    
511
 
    def log_message(self, message):
 
491
    def log_message(self, message, level=1):
 
492
        """Log message formatted with timestamp"""
 
493
        if level < self.log_level:
 
494
            return
512
495
        timestamp = datetime.datetime.now().isoformat()
513
 
        self.log_message_raw(timestamp + ": " + message)
 
496
        self.log_message_raw("{}: {}".format(timestamp, message),
 
497
                             level=level)
514
498
    
515
 
    def log_message_raw(self, markup):
 
499
    def log_message_raw(self, markup, level=1):
516
500
        """Add a log message to the log buffer."""
 
501
        if level < self.log_level:
 
502
            return
517
503
        self.log.append(urwid.Text(markup, wrap=self.log_wrap))
518
504
        if (self.max_log_length
519
505
            and len(self.log) > self.max_log_length):
526
512
        """Toggle visibility of the log buffer."""
527
513
        self.log_visible = not self.log_visible
528
514
        self.rebuild()
529
 
        #self.log_message("Log visibility changed to: "
530
 
        #                 + unicode(self.log_visible))
 
515
        self.log_message("Log visibility changed to: {}"
 
516
                         .format(self.log_visible), level=0)
531
517
    
532
518
    def change_log_display(self):
533
519
        """Change type of log display.
538
524
            self.log_wrap = "clip"
539
525
        for textwidget in self.log:
540
526
            textwidget.set_wrap_mode(self.log_wrap)
541
 
        #self.log_message("Wrap mode: " + self.log_wrap)
 
527
        self.log_message("Wrap mode: {}".format(self.log_wrap),
 
528
                         level=0)
542
529
    
543
 
    def find_and_remove_client(self, path, name):
 
530
    def find_and_remove_client(self, path, interfaces):
544
531
        """Find a client by its object path and remove it.
545
532
        
546
 
        This is connected to the ClientRemoved signal from the
 
533
        This is connected to the InterfacesRemoved signal from the
547
534
        Mandos server object."""
 
535
        if client_interface not in interfaces:
 
536
            # Not a Mandos client object; ignore
 
537
            return
548
538
        try:
549
539
            client = self.clients_dict[path]
550
540
        except KeyError:
551
541
            # not found?
552
 
            self.log_message("Unknown client {0!r} ({1!r}) removed"
553
 
                             .format(name, path))
 
542
            self.log_message("Unknown client {!r} removed"
 
543
                             .format(path))
554
544
            return
555
545
        client.delete()
556
546
    
557
 
    def add_new_client(self, path):
 
547
    def add_new_client(self, path, ifs_and_props):
 
548
        """Find a client by its object path and remove it.
 
549
        
 
550
        This is connected to the InterfacesAdded signal from the
 
551
        Mandos server object.
 
552
        """
 
553
        if client_interface not in ifs_and_props:
 
554
            # Not a Mandos client object; ignore
 
555
            return
558
556
        client_proxy_object = self.bus.get_object(self.busname, path)
559
557
        self.add_client(MandosClientWidget(server_proxy_object
560
558
                                           =self.mandos_serv,
565
563
                                           delete_hook
566
564
                                           =self.remove_client,
567
565
                                           logger
568
 
                                           =self.log_message),
 
566
                                           =self.log_message,
 
567
                                           properties
 
568
                                           = dict(ifs_and_props[
 
569
                                               client_interface])),
569
570
                        path=path)
570
571
    
571
572
    def add_client(self, client, path=None):
573
574
        if path is None:
574
575
            path = client.proxy.object_path
575
576
        self.clients_dict[path] = client
576
 
        self.clients.sort(None, lambda c: c.properties["Name"])
 
577
        self.clients.sort(key=lambda c: c.properties["Name"])
577
578
        self.refresh()
578
579
    
579
580
    def remove_client(self, client, path=None):
581
582
        if path is None:
582
583
            path = client.proxy.object_path
583
584
        del self.clients_dict[path]
584
 
        if not self.clients_dict:
585
 
            # Work around bug in Urwid 0.9.8.3 - if a SimpleListWalker
586
 
            # is completely emptied, we need to recreate it.
587
 
            self.clients = urwid.SimpleListWalker([])
588
 
            self.rebuild()
589
585
        self.refresh()
590
586
    
591
587
    def refresh(self):
604
600
        try:
605
601
            mandos_clients = (self.mandos_serv
606
602
                              .GetAllClientsWithProperties())
 
603
            if not mandos_clients:
 
604
                self.log_message_raw(("bold", "Note: Server has no clients."))
607
605
        except dbus.exceptions.DBusException:
 
606
            self.log_message_raw(("bold", "Note: No Mandos server running."))
608
607
            mandos_clients = dbus.Dictionary()
609
608
        
610
609
        (self.mandos_serv
611
 
         .connect_to_signal("ClientRemoved",
 
610
         .connect_to_signal("InterfacesRemoved",
612
611
                            self.find_and_remove_client,
613
 
                            dbus_interface=server_interface,
 
612
                            dbus_interface
 
613
                            = dbus.OBJECT_MANAGER_IFACE,
614
614
                            byte_arrays=True))
615
615
        (self.mandos_serv
616
 
         .connect_to_signal("ClientAdded",
 
616
         .connect_to_signal("InterfacesAdded",
617
617
                            self.add_new_client,
618
 
                            dbus_interface=server_interface,
 
618
                            dbus_interface
 
619
                            = dbus.OBJECT_MANAGER_IFACE,
619
620
                            byte_arrays=True))
620
621
        (self.mandos_serv
621
622
         .connect_to_signal("ClientNotFound",
622
623
                            self.client_not_found,
623
624
                            dbus_interface=server_interface,
624
625
                            byte_arrays=True))
625
 
        for path, client in mandos_clients.iteritems():
 
626
        for path, client in mandos_clients.items():
626
627
            client_proxy_object = self.bus.get_object(self.busname,
627
628
                                                      path)
628
629
            self.add_client(MandosClientWidget(server_proxy_object
637
638
                                               logger
638
639
                                               =self.log_message),
639
640
                            path=path)
640
 
 
 
641
        
641
642
        self.refresh()
642
 
        self._input_callback_tag = (gobject.io_add_watch
 
643
        self._input_callback_tag = (GObject.io_add_watch
643
644
                                    (sys.stdin.fileno(),
644
 
                                     gobject.IO_IN,
 
645
                                     GObject.IO_IN,
645
646
                                     self.process_input))
646
647
        self.main_loop.run()
647
648
        # Main loop has finished, we should close everything now
648
 
        gobject.source_remove(self._input_callback_tag)
 
649
        GObject.source_remove(self._input_callback_tag)
649
650
        self.screen.stop()
650
651
    
651
652
    def stop(self):
675
676
            elif key == "window resize":
676
677
                self.size = self.screen.get_cols_rows()
677
678
                self.refresh()
678
 
            elif key == "\f":  # Ctrl-L
 
679
            elif key == "ctrl l":
 
680
                self.screen.clear()
679
681
                self.refresh()
680
682
            elif key == "l" or key == "D":
681
683
                self.toggle_log_display()
693
695
                                            "?: Help",
694
696
                                            "l: Log window toggle",
695
697
                                            "TAB: Switch window",
696
 
                                            "w: Wrap (log)"))))
 
698
                                            "w: Wrap (log lines)",
 
699
                                            "v: Toggle verbose log",
 
700
                                            ))))
697
701
                self.log_message_raw(("bold",
698
702
                                      "  "
699
703
                                      .join(("Clients:",
712
716
                else:
713
717
                    self.topwidget.set_focus(self.logbox)
714
718
                self.refresh()
 
719
            elif key == "v":
 
720
                if self.log_level == 0:
 
721
                    self.log_level = 1
 
722
                    self.log_message("Verbose mode: Off")
 
723
                else:
 
724
                    self.log_level = 0
 
725
                    self.log_message("Verbose mode: On")
715
726
            #elif (key == "end" or key == "meta >" or key == "G"
716
727
            #      or key == ">"):
717
728
            #    pass            # xxx end-of-buffer
740
751
    ui.run()
741
752
except KeyboardInterrupt:
742
753
    ui.screen.stop()
743
 
except Exception, e:
744
 
    ui.log_message(unicode(e))
 
754
except Exception as e:
 
755
    ui.log_message(str(e))
745
756
    ui.screen.stop()
746
757
    raise