/mandos/trunk

To get this branch, use:
bzr branch http://bzr.recompile.se/loggerhead/mandos/trunk

« back to all changes in this revision

Viewing changes to plugins.d/mandos-client.c

  • Committer: Teddy Hogeborn
  • Date: 2016-02-28 14:10:37 UTC
  • Revision ID: teddy@recompile.se-20160228141037-fyrxjr3l439zx2jl
Fix Debian dependency bugs and lintian checks.

* debian/control (Source: mandos/Build-Depends-Indep): Change "python
                         (= 2.7)" to "python (>= 2.7), python (<< 3)".
  (Package: mandos/Depends): - '' -
* mandos: Change "#!/usr/bin/python2.7" to "/usr/bin/python", since
          lintian otherwise complains about missing dependency on
          "python2.7".

Show diffs side-by-side

added added

removed removed

Lines of Context:
plugins.d/mandos-client.c
9
9
 * "browse_callback", and parts of "main".
10
10
 * 
11
11
 * Everything else is
12
 
 * Copyright © 2008-2016 Teddy Hogeborn
13
 
 * Copyright © 2008-2016 Björn Påhlsson
 
12
 * Copyright © 2008-2015 Teddy Hogeborn
 
13
 * Copyright © 2008-2015 Björn Påhlsson
14
14
 * 
15
15
 * This program is free software: you can redistribute it and/or
16
16
 * modify it under the terms of the GNU General Public License as
57
57
#include <sys/socket.h>         /* socket(), struct sockaddr_in6,
58
58
                                   inet_pton(), connect(),
59
59
                                   getnameinfo() */
60
 
#include <fcntl.h>              /* open(), unlinkat(), AT_REMOVEDIR */
 
60
#include <fcntl.h>              /* open(), unlinkat() */
61
61
#include <dirent.h>             /* opendir(), struct dirent, readdir()
62
62
                                 */
63
63
#include <inttypes.h>           /* PRIu16, PRIdMAX, intmax_t,
64
64
                                   strtoimax() */
65
 
#include <errno.h>              /* perror(), errno, EINTR, EINVAL,
66
 
                                   EAI_SYSTEM, ENETUNREACH,
67
 
                                   EHOSTUNREACH, ECONNREFUSED, EPROTO,
68
 
                                   EIO, ENOENT, ENXIO, ENOMEM, EISDIR,
69
 
                                   ENOTEMPTY,
 
65
#include <errno.h>              /* perror(), errno,
70
66
                                   program_invocation_short_name */
71
67
#include <time.h>               /* nanosleep(), time(), sleep() */
72
68
#include <net/if.h>             /* ioctl, ifreq, SIOCGIFFLAGS, IFF_UP,
517
513
  fprintf_plus(stderr, "GnuTLS: %s", string);
518
514
}
519
515
 
520
 
__attribute__((nonnull(1, 2, 4), warn_unused_result))
 
516
__attribute__((nonnull, warn_unused_result))
521
517
static int init_gnutls_global(const char *pubkeyfilename,
522
518
                              const char *seckeyfilename,
523
519
                              const char *dhparamsfilename,
529
525
    fprintf_plus(stderr, "Initializing GnuTLS\n");
530
526
  }
531
527
  
 
528
  ret = gnutls_global_init();
 
529
  if(ret != GNUTLS_E_SUCCESS){
 
530
    fprintf_plus(stderr, "GnuTLS global_init: %s\n",
 
531
                 safer_gnutls_strerror(ret));
 
532
    return -1;
 
533
  }
 
534
  
532
535
  if(debug){
533
536
    /* "Use a log level over 10 to enable all debugging options."
534
537
     * - GnuTLS manual
542
545
  if(ret != GNUTLS_E_SUCCESS){
543
546
    fprintf_plus(stderr, "GnuTLS memory error: %s\n",
544
547
                 safer_gnutls_strerror(ret));
 
548
    gnutls_global_deinit();
545
549
    return -1;
546
550
  }
547
551
  
751
755
 globalfail:
752
756
  
753
757
  gnutls_certificate_free_credentials(mc->cred);
 
758
  gnutls_global_deinit();
754
759
  gnutls_dh_params_deinit(mc->dh_params);
755
760
  return -1;
756
761
}
1909
1914
      return;
1910
1915
    }
1911
1916
  }
 
1917
#ifdef __GLIBC__
 
1918
#if __GLIBC_PREREQ(2, 15)
1912
1919
  int numhooks = scandirat(hookdir_fd, ".", &direntries,
1913
1920
                           runnable_hook, alphasort);
 
1921
#else  /* not __GLIBC_PREREQ(2, 15) */
 
1922
  int numhooks = scandir(hookdir, &direntries, runnable_hook,
 
1923
                         alphasort);
 
1924
#endif  /* not __GLIBC_PREREQ(2, 15) */
 
1925
#else   /* not __GLIBC__ */
 
1926
  int numhooks = scandir(hookdir, &direntries, runnable_hook,
 
1927
                         alphasort);
 
1928
#endif  /* not __GLIBC__ */
1914
1929
  if(numhooks == -1){
1915
1930
    perror_plus("scandir");
1916
1931
    return;
2961
2976
  
2962
2977
  if(gnutls_initialized){
2963
2978
    gnutls_certificate_free_credentials(mc.cred);
 
2979
    gnutls_global_deinit();
2964
2980
    gnutls_dh_params_deinit(mc.dh_params);
2965
2981
  }
2966
2982
  
3028
3044
  free(interfaces_to_take_down);
3029
3045
  free(interfaces_hooks);
3030
3046
  
3031
 
  void clean_dir_at(int base, const char * const dirname,
3032
 
                    uintmax_t level){
3033
 
    struct dirent **direntries = NULL;
3034
 
    int dret;
3035
 
    int dir_fd = (int)TEMP_FAILURE_RETRY(openat(base, dirname,
3036
 
                                                O_RDONLY
3037
 
                                                | O_NOFOLLOW
3038
 
                                                | O_DIRECTORY
3039
 
                                                | O_PATH));
3040
 
    if(dir_fd == -1){
3041
 
      perror_plus("open");
3042
 
    }
3043
 
    int numentries = scandirat(dir_fd, ".", &direntries,
3044
 
                               notdotentries, alphasort);
3045
 
    if(numentries >= 0){
3046
 
      for(int i = 0; i < numentries; i++){
3047
 
        if(debug){
3048
 
          fprintf_plus(stderr, "Unlinking \"%s/%s\"\n",
3049
 
                       dirname, direntries[i]->d_name);
3050
 
        }
3051
 
        dret = unlinkat(dir_fd, direntries[i]->d_name, 0);
3052
 
        if(dret == -1){
3053
 
          if(errno == EISDIR){
3054
 
              dret = unlinkat(dir_fd, direntries[i]->d_name,
3055
 
                              AT_REMOVEDIR);
3056
 
          }         
3057
 
          if((dret == -1) and (errno == ENOTEMPTY)
3058
 
             and (strcmp(direntries[i]->d_name, "private-keys-v1.d")
3059
 
                  == 0) and (level == 0)){
3060
 
            /* Recurse only in this special case */
3061
 
            clean_dir_at(dir_fd, direntries[i]->d_name, level+1);
3062
 
            dret = 0;
3063
 
          }
3064
 
          if(dret == -1){
3065
 
            fprintf_plus(stderr, "unlink(\"%s/%s\"): %s\n", dirname,
3066
 
                         direntries[i]->d_name, strerror(errno));
3067
 
          }
3068
 
        }
3069
 
        free(direntries[i]);
3070
 
      }
3071
 
      
3072
 
      /* need to clean even if 0 because man page doesn't specify */
3073
 
      free(direntries);
3074
 
      if(numentries == -1){
3075
 
        perror_plus("scandirat");
3076
 
      }
3077
 
      dret = unlinkat(base, dirname, AT_REMOVEDIR);
3078
 
      if(dret == -1 and errno != ENOENT){
3079
 
        perror_plus("rmdir");
3080
 
      }
3081
 
    } else {
3082
 
      perror_plus("scandirat");
3083
 
    }
3084
 
    close(dir_fd);
3085
 
  }
3086
 
  
3087
3047
  /* Removes the GPGME temp directory and all files inside */
3088
3048
  if(tempdir != NULL){
3089
 
    clean_dir_at(-1, tempdir, 0);
 
3049
    struct dirent **direntries = NULL;
 
3050
    int tempdir_fd = (int)TEMP_FAILURE_RETRY(open(tempdir, O_RDONLY
 
3051
                                                  | O_NOFOLLOW
 
3052
                                                  | O_DIRECTORY
 
3053
                                                  | O_PATH));
 
3054
    if(tempdir_fd == -1){
 
3055
      perror_plus("open");
 
3056
    } else {
 
3057
#ifdef __GLIBC__
 
3058
#if __GLIBC_PREREQ(2, 15)
 
3059
      int numentries = scandirat(tempdir_fd, ".", &direntries,
 
3060
                                 notdotentries, alphasort);
 
3061
#else  /* not __GLIBC_PREREQ(2, 15) */
 
3062
      int numentries = scandir(tempdir, &direntries, notdotentries,
 
3063
                               alphasort);
 
3064
#endif  /* not __GLIBC_PREREQ(2, 15) */
 
3065
#else   /* not __GLIBC__ */
 
3066
      int numentries = scandir(tempdir, &direntries, notdotentries,
 
3067
                               alphasort);
 
3068
#endif  /* not __GLIBC__ */
 
3069
      if(numentries >= 0){
 
3070
        for(int i = 0; i < numentries; i++){
 
3071
          ret = unlinkat(tempdir_fd, direntries[i]->d_name, 0);
 
3072
          if(ret == -1){
 
3073
            fprintf_plus(stderr, "unlinkat(open(\"%s\", O_RDONLY),"
 
3074
                         " \"%s\", 0): %s\n", tempdir,
 
3075
                         direntries[i]->d_name, strerror(errno));
 
3076
          }
 
3077
          free(direntries[i]);
 
3078
        }
 
3079
        
 
3080
        /* need to clean even if 0 because man page doesn't specify */
 
3081
        free(direntries);
 
3082
        if(numentries == -1){
 
3083
          perror_plus("scandir");
 
3084
        }
 
3085
        ret = rmdir(tempdir);
 
3086
        if(ret == -1 and errno != ENOENT){
 
3087
          perror_plus("rmdir");
 
3088
        }
 
3089
      }
 
3090
      close(tempdir_fd);
 
3091
    }
3090
3092
  }
3091
3093
  
3092
3094
  if(quit_now){