/mandos/trunk

To get this branch, use:
bzr branch http://bzr.recompile.se/loggerhead/mandos/trunk

« back to all changes in this revision

Viewing changes to TODO

  • Committer: Teddy Hogeborn
  • Date: 2015-08-10 09:00:23 UTC
  • Revision ID: teddy@recompile.se-20150810090023-fz6vjqr7zf33e2tf
Support the standard org.freedesktop.DBus.ObjectManager interface.

Now that the D-Bus standard has an interface to keep track of new and
removed objects, use that instead of our own methods.  This deprecates
our D-Bus methods "GetAllClients" and "GetAllClientsWithProperties"
and the signals "ClientAdded" and "ClientRemoved", all on the server
interface "se.recompile.Mandos".

* DBUS-API: Removed references to deprecated methods and signals;
  insert reference to the org.freedesktop.DBus.ObjectManager
  interface.
* mandos (DBusObjectWithProperties._get_all_interface_names): New.
  (dbus.OBJECT_MANAGER_IFACE): If not present, monkey patch.
  (DBusObjectWithObjectManager): New.
  (main/MandosDBusService): Inherit from DBusObjectWithObjectManager.
  (main/MandosDBusService.ClientRemoved): Annotate as deprecated.
  (main/MandosDBusService.GetAllClients): - '' -
  (main/MandosDBusService.GetAllClientsWithProperties): Annotate as
                                                        deprecated.
                                                        Also only
                                                        return
                                                        properties on
                                                        client
                                                        interface.
  (main/MandosDBusService.RemoveClient): Call client_removed_signal
                                         instead of ClientRemoved.
  (main/MandosDBusService.GetManagedObjects): New.
  (main/MandosDBusService.client_added_signal): New.
  (main/MandosDBusService.client_removed_signal): - '' -
  (main/cleanup): Call "client_removed_signal" instead of sending
                  "ClientRemoved" signal directly.
  (main): Call "client_added_signal" instead of sending "ClientAdded"
          signal directly.
* mandos-ctl: Use GetManagedObjects instead of
              GetAllClientsWithProperties.  Also, show better error
              message in case of failure to connect to the D-Bus

* mandos-monitor (MandosClientPropertyCache.properties_changed):
  Bug fix; only update properties on client interface.
  (UserInterface.find_and_remove_client): Change to accept arguments
                                          from InterfacesRemoved
                                          signal.  Also, bug fix:
                                          working error message when
                                          removing unknown client.
  (UserInterface.add_new_client): Change to accept arguments from
                                  InterfacesRemoved signal.  Pass
                                  properties to MandosClientWidget
                                  constructor.
  (UserInterface.run): Connect find_and_remove_client method to
                       InterfacesRemoved signal and the add_new_client
                       method to the InterfacesAdded signal.

Show diffs side-by-side

added added

removed removed

Lines of Context:
TODO
1
1
-*- org -*-
2
2
 
3
3
* GIT
4
 
** General: [[https://www.atlassian.com/git/workflows][Git Workflows]], [[http://gitimmersion.com/][Git Immersion]], [[https://news.ycombinator.com/item?id=7036628][Simple git workflow is simple]]
 
4
** General: [[https://www.atlassian.com/git/workflows][Git Workflows]], [[http://gitimmersion.com/][Git Immersion]], [[https://news.ycombinator.com/item?id=7036628][Simple git workflow is simple]] [[https://news.ycombinator.com/item?id=9661349][On undoing, fixing, or removing commits in git]]
5
5
** Intro: [[http://www.eyrie.org/~eagle/notes/debian/git.html#combine][Using Git for Debian Packaging]]
6
6
** Use: [[https://honk.sigxcpu.org/piki/projects/git-buildpackage/][git-buildpackage]]
7
7
** Migration
21
21
 
22
22
* mandos-client
23
23
** TODO [#B] Use capabilities instead of seteuid().
24
 
** TODO [#B] Use struct sockaddr_storage instead of a union
 
24
   https://forums.grsecurity.net/viewtopic.php?f=7&t=2522
25
25
** TODO [#B] Use getaddrinfo(hints=AI_NUMERICHOST) instead of inet_pton()
26
 
** TODO [#B] Prefer /run/tmp over /tmp, if it exists
27
26
** TODO [#C] Make start_mandos_communication() take "struct server".
 
27
** TODO [#C] --interfaces=regex,eth*,noregex (bridge-utils-interfaces(5))
 
28
** TODO [#C] Remove code for GNU libc < 2.15
28
29
 
29
30
* splashy
30
31
** TODO [#B] use scandir(3) instead of readdir(3)
31
32
 
32
33
* usplash (Deprecated)
33
 
** TODO [#A] Make it work again
 
34
** TODO [#B] Make it work again
34
35
** TODO [#B] use scandir(3) instead of readdir(3)
35
36
 
36
37
* askpass-fifo
37
 
** TODO [#B] Drop privileges after opening FIFO.
38
38
 
39
39
* password-prompt
40
40
** TODO [#B] lock stdin (with flock()?)
46
46
* plugin-runner
47
47
** TODO handle printing for errors for plugins
48
48
*** Hook up stderr of plugins, buffer them, and prepend "Mandos Plugin [plugin name]"
49
 
** TODO [#B] use scandir(3) instead of readdir(3)
50
49
** TODO [#C] use same file name rules as run-parts(8)
51
50
** kernel command line option for debug info
52
 
** TODO [#B] Use openat()
53
 
** TODO [#C] Use fnmatch() to look for bad prefixes and suffixes
 
51
** TODO [#C] Remove code for GNU libc < 2.15
54
52
 
55
53
* mandos (server)
 
54
** TODO [#B] --notify-command
 
55
   This would allow the mandos.service to use
 
56
   --notify-command="systemd-notify --pid READY=1"
56
57
** TODO [#B] Log level                                                    :BUGS:
57
58
*** TODO /etc/mandos/clients.d/*.conf
58
59
    Watch this directory and add/remove/update clients?
67
68
    + Approve(False) -> Close client connection immediately
68
69
** TODO [#C] python-parsedatetime
69
70
** TODO Separate logging logic to own object
70
 
** TODO [#A] Limit approval_delay to max gnutls/tls timeout value
 
71
** TODO [#B] Limit approval_delay to max gnutls/tls timeout value
71
72
** TODO [#B] break the wait on approval_delay if connection dies
72
73
** TODO Generate Client.runtime_expansions from client options + extra
73
74
** TODO Allow %%(checker)s as a runtime expansion
74
75
** TODO Use python-tlslite?
75
76
** TODO D-Bus AddClient() method on server object
76
77
** TODO Use org.freedesktop.DBus.Method.NoReply annotation on async methods. :2:
77
 
** TODO Emit [[http://dbus.freedesktop.org/doc/dbus-specification.html#standard-interfaces-properties][org.freedesktop.DBus.Properties.PropertiesChanged]] signal         :2:
78
 
   TODO Deprecate se.recompile.Mandos.Client.PropertyChanged - annotate!
79
 
   TODO Can use "invalidates" annotation to also emit on changed secret.
80
 
** TODO Support [[http://dbus.freedesktop.org/doc/dbus-specification.html#standard-interfaces-objectmanager][org.freedesktop.DBus.ObjectManager]] interface on server object :2:
81
 
   Deprecate methods GetAllClients(), GetAllClientsWithProperties()
82
 
   and signals ClientAdded and ClientRemoved.
83
78
** TODO Save state periodically to recover better from hard shutdowns
84
79
** TODO CheckerCompleted method, deprecate CheckedOK
85
80
** TODO Secret Service API?
86
81
   http://standards.freedesktop.org/secret-service/
87
82
** TODO Remove D-Bus interfaces with old domain name                      :2:
88
 
** TODO Remove old string_to_delta format                                 :2:
89
 
** TODO --no-zeroconf (only valid if port or socket is set)
 
83
** TODO Remove old string_to_delta format                                    :2:
 
84
** TODO http://0pointer.de/blog/projects/stateless.html
 
85
*** tmpfiles snippet to create /var/lib/mandos with right user+perms
 
86
*** File in /usr/lib/sysusers.d to create user+group "_mandos"
 
87
** TODO Error handling on error parsing config files
 
88
** TODO init.d script error handling
 
89
** TODO D-Bus server properties; address, port, interface, etc.              :2:
 
90
** TODO [#C] In Python 3.3, use shlex.quote() instead of re.escape()
90
91
 
91
92
* mandos.xml
92
93
** Add mandos contact info in manual pages
94
95
* mandos-ctl
95
96
*** Handle "no D-Bus server" and/or "no Mandos server found" better
96
97
*** [#B] --dump option
97
 
** TODO Remove old string_to_delta format                                 :2:
 
98
** TODO Remove old string_to_delta format                                    :2:
98
99
 
99
100
* TODO mandos-dispatch
100
101
  Listens for specified D-Bus signals and spawns shell commands with
119
120
*** TODO [#C] use same file name rules as run-parts(8)
120
121
*** TODO [#C] Do not install in initrd.img if configured not to.
121
122
    Use "/etc/initramfs-tools/hooksconf.d/mandos"?
122
 
** TODO [#C] /etc/bash_completion.d/mandos
 
123
** TODO [#C] $(pkg-config --variable=completionsdir bash-completion)
123
124
   From XML sources directly?
124
125
 
125
126
* Side Stuff