/mandos/trunk

To get this branch, use:
bzr branch http://bzr.recompile.se/loggerhead/mandos/trunk

« back to all changes in this revision

Viewing changes to debian/mandos-client.lintian-overrides

  • Committer: Teddy Hogeborn
  • Date: 2015-05-23 20:18:34 UTC
  • mto: This revision was merged to the branch mainline in revision 756.
  • Revision ID: teddy@recompile.se-20150523201834-e89ex4ito93yni8x
mandos: Use multiprocessing module to run checkers.

For a long time, the Mandos server has occasionally logged the message
"ERROR: Child process vanished".  This was never a fatal error, but it
has been annoying and slightly worrying, since a definite cause was
not found.  One potential cause could be the "multiprocessing" and
"subprocess" modules conflicting w.r.t. SIGCHLD.  To avoid this,
change the running of checkers from using subprocess.Popen
asynchronously to instead first create a multiprocessing.Process()
(which is asynchronous) calling a function, and have that function
then call subprocess.call() (which is synchronous).  In this way, the
only thing using any asynchronous subprocesses is the multiprocessing
module.

This makes it necessary to change one small thing in the D-Bus API,
since the subprocesses.call() function does not expose the raw wait(2)
status value.

DBUS-API (CheckerCompleted): Change the second value provided by this
                             D-Bus signal from the raw wait(2) status
                             to the actual terminating signal number.
mandos (subprocess_call_pipe): New function to be called by
                               multiprocessing.Process (starting a
                               separate process).
(Client.last_checker signal): New attribute for signal which
                              terminated last checker.  Like
                              last_checker_status, only not accessible
                              via D-Bus.
(Client.checker_callback): Take new "connection" argument and use it
                           to get returncode; set last_checker_signal.
                           Return False so gobject does not call this
                           callback again.
(Client.start_checker): Start checker using a multiprocessing.Process
                        instead of a subprocess.Popen.
(ClientDBus.checker_callback): Take new "connection" argument.        Call
                               Client.checker_callback early to have
                               it set last_checker_status and
                               last_checker_signal; use those.  Change
                               second value provided to D-Bus signal
                               CheckerCompleted to use
                               last_checker_signal if checker was
                               terminated by signal.
mandos-monitor: Update to reflect DBus API change.
(MandosClientWidget.checker_completed): Take "signal" instead of
                                        "condition" argument.  Use it
                                        accordingly.  Remove dead code
                                        (os.WCOREDUMP case).

Show diffs side-by-side

added added

removed removed

Lines of Context:
2
2
#
3
3
mandos-client binary: non-standard-dir-perm etc/keys/mandos/ 0700 != 0755
4
4
 
5
 
# The directory /usr/lib/mandos/plugins.d contains setuid binaries
6
 
# which are not meant to be run outside an initial RAM disk
 
5
# The directory /usr/lib/<arch>/mandos/plugins.d contains setuid
 
6
# binaries which are not meant to be run outside an initial RAM disk
7
7
# environment (except for test purposes).  It would be insecure to
8
8
# allow anyone to run them.
9
9
#
10
 
mandos-client binary: non-standard-dir-perm usr/lib/mandos/plugins.d/ 0700 != 0755
 
10
mandos-client binary: non-standard-dir-perm usr/lib/*/mandos/plugins.d/ 0700 != 0755
11
11
 
12
12
# These binaries must be setuid root, since they need root powers, but
13
13
# are started by plugin-runner(8mandos), which runs all plugins as
15
15
# system, but in an initial RAM disk environment.  Here they are
16
16
# protected from non-root access by the directory permissions, above.
17
17
#
18
 
mandos-client binary: setuid-binary usr/lib/mandos/plugins.d/mandos-client 4755 root/root
19
 
mandos-client binary: setuid-binary usr/lib/mandos/plugins.d/askpass-fifo 4755 root/root
20
 
mandos-client binary: setuid-binary usr/lib/mandos/plugins.d/splashy 4755 root/root
21
 
mandos-client binary: setuid-binary usr/lib/mandos/plugins.d/usplash 4755 root/root
 
18
mandos-client binary: setuid-binary usr/lib/*/mandos/plugins.d/mandos-client 4755 root/root
 
19
mandos-client binary: setuid-binary usr/lib/*/mandos/plugins.d/askpass-fifo 4755 root/root
 
20
mandos-client binary: setuid-binary usr/lib/*/mandos/plugins.d/splashy 4755 root/root
 
21
mandos-client binary: setuid-binary usr/lib/*/mandos/plugins.d/usplash 4755 root/root
 
22
mandos-client binary: setuid-binary usr/lib/*/mandos/plugins.d/plymouth 4755 root/root
22
23
 
23
24
# The directory /etc/mandos/plugins.d can be used by local system
24
25
# administrators to place plugins in, overriding and complementing
25
 
# /usr/lib/mandos/plugins.d, and must be likewise protected.
 
26
# /usr/lib/<arch>/mandos/plugins.d, and must be likewise protected.
26
27
#
27
28
mandos-client binary: non-standard-dir-perm etc/mandos/plugins.d/ 0700 != 0755