/mandos/trunk

To get this branch, use:
bzr branch http://bzr.recompile.se/loggerhead/mandos/trunk

« back to all changes in this revision

Viewing changes to debian/control

  • Committer: Teddy Hogeborn
  • Date: 2015-05-23 20:18:34 UTC
  • mto: This revision was merged to the branch mainline in revision 756.
  • Revision ID: teddy@recompile.se-20150523201834-e89ex4ito93yni8x
mandos: Use multiprocessing module to run checkers.

For a long time, the Mandos server has occasionally logged the message
"ERROR: Child process vanished".  This was never a fatal error, but it
has been annoying and slightly worrying, since a definite cause was
not found.  One potential cause could be the "multiprocessing" and
"subprocess" modules conflicting w.r.t. SIGCHLD.  To avoid this,
change the running of checkers from using subprocess.Popen
asynchronously to instead first create a multiprocessing.Process()
(which is asynchronous) calling a function, and have that function
then call subprocess.call() (which is synchronous).  In this way, the
only thing using any asynchronous subprocesses is the multiprocessing
module.

This makes it necessary to change one small thing in the D-Bus API,
since the subprocesses.call() function does not expose the raw wait(2)
status value.

DBUS-API (CheckerCompleted): Change the second value provided by this
                             D-Bus signal from the raw wait(2) status
                             to the actual terminating signal number.
mandos (subprocess_call_pipe): New function to be called by
                               multiprocessing.Process (starting a
                               separate process).
(Client.last_checker signal): New attribute for signal which
                              terminated last checker.  Like
                              last_checker_status, only not accessible
                              via D-Bus.
(Client.checker_callback): Take new "connection" argument and use it
                           to get returncode; set last_checker_signal.
                           Return False so gobject does not call this
                           callback again.
(Client.start_checker): Start checker using a multiprocessing.Process
                        instead of a subprocess.Popen.
(ClientDBus.checker_callback): Take new "connection" argument.        Call
                               Client.checker_callback early to have
                               it set last_checker_status and
                               last_checker_signal; use those.  Change
                               second value provided to D-Bus signal
                               CheckerCompleted to use
                               last_checker_signal if checker was
                               terminated by signal.
mandos-monitor: Update to reflect DBus API change.
(MandosClientWidget.checker_completed): Take "signal" instead of
                                        "condition" argument.  Use it
                                        accordingly.  Remove dead code
                                        (os.WCOREDUMP case).

Show diffs side-by-side

added added

removed removed

Lines of Context:
4
4
Maintainer: Mandos Maintainers <mandos@recompile.se>
5
5
Uploaders: Teddy Hogeborn <teddy@recompile.se>,
6
6
           Björn Påhlsson <belorn@recompile.se>
7
 
Build-Depends: debhelper (>= 7), docbook-xml, docbook-xsl,
8
 
        libavahi-core-dev, libgpgme11-dev, libgnutls-dev, xsltproc,
9
 
        pkg-config
10
 
Standards-Version: 3.9.3
 
7
Build-Depends: debhelper (>= 9), docbook-xml, docbook-xsl,
 
8
        libavahi-core-dev, libgpgme11-dev, libgnutls28-dev
 
9
        | gnutls-dev, xsltproc, pkg-config
 
10
Build-Depends-Indep: systemd, python2.7, python2.7-gnutls,
 
11
        python2.7-dbus, python2.7-avahi, python2.7-gobject
 
12
Standards-Version: 3.9.6
11
13
Vcs-Bzr: http://ftp.recompile.se/pub/mandos/trunk
12
14
Vcs-Browser: http://bzr.recompile.se/loggerhead/mandos/trunk/files
13
15
Homepage: http://www.recompile.se/mandos
14
 
DM-Upload-Allowed: yes
15
16
 
16
17
Package: mandos
17
18
Architecture: all
18
 
Depends: ${misc:Depends}, python (>=2.6), python-gnutls, python-dbus,
19
 
        python-avahi, python-gobject, avahi-daemon, adduser,
20
 
        python-urwid, python (>=2.7) | python-argparse,
21
 
        python-gnupginterface
22
 
Recommends: fping
 
19
Depends: ${misc:Depends}, python (>= 2.7), python2.7, python-gnutls,
 
20
        python2.7-gnutls, python-dbus, python2.7-dbus, python-avahi,
 
21
        python2.7-avahi, python-gobject, python2.7-gobject,
 
22
        avahi-daemon, adduser, python-urwid, python2.7-urwid,
 
23
        gnupg (<< 2), initscripts (>= 2.88dsf-13.3)
 
24
Recommends: ssh-client | fping
23
25
Description: server giving encrypted passwords to Mandos clients
24
26
 This is the server part of the Mandos system, which allows
25
27
 computers to have encrypted root file systems and at the
38
40
Package: mandos-client
39
41
Architecture: linux-any
40
42
Depends: ${shlibs:Depends}, ${misc:Depends}, adduser, cryptsetup,
41
 
        gnupg (<< 2), initramfs-tools
 
43
        gnupg (<< 2), initramfs-tools, dpkg-dev (>=1.16.0)
 
44
Recommends: ssh
42
45
Breaks: dropbear (<= 0.53.1-1)
43
46
Enhances: cryptsetup
44
47
Description: do unattended reboots with an encrypted root file system