/mandos/trunk

To get this branch, use:
bzr branch http://bzr.recompile.se/loggerhead/mandos/trunk

« back to all changes in this revision

Viewing changes to TODO

  • Committer: Teddy Hogeborn
  • Date: 2015-05-23 20:18:34 UTC
  • mto: This revision was merged to the branch mainline in revision 756.
  • Revision ID: teddy@recompile.se-20150523201834-e89ex4ito93yni8x
mandos: Use multiprocessing module to run checkers.

For a long time, the Mandos server has occasionally logged the message
"ERROR: Child process vanished".  This was never a fatal error, but it
has been annoying and slightly worrying, since a definite cause was
not found.  One potential cause could be the "multiprocessing" and
"subprocess" modules conflicting w.r.t. SIGCHLD.  To avoid this,
change the running of checkers from using subprocess.Popen
asynchronously to instead first create a multiprocessing.Process()
(which is asynchronous) calling a function, and have that function
then call subprocess.call() (which is synchronous).  In this way, the
only thing using any asynchronous subprocesses is the multiprocessing
module.

This makes it necessary to change one small thing in the D-Bus API,
since the subprocesses.call() function does not expose the raw wait(2)
status value.

DBUS-API (CheckerCompleted): Change the second value provided by this
                             D-Bus signal from the raw wait(2) status
                             to the actual terminating signal number.
mandos (subprocess_call_pipe): New function to be called by
                               multiprocessing.Process (starting a
                               separate process).
(Client.last_checker signal): New attribute for signal which
                              terminated last checker.  Like
                              last_checker_status, only not accessible
                              via D-Bus.
(Client.checker_callback): Take new "connection" argument and use it
                           to get returncode; set last_checker_signal.
                           Return False so gobject does not call this
                           callback again.
(Client.start_checker): Start checker using a multiprocessing.Process
                        instead of a subprocess.Popen.
(ClientDBus.checker_callback): Take new "connection" argument.        Call
                               Client.checker_callback early to have
                               it set last_checker_status and
                               last_checker_signal; use those.  Change
                               second value provided to D-Bus signal
                               CheckerCompleted to use
                               last_checker_signal if checker was
                               terminated by signal.
mandos-monitor: Update to reflect DBus API change.
(MandosClientWidget.checker_completed): Take "signal" instead of
                                        "condition" argument.  Use it
                                        accordingly.  Remove dead code
                                        (os.WCOREDUMP case).

Show diffs side-by-side

added added

removed removed

Lines of Context:
1
1
-*- org -*-
2
2
 
3
3
* GIT
4
 
** General: [[https://www.atlassian.com/git/workflows][Git Workflows]], [[http://gitimmersion.com/][Git Immersion]], [[https://news.ycombinator.com/item?id=7036628][Simple git workflow is simple]] [[https://news.ycombinator.com/item?id=9661349][On undoing, fixing, or removing commits in git]]
 
4
** General: [[https://www.atlassian.com/git/workflows][Git Workflows]], [[http://gitimmersion.com/][Git Immersion]], [[https://news.ycombinator.com/item?id=7036628][Simple git workflow is simple]]
5
5
** Intro: [[http://www.eyrie.org/~eagle/notes/debian/git.html#combine][Using Git for Debian Packaging]]
6
6
** Use: [[https://honk.sigxcpu.org/piki/projects/git-buildpackage/][git-buildpackage]]
7
7
** Migration
20
20
* mandos-applet
21
21
 
22
22
* mandos-client
23
 
** TODO A --server option which only adds to the server list.
24
 
   (Unlike --connect, which implicitly disables zeroconf.)
 
23
** TODO [#A] --dh-params=FILE
25
24
** TODO [#B] Use capabilities instead of seteuid().
26
25
   https://forums.grsecurity.net/viewtopic.php?f=7&t=2522
27
26
** TODO [#B] Use getaddrinfo(hints=AI_NUMERICHOST) instead of inet_pton()
28
27
** TODO [#C] Make start_mandos_communication() take "struct server".
29
28
** TODO [#C] --interfaces=regex,eth*,noregex (bridge-utils-interfaces(5))
30
 
** TODO [#C] Remove code for GNU libc < 2.15
31
29
 
32
30
* splashy
33
31
** TODO [#B] use scandir(3) instead of readdir(3)
34
32
 
35
33
* usplash (Deprecated)
36
 
** TODO [#B] Make it work again
 
34
** TODO [#A] Make it work again
37
35
** TODO [#B] use scandir(3) instead of readdir(3)
38
36
 
39
37
* askpass-fifo
50
48
*** Hook up stderr of plugins, buffer them, and prepend "Mandos Plugin [plugin name]"
51
49
** TODO [#C] use same file name rules as run-parts(8)
52
50
** kernel command line option for debug info
53
 
** TODO [#C] Remove code for GNU libc < 2.15
54
51
 
55
52
* mandos (server)
 
53
** TODO [#B] Work around Avahi issue
 
54
   Avahi does not announce link-local addresses if any global
 
55
   addresses exist: http://lists.freedesktop.org/archives/avahi/2010-March/001863.html
56
56
** TODO [#B] --notify-command
57
57
   This would allow the mandos.service to use
58
58
   --notify-command="systemd-notify --pid READY=1"
70
70
    + Approve(False) -> Close client connection immediately
71
71
** TODO [#C] python-parsedatetime
72
72
** TODO Separate logging logic to own object
73
 
** TODO [#B] Limit approval_delay to max gnutls/tls timeout value
 
73
** TODO [#A] Limit approval_delay to max gnutls/tls timeout value
74
74
** TODO [#B] break the wait on approval_delay if connection dies
75
75
** TODO Generate Client.runtime_expansions from client options + extra
76
76
** TODO Allow %%(checker)s as a runtime expansion
77
77
** TODO Use python-tlslite?
78
78
** TODO D-Bus AddClient() method on server object
79
79
** TODO Use org.freedesktop.DBus.Method.NoReply annotation on async methods. :2:
 
80
** TODO Support [[http://dbus.freedesktop.org/doc/dbus-specification.html#standard-interfaces-objectmanager][org.freedesktop.DBus.ObjectManager]] interface on server object :2:
 
81
   Deprecate methods GetAllClients(), GetAllClientsWithProperties()
 
82
   and signals ClientAdded and ClientRemoved.
80
83
** TODO Save state periodically to recover better from hard shutdowns
81
84
** TODO CheckerCompleted method, deprecate CheckedOK
82
85
** TODO Secret Service API?
122
125
*** TODO [#C] use same file name rules as run-parts(8)
123
126
*** TODO [#C] Do not install in initrd.img if configured not to.
124
127
    Use "/etc/initramfs-tools/hooksconf.d/mandos"?
125
 
** TODO [#C] $(pkg-config --variable=completionsdir bash-completion)
 
128
** TODO [#C] /etc/bash_completion.d/mandos
126
129
   From XML sources directly?
127
130
 
128
131
* Side Stuff