/mandos/trunk

To get this branch, use:
bzr branch http://bzr.recompile.se/loggerhead/mandos/trunk

« back to all changes in this revision

Viewing changes to Makefile

  • Committer: Teddy Hogeborn
  • Date: 2015-07-02 18:22:22 UTC
  • mto: This revision was merged to the branch mainline in revision 759.
  • Revision ID: teddy@recompile.se-20150702182222-034v03mb8orwhezn
mandos-client: Minor changes to check for more error conditions.

* mandos-client.c (add_remove_local_route): Do TEMP_FAILURE_RETRY
                                            around closing of
                                            /dev/null.  Check return
                                            value when opening helper
                                            directory and helper
                                            executable.
  (run_network_hooks): Cast return value of TEMP_FAILURE_RETRY to int.
                       Do TEMP_FAILURE_RETRY around closing of
                       /dev/null.

Show diffs side-by-side

added added

removed removed

Lines of Context:
Makefile
1
 
WARN=-O -Wall -Wformat=2 -Winit-self -Wmissing-include-dirs \
2
 
        -Wswitch-default -Wswitch-enum -Wunused-parameter \
3
 
        -Wstrict-aliasing=1 -Wextra -Wfloat-equal -Wundef -Wshadow \
 
1
WARN=-O -Wall -Wextra -Wdouble-promotion -Wformat=2 -Winit-self \
 
2
        -Wmissing-include-dirs -Wswitch-default -Wswitch-enum \
 
3
        -Wunused -Wuninitialized -Wstrict-overflow=5 \
 
4
        -Wsuggest-attribute=pure -Wsuggest-attribute=const \
 
5
        -Wsuggest-attribute=noreturn -Wfloat-equal -Wundef -Wshadow \
4
6
        -Wunsafe-loop-optimizations -Wpointer-arith \
5
7
        -Wbad-function-cast -Wcast-qual -Wcast-align -Wwrite-strings \
6
 
        -Wconversion -Wstrict-prototypes -Wold-style-definition \
7
 
        -Wpacked -Wnested-externs -Winline -Wvolatile-register-var
8
 
#       -Wunreachable-code 
 
8
        -Wconversion -Wlogical-op -Waggregate-return \
 
9
        -Wstrict-prototypes -Wold-style-definition \
 
10
        -Wmissing-format-attribute -Wnormalized=nfc -Wpacked \
 
11
        -Wredundant-decls -Wnested-externs -Winline -Wvla \
 
12
        -Wvolatile-register-var -Woverlength-strings
9
13
#DEBUG=-ggdb3
10
 
# For info about _FORTIFY_SOURCE, see
11
 
# <http://www.kernel.org/doc/man-pages/online/pages/man7/feature_test_macros.7.html>
 
14
# For info about _FORTIFY_SOURCE, see feature_test_macros(7)
12
15
# and <http://gcc.gnu.org/ml/gcc-patches/2004-09/msg02055.html>.
13
16
FORTIFY=-D_FORTIFY_SOURCE=2 -fstack-protector-all -fPIC
14
17
LINK_FORTIFY_LD=-z relro -z now
20
23
LINK_FORTIFY += -pie
21
24
endif
22
25
#COVERAGE=--coverage
23
 
OPTIMIZE=-Os
 
26
OPTIMIZE=-Os -fno-strict-aliasing
24
27
LANGUAGE=-std=gnu99
25
28
htmldir=man
26
 
version=1.3.0
 
29
version=1.6.9
27
30
SED=sed
28
31
 
 
32
USER=$(firstword $(subst :, ,$(shell getent passwd _mandos || getent passwd nobody || echo 65534)))
 
33
GROUP=$(firstword $(subst :, ,$(shell getent group _mandos || getent group nobody || echo 65534)))
 
34
 
29
35
## Use these settings for a traditional /usr/local install
30
36
# PREFIX=$(DESTDIR)/usr/local
31
37
# CONFDIR=$(DESTDIR)/etc/mandos
32
38
# KEYDIR=$(DESTDIR)/etc/mandos/keys
33
39
# MANDIR=$(PREFIX)/man
34
40
# INITRAMFSTOOLS=$(DESTDIR)/etc/initramfs-tools
 
41
# STATEDIR=$(DESTDIR)/var/lib/mandos
 
42
# LIBDIR=$(PREFIX)/lib
35
43
##
36
44
 
37
45
## These settings are for a package-type install
40
48
KEYDIR=$(DESTDIR)/etc/keys/mandos
41
49
MANDIR=$(PREFIX)/share/man
42
50
INITRAMFSTOOLS=$(DESTDIR)/usr/share/initramfs-tools
 
51
STATEDIR=$(DESTDIR)/var/lib/mandos
 
52
LIBDIR=$(shell \
 
53
        for d in \
 
54
        "/usr/lib/`dpkg-architecture -qDEB_HOST_MULTIARCH 2>/dev/null`" \
 
55
        "`rpm --eval='%{_libdir}' 2>/dev/null`" /usr/lib; do \
 
56
                if [ -d "$$d" -a "$$d" = "$${d%/}" ]; then \
 
57
                        echo "$(DESTDIR)$$d"; \
 
58
                        break; \
 
59
                fi; \
 
60
        done)
43
61
##
44
62
 
 
63
SYSTEMD=$(DESTDIR)$(shell pkg-config systemd --variable=systemdsystemunitdir)
 
64
 
45
65
GNUTLS_CFLAGS=$(shell pkg-config --cflags-only-I gnutls)
46
66
GNUTLS_LIBS=$(shell pkg-config --libs gnutls)
47
67
AVAHI_CFLAGS=$(shell pkg-config --cflags-only-I avahi-core)
51
71
        getconf LFS_LDFLAGS)
52
72
 
53
73
# Do not change these two
54
 
CFLAGS=$(WARN) $(DEBUG) $(FORTIFY) $(COVERAGE) $(OPTIMIZE) \
 
74
CFLAGS+=$(WARN) $(DEBUG) $(FORTIFY) $(COVERAGE) $(OPTIMIZE) \
55
75
        $(LANGUAGE) $(GNUTLS_CFLAGS) $(AVAHI_CFLAGS) $(GPGME_CFLAGS) \
56
76
        -DVERSION='"$(version)"'
57
 
LDFLAGS=$(COVERAGE) $(LINK_FORTIFY) $(foreach flag,$(LINK_FORTIFY_LD),-Xlinker $(flag))
 
77
LDFLAGS+=-Xlinker --as-needed $(COVERAGE) $(LINK_FORTIFY) $(foreach flag,$(LINK_FORTIFY_LD),-Xlinker $(flag))
58
78
 
59
79
# Commands to format a DocBook <refentry> document into a manual page
60
80
DOCBOOKTOMAN=$(strip cd $(dir $<); xsltproc --nonet --xinclude \
63
83
        --param make.single.year.ranges         1 \
64
84
        --param man.output.quietly              1 \
65
85
        --param man.authors.section.enabled     0 \
66
 
         /usr/share/xml/docbook/stylesheet/nwalsh/manpages/docbook.xsl \
 
86
        /usr/share/xml/docbook/stylesheet/nwalsh/manpages/docbook.xsl \
67
87
        $(notdir $<); \
68
 
        $(MANPOST) $(notdir $@))
69
 
# DocBook-to-man post-processing to fix a '\n' escape bug
70
 
MANPOST=$(SED) --in-place --expression='s,\\\\en,\\en,g;s,\\n,\\en,g'
 
88
        if locale --all 2>/dev/null | grep --regexp='^en_US\.utf8$$' \
 
89
        && type man 2>/dev/null; then LANG=en_US.UTF-8 MANWIDTH=80 \
 
90
        man --warnings --encoding=UTF-8 --local-file $(notdir $@); \
 
91
        fi >/dev/null)
71
92
 
72
93
DOCBOOKTOHTML=$(strip xsltproc --nonet --xinclude \
73
94
        --param make.year.ranges                1 \
85
106
PLUGINS=plugins.d/password-prompt plugins.d/mandos-client \
86
107
        plugins.d/usplash plugins.d/splashy plugins.d/askpass-fifo \
87
108
        plugins.d/plymouth
88
 
CPROGS=plugin-runner $(PLUGINS)
 
109
PLUGIN_HELPERS=
 
110
CPROGS=plugin-runner $(PLUGINS) $(PLUGIN_HELPERS)
89
111
PROGS=mandos mandos-keygen mandos-ctl mandos-monitor $(CPROGS)
90
112
DOCS=mandos.8 mandos-keygen.8 mandos-monitor.8 mandos-ctl.8 \
91
113
        mandos.conf.5 mandos-clients.conf.5 plugin-runner.8mandos \
92
114
        plugins.d/mandos-client.8mandos \
93
115
        plugins.d/password-prompt.8mandos plugins.d/usplash.8mandos \
94
116
        plugins.d/splashy.8mandos plugins.d/askpass-fifo.8mandos \
95
 
        plugins.d/plymouth.8mandos
 
117
        plugins.d/plymouth.8mandos intro.8mandos
96
118
 
97
119
htmldocs=$(addsuffix .xhtml,$(DOCS))
98
120
 
119
141
%.8mandos.xhtml: %.xml common.ent legalnotice.xml
120
142
        $(DOCBOOKTOHTML)
121
143
 
 
144
intro.8mandos: intro.xml common.ent legalnotice.xml
 
145
        $(DOCBOOKTOMAN)
 
146
intro.8mandos.xhtml: intro.xml common.ent legalnotice.xml
 
147
        $(DOCBOOKTOHTML)
 
148
 
122
149
mandos.8: mandos.xml common.ent mandos-options.xml overview.xml \
123
150
                legalnotice.xml
124
151
        $(DOCBOOKTOMAN)
210
237
                $@)
211
238
 
212
239
plugins.d/mandos-client: plugins.d/mandos-client.c
213
 
        $(LINK.c) $^ $(GNUTLS_LIBS) $(AVAHI_LIBS) $(strip\
 
240
        $(LINK.c) $^ -lrt $(GNUTLS_LIBS) $(AVAHI_LIBS) $(strip\
214
241
                ) $(GPGME_LIBS) $(LOADLIBES) $(LDLIBS) -o $@
215
242
 
216
 
.PHONY : all doc html clean distclean run-client run-server install \
217
 
        install-server install-client uninstall uninstall-server \
218
 
        uninstall-client purge purge-server purge-client
 
243
.PHONY : all doc html clean distclean mostlyclean maintainer-clean \
 
244
        check run-client run-server install install-html \
 
245
        install-server install-client-nokey install-client uninstall \
 
246
        uninstall-server uninstall-client purge purge-server \
 
247
        purge-client
219
248
 
220
249
clean:
221
250
        -rm --force $(CPROGS) $(objects) $(htmldocs) $(DOCS) core
223
252
distclean: clean
224
253
mostlyclean: clean
225
254
maintainer-clean: clean
226
 
        -rm --force --recursive keydir confdir
 
255
        -rm --force --recursive keydir confdir statedir
227
256
 
228
257
check:  all
229
258
        ./mandos --check
 
259
        ./mandos-ctl --check
230
260
 
231
261
# Run the client with a local config and key
232
262
run-client: all keydir/seckey.txt keydir/pubkey.txt
235
265
        @echo "# ignored.  The messages are caused by not running as root, but   #"
236
266
        @echo "# you should NOT run \"make run-client\" as root unless you also    #"
237
267
        @echo "# unpacked and compiled Mandos as root, which is NOT recommended. #"
238
 
        @echo "# From plugin-runner: setuid: Operation not permitted             #"
 
268
        @echo "# From plugin-runner: setgid: Operation not permitted             #"
 
269
        @echo "#                     setuid: Operation not permitted             #"
239
270
        @echo "# From askpass-fifo:  mkfifo: Permission denied                   #"
240
 
        @echo "# From mandos-client: setuid: Operation not permitted             #"
241
 
        @echo "#                     seteuid: Operation not permitted            #"
242
 
        @echo "#                     klogctl: Operation not permitted            #"
 
271
        @echo "# From mandos-client:                                             #"
 
272
        @echo "#             Failed to raise privileges: Operation not permitted #"
 
273
        @echo "#             Warning: network hook \"*\" exited with status *      #"
243
274
        @echo "###################################################################"
 
275
# We set GNOME_KEYRING_CONTROL to block pam_gnome_keyring
244
276
        ./plugin-runner --plugin-dir=plugins.d \
 
277
                --plugin-helper-dir=plugin-helpers \
245
278
                --config-file=plugin-runner.conf \
246
 
                --options-for=mandos-client:--seckey=keydir/seckey.txt,--pubkey=keydir/pubkey.txt \
 
279
                --options-for=mandos-client:--seckey=keydir/seckey.txt,--pubkey=keydir/pubkey.txt,--network-hook-dir=network-hooks.d \
 
280
                --env-for=mandos-client:GNOME_KEYRING_CONTROL= \
247
281
                $(CLIENTARGS)
248
282
 
249
283
# Used by run-client
252
286
        ./mandos-keygen --dir keydir --force
253
287
 
254
288
# Run the server with a local config
255
 
run-server: confdir/mandos.conf confdir/clients.conf
256
 
        @echo "#################################################################"
257
 
        @echo "# NOTE: Please IGNORE the error about \"Could not open file      #"
258
 
        @echo "# u'/var/run/mandos.pid'\" -  it is harmless and is caused by    #"
259
 
        @echo "# the server not running as root.  Do NOT run \"make run-server\" #"
260
 
        @echo "# server as root if you didn't also unpack and compile it thus. #"
261
 
        @echo "#################################################################"
262
 
        ./mandos --debug --no-dbus --configdir=confdir $(SERVERARGS)
 
289
run-server: confdir/mandos.conf confdir/clients.conf statedir
 
290
        ./mandos --debug --no-dbus --configdir=confdir \
 
291
                --statedir=statedir $(SERVERARGS)
263
292
 
264
293
# Used by run-server
265
294
confdir/mandos.conf: mandos.conf
269
298
        install --directory confdir
270
299
        install --mode=u=rw $< $@
271
300
# Add a client password
272
 
        ./mandos-keygen --dir keydir --password >> $@
 
301
        ./mandos-keygen --dir keydir --password --no-ssh >> $@
 
302
statedir:
 
303
        install --directory statedir
273
304
 
274
305
install: install-server install-client-nokey
275
306
 
280
311
 
281
312
install-server: doc
282
313
        install --directory $(CONFDIR)
 
314
        if install --directory --mode=u=rwx --owner=$(USER) \
 
315
                --group=$(GROUP) $(STATEDIR); then \
 
316
                :; \
 
317
        elif install --directory --mode=u=rwx $(STATEDIR); then \
 
318
                chown -- $(USER):$(GROUP) $(STATEDIR) || :; \
 
319
        fi
283
320
        install --mode=u=rwx,go=rx mandos $(PREFIX)/sbin/mandos
284
321
        install --mode=u=rwx,go=rx --target-directory=$(PREFIX)/sbin \
285
322
                mandos-ctl
293
330
                $(DESTDIR)/etc/dbus-1/system.d/mandos.conf
294
331
        install --mode=u=rwx,go=rx init.d-mandos \
295
332
                $(DESTDIR)/etc/init.d/mandos
 
333
        if [ "$(SYSTEMD)" != "$(DESTDIR)" -a -d "$(SYSTEMD)" ]; then \
 
334
                install --mode=u=rw,go=r mandos.service $(SYSTEMD); \
 
335
        fi
296
336
        install --mode=u=rw,go=r default-mandos \
297
337
                $(DESTDIR)/etc/default/mandos
298
338
        if [ -z $(DESTDIR) ]; then \
308
348
                > $(MANDIR)/man5/mandos.conf.5.gz
309
349
        gzip --best --to-stdout mandos-clients.conf.5 \
310
350
                > $(MANDIR)/man5/mandos-clients.conf.5.gz
 
351
        gzip --best --to-stdout intro.8mandos \
 
352
                > $(MANDIR)/man8/intro.8mandos.gz
311
353
 
312
354
install-client-nokey: all doc
313
 
        install --directory $(PREFIX)/lib/mandos $(CONFDIR)
 
355
        install --directory $(LIBDIR)/mandos $(CONFDIR)
314
356
        install --directory --mode=u=rwx $(KEYDIR) \
315
 
                $(PREFIX)/lib/mandos/plugins.d
316
 
        if [ "$(CONFDIR)" != "$(PREFIX)/lib/mandos" ]; then \
 
357
                $(LIBDIR)/mandos/plugins.d
 
358
        if [ "$(CONFDIR)" != "$(LIBDIR)/mandos" ]; then \
317
359
                install --mode=u=rwx \
318
360
                        --directory "$(CONFDIR)/plugins.d"; \
 
361
                install --directory "$(CONFDIR)/plugin-helpers"; \
319
362
        fi
 
363
        install --mode=u=rwx,go=rx --directory \
 
364
                "$(CONFDIR)/network-hooks.d"
320
365
        install --mode=u=rwx,go=rx \
321
 
                --target-directory=$(PREFIX)/lib/mandos plugin-runner
 
366
                --target-directory=$(LIBDIR)/mandos plugin-runner
322
367
        install --mode=u=rwx,go=rx --target-directory=$(PREFIX)/sbin \
323
368
                mandos-keygen
324
369
        install --mode=u=rwx,go=rx \
325
 
                --target-directory=$(PREFIX)/lib/mandos/plugins.d \
 
370
                --target-directory=$(LIBDIR)/mandos/plugins.d \
326
371
                plugins.d/password-prompt
327
372
        install --mode=u=rwxs,go=rx \
328
 
                --target-directory=$(PREFIX)/lib/mandos/plugins.d \
 
373
                --target-directory=$(LIBDIR)/mandos/plugins.d \
329
374
                plugins.d/mandos-client
330
375
        install --mode=u=rwxs,go=rx \
331
 
                --target-directory=$(PREFIX)/lib/mandos/plugins.d \
 
376
                --target-directory=$(LIBDIR)/mandos/plugins.d \
332
377
                plugins.d/usplash
333
378
        install --mode=u=rwxs,go=rx \
334
 
                --target-directory=$(PREFIX)/lib/mandos/plugins.d \
 
379
                --target-directory=$(LIBDIR)/mandos/plugins.d \
335
380
                plugins.d/splashy
336
381
        install --mode=u=rwxs,go=rx \
337
 
                --target-directory=$(PREFIX)/lib/mandos/plugins.d \
 
382
                --target-directory=$(LIBDIR)/mandos/plugins.d \
338
383
                plugins.d/askpass-fifo
339
384
        install --mode=u=rwxs,go=rx \
340
 
                --target-directory=$(PREFIX)/lib/mandos/plugins.d \
 
385
                --target-directory=$(LIBDIR)/mandos/plugins.d \
341
386
                plugins.d/plymouth
342
387
        install initramfs-tools-hook \
343
388
                $(INITRAMFSTOOLS)/hooks/mandos
389
434
        ! grep --regexp='^ *[^ #].*keyscript=[^,=]*/mandos/' \
390
435
                $(DESTDIR)/etc/crypttab
391
436
        -rm --force $(PREFIX)/sbin/mandos-keygen \
392
 
                $(PREFIX)/lib/mandos/plugin-runner \
393
 
                $(PREFIX)/lib/mandos/plugins.d/password-prompt \
394
 
                $(PREFIX)/lib/mandos/plugins.d/mandos-client \
395
 
                $(PREFIX)/lib/mandos/plugins.d/usplash \
396
 
                $(PREFIX)/lib/mandos/plugins.d/splashy \
397
 
                $(PREFIX)/lib/mandos/plugins.d/askpass-fifo \
398
 
                $(PREFIX)/lib/mandos/plugins.d/plymouth \
 
437
                $(LIBDIR)/mandos/plugin-runner \
 
438
                $(LIBDIR)/mandos/plugins.d/password-prompt \
 
439
                $(LIBDIR)/mandos/plugins.d/mandos-client \
 
440
                $(LIBDIR)/mandos/plugins.d/usplash \
 
441
                $(LIBDIR)/mandos/plugins.d/splashy \
 
442
                $(LIBDIR)/mandos/plugins.d/askpass-fifo \
 
443
                $(LIBDIR)/mandos/plugins.d/plymouth \
399
444
                $(INITRAMFSTOOLS)/hooks/mandos \
400
445
                $(INITRAMFSTOOLS)/conf-hooks.d/mandos \
401
446
                $(INITRAMFSTOOLS)/scripts/init-premount/mandos \
407
452
                $(MANDIR)/man8/splashy.8mandos.gz \
408
453
                $(MANDIR)/man8/askpass-fifo.8mandos.gz \
409
454
                $(MANDIR)/man8/plymouth.8mandos.gz \
410
 
        -rmdir $(PREFIX)/lib/mandos/plugins.d $(CONFDIR)/plugins.d \
411
 
                 $(PREFIX)/lib/mandos $(CONFDIR) $(KEYDIR)
 
455
        -rmdir $(LIBDIR)/mandos/plugins.d $(CONFDIR)/plugins.d \
 
456
                 $(LIBDIR)/mandos $(CONFDIR) $(KEYDIR)
412
457
        update-initramfs -k all -u
413
458
 
414
459
purge: purge-server purge-client
418
463
                $(DESTDIR)/etc/dbus-1/system.d/mandos.conf
419
464
                $(DESTDIR)/etc/default/mandos \
420
465
                $(DESTDIR)/etc/init.d/mandos \
 
466
                $(SYSTEMD)/mandos.service \
 
467
                $(DESTDIR)/run/mandos.pid \
421
468
                $(DESTDIR)/var/run/mandos.pid
422
469
        -rmdir $(CONFDIR)
423
470