/mandos/trunk

To get this branch, use:
bzr branch http://bzr.recompile.se/loggerhead/mandos/trunk

« back to all changes in this revision

Viewing changes to mandos

  • Committer: Teddy Hogeborn
  • Date: 2014-07-13 21:55:28 UTC
  • mfrom: (237.4.49 release)
  • Revision ID: teddy@recompile.se-20140713215528-5lez8qv009g0i1h2
Merge from release branch.

Show diffs side-by-side

added added

removed removed

Lines of Context:
1
 
#!/usr/bin/python2.7
 
1
#!/usr/bin/python
2
2
# -*- mode: python; coding: utf-8 -*-
3
3
4
4
# Mandos server - give out binary blobs to connecting clients.
88
88
    except ImportError:
89
89
        SO_BINDTODEVICE = None
90
90
 
91
 
if sys.version_info.major == 2:
92
 
    str = unicode
93
 
 
94
 
version = "1.6.8"
 
91
version = "1.6.6"
95
92
stored_state_file = "clients.pickle"
96
93
 
97
94
logger = logging.getLogger()
107
104
        SIOCGIFINDEX = 0x8933  # From /usr/include/linux/sockios.h
108
105
        with contextlib.closing(socket.socket()) as s:
109
106
            ifreq = fcntl.ioctl(s, SIOCGIFINDEX,
110
 
                                struct.pack(b"16s16x", interface))
111
 
        interface_index = struct.unpack("I", ifreq[16:20])[0]
 
107
                                struct.pack(str("16s16x"),
 
108
                                            interface))
 
109
        interface_index = struct.unpack(str("I"),
 
110
                                        ifreq[16:20])[0]
112
111
        return interface_index
113
112
 
114
113
 
119
118
    syslogger = (logging.handlers.SysLogHandler
120
119
                 (facility =
121
120
                  logging.handlers.SysLogHandler.LOG_DAEMON,
122
 
                  address = "/dev/log"))
 
121
                  address = str("/dev/log")))
123
122
    syslogger.setFormatter(logging.Formatter
124
123
                           ('Mandos [%(process)d]: %(levelname)s:'
125
124
                            ' %(message)s'))
225
224
class AvahiError(Exception):
226
225
    def __init__(self, value, *args, **kwargs):
227
226
        self.value = value
228
 
        return super(AvahiError, self).__init__(value, *args,
229
 
                                                **kwargs)
 
227
        super(AvahiError, self).__init__(value, *args, **kwargs)
 
228
    def __unicode__(self):
 
229
        return unicode(repr(self.value))
230
230
 
231
231
class AvahiServiceError(AvahiError):
232
232
    pass
282
282
                            " after %i retries, exiting.",
283
283
                            self.rename_count)
284
284
            raise AvahiServiceError("Too many renames")
285
 
        self.name = str(self.server
286
 
                        .GetAlternativeServiceName(self.name))
 
285
        self.name = unicode(self.server
 
286
                            .GetAlternativeServiceName(self.name))
287
287
        logger.info("Changing Zeroconf service name to %r ...",
288
288
                    self.name)
289
289
        self.remove()
337
337
            self.rename()
338
338
        elif state == avahi.ENTRY_GROUP_FAILURE:
339
339
            logger.critical("Avahi: Error in group state changed %s",
340
 
                            str(error))
341
 
            raise AvahiGroupError("State changed: {!s}"
 
340
                            unicode(error))
 
341
            raise AvahiGroupError("State changed: {0!s}"
342
342
                                  .format(error))
343
343
    
344
344
    def cleanup(self):
395
395
        """Add the new name to the syslog messages"""
396
396
        ret = AvahiService.rename(self)
397
397
        syslogger.setFormatter(logging.Formatter
398
 
                               ('Mandos ({}) [%(process)d]:'
 
398
                               ('Mandos ({0}) [%(process)d]:'
399
399
                                ' %(levelname)s: %(message)s'
400
400
                                .format(self.name)))
401
401
        return ret
402
402
 
403
403
 
 
404
def timedelta_to_milliseconds(td):
 
405
    "Convert a datetime.timedelta() to milliseconds"
 
406
    return ((td.days * 24 * 60 * 60 * 1000)
 
407
            + (td.seconds * 1000)
 
408
            + (td.microseconds // 1000))
 
409
 
 
410
 
404
411
class Client(object):
405
412
    """A representation of a client host served by this server.
406
413
    
461
468
                        "enabled": "True",
462
469
                        }
463
470
    
 
471
    def timeout_milliseconds(self):
 
472
        "Return the 'timeout' attribute in milliseconds"
 
473
        return timedelta_to_milliseconds(self.timeout)
 
474
    
 
475
    def extended_timeout_milliseconds(self):
 
476
        "Return the 'extended_timeout' attribute in milliseconds"
 
477
        return timedelta_to_milliseconds(self.extended_timeout)
 
478
    
 
479
    def interval_milliseconds(self):
 
480
        "Return the 'interval' attribute in milliseconds"
 
481
        return timedelta_to_milliseconds(self.interval)
 
482
    
 
483
    def approval_delay_milliseconds(self):
 
484
        return timedelta_to_milliseconds(self.approval_delay)
 
485
    
464
486
    @staticmethod
465
487
    def config_parser(config):
466
488
        """Construct a new dict of client settings of this form:
491
513
                          "rb") as secfile:
492
514
                    client["secret"] = secfile.read()
493
515
            else:
494
 
                raise TypeError("No secret or secfile for section {}"
 
516
                raise TypeError("No secret or secfile for section {0}"
495
517
                                .format(section))
496
518
            client["timeout"] = string_to_delta(section["timeout"])
497
519
            client["extended_timeout"] = string_to_delta(
514
536
            server_settings = {}
515
537
        self.server_settings = server_settings
516
538
        # adding all client settings
517
 
        for setting, value in settings.items():
 
539
        for setting, value in settings.iteritems():
518
540
            setattr(self, setting, value)
519
541
        
520
542
        if self.enabled:
603
625
        if self.checker_initiator_tag is not None:
604
626
            gobject.source_remove(self.checker_initiator_tag)
605
627
        self.checker_initiator_tag = (gobject.timeout_add
606
 
                                      (int(self.interval
607
 
                                           .total_seconds() * 1000),
 
628
                                      (self.interval_milliseconds(),
608
629
                                       self.start_checker))
609
630
        # Schedule a disable() when 'timeout' has passed
610
631
        if self.disable_initiator_tag is not None:
611
632
            gobject.source_remove(self.disable_initiator_tag)
612
633
        self.disable_initiator_tag = (gobject.timeout_add
613
 
                                      (int(self.timeout
614
 
                                           .total_seconds() * 1000),
615
 
                                       self.disable))
 
634
                                   (self.timeout_milliseconds(),
 
635
                                    self.disable))
616
636
        # Also start a new checker *right now*.
617
637
        self.start_checker()
618
638
    
649
669
            self.disable_initiator_tag = None
650
670
        if getattr(self, "enabled", False):
651
671
            self.disable_initiator_tag = (gobject.timeout_add
652
 
                                          (int(timeout.total_seconds()
653
 
                                               * 1000), self.disable))
 
672
                                          (timedelta_to_milliseconds
 
673
                                           (timeout), self.disable))
654
674
            self.expires = datetime.datetime.utcnow() + timeout
655
675
    
656
676
    def need_approval(self):
687
707
        # Start a new checker if needed
688
708
        if self.checker is None:
689
709
            # Escape attributes for the shell
690
 
            escaped_attrs = { attr:
691
 
                                  re.escape(str(getattr(self, attr)))
692
 
                              for attr in self.runtime_expansions }
 
710
            escaped_attrs = dict(
 
711
                (attr, re.escape(unicode(getattr(self, attr))))
 
712
                for attr in
 
713
                self.runtime_expansions)
693
714
            try:
694
715
                command = self.checker_command % escaped_attrs
695
716
            except TypeError as error:
776
797
    # "Set" method, so we fail early here:
777
798
    if byte_arrays and signature != "ay":
778
799
        raise ValueError("Byte arrays not supported for non-'ay'"
779
 
                         " signature {!r}".format(signature))
 
800
                         " signature {0!r}".format(signature))
780
801
    def decorator(func):
781
802
        func._dbus_is_property = True
782
803
        func._dbus_interface = dbus_interface
830
851
class DBusPropertyException(dbus.exceptions.DBusException):
831
852
    """A base class for D-Bus property-related exceptions
832
853
    """
833
 
    pass
 
854
    def __unicode__(self):
 
855
        return unicode(str(self))
 
856
 
834
857
 
835
858
class DBusPropertyAccessException(DBusPropertyException):
836
859
    """A property's access permissions disallows an operation.
859
882
        If called like _is_dbus_thing("method") it returns a function
860
883
        suitable for use as predicate to inspect.getmembers().
861
884
        """
862
 
        return lambda obj: getattr(obj, "_dbus_is_{}".format(thing),
 
885
        return lambda obj: getattr(obj, "_dbus_is_{0}".format(thing),
863
886
                                   False)
864
887
    
865
888
    def _get_all_dbus_things(self, thing):
915
938
            # signatures other than "ay".
916
939
            if prop._dbus_signature != "ay":
917
940
                raise ValueError("Byte arrays not supported for non-"
918
 
                                 "'ay' signature {!r}"
 
941
                                 "'ay' signature {0!r}"
919
942
                                 .format(prop._dbus_signature))
920
943
            value = dbus.ByteArray(b''.join(chr(byte)
921
944
                                            for byte in value))
986
1009
                                              (prop,
987
1010
                                               "_dbus_annotations",
988
1011
                                               {}))
989
 
                        for name, value in annots.items():
 
1012
                        for name, value in annots.iteritems():
990
1013
                            ann_tag = document.createElement(
991
1014
                                "annotation")
992
1015
                            ann_tag.setAttribute("name", name)
995
1018
                # Add interface annotation tags
996
1019
                for annotation, value in dict(
997
1020
                    itertools.chain.from_iterable(
998
 
                        annotations().items()
 
1021
                        annotations().iteritems()
999
1022
                        for name, annotations in
1000
1023
                        self._get_all_dbus_things("interface")
1001
1024
                        if name == if_tag.getAttribute("name")
1002
 
                        )).items():
 
1025
                        )).iteritems():
1003
1026
                    ann_tag = document.createElement("annotation")
1004
1027
                    ann_tag.setAttribute("name", annotation)
1005
1028
                    ann_tag.setAttribute("value", value)
1061
1084
    """
1062
1085
    def wrapper(cls):
1063
1086
        for orig_interface_name, alt_interface_name in (
1064
 
            alt_interface_names.items()):
 
1087
            alt_interface_names.iteritems()):
1065
1088
            attr = {}
1066
1089
            interface_names = set()
1067
1090
            # Go though all attributes of the class
1184
1207
                                        attribute.func_closure)))
1185
1208
            if deprecate:
1186
1209
                # Deprecate all alternate interfaces
1187
 
                iname="_AlternateDBusNames_interface_annotation{}"
 
1210
                iname="_AlternateDBusNames_interface_annotation{0}"
1188
1211
                for interface_name in interface_names:
1189
1212
                    @dbus_interface_annotations(interface_name)
1190
1213
                    def func(self):
1199
1222
            if interface_names:
1200
1223
                # Replace the class with a new subclass of it with
1201
1224
                # methods, signals, etc. as created above.
1202
 
                cls = type(b"{}Alternate".format(cls.__name__),
 
1225
                cls = type(b"{0}Alternate".format(cls.__name__),
1203
1226
                           (cls,), attr)
1204
1227
        return cls
1205
1228
    return wrapper
1225
1248
        Client.__init__(self, *args, **kwargs)
1226
1249
        # Only now, when this client is initialized, can it show up on
1227
1250
        # the D-Bus
1228
 
        client_object_name = str(self.name).translate(
 
1251
        client_object_name = unicode(self.name).translate(
1229
1252
            {ord("."): ord("_"),
1230
1253
             ord("-"): ord("_")})
1231
1254
        self.dbus_object_path = (dbus.ObjectPath
1246
1269
                   to the D-Bus.  Default: no transform
1247
1270
        variant_level: D-Bus variant level.  Default: 1
1248
1271
        """
1249
 
        attrname = "_{}".format(dbus_name)
 
1272
        attrname = "_{0}".format(dbus_name)
1250
1273
        def setter(self, value):
1251
1274
            if hasattr(self, "dbus_object_path"):
1252
1275
                if (not hasattr(self, attrname) or
1282
1305
    approval_delay = notifychangeproperty(dbus.UInt64,
1283
1306
                                          "ApprovalDelay",
1284
1307
                                          type_func =
1285
 
                                          lambda td: td.total_seconds()
1286
 
                                          * 1000)
 
1308
                                          timedelta_to_milliseconds)
1287
1309
    approval_duration = notifychangeproperty(
1288
1310
        dbus.UInt64, "ApprovalDuration",
1289
 
        type_func = lambda td: td.total_seconds() * 1000)
 
1311
        type_func = timedelta_to_milliseconds)
1290
1312
    host = notifychangeproperty(dbus.String, "Host")
1291
1313
    timeout = notifychangeproperty(dbus.UInt64, "Timeout",
1292
 
                                   type_func = lambda td:
1293
 
                                       td.total_seconds() * 1000)
 
1314
                                   type_func =
 
1315
                                   timedelta_to_milliseconds)
1294
1316
    extended_timeout = notifychangeproperty(
1295
1317
        dbus.UInt64, "ExtendedTimeout",
1296
 
        type_func = lambda td: td.total_seconds() * 1000)
 
1318
        type_func = timedelta_to_milliseconds)
1297
1319
    interval = notifychangeproperty(dbus.UInt64,
1298
1320
                                    "Interval",
1299
1321
                                    type_func =
1300
 
                                    lambda td: td.total_seconds()
1301
 
                                    * 1000)
 
1322
                                    timedelta_to_milliseconds)
1302
1323
    checker_command = notifychangeproperty(dbus.String, "Checker")
1303
1324
    
1304
1325
    del notifychangeproperty
1347
1368
    
1348
1369
    def approve(self, value=True):
1349
1370
        self.approved = value
1350
 
        gobject.timeout_add(int(self.approval_duration.total_seconds()
1351
 
                                * 1000), self._reset_approved)
 
1371
        gobject.timeout_add(timedelta_to_milliseconds
 
1372
                            (self.approval_duration),
 
1373
                            self._reset_approved)
1352
1374
        self.send_changedstate()
1353
1375
    
1354
1376
    ## D-Bus methods, signals & properties
1457
1479
                           access="readwrite")
1458
1480
    def ApprovalDelay_dbus_property(self, value=None):
1459
1481
        if value is None:       # get
1460
 
            return dbus.UInt64(self.approval_delay.total_seconds()
1461
 
                               * 1000)
 
1482
            return dbus.UInt64(self.approval_delay_milliseconds())
1462
1483
        self.approval_delay = datetime.timedelta(0, 0, 0, value)
1463
1484
    
1464
1485
    # ApprovalDuration - property
1466
1487
                           access="readwrite")
1467
1488
    def ApprovalDuration_dbus_property(self, value=None):
1468
1489
        if value is None:       # get
1469
 
            return dbus.UInt64(self.approval_duration.total_seconds()
1470
 
                               * 1000)
 
1490
            return dbus.UInt64(timedelta_to_milliseconds(
 
1491
                    self.approval_duration))
1471
1492
        self.approval_duration = datetime.timedelta(0, 0, 0, value)
1472
1493
    
1473
1494
    # Name - property
1486
1507
    def Host_dbus_property(self, value=None):
1487
1508
        if value is None:       # get
1488
1509
            return dbus.String(self.host)
1489
 
        self.host = str(value)
 
1510
        self.host = unicode(value)
1490
1511
    
1491
1512
    # Created - property
1492
1513
    @dbus_service_property(_interface, signature="s", access="read")
1539
1560
                           access="readwrite")
1540
1561
    def Timeout_dbus_property(self, value=None):
1541
1562
        if value is None:       # get
1542
 
            return dbus.UInt64(self.timeout.total_seconds() * 1000)
 
1563
            return dbus.UInt64(self.timeout_milliseconds())
1543
1564
        old_timeout = self.timeout
1544
1565
        self.timeout = datetime.timedelta(0, 0, 0, value)
1545
1566
        # Reschedule disabling
1556
1577
                gobject.source_remove(self.disable_initiator_tag)
1557
1578
                self.disable_initiator_tag = (
1558
1579
                    gobject.timeout_add(
1559
 
                        int((self.expires - now).total_seconds()
1560
 
                            * 1000), self.disable))
 
1580
                        timedelta_to_milliseconds(self.expires - now),
 
1581
                        self.disable))
1561
1582
    
1562
1583
    # ExtendedTimeout - property
1563
1584
    @dbus_service_property(_interface, signature="t",
1564
1585
                           access="readwrite")
1565
1586
    def ExtendedTimeout_dbus_property(self, value=None):
1566
1587
        if value is None:       # get
1567
 
            return dbus.UInt64(self.extended_timeout.total_seconds()
1568
 
                               * 1000)
 
1588
            return dbus.UInt64(self.extended_timeout_milliseconds())
1569
1589
        self.extended_timeout = datetime.timedelta(0, 0, 0, value)
1570
1590
    
1571
1591
    # Interval - property
1573
1593
                           access="readwrite")
1574
1594
    def Interval_dbus_property(self, value=None):
1575
1595
        if value is None:       # get
1576
 
            return dbus.UInt64(self.interval.total_seconds() * 1000)
 
1596
            return dbus.UInt64(self.interval_milliseconds())
1577
1597
        self.interval = datetime.timedelta(0, 0, 0, value)
1578
1598
        if getattr(self, "checker_initiator_tag", None) is None:
1579
1599
            return
1590
1610
    def Checker_dbus_property(self, value=None):
1591
1611
        if value is None:       # get
1592
1612
            return dbus.String(self.checker_command)
1593
 
        self.checker_command = str(value)
 
1613
        self.checker_command = unicode(value)
1594
1614
    
1595
1615
    # CheckerRunning - property
1596
1616
    @dbus_service_property(_interface, signature="b",
1612
1632
    @dbus_service_property(_interface, signature="ay",
1613
1633
                           access="write", byte_arrays=True)
1614
1634
    def Secret_dbus_property(self, value):
1615
 
        self.secret = bytes(value)
 
1635
        self.secret = str(value)
1616
1636
    
1617
1637
    del _interface
1618
1638
 
1652
1672
    def handle(self):
1653
1673
        with contextlib.closing(self.server.child_pipe) as child_pipe:
1654
1674
            logger.info("TCP connection from: %s",
1655
 
                        str(self.client_address))
 
1675
                        unicode(self.client_address))
1656
1676
            logger.debug("Pipe FD: %d",
1657
1677
                         self.server.child_pipe.fileno())
1658
1678
            
1739
1759
                        if self.server.use_dbus:
1740
1760
                            # Emit D-Bus signal
1741
1761
                            client.NeedApproval(
1742
 
                                client.approval_delay.total_seconds()
1743
 
                                * 1000, client.approved_by_default)
 
1762
                                client.approval_delay_milliseconds(),
 
1763
                                client.approved_by_default)
1744
1764
                    else:
1745
1765
                        logger.warning("Client %s was not approved",
1746
1766
                                       client.name)
1752
1772
                    #wait until timeout or approved
1753
1773
                    time = datetime.datetime.now()
1754
1774
                    client.changedstate.acquire()
1755
 
                    client.changedstate.wait(delay.total_seconds())
 
1775
                    client.changedstate.wait(
 
1776
                        float(timedelta_to_milliseconds(delay)
 
1777
                              / 1000))
1756
1778
                    client.changedstate.release()
1757
1779
                    time2 = datetime.datetime.now()
1758
1780
                    if (time2 - time) >= delay:
1957
1979
                try:
1958
1980
                    self.socket.setsockopt(socket.SOL_SOCKET,
1959
1981
                                           SO_BINDTODEVICE,
1960
 
                                           (self.interface + "\0")
1961
 
                                           .encode("utf-8"))
 
1982
                                           str(self.interface + '\0'))
1962
1983
                except socket.error as error:
1963
1984
                    if error.errno == errno.EPERM:
1964
1985
                        logger.error("No permission to bind to"
2167
2188
    token_duration = Token(re.compile(r"P"), None,
2168
2189
                           frozenset((token_year, token_month,
2169
2190
                                      token_day, token_time,
2170
 
                                      token_week)))
 
2191
                                      token_week))),
2171
2192
    # Define starting values
2172
2193
    value = datetime.timedelta() # Value so far
2173
2194
    found_token = None
2174
 
    followers = frozenset((token_duration,)) # Following valid tokens
 
2195
    followers = frozenset(token_duration,) # Following valid tokens
2175
2196
    s = duration                # String left to parse
2176
2197
    # Loop until end token is found
2177
2198
    while found_token is not token_end:
2224
2245
    timevalue = datetime.timedelta(0)
2225
2246
    for s in interval.split():
2226
2247
        try:
2227
 
            suffix = s[-1]
 
2248
            suffix = unicode(s[-1])
2228
2249
            value = int(s[:-1])
2229
2250
            if suffix == "d":
2230
2251
                delta = datetime.timedelta(value)
2237
2258
            elif suffix == "w":
2238
2259
                delta = datetime.timedelta(0, 0, 0, 0, 0, 0, value)
2239
2260
            else:
2240
 
                raise ValueError("Unknown suffix {!r}"
 
2261
                raise ValueError("Unknown suffix {0!r}"
2241
2262
                                 .format(suffix))
2242
2263
        except IndexError as e:
2243
2264
            raise ValueError(*(e.args))
2260
2281
        # Close all standard open file descriptors
2261
2282
        null = os.open(os.devnull, os.O_NOCTTY | os.O_RDWR)
2262
2283
        if not stat.S_ISCHR(os.fstat(null).st_mode):
2263
 
            raise OSError(errno.ENODEV, "{} not a character device"
 
2284
            raise OSError(errno.ENODEV,
 
2285
                          "{0} not a character device"
2264
2286
                          .format(os.devnull))
2265
2287
        os.dup2(null, sys.stdin.fileno())
2266
2288
        os.dup2(null, sys.stdout.fileno())
2276
2298
    
2277
2299
    parser = argparse.ArgumentParser()
2278
2300
    parser.add_argument("-v", "--version", action="version",
2279
 
                        version = "%(prog)s {}".format(version),
 
2301
                        version = "%(prog)s {0}".format(version),
2280
2302
                        help="show version number and exit")
2281
2303
    parser.add_argument("-i", "--interface", metavar="IF",
2282
2304
                        help="Bind to interface IF")
2381
2403
    del options
2382
2404
    # Force all strings to be unicode
2383
2405
    for option in server_settings.keys():
2384
 
        if isinstance(server_settings[option], bytes):
2385
 
            server_settings[option] = (server_settings[option]
2386
 
                                       .decode("utf-8"))
 
2406
        if type(server_settings[option]) is str:
 
2407
            server_settings[option] = unicode(server_settings[option])
2387
2408
    # Force all boolean options to be boolean
2388
2409
    for option in ("debug", "use_dbus", "use_ipv6", "restore",
2389
2410
                   "foreground", "zeroconf"):
2422
2443
    
2423
2444
    if server_settings["servicename"] != "Mandos":
2424
2445
        syslogger.setFormatter(logging.Formatter
2425
 
                               ('Mandos ({}) [%(process)d]:'
 
2446
                               ('Mandos ({0}) [%(process)d]:'
2426
2447
                                ' %(levelname)s: %(message)s'
2427
2448
                                .format(server_settings
2428
2449
                                        ["servicename"])))
2532
2553
                                       protocol = protocol, bus = bus)
2533
2554
        if server_settings["interface"]:
2534
2555
            service.interface = (if_nametoindex
2535
 
                                 (server_settings["interface"]
2536
 
                                  .encode("utf-8")))
 
2556
                                 (str(server_settings["interface"])))
2537
2557
    
2538
2558
    global multiprocessing_manager
2539
2559
    multiprocessing_manager = multiprocessing.Manager()
2563
2583
            os.remove(stored_state_path)
2564
2584
        except IOError as e:
2565
2585
            if e.errno == errno.ENOENT:
2566
 
                logger.warning("Could not load persistent state: {}"
 
2586
                logger.warning("Could not load persistent state: {0}"
2567
2587
                                .format(os.strerror(e.errno)))
2568
2588
            else:
2569
2589
                logger.critical("Could not load persistent state:",
2574
2594
                           "EOFError:", exc_info=e)
2575
2595
    
2576
2596
    with PGPEngine() as pgp:
2577
 
        for client_name, client in clients_data.items():
 
2597
        for client_name, client in clients_data.iteritems():
2578
2598
            # Skip removed clients
2579
2599
            if client_name not in client_settings:
2580
2600
                continue
2605
2625
                if datetime.datetime.utcnow() >= client["expires"]:
2606
2626
                    if not client["last_checked_ok"]:
2607
2627
                        logger.warning(
2608
 
                            "disabling client {} - Client never "
 
2628
                            "disabling client {0} - Client never "
2609
2629
                            "performed a successful checker"
2610
2630
                            .format(client_name))
2611
2631
                        client["enabled"] = False
2612
2632
                    elif client["last_checker_status"] != 0:
2613
2633
                        logger.warning(
2614
 
                            "disabling client {} - Client last"
2615
 
                            " checker failed with error code {}"
 
2634
                            "disabling client {0} - Client "
 
2635
                            "last checker failed with error code {1}"
2616
2636
                            .format(client_name,
2617
2637
                                    client["last_checker_status"]))
2618
2638
                        client["enabled"] = False
2621
2641
                                             .utcnow()
2622
2642
                                             + client["timeout"])
2623
2643
                        logger.debug("Last checker succeeded,"
2624
 
                                     " keeping {} enabled"
 
2644
                                     " keeping {0} enabled"
2625
2645
                                     .format(client_name))
2626
2646
            try:
2627
2647
                client["secret"] = (
2630
2650
                                ["secret"]))
2631
2651
            except PGPError:
2632
2652
                # If decryption fails, we use secret from new settings
2633
 
                logger.debug("Failed to decrypt {} old secret"
 
2653
                logger.debug("Failed to decrypt {0} old secret"
2634
2654
                             .format(client_name))
2635
2655
                client["secret"] = (
2636
2656
                    client_settings[client_name]["secret"])
2644
2664
        clients_data[client_name] = client_settings[client_name]
2645
2665
    
2646
2666
    # Create all client objects
2647
 
    for client_name, client in clients_data.items():
 
2667
    for client_name, client in clients_data.iteritems():
2648
2668
        tcp_server.clients[client_name] = client_class(
2649
2669
            name = client_name, settings = client,
2650
2670
            server_settings = server_settings)
2657
2677
            try:
2658
2678
                with pidfile:
2659
2679
                    pid = os.getpid()
2660
 
                    pidfile.write("{}\n".format(pid).encode("utf-8"))
 
2680
                    pidfile.write(str(pid) + "\n".encode("utf-8"))
2661
2681
            except IOError:
2662
2682
                logger.error("Could not write to file %r with PID %d",
2663
2683
                             pidfilename, pid)
2754
2774
                
2755
2775
                # A list of attributes that can not be pickled
2756
2776
                # + secret.
2757
 
                exclude = { "bus", "changedstate", "secret",
2758
 
                            "checker", "server_settings" }
 
2777
                exclude = set(("bus", "changedstate", "secret",
 
2778
                               "checker", "server_settings"))
2759
2779
                for name, typ in (inspect.getmembers
2760
2780
                                  (dbus.service.Object)):
2761
2781
                    exclude.add(name)
2784
2804
                except NameError:
2785
2805
                    pass
2786
2806
            if e.errno in (errno.ENOENT, errno.EACCES, errno.EEXIST):
2787
 
                logger.warning("Could not save persistent state: {}"
 
2807
                logger.warning("Could not save persistent state: {0}"
2788
2808
                               .format(os.strerror(e.errno)))
2789
2809
            else:
2790
2810
                logger.warning("Could not save persistent state:",