/mandos/trunk

To get this branch, use:
bzr branch http://bzr.recompile.se/loggerhead/mandos/trunk

« back to all changes in this revision

Viewing changes to mandos-keygen

  • Committer: Teddy Hogeborn
  • Date: 2014-06-14 23:43:07 UTC
  • Revision ID: teddy@recompile.se-20140614234307-i0mh9r2n4orkqtki
plugin-runner: Release memory and close FD's correctly in all cases.

* plugins.d/mandos-client.c (main): Init "direntries" to NULL.  Close
                                    "dir_fd" at fallback label.  Do
                                    not free "direntries" if
                                    scandirat() or scandir() failed.
                                    Do free(direntries) at fallback
                                    label.

Show diffs side-by-side

added added

removed removed

Lines of Context:
33
33
KEYCOMMENT=""
34
34
KEYEXPIRE=0
35
35
FORCE=no
36
 
SSH=yes
37
36
KEYCOMMENT_ORIG="$KEYCOMMENT"
38
37
mode=keygen
39
38
 
42
41
fi
43
42
 
44
43
# Parse options
45
 
TEMP=`getopt --options vhpF:d:t:l:s:L:n:e:c:x:fS \
46
 
    --longoptions version,help,password,passfile:,dir:,type:,length:,subtype:,sublength:,name:,email:,comment:,expire:,force,no-ssh \
 
44
TEMP=`getopt --options vhpF:d:t:l:s:L:n:e:c:x:f \
 
45
    --longoptions version,help,password,passfile:,dir:,type:,length:,subtype:,sublength:,name:,email:,comment:,expire:,force \
47
46
    --name "$0" -- "$@"`
48
47
 
49
48
help(){
86
85
                        Encrypt a password from FILE using the key in
87
86
                        the key directory.  All options other than
88
87
                        --dir and --name are ignored.
89
 
  -S, --no-ssh          Don't get SSH key or set "checker" option.
90
88
EOF
91
89
}
92
90
 
105
103
        -c|--comment) KEYCOMMENT="$2"; shift 2;;
106
104
        -x|--expire) KEYEXPIRE="$2"; shift 2;;
107
105
        -f|--force) FORCE=yes; shift;;
108
 
        -S|--no-ssh) SSH=no; shift;;
109
106
        -v|--version) echo "$0 $VERSION"; exit;;
110
107
        -h|--help) help; exit;;
111
108
        --) shift; break;;
191
188
trap "
192
189
set +e; \
193
190
test -n \"$SECFILE\" && shred --remove \"$SECFILE\"; \
194
 
shred --remove \"$RINGDIR\"/sec* 2>/dev/null;
 
191
shred --remove \"$RINGDIR\"/sec*;
195
192
test -n \"$BATCHFILE\" && rm --force \"$BATCHFILE\"; \
196
193
rm --recursive --force \"$RINGDIR\";
197
194
tty --quiet && stty echo; \
277
274
fi
278
275
 
279
276
if [ "$mode" = password ]; then
280
 
    
281
 
    # Make SSH be 0 or 1
282
 
    case "$SSH" in
283
 
        [Yy][Ee][Ss]|[Tt][Rr][Uu][Ee]) SSH=1;;
284
 
        [Nn][Oo]|[Ff][Aa][Ll][Ss][Ee]|*) SSH=0;;
285
 
    esac
286
 
    
287
 
    if [ $SSH -eq 1 ]; then
288
 
        set +e
289
 
        ssh_fingerprint="`ssh-keyscan localhost 2>/dev/null`"
290
 
        if [ $? -ne 0 ]; then
291
 
            ssh_fingerprint=""
292
 
        fi
293
 
        set -e
294
 
        ssh_fingerprint="${ssh_fingerprint#localhost }"
295
 
    fi
296
 
    
297
277
    # Import key into temporary key rings
298
278
    gpg --quiet --batch --no-tty --no-options --enable-dsa2 \
299
279
        --homedir "$RINGDIR" --trust-model always --armor \
362
342
                /^[^-]/s/^/    /p
363
343
            }
364
344
        }' < "$SECFILE"
365
 
    if [ -n "$ssh_fingerprint" ]; then
366
 
        echo 'checker = ssh-keyscan %%(host)s 2>/dev/null | grep --fixed-strings --line-regexp --quiet --regexp="%%(host)s %(ssh_fingerprint)s"'
367
 
        echo "ssh_fingerprint = ${ssh_fingerprint}"
368
 
    fi
369
345
fi
370
346
 
371
347
trap - EXIT
376
352
    shred --remove "$SECFILE"
377
353
fi
378
354
# Remove the key rings
379
 
shred --remove "$RINGDIR"/sec* 2>/dev/null
 
355
shred --remove "$RINGDIR"/sec*
380
356
rm --recursive --force "$RINGDIR"