/mandos/trunk

To get this branch, use:
bzr branch http://bzr.recompile.se/loggerhead/mandos/trunk

« back to all changes in this revision

Viewing changes to Makefile

  • Committer: Teddy Hogeborn
  • Date: 2014-06-14 23:43:07 UTC
  • Revision ID: teddy@recompile.se-20140614234307-i0mh9r2n4orkqtki
plugin-runner: Release memory and close FD's correctly in all cases.

* plugins.d/mandos-client.c (main): Init "direntries" to NULL.  Close
                                    "dir_fd" at fallback label.  Do
                                    not free "direntries" if
                                    scandirat() or scandir() failed.
                                    Do free(direntries) at fallback
                                    label.

Show diffs side-by-side

added added

removed removed

Lines of Context:
Makefile
1
 
WARN=-O -Wall -Wformat=2 -Winit-self -Wmissing-include-dirs \
2
 
        -Wswitch-default -Wswitch-enum -Wunused-parameter \
3
 
        -Wstrict-aliasing=1 -Wextra -Wfloat-equal -Wundef -Wshadow \
 
1
WARN=-O -Wall -Wextra -Wdouble-promotion -Wformat=2 -Winit-self \
 
2
        -Wmissing-include-dirs -Wswitch-default -Wswitch-enum \
 
3
        -Wunused -Wuninitialized -Wstrict-overflow=5 \
 
4
        -Wsuggest-attribute=pure -Wsuggest-attribute=const \
 
5
        -Wsuggest-attribute=noreturn -Wfloat-equal -Wundef -Wshadow \
4
6
        -Wunsafe-loop-optimizations -Wpointer-arith \
5
7
        -Wbad-function-cast -Wcast-qual -Wcast-align -Wwrite-strings \
6
 
        -Wconversion -Wstrict-prototypes -Wold-style-definition \
7
 
        -Wpacked -Wnested-externs -Winline -Wvolatile-register-var
8
 
#       -Wunreachable-code 
 
8
        -Wconversion -Wlogical-op -Waggregate-return \
 
9
        -Wstrict-prototypes -Wold-style-definition \
 
10
        -Wmissing-format-attribute -Wnormalized=nfc -Wpacked \
 
11
        -Wredundant-decls -Wnested-externs -Winline -Wvla \
 
12
        -Wvolatile-register-var -Woverlength-strings
9
13
#DEBUG=-ggdb3
10
 
# For info about _FORTIFY_SOURCE, see
11
 
# <http://www.kernel.org/doc/man-pages/online/pages/man7/feature_test_macros.7.html>
 
14
# For info about _FORTIFY_SOURCE, see feature_test_macros(7)
12
15
# and <http://gcc.gnu.org/ml/gcc-patches/2004-09/msg02055.html>.
13
16
FORTIFY=-D_FORTIFY_SOURCE=2 -fstack-protector-all -fPIC
14
17
LINK_FORTIFY_LD=-z relro -z now
20
23
LINK_FORTIFY += -pie
21
24
endif
22
25
#COVERAGE=--coverage
23
 
OPTIMIZE=-Os
 
26
OPTIMIZE=-Os -fno-strict-aliasing
24
27
LANGUAGE=-std=gnu99
25
28
htmldir=man
26
 
version=1.3.0
 
29
version=1.6.5
27
30
SED=sed
28
31
 
 
32
USER=$(firstword $(subst :, ,$(shell getent passwd _mandos || getent passwd nobody || echo 65534)))
 
33
GROUP=$(firstword $(subst :, ,$(shell getent group _mandos || getent group nobody || echo 65534)))
 
34
 
29
35
## Use these settings for a traditional /usr/local install
30
36
# PREFIX=$(DESTDIR)/usr/local
31
37
# CONFDIR=$(DESTDIR)/etc/mandos
32
38
# KEYDIR=$(DESTDIR)/etc/mandos/keys
33
39
# MANDIR=$(PREFIX)/man
34
40
# INITRAMFSTOOLS=$(DESTDIR)/etc/initramfs-tools
 
41
# STATEDIR=$(DESTDIR)/var/lib/mandos
 
42
# LIBDIR=$(PREFIX)/lib
35
43
##
36
44
 
37
45
## These settings are for a package-type install
40
48
KEYDIR=$(DESTDIR)/etc/keys/mandos
41
49
MANDIR=$(PREFIX)/share/man
42
50
INITRAMFSTOOLS=$(DESTDIR)/usr/share/initramfs-tools
 
51
STATEDIR=$(DESTDIR)/var/lib/mandos
 
52
LIBDIR=$(shell \
 
53
        for d in \
 
54
        "/usr/lib/`dpkg-architecture -qDEB_HOST_MULTIARCH 2>/dev/null`" \
 
55
        "`rpm --eval='%{_libdir}' 2>/dev/null`" /usr/lib; do \
 
56
                if [ -d "$$d" -a "$$d" = "$${d%/}" ]; then \
 
57
                        echo "$(DESTDIR)$$d"; \
 
58
                        break; \
 
59
                fi; \
 
60
        done)
43
61
##
44
62
 
 
63
SYSTEMD=$(DESTDIR)$(shell pkg-config systemd --variable=systemdsystemunitdir)
 
64
 
45
65
GNUTLS_CFLAGS=$(shell pkg-config --cflags-only-I gnutls)
46
66
GNUTLS_LIBS=$(shell pkg-config --libs gnutls)
47
67
AVAHI_CFLAGS=$(shell pkg-config --cflags-only-I avahi-core)
51
71
        getconf LFS_LDFLAGS)
52
72
 
53
73
# Do not change these two
54
 
CFLAGS=$(WARN) $(DEBUG) $(FORTIFY) $(COVERAGE) $(OPTIMIZE) \
 
74
CFLAGS+=$(WARN) $(DEBUG) $(FORTIFY) $(COVERAGE) $(OPTIMIZE) \
55
75
        $(LANGUAGE) $(GNUTLS_CFLAGS) $(AVAHI_CFLAGS) $(GPGME_CFLAGS) \
56
76
        -DVERSION='"$(version)"'
57
 
LDFLAGS=$(COVERAGE) $(LINK_FORTIFY) $(foreach flag,$(LINK_FORTIFY_LD),-Xlinker $(flag))
 
77
LDFLAGS+=-Xlinker --as-needed $(COVERAGE) $(LINK_FORTIFY) $(foreach flag,$(LINK_FORTIFY_LD),-Xlinker $(flag))
58
78
 
59
79
# Commands to format a DocBook <refentry> document into a manual page
60
80
DOCBOOKTOMAN=$(strip cd $(dir $<); xsltproc --nonet --xinclude \
63
83
        --param make.single.year.ranges         1 \
64
84
        --param man.output.quietly              1 \
65
85
        --param man.authors.section.enabled     0 \
66
 
         /usr/share/xml/docbook/stylesheet/nwalsh/manpages/docbook.xsl \
 
86
        /usr/share/xml/docbook/stylesheet/nwalsh/manpages/docbook.xsl \
67
87
        $(notdir $<); \
68
 
        $(MANPOST) $(notdir $@))
69
 
# DocBook-to-man post-processing to fix a '\n' escape bug
70
 
MANPOST=$(SED) --in-place --expression='s,\\\\en,\\en,g;s,\\n,\\en,g'
 
88
        if locale --all 2>/dev/null | grep --regexp='^en_US\.utf8$$' \
 
89
        && type man 2>/dev/null; then LANG=en_US.UTF-8 MANWIDTH=80 \
 
90
        man --warnings --encoding=UTF-8 --local-file $(notdir $@); \
 
91
        fi >/dev/null)
71
92
 
72
93
DOCBOOKTOHTML=$(strip xsltproc --nonet --xinclude \
73
94
        --param make.year.ranges                1 \
92
113
        plugins.d/mandos-client.8mandos \
93
114
        plugins.d/password-prompt.8mandos plugins.d/usplash.8mandos \
94
115
        plugins.d/splashy.8mandos plugins.d/askpass-fifo.8mandos \
95
 
        plugins.d/plymouth.8mandos
 
116
        plugins.d/plymouth.8mandos intro.8mandos
96
117
 
97
118
htmldocs=$(addsuffix .xhtml,$(DOCS))
98
119
 
119
140
%.8mandos.xhtml: %.xml common.ent legalnotice.xml
120
141
        $(DOCBOOKTOHTML)
121
142
 
 
143
intro.8mandos: intro.xml common.ent legalnotice.xml
 
144
        $(DOCBOOKTOMAN)
 
145
intro.8mandos.xhtml: intro.xml common.ent legalnotice.xml
 
146
        $(DOCBOOKTOHTML)
 
147
 
122
148
mandos.8: mandos.xml common.ent mandos-options.xml overview.xml \
123
149
                legalnotice.xml
124
150
        $(DOCBOOKTOMAN)
210
236
                $@)
211
237
 
212
238
plugins.d/mandos-client: plugins.d/mandos-client.c
213
 
        $(LINK.c) $(GNUTLS_LIBS) $(AVAHI_LIBS) $(GPGME_LIBS) $(strip\
214
 
                ) $(COMMON) $^ $(LOADLIBES) $(LDLIBS) -o $@
 
239
        $(LINK.c) $^ -lrt $(GNUTLS_LIBS) $(AVAHI_LIBS) $(strip\
 
240
                ) $(GPGME_LIBS) $(LOADLIBES) $(LDLIBS) -o $@
215
241
 
216
 
.PHONY : all doc html clean distclean run-client run-server install \
217
 
        install-server install-client uninstall uninstall-server \
218
 
        uninstall-client purge purge-server purge-client
 
242
.PHONY : all doc html clean distclean mostlyclean maintainer-clean \
 
243
        check run-client run-server install install-html \
 
244
        install-server install-client-nokey install-client uninstall \
 
245
        uninstall-server uninstall-client purge purge-server \
 
246
        purge-client
219
247
 
220
248
clean:
221
249
        -rm --force $(CPROGS) $(objects) $(htmldocs) $(DOCS) core
223
251
distclean: clean
224
252
mostlyclean: clean
225
253
maintainer-clean: clean
226
 
        -rm --force --recursive keydir confdir
 
254
        -rm --force --recursive keydir confdir statedir
227
255
 
228
256
check:  all
229
257
        ./mandos --check
 
258
        ./mandos-ctl --check
230
259
 
231
260
# Run the client with a local config and key
232
261
run-client: all keydir/seckey.txt keydir/pubkey.txt
243
272
        @echo "###################################################################"
244
273
        ./plugin-runner --plugin-dir=plugins.d \
245
274
                --config-file=plugin-runner.conf \
246
 
                --options-for=mandos-client:--seckey=keydir/seckey.txt,--pubkey=keydir/pubkey.txt \
 
275
                --options-for=mandos-client:--seckey=keydir/seckey.txt,--pubkey=keydir/pubkey.txt,--network-hook-dir=network-hooks.d \
247
276
                $(CLIENTARGS)
248
277
 
249
278
# Used by run-client
252
281
        ./mandos-keygen --dir keydir --force
253
282
 
254
283
# Run the server with a local config
255
 
run-server: confdir/mandos.conf confdir/clients.conf
256
 
        @echo "#################################################################"
257
 
        @echo "# NOTE: Please IGNORE the error about \"Could not open file      #"
258
 
        @echo "# u'/var/run/mandos.pid'\" -  it is harmless and is caused by    #"
259
 
        @echo "# the server not running as root.  Do NOT run \"make run-server\" #"
260
 
        @echo "# server as root if you didn't also unpack and compile it thus. #"
261
 
        @echo "#################################################################"
262
 
        ./mandos --debug --no-dbus --configdir=confdir $(SERVERARGS)
 
284
run-server: confdir/mandos.conf confdir/clients.conf statedir
 
285
        ./mandos --debug --no-dbus --configdir=confdir \
 
286
                --statedir=statedir $(SERVERARGS)
263
287
 
264
288
# Used by run-server
265
289
confdir/mandos.conf: mandos.conf
270
294
        install --mode=u=rw $< $@
271
295
# Add a client password
272
296
        ./mandos-keygen --dir keydir --password >> $@
 
297
statedir:
 
298
        install --directory statedir
273
299
 
274
300
install: install-server install-client-nokey
275
301
 
280
306
 
281
307
install-server: doc
282
308
        install --directory $(CONFDIR)
 
309
        if install --directory --mode=u=rwx --owner=$(USER) \
 
310
                --group=$(GROUP) $(STATEDIR); then \
 
311
                :; \
 
312
        elif install --directory --mode=u=rwx $(STATEDIR); then \
 
313
                chown -- $(USER):$(GROUP) $(STATEDIR) || :; \
 
314
        fi
283
315
        install --mode=u=rwx,go=rx mandos $(PREFIX)/sbin/mandos
284
316
        install --mode=u=rwx,go=rx --target-directory=$(PREFIX)/sbin \
285
317
                mandos-ctl
293
325
                $(DESTDIR)/etc/dbus-1/system.d/mandos.conf
294
326
        install --mode=u=rwx,go=rx init.d-mandos \
295
327
                $(DESTDIR)/etc/init.d/mandos
 
328
        if [ "$(SYSTEMD)" != "$(DESTDIR)" -a -d "$(SYSTEMD)" ]; then \
 
329
                install --mode=u=rw,go=r mandos.service $(SYSTEMD); \
 
330
        fi
296
331
        install --mode=u=rw,go=r default-mandos \
297
332
                $(DESTDIR)/etc/default/mandos
298
333
        if [ -z $(DESTDIR) ]; then \
308
343
                > $(MANDIR)/man5/mandos.conf.5.gz
309
344
        gzip --best --to-stdout mandos-clients.conf.5 \
310
345
                > $(MANDIR)/man5/mandos-clients.conf.5.gz
 
346
        gzip --best --to-stdout intro.8mandos \
 
347
                > $(MANDIR)/man8/intro.8mandos.gz
311
348
 
312
349
install-client-nokey: all doc
313
 
        install --directory $(PREFIX)/lib/mandos $(CONFDIR)
 
350
        install --directory $(LIBDIR)/mandos $(CONFDIR)
314
351
        install --directory --mode=u=rwx $(KEYDIR) \
315
 
                $(PREFIX)/lib/mandos/plugins.d
316
 
        if [ "$(CONFDIR)" != "$(PREFIX)/lib/mandos" ]; then \
 
352
                $(LIBDIR)/mandos/plugins.d
 
353
        if [ "$(CONFDIR)" != "$(LIBDIR)/mandos" ]; then \
317
354
                install --mode=u=rwx \
318
355
                        --directory "$(CONFDIR)/plugins.d"; \
319
356
        fi
 
357
        install --mode=u=rwx,go=rx --directory \
 
358
                "$(CONFDIR)/network-hooks.d"
320
359
        install --mode=u=rwx,go=rx \
321
 
                --target-directory=$(PREFIX)/lib/mandos plugin-runner
 
360
                --target-directory=$(LIBDIR)/mandos plugin-runner
322
361
        install --mode=u=rwx,go=rx --target-directory=$(PREFIX)/sbin \
323
362
                mandos-keygen
324
363
        install --mode=u=rwx,go=rx \
325
 
                --target-directory=$(PREFIX)/lib/mandos/plugins.d \
 
364
                --target-directory=$(LIBDIR)/mandos/plugins.d \
326
365
                plugins.d/password-prompt
327
366
        install --mode=u=rwxs,go=rx \
328
 
                --target-directory=$(PREFIX)/lib/mandos/plugins.d \
 
367
                --target-directory=$(LIBDIR)/mandos/plugins.d \
329
368
                plugins.d/mandos-client
330
369
        install --mode=u=rwxs,go=rx \
331
 
                --target-directory=$(PREFIX)/lib/mandos/plugins.d \
 
370
                --target-directory=$(LIBDIR)/mandos/plugins.d \
332
371
                plugins.d/usplash
333
372
        install --mode=u=rwxs,go=rx \
334
 
                --target-directory=$(PREFIX)/lib/mandos/plugins.d \
 
373
                --target-directory=$(LIBDIR)/mandos/plugins.d \
335
374
                plugins.d/splashy
336
375
        install --mode=u=rwxs,go=rx \
337
 
                --target-directory=$(PREFIX)/lib/mandos/plugins.d \
 
376
                --target-directory=$(LIBDIR)/mandos/plugins.d \
338
377
                plugins.d/askpass-fifo
339
378
        install --mode=u=rwxs,go=rx \
340
 
                --target-directory=$(PREFIX)/lib/mandos/plugins.d \
 
379
                --target-directory=$(LIBDIR)/mandos/plugins.d \
341
380
                plugins.d/plymouth
342
381
        install initramfs-tools-hook \
343
382
                $(INITRAMFSTOOLS)/hooks/mandos
389
428
        ! grep --regexp='^ *[^ #].*keyscript=[^,=]*/mandos/' \
390
429
                $(DESTDIR)/etc/crypttab
391
430
        -rm --force $(PREFIX)/sbin/mandos-keygen \
392
 
                $(PREFIX)/lib/mandos/plugin-runner \
393
 
                $(PREFIX)/lib/mandos/plugins.d/password-prompt \
394
 
                $(PREFIX)/lib/mandos/plugins.d/mandos-client \
395
 
                $(PREFIX)/lib/mandos/plugins.d/usplash \
396
 
                $(PREFIX)/lib/mandos/plugins.d/splashy \
397
 
                $(PREFIX)/lib/mandos/plugins.d/askpass-fifo \
398
 
                $(PREFIX)/lib/mandos/plugins.d/plymouth \
 
431
                $(LIBDIR)/mandos/plugin-runner \
 
432
                $(LIBDIR)/mandos/plugins.d/password-prompt \
 
433
                $(LIBDIR)/mandos/plugins.d/mandos-client \
 
434
                $(LIBDIR)/mandos/plugins.d/usplash \
 
435
                $(LIBDIR)/mandos/plugins.d/splashy \
 
436
                $(LIBDIR)/mandos/plugins.d/askpass-fifo \
 
437
                $(LIBDIR)/mandos/plugins.d/plymouth \
399
438
                $(INITRAMFSTOOLS)/hooks/mandos \
400
439
                $(INITRAMFSTOOLS)/conf-hooks.d/mandos \
401
440
                $(INITRAMFSTOOLS)/scripts/init-premount/mandos \
407
446
                $(MANDIR)/man8/splashy.8mandos.gz \
408
447
                $(MANDIR)/man8/askpass-fifo.8mandos.gz \
409
448
                $(MANDIR)/man8/plymouth.8mandos.gz \
410
 
        -rmdir $(PREFIX)/lib/mandos/plugins.d $(CONFDIR)/plugins.d \
411
 
                 $(PREFIX)/lib/mandos $(CONFDIR) $(KEYDIR)
 
449
        -rmdir $(LIBDIR)/mandos/plugins.d $(CONFDIR)/plugins.d \
 
450
                 $(LIBDIR)/mandos $(CONFDIR) $(KEYDIR)
412
451
        update-initramfs -k all -u
413
452
 
414
453
purge: purge-server purge-client
418
457
                $(DESTDIR)/etc/dbus-1/system.d/mandos.conf
419
458
                $(DESTDIR)/etc/default/mandos \
420
459
                $(DESTDIR)/etc/init.d/mandos \
 
460
                $(SYSTEMD)/mandos.service \
 
461
                $(DESTDIR)/run/mandos.pid \
421
462
                $(DESTDIR)/var/run/mandos.pid
422
463
        -rmdir $(CONFDIR)
423
464