/mandos/trunk

To get this branch, use:
bzr branch http://bzr.recompile.se/loggerhead/mandos/trunk

« back to all changes in this revision

Viewing changes to debian/mandos-client.lintian-overrides

  • Committer: Teddy Hogeborn
  • Date: 2014-06-14 23:29:00 UTC
  • Revision ID: teddy@recompile.se-20140614232900-vhcywskev4u8rz2d
mandos-client: Fix some bugs on error conditions.

* plugins.d/mandos-client.c (run_network_hooks): Init "dirent" to NULL
                                                 and, later, always
                                                 free() it unless
                                                 scandirat() or
                                                 scandir() failed.
  (main): Fix free() of uninitalized memory in case scandirat() or
          scandir() of "/sys/class/net" failed.  Also, when cleaning
          up, even if GPGME temp directory is empty, do
          free(direntries) and remove the directory.

Show diffs side-by-side

added added

removed removed

Lines of Context:
2
2
#
3
3
mandos-client binary: non-standard-dir-perm etc/keys/mandos/ 0700 != 0755
4
4
 
5
 
# The directory /usr/lib/mandos/plugins.d contains setuid binaries
6
 
# which are not meant to be run outside an initial RAM disk
 
5
# The directory /usr/lib/<arch>/mandos/plugins.d contains setuid
 
6
# binaries which are not meant to be run outside an initial RAM disk
7
7
# environment (except for test purposes).  It would be insecure to
8
8
# allow anyone to run them.
9
9
#
10
 
mandos-client binary: non-standard-dir-perm usr/lib/mandos/plugins.d/ 0700 != 0755
 
10
mandos-client binary: non-standard-dir-perm usr/lib/*/mandos/plugins.d/ 0700 != 0755
11
11
 
12
12
# These binaries must be setuid root, since they need root powers, but
13
13
# are started by plugin-runner(8mandos), which runs all plugins as
15
15
# system, but in an initial RAM disk environment.  Here they are
16
16
# protected from non-root access by the directory permissions, above.
17
17
#
18
 
mandos-client binary: setuid-binary usr/lib/mandos/plugins.d/mandos-client 4755 root/root
19
 
mandos-client binary: setuid-binary usr/lib/mandos/plugins.d/askpass-fifo 4755 root/root
20
 
mandos-client binary: setuid-binary usr/lib/mandos/plugins.d/splashy 4755 root/root
21
 
mandos-client binary: setuid-binary usr/lib/mandos/plugins.d/usplash 4755 root/root
22
 
mandos-client binary: setuid-binary usr/lib/mandos/plugins.d/plymouth 4755 root/root
 
18
mandos-client binary: setuid-binary usr/lib/*/mandos/plugins.d/mandos-client 4755 root/root
 
19
mandos-client binary: setuid-binary usr/lib/*/mandos/plugins.d/askpass-fifo 4755 root/root
 
20
mandos-client binary: setuid-binary usr/lib/*/mandos/plugins.d/splashy 4755 root/root
 
21
mandos-client binary: setuid-binary usr/lib/*/mandos/plugins.d/usplash 4755 root/root
 
22
mandos-client binary: setuid-binary usr/lib/*/mandos/plugins.d/plymouth 4755 root/root
23
23
 
24
24
# The directory /etc/mandos/plugins.d can be used by local system
25
25
# administrators to place plugins in, overriding and complementing
26
 
# /usr/lib/mandos/plugins.d, and must be likewise protected.
 
26
# /usr/lib/<arch>/mandos/plugins.d, and must be likewise protected.
27
27
#
28
28
mandos-client binary: non-standard-dir-perm etc/mandos/plugins.d/ 0700 != 0755