19
19
* along with this program. If not, see
20
20
* <http://www.gnu.org/licenses/>.
22
* Contact the authors at <mandos@fukt.bsnet.se>.
22
* Contact the authors at <mandos@recompile.se>.
25
25
#define _GNU_SOURCE /* TEMP_FAILURE_RETRY(), getline(),
27
27
#include <stddef.h> /* size_t, NULL */
28
#include <stdlib.h> /* malloc(), exit(), EXIT_FAILURE,
29
EXIT_SUCCESS, realloc() */
28
#include <stdlib.h> /* malloc(), exit(), EXIT_SUCCESS,
30
30
#include <stdbool.h> /* bool, true, false */
31
#include <stdio.h> /* perror, fileno(), fprintf(),
32
stderr, STDOUT_FILENO */
33
#include <sys/types.h> /* DIR, opendir(), stat(), struct
31
#include <stdio.h> /* fileno(), fprintf(),
32
stderr, STDOUT_FILENO, fclose() */
33
#include <sys/types.h> /* DIR, fdopendir(), fstat(), struct
34
34
stat, waitpid(), WIFEXITED(),
35
35
WEXITSTATUS(), wait(), pid_t,
36
36
uid_t, gid_t, getuid(), getgid(),
38
38
#include <sys/select.h> /* fd_set, select(), FD_ZERO(),
39
39
FD_SET(), FD_ISSET(), FD_CLR */
40
40
#include <sys/wait.h> /* wait(), waitpid(), WIFEXITED(),
42
#include <sys/stat.h> /* struct stat, stat(), S_ISREG() */
41
WEXITSTATUS(), WTERMSIG(),
43
#include <sys/stat.h> /* struct stat, fstat(), S_ISREG() */
43
44
#include <iso646.h> /* and, or, not */
44
#include <dirent.h> /* DIR, struct dirent, opendir(),
45
#include <dirent.h> /* DIR, struct dirent, fdopendir(),
45
46
readdir(), closedir(), dirfd() */
46
#include <unistd.h> /* struct stat, stat(), S_ISREG(),
47
fcntl(), setuid(), setgid(),
48
F_GETFD, F_SETFD, FD_CLOEXEC,
49
access(), pipe(), fork(), close()
50
dup2(), STDOUT_FILENO, _exit(),
51
execv(), write(), read(),
47
#include <unistd.h> /* fcntl(), F_GETFD, F_SETFD,
48
FD_CLOEXEC, write(), STDOUT_FILENO,
49
struct stat, fstat(), close(),
50
setgid(), setuid(), S_ISREG(),
51
faccessat() pipe(), fork(),
52
_exit(), dup2(), fexecve(), read()
53
54
#include <fcntl.h> /* fcntl(), F_GETFD, F_SETFD,
55
#include <string.h> /* strsep, strlen(), asprintf() */
55
FD_CLOEXEC, openat() */
56
#include <string.h> /* strsep, strlen(), strsignal(),
57
strcmp(), strncmp() */
56
58
#include <errno.h> /* errno */
57
59
#include <argp.h> /* struct argp_option, struct
58
60
argp_state, struct argp,
62
64
#include <signal.h> /* struct sigaction, sigemptyset(),
63
65
sigaddset(), sigaction(),
64
66
sigprocmask(), SIG_BLOCK, SIGCHLD,
65
SIG_UNBLOCK, kill() */
67
SIG_UNBLOCK, kill(), sig_atomic_t
66
69
#include <errno.h> /* errno, EBADF */
67
#include <inttypes.h> /* intmax_t, SCNdMAX, PRIdMAX, */
70
#include <inttypes.h> /* intmax_t, PRIdMAX, strtoimax() */
71
#include <sysexits.h> /* EX_OSERR, EX_USAGE, EX_IOERR,
72
EX_CONFIG, EX_UNAVAILABLE, EX_OK */
73
#include <errno.h> /* errno */
74
#include <error.h> /* error() */
75
#include <fnmatch.h> /* fnmatch() */
69
77
#define BUFFER_SIZE 256
109
118
/* Create a new plugin */
110
plugin *new_plugin = malloc(sizeof(plugin));
119
plugin *new_plugin = NULL;
121
new_plugin = malloc(sizeof(plugin));
122
} while(new_plugin == NULL and errno == EINTR);
111
123
if(new_plugin == NULL){
114
126
char *copy_name = NULL;
115
127
if(name != NULL){
116
copy_name = strdup(name);
129
copy_name = strdup(name);
130
} while(copy_name == NULL and errno == EINTR);
117
131
if(copy_name == NULL){
122
*new_plugin = (plugin) { .name = copy_name,
125
.next = plugin_list };
139
*new_plugin = (plugin){ .name = copy_name,
142
.next = plugin_list };
127
new_plugin->argv = malloc(sizeof(char *) * 2);
145
new_plugin->argv = malloc(sizeof(char *) * 2);
146
} while(new_plugin->argv == NULL and errno == EINTR);
128
147
if(new_plugin->argv == NULL){
130
150
free(new_plugin);
133
154
new_plugin->argv[0] = copy_name;
134
155
new_plugin->argv[1] = NULL;
136
new_plugin->environ = malloc(sizeof(char *));
158
new_plugin->environ = malloc(sizeof(char *));
159
} while(new_plugin->environ == NULL and errno == EINTR);
137
160
if(new_plugin->environ == NULL){
139
163
free(new_plugin->argv);
140
164
free(new_plugin);
143
168
new_plugin->environ[0] = NULL;
371
414
.doc = "Group ID the plugins will run as", .group = 3 },
372
415
{ .name = "debug", .key = 132,
373
416
.doc = "Debug mode", .group = 4 },
418
* These reproduce what we would get without ARGP_NO_HELP
420
{ .name = "help", .key = '?',
421
.doc = "Give this help list", .group = -1 },
422
{ .name = "usage", .key = -3,
423
.doc = "Give a short usage message", .group = -1 },
424
{ .name = "version", .key = 'V',
425
.doc = "Print program version", .group = -1 },
377
error_t parse_opt(int key, char *arg, __attribute__((unused))
378
struct argp_state *state) {
429
__attribute__((nonnull(3)))
430
error_t parse_opt(int key, char *arg, struct argp_state *state){
380
435
case 'g': /* --global-options */
383
while((p = strsep(&arg, ",")) != NULL){
387
if(not add_argument(getplugin(NULL), p)){
388
perror("add_argument");
389
return ARGP_ERR_UNKNOWN;
438
while((plugin_option = strsep(&arg, ",")) != NULL){
439
if(not add_argument(getplugin(NULL), plugin_option)){
394
446
case 'G': /* --global-env */
398
if(not add_environment(getplugin(NULL), arg, true)){
399
perror("add_environment");
447
if(add_environment(getplugin(NULL), arg, true)){
402
451
case 'o': /* --options-for */
404
char *p_name = strsep(&arg, ":");
405
if(p_name[0] == '\0' or arg == NULL){
408
char *opt = strsep(&arg, ":");
409
if(opt[0] == '\0' or opt == NULL){
413
while((p = strsep(&opt, ",")) != NULL){
417
if(not add_argument(getplugin(p_name), p)){
418
perror("add_argument");
419
return ARGP_ERR_UNKNOWN;
453
char *option_list = strchr(arg, ':');
454
if(option_list == NULL){
455
argp_error(state, "No colon in \"%s\"", arg);
462
argp_error(state, "Empty plugin name");
467
while((option = strsep(&option_list, ",")) != NULL){
468
if(not add_argument(getplugin(arg), option)){
424
475
case 'E': /* --env-for */
429
477
char *envdef = strchr(arg, ':');
430
478
if(envdef == NULL){
479
argp_error(state, "No colon in \"%s\"", arg);
434
if(not add_environment(getplugin(arg), envdef+1, true)){
435
perror("add_environment");
486
argp_error(state, "Empty plugin name");
490
if(add_environment(getplugin(arg), envdef, true)){
439
495
case 'd': /* --disable */
441
497
plugin *p = getplugin(arg);
443
return ARGP_ERR_UNKNOWN;
448
504
case 'e': /* --enable */
450
506
plugin *p = getplugin(arg);
452
return ARGP_ERR_UNKNOWN;
457
513
case 128: /* --plugin-dir */
459
515
plugindir = strdup(arg);
460
if(plugindir == NULL){
516
if(plugindir != NULL){
464
520
case 129: /* --config-file */
465
521
/* This is already done by parse_opt_config_file() */
467
523
case 130: /* --userid */
468
ret = sscanf(arg, "%" SCNdMAX "%n", &tmpmax, &numchars);
469
if(ret < 1 or tmpmax != (uid_t)tmpmax
470
or arg[numchars] != '\0'){
471
fprintf(stderr, "Bad user ID number: \"%s\", using %"
472
PRIdMAX "\n", arg, (intmax_t)uid);
524
tmp_id = strtoimax(arg, &tmp, 10);
525
if(errno != 0 or tmp == arg or *tmp != '\0'
526
or tmp_id != (uid_t)tmp_id){
527
argp_error(state, "Bad user ID number: \"%s\", using %"
528
PRIdMAX, arg, (intmax_t)uid);
477
534
case 131: /* --groupid */
478
ret = sscanf(arg, "%" SCNdMAX "%n", &tmpmax, &numchars);
479
if(ret < 1 or tmpmax != (gid_t)tmpmax
480
or arg[numchars] != '\0'){
481
fprintf(stderr, "Bad group ID number: \"%s\", using %"
482
PRIdMAX "\n", arg, (intmax_t)gid);
535
tmp_id = strtoimax(arg, &tmp, 10);
536
if(errno != 0 or tmp == arg or *tmp != '\0'
537
or tmp_id != (gid_t)tmp_id){
538
argp_error(state, "Bad group ID number: \"%s\", using %"
539
PRIdMAX, arg, (intmax_t)gid);
487
545
case 132: /* --debug */
549
* These reproduce what we would get without ARGP_NO_HELP
551
case '?': /* --help */
552
state->flags &= ~(unsigned int)ARGP_NO_EXIT; /* force exit */
553
argp_state_help(state, state->out_stream, ARGP_HELP_STD_HELP);
554
case -3: /* --usage */
555
state->flags &= ~(unsigned int)ARGP_NO_EXIT; /* force exit */
556
argp_state_help(state, state->out_stream,
557
ARGP_HELP_USAGE | ARGP_HELP_EXIT_OK);
558
case 'V': /* --version */
559
fprintf(state->out_stream, "%s\n", argp_program_version);
491
563
* When adding more options before this line, remember to also add a
492
564
* "case" to the "parse_opt_config_file" function below.
597
679
new_arg = strdup(p);
598
680
if(new_arg == NULL){
600
exitstatus = EXIT_FAILURE;
681
error(0, errno, "strdup");
682
exitstatus = EX_OSERR;
605
687
custom_argc += 1;
606
custom_argv = realloc(custom_argv, sizeof(char *)
607
* ((unsigned int) custom_argc + 1));
608
if(custom_argv == NULL){
610
exitstatus = EXIT_FAILURE;
689
char **new_argv = realloc(custom_argv, sizeof(char *)
692
if(new_argv == NULL){
693
error(0, errno, "realloc");
694
exitstatus = EX_OSERR;
699
custom_argv = new_argv;
614
702
custom_argv[custom_argc-1] = new_arg;
615
custom_argv[custom_argc] = NULL;
703
custom_argv[custom_argc] = NULL;
707
ret = fclose(conffp);
708
} while(ret == EOF and errno == EINTR);
710
error(0, errno, "fclose");
711
exitstatus = EX_IOERR;
620
716
/* Check for harmful errors and go to fallback. Other errors might
621
717
not affect opening plugins */
622
718
if(errno == EMFILE or errno == ENFILE or errno == ENOMEM){
624
exitstatus = EXIT_FAILURE;
719
error(0, errno, "fopen");
720
exitstatus = EX_OSERR;
628
/* If there was any arguments from configuration file,
629
pass them to parser as command arguments */
724
/* If there were any arguments from the configuration file, pass
725
them to parser as command line arguments */
630
726
if(custom_argv != NULL){
631
ret = argp_parse(&argp, custom_argc, custom_argv, ARGP_IN_ORDER,
633
if(ret == ARGP_ERR_UNKNOWN){
634
fprintf(stderr, "Unknown error while parsing arguments\n");
635
exitstatus = EXIT_FAILURE;
727
ret = argp_parse(&argp, custom_argc, custom_argv,
728
ARGP_IN_ORDER | ARGP_NO_EXIT | ARGP_NO_HELP,
736
error(0, errno, "argp_parse");
737
exitstatus = EX_OSERR;
740
exitstatus = EX_CONFIG;
640
745
/* Parse actual command line arguments, to let them override the
642
ret = argp_parse(&argp, argc, argv, ARGP_IN_ORDER, 0, NULL);
643
if(ret == ARGP_ERR_UNKNOWN){
644
fprintf(stderr, "Unknown error while parsing arguments\n");
645
exitstatus = EXIT_FAILURE;
747
ret = argp_parse(&argp, argc, argv,
748
ARGP_IN_ORDER | ARGP_NO_EXIT | ARGP_NO_HELP,
756
error(0, errno, "argp_parse");
757
exitstatus = EX_OSERR;
760
exitstatus = EX_USAGE;
663
/* Strip permissions down to nobody */
779
/* Work around Debian bug #633582:
780
<http://bugs.debian.org/633582> */
781
int plugindir_fd = open(/* plugindir or */ PDIR, O_RDONLY);
782
if(plugindir_fd == -1){
784
error(0, errno, "open(\"" PDIR "\")");
787
ret = (int)TEMP_FAILURE_RETRY(fstat(plugindir_fd, &st));
789
error(0, errno, "fstat");
791
if(S_ISDIR(st.st_mode) and st.st_uid == 0 and st.st_gid == 0){
792
ret = fchown(plugindir_fd, uid, gid);
794
error(0, errno, "fchown");
798
TEMP_FAILURE_RETRY(close(plugindir_fd));
802
/* Lower permissions */
805
error(0, errno, "setgid");
664
807
ret = setuid(uid);
673
if(plugindir == NULL){
676
dir = opendir(plugindir);
680
perror("Could not open plugin dir");
681
exitstatus = EXIT_FAILURE;
685
/* Set the FD_CLOEXEC flag on the directory, if possible */
809
error(0, errno, "setuid");
812
/* Open plugin directory with close_on_exec flag */
687
int dir_fd = dirfd(dir);
689
ret = set_cloexec_flag(dir_fd);
691
perror("set_cloexec_flag");
692
exitstatus = EXIT_FAILURE;
814
dir_fd = open(plugindir != NULL ? plugindir : PDIR, O_RDONLY |
817
#else /* not O_CLOEXEC */
819
#endif /* not O_CLOEXEC */
822
error(0, errno, "Could not open plugin dir");
823
exitstatus = EX_UNAVAILABLE;
828
/* Set the FD_CLOEXEC flag on the directory */
829
ret = set_cloexec_flag(dir_fd);
831
error(0, errno, "set_cloexec_flag");
832
TEMP_FAILURE_RETRY(close(dir_fd));
833
exitstatus = EX_OSERR;
836
#endif /* O_CLOEXEC */
838
dir = fdopendir(dir_fd);
840
error(0, errno, "Could not open plugin dir");
841
TEMP_FAILURE_RETRY(close(dir_fd));
842
exitstatus = EX_OSERR;
700
849
/* Read and execute any executable in the plugin directory*/
702
dirst = readdir(dir);
852
dirst = readdir(dir);
853
} while(dirst == NULL and errno == EINTR);
704
855
/* All directory entries have been processed */
705
856
if(dirst == NULL){
706
857
if(errno == EBADF){
708
exitstatus = EXIT_FAILURE;
858
error(0, errno, "readdir");
859
exitstatus = EX_IOERR;
714
d_name_len = strlen(dirst->d_name);
716
865
/* Ignore dotfiles, backup files and other junk */
718
867
bool bad_name = false;
720
const char const *bad_prefixes[] = { ".", "#", NULL };
722
const char const *bad_suffixes[] = { "~", "#", ".dpkg-new",
725
".dpkg-divert", NULL };
726
for(const char **pre = bad_prefixes; *pre != NULL; pre++){
727
size_t pre_len = strlen(*pre);
728
if((d_name_len >= pre_len)
729
and strncmp((dirst->d_name), *pre, pre_len) == 0){
731
fprintf(stderr, "Ignoring plugin dir entry \"%s\""
732
" with bad prefix %s\n", dirst->d_name, *pre);
741
for(const char **suf = bad_suffixes; *suf != NULL; suf++){
742
size_t suf_len = strlen(*suf);
743
if((d_name_len >= suf_len)
744
and (strcmp((dirst->d_name)+d_name_len-suf_len, *suf)
747
fprintf(stderr, "Ignoring plugin dir entry \"%s\""
748
" with bad suffix %s\n", dirst->d_name, *suf);
761
if(plugindir == NULL){
762
ret = asprintf(&filename, PDIR "/%s", dirst->d_name);
764
ret = asprintf(&filename, "%s/%s", plugindir, dirst->d_name);
868
const char * const patterns[] = { ".*", "#*#", "*~",
869
"*.dpkg-new", "*.dpkg-old",
870
"*.dpkg-bak", "*.dpkg-divert",
873
#pragma GCC diagnostic push
874
#pragma GCC diagnostic ignored "-Wcast-qual"
876
for(const char **pat = (const char **)patterns;
877
*pat != NULL; pat++){
879
#pragma GCC diagnostic pop
881
if(fnmatch(*pat, dirst->d_name,
882
FNM_FILE_NAME | FNM_PERIOD) != FNM_NOMATCH){
884
fprintf(stderr, "Ignoring plugin dir entry \"%s\""
885
" matching pattern %s\n", dirst->d_name, *pat);
896
int plugin_fd = openat(dir_fd, dirst->d_name, O_RDONLY |
899
#else /* not O_CLOEXEC */
901
#endif /* not O_CLOEXEC */
904
error(0, errno, "Could not open plugin");
908
/* Set the FD_CLOEXEC flag on the plugin FD */
909
ret = set_cloexec_flag(plugin_fd);
911
error(0, errno, "set_cloexec_flag");
912
TEMP_FAILURE_RETRY(close(plugin_fd));
771
ret = stat(filename, &st);
915
#endif /* O_CLOEXEC */
916
ret = (int)TEMP_FAILURE_RETRY(fstat(plugin_fd, &st));
918
error(0, errno, "stat");
919
TEMP_FAILURE_RETRY(close(plugin_fd));
778
923
/* Ignore non-executable files */
779
if(not S_ISREG(st.st_mode) or (access(filename, X_OK) != 0)){
924
if(not S_ISREG(st.st_mode)
925
or (TEMP_FAILURE_RETRY(faccessat(dir_fd, dirst->d_name, X_OK,
781
fprintf(stderr, "Ignoring plugin dir entry \"%s\""
782
" with bad type or mode\n", filename);
928
fprintf(stderr, "Ignoring plugin dir entry \"%s/%s\""
929
" with bad type or mode\n",
930
plugindir != NULL ? plugindir : PDIR, dirst->d_name);
932
TEMP_FAILURE_RETRY(close(plugin_fd));
788
936
plugin *p = getplugin(dirst->d_name);
938
error(0, errno, "getplugin");
939
TEMP_FAILURE_RETRY(close(plugin_fd));
806
954
for(char **a = g->argv + 1; *a != NULL; a++){
807
955
if(not add_argument(p, *a)){
808
perror("add_argument");
956
error(0, errno, "add_argument");
811
959
/* Add global environment variables */
812
960
for(char **e = g->environ; *e != NULL; e++){
813
961
if(not add_environment(p, *e, false)){
814
perror("add_environment");
962
error(0, errno, "add_environment");
819
/* If this plugin has any environment variables, we will call
820
using execve and need to duplicate the environment from this
967
/* If this plugin has any environment variables, we need to
968
duplicate the environment from this process, too. */
822
969
if(p->environ[0] != NULL){
823
970
for(char **e = environ; *e != NULL; e++){
824
971
if(not add_environment(p, *e, false)){
825
perror("add_environment");
972
error(0, errno, "add_environment");
978
ret = (int)TEMP_FAILURE_RETRY(pipe(pipefd));
834
exitstatus = EXIT_FAILURE;
980
error(0, errno, "pipe");
981
exitstatus = EX_OSERR;
984
if(pipefd[0] >= FD_SETSIZE){
985
fprintf(stderr, "pipe()[0] (%d) >= FD_SETSIZE (%d)", pipefd[0],
987
TEMP_FAILURE_RETRY(close(pipefd[0]));
988
TEMP_FAILURE_RETRY(close(pipefd[1]));
989
exitstatus = EX_OSERR;
837
992
/* Ask OS to automatic close the pipe on exec */
838
993
ret = set_cloexec_flag(pipefd[0]);
840
perror("set_cloexec_flag");
841
exitstatus = EXIT_FAILURE;
995
error(0, errno, "set_cloexec_flag");
996
TEMP_FAILURE_RETRY(close(pipefd[0]));
997
TEMP_FAILURE_RETRY(close(pipefd[1]));
998
exitstatus = EX_OSERR;
844
1001
ret = set_cloexec_flag(pipefd[1]);
846
perror("set_cloexec_flag");
847
exitstatus = EXIT_FAILURE;
1003
error(0, errno, "set_cloexec_flag");
1004
TEMP_FAILURE_RETRY(close(pipefd[0]));
1005
TEMP_FAILURE_RETRY(close(pipefd[1]));
1006
exitstatus = EX_OSERR;
850
1009
/* Block SIGCHLD until process is safely in process list */
851
ret = sigprocmask(SIG_BLOCK, &sigchld_action.sa_mask, NULL);
1010
ret = (int)TEMP_FAILURE_RETRY(sigprocmask(SIG_BLOCK,
1011
&sigchld_action.sa_mask,
853
perror("sigprocmask");
854
exitstatus = EXIT_FAILURE;
1014
error(0, errno, "sigprocmask");
1015
exitstatus = EX_OSERR;
857
1018
/* Starting a new process to be watched */
1022
} while(pid == -1 and errno == EINTR);
861
exitstatus = EXIT_FAILURE;
1024
error(0, errno, "fork");
1025
TEMP_FAILURE_RETRY(sigprocmask(SIG_UNBLOCK,
1026
&sigchld_action.sa_mask, NULL));
1027
TEMP_FAILURE_RETRY(close(pipefd[0]));
1028
TEMP_FAILURE_RETRY(close(pipefd[1]));
1029
exitstatus = EX_OSERR;
865
1033
/* this is the child process */
866
1034
ret = sigaction(SIGCHLD, &old_sigchld_action, NULL);
1036
error(0, errno, "sigaction");
871
1039
ret = sigprocmask(SIG_UNBLOCK, &sigchld_action.sa_mask, NULL);
873
perror("sigprocmask");
1041
error(0, errno, "sigprocmask");
877
1045
ret = dup2(pipefd[1], STDOUT_FILENO); /* replace our stdout */
1047
error(0, errno, "dup2");
883
1051
if(dirfd(dir) < 0){
885
1053
above and must now close it manually here. */
888
if(p->environ[0] == NULL){
889
if(execv(filename, p->argv) < 0){
894
if(execve(filename, p->argv, p->environ) < 0){
1056
if(fexecve(plugin_fd, p->argv,
1057
(p->environ[0] != NULL) ? p->environ : environ) < 0){
1058
error(0, errno, "fexecve for %s/%s",
1059
plugindir != NULL ? plugindir : PDIR, dirst->d_name);
901
1064
/* Parent process */
902
close(pipefd[1]); /* Close unused write end of pipe */
1065
TEMP_FAILURE_RETRY(close(pipefd[1])); /* Close unused write end of
1067
TEMP_FAILURE_RETRY(close(plugin_fd));
904
1068
plugin *new_plugin = getplugin(dirst->d_name);
905
1069
if(new_plugin == NULL){
907
ret = sigprocmask(SIG_UNBLOCK, &sigchld_action.sa_mask, NULL);
1070
error(0, errno, "getplugin");
1071
ret = (int)(TEMP_FAILURE_RETRY
1072
(sigprocmask(SIG_UNBLOCK, &sigchld_action.sa_mask,
909
perror("sigprocmask");
1075
error(0, errno, "sigprocmask");
911
exitstatus = EXIT_FAILURE;
1077
exitstatus = EX_OSERR;
918
1084
/* Unblock SIGCHLD so signal handler can be run if this process
919
1085
has already completed */
920
ret = sigprocmask(SIG_UNBLOCK, &sigchld_action.sa_mask, NULL);
1086
ret = (int)TEMP_FAILURE_RETRY(sigprocmask(SIG_UNBLOCK,
1087
&sigchld_action.sa_mask,
922
perror("sigprocmask");
923
exitstatus = EXIT_FAILURE;
1090
error(0, errno, "sigprocmask");
1091
exitstatus = EX_OSERR;
927
FD_SET(new_plugin->fd, &rfds_all);
1095
#if defined (__GNUC__) and defined (__GLIBC__)
1096
#if not __GLIBC_PREREQ(2, 16)
1097
#pragma GCC diagnostic push
1098
#pragma GCC diagnostic ignored "-Wsign-conversion"
1101
FD_SET(new_plugin->fd, &rfds_all); /* Spurious warning from
1102
-Wconversion in GNU libc
1104
#if defined (__GNUC__) and defined (__GLIBC__)
1105
#if not __GLIBC_PREREQ(2, 16)
1106
#pragma GCC diagnostic pop
929
1110
if(maxfd < new_plugin->fd){
930
1111
maxfd = new_plugin->fd;
1115
TEMP_FAILURE_RETRY(closedir(dir));
1117
free_plugin(getplugin(NULL));
937
1119
for(plugin *p = plugin_list; p != NULL; p = p->next){
938
1120
if(p->pid != 0){
949
1131
while(plugin_list){
950
1132
fd_set rfds = rfds_all;
951
1133
int select_ret = select(maxfd+1, &rfds, NULL, NULL, NULL);
952
if(select_ret == -1){
954
exitstatus = EXIT_FAILURE;
1134
if(select_ret == -1 and errno != EINTR){
1135
error(0, errno, "select");
1136
exitstatus = EX_OSERR;
957
1139
/* OK, now either a process completed, or something can be read
958
1140
from one of them */
959
1141
for(plugin *proc = plugin_list; proc != NULL;){
960
1142
/* Is this process completely done? */
961
if(proc->eof and proc->completed){
1143
if(proc->completed and proc->eof){
962
1144
/* Only accept the plugin output if it exited cleanly */
963
1145
if(not WIFEXITED(proc->status)
964
1146
or WEXITSTATUS(proc->status) != 0){
965
1147
/* Bad exit by plugin */
968
1150
if(WIFEXITED(proc->status)){
969
fprintf(stderr, "Plugin %" PRIdMAX " exited with status"
970
" %d\n", (intmax_t) (proc->pid),
1151
fprintf(stderr, "Plugin %s [%" PRIdMAX "] exited with"
1152
" status %d\n", proc->name,
1153
(intmax_t) (proc->pid),
971
1154
WEXITSTATUS(proc->status));
972
} else if(WIFSIGNALED(proc->status)) {
973
fprintf(stderr, "Plugin %" PRIdMAX " killed by signal"
974
" %d\n", (intmax_t) (proc->pid),
975
WTERMSIG(proc->status));
1155
} else if(WIFSIGNALED(proc->status)){
1156
fprintf(stderr, "Plugin %s [%" PRIdMAX "] killed by"
1157
" signal %d: %s\n", proc->name,
1158
(intmax_t) (proc->pid),
1159
WTERMSIG(proc->status),
1160
strsignal(WTERMSIG(proc->status)));
976
1161
} else if(WCOREDUMP(proc->status)){
977
fprintf(stderr, "Plugin %" PRIdMAX " dumped core\n",
978
(intmax_t) (proc->pid));
1162
fprintf(stderr, "Plugin %s [%" PRIdMAX "] dumped"
1163
" core\n", proc->name, (intmax_t) (proc->pid));
982
1167
/* Remove the plugin */
983
FD_CLR(proc->fd, &rfds_all);
1168
#if defined (__GNUC__) and defined (__GLIBC__)
1169
#if not __GLIBC_PREREQ(2, 16)
1170
#pragma GCC diagnostic push
1171
#pragma GCC diagnostic ignored "-Wsign-conversion"
1174
FD_CLR(proc->fd, &rfds_all); /* Spurious warning from
1175
-Wconversion in GNU libc
1177
#if defined (__GNUC__) and defined (__GLIBC__)
1178
#if not __GLIBC_PREREQ(2, 16)
1179
#pragma GCC diagnostic pop
985
1183
/* Block signal while modifying process_list */
986
ret = sigprocmask(SIG_BLOCK, &sigchld_action.sa_mask, NULL);
1184
ret = (int)TEMP_FAILURE_RETRY(sigprocmask
1186
&sigchld_action.sa_mask,
988
perror("sigprocmask");
989
exitstatus = EXIT_FAILURE;
1189
error(0, errno, "sigprocmask");
1190
exitstatus = EX_OSERR;
1015
1217
bool bret = print_out_password(proc->buffer,
1016
1218
proc->buffer_length);
1018
perror("print_out_password");
1019
exitstatus = EXIT_FAILURE;
1220
error(0, errno, "print_out_password");
1221
exitstatus = EX_IOERR;
1024
1226
/* This process has not completed. Does it have any output? */
1025
if(proc->eof or not FD_ISSET(proc->fd, &rfds)){
1227
#if defined (__GNUC__) and defined (__GLIBC__)
1228
#if not __GLIBC_PREREQ(2, 16)
1229
#pragma GCC diagnostic push
1230
#pragma GCC diagnostic ignored "-Wsign-conversion"
1233
if(proc->eof or not FD_ISSET(proc->fd, &rfds)){ /* Spurious
1239
#if defined (__GNUC__) and defined (__GLIBC__)
1240
#if not __GLIBC_PREREQ(2, 16)
1241
#pragma GCC diagnostic pop
1026
1244
/* This process had nothing to say at this time */
1027
1245
proc = proc->next;
1030
1248
/* Before reading, make the process' data buffer large enough */
1031
1249
if(proc->buffer_length + BUFFER_SIZE > proc->buffer_size){
1032
proc->buffer = realloc(proc->buffer, proc->buffer_size
1033
+ (size_t) BUFFER_SIZE);
1034
if(proc->buffer == NULL){
1036
exitstatus = EXIT_FAILURE;
1250
char *new_buffer = realloc(proc->buffer, proc->buffer_size
1251
+ (size_t) BUFFER_SIZE);
1252
if(new_buffer == NULL){
1253
error(0, errno, "malloc");
1254
exitstatus = EX_OSERR;
1257
proc->buffer = new_buffer;
1039
1258
proc->buffer_size += BUFFER_SIZE;
1041
1260
/* Read from the process */
1042
sret = read(proc->fd, proc->buffer + proc->buffer_length,
1261
sret = TEMP_FAILURE_RETRY(read(proc->fd,
1263
+ proc->buffer_length,
1045
1266
/* Read error from this process; ignore the error */
1046
1267
proc = proc->next;