To get this branch, use:
bzr branch
http://bzr.recompile.se/loggerhead/mandos/trunk
« back to all changes in this revision
Viewing changes to plugin-runner.c
- browse files at revision 700
- compare with another revision
- download diff
- download tarball
- view history from revision 700
- Committer: Teddy Hogeborn
- Date: 2014-06-14 02:52:31 UTC
- Revision ID: teddy@recompile.se-20140614025231-xpairrn1olkfgsek
plugin-runner: Do not leak file descriptors on certain errors.
* plugin-runner.c (main): If set_cloexec_flag fails, close pipe FD's.
* plugin-runner.c (main): If set_cloexec_flag fails, close pipe FD's.
- files added:
- DBUS-API
- debian/source
- debian/upstream
- network-hooks.d
- files modified:
- .bzrignore
added
removed
plugin-runner.c
1
/* -*- coding: utf-8 -*- */
1
/* -*- coding: utf-8; mode: c; mode: orgtbl -*- */
2
2
/*
3
3
* Mandos plugin runner - Run Mandos plugins
4
4
*
5
* Copyright © 2008,2009 Teddy Hogeborn
6
* Copyright © 2008,2009 Björn Påhlsson
5
* Copyright © 2008-2014 Teddy Hogeborn
6
* Copyright © 2008-2014 Björn Påhlsson
7
7
*
8
8
* This program is free software: you can redistribute it and/or
9
9
* modify it under the terms of the GNU General Public License as
19
19
* along with this program. If not, see
20
20
* <http://www.gnu.org/licenses/>.
21
21
*
22
* Contact the authors at <mandos@fukt.bsnet.se>.
22
* Contact the authors at <mandos@recompile.se>.
23
23
*/
24
24
25
25
#define _GNU_SOURCE /* TEMP_FAILURE_RETRY(), getline(),
26
asprintf() */
26
O_CLOEXEC */
27
27
#include <stddef.h> /* size_t, NULL */
28
#include <stdlib.h> /* malloc(), exit(), EXIT_FAILURE,
29
EXIT_SUCCESS, realloc() */
28
#include <stdlib.h> /* malloc(), exit(), EXIT_SUCCESS,
29
realloc() */
30
30
#include <stdbool.h> /* bool, true, false */
31
#include <stdio.h> /* perror, fileno(), fprintf(),
32
stderr, STDOUT_FILENO */
33
#include <sys/types.h> /* DIR, opendir(), stat(), struct
31
#include <stdio.h> /* fileno(), fprintf(),
32
stderr, STDOUT_FILENO, fclose() */
33
#include <sys/types.h> /* DIR, fdopendir(), fstat(), struct
34
34
stat, waitpid(), WIFEXITED(),
35
35
WEXITSTATUS(), wait(), pid_t,
36
36
uid_t, gid_t, getuid(), getgid(),
38
38
#include <sys/select.h> /* fd_set, select(), FD_ZERO(),
39
39
FD_SET(), FD_ISSET(), FD_CLR */
40
40
#include <sys/wait.h> /* wait(), waitpid(), WIFEXITED(),
41
WEXITSTATUS() */
42
#include <sys/stat.h> /* struct stat, stat(), S_ISREG() */
41
WEXITSTATUS(), WTERMSIG(),
42
WCOREDUMP() */
43
#include <sys/stat.h> /* struct stat, fstat(), S_ISREG() */
43
44
#include <iso646.h> /* and, or, not */
44
#include <dirent.h> /* DIR, struct dirent, opendir(),
45
#include <dirent.h> /* DIR, struct dirent, fdopendir(),
45
46
readdir(), closedir(), dirfd() */
46
#include <unistd.h> /* struct stat, stat(), S_ISREG(),
47
fcntl(), setuid(), setgid(),
48
F_GETFD, F_SETFD, FD_CLOEXEC,
49
access(), pipe(), fork(), close()
50
dup2(), STDOUT_FILENO, _exit(),
51
execv(), write(), read(),
52
close() */
47
#include <unistd.h> /* fcntl(), F_GETFD, F_SETFD,
48
FD_CLOEXEC, write(), STDOUT_FILENO,
49
struct stat, fstat(), close(),
50
setgid(), setuid(), S_ISREG(),
51
faccessat() pipe(), fork(),
52
_exit(), dup2(), fexecve(), read()
53
*/
53
54
#include <fcntl.h> /* fcntl(), F_GETFD, F_SETFD,
54
FD_CLOEXEC */
55
#include <string.h> /* strsep, strlen(), asprintf() */
55
FD_CLOEXEC, openat() */
56
#include <string.h> /* strsep, strlen(), strsignal(),
57
strcmp(), strncmp() */
56
58
#include <errno.h> /* errno */
57
59
#include <argp.h> /* struct argp_option, struct
58
60
argp_state, struct argp,
66
68
*/
67
69
#include <errno.h> /* errno, EBADF */
68
70
#include <inttypes.h> /* intmax_t, PRIdMAX, strtoimax() */
71
#include <sysexits.h> /* EX_OSERR, EX_USAGE, EX_IOERR,
72
EX_CONFIG, EX_UNAVAILABLE, EX_OK */
73
#include <errno.h> /* errno */
74
#include <error.h> /* error() */
75
#include <fnmatch.h> /* fnmatch() */
69
76
70
77
#define BUFFER_SIZE 256
71
78
73
80
#define AFILE "/conf/conf.d/mandos/plugin-runner.conf"
74
81
75
82
const char *argp_program_version = "plugin-runner " VERSION;
76
const char *argp_program_bug_address = "<mandos@fukt.bsnet.se>";
83
const char *argp_program_bug_address = "<mandos@recompile.se>";
77
84
78
85
typedef struct plugin{
79
86
char *name; /* can be NULL or any plugin name */
99
106
100
107
/* Gets an existing plugin based on name,
101
108
or if none is found, creates a new one */
109
__attribute__((warn_unused_result))
102
110
static plugin *getplugin(char *name){
103
/* Check for exiting plugin with that name */
111
/* Check for existing plugin with that name */
104
112
for(plugin *p = plugin_list; p != NULL; p = p->next){
105
113
if((p->name == name)
106
114
or (p->name and name and (strcmp(p->name, name) == 0))){
108
116
}
109
117
}
110
118
/* Create a new plugin */
111
plugin *new_plugin = malloc(sizeof(plugin));
119
plugin *new_plugin = NULL;
120
do {
121
new_plugin = malloc(sizeof(plugin));
122
} while(new_plugin == NULL and errno == EINTR);
112
123
if(new_plugin == NULL){
113
124
return NULL;
114
125
}
115
126
char *copy_name = NULL;
116
127
if(name != NULL){
117
copy_name = strdup(name);
128
do {
129
copy_name = strdup(name);
130
} while(copy_name == NULL and errno == EINTR);
118
131
if(copy_name == NULL){
132
int e = errno;
119
133
free(new_plugin);
134
errno = e;
120
135
return NULL;
121
136
}
122
137
}
126
141
.disabled = false,
127
142
.next = plugin_list };
128
143
129
new_plugin->argv = malloc(sizeof(char *) * 2);
144
do {
145
new_plugin->argv = malloc(sizeof(char *) * 2);
146
} while(new_plugin->argv == NULL and errno == EINTR);
130
147
if(new_plugin->argv == NULL){
148
int e = errno;
131
149
free(copy_name);
132
150
free(new_plugin);
151
errno = e;
133
152
return NULL;
134
153
}
135
154
new_plugin->argv[0] = copy_name;
136
155
new_plugin->argv[1] = NULL;
137
156
138
new_plugin->environ = malloc(sizeof(char *));
157
do {
158
new_plugin->environ = malloc(sizeof(char *));
159
} while(new_plugin->environ == NULL and errno == EINTR);
139
160
if(new_plugin->environ == NULL){
161
int e = errno;
140
162
free(copy_name);
141
163
free(new_plugin->argv);
142
164
free(new_plugin);
165
errno = e;
143
166
return NULL;
144
167
}
145
168
new_plugin->environ[0] = NULL;
150
173
}
151
174
152
175
/* Helper function for add_argument and add_environment */
176
__attribute__((nonnull, warn_unused_result))
153
177
static bool add_to_char_array(const char *new, char ***array,
154
178
int *len){
155
179
/* Resize the pointed-to array to hold one more pointer */
156
*array = realloc(*array, sizeof(char *)
157
* (size_t) ((*len) + 2));
180
char **new_array = NULL;
181
do {
182
new_array = realloc(*array, sizeof(char *)
183
* (size_t) ((*len) + 2));
184
} while(new_array == NULL and errno == EINTR);
158
185
/* Malloc check */
159
if(*array == NULL){
186
if(new_array == NULL){
160
187
return false;
161
188
}
189
*array = new_array;
162
190
/* Make a copy of the new string */
163
char *copy = strdup(new);
191
char *copy;
192
do {
193
copy = strdup(new);
194
} while(copy == NULL and errno == EINTR);
164
195
if(copy == NULL){
165
196
return false;
166
197
}
173
204
}
174
205
175
206
/* Add to a plugin's argument vector */
207
__attribute__((nonnull(2), warn_unused_result))
176
208
static bool add_argument(plugin *p, const char *arg){
177
209
if(p == NULL){
178
210
return false;
181
213
}
182
214
183
215
/* Add to a plugin's environment */
216
__attribute__((nonnull(2), warn_unused_result))
184
217
static bool add_environment(plugin *p, const char *def, bool replace){
185
218
if(p == NULL){
186
219
return false;
188
221
/* namelen = length of name of environment variable */
189
222
size_t namelen = (size_t)(strchrnul(def, '=') - def);
190
223
/* Search for this environment variable */
191
for(char **e = p->environ; *e != NULL; e++){
192
if(strncmp(*e, def, namelen + 1) == 0){
224
for(char **envdef = p->environ; *envdef != NULL; envdef++){
225
if(strncmp(*envdef, def, namelen + 1) == 0){
193
226
/* It already exists */
194
227
if(replace){
195
char *new = realloc(*e, strlen(def) + 1);
196
if(new == NULL){
228
char *new_envdef;
229
do {
230
new_envdef = realloc(*envdef, strlen(def) + 1);
231
} while(new_envdef == NULL and errno == EINTR);
232
if(new_envdef == NULL){
197
233
return false;
198
234
}
199
*e = new;
200
strcpy(*e, def);
235
*envdef = new_envdef;
236
strcpy(*envdef, def);
201
237
}
202
238
return true;
203
239
}
208
244
/*
209
245
* Based on the example in the GNU LibC manual chapter 13.13 "File
210
246
* Descriptor Flags".
211
* *Note File Descriptor Flags:(libc)Descriptor Flags.
247
| [[info:libc:Descriptor%20Flags][File Descriptor Flags]] |
212
248
*/
249
__attribute__((warn_unused_result))
213
250
static int set_cloexec_flag(int fd){
214
int ret = fcntl(fd, F_GETFD, 0);
251
int ret = (int)TEMP_FAILURE_RETRY(fcntl(fd, F_GETFD, 0));
215
252
/* If reading the flags failed, return error indication now. */
216
253
if(ret < 0){
217
254
return ret;
218
255
}
219
256
/* Store modified flag word in the descriptor. */
220
return fcntl(fd, F_SETFD, ret | FD_CLOEXEC);
257
return (int)TEMP_FAILURE_RETRY(fcntl(fd, F_SETFD,
258
ret | FD_CLOEXEC));
221
259
}
222
260
223
261
238
276
/* No child processes */
239
277
break;
240
278
}
241
perror("waitpid");
279
error(0, errno, "waitpid");
242
280
}
243
281
244
282
/* A child exited, find it in process_list */
256
294
}
257
295
258
296
/* Prints out a password to stdout */
297
__attribute__((nonnull, warn_unused_result))
259
298
static bool print_out_password(const char *buffer, size_t length){
260
299
ssize_t ret;
261
300
for(size_t written = 0; written < length; written += (size_t)ret){
269
308
}
270
309
271
310
/* Removes and free a plugin from the plugin list */
311
__attribute__((nonnull))
272
312
static void free_plugin(plugin *plugin_node){
273
313
274
314
for(char **arg = plugin_node->argv; *arg != NULL; arg++){
308
348
char *plugindir = NULL;
309
349
char *argfile = NULL;
310
350
FILE *conffp;
311
size_t d_name_len;
312
351
DIR *dir = NULL;
313
352
struct dirent *dirst;
314
353
struct stat st;
315
354
fd_set rfds_all;
316
355
int ret, maxfd = 0;
317
356
ssize_t sret;
318
intmax_t tmpmax;
319
357
uid_t uid = 65534;
320
358
gid_t gid = 65534;
321
359
bool debug = false;
325
363
.sa_flags = SA_NOCLDSTOP };
326
364
char **custom_argv = NULL;
327
365
int custom_argc = 0;
366
int dir_fd;
328
367
329
368
/* Establish a signal handler */
330
369
sigemptyset(&sigchld_action.sa_mask);
331
370
ret = sigaddset(&sigchld_action.sa_mask, SIGCHLD);
332
371
if(ret == -1){
333
perror("sigaddset");
334
exitstatus = EXIT_FAILURE;
372
error(0, errno, "sigaddset");
373
exitstatus = EX_OSERR;
335
374
goto fallback;
336
375
}
337
376
ret = sigaction(SIGCHLD, &sigchld_action, &old_sigchld_action);
338
377
if(ret == -1){
339
perror("sigaction");
340
exitstatus = EXIT_FAILURE;
378
error(0, errno, "sigaction");
379
exitstatus = EX_OSERR;
341
380
goto fallback;
342
381
}
343
382
375
414
.doc = "Group ID the plugins will run as", .group = 3 },
376
415
{ .name = "debug", .key = 132,
377
416
.doc = "Debug mode", .group = 4 },
417
/*
418
* These reproduce what we would get without ARGP_NO_HELP
419
*/
420
{ .name = "help", .key = '?',
421
.doc = "Give this help list", .group = -1 },
422
{ .name = "usage", .key = -3,
423
.doc = "Give a short usage message", .group = -1 },
424
{ .name = "version", .key = 'V',
425
.doc = "Print program version", .group = -1 },
378
426
{ .name = NULL }
379
427
};
380
428
381
error_t parse_opt(int key, char *arg, __attribute__((unused))
382
struct argp_state *state){
383
char *tmp;
429
__attribute__((nonnull(3)))
430
error_t parse_opt(int key, char *arg, struct argp_state *state){
431
errno = 0;
384
432
switch(key){
433
char *tmp;
434
intmax_t tmp_id;
385
435
case 'g': /* --global-options */
386
if(arg != NULL){
436
{
387
437
char *plugin_option;
388
438
while((plugin_option = strsep(&arg, ",")) != NULL){
389
if(plugin_option[0] == '\0'){
390
continue;
391
}
392
439
if(not add_argument(getplugin(NULL), plugin_option)){
393
perror("add_argument");
394
return ARGP_ERR_UNKNOWN;
440
break;
395
441
}
396
442
}
443
errno = 0;
397
444
}
398
445
break;
399
446
case 'G': /* --global-env */
400
if(arg == NULL){
401
break;
402
}
403
if(not add_environment(getplugin(NULL), arg, true)){
404
perror("add_environment");
447
if(add_environment(getplugin(NULL), arg, true)){
448
errno = 0;
405
449
}
406
450
break;
407
451
case 'o': /* --options-for */
408
if(arg != NULL){
409
char *plugin_name = strsep(&arg, ":");
410
if(plugin_name[0] == '\0'){
411
break;
412
}
413
char *plugin_option;
414
while((plugin_option = strsep(&arg, ",")) != NULL){
415
if(not add_argument(getplugin(plugin_name), plugin_option)){
416
perror("add_argument");
417
return ARGP_ERR_UNKNOWN;
452
{
453
char *option_list = strchr(arg, ':');
454
if(option_list == NULL){
455
argp_error(state, "No colon in \"%s\"", arg);
456
errno = EINVAL;
457
break;
458
}
459
*option_list = '\0';
460
option_list++;
461
if(arg[0] == '\0'){
462
argp_error(state, "Empty plugin name");
463
errno = EINVAL;
464
break;
465
}
466
char *option;
467
while((option = strsep(&option_list, ",")) != NULL){
468
if(not add_argument(getplugin(arg), option)){
469
break;
418
470
}
419
471
}
472
errno = 0;
420
473
}
421
474
break;
422
475
case 'E': /* --env-for */
423
if(arg == NULL){
424
break;
425
}
426
476
{
427
477
char *envdef = strchr(arg, ':');
428
478
if(envdef == NULL){
479
argp_error(state, "No colon in \"%s\"", arg);
480
errno = EINVAL;
429
481
break;
430
482
}
431
483
*envdef = '\0';
432
if(not add_environment(getplugin(arg), envdef+1, true)){
433
perror("add_environment");
484
envdef++;
485
if(arg[0] == '\0'){
486
argp_error(state, "Empty plugin name");
487
errno = EINVAL;
488
break;
489
}
490
if(add_environment(getplugin(arg), envdef, true)){
491
errno = 0;
434
492
}
435
493
}
436
494
break;
437
495
case 'd': /* --disable */
438
if(arg != NULL){
496
{
439
497
plugin *p = getplugin(arg);
440
if(p == NULL){
441
return ARGP_ERR_UNKNOWN;
498
if(p != NULL){
499
p->disabled = true;
500
errno = 0;
442
501
}
443
p->disabled = true;
444
502
}
445
503
break;
446
504
case 'e': /* --enable */
447
if(arg != NULL){
505
{
448
506
plugin *p = getplugin(arg);
449
if(p == NULL){
450
return ARGP_ERR_UNKNOWN;
507
if(p != NULL){
508
p->disabled = false;
509
errno = 0;
451
510
}
452
p->disabled = false;
453
511
}
454
512
break;
455
513
case 128: /* --plugin-dir */
456
514
free(plugindir);
457
515
plugindir = strdup(arg);
458
if(plugindir == NULL){
459
perror("strdup");
460
}
516
if(plugindir != NULL){
517
errno = 0;
518
}
461
519
break;
462
520
case 129: /* --config-file */
463
521
/* This is already done by parse_opt_config_file() */
464
522
break;
465
523
case 130: /* --userid */
466
errno = 0;
467
tmpmax = strtoimax(arg, &tmp, 10);
524
tmp_id = strtoimax(arg, &tmp, 10);
468
525
if(errno != 0 or tmp == arg or *tmp != '\0'
469
or tmpmax != (uid_t)tmpmax){
470
fprintf(stderr, "Bad user ID number: \"%s\", using %"
471
PRIdMAX "\n", arg, (intmax_t)uid);
472
} else {
473
uid = (uid_t)tmpmax;
526
or tmp_id != (uid_t)tmp_id){
527
argp_error(state, "Bad user ID number: \"%s\", using %"
528
PRIdMAX, arg, (intmax_t)uid);
529
break;
474
530
}
531
uid = (uid_t)tmp_id;
532
errno = 0;
475
533
break;
476
534
case 131: /* --groupid */
477
errno = 0;
478
tmpmax = strtoimax(arg, &tmp, 10);
535
tmp_id = strtoimax(arg, &tmp, 10);
479
536
if(errno != 0 or tmp == arg or *tmp != '\0'
480
or tmpmax != (gid_t)tmpmax){
481
fprintf(stderr, "Bad group ID number: \"%s\", using %"
482
PRIdMAX "\n", arg, (intmax_t)gid);
483
} else {
484
gid = (gid_t)tmpmax;
537
or tmp_id != (gid_t)tmp_id){
538
argp_error(state, "Bad group ID number: \"%s\", using %"
539
PRIdMAX, arg, (intmax_t)gid);
540
break;
485
541
}
542
gid = (gid_t)tmp_id;
543
errno = 0;
486
544
break;
487
545
case 132: /* --debug */
488
546
debug = true;
489
547
break;
548
/*
549
* These reproduce what we would get without ARGP_NO_HELP
550
*/
551
case '?': /* --help */
552
state->flags &= ~(unsigned int)ARGP_NO_EXIT; /* force exit */
553
argp_state_help(state, state->out_stream, ARGP_HELP_STD_HELP);
554
case -3: /* --usage */
555
state->flags &= ~(unsigned int)ARGP_NO_EXIT; /* force exit */
556
argp_state_help(state, state->out_stream,
557
ARGP_HELP_USAGE | ARGP_HELP_EXIT_OK);
558
case 'V': /* --version */
559
fprintf(state->out_stream, "%s\n", argp_program_version);
560
exit(EXIT_SUCCESS);
561
break;
490
562
/*
491
563
* When adding more options before this line, remember to also add a
492
564
* "case" to the "parse_opt_config_file" function below.
495
567
/* Cryptsetup always passes an argument, which is an empty
496
568
string if "none" was specified in /etc/crypttab. So if
497
569
argument was empty, we ignore it silently. */
498
if(arg[0] != '\0'){
499
fprintf(stderr, "Ignoring unknown argument \"%s\"\n", arg);
570
if(arg[0] == '\0'){
571
break;
500
572
}
501
break;
502
case ARGP_KEY_END:
503
break;
504
573
default:
505
574
return ARGP_ERR_UNKNOWN;
506
575
}
507
return 0;
576
return errno; /* Set to 0 at start */
508
577
}
509
578
510
579
/* This option parser is the same as parse_opt() above, except it
512
581
error_t parse_opt_config_file(int key, char *arg,
513
582
__attribute__((unused))
514
583
struct argp_state *state){
584
errno = 0;
515
585
switch(key){
516
586
case 'g': /* --global-options */
517
587
case 'G': /* --global-env */
524
594
case 129: /* --config-file */
525
595
free(argfile);
526
596
argfile = strdup(arg);
527
if(argfile == NULL){
528
perror("strdup");
597
if(argfile != NULL){
598
errno = 0;
529
599
}
530
break;
600
break;
531
601
case 130: /* --userid */
532
602
case 131: /* --groupid */
533
603
case 132: /* --debug */
604
case '?': /* --help */
605
case -3: /* --usage */
606
case 'V': /* --version */
534
607
case ARGP_KEY_ARG:
535
case ARGP_KEY_END:
536
608
break;
537
609
default:
538
610
return ARGP_ERR_UNKNOWN;
539
611
}
540
return 0;
612
return errno;
541
613
}
542
614
543
615
struct argp argp = { .options = options,
547
619
548
620
/* Parse using parse_opt_config_file() in order to get the custom
549
621
config file location, if any. */
550
ret = argp_parse(&argp, argc, argv, ARGP_IN_ORDER, 0, NULL);
551
if(ret == ARGP_ERR_UNKNOWN){
552
fprintf(stderr, "Unknown error while parsing arguments\n");
553
exitstatus = EXIT_FAILURE;
622
ret = argp_parse(&argp, argc, argv,
623
ARGP_IN_ORDER | ARGP_NO_EXIT | ARGP_NO_HELP,
624
NULL, NULL);
625
switch(ret){
626
case 0:
627
break;
628
case ENOMEM:
629
default:
630
errno = ret;
631
error(0, errno, "argp_parse");
632
exitstatus = EX_OSERR;
633
goto fallback;
634
case EINVAL:
635
exitstatus = EX_USAGE;
554
636
goto fallback;
555
637
}
556
638
562
644
conffp = fopen(AFILE, "r");
563
645
} else {
564
646
conffp = fopen(argfile, "r");
565
}
647
}
566
648
if(conffp != NULL){
567
649
char *org_line = NULL;
568
650
char *p, *arg, *new_arg, *line;
573
655
custom_argc = 1;
574
656
custom_argv = malloc(sizeof(char*) * 2);
575
657
if(custom_argv == NULL){
576
perror("malloc");
577
exitstatus = EXIT_FAILURE;
658
error(0, errno, "malloc");
659
exitstatus = EX_OSERR;
578
660
goto fallback;
579
661
}
580
662
custom_argv[0] = argv[0];
596
678
}
597
679
new_arg = strdup(p);
598
680
if(new_arg == NULL){
599
perror("strdup");
600
exitstatus = EXIT_FAILURE;
681
error(0, errno, "strdup");
682
exitstatus = EX_OSERR;
601
683
free(org_line);
602
684
goto fallback;
603
685
}
604
686
605
687
custom_argc += 1;
606
custom_argv = realloc(custom_argv, sizeof(char *)
607
* ((unsigned int) custom_argc + 1));
608
if(custom_argv == NULL){
609
perror("realloc");
610
exitstatus = EXIT_FAILURE;
611
free(org_line);
612
goto fallback;
688
{
689
char **new_argv = realloc(custom_argv, sizeof(char *)
690
* ((unsigned int)
691
custom_argc + 1));
692
if(new_argv == NULL){
693
error(0, errno, "realloc");
694
exitstatus = EX_OSERR;
695
free(new_arg);
696
free(org_line);
697
goto fallback;
698
} else {
699
custom_argv = new_argv;
700
}
613
701
}
614
702
custom_argv[custom_argc-1] = new_arg;
615
custom_argv[custom_argc] = NULL;
703
custom_argv[custom_argc] = NULL;
616
704
}
617
705
}
706
do {
707
ret = fclose(conffp);
708
} while(ret == EOF and errno == EINTR);
709
if(ret == EOF){
710
error(0, errno, "fclose");
711
exitstatus = EX_IOERR;
712
goto fallback;
713
}
618
714
free(org_line);
619
715
} else {
620
716
/* Check for harmful errors and go to fallback. Other errors might
621
717
not affect opening plugins */
622
718
if(errno == EMFILE or errno == ENFILE or errno == ENOMEM){
623
perror("fopen");
624
exitstatus = EXIT_FAILURE;
719
error(0, errno, "fopen");
720
exitstatus = EX_OSERR;
625
721
goto fallback;
626
722
}
627
723
}
628
/* If there was any arguments from configuration file,
629
pass them to parser as command arguments */
724
/* If there were any arguments from the configuration file, pass
725
them to parser as command line arguments */
630
726
if(custom_argv != NULL){
631
ret = argp_parse(&argp, custom_argc, custom_argv, ARGP_IN_ORDER,
632
0, NULL);
633
if(ret == ARGP_ERR_UNKNOWN){
634
fprintf(stderr, "Unknown error while parsing arguments\n");
635
exitstatus = EXIT_FAILURE;
727
ret = argp_parse(&argp, custom_argc, custom_argv,
728
ARGP_IN_ORDER | ARGP_NO_EXIT | ARGP_NO_HELP,
729
NULL, NULL);
730
switch(ret){
731
case 0:
732
break;
733
case ENOMEM:
734
default:
735
errno = ret;
736
error(0, errno, "argp_parse");
737
exitstatus = EX_OSERR;
738
goto fallback;
739
case EINVAL:
740
exitstatus = EX_CONFIG;
636
741
goto fallback;
637
742
}
638
743
}
639
744
640
745
/* Parse actual command line arguments, to let them override the
641
746
config file */
642
ret = argp_parse(&argp, argc, argv, ARGP_IN_ORDER, 0, NULL);
643
if(ret == ARGP_ERR_UNKNOWN){
644
fprintf(stderr, "Unknown error while parsing arguments\n");
645
exitstatus = EXIT_FAILURE;
747
ret = argp_parse(&argp, argc, argv,
748
ARGP_IN_ORDER | ARGP_NO_EXIT | ARGP_NO_HELP,
749
NULL, NULL);
750
switch(ret){
751
case 0:
752
break;
753
case ENOMEM:
754
default:
755
errno = ret;
756
error(0, errno, "argp_parse");
757
exitstatus = EX_OSERR;
758
goto fallback;
759
case EINVAL:
760
exitstatus = EX_USAGE;
646
761
goto fallback;
647
762
}
648
763
660
775
}
661
776
}
662
777
663
/* Strip permissions down to nobody */
664
setgid(gid);
778
if(getuid() == 0){
779
/* Work around Debian bug #633582:
780
<http://bugs.debian.org/633582> */
781
int plugindir_fd = open(/* plugindir or */ PDIR, O_RDONLY);
782
if(plugindir_fd == -1){
783
if(errno != ENOENT){
784
error(0, errno, "open(\"" PDIR "\")");
785
}
786
} else {
787
ret = (int)TEMP_FAILURE_RETRY(fstat(plugindir_fd, &st));
788
if(ret == -1){
789
error(0, errno, "fstat");
790
} else {
791
if(S_ISDIR(st.st_mode) and st.st_uid == 0 and st.st_gid == 0){
792
ret = fchown(plugindir_fd, uid, gid);
793
if(ret == -1){
794
error(0, errno, "fchown");
795
}
796
}
797
}
798
TEMP_FAILURE_RETRY(close(plugindir_fd));
799
}
800
}
801
802
/* Lower permissions */
803
ret = setgid(gid);
665
804
if(ret == -1){
666
perror("setgid");
805
error(0, errno, "setgid");
667
806
}
668
807
ret = setuid(uid);
669
808
if(ret == -1){
670
perror("setuid");
671
}
672
673
if(plugindir == NULL){
674
dir = opendir(PDIR);
675
} else {
676
dir = opendir(plugindir);
677
}
678
679
if(dir == NULL){
680
perror("Could not open plugin dir");
681
exitstatus = EXIT_FAILURE;
682
goto fallback;
683
}
684
685
/* Set the FD_CLOEXEC flag on the directory, if possible */
809
error(0, errno, "setuid");
810
}
811
812
/* Open plugin directory with close_on_exec flag */
686
813
{
687
int dir_fd = dirfd(dir);
688
if(dir_fd >= 0){
689
ret = set_cloexec_flag(dir_fd);
690
if(ret < 0){
691
perror("set_cloexec_flag");
692
exitstatus = EXIT_FAILURE;
693
goto fallback;
694
}
814
dir_fd = open(plugindir != NULL ? plugindir : PDIR, O_RDONLY |
815
#ifdef O_CLOEXEC
816
O_CLOEXEC
817
#else /* not O_CLOEXEC */
818
0
819
#endif /* not O_CLOEXEC */
820
);
821
if(dir_fd == -1){
822
error(0, errno, "Could not open plugin dir");
823
exitstatus = EX_UNAVAILABLE;
824
goto fallback;
825
}
826
827
#ifndef O_CLOEXEC
828
/* Set the FD_CLOEXEC flag on the directory */
829
ret = set_cloexec_flag(dir_fd);
830
if(ret < 0){
831
error(0, errno, "set_cloexec_flag");
832
TEMP_FAILURE_RETRY(close(dir_fd));
833
exitstatus = EX_OSERR;
834
goto fallback;
835
}
836
#endif /* O_CLOEXEC */
837
838
dir = fdopendir(dir_fd);
839
if(dir == NULL){
840
error(0, errno, "Could not open plugin dir");
841
TEMP_FAILURE_RETRY(close(dir_fd));
842
exitstatus = EX_OSERR;
843
goto fallback;
695
844
}
696
845
}
697
846
699
848
700
849
/* Read and execute any executable in the plugin directory*/
701
850
while(true){
702
dirst = readdir(dir);
851
do {
852
dirst = readdir(dir);
853
} while(dirst == NULL and errno == EINTR);
703
854
704
855
/* All directory entries have been processed */
705
856
if(dirst == NULL){
706
857
if(errno == EBADF){
707
perror("readdir");
708
exitstatus = EXIT_FAILURE;
858
error(0, errno, "readdir");
859
exitstatus = EX_IOERR;
709
860
goto fallback;
710
861
}
711
862
break;
712
863
}
713
864
714
d_name_len = strlen(dirst->d_name);
715
716
865
/* Ignore dotfiles, backup files and other junk */
717
866
{
718
867
bool bad_name = false;
719
720
const char const *bad_prefixes[] = { ".", "#", NULL };
721
722
const char const *bad_suffixes[] = { "~", "#", ".dpkg-new",
723
".dpkg-old",
724
".dpkg-bak",
725
".dpkg-divert", NULL };
726
for(const char **pre = bad_prefixes; *pre != NULL; pre++){
727
size_t pre_len = strlen(*pre);
728
if((d_name_len >= pre_len)
729
and strncmp((dirst->d_name), *pre, pre_len) == 0){
730
if(debug){
731
fprintf(stderr, "Ignoring plugin dir entry \"%s\""
732
" with bad prefix %s\n", dirst->d_name, *pre);
733
}
734
bad_name = true;
735
break;
736
}
737
}
738
if(bad_name){
739
continue;
740
}
741
for(const char **suf = bad_suffixes; *suf != NULL; suf++){
742
size_t suf_len = strlen(*suf);
743
if((d_name_len >= suf_len)
744
and (strcmp((dirst->d_name)+d_name_len-suf_len, *suf)
745
== 0)){
746
if(debug){
747
fprintf(stderr, "Ignoring plugin dir entry \"%s\""
748
" with bad suffix %s\n", dirst->d_name, *suf);
749
}
750
bad_name = true;
751
break;
752
}
753
}
754
868
const char * const patterns[] = { ".*", "#*#", "*~",
869
"*.dpkg-new", "*.dpkg-old",
870
"*.dpkg-bak", "*.dpkg-divert",
871
NULL };
872
#ifdef __GNUC__
873
#pragma GCC diagnostic push
874
#pragma GCC diagnostic ignored "-Wcast-qual"
875
#endif
876
for(const char **pat = (const char **)patterns;
877
*pat != NULL; pat++){
878
#ifdef __GNUC__
879
#pragma GCC diagnostic pop
880
#endif
881
if(fnmatch(*pat, dirst->d_name,
882
FNM_FILE_NAME | FNM_PERIOD) != FNM_NOMATCH){
883
if(debug){
884
fprintf(stderr, "Ignoring plugin dir entry \"%s\""
885
" matching pattern %s\n", dirst->d_name, *pat);
886
}
887
bad_name = true;
888
break;
889
}
890
}
755
891
if(bad_name){
756
892
continue;
757
893
}
758
894
}
759
895
760
char *filename;
761
if(plugindir == NULL){
762
ret = asprintf(&filename, PDIR "/%s", dirst->d_name);
763
} else {
764
ret = asprintf(&filename, "%s/%s", plugindir, dirst->d_name);
896
int plugin_fd = openat(dir_fd, dirst->d_name, O_RDONLY |
897
#ifdef O_CLOEXEC
898
O_CLOEXEC
899
#else /* not O_CLOEXEC */
900
0
901
#endif /* not O_CLOEXEC */
902
);
903
if(plugin_fd == -1){
904
error(0, errno, "Could not open plugin");
905
continue;
765
906
}
907
#ifndef O_CLOEXEC
908
/* Set the FD_CLOEXEC flag on the plugin FD */
909
ret = set_cloexec_flag(plugin_fd);
766
910
if(ret < 0){
767
perror("asprintf");
911
error(0, errno, "set_cloexec_flag");
912
TEMP_FAILURE_RETRY(close(plugin_fd));
768
913
continue;
769
914
}
770
771
ret = stat(filename, &st);
915
#endif /* O_CLOEXEC */
916
ret = (int)TEMP_FAILURE_RETRY(fstat(plugin_fd, &st));
772
917
if(ret == -1){
773
perror("stat");
774
free(filename);
918
error(0, errno, "stat");
919
TEMP_FAILURE_RETRY(close(plugin_fd));
775
920
continue;
776
921
}
777
922
778
923
/* Ignore non-executable files */
779
if(not S_ISREG(st.st_mode) or (access(filename, X_OK) != 0)){
924
if(not S_ISREG(st.st_mode)
925
or (TEMP_FAILURE_RETRY(faccessat(dir_fd, dirst->d_name, X_OK,
926
0)) != 0)){
780
927
if(debug){
781
fprintf(stderr, "Ignoring plugin dir entry \"%s\""
782
" with bad type or mode\n", filename);
928
fprintf(stderr, "Ignoring plugin dir entry \"%s/%s\""
929
" with bad type or mode\n",
930
plugindir != NULL ? plugindir : PDIR, dirst->d_name);
783
931
}
784
free(filename);
932
TEMP_FAILURE_RETRY(close(plugin_fd));
785
933
continue;
786
934
}
787
935
788
936
plugin *p = getplugin(dirst->d_name);
789
937
if(p == NULL){
790
perror("getplugin");
791
free(filename);
938
error(0, errno, "getplugin");
939
TEMP_FAILURE_RETRY(close(plugin_fd));
792
940
continue;
793
941
}
794
942
if(p->disabled){
796
944
fprintf(stderr, "Ignoring disabled plugin \"%s\"\n",
797
945
dirst->d_name);
798
946
}
799
free(filename);
947
TEMP_FAILURE_RETRY(close(plugin_fd));
800
948
continue;
801
949
}
802
950
{
805
953
if(g != NULL){
806
954
for(char **a = g->argv + 1; *a != NULL; a++){
807
955
if(not add_argument(p, *a)){
808
perror("add_argument");
956
error(0, errno, "add_argument");
809
957
}
810
958
}
811
959
/* Add global environment variables */
812
960
for(char **e = g->environ; *e != NULL; e++){
813
961
if(not add_environment(p, *e, false)){
814
perror("add_environment");
962
error(0, errno, "add_environment");
815
963
}
816
964
}
817
965
}
818
966
}
819
/* If this plugin has any environment variables, we will call
820
using execve and need to duplicate the environment from this
821
process, too. */
967
/* If this plugin has any environment variables, we need to
968
duplicate the environment from this process, too. */
822
969
if(p->environ[0] != NULL){
823
970
for(char **e = environ; *e != NULL; e++){
824
971
if(not add_environment(p, *e, false)){
825
perror("add_environment");
972
error(0, errno, "add_environment");
826
973
}
827
974
}
828
975
}
829
976
830
977
int pipefd[2];
831
ret = pipe(pipefd);
978
ret = (int)TEMP_FAILURE_RETRY(pipe(pipefd));
832
979
if(ret == -1){
833
perror("pipe");
834
exitstatus = EXIT_FAILURE;
980
error(0, errno, "pipe");
981
exitstatus = EX_OSERR;
835
982
goto fallback;
836
983
}
837
984
/* Ask OS to automatic close the pipe on exec */
838
985
ret = set_cloexec_flag(pipefd[0]);
839
986
if(ret < 0){
840
perror("set_cloexec_flag");
841
exitstatus = EXIT_FAILURE;
987
error(0, errno, "set_cloexec_flag");
988
TEMP_FAILURE_RETRY(close(pipefd[0]));
989
TEMP_FAILURE_RETRY(close(pipefd[1]));
990
exitstatus = EX_OSERR;
842
991
goto fallback;
843
992
}
844
993
ret = set_cloexec_flag(pipefd[1]);
845
994
if(ret < 0){
846
perror("set_cloexec_flag");
847
exitstatus = EXIT_FAILURE;
995
error(0, errno, "set_cloexec_flag");
996
TEMP_FAILURE_RETRY(close(pipefd[0]));
997
TEMP_FAILURE_RETRY(close(pipefd[1]));
998
exitstatus = EX_OSERR;
848
999
goto fallback;
849
1000
}
850
1001
/* Block SIGCHLD until process is safely in process list */
851
ret = sigprocmask(SIG_BLOCK, &sigchld_action.sa_mask, NULL);
1002
ret = (int)TEMP_FAILURE_RETRY(sigprocmask(SIG_BLOCK,
1003
&sigchld_action.sa_mask,
1004
NULL));
852
1005
if(ret < 0){
853
perror("sigprocmask");
854
exitstatus = EXIT_FAILURE;
1006
error(0, errno, "sigprocmask");
1007
exitstatus = EX_OSERR;
855
1008
goto fallback;
856
1009
}
857
1010
/* Starting a new process to be watched */
858
pid_t pid = fork();
1011
pid_t pid;
1012
do {
1013
pid = fork();
1014
} while(pid == -1 and errno == EINTR);
859
1015
if(pid == -1){
860
perror("fork");
861
exitstatus = EXIT_FAILURE;
1016
error(0, errno, "fork");
1017
exitstatus = EX_OSERR;
862
1018
goto fallback;
863
1019
}
864
1020
if(pid == 0){
865
1021
/* this is the child process */
866
1022
ret = sigaction(SIGCHLD, &old_sigchld_action, NULL);
867
1023
if(ret < 0){
868
perror("sigaction");
869
_exit(EXIT_FAILURE);
1024
error(0, errno, "sigaction");
1025
_exit(EX_OSERR);
870
1026
}
871
1027
ret = sigprocmask(SIG_UNBLOCK, &sigchld_action.sa_mask, NULL);
872
1028
if(ret < 0){
873
perror("sigprocmask");
874
_exit(EXIT_FAILURE);
1029
error(0, errno, "sigprocmask");
1030
_exit(EX_OSERR);
875
1031
}
876
1032
877
1033
ret = dup2(pipefd[1], STDOUT_FILENO); /* replace our stdout */
878
1034
if(ret == -1){
879
perror("dup2");
880
_exit(EXIT_FAILURE);
1035
error(0, errno, "dup2");
1036
_exit(EX_OSERR);
881
1037
}
882
1038
883
1039
if(dirfd(dir) < 0){
885
1041
above and must now close it manually here. */
886
1042
closedir(dir);
887
1043
}
888
if(p->environ[0] == NULL){
889
if(execv(filename, p->argv) < 0){
890
perror("execv");
891
_exit(EXIT_FAILURE);
892
}
893
} else {
894
if(execve(filename, p->argv, p->environ) < 0){
895
perror("execve");
896
_exit(EXIT_FAILURE);
897
}
1044
if(fexecve(plugin_fd, p->argv,
1045
(p->environ[0] != NULL) ? p->environ : environ) < 0){
1046
error(0, errno, "fexecve for %s/%s",
1047
plugindir != NULL ? plugindir : PDIR, dirst->d_name);
1048
_exit(EX_OSERR);
898
1049
}
899
1050
/* no return */
900
1051
}
901
1052
/* Parent process */
902
close(pipefd[1]); /* Close unused write end of pipe */
903
free(filename);
1053
TEMP_FAILURE_RETRY(close(pipefd[1])); /* Close unused write end of
1054
pipe */
1055
TEMP_FAILURE_RETRY(close(plugin_fd));
904
1056
plugin *new_plugin = getplugin(dirst->d_name);
905
1057
if(new_plugin == NULL){
906
perror("getplugin");
907
ret = sigprocmask(SIG_UNBLOCK, &sigchld_action.sa_mask, NULL);
1058
error(0, errno, "getplugin");
1059
ret = (int)(TEMP_FAILURE_RETRY
1060
(sigprocmask(SIG_UNBLOCK, &sigchld_action.sa_mask,
1061
NULL)));
908
1062
if(ret < 0){
909
perror("sigprocmask");
1063
error(0, errno, "sigprocmask");
910
1064
}
911
exitstatus = EXIT_FAILURE;
1065
exitstatus = EX_OSERR;
912
1066
goto fallback;
913
1067
}
914
1068
917
1071
918
1072
/* Unblock SIGCHLD so signal handler can be run if this process
919
1073
has already completed */
920
ret = sigprocmask(SIG_UNBLOCK, &sigchld_action.sa_mask, NULL);
1074
ret = (int)TEMP_FAILURE_RETRY(sigprocmask(SIG_UNBLOCK,
1075
&sigchld_action.sa_mask,
1076
NULL));
921
1077
if(ret < 0){
922
perror("sigprocmask");
923
exitstatus = EXIT_FAILURE;
1078
error(0, errno, "sigprocmask");
1079
exitstatus = EX_OSERR;
924
1080
goto fallback;
925
1081
}
926
1082
927
FD_SET(new_plugin->fd, &rfds_all);
1083
#if defined (__GNUC__) and defined (__GLIBC__)
1084
#if not __GLIBC_PREREQ(2, 16)
1085
#pragma GCC diagnostic push
1086
#pragma GCC diagnostic ignored "-Wsign-conversion"
1087
#endif
1088
#endif
1089
FD_SET(new_plugin->fd, &rfds_all); /* Spurious warning from
1090
-Wconversion in GNU libc
1091
before 2.16 */
1092
#if defined (__GNUC__) and defined (__GLIBC__)
1093
#if not __GLIBC_PREREQ(2, 16)
1094
#pragma GCC diagnostic pop
1095
#endif
1096
#endif
928
1097
929
1098
if(maxfd < new_plugin->fd){
930
1099
maxfd = new_plugin->fd;
931
1100
}
932
1101
}
933
1102
934
closedir(dir);
1103
TEMP_FAILURE_RETRY(closedir(dir));
935
1104
dir = NULL;
936
1105
free_plugin(getplugin(NULL));
937
1106
950
1119
while(plugin_list){
951
1120
fd_set rfds = rfds_all;
952
1121
int select_ret = select(maxfd+1, &rfds, NULL, NULL, NULL);
953
if(select_ret == -1){
954
perror("select");
955
exitstatus = EXIT_FAILURE;
1122
if(select_ret == -1 and errno != EINTR){
1123
error(0, errno, "select");
1124
exitstatus = EX_OSERR;
956
1125
goto fallback;
957
1126
}
958
1127
/* OK, now either a process completed, or something can be read
973
1142
WEXITSTATUS(proc->status));
974
1143
} else if(WIFSIGNALED(proc->status)){
975
1144
fprintf(stderr, "Plugin %s [%" PRIdMAX "] killed by"
976
" signal %d\n", proc->name,
1145
" signal %d: %s\n", proc->name,
977
1146
(intmax_t) (proc->pid),
978
WTERMSIG(proc->status));
1147
WTERMSIG(proc->status),
1148
strsignal(WTERMSIG(proc->status)));
979
1149
} else if(WCOREDUMP(proc->status)){
980
1150
fprintf(stderr, "Plugin %s [%" PRIdMAX "] dumped"
981
1151
" core\n", proc->name, (intmax_t) (proc->pid));
983
1153
}
984
1154
985
1155
/* Remove the plugin */
986
FD_CLR(proc->fd, &rfds_all);
1156
#if defined (__GNUC__) and defined (__GLIBC__)
1157
#if not __GLIBC_PREREQ(2, 16)
1158
#pragma GCC diagnostic push
1159
#pragma GCC diagnostic ignored "-Wsign-conversion"
1160
#endif
1161
#endif
1162
FD_CLR(proc->fd, &rfds_all); /* Spurious warning from
1163
-Wconversion in GNU libc
1164
before 2.16 */
1165
#if defined (__GNUC__) and defined (__GLIBC__)
1166
#if not __GLIBC_PREREQ(2, 16)
1167
#pragma GCC diagnostic pop
1168
#endif
1169
#endif
987
1170
988
1171
/* Block signal while modifying process_list */
989
ret = sigprocmask(SIG_BLOCK, &sigchld_action.sa_mask, NULL);
1172
ret = (int)TEMP_FAILURE_RETRY(sigprocmask
1173
(SIG_BLOCK,
1174
&sigchld_action.sa_mask,
1175
NULL));
990
1176
if(ret < 0){
991
perror("sigprocmask");
992
exitstatus = EXIT_FAILURE;
1177
error(0, errno, "sigprocmask");
1178
exitstatus = EX_OSERR;
993
1179
goto fallback;
994
1180
}
995
1181
998
1184
proc = next_plugin;
999
1185
1000
1186
/* We are done modifying process list, so unblock signal */
1001
ret = sigprocmask(SIG_UNBLOCK, &sigchld_action.sa_mask,
1002
NULL);
1187
ret = (int)(TEMP_FAILURE_RETRY
1188
(sigprocmask(SIG_UNBLOCK,
1189
&sigchld_action.sa_mask, NULL)));
1003
1190
if(ret < 0){
1004
perror("sigprocmask");
1005
exitstatus = EXIT_FAILURE;
1191
error(0, errno, "sigprocmask");
1192
exitstatus = EX_OSERR;
1006
1193
goto fallback;
1007
1194
}
1008
1195
1018
1205
bool bret = print_out_password(proc->buffer,
1019
1206
proc->buffer_length);
1020
1207
if(not bret){
1021
perror("print_out_password");
1022
exitstatus = EXIT_FAILURE;
1208
error(0, errno, "print_out_password");
1209
exitstatus = EX_IOERR;
1023
1210
}
1024
1211
goto fallback;
1025
1212
}
1026
1213
1027
1214
/* This process has not completed. Does it have any output? */
1028
if(proc->eof or not FD_ISSET(proc->fd, &rfds)){
1215
#if defined (__GNUC__) and defined (__GLIBC__)
1216
#if not __GLIBC_PREREQ(2, 16)
1217
#pragma GCC diagnostic push
1218
#pragma GCC diagnostic ignored "-Wsign-conversion"
1219
#endif
1220
#endif
1221
if(proc->eof or not FD_ISSET(proc->fd, &rfds)){ /* Spurious
1222
warning from
1223
-Wconversion
1224
in GNU libc
1225
before
1226
2.16 */
1227
#if defined (__GNUC__) and defined (__GLIBC__)
1228
#if not __GLIBC_PREREQ(2, 16)
1229
#pragma GCC diagnostic pop
1230
#endif
1231
#endif
1029
1232
/* This process had nothing to say at this time */
1030
1233
proc = proc->next;
1031
1234
continue;
1032
1235
}
1033
1236
/* Before reading, make the process' data buffer large enough */
1034
1237
if(proc->buffer_length + BUFFER_SIZE > proc->buffer_size){
1035
proc->buffer = realloc(proc->buffer, proc->buffer_size
1036
+ (size_t) BUFFER_SIZE);
1037
if(proc->buffer == NULL){
1038
perror("malloc");
1039
exitstatus = EXIT_FAILURE;
1238
char *new_buffer = realloc(proc->buffer, proc->buffer_size
1239
+ (size_t) BUFFER_SIZE);
1240
if(new_buffer == NULL){
1241
error(0, errno, "malloc");
1242
exitstatus = EX_OSERR;
1040
1243
goto fallback;
1041
1244
}
1245
proc->buffer = new_buffer;
1042
1246
proc->buffer_size += BUFFER_SIZE;
1043
1247
}
1044
1248
/* Read from the process */
1045
sret = read(proc->fd, proc->buffer + proc->buffer_length,
1046
BUFFER_SIZE);
1249
sret = TEMP_FAILURE_RETRY(read(proc->fd,
1250
proc->buffer
1251
+ proc->buffer_length,
1252
BUFFER_SIZE));
1047
1253
if(sret < 0){
1048
1254
/* Read error from this process; ignore the error */
1049
1255
proc = proc->next;
1061
1267
1062
1268
fallback:
1063
1269
1064
if(plugin_list == NULL or exitstatus != EXIT_SUCCESS){
1270
if(plugin_list == NULL or (exitstatus != EXIT_SUCCESS
1271
and exitstatus != EX_OK)){
1065
1272
/* Fallback if all plugins failed, none are found or an error
1066
1273
occured */
1067
1274
bool bret;
1075
1282
}
1076
1283
bret = print_out_password(passwordbuffer, len);
1077
1284
if(not bret){
1078
perror("print_out_password");
1079
exitstatus = EXIT_FAILURE;
1285
error(0, errno, "print_out_password");
1286
exitstatus = EX_IOERR;
1080
1287
}
1081
1288
}
1082
1289
1083
1290
/* Restore old signal handler */
1084
1291
ret = sigaction(SIGCHLD, &old_sigchld_action, NULL);
1085
1292
if(ret == -1){
1086
perror("sigaction");
1087
exitstatus = EXIT_FAILURE;
1293
error(0, errno, "sigaction");
1294
exitstatus = EX_OSERR;
1088
1295
}
1089
1296
1090
1297
if(custom_argv != NULL){
1105
1312
ret = kill(p->pid, SIGTERM);
1106
1313
if(ret == -1 and errno != ESRCH){
1107
1314
/* Set-uid proccesses might not get closed */
1108
perror("kill");
1315
error(0, errno, "kill");
1109
1316
}
1110
1317
}
1111
1318
}
1112
1319
1113
1320
/* Wait for any remaining child processes to terminate */
1114
do{
1321
do {
1115
1322
ret = wait(NULL);
1116
1323
} while(ret >= 0);
1117
1324
if(errno != ECHILD){
1118
perror("wait");
1325
error(0, errno, "wait");
1119
1326
}
1120
1327
1121
1328
free_plugin_list();
Loggerhead is a web-based interface for Breezy
Version: 2.0.2.dev0