/mandos/trunk

To get this branch, use:
bzr branch http://bzr.recompile.se/loggerhead/mandos/trunk

« back to all changes in this revision

Viewing changes to debian/rules

  • Committer: Teddy Hogeborn
  • Date: 2014-06-08 03:10:08 UTC
  • Revision ID: teddy@recompile.se-20140608031008-mc9bd7b024a3q0y0
Address a very theoretical possible security issue in mandos-client.

If there were to run some sort of "cleaner" process for /run/tmp (or
/tmp), and mandos-client were to run for long enough for that cleaner
process to remove the temporary directory for GPGME, there was a
possibility that another unprivileged process could trick the (also
unprivileged) mandos-client process to remove other files or symlinks
which the unprivileged mandos-client process was allowed to remove.
This is not currently known to have been exploitable, since there are
no known initramfs environments running such cleaner processes.

* plugins.d/mandos-client.c (main): Use O_NOFOLLOW when opening
                                    tempdir for cleaning.

Show diffs side-by-side

added added

removed removed

Lines of Context:
debian/rules
19
19
        $(MAKE) DESTDIR=$(CURDIR)/debian/mandos-client \
20
20
                install-client-nokey
21
21
 
22
 
override_dh_fixperms-arch:
 
22
override_dh_fixperms:
23
23
        dh_fixperms --exclude etc/keys/mandos \
 
24
                --exclude etc/mandos/clients.conf \
24
25
                --exclude etc/mandos/plugins.d \
25
 
                --exclude etc/mandos/plugin-helpers \
26
26
                --exclude usr/lib/$(shell dpkg-architecture -qDEB_HOST_MULTIARCH 2>/dev/null)/mandos/plugins.d \
27
 
                --exclude usr/lib/$(shell dpkg-architecture -qDEB_HOST_MULTIARCH 2>/dev/null)/mandos/plugin-helpers \
28
27
                --exclude usr/share/doc/mandos-client/examples/network-hooks.d
29
28
        chmod --recursive g-w -- \
30
29
        "$(CURDIR)/debian/mandos-client/usr/share/doc/mandos-client/examples/network-hooks.d"
31
30
 
32
 
override_dh_fixperms-indep:
33
 
        dh_fixperms --exclude etc/mandos/clients.conf
34
 
 
35
31
override_dh_auto_test-arch: ;