To get this branch, use:
bzr branch
http://bzr.recompile.se/loggerhead/mandos/trunk
« back to all changes in this revision
Viewing changes to plugin-runner.c
- browse files at revision 672
- compare with another revision
- download diff
- download tarball
- view history from revision 672
- Committer: Teddy Hogeborn
- Date: 2014-03-23 19:24:40 UTC
- Revision ID: teddy@recompile.se-20140323192440-d71iiqxebsxf9u2v
Update GCC warning flags and function attributes to GCC 4.7.
* Makefile (WARN): Update to include almost all warning flags.
* plugin-runner.c (getplugin, add_to_char_array, add_argument,
add_environment, set_cloexec_flag,
print_out_password): Add attribute
"warn_unused_result".
(main/parse_opt): Bug fix: Add error checking to --global-env,
--env-for, --plugin-dir, and --config-file, and
make sure errno does not "leak" from unrelated
functions.
* plugins.d/mandos-client.c
(fprintf_plus, debuggnutls, resolve_callback): Add "nonnull"
attribute.
(incbuffer, add_server, init_gpgme): Add "nonnull" and
"warn_unused_result"
attributes.
(pgp_packet_decrypt, init_gnutls_global): - '' -
(init_gnutls_session start_mandos_communication, get_flags): - '' -
(good_flags, good_interface, interface_is_up): - '' -
(interface_is_running, runnable_hook): - '' -
(avahi_loop_with_timeout, bring_up_interface): : - '' -
(safer_gnutls_strerror): Add "warn_unused_result" attribute.
(notdotentries): Set "nonnull", "pure", and "warn_unused_result"
attributes.
(raise_privileges, raise_privileges_permanently, lower_privileges,
lower_privileges_permanently): Set "warn_unused_result" attribute.
(run_network_hooks): Exit child process if it fails to do anything
it needs to do. Make explicit cast to double
when passing float value to asprintf(). Change
return type to void - all callers changed.
(bring_up_interface): Move variables "sd", "ret_errno", and
"ret_setflags" to innermost scope. Bug fix:
Fail if could not get interface flags also in
non-debug mode, and restore old errno
correctly. Print message if could not raise
(or later lower) privileges.
(take_down_interface): Bug fix: When failing because it could not
get interface flags, restore old errno
correctly. Print message if it could not
raise (or later lower) privileges.
(main): Complain if failed to raise or lower privileges. Only run
network hooks or lower privileges if raising privileges was
successful.
* Makefile (WARN): Update to include almost all warning flags.
* plugin-runner.c (getplugin, add_to_char_array, add_argument,
add_environment, set_cloexec_flag,
print_out_password): Add attribute
"warn_unused_result".
(main/parse_opt): Bug fix: Add error checking to --global-env,
--env-for, --plugin-dir, and --config-file, and
make sure errno does not "leak" from unrelated
functions.
* plugins.d/mandos-client.c
(fprintf_plus, debuggnutls, resolve_callback): Add "nonnull"
attribute.
(incbuffer, add_server, init_gpgme): Add "nonnull" and
"warn_unused_result"
attributes.
(pgp_packet_decrypt, init_gnutls_global): - '' -
(init_gnutls_session start_mandos_communication, get_flags): - '' -
(good_flags, good_interface, interface_is_up): - '' -
(interface_is_running, runnable_hook): - '' -
(avahi_loop_with_timeout, bring_up_interface): : - '' -
(safer_gnutls_strerror): Add "warn_unused_result" attribute.
(notdotentries): Set "nonnull", "pure", and "warn_unused_result"
attributes.
(raise_privileges, raise_privileges_permanently, lower_privileges,
lower_privileges_permanently): Set "warn_unused_result" attribute.
(run_network_hooks): Exit child process if it fails to do anything
it needs to do. Make explicit cast to double
when passing float value to asprintf(). Change
return type to void - all callers changed.
(bring_up_interface): Move variables "sd", "ret_errno", and
"ret_setflags" to innermost scope. Bug fix:
Fail if could not get interface flags also in
non-debug mode, and restore old errno
correctly. Print message if could not raise
(or later lower) privileges.
(take_down_interface): Bug fix: When failing because it could not
get interface flags, restore old errno
correctly. Print message if it could not
raise (or later lower) privileges.
(main): Complain if failed to raise or lower privileges. Only run
network hooks or lower privileges if raising privileges was
successful.
- files added:
- DBUS-API
- debian/source
- network-hooks.d
- files removed:
- debian/mandos-client.config
- files renamed:
- mandos-list => mandos-ctl
- files modified:
- .bzrignore
added
removed
plugin-runner.c
1
/* -*- coding: utf-8 -*- */
1
/* -*- coding: utf-8; mode: c; mode: orgtbl -*- */
2
2
/*
3
3
* Mandos plugin runner - Run Mandos plugins
4
4
*
5
* Copyright © 2008,2009 Teddy Hogeborn
6
* Copyright © 2008,2009 Björn Påhlsson
5
* Copyright © 2008-2013 Teddy Hogeborn
6
* Copyright © 2008-2013 Björn Påhlsson
7
7
*
8
8
* This program is free software: you can redistribute it and/or
9
9
* modify it under the terms of the GNU General Public License as
19
19
* along with this program. If not, see
20
20
* <http://www.gnu.org/licenses/>.
21
21
*
22
* Contact the authors at <mandos@fukt.bsnet.se>.
22
* Contact the authors at <mandos@recompile.se>.
23
23
*/
24
24
25
25
#define _GNU_SOURCE /* TEMP_FAILURE_RETRY(), getline(),
26
asprintf() */
26
asprintf(), O_CLOEXEC */
27
27
#include <stddef.h> /* size_t, NULL */
28
#include <stdlib.h> /* malloc(), exit(), EXIT_FAILURE,
29
EXIT_SUCCESS, realloc() */
28
#include <stdlib.h> /* malloc(), exit(), EXIT_SUCCESS,
29
realloc() */
30
30
#include <stdbool.h> /* bool, true, false */
31
#include <stdio.h> /* perror, fileno(), fprintf(),
31
#include <stdio.h> /* fileno(), fprintf(),
32
32
stderr, STDOUT_FILENO */
33
#include <sys/types.h> /* DIR, opendir(), stat(), struct
33
#include <sys/types.h> /* DIR, fdopendir(), stat(), struct
34
34
stat, waitpid(), WIFEXITED(),
35
35
WEXITSTATUS(), wait(), pid_t,
36
36
uid_t, gid_t, getuid(), getgid(),
38
38
#include <sys/select.h> /* fd_set, select(), FD_ZERO(),
39
39
FD_SET(), FD_ISSET(), FD_CLR */
40
40
#include <sys/wait.h> /* wait(), waitpid(), WIFEXITED(),
41
WEXITSTATUS() */
41
WEXITSTATUS(), WTERMSIG(),
42
WCOREDUMP() */
42
43
#include <sys/stat.h> /* struct stat, stat(), S_ISREG() */
43
44
#include <iso646.h> /* and, or, not */
44
#include <dirent.h> /* DIR, struct dirent, opendir(),
45
#include <dirent.h> /* DIR, struct dirent, fdopendir(),
45
46
readdir(), closedir(), dirfd() */
46
47
#include <unistd.h> /* struct stat, stat(), S_ISREG(),
47
48
fcntl(), setuid(), setgid(),
52
53
close() */
53
54
#include <fcntl.h> /* fcntl(), F_GETFD, F_SETFD,
54
55
FD_CLOEXEC */
55
#include <string.h> /* strsep, strlen(), asprintf() */
56
#include <string.h> /* strsep, strlen(), asprintf(),
57
strsignal(), strcmp(), strncmp() */
56
58
#include <errno.h> /* errno */
57
59
#include <argp.h> /* struct argp_option, struct
58
60
argp_state, struct argp,
62
64
#include <signal.h> /* struct sigaction, sigemptyset(),
63
65
sigaddset(), sigaction(),
64
66
sigprocmask(), SIG_BLOCK, SIGCHLD,
65
SIG_UNBLOCK, kill() */
67
SIG_UNBLOCK, kill(), sig_atomic_t
68
*/
66
69
#include <errno.h> /* errno, EBADF */
70
#include <inttypes.h> /* intmax_t, PRIdMAX, strtoimax() */
71
#include <sysexits.h> /* EX_OSERR, EX_USAGE, EX_IOERR,
72
EX_CONFIG, EX_UNAVAILABLE, EX_OK */
73
#include <errno.h> /* errno */
74
#include <error.h> /* error() */
67
75
68
76
#define BUFFER_SIZE 256
69
77
71
79
#define AFILE "/conf/conf.d/mandos/plugin-runner.conf"
72
80
73
81
const char *argp_program_version = "plugin-runner " VERSION;
74
const char *argp_program_bug_address = "<mandos@fukt.bsnet.se>";
82
const char *argp_program_bug_address = "<mandos@recompile.se>";
75
83
76
84
typedef struct plugin{
77
85
char *name; /* can be NULL or any plugin name */
80
88
char **environ;
81
89
int envc;
82
90
bool disabled;
83
91
84
92
/* Variables used for running processes*/
85
93
pid_t pid;
86
94
int fd;
88
96
size_t buffer_size;
89
97
size_t buffer_length;
90
98
bool eof;
91
volatile bool completed;
92
volatile int status;
99
volatile sig_atomic_t completed;
100
int status;
93
101
struct plugin *next;
94
102
} plugin;
95
103
97
105
98
106
/* Gets an existing plugin based on name,
99
107
or if none is found, creates a new one */
108
__attribute__((warn_unused_result))
100
109
static plugin *getplugin(char *name){
101
/* Check for exiting plugin with that name */
102
for (plugin *p = plugin_list; p != NULL; p = p->next){
103
if ((p->name == name)
104
or (p->name and name and (strcmp(p->name, name) == 0))){
110
/* Check for existing plugin with that name */
111
for(plugin *p = plugin_list; p != NULL; p = p->next){
112
if((p->name == name)
113
or (p->name and name and (strcmp(p->name, name) == 0))){
105
114
return p;
106
115
}
107
116
}
108
117
/* Create a new plugin */
109
plugin *new_plugin = malloc(sizeof(plugin));
110
if (new_plugin == NULL){
118
plugin *new_plugin = NULL;
119
do {
120
new_plugin = malloc(sizeof(plugin));
121
} while(new_plugin == NULL and errno == EINTR);
122
if(new_plugin == NULL){
111
123
return NULL;
112
124
}
113
125
char *copy_name = NULL;
114
126
if(name != NULL){
115
copy_name = strdup(name);
127
do {
128
copy_name = strdup(name);
129
} while(copy_name == NULL and errno == EINTR);
116
130
if(copy_name == NULL){
131
int e = errno;
132
free(new_plugin);
133
errno = e;
117
134
return NULL;
118
135
}
119
136
}
120
137
121
*new_plugin = (plugin) { .name = copy_name,
122
.argc = 1,
123
.disabled = false,
124
.next = plugin_list };
138
*new_plugin = (plugin){ .name = copy_name,
139
.argc = 1,
140
.disabled = false,
141
.next = plugin_list };
125
142
126
new_plugin->argv = malloc(sizeof(char *) * 2);
127
if (new_plugin->argv == NULL){
143
do {
144
new_plugin->argv = malloc(sizeof(char *) * 2);
145
} while(new_plugin->argv == NULL and errno == EINTR);
146
if(new_plugin->argv == NULL){
147
int e = errno;
128
148
free(copy_name);
129
149
free(new_plugin);
150
errno = e;
130
151
return NULL;
131
152
}
132
153
new_plugin->argv[0] = copy_name;
133
154
new_plugin->argv[1] = NULL;
134
155
135
new_plugin->environ = malloc(sizeof(char *));
156
do {
157
new_plugin->environ = malloc(sizeof(char *));
158
} while(new_plugin->environ == NULL and errno == EINTR);
136
159
if(new_plugin->environ == NULL){
160
int e = errno;
137
161
free(copy_name);
138
162
free(new_plugin->argv);
139
163
free(new_plugin);
164
errno = e;
140
165
return NULL;
141
166
}
142
167
new_plugin->environ[0] = NULL;
147
172
}
148
173
149
174
/* Helper function for add_argument and add_environment */
175
__attribute__((nonnull, warn_unused_result))
150
176
static bool add_to_char_array(const char *new, char ***array,
151
177
int *len){
152
178
/* Resize the pointed-to array to hold one more pointer */
153
*array = realloc(*array, sizeof(char *)
154
* (size_t) ((*len) + 2));
179
char **new_array = NULL;
180
do {
181
new_array = realloc(*array, sizeof(char *)
182
* (size_t) ((*len) + 2));
183
} while(new_array == NULL and errno == EINTR);
155
184
/* Malloc check */
156
if(*array == NULL){
185
if(new_array == NULL){
157
186
return false;
158
187
}
188
*array = new_array;
159
189
/* Make a copy of the new string */
160
char *copy = strdup(new);
190
char *copy;
191
do {
192
copy = strdup(new);
193
} while(copy == NULL and errno == EINTR);
161
194
if(copy == NULL){
162
195
return false;
163
196
}
170
203
}
171
204
172
205
/* Add to a plugin's argument vector */
206
__attribute__((nonnull(2), warn_unused_result))
173
207
static bool add_argument(plugin *p, const char *arg){
174
208
if(p == NULL){
175
209
return false;
178
212
}
179
213
180
214
/* Add to a plugin's environment */
215
__attribute__((nonnull(2), warn_unused_result))
181
216
static bool add_environment(plugin *p, const char *def, bool replace){
182
217
if(p == NULL){
183
218
return false;
185
220
/* namelen = length of name of environment variable */
186
221
size_t namelen = (size_t)(strchrnul(def, '=') - def);
187
222
/* Search for this environment variable */
188
for(char **e = p->environ; *e != NULL; e++){
189
if(strncmp(*e, def, namelen + 1) == 0){
223
for(char **envdef = p->environ; *envdef != NULL; envdef++){
224
if(strncmp(*envdef, def, namelen + 1) == 0){
190
225
/* It already exists */
191
226
if(replace){
192
char *new = realloc(*e, strlen(def) + 1);
193
if(new == NULL){
227
char *new_envdef;
228
do {
229
new_envdef = realloc(*envdef, strlen(def) + 1);
230
} while(new_envdef == NULL and errno == EINTR);
231
if(new_envdef == NULL){
194
232
return false;
195
233
}
196
*e = new;
197
strcpy(*e, def);
234
*envdef = new_envdef;
235
strcpy(*envdef, def);
198
236
}
199
237
return true;
200
238
}
205
243
/*
206
244
* Based on the example in the GNU LibC manual chapter 13.13 "File
207
245
* Descriptor Flags".
208
* *Note File Descriptor Flags:(libc)Descriptor Flags.
246
| [[info:libc:Descriptor%20Flags][File Descriptor Flags]] |
209
247
*/
248
__attribute__((warn_unused_result))
210
249
static int set_cloexec_flag(int fd){
211
int ret = fcntl(fd, F_GETFD, 0);
250
int ret = (int)TEMP_FAILURE_RETRY(fcntl(fd, F_GETFD, 0));
212
251
/* If reading the flags failed, return error indication now. */
213
252
if(ret < 0){
214
253
return ret;
215
254
}
216
255
/* Store modified flag word in the descriptor. */
217
return fcntl(fd, F_SETFD, ret | FD_CLOEXEC);
256
return (int)TEMP_FAILURE_RETRY(fcntl(fd, F_SETFD,
257
ret | FD_CLOEXEC));
218
258
}
219
259
220
260
221
261
/* Mark processes as completed when they exit, and save their exit
222
262
status. */
223
263
static void handle_sigchld(__attribute__((unused)) int sig){
264
int old_errno = errno;
224
265
while(true){
225
266
plugin *proc = plugin_list;
226
267
int status;
230
271
break;
231
272
}
232
273
if(pid == -1){
233
if (errno != ECHILD){
234
perror("waitpid");
274
if(errno == ECHILD){
275
/* No child processes */
276
break;
235
277
}
236
/* No child processes */
237
break;
278
error(0, errno, "waitpid");
238
279
}
239
280
240
281
/* A child exited, find it in process_list */
246
287
continue;
247
288
}
248
289
proc->status = status;
249
proc->completed = true;
290
proc->completed = 1;
250
291
}
292
errno = old_errno;
251
293
}
252
294
253
295
/* Prints out a password to stdout */
296
__attribute__((nonnull, warn_unused_result))
254
297
static bool print_out_password(const char *buffer, size_t length){
255
298
ssize_t ret;
256
299
for(size_t written = 0; written < length; written += (size_t)ret){
264
307
}
265
308
266
309
/* Removes and free a plugin from the plugin list */
310
__attribute__((nonnull))
267
311
static void free_plugin(plugin *plugin_node){
268
312
269
313
for(char **arg = plugin_node->argv; *arg != NULL; arg++){
275
319
}
276
320
free(plugin_node->environ);
277
321
free(plugin_node->buffer);
278
322
279
323
/* Removes the plugin from the singly-linked list */
280
324
if(plugin_node == plugin_list){
281
325
/* First one - simple */
309
353
struct stat st;
310
354
fd_set rfds_all;
311
355
int ret, maxfd = 0;
356
ssize_t sret;
312
357
uid_t uid = 65534;
313
358
gid_t gid = 65534;
314
359
bool debug = false;
323
368
sigemptyset(&sigchld_action.sa_mask);
324
369
ret = sigaddset(&sigchld_action.sa_mask, SIGCHLD);
325
370
if(ret == -1){
326
perror("sigaddset");
327
exitstatus = EXIT_FAILURE;
371
error(0, errno, "sigaddset");
372
exitstatus = EX_OSERR;
328
373
goto fallback;
329
374
}
330
375
ret = sigaction(SIGCHLD, &sigchld_action, &old_sigchld_action);
331
376
if(ret == -1){
332
perror("sigaction");
333
exitstatus = EXIT_FAILURE;
377
error(0, errno, "sigaction");
378
exitstatus = EX_OSERR;
334
379
goto fallback;
335
380
}
336
381
368
413
.doc = "Group ID the plugins will run as", .group = 3 },
369
414
{ .name = "debug", .key = 132,
370
415
.doc = "Debug mode", .group = 4 },
416
/*
417
* These reproduce what we would get without ARGP_NO_HELP
418
*/
419
{ .name = "help", .key = '?',
420
.doc = "Give this help list", .group = -1 },
421
{ .name = "usage", .key = -3,
422
.doc = "Give a short usage message", .group = -1 },
423
{ .name = "version", .key = 'V',
424
.doc = "Print program version", .group = -1 },
371
425
{ .name = NULL }
372
426
};
373
427
374
error_t parse_opt (int key, char *arg, __attribute__((unused))
375
struct argp_state *state) {
376
switch (key) {
428
__attribute__((nonnull(3)))
429
error_t parse_opt(int key, char *arg, struct argp_state *state){
430
errno = 0;
431
switch(key){
432
char *tmp;
433
intmax_t tmp_id;
377
434
case 'g': /* --global-options */
378
if (arg != NULL){
379
char *p;
380
while((p = strsep(&arg, ",")) != NULL){
381
if(p[0] == '\0'){
382
continue;
383
}
384
if(not add_argument(getplugin(NULL), p)){
385
perror("add_argument");
386
return ARGP_ERR_UNKNOWN;
435
{
436
char *plugin_option;
437
while((plugin_option = strsep(&arg, ",")) != NULL){
438
if(not add_argument(getplugin(NULL), plugin_option)){
439
break;
387
440
}
388
441
}
442
errno = 0;
389
443
}
390
444
break;
391
445
case 'G': /* --global-env */
392
if(arg == NULL){
393
break;
394
}
395
if(not add_environment(getplugin(NULL), arg, true)){
396
perror("add_environment");
446
if(add_environment(getplugin(NULL), arg, true)){
447
errno = 0;
397
448
}
398
449
break;
399
450
case 'o': /* --options-for */
400
if (arg != NULL){
401
char *p_name = strsep(&arg, ":");
402
if(p_name[0] == '\0' or arg == NULL){
403
break;
404
}
405
char *opt = strsep(&arg, ":");
406
if(opt[0] == '\0' or opt == NULL){
407
break;
408
}
409
char *p;
410
while((p = strsep(&opt, ",")) != NULL){
411
if(p[0] == '\0'){
412
continue;
413
}
414
if(not add_argument(getplugin(p_name), p)){
415
perror("add_argument");
416
return ARGP_ERR_UNKNOWN;
417
}
418
}
451
{
452
char *option_list = strchr(arg, ':');
453
if(option_list == NULL){
454
argp_error(state, "No colon in \"%s\"", arg);
455
errno = EINVAL;
456
break;
457
}
458
*option_list = '\0';
459
option_list++;
460
if(arg[0] == '\0'){
461
argp_error(state, "Empty plugin name");
462
errno = EINVAL;
463
break;
464
}
465
char *option;
466
while((option = strsep(&option_list, ",")) != NULL){
467
if(not add_argument(getplugin(arg), option)){
468
break;
469
}
470
}
471
errno = 0;
419
472
}
420
473
break;
421
474
case 'E': /* --env-for */
422
if(arg == NULL){
423
break;
424
}
425
475
{
426
476
char *envdef = strchr(arg, ':');
427
477
if(envdef == NULL){
478
argp_error(state, "No colon in \"%s\"", arg);
479
errno = EINVAL;
428
480
break;
429
481
}
430
482
*envdef = '\0';
431
if(not add_environment(getplugin(arg), envdef+1, true)){
432
perror("add_environment");
483
envdef++;
484
if(arg[0] == '\0'){
485
argp_error(state, "Empty plugin name");
486
errno = EINVAL;
487
break;
488
}
489
if(add_environment(getplugin(arg), envdef, true)){
490
errno = 0;
433
491
}
434
492
}
435
493
break;
436
494
case 'd': /* --disable */
437
if (arg != NULL){
495
{
438
496
plugin *p = getplugin(arg);
439
if(p == NULL){
440
return ARGP_ERR_UNKNOWN;
497
if(p != NULL){
498
p->disabled = true;
499
errno = 0;
441
500
}
442
p->disabled = true;
443
501
}
444
502
break;
445
503
case 'e': /* --enable */
446
if (arg != NULL){
504
{
447
505
plugin *p = getplugin(arg);
448
if(p == NULL){
449
return ARGP_ERR_UNKNOWN;
506
if(p != NULL){
507
p->disabled = false;
508
errno = 0;
450
509
}
451
p->disabled = false;
452
510
}
453
511
break;
454
512
case 128: /* --plugin-dir */
455
513
free(plugindir);
456
514
plugindir = strdup(arg);
457
if(plugindir == NULL){
458
perror("strdup");
459
}
515
if(plugindir != NULL){
516
errno = 0;
517
}
460
518
break;
461
519
case 129: /* --config-file */
462
520
/* This is already done by parse_opt_config_file() */
463
521
break;
464
522
case 130: /* --userid */
465
uid = (uid_t)strtol(arg, NULL, 10);
523
tmp_id = strtoimax(arg, &tmp, 10);
524
if(errno != 0 or tmp == arg or *tmp != '\0'
525
or tmp_id != (uid_t)tmp_id){
526
argp_error(state, "Bad user ID number: \"%s\", using %"
527
PRIdMAX, arg, (intmax_t)uid);
528
break;
529
}
530
uid = (uid_t)tmp_id;
531
errno = 0;
466
532
break;
467
533
case 131: /* --groupid */
468
gid = (gid_t)strtol(arg, NULL, 10);
534
tmp_id = strtoimax(arg, &tmp, 10);
535
if(errno != 0 or tmp == arg or *tmp != '\0'
536
or tmp_id != (gid_t)tmp_id){
537
argp_error(state, "Bad group ID number: \"%s\", using %"
538
PRIdMAX, arg, (intmax_t)gid);
539
break;
540
}
541
gid = (gid_t)tmp_id;
542
errno = 0;
469
543
break;
470
544
case 132: /* --debug */
471
545
debug = true;
472
546
break;
547
/*
548
* These reproduce what we would get without ARGP_NO_HELP
549
*/
550
case '?': /* --help */
551
state->flags &= ~(unsigned int)ARGP_NO_EXIT; /* force exit */
552
argp_state_help(state, state->out_stream, ARGP_HELP_STD_HELP);
553
case -3: /* --usage */
554
state->flags &= ~(unsigned int)ARGP_NO_EXIT; /* force exit */
555
argp_state_help(state, state->out_stream,
556
ARGP_HELP_USAGE | ARGP_HELP_EXIT_OK);
557
case 'V': /* --version */
558
fprintf(state->out_stream, "%s\n", argp_program_version);
559
exit(EXIT_SUCCESS);
560
break;
561
/*
562
* When adding more options before this line, remember to also add a
563
* "case" to the "parse_opt_config_file" function below.
564
*/
473
565
case ARGP_KEY_ARG:
474
566
/* Cryptsetup always passes an argument, which is an empty
475
567
string if "none" was specified in /etc/crypttab. So if
476
568
argument was empty, we ignore it silently. */
477
if(arg[0] != '\0'){
478
fprintf(stderr, "Ignoring unknown argument \"%s\"\n", arg);
569
if(arg[0] == '\0'){
570
break;
479
571
}
480
break;
481
case ARGP_KEY_END:
482
break;
483
572
default:
484
573
return ARGP_ERR_UNKNOWN;
485
574
}
486
return 0;
575
return errno; /* Set to 0 at start */
487
576
}
488
577
489
578
/* This option parser is the same as parse_opt() above, except it
490
579
ignores everything but the --config-file option. */
491
error_t parse_opt_config_file (int key, char *arg,
492
__attribute__((unused))
493
struct argp_state *state) {
494
switch (key) {
580
error_t parse_opt_config_file(int key, char *arg,
581
__attribute__((unused))
582
struct argp_state *state){
583
errno = 0;
584
switch(key){
495
585
case 'g': /* --global-options */
496
586
case 'G': /* --global-env */
497
587
case 'o': /* --options-for */
503
593
case 129: /* --config-file */
504
594
free(argfile);
505
595
argfile = strdup(arg);
506
if(argfile == NULL){
507
perror("strdup");
596
if(argfile != NULL){
597
errno = 0;
508
598
}
509
break;
599
break;
510
600
case 130: /* --userid */
511
601
case 131: /* --groupid */
512
602
case 132: /* --debug */
603
case '?': /* --help */
604
case -3: /* --usage */
605
case 'V': /* --version */
513
606
case ARGP_KEY_ARG:
514
case ARGP_KEY_END:
515
607
break;
516
608
default:
517
609
return ARGP_ERR_UNKNOWN;
518
610
}
519
return 0;
611
return errno;
520
612
}
521
613
522
614
struct argp argp = { .options = options,
524
616
.args_doc = "",
525
617
.doc = "Mandos plugin runner -- Run plugins" };
526
618
527
/* Parse using the parse_opt_config_file in order to get the custom
619
/* Parse using parse_opt_config_file() in order to get the custom
528
620
config file location, if any. */
529
ret = argp_parse (&argp, argc, argv, ARGP_IN_ORDER, 0, NULL);
530
if (ret == ARGP_ERR_UNKNOWN){
531
fprintf(stderr, "Unknown error while parsing arguments\n");
532
exitstatus = EXIT_FAILURE;
621
ret = argp_parse(&argp, argc, argv,
622
ARGP_IN_ORDER | ARGP_NO_EXIT | ARGP_NO_HELP,
623
NULL, NULL);
624
switch(ret){
625
case 0:
626
break;
627
case ENOMEM:
628
default:
629
errno = ret;
630
error(0, errno, "argp_parse");
631
exitstatus = EX_OSERR;
632
goto fallback;
633
case EINVAL:
634
exitstatus = EX_USAGE;
533
635
goto fallback;
534
636
}
535
637
537
639
argp.parser = parse_opt;
538
640
539
641
/* Open the configfile if available */
540
if (argfile == NULL){
642
if(argfile == NULL){
541
643
conffp = fopen(AFILE, "r");
542
644
} else {
543
645
conffp = fopen(argfile, "r");
544
}
646
}
545
647
if(conffp != NULL){
546
648
char *org_line = NULL;
547
649
char *p, *arg, *new_arg, *line;
548
650
size_t size = 0;
549
ssize_t sret;
550
651
const char whitespace_delims[] = " \r\t\f\v\n";
551
652
const char comment_delim[] = "#";
552
653
553
654
custom_argc = 1;
554
655
custom_argv = malloc(sizeof(char*) * 2);
555
656
if(custom_argv == NULL){
556
perror("malloc");
557
exitstatus = EXIT_FAILURE;
657
error(0, errno, "malloc");
658
exitstatus = EX_OSERR;
558
659
goto fallback;
559
660
}
560
661
custom_argv[0] = argv[0];
561
662
custom_argv[1] = NULL;
562
663
563
664
/* for each line in the config file, strip whitespace and ignore
564
665
commented text */
565
666
while(true){
567
668
if(sret == -1){
568
669
break;
569
670
}
570
671
571
672
line = org_line;
572
673
arg = strsep(&line, comment_delim);
573
674
while((p = strsep(&arg, whitespace_delims)) != NULL){
576
677
}
577
678
new_arg = strdup(p);
578
679
if(new_arg == NULL){
579
perror("strdup");
580
exitstatus = EXIT_FAILURE;
680
error(0, errno, "strdup");
681
exitstatus = EX_OSERR;
581
682
free(org_line);
582
683
goto fallback;
583
684
}
584
685
585
686
custom_argc += 1;
586
custom_argv = realloc(custom_argv, sizeof(char *)
587
* ((unsigned int) custom_argc + 1));
588
if(custom_argv == NULL){
589
perror("realloc");
590
exitstatus = EXIT_FAILURE;
591
free(org_line);
592
goto fallback;
687
{
688
char **new_argv = realloc(custom_argv, sizeof(char *)
689
* ((unsigned int)
690
custom_argc + 1));
691
if(new_argv == NULL){
692
error(0, errno, "realloc");
693
exitstatus = EX_OSERR;
694
free(new_arg);
695
free(org_line);
696
goto fallback;
697
} else {
698
custom_argv = new_argv;
699
}
593
700
}
594
701
custom_argv[custom_argc-1] = new_arg;
595
custom_argv[custom_argc] = NULL;
702
custom_argv[custom_argc] = NULL;
596
703
}
597
704
}
705
do {
706
ret = fclose(conffp);
707
} while(ret == EOF and errno == EINTR);
708
if(ret == EOF){
709
error(0, errno, "fclose");
710
exitstatus = EX_IOERR;
711
goto fallback;
712
}
598
713
free(org_line);
599
714
} else {
600
715
/* Check for harmful errors and go to fallback. Other errors might
601
716
not affect opening plugins */
602
if (errno == EMFILE or errno == ENFILE or errno == ENOMEM){
603
perror("fopen");
604
exitstatus = EXIT_FAILURE;
717
if(errno == EMFILE or errno == ENFILE or errno == ENOMEM){
718
error(0, errno, "fopen");
719
exitstatus = EX_OSERR;
605
720
goto fallback;
606
721
}
607
722
}
608
/* If there was any arguments from configuration file,
609
pass them to parser as command arguments */
723
/* If there were any arguments from the configuration file, pass
724
them to parser as command line arguments */
610
725
if(custom_argv != NULL){
611
ret = argp_parse (&argp, custom_argc, custom_argv, ARGP_IN_ORDER,
612
0, NULL);
613
if (ret == ARGP_ERR_UNKNOWN){
614
fprintf(stderr, "Unknown error while parsing arguments\n");
615
exitstatus = EXIT_FAILURE;
726
ret = argp_parse(&argp, custom_argc, custom_argv,
727
ARGP_IN_ORDER | ARGP_NO_EXIT | ARGP_NO_HELP,
728
NULL, NULL);
729
switch(ret){
730
case 0:
731
break;
732
case ENOMEM:
733
default:
734
errno = ret;
735
error(0, errno, "argp_parse");
736
exitstatus = EX_OSERR;
737
goto fallback;
738
case EINVAL:
739
exitstatus = EX_CONFIG;
616
740
goto fallback;
617
741
}
618
742
}
619
743
620
744
/* Parse actual command line arguments, to let them override the
621
745
config file */
622
ret = argp_parse (&argp, argc, argv, ARGP_IN_ORDER, 0, NULL);
623
if (ret == ARGP_ERR_UNKNOWN){
624
fprintf(stderr, "Unknown error while parsing arguments\n");
625
exitstatus = EXIT_FAILURE;
746
ret = argp_parse(&argp, argc, argv,
747
ARGP_IN_ORDER | ARGP_NO_EXIT | ARGP_NO_HELP,
748
NULL, NULL);
749
switch(ret){
750
case 0:
751
break;
752
case ENOMEM:
753
default:
754
errno = ret;
755
error(0, errno, "argp_parse");
756
exitstatus = EX_OSERR;
757
goto fallback;
758
case EINVAL:
759
exitstatus = EX_USAGE;
626
760
goto fallback;
627
761
}
628
762
633
767
for(char **a = p->argv; *a != NULL; a++){
634
768
fprintf(stderr, "\tArg: %s\n", *a);
635
769
}
636
fprintf(stderr, "...and %u environment variables\n", p->envc);
770
fprintf(stderr, "...and %d environment variables\n", p->envc);
637
771
for(char **a = p->environ; *a != NULL; a++){
638
772
fprintf(stderr, "\t%s\n", *a);
639
773
}
640
774
}
641
775
}
642
776
643
/* Strip permissions down to nobody */
777
if(getuid() == 0){
778
/* Work around Debian bug #633582:
779
<http://bugs.debian.org/633582> */
780
int plugindir_fd = open(/* plugindir or */ PDIR, O_RDONLY);
781
if(plugindir_fd == -1){
782
error(0, errno, "open");
783
} else {
784
ret = (int)TEMP_FAILURE_RETRY(fstat(plugindir_fd, &st));
785
if(ret == -1){
786
error(0, errno, "fstat");
787
} else {
788
if(S_ISDIR(st.st_mode) and st.st_uid == 0 and st.st_gid == 0){
789
ret = fchown(plugindir_fd, uid, gid);
790
if(ret == -1){
791
error(0, errno, "fchown");
792
}
793
}
794
}
795
TEMP_FAILURE_RETRY(close(plugindir_fd));
796
}
797
}
798
799
/* Lower permissions */
800
ret = setgid(gid);
801
if(ret == -1){
802
error(0, errno, "setgid");
803
}
644
804
ret = setuid(uid);
645
if (ret == -1){
646
perror("setuid");
647
}
648
setgid(gid);
649
if (ret == -1){
650
perror("setgid");
651
}
652
653
if (plugindir == NULL){
654
dir = opendir(PDIR);
655
} else {
656
dir = opendir(plugindir);
657
}
658
659
if(dir == NULL){
660
perror("Could not open plugin dir");
661
exitstatus = EXIT_FAILURE;
662
goto fallback;
663
}
664
665
/* Set the FD_CLOEXEC flag on the directory, if possible */
805
if(ret == -1){
806
error(0, errno, "setuid");
807
}
808
809
/* Open plugin directory with close_on_exec flag */
666
810
{
667
int dir_fd = dirfd(dir);
668
if(dir_fd >= 0){
669
ret = set_cloexec_flag(dir_fd);
670
if(ret < 0){
671
perror("set_cloexec_flag");
672
exitstatus = EXIT_FAILURE;
673
goto fallback;
674
}
811
int dir_fd = -1;
812
if(plugindir == NULL){
813
dir_fd = open(PDIR, O_RDONLY |
814
#ifdef O_CLOEXEC
815
O_CLOEXEC
816
#else /* not O_CLOEXEC */
817
0
818
#endif /* not O_CLOEXEC */
819
);
820
} else {
821
dir_fd = open(plugindir, O_RDONLY |
822
#ifdef O_CLOEXEC
823
O_CLOEXEC
824
#else /* not O_CLOEXEC */
825
0
826
#endif /* not O_CLOEXEC */
827
);
828
}
829
if(dir_fd == -1){
830
error(0, errno, "Could not open plugin dir");
831
exitstatus = EX_UNAVAILABLE;
832
goto fallback;
833
}
834
835
#ifndef O_CLOEXEC
836
/* Set the FD_CLOEXEC flag on the directory */
837
ret = set_cloexec_flag(dir_fd);
838
if(ret < 0){
839
error(0, errno, "set_cloexec_flag");
840
TEMP_FAILURE_RETRY(close(dir_fd));
841
exitstatus = EX_OSERR;
842
goto fallback;
843
}
844
#endif /* O_CLOEXEC */
845
846
dir = fdopendir(dir_fd);
847
if(dir == NULL){
848
error(0, errno, "Could not open plugin dir");
849
TEMP_FAILURE_RETRY(close(dir_fd));
850
exitstatus = EX_OSERR;
851
goto fallback;
675
852
}
676
853
}
677
854
679
856
680
857
/* Read and execute any executable in the plugin directory*/
681
858
while(true){
682
dirst = readdir(dir);
859
do {
860
dirst = readdir(dir);
861
} while(dirst == NULL and errno == EINTR);
683
862
684
863
/* All directory entries have been processed */
685
864
if(dirst == NULL){
686
if (errno == EBADF){
687
perror("readdir");
688
exitstatus = EXIT_FAILURE;
865
if(errno == EBADF){
866
error(0, errno, "readdir");
867
exitstatus = EX_IOERR;
689
868
goto fallback;
690
869
}
691
870
break;
697
876
{
698
877
bool bad_name = false;
699
878
700
const char const *bad_prefixes[] = { ".", "#", NULL };
879
const char * const bad_prefixes[] = { ".", "#", NULL };
701
880
702
const char const *bad_suffixes[] = { "~", "#", ".dpkg-new",
881
const char * const bad_suffixes[] = { "~", "#", ".dpkg-new",
703
882
".dpkg-old",
704
883
".dpkg-bak",
705
884
".dpkg-divert", NULL };
706
for(const char **pre = bad_prefixes; *pre != NULL; pre++){
885
#ifdef __GNUC__
886
#pragma GCC diagnostic push
887
#pragma GCC diagnostic ignored "-Wcast-qual"
888
#endif
889
for(const char **pre = (const char **)bad_prefixes;
890
*pre != NULL; pre++){
891
#ifdef __GNUC__
892
#pragma GCC diagnostic pop
893
#endif
707
894
size_t pre_len = strlen(*pre);
708
895
if((d_name_len >= pre_len)
709
896
and strncmp((dirst->d_name), *pre, pre_len) == 0){
718
905
if(bad_name){
719
906
continue;
720
907
}
721
for(const char **suf = bad_suffixes; *suf != NULL; suf++){
908
#ifdef __GNUC__
909
#pragma GCC diagnostic push
910
#pragma GCC diagnostic ignored "-Wcast-qual"
911
#endif
912
for(const char **suf = (const char **)bad_suffixes;
913
*suf != NULL; suf++){
914
#ifdef __GNUC__
915
#pragma GCC diagnostic pop
916
#endif
722
917
size_t suf_len = strlen(*suf);
723
918
if((d_name_len >= suf_len)
724
and (strcmp((dirst->d_name)+d_name_len-suf_len, *suf)
919
and (strcmp((dirst->d_name) + d_name_len-suf_len, *suf)
725
920
== 0)){
726
921
if(debug){
727
922
fprintf(stderr, "Ignoring plugin dir entry \"%s\""
736
931
continue;
737
932
}
738
933
}
739
934
740
935
char *filename;
741
936
if(plugindir == NULL){
742
ret = asprintf(&filename, PDIR "/%s", dirst->d_name);
937
ret = (int)TEMP_FAILURE_RETRY(asprintf(&filename, PDIR "/%s",
938
dirst->d_name));
743
939
} else {
744
ret = asprintf(&filename, "%s/%s", plugindir, dirst->d_name);
940
ret = (int)TEMP_FAILURE_RETRY(asprintf(&filename, "%s/%s",
941
plugindir,
942
dirst->d_name));
745
943
}
746
944
if(ret < 0){
747
perror("asprintf");
945
error(0, errno, "asprintf");
748
946
continue;
749
947
}
750
948
751
ret = stat(filename, &st);
752
if (ret == -1){
753
perror("stat");
949
ret = (int)TEMP_FAILURE_RETRY(stat(filename, &st));
950
if(ret == -1){
951
error(0, errno, "stat");
754
952
free(filename);
755
953
continue;
756
954
}
757
955
758
956
/* Ignore non-executable files */
759
if (not S_ISREG(st.st_mode) or (access(filename, X_OK) != 0)){
957
if(not S_ISREG(st.st_mode)
958
or (TEMP_FAILURE_RETRY(access(filename, X_OK)) != 0)){
760
959
if(debug){
761
960
fprintf(stderr, "Ignoring plugin dir entry \"%s\""
762
961
" with bad type or mode\n", filename);
767
966
768
967
plugin *p = getplugin(dirst->d_name);
769
968
if(p == NULL){
770
perror("getplugin");
969
error(0, errno, "getplugin");
771
970
free(filename);
772
971
continue;
773
972
}
785
984
if(g != NULL){
786
985
for(char **a = g->argv + 1; *a != NULL; a++){
787
986
if(not add_argument(p, *a)){
788
perror("add_argument");
987
error(0, errno, "add_argument");
789
988
}
790
989
}
791
990
/* Add global environment variables */
792
991
for(char **e = g->environ; *e != NULL; e++){
793
992
if(not add_environment(p, *e, false)){
794
perror("add_environment");
993
error(0, errno, "add_environment");
795
994
}
796
995
}
797
996
}
802
1001
if(p->environ[0] != NULL){
803
1002
for(char **e = environ; *e != NULL; e++){
804
1003
if(not add_environment(p, *e, false)){
805
perror("add_environment");
1004
error(0, errno, "add_environment");
806
1005
}
807
1006
}
808
1007
}
809
1008
810
1009
int pipefd[2];
811
ret = pipe(pipefd);
812
if (ret == -1){
813
perror("pipe");
814
exitstatus = EXIT_FAILURE;
1010
ret = (int)TEMP_FAILURE_RETRY(pipe(pipefd));
1011
if(ret == -1){
1012
error(0, errno, "pipe");
1013
exitstatus = EX_OSERR;
815
1014
goto fallback;
816
1015
}
817
1016
/* Ask OS to automatic close the pipe on exec */
818
1017
ret = set_cloexec_flag(pipefd[0]);
819
1018
if(ret < 0){
820
perror("set_cloexec_flag");
821
exitstatus = EXIT_FAILURE;
1019
error(0, errno, "set_cloexec_flag");
1020
exitstatus = EX_OSERR;
822
1021
goto fallback;
823
1022
}
824
1023
ret = set_cloexec_flag(pipefd[1]);
825
1024
if(ret < 0){
826
perror("set_cloexec_flag");
827
exitstatus = EXIT_FAILURE;
1025
error(0, errno, "set_cloexec_flag");
1026
exitstatus = EX_OSERR;
828
1027
goto fallback;
829
1028
}
830
1029
/* Block SIGCHLD until process is safely in process list */
831
ret = sigprocmask (SIG_BLOCK, &sigchld_action.sa_mask, NULL);
1030
ret = (int)TEMP_FAILURE_RETRY(sigprocmask(SIG_BLOCK,
1031
&sigchld_action.sa_mask,
1032
NULL));
832
1033
if(ret < 0){
833
perror("sigprocmask");
834
exitstatus = EXIT_FAILURE;
1034
error(0, errno, "sigprocmask");
1035
exitstatus = EX_OSERR;
835
1036
goto fallback;
836
1037
}
837
1038
/* Starting a new process to be watched */
838
pid_t pid = fork();
1039
pid_t pid;
1040
do {
1041
pid = fork();
1042
} while(pid == -1 and errno == EINTR);
839
1043
if(pid == -1){
840
perror("fork");
841
exitstatus = EXIT_FAILURE;
1044
error(0, errno, "fork");
1045
exitstatus = EX_OSERR;
842
1046
goto fallback;
843
1047
}
844
1048
if(pid == 0){
845
1049
/* this is the child process */
846
1050
ret = sigaction(SIGCHLD, &old_sigchld_action, NULL);
847
1051
if(ret < 0){
848
perror("sigaction");
849
_exit(EXIT_FAILURE);
1052
error(0, errno, "sigaction");
1053
_exit(EX_OSERR);
850
1054
}
851
1055
ret = sigprocmask(SIG_UNBLOCK, &sigchld_action.sa_mask, NULL);
852
1056
if(ret < 0){
853
perror("sigprocmask");
854
_exit(EXIT_FAILURE);
1057
error(0, errno, "sigprocmask");
1058
_exit(EX_OSERR);
855
1059
}
856
1060
857
1061
ret = dup2(pipefd[1], STDOUT_FILENO); /* replace our stdout */
858
1062
if(ret == -1){
859
perror("dup2");
860
_exit(EXIT_FAILURE);
1063
error(0, errno, "dup2");
1064
_exit(EX_OSERR);
861
1065
}
862
1066
863
1067
if(dirfd(dir) < 0){
867
1071
}
868
1072
if(p->environ[0] == NULL){
869
1073
if(execv(filename, p->argv) < 0){
870
perror("execv");
871
_exit(EXIT_FAILURE);
1074
error(0, errno, "execv for %s", filename);
1075
_exit(EX_OSERR);
872
1076
}
873
1077
} else {
874
1078
if(execve(filename, p->argv, p->environ) < 0){
875
perror("execve");
876
_exit(EXIT_FAILURE);
1079
error(0, errno, "execve for %s", filename);
1080
_exit(EX_OSERR);
877
1081
}
878
1082
}
879
1083
/* no return */
880
1084
}
881
1085
/* Parent process */
882
close(pipefd[1]); /* Close unused write end of pipe */
1086
TEMP_FAILURE_RETRY(close(pipefd[1])); /* Close unused write end of
1087
pipe */
883
1088
free(filename);
884
1089
plugin *new_plugin = getplugin(dirst->d_name);
885
if (new_plugin == NULL){
886
perror("getplugin");
887
ret = sigprocmask (SIG_UNBLOCK, &sigchld_action.sa_mask, NULL);
1090
if(new_plugin == NULL){
1091
error(0, errno, "getplugin");
1092
ret = (int)(TEMP_FAILURE_RETRY
1093
(sigprocmask(SIG_UNBLOCK, &sigchld_action.sa_mask,
1094
NULL)));
888
1095
if(ret < 0){
889
perror("sigprocmask");
1096
error(0, errno, "sigprocmask");
890
1097
}
891
exitstatus = EXIT_FAILURE;
1098
exitstatus = EX_OSERR;
892
1099
goto fallback;
893
1100
}
894
1101
897
1104
898
1105
/* Unblock SIGCHLD so signal handler can be run if this process
899
1106
has already completed */
900
ret = sigprocmask (SIG_UNBLOCK, &sigchld_action.sa_mask, NULL);
1107
ret = (int)TEMP_FAILURE_RETRY(sigprocmask(SIG_UNBLOCK,
1108
&sigchld_action.sa_mask,
1109
NULL));
901
1110
if(ret < 0){
902
perror("sigprocmask");
903
exitstatus = EXIT_FAILURE;
1111
error(0, errno, "sigprocmask");
1112
exitstatus = EX_OSERR;
904
1113
goto fallback;
905
1114
}
906
1115
907
FD_SET(new_plugin->fd, &rfds_all);
1116
#if defined (__GNUC__) and defined (__GLIBC__)
1117
#if not __GLIBC_PREREQ(2, 16)
1118
#pragma GCC diagnostic push
1119
#pragma GCC diagnostic ignored "-Wsign-conversion"
1120
#endif
1121
#endif
1122
FD_SET(new_plugin->fd, &rfds_all); /* Spurious warning from
1123
-Wconversion in GNU libc
1124
before 2.16 */
1125
#if defined (__GNUC__) and defined (__GLIBC__)
1126
#if not __GLIBC_PREREQ(2, 16)
1127
#pragma GCC diagnostic pop
1128
#endif
1129
#endif
908
1130
909
if (maxfd < new_plugin->fd){
1131
if(maxfd < new_plugin->fd){
910
1132
maxfd = new_plugin->fd;
911
1133
}
912
1134
}
913
1135
914
closedir(dir);
1136
TEMP_FAILURE_RETRY(closedir(dir));
915
1137
dir = NULL;
1138
free_plugin(getplugin(NULL));
916
1139
917
1140
for(plugin *p = plugin_list; p != NULL; p = p->next){
918
1141
if(p->pid != 0){
929
1152
while(plugin_list){
930
1153
fd_set rfds = rfds_all;
931
1154
int select_ret = select(maxfd+1, &rfds, NULL, NULL, NULL);
932
if (select_ret == -1){
933
perror("select");
934
exitstatus = EXIT_FAILURE;
1155
if(select_ret == -1 and errno != EINTR){
1156
error(0, errno, "select");
1157
exitstatus = EX_OSERR;
935
1158
goto fallback;
936
1159
}
937
1160
/* OK, now either a process completed, or something can be read
938
1161
from one of them */
939
1162
for(plugin *proc = plugin_list; proc != NULL;){
940
1163
/* Is this process completely done? */
941
if(proc->eof and proc->completed){
1164
if(proc->completed and proc->eof){
942
1165
/* Only accept the plugin output if it exited cleanly */
943
1166
if(not WIFEXITED(proc->status)
944
1167
or WEXITSTATUS(proc->status) != 0){
945
1168
/* Bad exit by plugin */
946
1169
947
1170
if(debug){
948
1171
if(WIFEXITED(proc->status)){
949
fprintf(stderr, "Plugin %u exited with status %d\n",
950
(unsigned int) (proc->pid),
1172
fprintf(stderr, "Plugin %s [%" PRIdMAX "] exited with"
1173
" status %d\n", proc->name,
1174
(intmax_t) (proc->pid),
951
1175
WEXITSTATUS(proc->status));
952
} else if(WIFSIGNALED(proc->status)) {
953
fprintf(stderr, "Plugin %u killed by signal %d\n",
954
(unsigned int) (proc->pid),
955
WTERMSIG(proc->status));
1176
} else if(WIFSIGNALED(proc->status)){
1177
fprintf(stderr, "Plugin %s [%" PRIdMAX "] killed by"
1178
" signal %d: %s\n", proc->name,
1179
(intmax_t) (proc->pid),
1180
WTERMSIG(proc->status),
1181
strsignal(WTERMSIG(proc->status)));
956
1182
} else if(WCOREDUMP(proc->status)){
957
fprintf(stderr, "Plugin %d dumped core\n",
958
(unsigned int) (proc->pid));
1183
fprintf(stderr, "Plugin %s [%" PRIdMAX "] dumped"
1184
" core\n", proc->name, (intmax_t) (proc->pid));
959
1185
}
960
1186
}
961
1187
962
1188
/* Remove the plugin */
963
FD_CLR(proc->fd, &rfds_all);
964
1189
#if defined (__GNUC__) and defined (__GLIBC__)
1190
#if not __GLIBC_PREREQ(2, 16)
1191
#pragma GCC diagnostic push
1192
#pragma GCC diagnostic ignored "-Wsign-conversion"
1193
#endif
1194
#endif
1195
FD_CLR(proc->fd, &rfds_all); /* Spurious warning from
1196
-Wconversion in GNU libc
1197
before 2.16 */
1198
#if defined (__GNUC__) and defined (__GLIBC__)
1199
#if not __GLIBC_PREREQ(2, 16)
1200
#pragma GCC diagnostic pop
1201
#endif
1202
#endif
1203
965
1204
/* Block signal while modifying process_list */
966
ret = sigprocmask(SIG_BLOCK, &sigchld_action.sa_mask, NULL);
1205
ret = (int)TEMP_FAILURE_RETRY(sigprocmask
1206
(SIG_BLOCK,
1207
&sigchld_action.sa_mask,
1208
NULL));
967
1209
if(ret < 0){
968
perror("sigprocmask");
969
exitstatus = EXIT_FAILURE;
1210
error(0, errno, "sigprocmask");
1211
exitstatus = EX_OSERR;
970
1212
goto fallback;
971
1213
}
972
1214
975
1217
proc = next_plugin;
976
1218
977
1219
/* We are done modifying process list, so unblock signal */
978
ret = sigprocmask (SIG_UNBLOCK, &sigchld_action.sa_mask,
979
NULL);
1220
ret = (int)(TEMP_FAILURE_RETRY
1221
(sigprocmask(SIG_UNBLOCK,
1222
&sigchld_action.sa_mask, NULL)));
980
1223
if(ret < 0){
981
perror("sigprocmask");
982
exitstatus = EXIT_FAILURE;
1224
error(0, errno, "sigprocmask");
1225
exitstatus = EX_OSERR;
983
1226
goto fallback;
984
1227
}
985
1228
995
1238
bool bret = print_out_password(proc->buffer,
996
1239
proc->buffer_length);
997
1240
if(not bret){
998
perror("print_out_password");
999
exitstatus = EXIT_FAILURE;
1241
error(0, errno, "print_out_password");
1242
exitstatus = EX_IOERR;
1000
1243
}
1001
1244
goto fallback;
1002
1245
}
1003
1246
1004
1247
/* This process has not completed. Does it have any output? */
1005
if(proc->eof or not FD_ISSET(proc->fd, &rfds)){
1248
#if defined (__GNUC__) and defined (__GLIBC__)
1249
#if not __GLIBC_PREREQ(2, 16)
1250
#pragma GCC diagnostic push
1251
#pragma GCC diagnostic ignored "-Wsign-conversion"
1252
#endif
1253
#endif
1254
if(proc->eof or not FD_ISSET(proc->fd, &rfds)){ /* Spurious
1255
warning from
1256
-Wconversion
1257
in GNU libc
1258
before
1259
2.16 */
1260
#if defined (__GNUC__) and defined (__GLIBC__)
1261
#if not __GLIBC_PREREQ(2, 16)
1262
#pragma GCC diagnostic pop
1263
#endif
1264
#endif
1006
1265
/* This process had nothing to say at this time */
1007
1266
proc = proc->next;
1008
1267
continue;
1009
1268
}
1010
1269
/* Before reading, make the process' data buffer large enough */
1011
1270
if(proc->buffer_length + BUFFER_SIZE > proc->buffer_size){
1012
proc->buffer = realloc(proc->buffer, proc->buffer_size
1013
+ (size_t) BUFFER_SIZE);
1014
if (proc->buffer == NULL){
1015
perror("malloc");
1016
exitstatus = EXIT_FAILURE;
1271
char *new_buffer = realloc(proc->buffer, proc->buffer_size
1272
+ (size_t) BUFFER_SIZE);
1273
if(new_buffer == NULL){
1274
error(0, errno, "malloc");
1275
exitstatus = EX_OSERR;
1017
1276
goto fallback;
1018
1277
}
1278
proc->buffer = new_buffer;
1019
1279
proc->buffer_size += BUFFER_SIZE;
1020
1280
}
1021
1281
/* Read from the process */
1022
ret = read(proc->fd, proc->buffer + proc->buffer_length,
1023
BUFFER_SIZE);
1024
if(ret < 0){
1282
sret = TEMP_FAILURE_RETRY(read(proc->fd,
1283
proc->buffer
1284
+ proc->buffer_length,
1285
BUFFER_SIZE));
1286
if(sret < 0){
1025
1287
/* Read error from this process; ignore the error */
1026
1288
proc = proc->next;
1027
1289
continue;
1028
1290
}
1029
if(ret == 0){
1291
if(sret == 0){
1030
1292
/* got EOF */
1031
1293
proc->eof = true;
1032
1294
} else {
1033
proc->buffer_length += (size_t) ret;
1295
proc->buffer_length += (size_t) sret;
1034
1296
}
1035
1297
}
1036
1298
}
1037
1038
1299
1300
1039
1301
fallback:
1040
1302
1041
if(plugin_list == NULL or exitstatus != EXIT_SUCCESS){
1303
if(plugin_list == NULL or (exitstatus != EXIT_SUCCESS
1304
and exitstatus != EX_OK)){
1042
1305
/* Fallback if all plugins failed, none are found or an error
1043
1306
occured */
1044
1307
bool bret;
1052
1315
}
1053
1316
bret = print_out_password(passwordbuffer, len);
1054
1317
if(not bret){
1055
perror("print_out_password");
1056
exitstatus = EXIT_FAILURE;
1318
error(0, errno, "print_out_password");
1319
exitstatus = EX_IOERR;
1057
1320
}
1058
1321
}
1059
1322
1060
1323
/* Restore old signal handler */
1061
1324
ret = sigaction(SIGCHLD, &old_sigchld_action, NULL);
1062
1325
if(ret == -1){
1063
perror("sigaction");
1064
exitstatus = EXIT_FAILURE;
1326
error(0, errno, "sigaction");
1327
exitstatus = EX_OSERR;
1065
1328
}
1066
1329
1067
1330
if(custom_argv != NULL){
1082
1345
ret = kill(p->pid, SIGTERM);
1083
1346
if(ret == -1 and errno != ESRCH){
1084
1347
/* Set-uid proccesses might not get closed */
1085
perror("kill");
1348
error(0, errno, "kill");
1086
1349
}
1087
1350
}
1088
1351
}
1089
1352
1090
1353
/* Wait for any remaining child processes to terminate */
1091
do{
1354
do {
1092
1355
ret = wait(NULL);
1093
1356
} while(ret >= 0);
1094
1357
if(errno != ECHILD){
1095
perror("wait");
1358
error(0, errno, "wait");
1096
1359
}
1097
1360
1098
1361
free_plugin_list();
Loggerhead is a web-based interface for Breezy
Version: 2.0.2.dev0