18
19
* along with this program. If not, see
19
20
* <http://www.gnu.org/licenses/>.
21
* Contact the authors at <mandos@fukt.bsnet.se>.
22
* Contact the authors at <mandos@recompile.se>.
24
25
#define _GNU_SOURCE /* TEMP_FAILURE_RETRY(), getline(),
26
asprintf(), O_CLOEXEC */
26
27
#include <stddef.h> /* size_t, NULL */
27
#include <stdlib.h> /* malloc(), exit(), EXIT_FAILURE,
28
EXIT_SUCCESS, realloc() */
28
#include <stdlib.h> /* malloc(), exit(), EXIT_SUCCESS,
29
30
#include <stdbool.h> /* bool, true, false */
30
#include <stdio.h> /* perror, popen(), fileno(),
31
fprintf(), stderr, STDOUT_FILENO */
32
#include <sys/types.h> /* DIR, opendir(), stat(), struct
31
#include <stdio.h> /* fileno(), fprintf(),
32
stderr, STDOUT_FILENO */
33
#include <sys/types.h> /* DIR, fdopendir(), stat(), struct
33
34
stat, waitpid(), WIFEXITED(),
34
35
WEXITSTATUS(), wait(), pid_t,
35
36
uid_t, gid_t, getuid(), getgid(),
37
38
#include <sys/select.h> /* fd_set, select(), FD_ZERO(),
38
39
FD_SET(), FD_ISSET(), FD_CLR */
39
40
#include <sys/wait.h> /* wait(), waitpid(), WIFEXITED(),
41
WEXITSTATUS(), WTERMSIG(),
41
43
#include <sys/stat.h> /* struct stat, stat(), S_ISREG() */
42
44
#include <iso646.h> /* and, or, not */
43
#include <dirent.h> /* DIR, struct dirent, opendir(),
45
#include <dirent.h> /* DIR, struct dirent, fdopendir(),
44
46
readdir(), closedir(), dirfd() */
45
47
#include <unistd.h> /* struct stat, stat(), S_ISREG(),
46
48
fcntl(), setuid(), setgid(),
47
49
F_GETFD, F_SETFD, FD_CLOEXEC,
48
50
access(), pipe(), fork(), close()
49
dup2, STDOUT_FILENO, _exit(),
51
dup2(), STDOUT_FILENO, _exit(),
50
52
execv(), write(), read(),
52
54
#include <fcntl.h> /* fcntl(), F_GETFD, F_SETFD,
54
#include <string.h> /* strsep, strlen(), asprintf() */
56
#include <string.h> /* strsep, strlen(), asprintf(),
57
strsignal(), strcmp(), strncmp() */
55
58
#include <errno.h> /* errno */
56
59
#include <argp.h> /* struct argp_option, struct
57
60
argp_state, struct argp,
89
96
size_t buffer_size;
90
97
size_t buffer_length;
92
volatile bool completed;
99
volatile sig_atomic_t completed;
94
101
struct plugin *next;
97
104
static plugin *plugin_list = NULL;
99
/* Gets a existing plugin based on name,
106
/* Gets an existing plugin based on name,
100
107
or if none is found, creates a new one */
101
108
static plugin *getplugin(char *name){
102
/* Check for exiting plugin with that name */
103
for (plugin *p = plugin_list; p != NULL; p = p->next){
104
if ((p->name == name)
105
or (p->name and name and (strcmp(p->name, name) == 0))){
109
/* Check for existing plugin with that name */
110
for(plugin *p = plugin_list; p != NULL; p = p->next){
112
or (p->name and name and (strcmp(p->name, name) == 0))){
109
116
/* Create a new plugin */
110
plugin *new_plugin = malloc(sizeof(plugin));
111
if (new_plugin == NULL){
117
plugin *new_plugin = NULL;
119
new_plugin = malloc(sizeof(plugin));
120
} while(new_plugin == NULL and errno == EINTR);
121
if(new_plugin == NULL){
114
124
char *copy_name = NULL;
115
125
if(name != NULL){
116
copy_name = strdup(name);
127
copy_name = strdup(name);
128
} while(copy_name == NULL and errno == EINTR);
117
129
if(copy_name == NULL){
122
*new_plugin = (plugin) { .name = copy_name,
125
.next = plugin_list };
127
new_plugin->argv = malloc(sizeof(char *) * 2);
128
if (new_plugin->argv == NULL){
137
*new_plugin = (plugin){ .name = copy_name,
140
.next = plugin_list };
143
new_plugin->argv = malloc(sizeof(char *) * 2);
144
} while(new_plugin->argv == NULL and errno == EINTR);
145
if(new_plugin->argv == NULL){
130
148
free(new_plugin);
133
152
new_plugin->argv[0] = copy_name;
134
153
new_plugin->argv[1] = NULL;
136
new_plugin->environ = malloc(sizeof(char *));
156
new_plugin->environ = malloc(sizeof(char *));
157
} while(new_plugin->environ == NULL and errno == EINTR);
137
158
if(new_plugin->environ == NULL){
139
161
free(new_plugin->argv);
140
162
free(new_plugin);
143
166
new_plugin->environ[0] = NULL;
145
168
/* Append the new plugin to the list */
146
169
plugin_list = new_plugin;
147
170
return new_plugin;
150
173
/* Helper function for add_argument and add_environment */
174
__attribute__((nonnull))
151
175
static bool add_to_char_array(const char *new, char ***array,
153
177
/* Resize the pointed-to array to hold one more pointer */
154
*array = realloc(*array, sizeof(char *)
155
* (size_t) ((*len) + 2));
179
*array = realloc(*array, sizeof(char *)
180
* (size_t) ((*len) + 2));
181
} while(*array == NULL and errno == EINTR);
156
182
/* Malloc check */
157
183
if(*array == NULL){
160
186
/* Make a copy of the new string */
161
char *copy = strdup(new);
190
} while(copy == NULL and errno == EINTR);
162
191
if(copy == NULL){
181
211
/* Add to a plugin's environment */
182
static bool add_environment(plugin *p, const char *def){
212
__attribute__((nonnull(2)))
213
static bool add_environment(plugin *p, const char *def, bool replace){
217
/* namelen = length of name of environment variable */
218
size_t namelen = (size_t)(strchrnul(def, '=') - def);
219
/* Search for this environment variable */
220
for(char **e = p->environ; *e != NULL; e++){
221
if(strncmp(*e, def, namelen + 1) == 0){
222
/* It already exists */
226
new = realloc(*e, strlen(def) + 1);
227
} while(new == NULL and errno == EINTR);
186
237
return add_to_char_array(def, &(p->environ), &(p->envc));
190
241
* Based on the example in the GNU LibC manual chapter 13.13 "File
191
242
* Descriptor Flags".
192
* *Note File Descriptor Flags:(libc)Descriptor Flags.
243
| [[info:libc:Descriptor%20Flags][File Descriptor Flags]] |
194
static int set_cloexec_flag(int fd)
196
int ret = fcntl(fd, F_GETFD, 0);
245
static int set_cloexec_flag(int fd){
246
int ret = (int)TEMP_FAILURE_RETRY(fcntl(fd, F_GETFD, 0));
197
247
/* If reading the flags failed, return error indication now. */
201
251
/* Store modified flag word in the descriptor. */
202
return fcntl(fd, F_SETFD, ret | FD_CLOEXEC);
252
return (int)TEMP_FAILURE_RETRY(fcntl(fd, F_SETFD,
206
257
/* Mark processes as completed when they exit, and save their exit
208
void handle_sigchld(__attribute__((unused)) int sig){
259
static void handle_sigchld(__attribute__((unused)) int sig){
260
int old_errno = errno;
210
262
plugin *proc = plugin_list;
327
380
{ .name = "global-options", .key = 'g',
328
381
.arg = "OPTION[,OPTION[,...]]",
329
382
.doc = "Options passed to all plugins" },
330
{ .name = "global-envs", .key = 'e',
383
{ .name = "global-env", .key = 'G',
331
384
.arg = "VAR=value",
332
385
.doc = "Environment variable passed to all plugins" },
333
386
{ .name = "options-for", .key = 'o',
334
387
.arg = "PLUGIN:OPTION[,OPTION[,...]]",
335
388
.doc = "Options passed only to specified plugin" },
336
{ .name = "envs-for", .key = 'f',
389
{ .name = "env-for", .key = 'E',
337
390
.arg = "PLUGIN:ENV=value",
338
391
.doc = "Environment variable passed to specified plugin" },
339
392
{ .name = "disable", .key = 'd',
341
394
.doc = "Disable a specific plugin", .group = 1 },
395
{ .name = "enable", .key = 'e',
397
.doc = "Enable a specific plugin", .group = 1 },
342
398
{ .name = "plugin-dir", .key = 128,
343
399
.arg = "DIRECTORY",
344
400
.doc = "Specify a different plugin directory", .group = 2 },
353
409
.doc = "Group ID the plugins will run as", .group = 3 },
354
410
{ .name = "debug", .key = 132,
355
411
.doc = "Debug mode", .group = 4 },
413
* These reproduce what we would get without ARGP_NO_HELP
415
{ .name = "help", .key = '?',
416
.doc = "Give this help list", .group = -1 },
417
{ .name = "usage", .key = -3,
418
.doc = "Give a short usage message", .group = -1 },
419
{ .name = "version", .key = 'V',
420
.doc = "Print program version", .group = -1 },
359
error_t parse_opt (int key, char *arg, __attribute__((unused)) struct argp_state *state) {
360
/* Get the INPUT argument from `argp_parse', which we know is a
361
pointer to our plugin list pointer. */
424
__attribute__((nonnull(3)))
425
error_t parse_opt(int key, char *arg, struct argp_state *state){
363
430
case 'g': /* --global-options */
366
while((p = strsep(&arg, ",")) != NULL){
370
if(not add_argument(getplugin(NULL), p)){
371
perror("add_argument");
372
return ARGP_ERR_UNKNOWN;
377
case 'e': /* --global-envs */
382
char *envdef = strdup(arg);
386
if(not add_environment(getplugin(NULL), envdef)){
387
perror("add_environment");
433
while((plugin_option = strsep(&arg, ",")) != NULL){
434
if(not add_argument(getplugin(NULL), plugin_option)){
440
case 'G': /* --global-env */
441
add_environment(getplugin(NULL), arg, true);
391
443
case 'o': /* --options-for */
393
char *p_name = strsep(&arg, ":");
394
if(p_name[0] == '\0'){
397
char *opt = strsep(&arg, ":");
403
while((p = strsep(&opt, ",")) != NULL){
407
if(not add_argument(getplugin(p_name), p)){
408
perror("add_argument");
409
return ARGP_ERR_UNKNOWN;
445
char *option_list = strchr(arg, ':');
446
if(option_list == NULL){
447
argp_error(state, "No colon in \"%s\"", arg);
454
argp_error(state, "Empty plugin name");
459
while((option = strsep(&option_list, ",")) != NULL){
460
if(not add_argument(getplugin(arg), option)){
415
case 'f': /* --envs-for */
466
case 'E': /* --env-for */
420
468
char *envdef = strchr(arg, ':');
421
469
if(envdef == NULL){
424
char *p_name = strndup(arg, (size_t) (envdef-arg));
470
argp_error(state, "No colon in \"%s\"", arg);
429
if(not add_environment(getplugin(p_name), envdef)){
430
perror("add_environment");
477
argp_error(state, "Empty plugin name");
481
add_environment(getplugin(arg), envdef, true);
434
484
case 'd': /* --disable */
436
plugin *p = getplugin(arg);
438
return ARGP_ERR_UNKNOWN;
486
plugin *p = getplugin(arg);
492
case 'e': /* --enable */
494
plugin *p = getplugin(arg);
443
500
case 128: /* --plugin-dir */
444
502
plugindir = strdup(arg);
445
if(plugindir == NULL){
449
case 129: /* --config-file */
504
case 129: /* --config-file */
505
/* This is already done by parse_opt_config_file() */
507
case 130: /* --userid */
508
tmp_id = strtoimax(arg, &tmp, 10);
509
if(errno != 0 or tmp == arg or *tmp != '\0'
510
or tmp_id != (uid_t)tmp_id){
511
argp_error(state, "Bad user ID number: \"%s\", using %"
512
PRIdMAX, arg, (intmax_t)uid);
517
case 131: /* --groupid */
518
tmp_id = strtoimax(arg, &tmp, 10);
519
if(errno != 0 or tmp == arg or *tmp != '\0'
520
or tmp_id != (gid_t)tmp_id){
521
argp_error(state, "Bad group ID number: \"%s\", using %"
522
PRIdMAX, arg, (intmax_t)gid);
527
case 132: /* --debug */
531
* These reproduce what we would get without ARGP_NO_HELP
533
case '?': /* --help */
534
state->flags &= ~(unsigned int)ARGP_NO_EXIT; /* force exit */
535
argp_state_help(state, state->out_stream, ARGP_HELP_STD_HELP);
536
case -3: /* --usage */
537
state->flags &= ~(unsigned int)ARGP_NO_EXIT; /* force exit */
538
argp_state_help(state, state->out_stream,
539
ARGP_HELP_USAGE | ARGP_HELP_EXIT_OK);
540
case 'V': /* --version */
541
fprintf(state->out_stream, "%s\n", argp_program_version);
545
* When adding more options before this line, remember to also add a
546
* "case" to the "parse_opt_config_file" function below.
549
/* Cryptsetup always passes an argument, which is an empty
550
string if "none" was specified in /etc/crypttab. So if
551
argument was empty, we ignore it silently. */
556
return ARGP_ERR_UNKNOWN;
558
return errno; /* Set to 0 at start */
561
/* This option parser is the same as parse_opt() above, except it
562
ignores everything but the --config-file option. */
563
error_t parse_opt_config_file(int key, char *arg,
564
__attribute__((unused))
565
struct argp_state *state){
568
case 'g': /* --global-options */
569
case 'G': /* --global-env */
570
case 'o': /* --options-for */
571
case 'E': /* --env-for */
572
case 'd': /* --disable */
573
case 'e': /* --enable */
574
case 128: /* --plugin-dir */
576
case 129: /* --config-file */
450
578
argfile = strdup(arg);
455
580
case 130: /* --userid */
456
uid = (uid_t)strtol(arg, NULL, 10);
458
581
case 131: /* --groupid */
459
gid = (gid_t)strtol(arg, NULL, 10);
461
582
case 132: /* --debug */
583
case '?': /* --help */
584
case -3: /* --usage */
585
case 'V': /* --version */
464
586
case ARGP_KEY_ARG:
465
fprintf(stderr, "Ignoring unknown argument \"%s\"\n", arg);
470
589
return ARGP_ERR_UNKNOWN;
475
struct argp argp = { .options = options, .parser = parse_opt,
476
.args_doc = "[+PLUS_SEPARATED_OPTIONS]",
594
struct argp argp = { .options = options,
595
.parser = parse_opt_config_file,
477
597
.doc = "Mandos plugin runner -- Run plugins" };
479
ret = argp_parse (&argp, argc, argv, 0, 0, NULL);
480
if (ret == ARGP_ERR_UNKNOWN){
481
fprintf(stderr, "Unknown error while parsing arguments\n");
482
exitstatus = EXIT_FAILURE;
599
/* Parse using parse_opt_config_file() in order to get the custom
600
config file location, if any. */
601
ret = argp_parse(&argp, argc, argv,
602
ARGP_IN_ORDER | ARGP_NO_EXIT | ARGP_NO_HELP,
610
error(0, errno, "argp_parse");
611
exitstatus = EX_OSERR;
614
exitstatus = EX_USAGE;
486
/* Opens the configfile if aviable */
487
if (argfile == NULL){
618
/* Reset to the normal argument parser */
619
argp.parser = parse_opt;
621
/* Open the configfile if available */
488
623
conffp = fopen(AFILE, "r");
490
625
conffp = fopen(argfile, "r");
492
627
if(conffp != NULL){
493
628
char *org_line = NULL;
494
629
char *p, *arg, *new_arg, *line;
497
631
const char whitespace_delims[] = " \r\t\f\v\n";
498
632
const char comment_delim[] = "#";
501
635
custom_argv = malloc(sizeof(char*) * 2);
502
636
if(custom_argv == NULL){
504
exitstatus = EXIT_FAILURE;
637
error(0, errno, "malloc");
638
exitstatus = EX_OSERR;
507
641
custom_argv[0] = argv[0];
508
642
custom_argv[1] = NULL;
510
/* for each line in the config file, strip whitespace and ignore commented text */
644
/* for each line in the config file, strip whitespace and ignore
512
647
sret = getline(&org_line, &size, conffp);
518
653
arg = strsep(&line, comment_delim);
519
654
while((p = strsep(&arg, whitespace_delims)) != NULL){
532
667
custom_argv = realloc(custom_argv, sizeof(char *)
533
668
* ((unsigned int) custom_argc + 1));
534
669
if(custom_argv == NULL){
536
exitstatus = EXIT_FAILURE;
670
error(0, errno, "realloc");
671
exitstatus = EX_OSERR;
540
675
custom_argv[custom_argc-1] = new_arg;
541
custom_argv[custom_argc] = NULL;
676
custom_argv[custom_argc] = NULL;
680
ret = fclose(conffp);
681
} while(ret == EOF and errno == EINTR);
683
error(0, errno, "fclose");
684
exitstatus = EX_IOERR;
546
689
/* Check for harmful errors and go to fallback. Other errors might
547
690
not affect opening plugins */
548
if (errno == EMFILE or errno == ENFILE or errno == ENOMEM){
550
exitstatus = EXIT_FAILURE;
691
if(errno == EMFILE or errno == ENFILE or errno == ENOMEM){
692
error(0, errno, "fopen");
693
exitstatus = EX_OSERR;
554
/* If there was any arguments from configuration file,
555
pass them to parser as command arguments */
697
/* If there were any arguments from the configuration file, pass
698
them to parser as command line arguments */
556
699
if(custom_argv != NULL){
557
ret = argp_parse (&argp, custom_argc, custom_argv, 0, 0, NULL);
558
if (ret == ARGP_ERR_UNKNOWN){
559
fprintf(stderr, "Unknown error while parsing arguments\n");
560
exitstatus = EXIT_FAILURE;
700
ret = argp_parse(&argp, custom_argc, custom_argv,
701
ARGP_IN_ORDER | ARGP_NO_EXIT | ARGP_NO_HELP,
709
error(0, errno, "argp_parse");
710
exitstatus = EX_OSERR;
713
exitstatus = EX_CONFIG;
718
/* Parse actual command line arguments, to let them override the
720
ret = argp_parse(&argp, argc, argv,
721
ARGP_IN_ORDER | ARGP_NO_EXIT | ARGP_NO_HELP,
729
error(0, errno, "argp_parse");
730
exitstatus = EX_OSERR;
733
exitstatus = EX_USAGE;
566
738
for(plugin *p = plugin_list; p != NULL; p=p->next){
567
739
fprintf(stderr, "Plugin: %s has %d arguments\n",
569
741
for(char **a = p->argv; *a != NULL; a++){
570
742
fprintf(stderr, "\tArg: %s\n", *a);
572
fprintf(stderr, "...and %u environment variables\n", p->envc);
744
fprintf(stderr, "...and %d environment variables\n", p->envc);
573
745
for(char **a = p->environ; *a != NULL; a++){
574
746
fprintf(stderr, "\t%s\n", *a);
579
/* Strip permissions down to nobody */
752
/* Work around Debian bug #633582:
753
<http://bugs.debian.org/633582> */
754
int plugindir_fd = open(/* plugindir or */ PDIR, O_RDONLY);
755
if(plugindir_fd == -1){
756
error(0, errno, "open");
758
ret = (int)TEMP_FAILURE_RETRY(fstat(plugindir_fd, &st));
760
error(0, errno, "fstat");
762
if(S_ISDIR(st.st_mode) and st.st_uid == 0 and st.st_gid == 0){
763
ret = fchown(plugindir_fd, uid, gid);
765
error(0, errno, "fchown");
769
TEMP_FAILURE_RETRY(close(plugindir_fd));
773
/* Lower permissions */
776
error(0, errno, "setgid");
580
778
ret = setuid(uid);
589
if (plugindir == NULL){
592
dir = opendir(plugindir);
596
perror("Could not open plugin dir");
597
exitstatus = EXIT_FAILURE;
601
/* Set the FD_CLOEXEC flag on the directory, if possible */
780
error(0, errno, "setuid");
783
/* Open plugin directory with close_on_exec flag */
603
int dir_fd = dirfd(dir);
605
ret = set_cloexec_flag(dir_fd);
607
perror("set_cloexec_flag");
608
exitstatus = EXIT_FAILURE;
786
if(plugindir == NULL){
787
dir_fd = open(PDIR, O_RDONLY |
790
#else /* not O_CLOEXEC */
792
#endif /* not O_CLOEXEC */
795
dir_fd = open(plugindir, O_RDONLY |
798
#else /* not O_CLOEXEC */
800
#endif /* not O_CLOEXEC */
804
error(0, errno, "Could not open plugin dir");
805
exitstatus = EX_UNAVAILABLE;
810
/* Set the FD_CLOEXEC flag on the directory */
811
ret = set_cloexec_flag(dir_fd);
813
error(0, errno, "set_cloexec_flag");
814
TEMP_FAILURE_RETRY(close(dir_fd));
815
exitstatus = EX_OSERR;
818
#endif /* O_CLOEXEC */
820
dir = fdopendir(dir_fd);
822
error(0, errno, "Could not open plugin dir");
823
TEMP_FAILURE_RETRY(close(dir_fd));
824
exitstatus = EX_OSERR;
614
829
FD_ZERO(&rfds_all);
616
831
/* Read and execute any executable in the plugin directory*/
618
dirst = readdir(dir);
834
dirst = readdir(dir);
835
} while(dirst == NULL and errno == EINTR);
620
// All directory entries have been processed
837
/* All directory entries have been processed */
621
838
if(dirst == NULL){
624
exitstatus = EXIT_FAILURE;
840
error(0, errno, "readdir");
841
exitstatus = EX_IOERR;
733
959
if(p->environ[0] != NULL){
734
960
for(char **e = environ; *e != NULL; e++){
735
char *copy = strdup(*e);
740
if(not add_environment(p, copy)){
741
perror("add_environment");
961
if(not add_environment(p, *e, false)){
962
error(0, errno, "add_environment");
750
exitstatus = EXIT_FAILURE;
968
ret = (int)TEMP_FAILURE_RETRY(pipe(pipefd));
970
error(0, errno, "pipe");
971
exitstatus = EX_OSERR;
753
974
/* Ask OS to automatic close the pipe on exec */
754
975
ret = set_cloexec_flag(pipefd[0]);
756
perror("set_cloexec_flag");
757
exitstatus = EXIT_FAILURE;
977
error(0, errno, "set_cloexec_flag");
978
exitstatus = EX_OSERR;
760
981
ret = set_cloexec_flag(pipefd[1]);
762
perror("set_cloexec_flag");
763
exitstatus = EXIT_FAILURE;
983
error(0, errno, "set_cloexec_flag");
984
exitstatus = EX_OSERR;
766
987
/* Block SIGCHLD until process is safely in process list */
767
ret = sigprocmask (SIG_BLOCK, &sigchld_action.sa_mask, NULL);
988
ret = (int)TEMP_FAILURE_RETRY(sigprocmask(SIG_BLOCK,
989
&sigchld_action.sa_mask,
769
perror("sigprocmask");
770
exitstatus = EXIT_FAILURE;
992
error(0, errno, "sigprocmask");
993
exitstatus = EX_OSERR;
773
// Starting a new process to be watched
996
/* Starting a new process to be watched */
1000
} while(pid == -1 and errno == EINTR);
777
exitstatus = EXIT_FAILURE;
1002
error(0, errno, "fork");
1003
exitstatus = EX_OSERR;
781
1007
/* this is the child process */
782
1008
ret = sigaction(SIGCHLD, &old_sigchld_action, NULL);
1010
error(0, errno, "sigaction");
787
ret = sigprocmask (SIG_UNBLOCK, &sigchld_action.sa_mask, NULL);
1013
ret = sigprocmask(SIG_UNBLOCK, &sigchld_action.sa_mask, NULL);
789
perror("sigprocmask");
1015
error(0, errno, "sigprocmask");
793
1019
ret = dup2(pipefd[1], STDOUT_FILENO); /* replace our stdout */
1021
error(0, errno, "dup2");
799
1025
if(dirfd(dir) < 0){
861
1105
free_plugin_list();
865
1109
/* Main loop while running plugins exist */
866
1110
while(plugin_list){
867
1111
fd_set rfds = rfds_all;
868
1112
int select_ret = select(maxfd+1, &rfds, NULL, NULL, NULL);
869
if (select_ret == -1){
871
exitstatus = EXIT_FAILURE;
1113
if(select_ret == -1 and errno != EINTR){
1114
error(0, errno, "select");
1115
exitstatus = EX_OSERR;
874
1118
/* OK, now either a process completed, or something can be read
875
1119
from one of them */
876
for(plugin *proc = plugin_list; proc != NULL; proc = proc->next){
1120
for(plugin *proc = plugin_list; proc != NULL;){
877
1121
/* Is this process completely done? */
878
if(proc->eof and proc->completed){
1122
if(proc->completed and proc->eof){
879
1123
/* Only accept the plugin output if it exited cleanly */
880
1124
if(not WIFEXITED(proc->status)
881
1125
or WEXITSTATUS(proc->status) != 0){
882
1126
/* Bad exit by plugin */
885
1129
if(WIFEXITED(proc->status)){
886
fprintf(stderr, "Plugin %u exited with status %d\n",
887
(unsigned int) (proc->pid),
1130
fprintf(stderr, "Plugin %s [%" PRIdMAX "] exited with"
1131
" status %d\n", proc->name,
1132
(intmax_t) (proc->pid),
888
1133
WEXITSTATUS(proc->status));
889
} else if(WIFSIGNALED(proc->status)) {
890
fprintf(stderr, "Plugin %u killed by signal %d\n",
891
(unsigned int) (proc->pid),
892
WTERMSIG(proc->status));
1134
} else if(WIFSIGNALED(proc->status)){
1135
fprintf(stderr, "Plugin %s [%" PRIdMAX "] killed by"
1136
" signal %d: %s\n", proc->name,
1137
(intmax_t) (proc->pid),
1138
WTERMSIG(proc->status),
1139
strsignal(WTERMSIG(proc->status)));
893
1140
} else if(WCOREDUMP(proc->status)){
894
fprintf(stderr, "Plugin %d dumped core\n",
895
(unsigned int) (proc->pid));
1141
fprintf(stderr, "Plugin %s [%" PRIdMAX "] dumped"
1142
" core\n", proc->name, (intmax_t) (proc->pid));
899
1146
/* Remove the plugin */
900
FD_CLR(proc->fd, &rfds_all);
1147
#if defined (__GNUC__) and defined (__GLIBC__)
1148
#if not __GLIBC_PREREQ(2, 16)
1149
#pragma GCC diagnostic push
1150
#pragma GCC diagnostic ignored "-Wsign-conversion"
1153
FD_CLR(proc->fd, &rfds_all); /* Spurious warning from
1154
-Wconversion in GNU libc
1156
#if defined (__GNUC__) and defined (__GLIBC__)
1157
#if not __GLIBC_PREREQ(2, 16)
1158
#pragma GCC diagnostic pop
902
1162
/* Block signal while modifying process_list */
903
ret = sigprocmask(SIG_BLOCK, &sigchld_action.sa_mask, NULL);
1163
ret = (int)TEMP_FAILURE_RETRY(sigprocmask
1165
&sigchld_action.sa_mask,
905
perror("sigprocmask");
906
exitstatus = EXIT_FAILURE;
1168
error(0, errno, "sigprocmask");
1169
exitstatus = EX_OSERR;
1173
plugin *next_plugin = proc->next;
909
1174
free_plugin(proc);
910
1177
/* We are done modifying process list, so unblock signal */
911
ret = sigprocmask (SIG_UNBLOCK, &sigchld_action.sa_mask,
1178
ret = (int)(TEMP_FAILURE_RETRY
1179
(sigprocmask(SIG_UNBLOCK,
1180
&sigchld_action.sa_mask, NULL)));
914
perror("sigprocmask");
915
exitstatus = EXIT_FAILURE;
1182
error(0, errno, "sigprocmask");
1183
exitstatus = EX_OSERR;
919
1187
if(plugin_list == NULL){
925
1194
/* This process exited nicely, so print its buffer */
927
1196
bool bret = print_out_password(proc->buffer,
928
1197
proc->buffer_length);
930
perror("print_out_password");
931
exitstatus = EXIT_FAILURE;
1199
error(0, errno, "print_out_password");
1200
exitstatus = EX_IOERR;
936
1205
/* This process has not completed. Does it have any output? */
937
if(proc->eof or not FD_ISSET(proc->fd, &rfds)){
1206
#if defined (__GNUC__) and defined (__GLIBC__)
1207
#if not __GLIBC_PREREQ(2, 16)
1208
#pragma GCC diagnostic push
1209
#pragma GCC diagnostic ignored "-Wsign-conversion"
1212
if(proc->eof or not FD_ISSET(proc->fd, &rfds)){ /* Spurious
1218
#if defined (__GNUC__) and defined (__GLIBC__)
1219
#if not __GLIBC_PREREQ(2, 16)
1220
#pragma GCC diagnostic pop
938
1223
/* This process had nothing to say at this time */
941
1227
/* Before reading, make the process' data buffer large enough */
942
1228
if(proc->buffer_length + BUFFER_SIZE > proc->buffer_size){
943
1229
proc->buffer = realloc(proc->buffer, proc->buffer_size
944
1230
+ (size_t) BUFFER_SIZE);
945
if (proc->buffer == NULL){
947
exitstatus = EXIT_FAILURE;
1231
if(proc->buffer == NULL){
1232
error(0, errno, "malloc");
1233
exitstatus = EX_OSERR;
950
1236
proc->buffer_size += BUFFER_SIZE;
952
1238
/* Read from the process */
953
ret = read(proc->fd, proc->buffer + proc->buffer_length,
1239
sret = TEMP_FAILURE_RETRY(read(proc->fd,
1241
+ proc->buffer_length,
956
1244
/* Read error from this process; ignore the error */
961
1250
proc->eof = true;
963
proc->buffer_length += (size_t) ret;
1252
proc->buffer_length += (size_t) sret;
971
if(plugin_list == NULL or exitstatus != EXIT_SUCCESS){
1260
if(plugin_list == NULL or (exitstatus != EXIT_SUCCESS
1261
and exitstatus != EX_OK)){
972
1262
/* Fallback if all plugins failed, none are found or an error
975
1265
fprintf(stderr, "Going to fallback mode using getpass(3)\n");
976
1266
char *passwordbuffer = getpass("Password: ");
977
bret = print_out_password(passwordbuffer, strlen(passwordbuffer));
1267
size_t len = strlen(passwordbuffer);
1268
/* Strip trailing newline */
1269
if(len > 0 and passwordbuffer[len-1] == '\n'){
1270
passwordbuffer[len-1] = '\0'; /* not strictly necessary */
1273
bret = print_out_password(passwordbuffer, len);
979
perror("print_out_password");
980
exitstatus = EXIT_FAILURE;
1275
error(0, errno, "print_out_password");
1276
exitstatus = EX_IOERR;
984
1280
/* Restore old signal handler */
985
1281
ret = sigaction(SIGCHLD, &old_sigchld_action, NULL);
988
exitstatus = EXIT_FAILURE;
1283
error(0, errno, "sigaction");
1284
exitstatus = EX_OSERR;
991
1287
if(custom_argv != NULL){
992
1288
for(char **arg = custom_argv+1; *arg != NULL; arg++){