/mandos/trunk

To get this branch, use:
bzr branch http://bzr.recompile.se/loggerhead/mandos/trunk

« back to all changes in this revision

Viewing changes to mandos-monitor

  • Committer: Teddy Hogeborn
  • Date: 2012-05-07 20:46:51 UTC
  • Revision ID: teddy@recompile.se-20120507204651-qx5o5ztwmau54mh4
* mandos-monitor: Speedup: Use properties from D-Bus
                  GetAllClientsWithProperties() call.  Also use
                  super() properly - only use keyword arguments and
                  strip them off as "kwargs" is passed on.
  (MandosClientPropertyCache.__init__): Take new "properties"
                                        argument; use it to skip
                                        calling D-Bus GetAll() method.
                                        Call super().  Bind self._
  (MandosClientPropertyCache._property_changed): New helper function.
  (MandosClientPropertyCache.property_changed): Changed to take
                                                keyword arguments.
  (MandosClientPropertyCache.delete): Bug fix: Don't call
                                      super().__init__().
  (MandosClientWidget.__init__): Don't take *args.  Strip used keyword
                                 arguments before calling super().
  (MandosClientWidget.property_changed): Removed dead code.
  (MandosClientWidget.delete): Don't take *args.
  (MandosClientWidget.property_changed): Don't take "value" argument,
                                         since it is not used.
  (ConstrainedListBox.keypress): Take *args, **kwargs and pass them on
                                 to super().

Show diffs side-by-side

added added

removed removed

Lines of Context:
mandos-monitor
3
3
# 
4
4
# Mandos Monitor - Control and monitor the Mandos server
5
5
# 
6
 
# Copyright © 2009-2015 Teddy Hogeborn
7
 
# Copyright © 2009-2015 Björn Påhlsson
 
6
# Copyright © 2009-2012 Teddy Hogeborn
 
7
# Copyright © 2009-2012 Björn Påhlsson
8
8
# 
9
9
# This program is free software: you can redistribute it and/or modify
10
10
# it under the terms of the GNU General Public License as published by
25
25
 
26
26
from __future__ import (division, absolute_import, print_function,
27
27
                        unicode_literals)
28
 
try:
29
 
    from future_builtins import *
30
 
except ImportError:
31
 
    pass
 
28
 
 
29
from future_builtins import *
32
30
 
33
31
import sys
34
32
import os
 
33
import signal
35
34
 
36
35
import datetime
37
36
 
39
38
import urwid
40
39
 
41
40
from dbus.mainloop.glib import DBusGMainLoop
42
 
try:
43
 
    import gobject
44
 
except ImportError:
45
 
    from gi.repository import GObject as gobject
 
41
import gobject
46
42
 
47
43
import dbus
48
44
 
 
45
import UserList
 
46
 
49
47
import locale
50
48
 
51
 
if sys.version_info.major == 2:
52
 
    str = unicode
53
 
 
54
49
locale.setlocale(locale.LC_ALL, '')
55
50
 
56
51
import logging
60
55
domain = 'se.recompile'
61
56
server_interface = domain + '.Mandos'
62
57
client_interface = domain + '.Mandos.Client'
63
 
version = "1.6.9"
 
58
version = "1.5.3"
 
59
 
 
60
# Always run in monochrome mode
 
61
urwid.curses_display.curses.has_colors = lambda : False
 
62
 
 
63
# Urwid doesn't support blinking, but we want it.  Since we have no
 
64
# use for underline on its own, we make underline also always blink.
 
65
urwid.curses_display.curses.A_UNDERLINE |= (
 
66
    urwid.curses_display.curses.A_BLINK)
64
67
 
65
68
def isoformat_to_datetime(iso):
66
69
    "Parse an ISO 8601 date string to a datetime.datetime()"
87
90
        self.proxy = proxy_object # Mandos Client proxy object
88
91
        self.properties = dict() if properties is None else properties
89
92
        self.property_changed_match = (
90
 
            self.proxy.connect_to_signal("PropertiesChanged",
91
 
                                         self.properties_changed,
92
 
                                         dbus.PROPERTIES_IFACE,
 
93
            self.proxy.connect_to_signal("PropertyChanged",
 
94
                                         self._property_changed,
 
95
                                         client_interface,
93
96
                                         byte_arrays=True))
94
97
        
95
98
        if properties is None:
100
103
        
101
104
        super(MandosClientPropertyCache, self).__init__(**kwargs)
102
105
    
103
 
    def properties_changed(self, interface, properties, invalidated):
104
 
        """This is called whenever we get a PropertiesChanged signal
105
 
        It updates the changed properties in the "properties" dict.
 
106
    def _property_changed(self, property, value):
 
107
        """Helper which takes positional arguments"""
 
108
        return self.property_changed(property=property, value=value)
 
109
    
 
110
    def property_changed(self, property=None, value=None):
 
111
        """This is called whenever we get a PropertyChanged signal
 
112
        It updates the changed property in the "properties" dict.
106
113
        """
107
114
        # Update properties dict with new value
108
 
        self.properties.update(properties)
 
115
        self.properties[property] = value
109
116
    
110
117
    def delete(self):
111
118
        self.property_changed_match.remove()
127
134
        self.logger = logger
128
135
        
129
136
        self._update_timer_callback_tag = None
 
137
        self._update_timer_callback_lock = 0
130
138
        
131
139
        # The widget shown normally
132
140
        self._text_widget = urwid.Text("")
136
144
        self.update()
137
145
        self.opened = False
138
146
        
 
147
        last_checked_ok = isoformat_to_datetime(self.properties
 
148
                                                ["LastCheckedOK"])
 
149
        
 
150
        if self.properties ["LastCheckerStatus"] != 0:
 
151
            self.using_timer(True)
 
152
        
 
153
        if self.need_approval:
 
154
            self.using_timer(True)
 
155
        
139
156
        self.match_objects = (
140
157
            self.proxy.connect_to_signal("CheckerCompleted",
141
158
                                         self.checker_completed,
157
174
                                         self.rejected,
158
175
                                         client_interface,
159
176
                                         byte_arrays=True))
160
 
        self.logger('Created client {}'
161
 
                    .format(self.properties["Name"]), level=0)
 
177
        #self.logger('Created client {0}'
 
178
        #            .format(self.properties["Name"]))
 
179
    
 
180
    def property_changed(self, property=None, value=None):
 
181
        super(self, MandosClientWidget).property_changed(property,
 
182
                                                         value)
 
183
        if property == "ApprovalPending":
 
184
            using_timer(bool(value))
 
185
        if property == "LastCheckerStatus":
 
186
            using_timer(value != 0)
 
187
            #self.logger('Checker for client {0} (command "{1}") was '
 
188
            #            ' successful'.format(self.properties["Name"],
 
189
            #                                 command))
162
190
    
163
191
    def using_timer(self, flag):
164
192
        """Call this method with True or False when timer should be
165
193
        activated or deactivated.
166
194
        """
167
 
        if flag and self._update_timer_callback_tag is None:
 
195
        old = self._update_timer_callback_lock
 
196
        if flag:
 
197
            self._update_timer_callback_lock += 1
 
198
        else:
 
199
            self._update_timer_callback_lock -= 1
 
200
        if old == 0 and self._update_timer_callback_lock:
168
201
            # Will update the shown timer value every second
169
202
            self._update_timer_callback_tag = (gobject.timeout_add
170
203
                                               (1000,
171
204
                                                self.update_timer))
172
 
        elif not (flag or self._update_timer_callback_tag is None):
 
205
        elif old and self._update_timer_callback_lock == 0:
173
206
            gobject.source_remove(self._update_timer_callback_tag)
174
207
            self._update_timer_callback_tag = None
175
208
    
176
 
    def checker_completed(self, exitstatus, signal, command):
 
209
    def checker_completed(self, exitstatus, condition, command):
177
210
        if exitstatus == 0:
178
 
            self.logger('Checker for client {} (command "{}")'
179
 
                        ' succeeded'.format(self.properties["Name"],
180
 
                                            command), level=0)
181
211
            self.update()
182
212
            return
183
213
        # Checker failed
184
 
        if exitstatus >= 0:
185
 
            self.logger('Checker for client {} (command "{}") failed'
186
 
                        ' with exit code {}'
187
 
                        .format(self.properties["Name"], command,
188
 
                                exitstatus))
189
 
        elif signal != 0:
190
 
            self.logger('Checker for client {} (command "{}") was'
191
 
                        ' killed by signal {}'
192
 
                        .format(self.properties["Name"], command,
193
 
                                signal))
 
214
        if os.WIFEXITED(condition):
 
215
            self.logger('Checker for client {0} (command "{1}")'
 
216
                        ' failed with exit code {2}'
 
217
                        .format(self.properties["Name"], command,
 
218
                                os.WEXITSTATUS(condition)))
 
219
        elif os.WIFSIGNALED(condition):
 
220
            self.logger('Checker for client {0} (command "{1}") was'
 
221
                        ' killed by signal {2}'
 
222
                        .format(self.properties["Name"], command,
 
223
                                os.WTERMSIG(condition)))
 
224
        elif os.WCOREDUMP(condition):
 
225
            self.logger('Checker for client {0} (command "{1}")'
 
226
                        ' dumped core'
 
227
                        .format(self.properties["Name"], command))
194
228
        else:
195
 
            self.logger('Checker for client {} completed'
 
229
            self.logger('Checker for client {0} completed'
196
230
                        ' mysteriously'
197
231
                        .format(self.properties["Name"]))
198
232
        self.update()
199
233
    
200
234
    def checker_started(self, command):
201
 
        """Server signals that a checker started."""
202
 
        self.logger('Client {} started checker "{}"'
203
 
                    .format(self.properties["Name"],
204
 
                            command), level=0)
 
235
        """Server signals that a checker started. This could be useful
 
236
           to log in the future. """
 
237
        #self.logger('Client {0} started checker "{1}"'
 
238
        #            .format(self.properties["Name"],
 
239
        #                    unicode(command)))
 
240
        pass
205
241
    
206
242
    def got_secret(self):
207
 
        self.logger('Client {} received its secret'
 
243
        self.logger('Client {0} received its secret'
208
244
                    .format(self.properties["Name"]))
209
245
    
210
246
    def need_approval(self, timeout, default):
211
247
        if not default:
212
 
            message = 'Client {} needs approval within {} seconds'
 
248
            message = 'Client {0} needs approval within {1} seconds'
213
249
        else:
214
 
            message = 'Client {} will get its secret in {} seconds'
 
250
            message = 'Client {0} will get its secret in {1} seconds'
215
251
        self.logger(message.format(self.properties["Name"],
216
252
                                   timeout/1000))
 
253
        self.using_timer(True)
217
254
    
218
255
    def rejected(self, reason):
219
 
        self.logger('Client {} was rejected; reason: {}'
 
256
        self.logger('Client {0} was rejected; reason: {1}'
220
257
                    .format(self.properties["Name"], reason))
221
258
    
222
259
    def selectable(self):
245
282
                          "bold-underline-blink":
246
283
                              "bold-underline-blink-standout",
247
284
                          }
248
 
        
 
285
 
249
286
        # Rebuild focus and non-focus widgets using current properties
250
 
        
 
287
 
251
288
        # Base part of a client. Name!
252
289
        base = '{name}: '.format(name=self.properties["Name"])
253
290
        if not self.properties["Enabled"]:
254
291
            message = "DISABLED"
255
 
            self.using_timer(False)
256
292
        elif self.properties["ApprovalPending"]:
257
293
            timeout = datetime.timedelta(milliseconds
258
294
                                         = self.properties
260
296
            last_approval_request = isoformat_to_datetime(
261
297
                self.properties["LastApprovalRequest"])
262
298
            if last_approval_request is not None:
263
 
                timer = max(timeout - (datetime.datetime.utcnow()
264
 
                                       - last_approval_request),
265
 
                            datetime.timedelta())
 
299
                timer = timeout - (datetime.datetime.utcnow()
 
300
                                   - last_approval_request)
266
301
            else:
267
302
                timer = datetime.timedelta()
268
303
            if self.properties["ApprovedByDefault"]:
269
 
                message = "Approval in {}. (d)eny?"
 
304
                message = "Approval in {0}. (d)eny?"
270
305
            else:
271
 
                message = "Denial in {}. (a)pprove?"
272
 
            message = message.format(str(timer).rsplit(".", 1)[0])
273
 
            self.using_timer(True)
 
306
                message = "Denial in {0}. (a)pprove?"
 
307
            message = message.format(unicode(timer).rsplit(".", 1)[0])
274
308
        elif self.properties["LastCheckerStatus"] != 0:
275
309
            # When checker has failed, show timer until client expires
276
310
            expires = self.properties["Expires"]
279
313
            else:
280
314
                expires = (datetime.datetime.strptime
281
315
                           (expires, '%Y-%m-%dT%H:%M:%S.%f'))
282
 
                timer = max(expires - datetime.datetime.utcnow(),
283
 
                            datetime.timedelta())
 
316
                timer = expires - datetime.datetime.utcnow()
284
317
            message = ('A checker has failed! Time until client'
285
 
                       ' gets disabled: {}'
286
 
                       .format(str(timer).rsplit(".", 1)[0]))
287
 
            self.using_timer(True)
 
318
                       ' gets disabled: {0}'
 
319
                       .format(unicode(timer).rsplit(".", 1)[0]))
288
320
        else:
289
321
            message = "enabled"
290
 
            self.using_timer(False)
291
 
        self._text = "{}{}".format(base, message)
292
 
        
 
322
        self._text = "{0}{1}".format(base, message)
 
323
            
293
324
        if not urwid.supports_unicode():
294
325
            self._text = self._text.encode("ascii", "replace")
295
326
        textlist = [("normal", self._text)]
369
400
        else:
370
401
            return key
371
402
    
372
 
    def properties_changed(self, interface, properties, invalidated):
373
 
        """Call self.update() if any properties changed.
 
403
    def property_changed(self, property=None, **kwargs):
 
404
        """Call self.update() if old value is not new value.
374
405
        This overrides the method from MandosClientPropertyCache"""
375
 
        old_values = { key: self.properties.get(key)
376
 
                       for key in properties.keys() }
377
 
        super(MandosClientWidget, self).properties_changed(
378
 
            interface, properties, invalidated)
379
 
        if any(old_values[key] != self.properties.get(key)
380
 
               for key in old_values):
 
406
        property_name = unicode(property)
 
407
        old_value = self.properties.get(property_name)
 
408
        super(MandosClientWidget, self).property_changed(
 
409
            property=property, **kwargs)
 
410
        if self.properties.get(property_name) != old_value:
381
411
            self.update()
382
412
 
383
413
 
397
427
    """This is the entire user interface - the whole screen
398
428
    with boxes, lists of client widgets, etc.
399
429
    """
400
 
    def __init__(self, max_log_length=1000, log_level=1):
 
430
    def __init__(self, max_log_length=1000):
401
431
        DBusGMainLoop(set_as_default=True)
402
432
        
403
433
        self.screen = urwid.curses_display.Screen()
406
436
                ("normal",
407
437
                 "default", "default", None),
408
438
                ("bold",
409
 
                 "bold", "default", "bold"),
 
439
                 "default", "default", "bold"),
410
440
                ("underline-blink",
411
 
                 "underline,blink", "default", "underline,blink"),
 
441
                 "default", "default", "underline"),
412
442
                ("standout",
413
 
                 "standout", "default", "standout"),
 
443
                 "default", "default", "standout"),
414
444
                ("bold-underline-blink",
415
 
                 "bold,underline,blink", "default", "bold,underline,blink"),
 
445
                 "default", "default", ("bold", "underline")),
416
446
                ("bold-standout",
417
 
                 "bold,standout", "default", "bold,standout"),
 
447
                 "default", "default", ("bold", "standout")),
418
448
                ("underline-blink-standout",
419
 
                 "underline,blink,standout", "default",
420
 
                 "underline,blink,standout"),
 
449
                 "default", "default", ("underline", "standout")),
421
450
                ("bold-underline-blink-standout",
422
 
                 "bold,underline,blink,standout", "default",
423
 
                 "bold,underline,blink,standout"),
 
451
                 "default", "default", ("bold", "underline",
 
452
                                          "standout")),
424
453
                ))
425
454
        
426
455
        if urwid.supports_unicode():
441
470
        self.log = []
442
471
        self.max_log_length = max_log_length
443
472
        
444
 
        self.log_level = log_level
445
 
        
446
473
        # We keep a reference to the log widget so we can remove it
447
474
        # from the ListWalker without it getting destroyed
448
475
        self.logbox = ConstrainedListBox(self.log)
462
489
        self.main_loop = gobject.MainLoop()
463
490
    
464
491
    def client_not_found(self, fingerprint, address):
465
 
        self.log_message("Client with address {} and fingerprint {}"
466
 
                         " could not be found"
 
492
        self.log_message("Client with address {0} and fingerprint"
 
493
                         " {1} could not be found"
467
494
                         .format(address, fingerprint))
468
495
    
469
496
    def rebuild(self):
482
509
            self.uilist.append(self.logbox)
483
510
        self.topwidget = urwid.Pile(self.uilist)
484
511
    
485
 
    def log_message(self, message, level=1):
486
 
        """Log message formatted with timestamp"""
487
 
        if level < self.log_level:
488
 
            return
 
512
    def log_message(self, message):
489
513
        timestamp = datetime.datetime.now().isoformat()
490
 
        self.log_message_raw("{}: {}".format(timestamp, message),
491
 
                             level=level)
 
514
        self.log_message_raw(timestamp + ": " + message)
492
515
    
493
 
    def log_message_raw(self, markup, level=1):
 
516
    def log_message_raw(self, markup):
494
517
        """Add a log message to the log buffer."""
495
 
        if level < self.log_level:
496
 
            return
497
518
        self.log.append(urwid.Text(markup, wrap=self.log_wrap))
498
519
        if (self.max_log_length
499
520
            and len(self.log) > self.max_log_length):
506
527
        """Toggle visibility of the log buffer."""
507
528
        self.log_visible = not self.log_visible
508
529
        self.rebuild()
509
 
        self.log_message("Log visibility changed to: {}"
510
 
                         .format(self.log_visible), level=0)
 
530
        #self.log_message("Log visibility changed to: "
 
531
        #                 + unicode(self.log_visible))
511
532
    
512
533
    def change_log_display(self):
513
534
        """Change type of log display.
518
539
            self.log_wrap = "clip"
519
540
        for textwidget in self.log:
520
541
            textwidget.set_wrap_mode(self.log_wrap)
521
 
        self.log_message("Wrap mode: {}".format(self.log_wrap),
522
 
                         level=0)
 
542
        #self.log_message("Wrap mode: " + self.log_wrap)
523
543
    
524
544
    def find_and_remove_client(self, path, name):
525
545
        """Find a client by its object path and remove it.
530
550
            client = self.clients_dict[path]
531
551
        except KeyError:
532
552
            # not found?
533
 
            self.log_message("Unknown client {!r} ({!r}) removed"
 
553
            self.log_message("Unknown client {0!r} ({1!r}) removed"
534
554
                             .format(name, path))
535
555
            return
536
556
        client.delete()
554
574
        if path is None:
555
575
            path = client.proxy.object_path
556
576
        self.clients_dict[path] = client
557
 
        self.clients.sort(key=lambda c: c.properties["Name"])
 
577
        self.clients.sort(None, lambda c: c.properties["Name"])
558
578
        self.refresh()
559
579
    
560
580
    def remove_client(self, client, path=None):
562
582
        if path is None:
563
583
            path = client.proxy.object_path
564
584
        del self.clients_dict[path]
 
585
        if not self.clients_dict:
 
586
            # Work around bug in Urwid 0.9.8.3 - if a SimpleListWalker
 
587
            # is completely emptied, we need to recreate it.
 
588
            self.clients = urwid.SimpleListWalker([])
 
589
            self.rebuild()
565
590
        self.refresh()
566
591
    
567
592
    def refresh(self):
580
605
        try:
581
606
            mandos_clients = (self.mandos_serv
582
607
                              .GetAllClientsWithProperties())
583
 
            if not mandos_clients:
584
 
                self.log_message_raw(("bold", "Note: Server has no clients."))
585
608
        except dbus.exceptions.DBusException:
586
 
            self.log_message_raw(("bold", "Note: No Mandos server running."))
587
609
            mandos_clients = dbus.Dictionary()
588
610
        
589
611
        (self.mandos_serv
601
623
                            self.client_not_found,
602
624
                            dbus_interface=server_interface,
603
625
                            byte_arrays=True))
604
 
        for path, client in mandos_clients.items():
 
626
        for path, client in mandos_clients.iteritems():
605
627
            client_proxy_object = self.bus.get_object(self.busname,
606
628
                                                      path)
607
629
            self.add_client(MandosClientWidget(server_proxy_object
654
676
            elif key == "window resize":
655
677
                self.size = self.screen.get_cols_rows()
656
678
                self.refresh()
657
 
            elif key == "ctrl l":
658
 
                self.screen.clear()
 
679
            elif key == "\f":  # Ctrl-L
659
680
                self.refresh()
660
681
            elif key == "l" or key == "D":
661
682
                self.toggle_log_display()
673
694
                                            "?: Help",
674
695
                                            "l: Log window toggle",
675
696
                                            "TAB: Switch window",
676
 
                                            "w: Wrap (log lines)",
677
 
                                            "v: Toggle verbose log",
678
 
                                            ))))
 
697
                                            "w: Wrap (log)"))))
679
698
                self.log_message_raw(("bold",
680
699
                                      "  "
681
700
                                      .join(("Clients:",
694
713
                else:
695
714
                    self.topwidget.set_focus(self.logbox)
696
715
                self.refresh()
697
 
            elif key == "v":
698
 
                if self.log_level == 0:
699
 
                    self.log_level = 1
700
 
                    self.log_message("Verbose mode: Off")
701
 
                else:
702
 
                    self.log_level = 0
703
 
                    self.log_message("Verbose mode: On")
704
716
            #elif (key == "end" or key == "meta >" or key == "G"
705
717
            #      or key == ">"):
706
718
            #    pass            # xxx end-of-buffer
729
741
    ui.run()
730
742
except KeyboardInterrupt:
731
743
    ui.screen.stop()
732
 
except Exception as e:
733
 
    ui.log_message(str(e))
 
744
except Exception, e:
 
745
    ui.log_message(unicode(e))
734
746
    ui.screen.stop()
735
747
    raise