18
19
* along with this program. If not, see
19
20
* <http://www.gnu.org/licenses/>.
21
* Contact the authors at <mandos@fukt.bsnet.se>.
22
* Contact the authors at <mandos@recompile.se>.
24
25
#define _GNU_SOURCE /* TEMP_FAILURE_RETRY(), getline(),
26
asprintf(), O_CLOEXEC */
26
27
#include <stddef.h> /* size_t, NULL */
27
#include <stdlib.h> /* malloc(), exit(), EXIT_FAILURE,
28
EXIT_SUCCESS, realloc() */
28
#include <stdlib.h> /* malloc(), exit(), EXIT_SUCCESS,
29
30
#include <stdbool.h> /* bool, true, false */
30
#include <stdio.h> /* perror, popen(), fileno(),
31
fprintf(), stderr, STDOUT_FILENO */
32
#include <sys/types.h> /* DIR, opendir(), stat(), struct
31
#include <stdio.h> /* fileno(), fprintf(),
32
stderr, STDOUT_FILENO */
33
#include <sys/types.h> /* DIR, fdopendir(), stat(), struct
33
34
stat, waitpid(), WIFEXITED(),
34
35
WEXITSTATUS(), wait(), pid_t,
35
36
uid_t, gid_t, getuid(), getgid(),
37
38
#include <sys/select.h> /* fd_set, select(), FD_ZERO(),
38
39
FD_SET(), FD_ISSET(), FD_CLR */
39
40
#include <sys/wait.h> /* wait(), waitpid(), WIFEXITED(),
41
WEXITSTATUS(), WTERMSIG(),
41
43
#include <sys/stat.h> /* struct stat, stat(), S_ISREG() */
42
44
#include <iso646.h> /* and, or, not */
43
#include <dirent.h> /* DIR, struct dirent, opendir(),
45
#include <dirent.h> /* DIR, struct dirent, fdopendir(),
44
46
readdir(), closedir(), dirfd() */
45
47
#include <unistd.h> /* struct stat, stat(), S_ISREG(),
46
48
fcntl(), setuid(), setgid(),
47
49
F_GETFD, F_SETFD, FD_CLOEXEC,
48
50
access(), pipe(), fork(), close()
49
dup2, STDOUT_FILENO, _exit(),
51
dup2(), STDOUT_FILENO, _exit(),
50
52
execv(), write(), read(),
52
54
#include <fcntl.h> /* fcntl(), F_GETFD, F_SETFD,
54
#include <string.h> /* strsep, strlen(), asprintf() */
56
#include <string.h> /* strsep, strlen(), asprintf(),
57
strsignal(), strcmp(), strncmp() */
55
58
#include <errno.h> /* errno */
56
59
#include <argp.h> /* struct argp_option, struct
57
60
argp_state, struct argp,
61
64
#include <signal.h> /* struct sigaction, sigemptyset(),
62
65
sigaddset(), sigaction(),
63
66
sigprocmask(), SIG_BLOCK, SIGCHLD,
64
SIG_UNBLOCK, kill() */
67
SIG_UNBLOCK, kill(), sig_atomic_t
65
69
#include <errno.h> /* errno, EBADF */
70
#include <inttypes.h> /* intmax_t, PRIdMAX, strtoimax() */
71
#include <sysexits.h> /* EX_OSERR, EX_USAGE, EX_IOERR,
72
EX_CONFIG, EX_UNAVAILABLE, EX_OK */
73
#include <errno.h> /* errno */
74
#include <error.h> /* error() */
67
76
#define BUFFER_SIZE 256
69
78
#define PDIR "/lib/mandos/plugins.d"
70
79
#define AFILE "/conf/conf.d/mandos/plugin-runner.conf"
72
const char *argp_program_version = "plugin-runner 1.0";
73
const char *argp_program_bug_address = "<mandos@fukt.bsnet.se>";
81
const char *argp_program_version = "plugin-runner " VERSION;
82
const char *argp_program_bug_address = "<mandos@recompile.se>";
77
84
typedef struct plugin{
78
85
char *name; /* can be NULL or any plugin name */
99
106
/* Gets an existing plugin based on name,
100
107
or if none is found, creates a new one */
101
108
static plugin *getplugin(char *name){
102
/* Check for exiting plugin with that name */
103
for (plugin *p = plugin_list; p != NULL; p = p->next){
104
if ((p->name == name)
105
or (p->name and name and (strcmp(p->name, name) == 0))){
109
/* Check for existing plugin with that name */
110
for(plugin *p = plugin_list; p != NULL; p = p->next){
112
or (p->name and name and (strcmp(p->name, name) == 0))){
109
116
/* Create a new plugin */
110
plugin *new_plugin = malloc(sizeof(plugin));
111
if (new_plugin == NULL){
117
plugin *new_plugin = NULL;
119
new_plugin = malloc(sizeof(plugin));
120
} while(new_plugin == NULL and errno == EINTR);
121
if(new_plugin == NULL){
114
124
char *copy_name = NULL;
115
125
if(name != NULL){
116
copy_name = strdup(name);
127
copy_name = strdup(name);
128
} while(copy_name == NULL and errno == EINTR);
117
129
if(copy_name == NULL){
122
*new_plugin = (plugin) { .name = copy_name,
125
.next = plugin_list };
137
*new_plugin = (plugin){ .name = copy_name,
140
.next = plugin_list };
127
new_plugin->argv = malloc(sizeof(char *) * 2);
128
if (new_plugin->argv == NULL){
143
new_plugin->argv = malloc(sizeof(char *) * 2);
144
} while(new_plugin->argv == NULL and errno == EINTR);
145
if(new_plugin->argv == NULL){
130
148
free(new_plugin);
133
152
new_plugin->argv[0] = copy_name;
134
153
new_plugin->argv[1] = NULL;
136
new_plugin->environ = malloc(sizeof(char *));
156
new_plugin->environ = malloc(sizeof(char *));
157
} while(new_plugin->environ == NULL and errno == EINTR);
137
158
if(new_plugin->environ == NULL){
139
161
free(new_plugin->argv);
140
162
free(new_plugin);
143
166
new_plugin->environ[0] = NULL;
373
404
.doc = "Group ID the plugins will run as", .group = 3 },
374
405
{ .name = "debug", .key = 132,
375
406
.doc = "Debug mode", .group = 4 },
408
* These reproduce what we would get without ARGP_NO_HELP
410
{ .name = "help", .key = '?',
411
.doc = "Give this help list", .group = -1 },
412
{ .name = "usage", .key = -3,
413
.doc = "Give a short usage message", .group = -1 },
414
{ .name = "version", .key = 'V',
415
.doc = "Print program version", .group = -1 },
379
error_t parse_opt (int key, char *arg, __attribute__((unused))
380
struct argp_state *state) {
419
error_t parse_opt(int key, char *arg, struct argp_state *state){
382
424
case 'g': /* --global-options */
385
while((p = strsep(&arg, ",")) != NULL){
389
if(not add_argument(getplugin(NULL), p)){
390
perror("add_argument");
391
return ARGP_ERR_UNKNOWN;
427
while((plugin_option = strsep(&arg, ",")) != NULL){
428
if(not add_argument(getplugin(NULL), plugin_option)){
396
434
case 'G': /* --global-env */
400
if(not add_environment(getplugin(NULL), arg, true)){
401
perror("add_environment");
435
add_environment(getplugin(NULL), arg, true);
404
437
case 'o': /* --options-for */
406
char *p_name = strsep(&arg, ":");
407
if(p_name[0] == '\0' or arg == NULL){
410
char *opt = strsep(&arg, ":");
411
if(opt[0] == '\0' or opt == NULL){
415
while((p = strsep(&opt, ",")) != NULL){
419
if(not add_argument(getplugin(p_name), p)){
420
perror("add_argument");
421
return ARGP_ERR_UNKNOWN;
439
char *option_list = strchr(arg, ':');
440
if(option_list == NULL){
441
argp_error(state, "No colon in \"%s\"", arg);
448
argp_error(state, "Empty plugin name");
453
while((option = strsep(&option_list, ",")) != NULL){
454
if(not add_argument(getplugin(arg), option)){
426
460
case 'E': /* --env-for */
431
462
char *envdef = strchr(arg, ':');
432
463
if(envdef == NULL){
464
argp_error(state, "No colon in \"%s\"", arg);
436
if(not add_environment(getplugin(arg), envdef+1, true)){
437
perror("add_environment");
471
argp_error(state, "Empty plugin name");
475
add_environment(getplugin(arg), envdef, true);
441
478
case 'd': /* --disable */
443
480
plugin *p = getplugin(arg);
445
return ARGP_ERR_UNKNOWN;
450
486
case 'e': /* --enable */
452
488
plugin *p = getplugin(arg);
454
return ARGP_ERR_UNKNOWN;
459
494
case 128: /* --plugin-dir */
461
496
plugindir = strdup(arg);
462
if(plugindir == NULL){
466
498
case 129: /* --config-file */
467
499
/* This is already done by parse_opt_config_file() */
469
501
case 130: /* --userid */
470
uid = (uid_t)strtol(arg, NULL, 10);
502
tmpmax = strtoimax(arg, &tmp, 10);
503
if(errno != 0 or tmp == arg or *tmp != '\0'
504
or tmpmax != (uid_t)tmpmax){
505
argp_error(state, "Bad user ID number: \"%s\", using %"
506
PRIdMAX, arg, (intmax_t)uid);
472
511
case 131: /* --groupid */
473
gid = (gid_t)strtol(arg, NULL, 10);
512
tmpmax = strtoimax(arg, &tmp, 10);
513
if(errno != 0 or tmp == arg or *tmp != '\0'
514
or tmpmax != (gid_t)tmpmax){
515
argp_error(state, "Bad group ID number: \"%s\", using %"
516
PRIdMAX, arg, (intmax_t)gid);
475
521
case 132: /* --debug */
525
* These reproduce what we would get without ARGP_NO_HELP
527
case '?': /* --help */
528
state->flags &= ~(unsigned int)ARGP_NO_EXIT; /* force exit */
529
argp_state_help(state, state->out_stream, ARGP_HELP_STD_HELP);
530
case -3: /* --usage */
531
state->flags &= ~(unsigned int)ARGP_NO_EXIT; /* force exit */
532
argp_state_help(state, state->out_stream,
533
ARGP_HELP_USAGE | ARGP_HELP_EXIT_OK);
534
case 'V': /* --version */
535
fprintf(state->out_stream, "%s\n", argp_program_version);
539
* When adding more options before this line, remember to also add a
540
* "case" to the "parse_opt_config_file" function below.
478
542
case ARGP_KEY_ARG:
479
fprintf(stderr, "Ignoring unknown argument \"%s\"\n", arg);
543
/* Cryptsetup always passes an argument, which is an empty
544
string if "none" was specified in /etc/crypttab. So if
545
argument was empty, we ignore it silently. */
484
550
return ARGP_ERR_UNKNOWN;
552
return errno; /* Set to 0 at start */
489
555
/* This option parser is the same as parse_opt() above, except it
490
556
ignores everything but the --config-file option. */
491
error_t parse_opt_config_file (int key, char *arg,
492
__attribute__((unused))
493
struct argp_state *state) {
557
error_t parse_opt_config_file(int key, char *arg,
558
__attribute__((unused))
559
struct argp_state *state){
495
562
case 'g': /* --global-options */
496
563
case 'G': /* --global-env */
497
564
case 'o': /* --options-for */
586
661
custom_argv = realloc(custom_argv, sizeof(char *)
587
662
* ((unsigned int) custom_argc + 1));
588
663
if(custom_argv == NULL){
590
exitstatus = EXIT_FAILURE;
664
error(0, errno, "realloc");
665
exitstatus = EX_OSERR;
594
669
custom_argv[custom_argc-1] = new_arg;
595
custom_argv[custom_argc] = NULL;
670
custom_argv[custom_argc] = NULL;
674
ret = fclose(conffp);
675
} while(ret == EOF and errno == EINTR);
677
error(0, errno, "fclose");
678
exitstatus = EX_IOERR;
600
683
/* Check for harmful errors and go to fallback. Other errors might
601
684
not affect opening plugins */
602
if (errno == EMFILE or errno == ENFILE or errno == ENOMEM){
604
exitstatus = EXIT_FAILURE;
685
if(errno == EMFILE or errno == ENFILE or errno == ENOMEM){
686
error(0, errno, "fopen");
687
exitstatus = EX_OSERR;
608
/* If there was any arguments from configuration file,
609
pass them to parser as command arguments */
691
/* If there were any arguments from the configuration file, pass
692
them to parser as command line arguments */
610
693
if(custom_argv != NULL){
611
ret = argp_parse (&argp, custom_argc, custom_argv, ARGP_IN_ORDER,
613
if (ret == ARGP_ERR_UNKNOWN){
614
fprintf(stderr, "Unknown error while parsing arguments\n");
615
exitstatus = EXIT_FAILURE;
694
ret = argp_parse(&argp, custom_argc, custom_argv,
695
ARGP_IN_ORDER | ARGP_NO_EXIT | ARGP_NO_HELP,
703
error(0, errno, "argp_parse");
704
exitstatus = EX_OSERR;
707
exitstatus = EX_CONFIG;
620
712
/* Parse actual command line arguments, to let them override the
622
ret = argp_parse (&argp, argc, argv, ARGP_IN_ORDER, 0, NULL);
623
if (ret == ARGP_ERR_UNKNOWN){
624
fprintf(stderr, "Unknown error while parsing arguments\n");
625
exitstatus = EXIT_FAILURE;
714
ret = argp_parse(&argp, argc, argv,
715
ARGP_IN_ORDER | ARGP_NO_EXIT | ARGP_NO_HELP,
723
error(0, errno, "argp_parse");
724
exitstatus = EX_OSERR;
727
exitstatus = EX_USAGE;
633
735
for(char **a = p->argv; *a != NULL; a++){
634
736
fprintf(stderr, "\tArg: %s\n", *a);
636
fprintf(stderr, "...and %u environment variables\n", p->envc);
738
fprintf(stderr, "...and %d environment variables\n", p->envc);
637
739
for(char **a = p->environ; *a != NULL; a++){
638
740
fprintf(stderr, "\t%s\n", *a);
643
/* Strip permissions down to nobody */
746
/* Work around Debian bug #633582:
747
<http://bugs.debian.org/633582> */
748
int plugindir_fd = open(/* plugindir or */ PDIR, O_RDONLY);
749
if(plugindir_fd == -1){
750
error(0, errno, "open");
752
ret = (int)TEMP_FAILURE_RETRY(fstat(plugindir_fd, &st));
754
error(0, errno, "fstat");
756
if(S_ISDIR(st.st_mode) and st.st_uid == 0 and st.st_gid == 0){
757
ret = fchown(plugindir_fd, uid, gid);
759
error(0, errno, "fchown");
763
TEMP_FAILURE_RETRY(close(plugindir_fd));
767
/* Lower permissions */
770
error(0, errno, "setgid");
644
772
ret = setuid(uid);
653
if (plugindir == NULL){
656
dir = opendir(plugindir);
660
perror("Could not open plugin dir");
661
exitstatus = EXIT_FAILURE;
665
/* Set the FD_CLOEXEC flag on the directory, if possible */
774
error(0, errno, "setuid");
777
/* Open plugin directory with close_on_exec flag */
667
int dir_fd = dirfd(dir);
669
ret = set_cloexec_flag(dir_fd);
671
perror("set_cloexec_flag");
672
exitstatus = EXIT_FAILURE;
780
if(plugindir == NULL){
781
dir_fd = open(PDIR, O_RDONLY |
784
#else /* not O_CLOEXEC */
786
#endif /* not O_CLOEXEC */
789
dir_fd = open(plugindir, O_RDONLY |
792
#else /* not O_CLOEXEC */
794
#endif /* not O_CLOEXEC */
798
error(0, errno, "Could not open plugin dir");
799
exitstatus = EX_UNAVAILABLE;
804
/* Set the FD_CLOEXEC flag on the directory */
805
ret = set_cloexec_flag(dir_fd);
807
error(0, errno, "set_cloexec_flag");
808
TEMP_FAILURE_RETRY(close(dir_fd));
809
exitstatus = EX_OSERR;
812
#endif /* O_CLOEXEC */
814
dir = fdopendir(dir_fd);
816
error(0, errno, "Could not open plugin dir");
817
TEMP_FAILURE_RETRY(close(dir_fd));
818
exitstatus = EX_OSERR;
797
953
if(p->environ[0] != NULL){
798
954
for(char **e = environ; *e != NULL; e++){
799
955
if(not add_environment(p, *e, false)){
800
perror("add_environment");
956
error(0, errno, "add_environment");
809
exitstatus = EXIT_FAILURE;
962
ret = (int)TEMP_FAILURE_RETRY(pipe(pipefd));
964
error(0, errno, "pipe");
965
exitstatus = EX_OSERR;
812
968
/* Ask OS to automatic close the pipe on exec */
813
969
ret = set_cloexec_flag(pipefd[0]);
815
perror("set_cloexec_flag");
816
exitstatus = EXIT_FAILURE;
971
error(0, errno, "set_cloexec_flag");
972
exitstatus = EX_OSERR;
819
975
ret = set_cloexec_flag(pipefd[1]);
821
perror("set_cloexec_flag");
822
exitstatus = EXIT_FAILURE;
977
error(0, errno, "set_cloexec_flag");
978
exitstatus = EX_OSERR;
825
981
/* Block SIGCHLD until process is safely in process list */
826
ret = sigprocmask (SIG_BLOCK, &sigchld_action.sa_mask, NULL);
982
ret = (int)TEMP_FAILURE_RETRY(sigprocmask(SIG_BLOCK,
983
&sigchld_action.sa_mask,
828
perror("sigprocmask");
829
exitstatus = EXIT_FAILURE;
986
error(0, errno, "sigprocmask");
987
exitstatus = EX_OSERR;
832
990
/* Starting a new process to be watched */
994
} while(pid == -1 and errno == EINTR);
836
exitstatus = EXIT_FAILURE;
996
error(0, errno, "fork");
997
exitstatus = EX_OSERR;
840
1001
/* this is the child process */
841
1002
ret = sigaction(SIGCHLD, &old_sigchld_action, NULL);
1004
error(0, errno, "sigaction");
846
ret = sigprocmask (SIG_UNBLOCK, &sigchld_action.sa_mask, NULL);
1007
ret = sigprocmask(SIG_UNBLOCK, &sigchld_action.sa_mask, NULL);
848
perror("sigprocmask");
1009
error(0, errno, "sigprocmask");
852
1013
ret = dup2(pipefd[1], STDOUT_FILENO); /* replace our stdout */
1015
error(0, errno, "dup2");
858
1019
if(dirfd(dir) < 0){
863
1024
if(p->environ[0] == NULL){
864
1025
if(execv(filename, p->argv) < 0){
1026
error(0, errno, "execv for %s", filename);
869
1030
if(execve(filename, p->argv, p->environ) < 0){
1031
error(0, errno, "execve for %s", filename);
876
1037
/* Parent process */
877
close(pipefd[1]); /* Close unused write end of pipe */
1038
TEMP_FAILURE_RETRY(close(pipefd[1])); /* Close unused write end of
879
1041
plugin *new_plugin = getplugin(dirst->d_name);
880
if (new_plugin == NULL){
882
ret = sigprocmask (SIG_UNBLOCK, &sigchld_action.sa_mask, NULL);
1042
if(new_plugin == NULL){
1043
error(0, errno, "getplugin");
1044
ret = (int)(TEMP_FAILURE_RETRY
1045
(sigprocmask(SIG_UNBLOCK, &sigchld_action.sa_mask,
884
perror("sigprocmask");
1048
error(0, errno, "sigprocmask");
886
exitstatus = EXIT_FAILURE;
1050
exitstatus = EX_OSERR;
920
1087
free_plugin_list();
924
1091
/* Main loop while running plugins exist */
925
1092
while(plugin_list){
926
1093
fd_set rfds = rfds_all;
927
1094
int select_ret = select(maxfd+1, &rfds, NULL, NULL, NULL);
928
if (select_ret == -1){
930
exitstatus = EXIT_FAILURE;
1095
if(select_ret == -1 and errno != EINTR){
1096
error(0, errno, "select");
1097
exitstatus = EX_OSERR;
933
1100
/* OK, now either a process completed, or something can be read
934
1101
from one of them */
935
1102
for(plugin *proc = plugin_list; proc != NULL;){
936
1103
/* Is this process completely done? */
937
if(proc->eof and proc->completed){
1104
if(proc->completed and proc->eof){
938
1105
/* Only accept the plugin output if it exited cleanly */
939
1106
if(not WIFEXITED(proc->status)
940
1107
or WEXITSTATUS(proc->status) != 0){
941
1108
/* Bad exit by plugin */
944
1111
if(WIFEXITED(proc->status)){
945
fprintf(stderr, "Plugin %u exited with status %d\n",
946
(unsigned int) (proc->pid),
1112
fprintf(stderr, "Plugin %s [%" PRIdMAX "] exited with"
1113
" status %d\n", proc->name,
1114
(intmax_t) (proc->pid),
947
1115
WEXITSTATUS(proc->status));
948
} else if(WIFSIGNALED(proc->status)) {
949
fprintf(stderr, "Plugin %u killed by signal %d\n",
950
(unsigned int) (proc->pid),
951
WTERMSIG(proc->status));
1116
} else if(WIFSIGNALED(proc->status)){
1117
fprintf(stderr, "Plugin %s [%" PRIdMAX "] killed by"
1118
" signal %d: %s\n", proc->name,
1119
(intmax_t) (proc->pid),
1120
WTERMSIG(proc->status),
1121
strsignal(WTERMSIG(proc->status)));
952
1122
} else if(WCOREDUMP(proc->status)){
953
fprintf(stderr, "Plugin %d dumped core\n",
954
(unsigned int) (proc->pid));
1123
fprintf(stderr, "Plugin %s [%" PRIdMAX "] dumped"
1124
" core\n", proc->name, (intmax_t) (proc->pid));
958
1128
/* Remove the plugin */
959
FD_CLR(proc->fd, &rfds_all);
1129
FD_CLR(proc->fd, &rfds_all); /* Spurious warning from
961
1132
/* Block signal while modifying process_list */
962
ret = sigprocmask(SIG_BLOCK, &sigchld_action.sa_mask, NULL);
964
perror("sigprocmask");
965
exitstatus = EXIT_FAILURE;
969
/* We are done modifying process list, so unblock signal */
970
ret = sigprocmask (SIG_UNBLOCK, &sigchld_action.sa_mask,
973
perror("sigprocmask");
974
exitstatus = EXIT_FAILURE;
978
if(plugin_list == NULL){
1133
ret = (int)TEMP_FAILURE_RETRY(sigprocmask
1135
&sigchld_action.sa_mask,
1138
error(0, errno, "sigprocmask");
1139
exitstatus = EX_OSERR;
982
1143
plugin *next_plugin = proc->next;
983
1144
free_plugin(proc);
984
1145
proc = next_plugin;
1147
/* We are done modifying process list, so unblock signal */
1148
ret = (int)(TEMP_FAILURE_RETRY
1149
(sigprocmask(SIG_UNBLOCK,
1150
&sigchld_action.sa_mask, NULL)));
1152
error(0, errno, "sigprocmask");
1153
exitstatus = EX_OSERR;
1157
if(plugin_list == NULL){
988
1164
/* This process exited nicely, so print its buffer */
990
1166
bool bret = print_out_password(proc->buffer,
991
1167
proc->buffer_length);
993
perror("print_out_password");
994
exitstatus = EXIT_FAILURE;
1169
error(0, errno, "print_out_password");
1170
exitstatus = EX_IOERR;
999
1175
/* This process has not completed. Does it have any output? */
1000
if(proc->eof or not FD_ISSET(proc->fd, &rfds)){
1176
if(proc->eof or not FD_ISSET(proc->fd, &rfds)){ /* Spurious
1001
1179
/* This process had nothing to say at this time */
1002
1180
proc = proc->next;
1006
1184
if(proc->buffer_length + BUFFER_SIZE > proc->buffer_size){
1007
1185
proc->buffer = realloc(proc->buffer, proc->buffer_size
1008
1186
+ (size_t) BUFFER_SIZE);
1009
if (proc->buffer == NULL){
1011
exitstatus = EXIT_FAILURE;
1187
if(proc->buffer == NULL){
1188
error(0, errno, "malloc");
1189
exitstatus = EX_OSERR;
1014
1192
proc->buffer_size += BUFFER_SIZE;
1016
1194
/* Read from the process */
1017
ret = read(proc->fd, proc->buffer + proc->buffer_length,
1195
sret = TEMP_FAILURE_RETRY(read(proc->fd,
1197
+ proc->buffer_length,
1020
1200
/* Read error from this process; ignore the error */
1021
1201
proc = proc->next;
1026
1206
proc->eof = true;
1028
proc->buffer_length += (size_t) ret;
1208
proc->buffer_length += (size_t) sret;
1036
if(plugin_list == NULL or exitstatus != EXIT_SUCCESS){
1216
if(plugin_list == NULL or (exitstatus != EXIT_SUCCESS
1217
and exitstatus != EX_OK)){
1037
1218
/* Fallback if all plugins failed, none are found or an error
1040
1221
fprintf(stderr, "Going to fallback mode using getpass(3)\n");
1041
1222
char *passwordbuffer = getpass("Password: ");
1042
bret = print_out_password(passwordbuffer, strlen(passwordbuffer));
1223
size_t len = strlen(passwordbuffer);
1224
/* Strip trailing newline */
1225
if(len > 0 and passwordbuffer[len-1] == '\n'){
1226
passwordbuffer[len-1] = '\0'; /* not strictly necessary */
1229
bret = print_out_password(passwordbuffer, len);
1044
perror("print_out_password");
1045
exitstatus = EXIT_FAILURE;
1231
error(0, errno, "print_out_password");
1232
exitstatus = EX_IOERR;
1049
1236
/* Restore old signal handler */
1050
1237
ret = sigaction(SIGCHLD, &old_sigchld_action, NULL);
1052
perror("sigaction");
1053
exitstatus = EXIT_FAILURE;
1239
error(0, errno, "sigaction");
1240
exitstatus = EX_OSERR;
1056
1243
if(custom_argv != NULL){
1057
1244
for(char **arg = custom_argv+1; *arg != NULL; arg++){