/mandos/trunk

To get this branch, use:
bzr branch http://bzr.recompile.se/loggerhead/mandos/trunk

« back to all changes in this revision

Viewing changes to Makefile

* network-hooks.d/bridge: Use "/usr/sbin/brctl" explicitly.
* plugins.d/mandos-client.c (run_network_hooks): Raise priviliges in
                                                 child process.
  (main): Do not use getuid() to check if running setuid root.  Do not
          raise privileges for run_network_hooks.

Show diffs side-by-side

added added

removed removed

Lines of Context:
Makefile
1
 
WARN=-O -Wall -Wextra -Wdouble-promotion -Wformat=2 -Winit-self \
2
 
        -Wmissing-include-dirs -Wswitch-default -Wswitch-enum \
3
 
        -Wunused -Wuninitialized -Wstrict-overflow=5 \
4
 
        -Wsuggest-attribute=pure -Wsuggest-attribute=const \
5
 
        -Wsuggest-attribute=noreturn -Wfloat-equal -Wundef -Wshadow \
 
1
WARN=-O -Wall -Wformat=2 -Winit-self -Wmissing-include-dirs \
 
2
        -Wswitch-default -Wswitch-enum -Wunused-parameter \
 
3
        -Wstrict-aliasing=1 -Wextra -Wfloat-equal -Wundef -Wshadow \
6
4
        -Wunsafe-loop-optimizations -Wpointer-arith \
7
5
        -Wbad-function-cast -Wcast-qual -Wcast-align -Wwrite-strings \
8
 
        -Wconversion -Wlogical-op -Waggregate-return \
9
 
        -Wstrict-prototypes -Wold-style-definition \
10
 
        -Wmissing-format-attribute -Wnormalized=nfc -Wpacked \
11
 
        -Wredundant-decls -Wnested-externs -Winline -Wvla \
12
 
        -Wvolatile-register-var -Woverlength-strings
13
 
#DEBUG=-ggdb3 -fsanitize=address 
14
 
# For info about _FORTIFY_SOURCE, see feature_test_macros(7)
15
 
# and <https://gcc.gnu.org/ml/gcc-patches/2004-09/msg02055.html>.
 
6
        -Wconversion -Wstrict-prototypes -Wold-style-definition \
 
7
        -Wpacked -Wnested-externs -Winline -Wvolatile-register-var
 
8
#       -Wunreachable-code
 
9
#DEBUG=-ggdb3
 
10
# For info about _FORTIFY_SOURCE, see
 
11
# <http://www.kernel.org/doc/man-pages/online/pages/man7/feature_test_macros.7.html>
 
12
# and <http://gcc.gnu.org/ml/gcc-patches/2004-09/msg02055.html>.
16
13
FORTIFY=-D_FORTIFY_SOURCE=2 -fstack-protector-all -fPIC
17
 
# <https://developerblog.redhat.com/2014/10/16/gcc-undefined-behavior-sanitizer-ubsan/>
18
 
ALL_SANITIZE_OPTIONS:=-fsanitize=leak -fsanitize=undefined \
19
 
        -fsanitize=shift -fsanitize=integer-divide-by-zero \
20
 
        -fsanitize=unreachable -fsanitize=vla-bound -fsanitize=null \
21
 
        -fsanitize=return -fsanitize=signed-integer-overflow \
22
 
        -fsanitize=bounds -fsanitize=alignment \
23
 
        -fsanitize=object-size -fsanitize=float-divide-by-zero \
24
 
        -fsanitize=float-cast-overflow -fsanitize=nonnull-attribute \
25
 
        -fsanitize=returns-nonnull-attribute -fsanitize=bool \
26
 
        -fsanitize=enum
27
 
# Check which sanitizing options can be used
28
 
SANITIZE:=$(foreach option,$(ALL_SANITIZE_OPTIONS),$(shell \
29
 
        echo 'int main(){}' | $(CC) --language=c $(option) /dev/stdin \
30
 
        -o /dev/null >/dev/null 2>&1 && echo $(option)))
31
14
LINK_FORTIFY_LD=-z relro -z now
32
15
LINK_FORTIFY=
33
16
 
37
20
LINK_FORTIFY += -pie
38
21
endif
39
22
#COVERAGE=--coverage
40
 
OPTIMIZE=-Os -fno-strict-aliasing
41
 
LANGUAGE=-std=gnu11
 
23
OPTIMIZE=-Os
 
24
LANGUAGE=-std=gnu99
42
25
htmldir=man
43
 
version=1.7.16
 
26
version=1.4.1
44
27
SED=sed
45
28
 
46
 
USER=$(firstword $(subst :, ,$(shell getent passwd _mandos || getent passwd nobody || echo 65534)))
47
 
GROUP=$(firstword $(subst :, ,$(shell getent group _mandos || getent group nogroup || echo 65534)))
48
 
 
49
29
## Use these settings for a traditional /usr/local install
50
30
# PREFIX=$(DESTDIR)/usr/local
51
31
# CONFDIR=$(DESTDIR)/etc/mandos
52
32
# KEYDIR=$(DESTDIR)/etc/mandos/keys
53
33
# MANDIR=$(PREFIX)/man
54
34
# INITRAMFSTOOLS=$(DESTDIR)/etc/initramfs-tools
55
 
# STATEDIR=$(DESTDIR)/var/lib/mandos
56
 
# LIBDIR=$(PREFIX)/lib
57
35
##
58
36
 
59
37
## These settings are for a package-type install
62
40
KEYDIR=$(DESTDIR)/etc/keys/mandos
63
41
MANDIR=$(PREFIX)/share/man
64
42
INITRAMFSTOOLS=$(DESTDIR)/usr/share/initramfs-tools
65
 
STATEDIR=$(DESTDIR)/var/lib/mandos
66
 
LIBDIR=$(shell \
67
 
        for d in \
68
 
        "/usr/lib/`dpkg-architecture -qDEB_HOST_MULTIARCH 2>/dev/null`" \
69
 
        "`rpm --eval='%{_libdir}' 2>/dev/null`" /usr/lib; do \
70
 
                if [ -d "$$d" -a "$$d" = "$${d%/}" ]; then \
71
 
                        echo "$(DESTDIR)$$d"; \
72
 
                        break; \
73
 
                fi; \
74
 
        done)
75
43
##
76
44
 
77
 
SYSTEMD=$(DESTDIR)$(shell pkg-config systemd --variable=systemdsystemunitdir)
78
 
TMPFILES=$(DESTDIR)$(shell pkg-config systemd --variable=tmpfilesdir)
79
 
 
80
45
GNUTLS_CFLAGS=$(shell pkg-config --cflags-only-I gnutls)
81
46
GNUTLS_LIBS=$(shell pkg-config --libs gnutls)
82
47
AVAHI_CFLAGS=$(shell pkg-config --cflags-only-I avahi-core)
84
49
GPGME_CFLAGS=$(shell gpgme-config --cflags; getconf LFS_CFLAGS)
85
50
GPGME_LIBS=$(shell gpgme-config --libs; getconf LFS_LIBS; \
86
51
        getconf LFS_LDFLAGS)
87
 
LIBNL3_CFLAGS=$(shell pkg-config --cflags-only-I libnl-route-3.0)
88
 
LIBNL3_LIBS=$(shell pkg-config --libs libnl-route-3.0)
89
52
 
90
53
# Do not change these two
91
 
CFLAGS+=$(WARN) $(DEBUG) $(FORTIFY) $(SANITIZE) $(COVERAGE) \
92
 
        $(OPTIMIZE) $(LANGUAGE) $(GNUTLS_CFLAGS) $(AVAHI_CFLAGS) \
93
 
        $(GPGME_CFLAGS) -DVERSION='"$(version)"'
94
 
LDFLAGS+=-Xlinker --as-needed $(COVERAGE) $(LINK_FORTIFY) $(foreach flag,$(LINK_FORTIFY_LD),-Xlinker $(flag))
 
54
CFLAGS=$(WARN) $(DEBUG) $(FORTIFY) $(COVERAGE) $(OPTIMIZE) \
 
55
        $(LANGUAGE) $(GNUTLS_CFLAGS) $(AVAHI_CFLAGS) $(GPGME_CFLAGS) \
 
56
        -DVERSION='"$(version)"'
 
57
LDFLAGS=-Xlinker --as-needed $(COVERAGE) $(LINK_FORTIFY) $(foreach flag,$(LINK_FORTIFY_LD),-Xlinker $(flag))
95
58
 
96
59
# Commands to format a DocBook <refentry> document into a manual page
97
60
DOCBOOKTOMAN=$(strip cd $(dir $<); xsltproc --nonet --xinclude \
100
63
        --param make.single.year.ranges         1 \
101
64
        --param man.output.quietly              1 \
102
65
        --param man.authors.section.enabled     0 \
103
 
        /usr/share/xml/docbook/stylesheet/nwalsh/manpages/docbook.xsl \
 
66
         /usr/share/xml/docbook/stylesheet/nwalsh/manpages/docbook.xsl \
104
67
        $(notdir $<); \
105
 
        if locale --all 2>/dev/null | grep --regexp='^en_US\.utf8$$' \
106
 
        && type man 2>/dev/null; then LANG=en_US.UTF-8 MANWIDTH=80 \
107
 
        man --warnings --encoding=UTF-8 --local-file $(notdir $@); \
108
 
        fi >/dev/null)
 
68
        $(MANPOST) $(notdir $@);\
 
69
        LANG=en_US.UTF-8 MANWIDTH=80 man --warnings --encoding=UTF-8 \
 
70
        --local-file $(notdir $@) >/dev/null)
 
71
# DocBook-to-man post-processing to fix a '\n' escape bug
 
72
MANPOST=$(SED) --in-place --expression='s,\\\\en,\\en,g;s,\\n,\\en,g'
109
73
 
110
74
DOCBOOKTOHTML=$(strip xsltproc --nonet --xinclude \
111
75
        --param make.year.ranges                1 \
123
87
PLUGINS=plugins.d/password-prompt plugins.d/mandos-client \
124
88
        plugins.d/usplash plugins.d/splashy plugins.d/askpass-fifo \
125
89
        plugins.d/plymouth
126
 
PLUGIN_HELPERS=plugin-helpers/mandos-client-iprouteadddel
127
 
CPROGS=plugin-runner $(PLUGINS) $(PLUGIN_HELPERS)
 
90
CPROGS=plugin-runner $(PLUGINS)
128
91
PROGS=mandos mandos-keygen mandos-ctl mandos-monitor $(CPROGS)
129
92
DOCS=mandos.8 mandos-keygen.8 mandos-monitor.8 mandos-ctl.8 \
130
93
        mandos.conf.5 mandos-clients.conf.5 plugin-runner.8mandos \
257
220
        $(LINK.c) $^ -lrt $(GNUTLS_LIBS) $(AVAHI_LIBS) $(strip\
258
221
                ) $(GPGME_LIBS) $(LOADLIBES) $(LDLIBS) -o $@
259
222
 
260
 
plugin-helpers/mandos-client-iprouteadddel: plugin-helpers/mandos-client-iprouteadddel.c
261
 
        $(LINK.c) $(LIBNL3_CFLAGS) $^ $(LIBNL3_LIBS) $(strip\
262
 
                ) $(LOADLIBES) $(LDLIBS) -o $@
263
 
 
264
 
.PHONY : all doc html clean distclean mostlyclean maintainer-clean \
265
 
        check run-client run-server install install-html \
266
 
        install-server install-client-nokey install-client uninstall \
267
 
        uninstall-server uninstall-client purge purge-server \
268
 
        purge-client
 
223
.PHONY : all doc html clean distclean run-client run-server install \
 
224
        install-server install-client uninstall uninstall-server \
 
225
        uninstall-client purge purge-server purge-client
269
226
 
270
227
clean:
271
228
        -rm --force $(CPROGS) $(objects) $(htmldocs) $(DOCS) core
273
230
distclean: clean
274
231
mostlyclean: clean
275
232
maintainer-clean: clean
276
 
        -rm --force --recursive keydir confdir statedir
 
233
        -rm --force --recursive keydir confdir
277
234
 
278
235
check:  all
279
236
        ./mandos --check
280
 
        ./mandos-ctl --check
281
237
 
282
238
# Run the client with a local config and key
283
239
run-client: all keydir/seckey.txt keydir/pubkey.txt
284
240
        @echo "###################################################################"
285
241
        @echo "# The following error messages are harmless and can be safely     #"
286
 
        @echo "# ignored:                                                        #"
287
 
        @echo "# From plugin-runner: setgid: Operation not permitted             #"
288
 
        @echo "#                     setuid: Operation not permitted             #"
 
242
        @echo "# ignored.  The messages are caused by not running as root, but   #"
 
243
        @echo "# you should NOT run \"make run-client\" as root unless you also    #"
 
244
        @echo "# unpacked and compiled Mandos as root, which is NOT recommended. #"
 
245
        @echo "# From plugin-runner: setuid: Operation not permitted             #"
289
246
        @echo "# From askpass-fifo:  mkfifo: Permission denied                   #"
290
 
        @echo "# From mandos-client:                                             #"
291
 
        @echo "#             Failed to raise privileges: Operation not permitted #"
292
 
        @echo "#             Warning: network hook \"*\" exited with status *      #"
293
 
        @echo "#                                                                 #"
294
 
        @echo "# (The messages are caused by not running as root, but you should #"
295
 
        @echo "# NOT run \"make run-client\" as root unless you also unpacked and  #"
296
 
        @echo "# compiled Mandos as root, which is also NOT recommended.)        #"
 
247
        @echo "# From mandos-client: setuid: Operation not permitted             #"
 
248
        @echo "#                     seteuid: Operation not permitted            #"
 
249
        @echo "#                     klogctl: Operation not permitted            #"
297
250
        @echo "###################################################################"
298
 
# We set GNOME_KEYRING_CONTROL to block pam_gnome_keyring
299
251
        ./plugin-runner --plugin-dir=plugins.d \
300
 
                --plugin-helper-dir=plugin-helpers \
301
252
                --config-file=plugin-runner.conf \
302
253
                --options-for=mandos-client:--seckey=keydir/seckey.txt,--pubkey=keydir/pubkey.txt,--network-hook-dir=network-hooks.d \
303
 
                --env-for=mandos-client:GNOME_KEYRING_CONTROL= \
304
254
                $(CLIENTARGS)
305
255
 
306
256
# Used by run-client
309
259
        ./mandos-keygen --dir keydir --force
310
260
 
311
261
# Run the server with a local config
312
 
run-server: confdir/mandos.conf confdir/clients.conf statedir
313
 
        ./mandos --debug --no-dbus --configdir=confdir \
314
 
                --statedir=statedir $(SERVERARGS)
 
262
run-server: confdir/mandos.conf confdir/clients.conf
 
263
        @echo "#################################################################"
 
264
        @echo "# NOTE: Please IGNORE the error about \"Could not open file      #"
 
265
        @echo "# u'/var/run/mandos.pid'\" -  it is harmless and is caused by    #"
 
266
        @echo "# the server not running as root.  Do NOT run \"make run-server\" #"
 
267
        @echo "# server as root if you didn't also unpack and compile it thus. #"
 
268
        @echo "#################################################################"
 
269
        ./mandos --debug --no-dbus --configdir=confdir $(SERVERARGS)
315
270
 
316
271
# Used by run-server
317
272
confdir/mandos.conf: mandos.conf
321
276
        install --directory confdir
322
277
        install --mode=u=rw $< $@
323
278
# Add a client password
324
 
        ./mandos-keygen --dir keydir --password --no-ssh >> $@
325
 
statedir:
326
 
        install --directory statedir
 
279
        ./mandos-keygen --dir keydir --password >> $@
327
280
 
328
281
install: install-server install-client-nokey
329
282
 
334
287
 
335
288
install-server: doc
336
289
        install --directory $(CONFDIR)
337
 
        if install --directory --mode=u=rwx --owner=$(USER) \
338
 
                --group=$(GROUP) $(STATEDIR); then \
339
 
                :; \
340
 
        elif install --directory --mode=u=rwx $(STATEDIR); then \
341
 
                chown -- $(USER):$(GROUP) $(STATEDIR) || :; \
342
 
        fi
343
 
        if [ "$(TMPFILES)" != "$(DESTDIR)" -a -d "$(TMPFILES)" ]; then \
344
 
                install --mode=u=rw,go=r tmpfiles.d-mandos.conf \
345
 
                        $(TMPFILES)/mandos.conf; \
346
 
        fi
347
290
        install --mode=u=rwx,go=rx mandos $(PREFIX)/sbin/mandos
348
291
        install --mode=u=rwx,go=rx --target-directory=$(PREFIX)/sbin \
349
292
                mandos-ctl
357
300
                $(DESTDIR)/etc/dbus-1/system.d/mandos.conf
358
301
        install --mode=u=rwx,go=rx init.d-mandos \
359
302
                $(DESTDIR)/etc/init.d/mandos
360
 
        if [ "$(SYSTEMD)" != "$(DESTDIR)" -a -d "$(SYSTEMD)" ]; then \
361
 
                install --mode=u=rw,go=r mandos.service $(SYSTEMD); \
362
 
        fi
363
303
        install --mode=u=rw,go=r default-mandos \
364
304
                $(DESTDIR)/etc/default/mandos
365
305
        if [ -z $(DESTDIR) ]; then \
375
315
                > $(MANDIR)/man5/mandos.conf.5.gz
376
316
        gzip --best --to-stdout mandos-clients.conf.5 \
377
317
                > $(MANDIR)/man5/mandos-clients.conf.5.gz
378
 
        gzip --best --to-stdout intro.8mandos \
379
 
                > $(MANDIR)/man8/intro.8mandos.gz
380
318
 
381
319
install-client-nokey: all doc
382
 
        install --directory $(LIBDIR)/mandos $(CONFDIR)
 
320
        install --directory $(PREFIX)/lib/mandos $(CONFDIR)
383
321
        install --directory --mode=u=rwx $(KEYDIR) \
384
 
                $(LIBDIR)/mandos/plugins.d \
385
 
                $(LIBDIR)/mandos/plugin-helpers
386
 
        if [ "$(CONFDIR)" != "$(LIBDIR)/mandos" ]; then \
 
322
                $(PREFIX)/lib/mandos/plugins.d
 
323
        if [ "$(CONFDIR)" != "$(PREFIX)/lib/mandos" ]; then \
387
324
                install --mode=u=rwx \
388
 
                        --directory "$(CONFDIR)/plugins.d" \
389
 
                        "$(CONFDIR)/plugin-helpers"; \
 
325
                        --directory "$(CONFDIR)/plugins.d"; \
390
326
        fi
391
 
        install --mode=u=rwx,go=rx --directory \
392
 
                "$(CONFDIR)/network-hooks.d"
393
327
        install --mode=u=rwx,go=rx \
394
 
                --target-directory=$(LIBDIR)/mandos plugin-runner
 
328
                --target-directory=$(PREFIX)/lib/mandos plugin-runner
395
329
        install --mode=u=rwx,go=rx --target-directory=$(PREFIX)/sbin \
396
330
                mandos-keygen
397
331
        install --mode=u=rwx,go=rx \
398
 
                --target-directory=$(LIBDIR)/mandos/plugins.d \
 
332
                --target-directory=$(PREFIX)/lib/mandos/plugins.d \
399
333
                plugins.d/password-prompt
400
334
        install --mode=u=rwxs,go=rx \
401
 
                --target-directory=$(LIBDIR)/mandos/plugins.d \
 
335
                --target-directory=$(PREFIX)/lib/mandos/plugins.d \
402
336
                plugins.d/mandos-client
403
337
        install --mode=u=rwxs,go=rx \
404
 
                --target-directory=$(LIBDIR)/mandos/plugins.d \
 
338
                --target-directory=$(PREFIX)/lib/mandos/plugins.d \
405
339
                plugins.d/usplash
406
340
        install --mode=u=rwxs,go=rx \
407
 
                --target-directory=$(LIBDIR)/mandos/plugins.d \
 
341
                --target-directory=$(PREFIX)/lib/mandos/plugins.d \
408
342
                plugins.d/splashy
409
343
        install --mode=u=rwxs,go=rx \
410
 
                --target-directory=$(LIBDIR)/mandos/plugins.d \
 
344
                --target-directory=$(PREFIX)/lib/mandos/plugins.d \
411
345
                plugins.d/askpass-fifo
412
346
        install --mode=u=rwxs,go=rx \
413
 
                --target-directory=$(LIBDIR)/mandos/plugins.d \
 
347
                --target-directory=$(PREFIX)/lib/mandos/plugins.d \
414
348
                plugins.d/plymouth
415
 
        install --mode=u=rwx,go=rx \
416
 
                --target-directory=$(LIBDIR)/mandos/plugin-helpers \
417
 
                plugin-helpers/mandos-client-iprouteadddel
418
349
        install initramfs-tools-hook \
419
350
                $(INITRAMFSTOOLS)/hooks/mandos
420
351
        install --mode=u=rw,go=r initramfs-tools-hook-conf \
465
396
        ! grep --regexp='^ *[^ #].*keyscript=[^,=]*/mandos/' \
466
397
                $(DESTDIR)/etc/crypttab
467
398
        -rm --force $(PREFIX)/sbin/mandos-keygen \
468
 
                $(LIBDIR)/mandos/plugin-runner \
469
 
                $(LIBDIR)/mandos/plugins.d/password-prompt \
470
 
                $(LIBDIR)/mandos/plugins.d/mandos-client \
471
 
                $(LIBDIR)/mandos/plugins.d/usplash \
472
 
                $(LIBDIR)/mandos/plugins.d/splashy \
473
 
                $(LIBDIR)/mandos/plugins.d/askpass-fifo \
474
 
                $(LIBDIR)/mandos/plugins.d/plymouth \
 
399
                $(PREFIX)/lib/mandos/plugin-runner \
 
400
                $(PREFIX)/lib/mandos/plugins.d/password-prompt \
 
401
                $(PREFIX)/lib/mandos/plugins.d/mandos-client \
 
402
                $(PREFIX)/lib/mandos/plugins.d/usplash \
 
403
                $(PREFIX)/lib/mandos/plugins.d/splashy \
 
404
                $(PREFIX)/lib/mandos/plugins.d/askpass-fifo \
 
405
                $(PREFIX)/lib/mandos/plugins.d/plymouth \
475
406
                $(INITRAMFSTOOLS)/hooks/mandos \
476
407
                $(INITRAMFSTOOLS)/conf-hooks.d/mandos \
477
408
                $(INITRAMFSTOOLS)/scripts/init-premount/mandos \
483
414
                $(MANDIR)/man8/splashy.8mandos.gz \
484
415
                $(MANDIR)/man8/askpass-fifo.8mandos.gz \
485
416
                $(MANDIR)/man8/plymouth.8mandos.gz \
486
 
        -rmdir $(LIBDIR)/mandos/plugins.d $(CONFDIR)/plugins.d \
487
 
                 $(LIBDIR)/mandos $(CONFDIR) $(KEYDIR)
 
417
        -rmdir $(PREFIX)/lib/mandos/plugins.d $(CONFDIR)/plugins.d \
 
418
                 $(PREFIX)/lib/mandos $(CONFDIR) $(KEYDIR)
488
419
        update-initramfs -k all -u
489
420
 
490
421
purge: purge-server purge-client
494
425
                $(DESTDIR)/etc/dbus-1/system.d/mandos.conf
495
426
                $(DESTDIR)/etc/default/mandos \
496
427
                $(DESTDIR)/etc/init.d/mandos \
497
 
                $(SYSTEMD)/mandos.service \
498
 
                $(DESTDIR)/run/mandos.pid \
499
428
                $(DESTDIR)/var/run/mandos.pid
500
429
        -rmdir $(CONFDIR)
501
430