145
151
        self.group = None       # our entry group
 
146
152
        self.server = None
 
 
154
        self.entry_group_state_changed_match = None
 
148
155
    def rename(self):
 
149
156
        """Derived from the Avahi example code"""
 
150
157
        if self.rename_count >= self.max_renames:
 
151
 
            logger.critical(u"No suitable Zeroconf service name found"
 
152
 
                            u" after %i retries, exiting.",
 
 
158
            logger.critical("No suitable Zeroconf service name found"
 
 
159
                            " after %i retries, exiting.",
 
153
160
                            self.rename_count)
 
154
 
            raise AvahiServiceError(u"Too many renames")
 
155
 
        self.name = self.server.GetAlternativeServiceName(self.name)
 
156
 
        logger.info(u"Changing Zeroconf service name to %r ...",
 
 
161
            raise AvahiServiceError("Too many renames")
 
 
162
        self.name = unicode(self.server.GetAlternativeServiceName(self.name))
 
 
163
        logger.info("Changing Zeroconf service name to %r ...",
 
158
165
        syslogger.setFormatter(logging.Formatter
 
159
 
                               (u'Mandos (%s) [%%(process)d]:'
 
160
 
                                u' %%(levelname)s: %%(message)s'
 
 
166
                               ('Mandos (%s) [%%(process)d]:'
 
 
167
                                ' %%(levelname)s: %%(message)s'
 
 
172
        except dbus.exceptions.DBusException as error:
 
 
173
            logger.critical("DBusException: %s", error)
 
164
176
        self.rename_count += 1
 
165
177
    def remove(self):
 
166
178
        """Derived from the Avahi example code"""
 
167
179
        if self.group is not None:
 
 
182
            except (dbus.exceptions.UnknownMethodException,
 
 
183
                    dbus.exceptions.DBusException) as e:
 
 
186
        if self.entry_group_state_changed_match is not None:
 
 
187
            self.entry_group_state_changed_match.remove()
 
 
188
            self.entry_group_state_changed_match = None
 
170
190
        """Derived from the Avahi example code"""
 
171
 
        if self.group is None:
 
172
 
            self.group = dbus.Interface(
 
173
 
                self.bus.get_object(avahi.DBUS_NAME,
 
174
 
                                    self.server.EntryGroupNew()),
 
175
 
                avahi.DBUS_INTERFACE_ENTRY_GROUP)
 
176
 
            self.group.connect_to_signal('StateChanged',
 
177
 
                                         self.entry_group_state_changed)
 
178
 
        logger.debug(u"Adding Zeroconf service '%s' of type '%s' ...",
 
 
192
        self.group = dbus.Interface(
 
 
193
            self.bus.get_object(avahi.DBUS_NAME,
 
 
194
                                self.server.EntryGroupNew(),
 
 
195
                                follow_name_owner_changes=True),
 
 
196
            avahi.DBUS_INTERFACE_ENTRY_GROUP)
 
 
197
        self.entry_group_state_changed_match = (
 
 
198
            self.group.connect_to_signal(
 
 
199
                'StateChanged', self .entry_group_state_changed))
 
 
200
        logger.debug("Adding Zeroconf service '%s' of type '%s' ...",
 
179
201
                     self.name, self.type)
 
180
202
        self.group.AddService(
 
 
188
210
        self.group.Commit()
 
189
211
    def entry_group_state_changed(self, state, error):
 
190
212
        """Derived from the Avahi example code"""
 
191
 
        logger.debug(u"Avahi state change: %i", state)
 
 
213
        logger.debug("Avahi entry group state change: %i", state)
 
193
215
        if state == avahi.ENTRY_GROUP_ESTABLISHED:
 
194
 
            logger.debug(u"Zeroconf service established.")
 
 
216
            logger.debug("Zeroconf service established.")
 
195
217
        elif state == avahi.ENTRY_GROUP_COLLISION:
 
196
 
            logger.warning(u"Zeroconf service name collision.")
 
 
218
            logger.info("Zeroconf service name collision.")
 
198
220
        elif state == avahi.ENTRY_GROUP_FAILURE:
 
199
 
            logger.critical(u"Avahi: Error in group state changed %s",
 
 
221
            logger.critical("Avahi: Error in group state changed %s",
 
201
 
            raise AvahiGroupError(u"State changed: %s"
 
 
223
            raise AvahiGroupError("State changed: %s"
 
202
224
                                  % unicode(error))
 
203
225
    def cleanup(self):
 
204
226
        """Derived from the Avahi example code"""
 
205
 
        if self.group is not None:
 
208
 
    def server_state_changed(self, state):
 
 
228
    def server_state_changed(self, state, error=None):
 
209
229
        """Derived from the Avahi example code"""
 
210
 
        if state == avahi.SERVER_COLLISION:
 
211
 
            logger.error(u"Zeroconf server name collision")
 
 
230
        logger.debug("Avahi server state change: %i", state)
 
 
231
        bad_states = { avahi.SERVER_INVALID:
 
 
232
                           "Zeroconf server invalid",
 
 
233
                       avahi.SERVER_REGISTERING: None,
 
 
234
                       avahi.SERVER_COLLISION:
 
 
235
                           "Zeroconf server name collision",
 
 
236
                       avahi.SERVER_FAILURE:
 
 
237
                           "Zeroconf server failure" }
 
 
238
        if state in bad_states:
 
 
239
            if bad_states[state]:
 
 
240
                logger.error(bad_states[state])
 
213
242
        elif state == avahi.SERVER_RUNNING:
 
 
245
            logger.debug("Unknown state: %r", state)
 
215
246
    def activate(self):
 
216
247
        """Derived from the Avahi example code"""
 
217
248
        if self.server is None:
 
218
249
            self.server = dbus.Interface(
 
219
250
                self.bus.get_object(avahi.DBUS_NAME,
 
220
 
                                    avahi.DBUS_PATH_SERVER),
 
 
251
                                    avahi.DBUS_PATH_SERVER,
 
 
252
                                    follow_name_owner_changes=True),
 
221
253
                avahi.DBUS_INTERFACE_SERVER)
 
222
 
        self.server.connect_to_signal(u"StateChanged",
 
 
254
        self.server.connect_to_signal("StateChanged",
 
223
255
                                 self.server_state_changed)
 
224
256
        self.server_state_changed(self.server.GetState())
 
 
228
260
    """A representation of a client host served by this server.
 
231
 
    name:       string; from the config file, used in log messages and
 
233
 
    fingerprint: string (40 or 32 hexadecimal digits); used to
 
234
 
                 uniquely identify the client
 
235
 
    secret:     bytestring; sent verbatim (over TLS) to client
 
236
 
    host:       string; available for use by the checker command
 
237
 
    created:    datetime.datetime(); (UTC) object creation
 
238
 
    last_enabled: datetime.datetime(); (UTC)
 
240
 
    last_checked_ok: datetime.datetime(); (UTC) or None
 
241
 
    timeout:    datetime.timedelta(); How long from last_checked_ok
 
242
 
                                      until this client is invalid
 
243
 
    interval:   datetime.timedelta(); How often to start a new checker
 
244
 
    disable_hook:  If set, called by disable() as disable_hook(self)
 
 
263
    _approved:   bool(); 'None' if not yet approved/disapproved
 
 
264
    approval_delay: datetime.timedelta(); Time to wait for approval
 
 
265
    approval_duration: datetime.timedelta(); Duration of one approval
 
245
266
    checker:    subprocess.Popen(); a running checker process used
 
246
267
                                    to see if the client lives.
 
247
268
                                    'None' if no process is running.
 
248
 
    checker_initiator_tag: a gobject event source tag, or None
 
249
 
    disable_initiator_tag:    - '' -
 
250
 
    checker_callback_tag:  - '' -
 
251
 
    checker_command: string; External command which is run to check if
 
252
 
                     client lives.  %() expansions are done at
 
 
269
    checker_callback_tag: a gobject event source tag, or None
 
 
270
    checker_command: string; External command which is run to check
 
 
271
                     if client lives.  %() expansions are done at
 
253
272
                     runtime with vars(self) as dict, so that for
 
254
273
                     instance %(name)s can be used in the command.
 
 
274
    checker_initiator_tag: a gobject event source tag, or None
 
 
275
    created:    datetime.datetime(); (UTC) object creation
 
255
276
    current_checker_command: string; current running checker_command
 
 
277
    disable_hook:  If set, called by disable() as disable_hook(self)
 
 
278
    disable_initiator_tag: a gobject event source tag, or None
 
 
280
    fingerprint: string (40 or 32 hexadecimal digits); used to
 
 
281
                 uniquely identify the client
 
 
282
    host:       string; available for use by the checker command
 
 
283
    interval:   datetime.timedelta(); How often to start a new checker
 
 
284
    last_approval_request: datetime.datetime(); (UTC) or None
 
 
285
    last_checked_ok: datetime.datetime(); (UTC) or None
 
 
286
    last_enabled: datetime.datetime(); (UTC)
 
 
287
    name:       string; from the config file, used in log messages and
 
 
289
    secret:     bytestring; sent verbatim (over TLS) to client
 
 
290
    timeout:    datetime.timedelta(); How long from last_checked_ok
 
 
291
                                      until this client is disabled
 
 
292
    runtime_expansions: Allowed attributes for runtime expansion.
 
 
295
    runtime_expansions = ("approval_delay", "approval_duration",
 
 
296
                          "created", "enabled", "fingerprint",
 
 
297
                          "host", "interval", "last_checked_ok",
 
 
298
                          "last_enabled", "name", "timeout")
 
259
 
    def _datetime_to_milliseconds(dt):
 
260
 
        "Convert a datetime.datetime() to milliseconds"
 
261
 
        return ((dt.days * 24 * 60 * 60 * 1000)
 
262
 
                + (dt.seconds * 1000)
 
263
 
                + (dt.microseconds // 1000))
 
 
301
    def _timedelta_to_milliseconds(td):
 
 
302
        "Convert a datetime.timedelta() to milliseconds"
 
 
303
        return ((td.days * 24 * 60 * 60 * 1000)
 
 
304
                + (td.seconds * 1000)
 
 
305
                + (td.microseconds // 1000))
 
265
307
    def timeout_milliseconds(self):
 
266
308
        "Return the 'timeout' attribute in milliseconds"
 
267
 
        return self._datetime_to_milliseconds(self.timeout)
 
 
309
        return self._timedelta_to_milliseconds(self.timeout)
 
269
311
    def interval_milliseconds(self):
 
270
312
        "Return the 'interval' attribute in milliseconds"
 
271
 
        return self._datetime_to_milliseconds(self.interval)
 
 
313
        return self._timedelta_to_milliseconds(self.interval)
 
 
315
    def approval_delay_milliseconds(self):
 
 
316
        return self._timedelta_to_milliseconds(self.approval_delay)
 
273
318
    def __init__(self, name = None, disable_hook=None, config=None):
 
274
319
        """Note: the 'checker' key in 'config' sets the
 
 
278
323
        if config is None:
 
280
 
        logger.debug(u"Creating client %r", self.name)
 
 
325
        logger.debug("Creating client %r", self.name)
 
281
326
        # Uppercase and remove spaces from fingerprint for later
 
282
327
        # comparison purposes with return value from the fingerprint()
 
284
 
        self.fingerprint = (config[u"fingerprint"].upper()
 
286
 
        logger.debug(u"  Fingerprint: %s", self.fingerprint)
 
287
 
        if u"secret" in config:
 
288
 
            self.secret = config[u"secret"].decode(u"base64")
 
289
 
        elif u"secfile" in config:
 
290
 
            with closing(open(os.path.expanduser
 
292
 
                               (config[u"secfile"])))) as secfile:
 
 
329
        self.fingerprint = (config["fingerprint"].upper()
 
 
331
        logger.debug("  Fingerprint: %s", self.fingerprint)
 
 
332
        if "secret" in config:
 
 
333
            self.secret = config["secret"].decode("base64")
 
 
334
        elif "secfile" in config:
 
 
335
            with open(os.path.expanduser(os.path.expandvars
 
 
336
                                         (config["secfile"])),
 
293
338
                self.secret = secfile.read()
 
295
 
            raise TypeError(u"No secret or secfile for client %s"
 
 
340
            raise TypeError("No secret or secfile for client %s"
 
297
 
        self.host = config.get(u"host", u"")
 
 
342
        self.host = config.get("host", "")
 
298
343
        self.created = datetime.datetime.utcnow()
 
299
344
        self.enabled = False
 
 
345
        self.last_approval_request = None
 
300
346
        self.last_enabled = None
 
301
347
        self.last_checked_ok = None
 
302
 
        self.timeout = string_to_delta(config[u"timeout"])
 
303
 
        self.interval = string_to_delta(config[u"interval"])
 
 
348
        self.timeout = string_to_delta(config["timeout"])
 
 
349
        self.interval = string_to_delta(config["interval"])
 
304
350
        self.disable_hook = disable_hook
 
305
351
        self.checker = None
 
306
352
        self.checker_initiator_tag = None
 
307
353
        self.disable_initiator_tag = None
 
308
354
        self.checker_callback_tag = None
 
309
 
        self.checker_command = config[u"checker"]
 
 
355
        self.checker_command = config["checker"]
 
310
356
        self.current_checker_command = None
 
311
357
        self.last_connect = None
 
 
358
        self._approved = None
 
 
359
        self.approved_by_default = config.get("approved_by_default",
 
 
361
        self.approvals_pending = 0
 
 
362
        self.approval_delay = string_to_delta(
 
 
363
            config["approval_delay"])
 
 
364
        self.approval_duration = string_to_delta(
 
 
365
            config["approval_duration"])
 
 
366
        self.changedstate = multiprocessing_manager.Condition(multiprocessing_manager.Lock())
 
 
368
    def send_changedstate(self):
 
 
369
        self.changedstate.acquire()
 
 
370
        self.changedstate.notify_all()
 
 
371
        self.changedstate.release()
 
313
373
    def enable(self):
 
314
374
        """Start this client's checker and timeout hooks"""
 
315
 
        if getattr(self, u"enabled", False):
 
 
375
        if getattr(self, "enabled", False):
 
316
376
            # Already enabled
 
 
378
        self.send_changedstate()
 
318
379
        self.last_enabled = datetime.datetime.utcnow()
 
319
380
        # Schedule a new checker to be started an 'interval' from now,
 
320
381
        # and every interval from then on.
 
321
382
        self.checker_initiator_tag = (gobject.timeout_add
 
322
383
                                      (self.interval_milliseconds(),
 
323
384
                                       self.start_checker))
 
324
 
        # Also start a new checker *right now*.
 
326
385
        # Schedule a disable() when 'timeout' has passed
 
327
386
        self.disable_initiator_tag = (gobject.timeout_add
 
328
387
                                   (self.timeout_milliseconds(),
 
330
389
        self.enabled = True
 
 
390
        # Also start a new checker *right now*.
 
 
393
    def disable(self, quiet=True):
 
333
394
        """Disable this client."""
 
334
395
        if not getattr(self, "enabled", False):
 
336
 
        logger.info(u"Disabling client %s", self.name)
 
337
 
        if getattr(self, u"disable_initiator_tag", False):
 
 
398
            self.send_changedstate()
 
 
400
            logger.info("Disabling client %s", self.name)
 
 
401
        if getattr(self, "disable_initiator_tag", False):
 
338
402
            gobject.source_remove(self.disable_initiator_tag)
 
339
403
            self.disable_initiator_tag = None
 
340
 
        if getattr(self, u"checker_initiator_tag", False):
 
 
404
        if getattr(self, "checker_initiator_tag", False):
 
341
405
            gobject.source_remove(self.checker_initiator_tag)
 
342
406
            self.checker_initiator_tag = None
 
343
407
        self.stop_checker()
 
 
453
527
        if self.checker_callback_tag:
 
454
528
            gobject.source_remove(self.checker_callback_tag)
 
455
529
            self.checker_callback_tag = None
 
456
 
        if getattr(self, u"checker", None) is None:
 
 
530
        if getattr(self, "checker", None) is None:
 
458
 
        logger.debug(u"Stopping checker for %(name)s", vars(self))
 
 
532
        logger.debug("Stopping checker for %(name)s", vars(self))
 
460
534
            os.kill(self.checker.pid, signal.SIGTERM)
 
462
536
            #if self.checker.poll() is None:
 
463
537
            #    os.kill(self.checker.pid, signal.SIGKILL)
 
464
 
        except OSError, error:
 
 
538
        except OSError as error:
 
465
539
            if error.errno != errno.ESRCH: # No such process
 
467
541
        self.checker = None
 
469
 
    def still_valid(self):
 
470
 
        """Has the timeout not yet passed for this client?"""
 
471
 
        if not getattr(self, u"enabled", False):
 
473
 
        now = datetime.datetime.utcnow()
 
474
 
        if self.last_checked_ok is None:
 
475
 
            return now < (self.created + self.timeout)
 
477
 
            return now < (self.last_checked_ok + self.timeout)
 
480
 
class ClientDBus(Client, dbus.service.Object):
 
 
543
def dbus_service_property(dbus_interface, signature="v",
 
 
544
                          access="readwrite", byte_arrays=False):
 
 
545
    """Decorators for marking methods of a DBusObjectWithProperties to
 
 
546
    become properties on the D-Bus.
 
 
548
    The decorated method will be called with no arguments by "Get"
 
 
549
    and with one argument by "Set".
 
 
551
    The parameters, where they are supported, are the same as
 
 
552
    dbus.service.method, except there is only "signature", since the
 
 
553
    type from Get() and the type sent to Set() is the same.
 
 
555
    # Encoding deeply encoded byte arrays is not supported yet by the
 
 
556
    # "Set" method, so we fail early here:
 
 
557
    if byte_arrays and signature != "ay":
 
 
558
        raise ValueError("Byte arrays not supported for non-'ay'"
 
 
559
                         " signature %r" % signature)
 
 
561
        func._dbus_is_property = True
 
 
562
        func._dbus_interface = dbus_interface
 
 
563
        func._dbus_signature = signature
 
 
564
        func._dbus_access = access
 
 
565
        func._dbus_name = func.__name__
 
 
566
        if func._dbus_name.endswith("_dbus_property"):
 
 
567
            func._dbus_name = func._dbus_name[:-14]
 
 
568
        func._dbus_get_args_options = {'byte_arrays': byte_arrays }
 
 
573
class DBusPropertyException(dbus.exceptions.DBusException):
 
 
574
    """A base class for D-Bus property-related exceptions
 
 
576
    def __unicode__(self):
 
 
577
        return unicode(str(self))
 
 
580
class DBusPropertyAccessException(DBusPropertyException):
 
 
581
    """A property's access permissions disallows an operation.
 
 
586
class DBusPropertyNotFound(DBusPropertyException):
 
 
587
    """An attempt was made to access a non-existing property.
 
 
592
class DBusObjectWithProperties(dbus.service.Object):
 
 
593
    """A D-Bus object with properties.
 
 
595
    Classes inheriting from this can use the dbus_service_property
 
 
596
    decorator to expose methods as D-Bus properties.  It exposes the
 
 
597
    standard Get(), Set(), and GetAll() methods on the D-Bus.
 
 
601
    def _is_dbus_property(obj):
 
 
602
        return getattr(obj, "_dbus_is_property", False)
 
 
604
    def _get_all_dbus_properties(self):
 
 
605
        """Returns a generator of (name, attribute) pairs
 
 
607
        return ((prop._dbus_name, prop)
 
 
609
                inspect.getmembers(self, self._is_dbus_property))
 
 
611
    def _get_dbus_property(self, interface_name, property_name):
 
 
612
        """Returns a bound method if one exists which is a D-Bus
 
 
613
        property with the specified name and interface.
 
 
615
        for name in (property_name,
 
 
616
                     property_name + "_dbus_property"):
 
 
617
            prop = getattr(self, name, None)
 
 
619
                or not self._is_dbus_property(prop)
 
 
620
                or prop._dbus_name != property_name
 
 
621
                or (interface_name and prop._dbus_interface
 
 
622
                    and interface_name != prop._dbus_interface)):
 
 
626
        raise DBusPropertyNotFound(self.dbus_object_path + ":"
 
 
627
                                   + interface_name + "."
 
 
630
    @dbus.service.method(dbus.PROPERTIES_IFACE, in_signature="ss",
 
 
632
    def Get(self, interface_name, property_name):
 
 
633
        """Standard D-Bus property Get() method, see D-Bus standard.
 
 
635
        prop = self._get_dbus_property(interface_name, property_name)
 
 
636
        if prop._dbus_access == "write":
 
 
637
            raise DBusPropertyAccessException(property_name)
 
 
639
        if not hasattr(value, "variant_level"):
 
 
641
        return type(value)(value, variant_level=value.variant_level+1)
 
 
643
    @dbus.service.method(dbus.PROPERTIES_IFACE, in_signature="ssv")
 
 
644
    def Set(self, interface_name, property_name, value):
 
 
645
        """Standard D-Bus property Set() method, see D-Bus standard.
 
 
647
        prop = self._get_dbus_property(interface_name, property_name)
 
 
648
        if prop._dbus_access == "read":
 
 
649
            raise DBusPropertyAccessException(property_name)
 
 
650
        if prop._dbus_get_args_options["byte_arrays"]:
 
 
651
            # The byte_arrays option is not supported yet on
 
 
652
            # signatures other than "ay".
 
 
653
            if prop._dbus_signature != "ay":
 
 
655
            value = dbus.ByteArray(''.join(unichr(byte)
 
 
659
    @dbus.service.method(dbus.PROPERTIES_IFACE, in_signature="s",
 
 
660
                         out_signature="a{sv}")
 
 
661
    def GetAll(self, interface_name):
 
 
662
        """Standard D-Bus property GetAll() method, see D-Bus
 
 
665
        Note: Will not include properties with access="write".
 
 
668
        for name, prop in self._get_all_dbus_properties():
 
 
670
                and interface_name != prop._dbus_interface):
 
 
671
                # Interface non-empty but did not match
 
 
673
            # Ignore write-only properties
 
 
674
            if prop._dbus_access == "write":
 
 
677
            if not hasattr(value, "variant_level"):
 
 
680
            all[name] = type(value)(value, variant_level=
 
 
681
                                    value.variant_level+1)
 
 
682
        return dbus.Dictionary(all, signature="sv")
 
 
684
    @dbus.service.method(dbus.INTROSPECTABLE_IFACE,
 
 
686
                         path_keyword='object_path',
 
 
687
                         connection_keyword='connection')
 
 
688
    def Introspect(self, object_path, connection):
 
 
689
        """Standard D-Bus method, overloaded to insert property tags.
 
 
691
        xmlstring = dbus.service.Object.Introspect(self, object_path,
 
 
694
            document = xml.dom.minidom.parseString(xmlstring)
 
 
695
            def make_tag(document, name, prop):
 
 
696
                e = document.createElement("property")
 
 
697
                e.setAttribute("name", name)
 
 
698
                e.setAttribute("type", prop._dbus_signature)
 
 
699
                e.setAttribute("access", prop._dbus_access)
 
 
701
            for if_tag in document.getElementsByTagName("interface"):
 
 
702
                for tag in (make_tag(document, name, prop)
 
 
704
                            in self._get_all_dbus_properties()
 
 
705
                            if prop._dbus_interface
 
 
706
                            == if_tag.getAttribute("name")):
 
 
707
                    if_tag.appendChild(tag)
 
 
708
                # Add the names to the return values for the
 
 
709
                # "org.freedesktop.DBus.Properties" methods
 
 
710
                if (if_tag.getAttribute("name")
 
 
711
                    == "org.freedesktop.DBus.Properties"):
 
 
712
                    for cn in if_tag.getElementsByTagName("method"):
 
 
713
                        if cn.getAttribute("name") == "Get":
 
 
714
                            for arg in cn.getElementsByTagName("arg"):
 
 
715
                                if (arg.getAttribute("direction")
 
 
717
                                    arg.setAttribute("name", "value")
 
 
718
                        elif cn.getAttribute("name") == "GetAll":
 
 
719
                            for arg in cn.getElementsByTagName("arg"):
 
 
720
                                if (arg.getAttribute("direction")
 
 
722
                                    arg.setAttribute("name", "props")
 
 
723
            xmlstring = document.toxml("utf-8")
 
 
725
        except (AttributeError, xml.dom.DOMException,
 
 
726
                xml.parsers.expat.ExpatError) as error:
 
 
727
            logger.error("Failed to override Introspection method",
 
 
732
class ClientDBus(Client, DBusObjectWithProperties):
 
481
733
    """A Client class using D-Bus
 
484
736
    dbus_object_path: dbus.ObjectPath
 
485
737
    bus: dbus.SystemBus()
 
 
740
    runtime_expansions = (Client.runtime_expansions
 
 
741
                          + ("dbus_object_path",))
 
487
743
    # dbus.service.Object doesn't use super(), so we can't either.
 
489
745
    def __init__(self, bus = None, *args, **kwargs):
 
 
746
        self._approvals_pending = 0
 
491
748
        Client.__init__(self, *args, **kwargs)
 
492
749
        # Only now, when this client is initialized, can it show up on
 
 
751
        client_object_name = unicode(self.name).translate(
 
494
754
        self.dbus_object_path = (dbus.ObjectPath
 
496
 
                                  + self.name.replace(u".", u"_")))
 
497
 
        dbus.service.Object.__init__(self, self.bus,
 
498
 
                                     self.dbus_object_path)
 
 
755
                                 ("/clients/" + client_object_name))
 
 
756
        DBusObjectWithProperties.__init__(self, self.bus,
 
 
757
                                          self.dbus_object_path)
 
 
759
    def _get_approvals_pending(self):
 
 
760
        return self._approvals_pending
 
 
761
    def _set_approvals_pending(self, value):
 
 
762
        old_value = self._approvals_pending
 
 
763
        self._approvals_pending = value
 
 
765
        if (hasattr(self, "dbus_object_path")
 
 
766
            and bval is not bool(old_value)):
 
 
767
            dbus_bool = dbus.Boolean(bval, variant_level=1)
 
 
768
            self.PropertyChanged(dbus.String("ApprovalPending"),
 
 
771
    approvals_pending = property(_get_approvals_pending,
 
 
772
                                 _set_approvals_pending)
 
 
773
    del _get_approvals_pending, _set_approvals_pending
 
501
776
    def _datetime_to_dbus(dt, variant_level=0):
 
 
578
861
            # Emit D-Bus signal
 
579
862
            self.CheckerStarted(self.current_checker_command)
 
580
863
            self.PropertyChanged(
 
581
 
                dbus.String(u"checker_running"),
 
 
864
                dbus.String("CheckerRunning"),
 
582
865
                dbus.Boolean(True, variant_level=1))
 
585
868
    def stop_checker(self, *args, **kwargs):
 
586
 
        old_checker = getattr(self, u"checker", None)
 
 
869
        old_checker = getattr(self, "checker", None)
 
587
870
        r = Client.stop_checker(self, *args, **kwargs)
 
588
871
        if (old_checker is not None
 
589
 
            and getattr(self, u"checker", None) is None):
 
590
 
            self.PropertyChanged(dbus.String(u"checker_running"),
 
 
872
            and getattr(self, "checker", None) is None):
 
 
873
            self.PropertyChanged(dbus.String("CheckerRunning"),
 
591
874
                                 dbus.Boolean(False, variant_level=1))
 
594
 
    ## D-Bus methods & signals
 
595
 
    _interface = u"se.bsnet.fukt.Mandos.Client"
 
598
 
    @dbus.service.method(_interface)
 
600
 
        return self.checked_ok()
 
 
877
    def _reset_approved(self):
 
 
878
        self._approved = None
 
 
881
    def approve(self, value=True):
 
 
882
        self.send_changedstate()
 
 
883
        self._approved = value
 
 
884
        gobject.timeout_add(self._timedelta_to_milliseconds
 
 
885
                            (self.approval_duration),
 
 
886
                            self._reset_approved)
 
 
889
    ## D-Bus methods, signals & properties
 
 
890
    _interface = "se.bsnet.fukt.Mandos.Client"
 
602
894
    # CheckerCompleted - signal
 
603
 
    @dbus.service.signal(_interface, signature=u"nxs")
 
 
895
    @dbus.service.signal(_interface, signature="nxs")
 
604
896
    def CheckerCompleted(self, exitcode, waitstatus, command):
 
608
900
    # CheckerStarted - signal
 
609
 
    @dbus.service.signal(_interface, signature=u"s")
 
 
901
    @dbus.service.signal(_interface, signature="s")
 
610
902
    def CheckerStarted(self, command):
 
614
 
    # GetAllProperties - method
 
615
 
    @dbus.service.method(_interface, out_signature=u"a{sv}")
 
616
 
    def GetAllProperties(self):
 
618
 
        return dbus.Dictionary({
 
619
 
                dbus.String(u"name"):
 
620
 
                    dbus.String(self.name, variant_level=1),
 
621
 
                dbus.String(u"fingerprint"):
 
622
 
                    dbus.String(self.fingerprint, variant_level=1),
 
623
 
                dbus.String(u"host"):
 
624
 
                    dbus.String(self.host, variant_level=1),
 
625
 
                dbus.String(u"created"):
 
626
 
                    self._datetime_to_dbus(self.created,
 
628
 
                dbus.String(u"last_enabled"):
 
629
 
                    (self._datetime_to_dbus(self.last_enabled,
 
631
 
                     if self.last_enabled is not None
 
632
 
                     else dbus.Boolean(False, variant_level=1)),
 
633
 
                dbus.String(u"enabled"):
 
634
 
                    dbus.Boolean(self.enabled, variant_level=1),
 
635
 
                dbus.String(u"last_checked_ok"):
 
636
 
                    (self._datetime_to_dbus(self.last_checked_ok,
 
638
 
                     if self.last_checked_ok is not None
 
639
 
                     else dbus.Boolean (False, variant_level=1)),
 
640
 
                dbus.String(u"timeout"):
 
641
 
                    dbus.UInt64(self.timeout_milliseconds(),
 
643
 
                dbus.String(u"interval"):
 
644
 
                    dbus.UInt64(self.interval_milliseconds(),
 
646
 
                dbus.String(u"checker"):
 
647
 
                    dbus.String(self.checker_command,
 
649
 
                dbus.String(u"checker_running"):
 
650
 
                    dbus.Boolean(self.checker is not None,
 
652
 
                dbus.String(u"object_path"):
 
653
 
                    dbus.ObjectPath(self.dbus_object_path,
 
657
 
    # IsStillValid - method
 
658
 
    @dbus.service.method(_interface, out_signature=u"b")
 
659
 
    def IsStillValid(self):
 
660
 
        return self.still_valid()
 
662
906
    # PropertyChanged - signal
 
663
 
    @dbus.service.signal(_interface, signature=u"sv")
 
 
907
    @dbus.service.signal(_interface, signature="sv")
 
664
908
    def PropertyChanged(self, property, value):
 
668
 
    # ReceivedSecret - signal
 
669
913
    @dbus.service.signal(_interface)
 
670
 
    def ReceivedSecret(self):
 
 
916
        Is sent after a successful transfer of secret from the Mandos
 
 
917
        server to mandos-client
 
674
921
    # Rejected - signal
 
675
 
    @dbus.service.signal(_interface)
 
 
922
    @dbus.service.signal(_interface, signature="s")
 
 
923
    def Rejected(self, reason):
 
680
 
    # SetChecker - method
 
681
 
    @dbus.service.method(_interface, in_signature=u"s")
 
682
 
    def SetChecker(self, checker):
 
683
 
        "D-Bus setter method"
 
684
 
        self.checker_command = checker
 
686
 
        self.PropertyChanged(dbus.String(u"checker"),
 
687
 
                             dbus.String(self.checker_command,
 
691
 
    @dbus.service.method(_interface, in_signature=u"s")
 
692
 
    def SetHost(self, host):
 
693
 
        "D-Bus setter method"
 
696
 
        self.PropertyChanged(dbus.String(u"host"),
 
697
 
                             dbus.String(self.host, variant_level=1))
 
699
 
    # SetInterval - method
 
700
 
    @dbus.service.method(_interface, in_signature=u"t")
 
701
 
    def SetInterval(self, milliseconds):
 
702
 
        self.interval = datetime.timedelta(0, 0, 0, milliseconds)
 
704
 
        self.PropertyChanged(dbus.String(u"interval"),
 
705
 
                             (dbus.UInt64(self.interval_milliseconds(),
 
709
 
    @dbus.service.method(_interface, in_signature=u"ay",
 
711
 
    def SetSecret(self, secret):
 
712
 
        "D-Bus setter method"
 
713
 
        self.secret = str(secret)
 
715
 
    # SetTimeout - method
 
716
 
    @dbus.service.method(_interface, in_signature=u"t")
 
717
 
    def SetTimeout(self, milliseconds):
 
718
 
        self.timeout = datetime.timedelta(0, 0, 0, milliseconds)
 
720
 
        self.PropertyChanged(dbus.String(u"timeout"),
 
721
 
                             (dbus.UInt64(self.timeout_milliseconds(),
 
 
927
    # NeedApproval - signal
 
 
928
    @dbus.service.signal(_interface, signature="tb")
 
 
929
    def NeedApproval(self, timeout, default):
 
 
931
        return self.need_approval()
 
 
936
    @dbus.service.method(_interface, in_signature="b")
 
 
937
    def Approve(self, value):
 
 
941
    @dbus.service.method(_interface)
 
724
945
    # Enable - method
 
725
946
    @dbus.service.method(_interface)
 
 
744
965
    def StopChecker(self):
 
745
966
        self.stop_checker()
 
 
970
    # ApprovalPending - property
 
 
971
    @dbus_service_property(_interface, signature="b", access="read")
 
 
972
    def ApprovalPending_dbus_property(self):
 
 
973
        return dbus.Boolean(bool(self.approvals_pending))
 
 
975
    # ApprovedByDefault - property
 
 
976
    @dbus_service_property(_interface, signature="b",
 
 
978
    def ApprovedByDefault_dbus_property(self, value=None):
 
 
979
        if value is None:       # get
 
 
980
            return dbus.Boolean(self.approved_by_default)
 
 
981
        self.approved_by_default = bool(value)
 
 
983
        self.PropertyChanged(dbus.String("ApprovedByDefault"),
 
 
984
                             dbus.Boolean(value, variant_level=1))
 
 
986
    # ApprovalDelay - property
 
 
987
    @dbus_service_property(_interface, signature="t",
 
 
989
    def ApprovalDelay_dbus_property(self, value=None):
 
 
990
        if value is None:       # get
 
 
991
            return dbus.UInt64(self.approval_delay_milliseconds())
 
 
992
        self.approval_delay = datetime.timedelta(0, 0, 0, value)
 
 
994
        self.PropertyChanged(dbus.String("ApprovalDelay"),
 
 
995
                             dbus.UInt64(value, variant_level=1))
 
 
997
    # ApprovalDuration - property
 
 
998
    @dbus_service_property(_interface, signature="t",
 
 
1000
    def ApprovalDuration_dbus_property(self, value=None):
 
 
1001
        if value is None:       # get
 
 
1002
            return dbus.UInt64(self._timedelta_to_milliseconds(
 
 
1003
                    self.approval_duration))
 
 
1004
        self.approval_duration = datetime.timedelta(0, 0, 0, value)
 
 
1006
        self.PropertyChanged(dbus.String("ApprovalDuration"),
 
 
1007
                             dbus.UInt64(value, variant_level=1))
 
 
1010
    @dbus_service_property(_interface, signature="s", access="read")
 
 
1011
    def Name_dbus_property(self):
 
 
1012
        return dbus.String(self.name)
 
 
1014
    # Fingerprint - property
 
 
1015
    @dbus_service_property(_interface, signature="s", access="read")
 
 
1016
    def Fingerprint_dbus_property(self):
 
 
1017
        return dbus.String(self.fingerprint)
 
 
1020
    @dbus_service_property(_interface, signature="s",
 
 
1022
    def Host_dbus_property(self, value=None):
 
 
1023
        if value is None:       # get
 
 
1024
            return dbus.String(self.host)
 
 
1027
        self.PropertyChanged(dbus.String("Host"),
 
 
1028
                             dbus.String(value, variant_level=1))
 
 
1030
    # Created - property
 
 
1031
    @dbus_service_property(_interface, signature="s", access="read")
 
 
1032
    def Created_dbus_property(self):
 
 
1033
        return dbus.String(self._datetime_to_dbus(self.created))
 
 
1035
    # LastEnabled - property
 
 
1036
    @dbus_service_property(_interface, signature="s", access="read")
 
 
1037
    def LastEnabled_dbus_property(self):
 
 
1038
        if self.last_enabled is None:
 
 
1039
            return dbus.String("")
 
 
1040
        return dbus.String(self._datetime_to_dbus(self.last_enabled))
 
 
1042
    # Enabled - property
 
 
1043
    @dbus_service_property(_interface, signature="b",
 
 
1045
    def Enabled_dbus_property(self, value=None):
 
 
1046
        if value is None:       # get
 
 
1047
            return dbus.Boolean(self.enabled)
 
 
1053
    # LastCheckedOK - property
 
 
1054
    @dbus_service_property(_interface, signature="s",
 
 
1056
    def LastCheckedOK_dbus_property(self, value=None):
 
 
1057
        if value is not None:
 
 
1060
        if self.last_checked_ok is None:
 
 
1061
            return dbus.String("")
 
 
1062
        return dbus.String(self._datetime_to_dbus(self
 
 
1065
    # LastApprovalRequest - property
 
 
1066
    @dbus_service_property(_interface, signature="s", access="read")
 
 
1067
    def LastApprovalRequest_dbus_property(self):
 
 
1068
        if self.last_approval_request is None:
 
 
1069
            return dbus.String("")
 
 
1070
        return dbus.String(self.
 
 
1071
                           _datetime_to_dbus(self
 
 
1072
                                             .last_approval_request))
 
 
1074
    # Timeout - property
 
 
1075
    @dbus_service_property(_interface, signature="t",
 
 
1077
    def Timeout_dbus_property(self, value=None):
 
 
1078
        if value is None:       # get
 
 
1079
            return dbus.UInt64(self.timeout_milliseconds())
 
 
1080
        self.timeout = datetime.timedelta(0, 0, 0, value)
 
 
1082
        self.PropertyChanged(dbus.String("Timeout"),
 
 
1083
                             dbus.UInt64(value, variant_level=1))
 
 
1084
        if getattr(self, "disable_initiator_tag", None) is None:
 
 
1086
        # Reschedule timeout
 
 
1087
        gobject.source_remove(self.disable_initiator_tag)
 
 
1088
        self.disable_initiator_tag = None
 
 
1089
        time_to_die = (self.
 
 
1090
                       _timedelta_to_milliseconds((self
 
 
1095
        if time_to_die <= 0:
 
 
1096
            # The timeout has passed
 
 
1099
            self.disable_initiator_tag = (gobject.timeout_add
 
 
1100
                                          (time_to_die, self.disable))
 
 
1102
    # Interval - property
 
 
1103
    @dbus_service_property(_interface, signature="t",
 
 
1105
    def Interval_dbus_property(self, value=None):
 
 
1106
        if value is None:       # get
 
 
1107
            return dbus.UInt64(self.interval_milliseconds())
 
 
1108
        self.interval = datetime.timedelta(0, 0, 0, value)
 
 
1110
        self.PropertyChanged(dbus.String("Interval"),
 
 
1111
                             dbus.UInt64(value, variant_level=1))
 
 
1112
        if getattr(self, "checker_initiator_tag", None) is None:
 
 
1114
        # Reschedule checker run
 
 
1115
        gobject.source_remove(self.checker_initiator_tag)
 
 
1116
        self.checker_initiator_tag = (gobject.timeout_add
 
 
1117
                                      (value, self.start_checker))
 
 
1118
        self.start_checker()    # Start one now, too
 
 
1120
    # Checker - property
 
 
1121
    @dbus_service_property(_interface, signature="s",
 
 
1123
    def Checker_dbus_property(self, value=None):
 
 
1124
        if value is None:       # get
 
 
1125
            return dbus.String(self.checker_command)
 
 
1126
        self.checker_command = value
 
 
1128
        self.PropertyChanged(dbus.String("Checker"),
 
 
1129
                             dbus.String(self.checker_command,
 
 
1132
    # CheckerRunning - property
 
 
1133
    @dbus_service_property(_interface, signature="b",
 
 
1135
    def CheckerRunning_dbus_property(self, value=None):
 
 
1136
        if value is None:       # get
 
 
1137
            return dbus.Boolean(self.checker is not None)
 
 
1139
            self.start_checker()
 
 
1143
    # ObjectPath - property
 
 
1144
    @dbus_service_property(_interface, signature="o", access="read")
 
 
1145
    def ObjectPath_dbus_property(self):
 
 
1146
        return self.dbus_object_path # is already a dbus.ObjectPath
 
 
1149
    @dbus_service_property(_interface, signature="ay",
 
 
1150
                           access="write", byte_arrays=True)
 
 
1151
    def Secret_dbus_property(self, value):
 
 
1152
        self.secret = str(value)
 
 
1157
class ProxyClient(object):
 
 
1158
    def __init__(self, child_pipe, fpr, address):
 
 
1159
        self._pipe = child_pipe
 
 
1160
        self._pipe.send(('init', fpr, address))
 
 
1161
        if not self._pipe.recv():
 
 
1164
    def __getattribute__(self, name):
 
 
1165
        if(name == '_pipe'):
 
 
1166
            return super(ProxyClient, self).__getattribute__(name)
 
 
1167
        self._pipe.send(('getattr', name))
 
 
1168
        data = self._pipe.recv()
 
 
1169
        if data[0] == 'data':
 
 
1171
        if data[0] == 'function':
 
 
1172
            def func(*args, **kwargs):
 
 
1173
                self._pipe.send(('funcall', name, args, kwargs))
 
 
1174
                return self._pipe.recv()[1]
 
 
1177
    def __setattr__(self, name, value):
 
 
1178
        if(name == '_pipe'):
 
 
1179
            return super(ProxyClient, self).__setattr__(name, value)
 
 
1180
        self._pipe.send(('setattr', name, value))
 
750
1183
class ClientHandler(socketserver.BaseRequestHandler, object):
 
751
1184
    """A class to handle client connections.
 
 
754
1187
    Note: This will run in its own forked process."""
 
756
1189
    def handle(self):
 
757
 
        logger.info(u"TCP connection from: %s",
 
758
 
                    unicode(self.client_address))
 
759
 
        logger.debug(u"IPC Pipe FD: %d", self.server.pipe[1])
 
760
 
        # Open IPC pipe to parent process
 
761
 
        with closing(os.fdopen(self.server.pipe[1], u"w", 1)) as ipc:
 
 
1190
        with contextlib.closing(self.server.child_pipe) as child_pipe:
 
 
1191
            logger.info("TCP connection from: %s",
 
 
1192
                        unicode(self.client_address))
 
 
1193
            logger.debug("Pipe FD: %d",
 
 
1194
                         self.server.child_pipe.fileno())
 
762
1196
            session = (gnutls.connection
 
763
1197
                       .ClientSession(self.request,
 
764
1198
                                      gnutls.connection
 
765
1199
                                      .X509Credentials()))
 
767
 
            line = self.request.makefile().readline()
 
768
 
            logger.debug(u"Protocol version: %r", line)
 
770
 
                if int(line.strip().split()[0]) > 1:
 
772
 
            except (ValueError, IndexError, RuntimeError), error:
 
773
 
                logger.error(u"Unknown protocol version: %s", error)
 
776
1201
            # Note: gnutls.connection.X509Credentials is really a
 
777
1202
            # generic GnuTLS certificate credentials object so long as
 
778
1203
            # no X.509 keys are added to it.  Therefore, we can use it
 
779
1204
            # here despite using OpenPGP certificates.
 
781
 
            #priority = u':'.join((u"NONE", u"+VERS-TLS1.1",
 
782
 
            #                      u"+AES-256-CBC", u"+SHA1",
 
783
 
            #                      u"+COMP-NULL", u"+CTYPE-OPENPGP",
 
 
1206
            #priority = ':'.join(("NONE", "+VERS-TLS1.1",
 
 
1207
            #                      "+AES-256-CBC", "+SHA1",
 
 
1208
            #                      "+COMP-NULL", "+CTYPE-OPENPGP",
 
785
1210
            # Use a fallback default, since this MUST be set.
 
786
1211
            priority = self.server.gnutls_priority
 
787
1212
            if priority is None:
 
789
1214
            (gnutls.library.functions
 
790
1215
             .gnutls_priority_set_direct(session._c_object,
 
791
1216
                                         priority, None))
 
 
1218
            # Start communication using the Mandos protocol
 
 
1219
            # Get protocol number
 
 
1220
            line = self.request.makefile().readline()
 
 
1221
            logger.debug("Protocol version: %r", line)
 
 
1223
                if int(line.strip().split()[0]) > 1:
 
 
1225
            except (ValueError, IndexError, RuntimeError) as error:
 
 
1226
                logger.error("Unknown protocol version: %s", error)
 
 
1229
            # Start GnuTLS connection
 
794
1231
                session.handshake()
 
795
 
            except gnutls.errors.GNUTLSError, error:
 
796
 
                logger.warning(u"Handshake failed: %s", error)
 
 
1232
            except gnutls.errors.GNUTLSError as error:
 
 
1233
                logger.warning("Handshake failed: %s", error)
 
797
1234
                # Do not run session.bye() here: the session is not
 
798
1235
                # established.  Just abandon the request.
 
800
 
            logger.debug(u"Handshake succeeded")
 
 
1237
            logger.debug("Handshake succeeded")
 
 
1239
            approval_required = False
 
802
 
                fpr = self.fingerprint(self.peer_certificate(session))
 
803
 
            except (TypeError, gnutls.errors.GNUTLSError), error:
 
804
 
                logger.warning(u"Bad certificate: %s", error)
 
807
 
            logger.debug(u"Fingerprint: %s", fpr)
 
 
1242
                    fpr = self.fingerprint(self.peer_certificate
 
 
1245
                        gnutls.errors.GNUTLSError) as error:
 
 
1246
                    logger.warning("Bad certificate: %s", error)
 
 
1248
                logger.debug("Fingerprint: %s", fpr)
 
 
1251
                    client = ProxyClient(child_pipe, fpr,
 
 
1252
                                         self.client_address)
 
 
1256
                if client.approval_delay:
 
 
1257
                    delay = client.approval_delay
 
 
1258
                    client.approvals_pending += 1
 
 
1259
                    approval_required = True
 
 
1262
                    if not client.enabled:
 
 
1263
                        logger.warning("Client %s is disabled",
 
 
1265
                        if self.server.use_dbus:
 
 
1267
                            client.Rejected("Disabled")                    
 
 
1270
                    if client._approved or not client.approval_delay:
 
 
1271
                        #We are approved or approval is disabled
 
 
1273
                    elif client._approved is None:
 
 
1274
                        logger.info("Client %s needs approval",
 
 
1276
                        if self.server.use_dbus:
 
 
1278
                            client.NeedApproval(
 
 
1279
                                client.approval_delay_milliseconds(),
 
 
1280
                                client.approved_by_default)
 
 
1282
                        logger.warning("Client %s was not approved",
 
 
1284
                        if self.server.use_dbus:
 
 
1286
                            client.Rejected("Denied")
 
 
1289
                    #wait until timeout or approved
 
 
1290
                    #x = float(client._timedelta_to_milliseconds(delay))
 
 
1291
                    time = datetime.datetime.now()
 
 
1292
                    client.changedstate.acquire()
 
 
1293
                    client.changedstate.wait(float(client._timedelta_to_milliseconds(delay) / 1000))
 
 
1294
                    client.changedstate.release()
 
 
1295
                    time2 = datetime.datetime.now()
 
 
1296
                    if (time2 - time) >= delay:
 
 
1297
                        if not client.approved_by_default:
 
 
1298
                            logger.warning("Client %s timed out while"
 
 
1299
                                           " waiting for approval",
 
 
1301
                            if self.server.use_dbus:
 
 
1303
                                client.Rejected("Approval timed out")
 
 
1308
                        delay -= time2 - time
 
 
1311
                while sent_size < len(client.secret):
 
 
1313
                        sent = session.send(client.secret[sent_size:])
 
 
1314
                    except gnutls.errors.GNUTLSError as error:
 
 
1315
                        logger.warning("gnutls send failed")
 
 
1317
                    logger.debug("Sent: %d, remaining: %d",
 
 
1318
                                 sent, len(client.secret)
 
 
1319
                                 - (sent_size + sent))
 
 
1322
                logger.info("Sending secret to %s", client.name)
 
 
1323
                # bump the timeout as if seen
 
 
1325
                if self.server.use_dbus:
 
809
 
            for c in self.server.clients:
 
810
 
                if c.fingerprint == fpr:
 
814
 
                ipc.write(u"NOTFOUND %s %s\n"
 
815
 
                          % (fpr, unicode(self.client_address)))
 
818
 
            # Have to check if client.still_valid(), since it is
 
819
 
            # possible that the client timed out while establishing
 
820
 
            # the GnuTLS session.
 
821
 
            if not client.still_valid():
 
822
 
                ipc.write(u"INVALID %s\n" % client.name)
 
825
 
            ipc.write(u"SENDING %s\n" % client.name)
 
827
 
            while sent_size < len(client.secret):
 
828
 
                sent = session.send(client.secret[sent_size:])
 
829
 
                logger.debug(u"Sent: %d, remaining: %d",
 
830
 
                             sent, len(client.secret)
 
831
 
                             - (sent_size + sent))
 
 
1330
                if approval_required:
 
 
1331
                    client.approvals_pending -= 1
 
 
1334
                except gnutls.errors.GNUTLSError as error:
 
 
1335
                    logger.warning("GnuTLS bye failed")
 
836
1338
    def peer_certificate(session):
 
 
892
1394
        # Convert the buffer to a Python bytestring
 
893
1395
        fpr = ctypes.string_at(buf, buf_len.value)
 
894
1396
        # Convert the bytestring to hexadecimal notation
 
895
 
        hex_fpr = u''.join(u"%02X" % ord(char) for char in fpr)
 
 
1397
        hex_fpr = ''.join("%02X" % ord(char) for char in fpr)
 
899
 
class ForkingMixInWithPipe(socketserver.ForkingMixIn, object):
 
900
 
    """Like socketserver.ForkingMixIn, but also pass a pipe."""
 
 
1401
class MultiprocessingMixIn(object):
 
 
1402
    """Like socketserver.ThreadingMixIn, but with multiprocessing"""
 
 
1403
    def sub_process_main(self, request, address):
 
 
1405
            self.finish_request(request, address)
 
 
1407
            self.handle_error(request, address)
 
 
1408
        self.close_request(request)
 
 
1410
    def process_request(self, request, address):
 
 
1411
        """Start a new process to process the request."""
 
 
1412
        multiprocessing.Process(target = self.sub_process_main,
 
 
1413
                                args = (request, address)).start()
 
 
1415
class MultiprocessingMixInWithPipe(MultiprocessingMixIn, object):
 
 
1416
    """ adds a pipe to the MixIn """
 
901
1417
    def process_request(self, request, client_address):
 
902
1418
        """Overrides and wraps the original process_request().
 
904
1420
        This function creates a new pipe in self.pipe
 
906
 
        self.pipe = os.pipe()
 
907
 
        super(ForkingMixInWithPipe,
 
 
1422
        parent_pipe, self.child_pipe = multiprocessing.Pipe()
 
 
1424
        super(MultiprocessingMixInWithPipe,
 
908
1425
              self).process_request(request, client_address)
 
909
 
        os.close(self.pipe[1])  # close write end
 
910
 
        self.add_pipe(self.pipe[0])
 
911
 
    def add_pipe(self, pipe):
 
 
1426
        self.child_pipe.close()
 
 
1427
        self.add_pipe(parent_pipe)
 
 
1429
    def add_pipe(self, parent_pipe):
 
912
1430
        """Dummy function; override as necessary"""
 
916
 
class IPv6_TCPServer(ForkingMixInWithPipe,
 
 
1431
        raise NotImplementedError
 
 
1433
class IPv6_TCPServer(MultiprocessingMixInWithPipe,
 
917
1434
                     socketserver.TCPServer, object):
 
918
1435
    """IPv6-capable TCP server.  Accepts 'None' as address and/or port
 
 
1026
1544
                                       for cond, name in
 
1027
1545
                                       condition_names.iteritems()
 
1028
1546
                                       if cond & condition)
 
1029
 
        logger.debug(u"Handling IPC: FD = %d, condition = %s", source,
 
1032
 
        # Turn the pipe file descriptor into a Python file object
 
1033
 
        if source not in file_objects:
 
1034
 
            file_objects[source] = os.fdopen(source, u"r", 1)
 
1036
 
        # Read a line from the file object
 
1037
 
        cmdline = file_objects[source].readline()
 
1038
 
        if not cmdline:             # Empty line means end of file
 
1039
 
            # close the IPC pipe
 
1040
 
            file_objects[source].close()
 
1041
 
            del file_objects[source]
 
1043
 
            # Stop calling this function
 
1046
 
        logger.debug(u"IPC command: %r", cmdline)
 
1048
 
        # Parse and act on command
 
1049
 
        cmd, args = cmdline.rstrip(u"\r\n").split(None, 1)
 
1051
 
        if cmd == u"NOTFOUND":
 
1052
 
            logger.warning(u"Client not found for fingerprint: %s",
 
1056
 
                mandos_dbus_service.ClientNotFound(args)
 
1057
 
        elif cmd == u"INVALID":
 
1058
 
            for client in self.clients:
 
1059
 
                if client.name == args:
 
1060
 
                    logger.warning(u"Client %s is invalid", args)
 
1066
 
                logger.error(u"Unknown client %s is invalid", args)
 
1067
 
        elif cmd == u"SENDING":
 
1068
 
            for client in self.clients:
 
1069
 
                if client.name == args:
 
1070
 
                    logger.info(u"Sending secret to %s", client.name)
 
1074
 
                        client.ReceivedSecret()
 
1077
 
                logger.error(u"Sending secret to unknown client %s",
 
1080
 
            logger.error(u"Unknown IPC command: %r", cmdline)
 
1082
 
        # Keep calling this function
 
 
1547
        # error or the other end of multiprocessing.Pipe has closed
 
 
1548
        if condition & (gobject.IO_ERR | condition & gobject.IO_HUP):
 
 
1551
        # Read a request from the child
 
 
1552
        request = parent_pipe.recv()
 
 
1553
        command = request[0]
 
 
1555
        if command == 'init':
 
 
1557
            address = request[2]
 
 
1559
            for c in self.clients:
 
 
1560
                if c.fingerprint == fpr:
 
 
1564
                logger.warning("Client not found for fingerprint: %s, ad"
 
 
1565
                               "dress: %s", fpr, address)
 
 
1568
                    mandos_dbus_service.ClientNotFound(fpr, address[0])
 
 
1569
                parent_pipe.send(False)
 
 
1572
            gobject.io_add_watch(parent_pipe.fileno(),
 
 
1573
                                 gobject.IO_IN | gobject.IO_HUP,
 
 
1574
                                 functools.partial(self.handle_ipc,
 
 
1575
                                                   parent_pipe = parent_pipe,
 
 
1576
                                                   client_object = client))
 
 
1577
            parent_pipe.send(True)
 
 
1578
            # remove the old hook in favor of the new above hook on same fileno
 
 
1580
        if command == 'funcall':
 
 
1581
            funcname = request[1]
 
 
1585
            parent_pipe.send(('data', getattr(client_object, funcname)(*args, **kwargs)))
 
 
1587
        if command == 'getattr':
 
 
1588
            attrname = request[1]
 
 
1589
            if callable(client_object.__getattribute__(attrname)):
 
 
1590
                parent_pipe.send(('function',))
 
 
1592
                parent_pipe.send(('data', client_object.__getattribute__(attrname)))
 
 
1594
        if command == 'setattr':
 
 
1595
            attrname = request[1]
 
 
1597
            setattr(client_object, attrname, value)
 
1086
1602
def string_to_delta(interval):
 
1087
1603
    """Parse a string and return a datetime.timedelta
 
1089
 
    >>> string_to_delta(u'7d')
 
 
1605
    >>> string_to_delta('7d')
 
1090
1606
    datetime.timedelta(7)
 
1091
 
    >>> string_to_delta(u'60s')
 
 
1607
    >>> string_to_delta('60s')
 
1092
1608
    datetime.timedelta(0, 60)
 
1093
 
    >>> string_to_delta(u'60m')
 
 
1609
    >>> string_to_delta('60m')
 
1094
1610
    datetime.timedelta(0, 3600)
 
1095
 
    >>> string_to_delta(u'24h')
 
 
1611
    >>> string_to_delta('24h')
 
1096
1612
    datetime.timedelta(1)
 
1097
 
    >>> string_to_delta(u'1w')
 
 
1613
    >>> string_to_delta('1w')
 
1098
1614
    datetime.timedelta(7)
 
1099
 
    >>> string_to_delta(u'5m 30s')
 
 
1615
    >>> string_to_delta('5m 30s')
 
1100
1616
    datetime.timedelta(0, 330)
 
1102
1618
    timevalue = datetime.timedelta(0)
 
 
1175
 
    ######################################################################
 
 
1692
    ##################################################################
 
1176
1693
    # Parsing of options, both command line and config file
 
1178
 
    parser = optparse.OptionParser(version = "%%prog %s" % version)
 
1179
 
    parser.add_option("-i", u"--interface", type=u"string",
 
1180
 
                      metavar="IF", help=u"Bind to interface IF")
 
1181
 
    parser.add_option("-a", u"--address", type=u"string",
 
1182
 
                      help=u"Address to listen for requests on")
 
1183
 
    parser.add_option("-p", u"--port", type=u"int",
 
1184
 
                      help=u"Port number to receive requests on")
 
1185
 
    parser.add_option("--check", action=u"store_true",
 
1186
 
                      help=u"Run self-test")
 
1187
 
    parser.add_option("--debug", action=u"store_true",
 
1188
 
                      help=u"Debug mode; run in foreground and log to"
 
1190
 
    parser.add_option("--priority", type=u"string", help=u"GnuTLS"
 
1191
 
                      u" priority string (see GnuTLS documentation)")
 
1192
 
    parser.add_option("--servicename", type=u"string",
 
1193
 
                      metavar=u"NAME", help=u"Zeroconf service name")
 
1194
 
    parser.add_option("--configdir", type=u"string",
 
1195
 
                      default=u"/etc/mandos", metavar=u"DIR",
 
1196
 
                      help=u"Directory to search for configuration"
 
1198
 
    parser.add_option("--no-dbus", action=u"store_false",
 
1199
 
                      dest=u"use_dbus", help=u"Do not provide D-Bus"
 
1200
 
                      u" system bus interface")
 
1201
 
    parser.add_option("--no-ipv6", action=u"store_false",
 
1202
 
                      dest=u"use_ipv6", help=u"Do not use IPv6")
 
1203
 
    options = parser.parse_args()[0]
 
 
1695
    parser = argparse.ArgumentParser()
 
 
1696
    parser.add_argument("-v", "--version", action="version",
 
 
1697
                        version = "%%(prog)s %s" % version,
 
 
1698
                        help="show version number and exit")
 
 
1699
    parser.add_argument("-i", "--interface", metavar="IF",
 
 
1700
                        help="Bind to interface IF")
 
 
1701
    parser.add_argument("-a", "--address",
 
 
1702
                        help="Address to listen for requests on")
 
 
1703
    parser.add_argument("-p", "--port", type=int,
 
 
1704
                        help="Port number to receive requests on")
 
 
1705
    parser.add_argument("--check", action="store_true",
 
 
1706
                        help="Run self-test")
 
 
1707
    parser.add_argument("--debug", action="store_true",
 
 
1708
                        help="Debug mode; run in foreground and log"
 
 
1710
    parser.add_argument("--debuglevel", metavar="LEVEL",
 
 
1711
                        help="Debug level for stdout output")
 
 
1712
    parser.add_argument("--priority", help="GnuTLS"
 
 
1713
                        " priority string (see GnuTLS documentation)")
 
 
1714
    parser.add_argument("--servicename",
 
 
1715
                        metavar="NAME", help="Zeroconf service name")
 
 
1716
    parser.add_argument("--configdir",
 
 
1717
                        default="/etc/mandos", metavar="DIR",
 
 
1718
                        help="Directory to search for configuration"
 
 
1720
    parser.add_argument("--no-dbus", action="store_false",
 
 
1721
                        dest="use_dbus", help="Do not provide D-Bus"
 
 
1722
                        " system bus interface")
 
 
1723
    parser.add_argument("--no-ipv6", action="store_false",
 
 
1724
                        dest="use_ipv6", help="Do not use IPv6")
 
 
1725
    options = parser.parse_args()
 
1205
1727
    if options.check:
 
 
1210
1732
    # Default values for config file for server-global settings
 
1211
 
    server_defaults = { u"interface": u"",
 
1216
 
                        u"SECURE256:!CTYPE-X.509:+CTYPE-OPENPGP",
 
1217
 
                        u"servicename": u"Mandos",
 
1218
 
                        u"use_dbus": u"True",
 
1219
 
                        u"use_ipv6": u"True",
 
 
1733
    server_defaults = { "interface": "",
 
 
1738
                        "SECURE256:!CTYPE-X.509:+CTYPE-OPENPGP",
 
 
1739
                        "servicename": "Mandos",
 
1222
1745
    # Parse config file for server-global settings
 
1223
1746
    server_config = configparser.SafeConfigParser(server_defaults)
 
1224
1747
    del server_defaults
 
1225
1748
    server_config.read(os.path.join(options.configdir,
 
1227
1750
    # Convert the SafeConfigParser object to a dict
 
1228
1751
    server_settings = server_config.defaults()
 
1229
1752
    # Use the appropriate methods on the non-string config options
 
1230
 
    for option in (u"debug", u"use_dbus", u"use_ipv6"):
 
1231
 
        server_settings[option] = server_config.getboolean(u"DEFAULT",
 
 
1753
    for option in ("debug", "use_dbus", "use_ipv6"):
 
 
1754
        server_settings[option] = server_config.getboolean("DEFAULT",
 
1233
1756
    if server_settings["port"]:
 
1234
 
        server_settings["port"] = server_config.getint(u"DEFAULT",
 
 
1757
        server_settings["port"] = server_config.getint("DEFAULT",
 
1236
1759
    del server_config
 
1238
1761
    # Override the settings from the config file with command line
 
1239
1762
    # options, if set.
 
1240
 
    for option in (u"interface", u"address", u"port", u"debug",
 
1241
 
                   u"priority", u"servicename", u"configdir",
 
1242
 
                   u"use_dbus", u"use_ipv6"):
 
 
1763
    for option in ("interface", "address", "port", "debug",
 
 
1764
                   "priority", "servicename", "configdir",
 
 
1765
                   "use_dbus", "use_ipv6", "debuglevel"):
 
1243
1766
        value = getattr(options, option)
 
1244
1767
        if value is not None:
 
1245
1768
            server_settings[option] = value
 
 
1253
1776
    ##################################################################
 
1255
1778
    # For convenience
 
1256
 
    debug = server_settings[u"debug"]
 
1257
 
    use_dbus = server_settings[u"use_dbus"]
 
1258
 
    use_ipv6 = server_settings[u"use_ipv6"]
 
1261
 
        syslogger.setLevel(logging.WARNING)
 
1262
 
        console.setLevel(logging.WARNING)
 
1264
 
    if server_settings[u"servicename"] != u"Mandos":
 
 
1779
    debug = server_settings["debug"]
 
 
1780
    debuglevel = server_settings["debuglevel"]
 
 
1781
    use_dbus = server_settings["use_dbus"]
 
 
1782
    use_ipv6 = server_settings["use_ipv6"]
 
 
1784
    if server_settings["servicename"] != "Mandos":
 
1265
1785
        syslogger.setFormatter(logging.Formatter
 
1266
 
                               (u'Mandos (%s) [%%(process)d]:'
 
1267
 
                                u' %%(levelname)s: %%(message)s'
 
1268
 
                                % server_settings[u"servicename"]))
 
 
1786
                               ('Mandos (%s) [%%(process)d]:'
 
 
1787
                                ' %%(levelname)s: %%(message)s'
 
 
1788
                                % server_settings["servicename"]))
 
1270
1790
    # Parse config file with clients
 
1271
 
    client_defaults = { u"timeout": u"1h",
 
1273
 
                        u"checker": u"fping -q -- %%(host)s",
 
 
1791
    client_defaults = { "timeout": "1h",
 
 
1793
                        "checker": "fping -q -- %%(host)s",
 
 
1795
                        "approval_delay": "0s",
 
 
1796
                        "approval_duration": "1s",
 
1276
1798
    client_config = configparser.SafeConfigParser(client_defaults)
 
1277
 
    client_config.read(os.path.join(server_settings[u"configdir"],
 
 
1799
    client_config.read(os.path.join(server_settings["configdir"],
 
1280
1802
    global mandos_dbus_service
 
1281
1803
    mandos_dbus_service = None
 
1283
 
    tcp_server = MandosServer((server_settings[u"address"],
 
1284
 
                               server_settings[u"port"]),
 
 
1805
    tcp_server = MandosServer((server_settings["address"],
 
 
1806
                               server_settings["port"]),
 
1286
 
                              interface=server_settings[u"interface"],
 
 
1808
                              interface=(server_settings["interface"]
 
1287
1810
                              use_ipv6=use_ipv6,
 
1288
1811
                              gnutls_priority=
 
1289
 
                              server_settings[u"priority"],
 
 
1812
                              server_settings["priority"],
 
1290
1813
                              use_dbus=use_dbus)
 
1291
 
    pidfilename = u"/var/run/mandos.pid"
 
1293
 
        pidfile = open(pidfilename, u"w")
 
1295
 
        logger.error(u"Could not open file %r", pidfilename)
 
 
1815
        pidfilename = "/var/run/mandos.pid"
 
 
1817
            pidfile = open(pidfilename, "w")
 
 
1819
            logger.error("Could not open file %r", pidfilename)
 
1298
 
        uid = pwd.getpwnam(u"_mandos").pw_uid
 
1299
 
        gid = pwd.getpwnam(u"_mandos").pw_gid
 
 
1822
        uid = pwd.getpwnam("_mandos").pw_uid
 
 
1823
        gid = pwd.getpwnam("_mandos").pw_gid
 
1300
1824
    except KeyError:
 
1302
 
            uid = pwd.getpwnam(u"mandos").pw_uid
 
1303
 
            gid = pwd.getpwnam(u"mandos").pw_gid
 
 
1826
            uid = pwd.getpwnam("mandos").pw_uid
 
 
1827
            gid = pwd.getpwnam("mandos").pw_gid
 
1304
1828
        except KeyError:
 
1306
 
                uid = pwd.getpwnam(u"nobody").pw_uid
 
1307
 
                gid = pwd.getpwnam(u"nobody").pw_gid
 
 
1830
                uid = pwd.getpwnam("nobody").pw_uid
 
 
1831
                gid = pwd.getpwnam("nobody").pw_gid
 
1308
1832
            except KeyError:
 
1314
 
    except OSError, error:
 
 
1838
    except OSError as error:
 
1315
1839
        if error[0] != errno.EPERM:
 
1318
 
    # Enable all possible GnuTLS debugging
 
 
1842
    if not debug and not debuglevel:
 
 
1843
        syslogger.setLevel(logging.WARNING)
 
 
1844
        console.setLevel(logging.WARNING)
 
 
1846
        level = getattr(logging, debuglevel.upper())
 
 
1847
        syslogger.setLevel(level)
 
 
1848
        console.setLevel(level)
 
 
1851
        # Enable all possible GnuTLS debugging
 
1320
1853
        # "Use a log level over 10 to enable all debugging options."
 
1321
1854
        # - GnuTLS manual
 
1322
1855
        gnutls.library.functions.gnutls_global_set_log_level(11)
 
1324
1857
        @gnutls.library.types.gnutls_log_func
 
1325
1858
        def debug_gnutls(level, string):
 
1326
 
            logger.debug(u"GnuTLS: %s", string[:-1])
 
 
1859
            logger.debug("GnuTLS: %s", string[:-1])
 
1328
1861
        (gnutls.library.functions
 
1329
1862
         .gnutls_global_set_log_function(debug_gnutls))
 
 
1864
        # Redirect stdin so all checkers get /dev/null
 
 
1865
        null = os.open(os.path.devnull, os.O_NOCTTY | os.O_RDWR)
 
 
1866
        os.dup2(null, sys.stdin.fileno())
 
 
1870
        # No console logging
 
 
1871
        logger.removeHandler(console)
 
 
1873
    # Need to fork before connecting to D-Bus
 
 
1875
        # Close all input and output, do double fork, etc.
 
1331
1878
    global main_loop
 
1332
1879
    # From the Avahi example code
 
 
1335
1882
    bus = dbus.SystemBus()
 
1336
1883
    # End of Avahi example code
 
1338
 
        bus_name = dbus.service.BusName(u"se.bsnet.fukt.Mandos", bus)
 
 
1886
            bus_name = dbus.service.BusName("se.bsnet.fukt.Mandos",
 
 
1887
                                            bus, do_not_queue=True)
 
 
1888
        except dbus.exceptions.NameExistsException as e:
 
 
1889
            logger.error(unicode(e) + ", disabling D-Bus")
 
 
1891
            server_settings["use_dbus"] = False
 
 
1892
            tcp_server.use_dbus = False
 
1339
1893
    protocol = avahi.PROTO_INET6 if use_ipv6 else avahi.PROTO_INET
 
1340
 
    service = AvahiService(name = server_settings[u"servicename"],
 
1341
 
                           servicetype = u"_mandos._tcp",
 
 
1894
    service = AvahiService(name = server_settings["servicename"],
 
 
1895
                           servicetype = "_mandos._tcp",
 
1342
1896
                           protocol = protocol, bus = bus)
 
1343
1897
    if server_settings["interface"]:
 
1344
1898
        service.interface = (if_nametoindex
 
1345
 
                             (str(server_settings[u"interface"])))
 
 
1899
                             (str(server_settings["interface"])))
 
 
1901
    global multiprocessing_manager
 
 
1902
    multiprocessing_manager = multiprocessing.Manager()
 
1347
1904
    client_class = Client
 
1349
1906
        client_class = functools.partial(ClientDBus, bus = bus)
 
 
1907
    def client_config_items(config, section):
 
 
1908
        special_settings = {
 
 
1909
            "approved_by_default":
 
 
1910
                lambda: config.getboolean(section,
 
 
1911
                                          "approved_by_default"),
 
 
1913
        for name, value in config.items(section):
 
 
1915
                yield (name, special_settings[name]())
 
1350
1919
    tcp_server.clients.update(set(
 
1351
1920
            client_class(name = section,
 
1352
 
                         config= dict(client_config.items(section)))
 
 
1921
                         config= dict(client_config_items(
 
 
1922
                        client_config, section)))
 
1353
1923
            for section in client_config.sections()))
 
1354
1924
    if not tcp_server.clients:
 
1355
 
        logger.warning(u"No clients defined")
 
1358
 
        # Redirect stdin so all checkers get /dev/null
 
1359
 
        null = os.open(os.path.devnull, os.O_NOCTTY | os.O_RDWR)
 
1360
 
        os.dup2(null, sys.stdin.fileno())
 
1364
 
        # No console logging
 
1365
 
        logger.removeHandler(console)
 
1366
 
        # Close all input and output, do double fork, etc.
 
1370
 
        with closing(pidfile):
 
1372
 
            pidfile.write(str(pid) + "\n")
 
1375
 
        logger.error(u"Could not write to file %r with PID %d",
 
1378
 
        # "pidfile" was never created
 
1383
 
        "Cleanup function; run on exit"
 
 
1925
        logger.warning("No clients defined")
 
1386
 
        while tcp_server.clients:
 
1387
 
            client = tcp_server.clients.pop()
 
1388
 
            client.disable_hook = None
 
1391
 
    atexit.register(cleanup)
 
 
1931
                pidfile.write(str(pid) + "\n".encode("utf-8"))
 
 
1934
            logger.error("Could not write to file %r with PID %d",
 
 
1937
            # "pidfile" was never created
 
1394
1941
        signal.signal(signal.SIGINT, signal.SIG_IGN)
 
1395
1943
    signal.signal(signal.SIGHUP, lambda signum, frame: sys.exit())
 
1396
1944
    signal.signal(signal.SIGTERM, lambda signum, frame: sys.exit())
 
 
1399
1947
        class MandosDBusService(dbus.service.Object):
 
1400
1948
            """A D-Bus proxy object"""
 
1401
1949
            def __init__(self):
 
1402
 
                dbus.service.Object.__init__(self, bus, u"/")
 
1403
 
            _interface = u"se.bsnet.fukt.Mandos"
 
1405
 
            @dbus.service.signal(_interface, signature=u"oa{sv}")
 
1406
 
            def ClientAdded(self, objpath, properties):
 
1410
 
            @dbus.service.signal(_interface, signature=u"s")
 
1411
 
            def ClientNotFound(self, fingerprint):
 
1415
 
            @dbus.service.signal(_interface, signature=u"os")
 
 
1950
                dbus.service.Object.__init__(self, bus, "/")
 
 
1951
            _interface = "se.bsnet.fukt.Mandos"
 
 
1953
            @dbus.service.signal(_interface, signature="o")
 
 
1954
            def ClientAdded(self, objpath):
 
 
1958
            @dbus.service.signal(_interface, signature="ss")
 
 
1959
            def ClientNotFound(self, fingerprint, address):
 
 
1963
            @dbus.service.signal(_interface, signature="os")
 
1416
1964
            def ClientRemoved(self, objpath, name):
 
1420
 
            @dbus.service.method(_interface, out_signature=u"ao")
 
 
1968
            @dbus.service.method(_interface, out_signature="ao")
 
1421
1969
            def GetAllClients(self):
 
1423
1971
                return dbus.Array(c.dbus_object_path
 
1424
1972
                                  for c in tcp_server.clients)
 
1426
1974
            @dbus.service.method(_interface,
 
1427
 
                                 out_signature=u"a{oa{sv}}")
 
 
1975
                                 out_signature="a{oa{sv}}")
 
1428
1976
            def GetAllClientsWithProperties(self):
 
1430
1978
                return dbus.Dictionary(
 
1431
 
                    ((c.dbus_object_path, c.GetAllProperties())
 
 
1979
                    ((c.dbus_object_path, c.GetAll(""))
 
1432
1980
                     for c in tcp_server.clients),
 
1433
 
                    signature=u"oa{sv}")
 
1435
 
            @dbus.service.method(_interface, in_signature=u"o")
 
 
1983
            @dbus.service.method(_interface, in_signature="o")
 
1436
1984
            def RemoveClient(self, object_path):
 
1438
1986
                for c in tcp_server.clients: