To get this branch, use:
bzr branch
http://bzr.recompile.se/loggerhead/mandos/trunk
« back to all changes in this revision
Viewing changes to plugin-runner.c
- browse files at revision 463.1.6
- compare with another revision
- download diff
- download tarball
- view history from revision 463.1.6
- Committer: teddy at bsnet
- Date: 2011-02-13 10:19:26 UTC
- mto: This revision was merged to the branch mainline in revision 465.
- Revision ID: teddy@fukt.bsnet.se-20110213101926-ve878ub7l59ib6jn
* mandos: Bug fix: pass str("/dev/log") to logging.SysLogHandler(),
not unicode string.
not unicode string.
- files removed:
- bugs.xml
- debian/upstream
- network-hooks.d
- plugin-helpers
- files modified:
- .bzrignore
added
removed
plugin-runner.c
2
2
/*
3
3
* Mandos plugin runner - Run Mandos plugins
4
4
*
5
* Copyright © 2008-2017 Teddy Hogeborn
6
* Copyright © 2008-2017 Björn Påhlsson
7
*
8
* This file is part of Mandos.
9
*
10
* Mandos is free software: you can redistribute it and/or modify it
11
* under the terms of the GNU General Public License as published by
12
* the Free Software Foundation, either version 3 of the License, or
13
* (at your option) any later version.
14
*
15
* Mandos is distributed in the hope that it will be useful, but
5
* Copyright © 2008-2010 Teddy Hogeborn
6
* Copyright © 2008-2010 Björn Påhlsson
7
*
8
* This program is free software: you can redistribute it and/or
9
* modify it under the terms of the GNU General Public License as
10
* published by the Free Software Foundation, either version 3 of the
11
* License, or (at your option) any later version.
12
*
13
* This program is distributed in the hope that it will be useful, but
16
14
* WITHOUT ANY WARRANTY; without even the implied warranty of
17
15
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
18
16
* General Public License for more details.
19
17
*
20
18
* You should have received a copy of the GNU General Public License
21
* along with Mandos. If not, see <http://www.gnu.org/licenses/>.
19
* along with this program. If not, see
20
* <http://www.gnu.org/licenses/>.
22
21
*
23
* Contact the authors at <mandos@recompile.se>.
22
* Contact the authors at <mandos@fukt.bsnet.se>.
24
23
*/
25
24
26
25
#define _GNU_SOURCE /* TEMP_FAILURE_RETRY(), getline(),
27
O_CLOEXEC, pipe2() */
26
asprintf(), O_CLOEXEC */
28
27
#include <stddef.h> /* size_t, NULL */
29
28
#include <stdlib.h> /* malloc(), exit(), EXIT_SUCCESS,
30
29
realloc() */
31
30
#include <stdbool.h> /* bool, true, false */
32
31
#include <stdio.h> /* fileno(), fprintf(),
33
stderr, STDOUT_FILENO, fclose() */
34
#include <sys/types.h> /* fstat(), struct stat, waitpid(),
35
WIFEXITED(), WEXITSTATUS(), wait(),
36
pid_t, uid_t, gid_t, getuid(),
37
getgid() */
32
stderr, STDOUT_FILENO */
33
#include <sys/types.h> /* DIR, fdopendir(), stat(), struct
34
stat, waitpid(), WIFEXITED(),
35
WEXITSTATUS(), wait(), pid_t,
36
uid_t, gid_t, getuid(), getgid(),
37
dirfd() */
38
38
#include <sys/select.h> /* fd_set, select(), FD_ZERO(),
39
39
FD_SET(), FD_ISSET(), FD_CLR */
40
40
#include <sys/wait.h> /* wait(), waitpid(), WIFEXITED(),
41
WEXITSTATUS(), WTERMSIG() */
42
#include <sys/stat.h> /* struct stat, fstat(), S_ISREG() */
41
WEXITSTATUS(), WTERMSIG(),
42
WCOREDUMP() */
43
#include <sys/stat.h> /* struct stat, stat(), S_ISREG() */
43
44
#include <iso646.h> /* and, or, not */
44
#include <dirent.h> /* struct dirent, scandirat() */
45
#include <unistd.h> /* fcntl(), F_GETFD, F_SETFD,
46
FD_CLOEXEC, write(), STDOUT_FILENO,
47
struct stat, fstat(), close(),
48
setgid(), setuid(), S_ISREG(),
49
faccessat() pipe2(), fork(),
50
_exit(), dup2(), fexecve(), read()
51
*/
45
#include <dirent.h> /* DIR, struct dirent, fdopendir(),
46
readdir(), closedir(), dirfd() */
47
#include <unistd.h> /* struct stat, stat(), S_ISREG(),
48
fcntl(), setuid(), setgid(),
49
F_GETFD, F_SETFD, FD_CLOEXEC,
50
access(), pipe(), fork(), close()
51
dup2(), STDOUT_FILENO, _exit(),
52
execv(), write(), read(),
53
close() */
52
54
#include <fcntl.h> /* fcntl(), F_GETFD, F_SETFD,
53
FD_CLOEXEC, openat(), scandirat(),
54
pipe2() */
55
#include <string.h> /* strsep, strlen(), strsignal(),
56
strcmp(), strncmp() */
55
FD_CLOEXEC */
56
#include <string.h> /* strsep, strlen(), asprintf(),
57
strsignal(), strcmp(), strncmp() */
57
58
#include <errno.h> /* errno */
58
59
#include <argp.h> /* struct argp_option, struct
59
60
argp_state, struct argp,
71
72
EX_CONFIG, EX_UNAVAILABLE, EX_OK */
72
73
#include <errno.h> /* errno */
73
74
#include <error.h> /* error() */
74
#include <fnmatch.h> /* fnmatch() */
75
75
76
76
#define BUFFER_SIZE 256
77
77
78
78
#define PDIR "/lib/mandos/plugins.d"
79
#define PHDIR "/lib/mandos/plugin-helpers"
80
79
#define AFILE "/conf/conf.d/mandos/plugin-runner.conf"
81
80
82
81
const char *argp_program_version = "plugin-runner " VERSION;
83
const char *argp_program_bug_address = "<mandos@recompile.se>";
82
const char *argp_program_bug_address = "<mandos@fukt.bsnet.se>";
84
83
85
84
typedef struct plugin{
86
85
char *name; /* can be NULL or any plugin name */
106
105
107
106
/* Gets an existing plugin based on name,
108
107
or if none is found, creates a new one */
109
__attribute__((warn_unused_result))
110
108
static plugin *getplugin(char *name){
111
109
/* Check for existing plugin with that name */
112
110
for(plugin *p = plugin_list; p != NULL; p = p->next){
173
171
}
174
172
175
173
/* Helper function for add_argument and add_environment */
176
__attribute__((nonnull, warn_unused_result))
177
174
static bool add_to_char_array(const char *new, char ***array,
178
175
int *len){
179
176
/* Resize the pointed-to array to hold one more pointer */
180
char **new_array = NULL;
181
177
do {
182
new_array = realloc(*array, sizeof(char *)
183
* (size_t) ((*len) + 2));
184
} while(new_array == NULL and errno == EINTR);
178
*array = realloc(*array, sizeof(char *)
179
* (size_t) ((*len) + 2));
180
} while(*array == NULL and errno == EINTR);
185
181
/* Malloc check */
186
if(new_array == NULL){
182
if(*array == NULL){
187
183
return false;
188
184
}
189
*array = new_array;
190
185
/* Make a copy of the new string */
191
186
char *copy;
192
187
do {
204
199
}
205
200
206
201
/* Add to a plugin's argument vector */
207
__attribute__((nonnull(2), warn_unused_result))
208
202
static bool add_argument(plugin *p, const char *arg){
209
203
if(p == NULL){
210
204
return false;
213
207
}
214
208
215
209
/* Add to a plugin's environment */
216
__attribute__((nonnull(2), warn_unused_result))
217
210
static bool add_environment(plugin *p, const char *def, bool replace){
218
211
if(p == NULL){
219
212
return false;
221
214
/* namelen = length of name of environment variable */
222
215
size_t namelen = (size_t)(strchrnul(def, '=') - def);
223
216
/* Search for this environment variable */
224
for(char **envdef = p->environ; *envdef != NULL; envdef++){
225
if(strncmp(*envdef, def, namelen + 1) == 0){
217
for(char **e = p->environ; *e != NULL; e++){
218
if(strncmp(*e, def, namelen + 1) == 0){
226
219
/* It already exists */
227
220
if(replace){
228
char *new_envdef;
221
char *new;
229
222
do {
230
new_envdef = realloc(*envdef, strlen(def) + 1);
231
} while(new_envdef == NULL and errno == EINTR);
232
if(new_envdef == NULL){
223
new = realloc(*e, strlen(def) + 1);
224
} while(new == NULL and errno == EINTR);
225
if(new == NULL){
233
226
return false;
234
227
}
235
*envdef = new_envdef;
236
strcpy(*envdef, def);
228
*e = new;
229
strcpy(*e, def);
237
230
}
238
231
return true;
239
232
}
241
234
return add_to_char_array(def, &(p->environ), &(p->envc));
242
235
}
243
236
244
#ifndef O_CLOEXEC
245
237
/*
246
238
* Based on the example in the GNU LibC manual chapter 13.13 "File
247
239
* Descriptor Flags".
248
240
| [[info:libc:Descriptor%20Flags][File Descriptor Flags]] |
249
241
*/
250
__attribute__((warn_unused_result))
251
242
static int set_cloexec_flag(int fd){
252
243
int ret = (int)TEMP_FAILURE_RETRY(fcntl(fd, F_GETFD, 0));
253
244
/* If reading the flags failed, return error indication now. */
258
249
return (int)TEMP_FAILURE_RETRY(fcntl(fd, F_SETFD,
259
250
ret | FD_CLOEXEC));
260
251
}
261
#endif /* not O_CLOEXEC */
262
252
263
253
264
254
/* Mark processes as completed when they exit, and save their exit
296
286
}
297
287
298
288
/* Prints out a password to stdout */
299
__attribute__((nonnull, warn_unused_result))
300
289
static bool print_out_password(const char *buffer, size_t length){
301
290
ssize_t ret;
302
291
for(size_t written = 0; written < length; written += (size_t)ret){
310
299
}
311
300
312
301
/* Removes and free a plugin from the plugin list */
313
__attribute__((nonnull))
314
302
static void free_plugin(plugin *plugin_node){
315
303
316
304
for(char **arg = plugin_node->argv; *arg != NULL; arg++){
348
336
349
337
int main(int argc, char *argv[]){
350
338
char *plugindir = NULL;
351
char *pluginhelperdir = NULL;
352
339
char *argfile = NULL;
353
340
FILE *conffp;
354
struct dirent **direntries = NULL;
341
size_t d_name_len;
342
DIR *dir = NULL;
343
struct dirent *dirst;
355
344
struct stat st;
356
345
fd_set rfds_all;
357
346
int ret, maxfd = 0;
365
354
.sa_flags = SA_NOCLDSTOP };
366
355
char **custom_argv = NULL;
367
356
int custom_argc = 0;
368
int dir_fd = -1;
369
357
370
358
/* Establish a signal handler */
371
359
sigemptyset(&sigchld_action.sa_mask);
416
404
.doc = "Group ID the plugins will run as", .group = 3 },
417
405
{ .name = "debug", .key = 132,
418
406
.doc = "Debug mode", .group = 4 },
419
{ .name = "plugin-helper-dir", .key = 133,
420
.arg = "DIRECTORY",
421
.doc = "Specify a different plugin helper directory",
422
.group = 2 },
423
407
/*
424
408
* These reproduce what we would get without ARGP_NO_HELP
425
409
*/
432
416
{ .name = NULL }
433
417
};
434
418
435
__attribute__((nonnull(3)))
436
419
error_t parse_opt(int key, char *arg, struct argp_state *state){
437
420
errno = 0;
438
421
switch(key){
439
422
char *tmp;
440
intmax_t tmp_id;
423
intmax_t tmpmax;
441
424
case 'g': /* --global-options */
442
425
{
443
426
char *plugin_option;
446
429
break;
447
430
}
448
431
}
449
errno = 0;
450
432
}
451
433
break;
452
434
case 'G': /* --global-env */
453
if(add_environment(getplugin(NULL), arg, true)){
454
errno = 0;
455
}
435
add_environment(getplugin(NULL), arg, true);
456
436
break;
457
437
case 'o': /* --options-for */
458
438
{
475
455
break;
476
456
}
477
457
}
478
errno = 0;
479
458
}
480
459
break;
481
460
case 'E': /* --env-for */
493
472
errno = EINVAL;
494
473
break;
495
474
}
496
if(add_environment(getplugin(arg), envdef, true)){
497
errno = 0;
498
}
475
add_environment(getplugin(arg), envdef, true);
499
476
}
500
477
break;
501
478
case 'd': /* --disable */
503
480
plugin *p = getplugin(arg);
504
481
if(p != NULL){
505
482
p->disabled = true;
506
errno = 0;
507
483
}
508
484
}
509
485
break;
512
488
plugin *p = getplugin(arg);
513
489
if(p != NULL){
514
490
p->disabled = false;
515
errno = 0;
516
491
}
517
492
}
518
493
break;
519
494
case 128: /* --plugin-dir */
520
495
free(plugindir);
521
496
plugindir = strdup(arg);
522
if(plugindir != NULL){
523
errno = 0;
524
}
525
497
break;
526
498
case 129: /* --config-file */
527
499
/* This is already done by parse_opt_config_file() */
528
500
break;
529
501
case 130: /* --userid */
530
tmp_id = strtoimax(arg, &tmp, 10);
502
tmpmax = strtoimax(arg, &tmp, 10);
531
503
if(errno != 0 or tmp == arg or *tmp != '\0'
532
or tmp_id != (uid_t)tmp_id){
504
or tmpmax != (uid_t)tmpmax){
533
505
argp_error(state, "Bad user ID number: \"%s\", using %"
534
506
PRIdMAX, arg, (intmax_t)uid);
535
507
break;
536
508
}
537
uid = (uid_t)tmp_id;
538
errno = 0;
509
uid = (uid_t)tmpmax;
539
510
break;
540
511
case 131: /* --groupid */
541
tmp_id = strtoimax(arg, &tmp, 10);
512
tmpmax = strtoimax(arg, &tmp, 10);
542
513
if(errno != 0 or tmp == arg or *tmp != '\0'
543
or tmp_id != (gid_t)tmp_id){
514
or tmpmax != (gid_t)tmpmax){
544
515
argp_error(state, "Bad group ID number: \"%s\", using %"
545
516
PRIdMAX, arg, (intmax_t)gid);
546
517
break;
547
518
}
548
gid = (gid_t)tmp_id;
549
errno = 0;
519
gid = (gid_t)tmpmax;
550
520
break;
551
521
case 132: /* --debug */
552
522
debug = true;
553
523
break;
554
case 133: /* --plugin-helper-dir */
555
free(pluginhelperdir);
556
pluginhelperdir = strdup(arg);
557
if(pluginhelperdir != NULL){
558
errno = 0;
559
}
560
break;
561
524
/*
562
525
* These reproduce what we would get without ARGP_NO_HELP
563
526
*/
607
570
case 129: /* --config-file */
608
571
free(argfile);
609
572
argfile = strdup(arg);
610
if(argfile != NULL){
611
errno = 0;
612
}
613
573
break;
614
574
case 130: /* --userid */
615
575
case 131: /* --groupid */
616
576
case 132: /* --debug */
617
case 133: /* --plugin-helper-dir */
618
577
case '?': /* --help */
619
578
case -3: /* --usage */
620
579
case 'V': /* --version */
699
658
}
700
659
701
660
custom_argc += 1;
702
{
703
char **new_argv = realloc(custom_argv, sizeof(char *)
704
* ((size_t)custom_argc + 1));
705
if(new_argv == NULL){
706
error(0, errno, "realloc");
707
exitstatus = EX_OSERR;
708
free(new_arg);
709
free(org_line);
710
goto fallback;
711
} else {
712
custom_argv = new_argv;
713
}
661
custom_argv = realloc(custom_argv, sizeof(char *)
662
* ((unsigned int) custom_argc + 1));
663
if(custom_argv == NULL){
664
error(0, errno, "realloc");
665
exitstatus = EX_OSERR;
666
free(org_line);
667
goto fallback;
714
668
}
715
669
custom_argv[custom_argc-1] = new_arg;
716
670
custom_argv[custom_argc] = NULL;
774
728
goto fallback;
775
729
}
776
730
777
{
778
char *pluginhelperenv;
779
bool bret = true;
780
ret = asprintf(&pluginhelperenv, "MANDOSPLUGINHELPERDIR=%s",
781
pluginhelperdir != NULL ? pluginhelperdir : PHDIR);
782
if(ret != -1){
783
bret = add_environment(getplugin(NULL), pluginhelperenv, true);
784
}
785
if(ret == -1 or not bret){
786
error(0, errno, "Failed to set MANDOSPLUGINHELPERDIR"
787
" environment variable to \"%s\" for all plugins\n",
788
pluginhelperdir != NULL ? pluginhelperdir : PHDIR);
789
}
790
if(ret != -1){
791
free(pluginhelperenv);
792
}
793
}
794
795
731
if(debug){
796
for(plugin *p = plugin_list; p != NULL; p = p->next){
732
for(plugin *p = plugin_list; p != NULL; p=p->next){
797
733
fprintf(stderr, "Plugin: %s has %d arguments\n",
798
734
p->name ? p->name : "Global", p->argc - 1);
799
735
for(char **a = p->argv; *a != NULL; a++){
806
742
}
807
743
}
808
744
809
if(getuid() == 0){
810
/* Work around Debian bug #633582:
811
<https://bugs.debian.org/633582> */
812
int plugindir_fd = open(/* plugindir or */ PDIR, O_RDONLY);
813
if(plugindir_fd == -1){
814
if(errno != ENOENT){
815
error(0, errno, "open(\"" PDIR "\")");
816
}
817
} else {
818
ret = (int)TEMP_FAILURE_RETRY(fstat(plugindir_fd, &st));
819
if(ret == -1){
820
error(0, errno, "fstat");
821
} else {
822
if(S_ISDIR(st.st_mode) and st.st_uid == 0 and st.st_gid == 0){
823
ret = fchown(plugindir_fd, uid, gid);
824
if(ret == -1){
825
error(0, errno, "fchown");
826
}
827
}
828
}
829
close(plugindir_fd);
830
}
831
}
832
833
/* Lower permissions */
834
ret = setgid(gid);
745
/* Strip permissions down to nobody */
746
setgid(gid);
835
747
if(ret == -1){
836
748
error(0, errno, "setgid");
837
749
}
842
754
843
755
/* Open plugin directory with close_on_exec flag */
844
756
{
845
dir_fd = open(plugindir != NULL ? plugindir : PDIR, O_RDONLY |
846
#ifdef O_CLOEXEC
847
O_CLOEXEC
848
#else /* not O_CLOEXEC */
849
0
850
#endif /* not O_CLOEXEC */
851
);
757
int dir_fd = -1;
758
if(plugindir == NULL){
759
dir_fd = open(PDIR, O_RDONLY |
760
#ifdef O_CLOEXEC
761
O_CLOEXEC
762
#else /* not O_CLOEXEC */
763
0
764
#endif /* not O_CLOEXEC */
765
);
766
} else {
767
dir_fd = open(plugindir, O_RDONLY |
768
#ifdef O_CLOEXEC
769
O_CLOEXEC
770
#else /* not O_CLOEXEC */
771
0
772
#endif /* not O_CLOEXEC */
773
);
774
}
852
775
if(dir_fd == -1){
853
776
error(0, errno, "Could not open plugin dir");
854
777
exitstatus = EX_UNAVAILABLE;
860
783
ret = set_cloexec_flag(dir_fd);
861
784
if(ret < 0){
862
785
error(0, errno, "set_cloexec_flag");
786
TEMP_FAILURE_RETRY(close(dir_fd));
863
787
exitstatus = EX_OSERR;
864
788
goto fallback;
865
789
}
866
790
#endif /* O_CLOEXEC */
867
}
868
869
int good_name(const struct dirent * const dirent){
870
const char * const patterns[] = { ".*", "#*#", "*~", "*.dpkg-new",
871
"*.dpkg-old", "*.dpkg-bak",
872
"*.dpkg-divert", NULL };
873
#ifdef __GNUC__
874
#pragma GCC diagnostic push
875
#pragma GCC diagnostic ignored "-Wcast-qual"
876
#endif
877
for(const char **pat = (const char **)patterns;
878
*pat != NULL; pat++){
879
#ifdef __GNUC__
880
#pragma GCC diagnostic pop
881
#endif
882
if(fnmatch(*pat, dirent->d_name, FNM_FILE_NAME | FNM_PERIOD)
883
!= FNM_NOMATCH){
884
if(debug){
885
fprintf(stderr, "Ignoring plugin dir entry \"%s\""
886
" matching pattern %s\n", dirent->d_name, *pat);
887
}
888
return 0;
889
}
791
792
dir = fdopendir(dir_fd);
793
if(dir == NULL){
794
error(0, errno, "Could not open plugin dir");
795
TEMP_FAILURE_RETRY(close(dir_fd));
796
exitstatus = EX_OSERR;
797
goto fallback;
890
798
}
891
return 1;
892
}
893
894
int numplugins = scandirat(dir_fd, ".", &direntries, good_name,
895
alphasort);
896
if(numplugins == -1){
897
error(0, errno, "Could not scan plugin dir");
898
direntries = NULL;
899
exitstatus = EX_OSERR;
900
goto fallback;
901
799
}
902
800
903
801
FD_ZERO(&rfds_all);
904
802
905
803
/* Read and execute any executable in the plugin directory*/
906
for(int i = 0; i < numplugins; i++){
907
908
int plugin_fd = openat(dir_fd, direntries[i]->d_name, O_RDONLY);
909
if(plugin_fd == -1){
910
error(0, errno, "Could not open plugin");
911
free(direntries[i]);
804
while(true){
805
do {
806
dirst = readdir(dir);
807
} while(dirst == NULL and errno == EINTR);
808
809
/* All directory entries have been processed */
810
if(dirst == NULL){
811
if(errno == EBADF){
812
error(0, errno, "readdir");
813
exitstatus = EX_IOERR;
814
goto fallback;
815
}
816
break;
817
}
818
819
d_name_len = strlen(dirst->d_name);
820
821
/* Ignore dotfiles, backup files and other junk */
822
{
823
bool bad_name = false;
824
825
const char const *bad_prefixes[] = { ".", "#", NULL };
826
827
const char const *bad_suffixes[] = { "~", "#", ".dpkg-new",
828
".dpkg-old",
829
".dpkg-bak",
830
".dpkg-divert", NULL };
831
for(const char **pre = bad_prefixes; *pre != NULL; pre++){
832
size_t pre_len = strlen(*pre);
833
if((d_name_len >= pre_len)
834
and strncmp((dirst->d_name), *pre, pre_len) == 0){
835
if(debug){
836
fprintf(stderr, "Ignoring plugin dir entry \"%s\""
837
" with bad prefix %s\n", dirst->d_name, *pre);
838
}
839
bad_name = true;
840
break;
841
}
842
}
843
if(bad_name){
844
continue;
845
}
846
for(const char **suf = bad_suffixes; *suf != NULL; suf++){
847
size_t suf_len = strlen(*suf);
848
if((d_name_len >= suf_len)
849
and (strcmp((dirst->d_name) + d_name_len-suf_len, *suf)
850
== 0)){
851
if(debug){
852
fprintf(stderr, "Ignoring plugin dir entry \"%s\""
853
" with bad suffix %s\n", dirst->d_name, *suf);
854
}
855
bad_name = true;
856
break;
857
}
858
}
859
860
if(bad_name){
861
continue;
862
}
863
}
864
865
char *filename;
866
if(plugindir == NULL){
867
ret = (int)TEMP_FAILURE_RETRY(asprintf(&filename, PDIR "/%s",
868
dirst->d_name));
869
} else {
870
ret = (int)TEMP_FAILURE_RETRY(asprintf(&filename, "%s/%s",
871
plugindir,
872
dirst->d_name));
873
}
874
if(ret < 0){
875
error(0, errno, "asprintf");
912
876
continue;
913
877
}
914
ret = (int)TEMP_FAILURE_RETRY(fstat(plugin_fd, &st));
878
879
ret = (int)TEMP_FAILURE_RETRY(stat(filename, &st));
915
880
if(ret == -1){
916
881
error(0, errno, "stat");
917
close(plugin_fd);
918
free(direntries[i]);
882
free(filename);
919
883
continue;
920
884
}
921
885
922
886
/* Ignore non-executable files */
923
887
if(not S_ISREG(st.st_mode)
924
or (TEMP_FAILURE_RETRY(faccessat(dir_fd, direntries[i]->d_name,
925
X_OK, 0)) != 0)){
888
or (TEMP_FAILURE_RETRY(access(filename, X_OK)) != 0)){
926
889
if(debug){
927
fprintf(stderr, "Ignoring plugin dir entry \"%s/%s\""
928
" with bad type or mode\n",
929
plugindir != NULL ? plugindir : PDIR,
930
direntries[i]->d_name);
890
fprintf(stderr, "Ignoring plugin dir entry \"%s\""
891
" with bad type or mode\n", filename);
931
892
}
932
close(plugin_fd);
933
free(direntries[i]);
893
free(filename);
934
894
continue;
935
895
}
936
896
937
plugin *p = getplugin(direntries[i]->d_name);
897
plugin *p = getplugin(dirst->d_name);
938
898
if(p == NULL){
939
899
error(0, errno, "getplugin");
940
close(plugin_fd);
941
free(direntries[i]);
900
free(filename);
942
901
continue;
943
902
}
944
903
if(p->disabled){
945
904
if(debug){
946
905
fprintf(stderr, "Ignoring disabled plugin \"%s\"\n",
947
direntries[i]->d_name);
906
dirst->d_name);
948
907
}
949
close(plugin_fd);
950
free(direntries[i]);
908
free(filename);
951
909
continue;
952
910
}
953
911
{
967
925
}
968
926
}
969
927
}
970
/* If this plugin has any environment variables, we need to
971
duplicate the environment from this process, too. */
928
/* If this plugin has any environment variables, we will call
929
using execve and need to duplicate the environment from this
930
process, too. */
972
931
if(p->environ[0] != NULL){
973
932
for(char **e = environ; *e != NULL; e++){
974
933
if(not add_environment(p, *e, false)){
978
937
}
979
938
980
939
int pipefd[2];
981
#ifndef O_CLOEXEC
982
940
ret = (int)TEMP_FAILURE_RETRY(pipe(pipefd));
983
#else /* O_CLOEXEC */
984
ret = (int)TEMP_FAILURE_RETRY(pipe2(pipefd, O_CLOEXEC));
985
#endif /* O_CLOEXEC */
986
941
if(ret == -1){
987
942
error(0, errno, "pipe");
988
943
exitstatus = EX_OSERR;
989
free(direntries[i]);
990
goto fallback;
991
}
992
if(pipefd[0] >= FD_SETSIZE){
993
fprintf(stderr, "pipe()[0] (%d) >= FD_SETSIZE (%d)", pipefd[0],
994
FD_SETSIZE);
995
close(pipefd[0]);
996
close(pipefd[1]);
997
exitstatus = EX_OSERR;
998
free(direntries[i]);
999
goto fallback;
1000
}
1001
#ifndef O_CLOEXEC
944
goto fallback;
945
}
1002
946
/* Ask OS to automatic close the pipe on exec */
1003
947
ret = set_cloexec_flag(pipefd[0]);
1004
948
if(ret < 0){
1005
949
error(0, errno, "set_cloexec_flag");
1006
close(pipefd[0]);
1007
close(pipefd[1]);
1008
950
exitstatus = EX_OSERR;
1009
free(direntries[i]);
1010
951
goto fallback;
1011
952
}
1012
953
ret = set_cloexec_flag(pipefd[1]);
1013
954
if(ret < 0){
1014
955
error(0, errno, "set_cloexec_flag");
1015
close(pipefd[0]);
1016
close(pipefd[1]);
1017
956
exitstatus = EX_OSERR;
1018
free(direntries[i]);
1019
957
goto fallback;
1020
958
}
1021
#endif /* not O_CLOEXEC */
1022
959
/* Block SIGCHLD until process is safely in process list */
1023
960
ret = (int)TEMP_FAILURE_RETRY(sigprocmask(SIG_BLOCK,
1024
961
&sigchld_action.sa_mask,
1026
963
if(ret < 0){
1027
964
error(0, errno, "sigprocmask");
1028
965
exitstatus = EX_OSERR;
1029
free(direntries[i]);
1030
966
goto fallback;
1031
967
}
1032
968
/* Starting a new process to be watched */
1036
972
} while(pid == -1 and errno == EINTR);
1037
973
if(pid == -1){
1038
974
error(0, errno, "fork");
1039
TEMP_FAILURE_RETRY(sigprocmask(SIG_UNBLOCK,
1040
&sigchld_action.sa_mask, NULL));
1041
close(pipefd[0]);
1042
close(pipefd[1]);
1043
975
exitstatus = EX_OSERR;
1044
free(direntries[i]);
1045
976
goto fallback;
1046
977
}
1047
978
if(pid == 0){
1063
994
_exit(EX_OSERR);
1064
995
}
1065
996
1066
if(fexecve(plugin_fd, p->argv,
1067
(p->environ[0] != NULL) ? p->environ : environ) < 0){
1068
error(0, errno, "fexecve for %s/%s",
1069
plugindir != NULL ? plugindir : PDIR,
1070
direntries[i]->d_name);
1071
_exit(EX_OSERR);
997
if(dirfd(dir) < 0){
998
/* If dir has no file descriptor, we could not set FD_CLOEXEC
999
above and must now close it manually here. */
1000
closedir(dir);
1001
}
1002
if(p->environ[0] == NULL){
1003
if(execv(filename, p->argv) < 0){
1004
error(0, errno, "execv for %s", filename);
1005
_exit(EX_OSERR);
1006
}
1007
} else {
1008
if(execve(filename, p->argv, p->environ) < 0){
1009
error(0, errno, "execve for %s", filename);
1010
_exit(EX_OSERR);
1011
}
1072
1012
}
1073
1013
/* no return */
1074
1014
}
1075
1015
/* Parent process */
1076
close(pipefd[1]); /* Close unused write end of pipe */
1077
close(plugin_fd);
1078
plugin *new_plugin = getplugin(direntries[i]->d_name);
1016
TEMP_FAILURE_RETRY(close(pipefd[1])); /* Close unused write end of
1017
pipe */
1018
free(filename);
1019
plugin *new_plugin = getplugin(dirst->d_name);
1079
1020
if(new_plugin == NULL){
1080
1021
error(0, errno, "getplugin");
1081
1022
ret = (int)(TEMP_FAILURE_RETRY
1085
1026
error(0, errno, "sigprocmask");
1086
1027
}
1087
1028
exitstatus = EX_OSERR;
1088
free(direntries[i]);
1089
1029
goto fallback;
1090
1030
}
1091
free(direntries[i]);
1092
1031
1093
1032
new_plugin->pid = pid;
1094
1033
new_plugin->fd = pipefd[0];
1104
1043
goto fallback;
1105
1044
}
1106
1045
1107
FD_SET(new_plugin->fd, &rfds_all);
1046
FD_SET(new_plugin->fd, &rfds_all); /* Spurious warning from
1047
-Wconversion */
1108
1048
1109
1049
if(maxfd < new_plugin->fd){
1110
1050
maxfd = new_plugin->fd;
1111
1051
}
1112
1052
}
1113
1053
1114
free(direntries);
1115
direntries = NULL;
1116
close(dir_fd);
1117
dir_fd = -1;
1054
TEMP_FAILURE_RETRY(closedir(dir));
1055
dir = NULL;
1118
1056
free_plugin(getplugin(NULL));
1119
1057
1120
1058
for(plugin *p = plugin_list; p != NULL; p = p->next){
1159
1097
(intmax_t) (proc->pid),
1160
1098
WTERMSIG(proc->status),
1161
1099
strsignal(WTERMSIG(proc->status)));
1100
} else if(WCOREDUMP(proc->status)){
1101
fprintf(stderr, "Plugin %s [%" PRIdMAX "] dumped"
1102
" core\n", proc->name, (intmax_t) (proc->pid));
1162
1103
}
1163
1104
}
1164
1105
1165
1106
/* Remove the plugin */
1166
FD_CLR(proc->fd, &rfds_all);
1107
FD_CLR(proc->fd, &rfds_all); /* Spurious warning from
1108
-Wconversion */
1167
1109
1168
1110
/* Block signal while modifying process_list */
1169
1111
ret = (int)TEMP_FAILURE_RETRY(sigprocmask
1209
1151
}
1210
1152
1211
1153
/* This process has not completed. Does it have any output? */
1212
if(proc->eof or not FD_ISSET(proc->fd, &rfds)){
1154
if(proc->eof or not FD_ISSET(proc->fd, &rfds)){ /* Spurious
1155
warning from
1156
-Wconversion */
1213
1157
/* This process had nothing to say at this time */
1214
1158
proc = proc->next;
1215
1159
continue;
1216
1160
}
1217
1161
/* Before reading, make the process' data buffer large enough */
1218
1162
if(proc->buffer_length + BUFFER_SIZE > proc->buffer_size){
1219
char *new_buffer = realloc(proc->buffer, proc->buffer_size
1220
+ (size_t) BUFFER_SIZE);
1221
if(new_buffer == NULL){
1163
proc->buffer = realloc(proc->buffer, proc->buffer_size
1164
+ (size_t) BUFFER_SIZE);
1165
if(proc->buffer == NULL){
1222
1166
error(0, errno, "malloc");
1223
1167
exitstatus = EX_OSERR;
1224
1168
goto fallback;
1225
1169
}
1226
proc->buffer = new_buffer;
1227
1170
proc->buffer_size += BUFFER_SIZE;
1228
1171
}
1229
1172
/* Read from the process */
1282
1225
free(custom_argv);
1283
1226
}
1284
1227
1285
free(direntries);
1286
1287
if(dir_fd != -1){
1288
close(dir_fd);
1228
if(dir != NULL){
1229
closedir(dir);
1289
1230
}
1290
1231
1291
1232
/* Kill the processes */
1311
1252
free_plugin_list();
1312
1253
1313
1254
free(plugindir);
1314
free(pluginhelperdir);
1315
1255
free(argfile);
1316
1256
1317
1257
return exitstatus;
Loggerhead is a web-based interface for Breezy
Version: 2.0.2.dev0