To get this branch, use:
bzr branch
http://bzr.recompile.se/loggerhead/mandos/trunk
« back to all changes in this revision
Viewing changes to plugin-runner.c
- browse files at revision 394
- compare with another revision
- download diff
- download tarball
- view history from revision 394
- Committer: Teddy Hogeborn
- Date: 2009-10-24 19:17:52 UTC
- Revision ID: teddy@fukt.bsnet.se-20091024191752-7g6xlf6wpp2pdexb
Convert some programs to use the exit codes from <sysexits.h>. Change
all programs using the "argp" parsing functions to use them correctly;
checking return value, using argp_error() to report parse errors etc.
* plugin-runner.c: Use <sysexits.h> exit codes. Always use fallback,
even on option errors, except for "--help", etc.
(getplugin): Make sure "errno" is set correctly on return.
(main): Declare our own "--help", "--usage", and "--version"
options which do not cause the fallback to be invoked.
In all other options, use fallback on any error.
(parse_opt, parse_opt_config_file): Reset errno at start and return
errno. No need to check "arg"
for NULL. New "--help",
"--usage", and "--version"
options.
(parse_opt): Accept empty string as global option. Do not print
errors which will be detected and reported later. Do
"argp_error()" on parse error or empty plugin names.
* plugins.d/mandos-client.c: Use <sysexits.h> exit codes. Do not
return successful exit code on "--help",
etc. since this would give the wrong
message to "plugin-runner".
(main): Declare our own "--help", "--usage", and "--version"
options which do not return a successful exit code.
(parse_opt): Reset errno at start and return errno. Do
"argp_error()" on parse errors. New "--help",
"--usage", and "--version" options.
* plugins.d/password-prompt.c: Use exit codes from <sysexits.h>. Do
not return successful exit code on
"--help", etc. since this would give
the wrong message to "plugin-runner".
(main): Declare our own "--help", "--usage", and "--version" options
which do not return a successful exit code. Do
close(STDOUT_FILENO) after writing to check its return code.
(parse_opt): Reset errno at start and return errno.
all programs using the "argp" parsing functions to use them correctly;
checking return value, using argp_error() to report parse errors etc.
* plugin-runner.c: Use <sysexits.h> exit codes. Always use fallback,
even on option errors, except for "--help", etc.
(getplugin): Make sure "errno" is set correctly on return.
(main): Declare our own "--help", "--usage", and "--version"
options which do not cause the fallback to be invoked.
In all other options, use fallback on any error.
(parse_opt, parse_opt_config_file): Reset errno at start and return
errno. No need to check "arg"
for NULL. New "--help",
"--usage", and "--version"
options.
(parse_opt): Accept empty string as global option. Do not print
errors which will be detected and reported later. Do
"argp_error()" on parse error or empty plugin names.
* plugins.d/mandos-client.c: Use <sysexits.h> exit codes. Do not
return successful exit code on "--help",
etc. since this would give the wrong
message to "plugin-runner".
(main): Declare our own "--help", "--usage", and "--version"
options which do not return a successful exit code.
(parse_opt): Reset errno at start and return errno. Do
"argp_error()" on parse errors. New "--help",
"--usage", and "--version" options.
* plugins.d/password-prompt.c: Use exit codes from <sysexits.h>. Do
not return successful exit code on
"--help", etc. since this would give
the wrong message to "plugin-runner".
(main): Declare our own "--help", "--usage", and "--version" options
which do not return a successful exit code. Do
close(STDOUT_FILENO) after writing to check its return code.
(parse_opt): Reset errno at start and return errno.
- files removed:
- DBUS-API
- debian/source
- debian/upstream
- network-hooks.d
- files modified:
- .bzrignore
added
removed
plugin-runner.c
2
2
/*
3
3
* Mandos plugin runner - Run Mandos plugins
4
4
*
5
* Copyright © 2008-2014 Teddy Hogeborn
6
* Copyright © 2008-2014 Björn Påhlsson
5
* Copyright © 2008,2009 Teddy Hogeborn
6
* Copyright © 2008,2009 Björn Påhlsson
7
7
*
8
8
* This program is free software: you can redistribute it and/or
9
9
* modify it under the terms of the GNU General Public License as
19
19
* along with this program. If not, see
20
20
* <http://www.gnu.org/licenses/>.
21
21
*
22
* Contact the authors at <mandos@recompile.se>.
22
* Contact the authors at <mandos@fukt.bsnet.se>.
23
23
*/
24
24
25
25
#define _GNU_SOURCE /* TEMP_FAILURE_RETRY(), getline(),
26
O_CLOEXEC */
26
asprintf(), O_CLOEXEC */
27
27
#include <stddef.h> /* size_t, NULL */
28
#include <stdlib.h> /* malloc(), exit(), EXIT_SUCCESS,
29
realloc() */
28
#include <stdlib.h> /* malloc(), exit(), EXIT_FAILURE,
29
EXIT_SUCCESS, realloc() */
30
30
#include <stdbool.h> /* bool, true, false */
31
#include <stdio.h> /* fileno(), fprintf(),
32
stderr, STDOUT_FILENO, fclose() */
33
#include <sys/types.h> /* DIR, fdopendir(), fstat(), struct
31
#include <stdio.h> /* perror, fileno(), fprintf(),
32
stderr, STDOUT_FILENO */
33
#include <sys/types.h> /* DIR, fdopendir(), stat(), struct
34
34
stat, waitpid(), WIFEXITED(),
35
35
WEXITSTATUS(), wait(), pid_t,
36
36
uid_t, gid_t, getuid(), getgid(),
40
40
#include <sys/wait.h> /* wait(), waitpid(), WIFEXITED(),
41
41
WEXITSTATUS(), WTERMSIG(),
42
42
WCOREDUMP() */
43
#include <sys/stat.h> /* struct stat, fstat(), S_ISREG() */
43
#include <sys/stat.h> /* struct stat, stat(), S_ISREG() */
44
44
#include <iso646.h> /* and, or, not */
45
45
#include <dirent.h> /* DIR, struct dirent, fdopendir(),
46
46
readdir(), closedir(), dirfd() */
47
#include <unistd.h> /* fcntl(), F_GETFD, F_SETFD,
48
FD_CLOEXEC, write(), STDOUT_FILENO,
49
struct stat, fstat(), close(),
50
setgid(), setuid(), S_ISREG(),
51
faccessat() pipe(), fork(),
52
_exit(), dup2(), fexecve(), read()
53
*/
47
#include <unistd.h> /* struct stat, stat(), S_ISREG(),
48
fcntl(), setuid(), setgid(),
49
F_GETFD, F_SETFD, FD_CLOEXEC,
50
access(), pipe(), fork(), close()
51
dup2(), STDOUT_FILENO, _exit(),
52
execv(), write(), read(),
53
close() */
54
54
#include <fcntl.h> /* fcntl(), F_GETFD, F_SETFD,
55
FD_CLOEXEC, openat() */
56
#include <string.h> /* strsep, strlen(), strsignal(),
57
strcmp(), strncmp() */
55
FD_CLOEXEC */
56
#include <string.h> /* strsep, strlen(), asprintf(),
57
strsignal() */
58
58
#include <errno.h> /* errno */
59
59
#include <argp.h> /* struct argp_option, struct
60
60
argp_state, struct argp,
68
68
*/
69
69
#include <errno.h> /* errno, EBADF */
70
70
#include <inttypes.h> /* intmax_t, PRIdMAX, strtoimax() */
71
#include <sysexits.h> /* EX_OSERR, EX_USAGE, EX_IOERR,
72
EX_CONFIG, EX_UNAVAILABLE, EX_OK */
73
#include <errno.h> /* errno */
74
#include <error.h> /* error() */
75
#include <fnmatch.h> /* fnmatch() */
71
#include <sysexits.h> /* EX_OSERR, EX_USAGE */
76
72
77
73
#define BUFFER_SIZE 256
78
74
80
76
#define AFILE "/conf/conf.d/mandos/plugin-runner.conf"
81
77
82
78
const char *argp_program_version = "plugin-runner " VERSION;
83
const char *argp_program_bug_address = "<mandos@recompile.se>";
79
const char *argp_program_bug_address = "<mandos@fukt.bsnet.se>";
84
80
85
81
typedef struct plugin{
86
82
char *name; /* can be NULL or any plugin name */
106
102
107
103
/* Gets an existing plugin based on name,
108
104
or if none is found, creates a new one */
109
__attribute__((warn_unused_result))
110
105
static plugin *getplugin(char *name){
111
106
/* Check for existing plugin with that name */
112
107
for(plugin *p = plugin_list; p != NULL; p = p->next){
173
168
}
174
169
175
170
/* Helper function for add_argument and add_environment */
176
__attribute__((nonnull, warn_unused_result))
177
171
static bool add_to_char_array(const char *new, char ***array,
178
172
int *len){
179
173
/* Resize the pointed-to array to hold one more pointer */
180
char **new_array = NULL;
181
174
do {
182
new_array = realloc(*array, sizeof(char *)
183
* (size_t) ((*len) + 2));
184
} while(new_array == NULL and errno == EINTR);
175
*array = realloc(*array, sizeof(char *)
176
* (size_t) ((*len) + 2));
177
} while(*array == NULL and errno == EINTR);
185
178
/* Malloc check */
186
if(new_array == NULL){
179
if(*array == NULL){
187
180
return false;
188
181
}
189
*array = new_array;
190
182
/* Make a copy of the new string */
191
183
char *copy;
192
184
do {
204
196
}
205
197
206
198
/* Add to a plugin's argument vector */
207
__attribute__((nonnull(2), warn_unused_result))
208
199
static bool add_argument(plugin *p, const char *arg){
209
200
if(p == NULL){
210
201
return false;
213
204
}
214
205
215
206
/* Add to a plugin's environment */
216
__attribute__((nonnull(2), warn_unused_result))
217
207
static bool add_environment(plugin *p, const char *def, bool replace){
218
208
if(p == NULL){
219
209
return false;
221
211
/* namelen = length of name of environment variable */
222
212
size_t namelen = (size_t)(strchrnul(def, '=') - def);
223
213
/* Search for this environment variable */
224
for(char **envdef = p->environ; *envdef != NULL; envdef++){
225
if(strncmp(*envdef, def, namelen + 1) == 0){
214
for(char **e = p->environ; *e != NULL; e++){
215
if(strncmp(*e, def, namelen + 1) == 0){
226
216
/* It already exists */
227
217
if(replace){
228
char *new_envdef;
218
char *new;
229
219
do {
230
new_envdef = realloc(*envdef, strlen(def) + 1);
231
} while(new_envdef == NULL and errno == EINTR);
232
if(new_envdef == NULL){
220
new = realloc(*e, strlen(def) + 1);
221
} while(new == NULL and errno == EINTR);
222
if(new == NULL){
233
223
return false;
234
224
}
235
*envdef = new_envdef;
236
strcpy(*envdef, def);
225
*e = new;
226
strcpy(*e, def);
237
227
}
238
228
return true;
239
229
}
246
236
* Descriptor Flags".
247
237
| [[info:libc:Descriptor%20Flags][File Descriptor Flags]] |
248
238
*/
249
__attribute__((warn_unused_result))
250
239
static int set_cloexec_flag(int fd){
251
240
int ret = (int)TEMP_FAILURE_RETRY(fcntl(fd, F_GETFD, 0));
252
241
/* If reading the flags failed, return error indication now. */
276
265
/* No child processes */
277
266
break;
278
267
}
279
error(0, errno, "waitpid");
268
perror("waitpid");
280
269
}
281
270
282
271
/* A child exited, find it in process_list */
294
283
}
295
284
296
285
/* Prints out a password to stdout */
297
__attribute__((nonnull, warn_unused_result))
298
286
static bool print_out_password(const char *buffer, size_t length){
299
287
ssize_t ret;
300
288
for(size_t written = 0; written < length; written += (size_t)ret){
308
296
}
309
297
310
298
/* Removes and free a plugin from the plugin list */
311
__attribute__((nonnull))
312
299
static void free_plugin(plugin *plugin_node){
313
300
314
301
for(char **arg = plugin_node->argv; *arg != NULL; arg++){
348
335
char *plugindir = NULL;
349
336
char *argfile = NULL;
350
337
FILE *conffp;
338
size_t d_name_len;
351
339
DIR *dir = NULL;
352
340
struct dirent *dirst;
353
341
struct stat st;
363
351
.sa_flags = SA_NOCLDSTOP };
364
352
char **custom_argv = NULL;
365
353
int custom_argc = 0;
366
int dir_fd;
367
354
368
355
/* Establish a signal handler */
369
356
sigemptyset(&sigchld_action.sa_mask);
370
357
ret = sigaddset(&sigchld_action.sa_mask, SIGCHLD);
371
358
if(ret == -1){
372
error(0, errno, "sigaddset");
373
exitstatus = EX_OSERR;
359
perror("sigaddset");
360
exitstatus = EXIT_FAILURE;
374
361
goto fallback;
375
362
}
376
363
ret = sigaction(SIGCHLD, &sigchld_action, &old_sigchld_action);
377
364
if(ret == -1){
378
error(0, errno, "sigaction");
379
exitstatus = EX_OSERR;
365
perror("sigaction");
366
exitstatus = EXIT_FAILURE;
380
367
goto fallback;
381
368
}
382
369
426
413
{ .name = NULL }
427
414
};
428
415
429
__attribute__((nonnull(3)))
430
416
error_t parse_opt(int key, char *arg, struct argp_state *state){
431
417
errno = 0;
432
418
switch(key){
433
419
char *tmp;
434
intmax_t tmp_id;
420
intmax_t tmpmax;
435
421
case 'g': /* --global-options */
436
422
{
437
423
char *plugin_option;
440
426
break;
441
427
}
442
428
}
443
errno = 0;
444
429
}
445
430
break;
446
431
case 'G': /* --global-env */
447
if(add_environment(getplugin(NULL), arg, true)){
448
errno = 0;
449
}
432
add_environment(getplugin(NULL), arg, true);
450
433
break;
451
434
case 'o': /* --options-for */
452
435
{
469
452
break;
470
453
}
471
454
}
472
errno = 0;
473
455
}
474
456
break;
475
457
case 'E': /* --env-for */
487
469
errno = EINVAL;
488
470
break;
489
471
}
490
if(add_environment(getplugin(arg), envdef, true)){
491
errno = 0;
492
}
472
add_environment(getplugin(arg), envdef, true);
493
473
}
494
474
break;
495
475
case 'd': /* --disable */
497
477
plugin *p = getplugin(arg);
498
478
if(p != NULL){
499
479
p->disabled = true;
500
errno = 0;
501
480
}
502
481
}
503
482
break;
506
485
plugin *p = getplugin(arg);
507
486
if(p != NULL){
508
487
p->disabled = false;
509
errno = 0;
510
488
}
511
489
}
512
490
break;
513
491
case 128: /* --plugin-dir */
514
492
free(plugindir);
515
493
plugindir = strdup(arg);
516
if(plugindir != NULL){
517
errno = 0;
518
}
519
494
break;
520
495
case 129: /* --config-file */
521
496
/* This is already done by parse_opt_config_file() */
522
497
break;
523
498
case 130: /* --userid */
524
tmp_id = strtoimax(arg, &tmp, 10);
499
tmpmax = strtoimax(arg, &tmp, 10);
525
500
if(errno != 0 or tmp == arg or *tmp != '\0'
526
or tmp_id != (uid_t)tmp_id){
501
or tmpmax != (uid_t)tmpmax){
527
502
argp_error(state, "Bad user ID number: \"%s\", using %"
528
503
PRIdMAX, arg, (intmax_t)uid);
529
504
break;
530
505
}
531
uid = (uid_t)tmp_id;
532
errno = 0;
506
uid = (uid_t)tmpmax;
533
507
break;
534
508
case 131: /* --groupid */
535
tmp_id = strtoimax(arg, &tmp, 10);
509
tmpmax = strtoimax(arg, &tmp, 10);
536
510
if(errno != 0 or tmp == arg or *tmp != '\0'
537
or tmp_id != (gid_t)tmp_id){
511
or tmpmax != (gid_t)tmpmax){
538
512
argp_error(state, "Bad group ID number: \"%s\", using %"
539
513
PRIdMAX, arg, (intmax_t)gid);
540
514
break;
541
515
}
542
gid = (gid_t)tmp_id;
543
errno = 0;
516
gid = (gid_t)tmpmax;
544
517
break;
545
518
case 132: /* --debug */
546
519
debug = true;
594
567
case 129: /* --config-file */
595
568
free(argfile);
596
569
argfile = strdup(arg);
597
if(argfile != NULL){
598
errno = 0;
599
}
600
570
break;
601
571
case 130: /* --userid */
602
572
case 131: /* --groupid */
628
598
case ENOMEM:
629
599
default:
630
600
errno = ret;
631
error(0, errno, "argp_parse");
601
perror("argp_parse");
632
602
exitstatus = EX_OSERR;
633
603
goto fallback;
634
604
case EINVAL:
655
625
custom_argc = 1;
656
626
custom_argv = malloc(sizeof(char*) * 2);
657
627
if(custom_argv == NULL){
658
error(0, errno, "malloc");
659
exitstatus = EX_OSERR;
628
perror("malloc");
629
exitstatus = EXIT_FAILURE;
660
630
goto fallback;
661
631
}
662
632
custom_argv[0] = argv[0];
678
648
}
679
649
new_arg = strdup(p);
680
650
if(new_arg == NULL){
681
error(0, errno, "strdup");
682
exitstatus = EX_OSERR;
651
perror("strdup");
652
exitstatus = EXIT_FAILURE;
683
653
free(org_line);
684
654
goto fallback;
685
655
}
686
656
687
657
custom_argc += 1;
688
{
689
char **new_argv = realloc(custom_argv, sizeof(char *)
690
* ((unsigned int)
691
custom_argc + 1));
692
if(new_argv == NULL){
693
error(0, errno, "realloc");
694
exitstatus = EX_OSERR;
695
free(new_arg);
696
free(org_line);
697
goto fallback;
698
} else {
699
custom_argv = new_argv;
700
}
658
custom_argv = realloc(custom_argv, sizeof(char *)
659
* ((unsigned int) custom_argc + 1));
660
if(custom_argv == NULL){
661
perror("realloc");
662
exitstatus = EXIT_FAILURE;
663
free(org_line);
664
goto fallback;
701
665
}
702
666
custom_argv[custom_argc-1] = new_arg;
703
667
custom_argv[custom_argc] = NULL;
707
671
ret = fclose(conffp);
708
672
} while(ret == EOF and errno == EINTR);
709
673
if(ret == EOF){
710
error(0, errno, "fclose");
711
exitstatus = EX_IOERR;
674
perror("fclose");
675
exitstatus = EXIT_FAILURE;
712
676
goto fallback;
713
677
}
714
678
free(org_line);
716
680
/* Check for harmful errors and go to fallback. Other errors might
717
681
not affect opening plugins */
718
682
if(errno == EMFILE or errno == ENFILE or errno == ENOMEM){
719
error(0, errno, "fopen");
720
exitstatus = EX_OSERR;
683
perror("fopen");
684
exitstatus = EXIT_FAILURE;
721
685
goto fallback;
722
686
}
723
687
}
733
697
case ENOMEM:
734
698
default:
735
699
errno = ret;
736
error(0, errno, "argp_parse");
700
perror("argp_parse");
737
701
exitstatus = EX_OSERR;
738
702
goto fallback;
739
703
case EINVAL:
753
717
case ENOMEM:
754
718
default:
755
719
errno = ret;
756
error(0, errno, "argp_parse");
720
perror("argp_parse");
757
721
exitstatus = EX_OSERR;
758
722
goto fallback;
759
723
case EINVAL:
775
739
}
776
740
}
777
741
778
if(getuid() == 0){
779
/* Work around Debian bug #633582:
780
<http://bugs.debian.org/633582> */
781
int plugindir_fd = open(/* plugindir or */ PDIR, O_RDONLY);
782
if(plugindir_fd == -1){
783
if(errno != ENOENT){
784
error(0, errno, "open(\"" PDIR "\")");
785
}
786
} else {
787
ret = (int)TEMP_FAILURE_RETRY(fstat(plugindir_fd, &st));
788
if(ret == -1){
789
error(0, errno, "fstat");
790
} else {
791
if(S_ISDIR(st.st_mode) and st.st_uid == 0 and st.st_gid == 0){
792
ret = fchown(plugindir_fd, uid, gid);
793
if(ret == -1){
794
error(0, errno, "fchown");
795
}
796
}
797
}
798
TEMP_FAILURE_RETRY(close(plugindir_fd));
799
}
800
}
801
802
/* Lower permissions */
803
ret = setgid(gid);
742
/* Strip permissions down to nobody */
743
setgid(gid);
804
744
if(ret == -1){
805
error(0, errno, "setgid");
745
perror("setgid");
806
746
}
807
747
ret = setuid(uid);
808
748
if(ret == -1){
809
error(0, errno, "setuid");
749
perror("setuid");
810
750
}
811
751
812
752
/* Open plugin directory with close_on_exec flag */
813
753
{
814
dir_fd = open(plugindir != NULL ? plugindir : PDIR, O_RDONLY |
815
#ifdef O_CLOEXEC
816
O_CLOEXEC
817
#else /* not O_CLOEXEC */
818
0
819
#endif /* not O_CLOEXEC */
820
);
754
int dir_fd = -1;
755
if(plugindir == NULL){
756
dir_fd = open(PDIR, O_RDONLY |
757
#ifdef O_CLOEXEC
758
O_CLOEXEC
759
#else /* not O_CLOEXEC */
760
0
761
#endif /* not O_CLOEXEC */
762
);
763
} else {
764
dir_fd = open(plugindir, O_RDONLY |
765
#ifdef O_CLOEXEC
766
O_CLOEXEC
767
#else /* not O_CLOEXEC */
768
0
769
#endif /* not O_CLOEXEC */
770
);
771
}
821
772
if(dir_fd == -1){
822
error(0, errno, "Could not open plugin dir");
823
exitstatus = EX_UNAVAILABLE;
773
perror("Could not open plugin dir");
774
exitstatus = EXIT_FAILURE;
824
775
goto fallback;
825
776
}
826
777
828
779
/* Set the FD_CLOEXEC flag on the directory */
829
780
ret = set_cloexec_flag(dir_fd);
830
781
if(ret < 0){
831
error(0, errno, "set_cloexec_flag");
782
perror("set_cloexec_flag");
832
783
TEMP_FAILURE_RETRY(close(dir_fd));
833
exitstatus = EX_OSERR;
784
exitstatus = EXIT_FAILURE;
834
785
goto fallback;
835
786
}
836
787
#endif /* O_CLOEXEC */
837
788
838
789
dir = fdopendir(dir_fd);
839
790
if(dir == NULL){
840
error(0, errno, "Could not open plugin dir");
791
perror("Could not open plugin dir");
841
792
TEMP_FAILURE_RETRY(close(dir_fd));
842
exitstatus = EX_OSERR;
793
exitstatus = EXIT_FAILURE;
843
794
goto fallback;
844
795
}
845
796
}
855
806
/* All directory entries have been processed */
856
807
if(dirst == NULL){
857
808
if(errno == EBADF){
858
error(0, errno, "readdir");
859
exitstatus = EX_IOERR;
809
perror("readdir");
810
exitstatus = EXIT_FAILURE;
860
811
goto fallback;
861
812
}
862
813
break;
863
814
}
864
815
816
d_name_len = strlen(dirst->d_name);
817
865
818
/* Ignore dotfiles, backup files and other junk */
866
819
{
867
820
bool bad_name = false;
868
const char * const patterns[] = { ".*", "#*#", "*~",
869
"*.dpkg-new", "*.dpkg-old",
870
"*.dpkg-bak", "*.dpkg-divert",
871
NULL };
872
#ifdef __GNUC__
873
#pragma GCC diagnostic push
874
#pragma GCC diagnostic ignored "-Wcast-qual"
875
#endif
876
for(const char **pat = (const char **)patterns;
877
*pat != NULL; pat++){
878
#ifdef __GNUC__
879
#pragma GCC diagnostic pop
880
#endif
881
if(fnmatch(*pat, dirst->d_name,
882
FNM_FILE_NAME | FNM_PERIOD) != FNM_NOMATCH){
883
if(debug){
884
fprintf(stderr, "Ignoring plugin dir entry \"%s\""
885
" matching pattern %s\n", dirst->d_name, *pat);
886
}
887
bad_name = true;
888
break;
889
}
890
}
821
822
const char const *bad_prefixes[] = { ".", "#", NULL };
823
824
const char const *bad_suffixes[] = { "~", "#", ".dpkg-new",
825
".dpkg-old",
826
".dpkg-bak",
827
".dpkg-divert", NULL };
828
for(const char **pre = bad_prefixes; *pre != NULL; pre++){
829
size_t pre_len = strlen(*pre);
830
if((d_name_len >= pre_len)
831
and strncmp((dirst->d_name), *pre, pre_len) == 0){
832
if(debug){
833
fprintf(stderr, "Ignoring plugin dir entry \"%s\""
834
" with bad prefix %s\n", dirst->d_name, *pre);
835
}
836
bad_name = true;
837
break;
838
}
839
}
840
if(bad_name){
841
continue;
842
}
843
for(const char **suf = bad_suffixes; *suf != NULL; suf++){
844
size_t suf_len = strlen(*suf);
845
if((d_name_len >= suf_len)
846
and (strcmp((dirst->d_name)+d_name_len-suf_len, *suf)
847
== 0)){
848
if(debug){
849
fprintf(stderr, "Ignoring plugin dir entry \"%s\""
850
" with bad suffix %s\n", dirst->d_name, *suf);
851
}
852
bad_name = true;
853
break;
854
}
855
}
856
891
857
if(bad_name){
892
858
continue;
893
859
}
894
860
}
895
861
896
int plugin_fd = openat(dir_fd, dirst->d_name, O_RDONLY |
897
#ifdef O_CLOEXEC
898
O_CLOEXEC
899
#else /* not O_CLOEXEC */
900
0
901
#endif /* not O_CLOEXEC */
902
);
903
if(plugin_fd == -1){
904
error(0, errno, "Could not open plugin");
905
continue;
862
char *filename;
863
if(plugindir == NULL){
864
ret = (int)TEMP_FAILURE_RETRY(asprintf(&filename, PDIR "/%s",
865
dirst->d_name));
866
} else {
867
ret = (int)TEMP_FAILURE_RETRY(asprintf(&filename, "%s/%s",
868
plugindir,
869
dirst->d_name));
906
870
}
907
#ifndef O_CLOEXEC
908
/* Set the FD_CLOEXEC flag on the plugin FD */
909
ret = set_cloexec_flag(plugin_fd);
910
871
if(ret < 0){
911
error(0, errno, "set_cloexec_flag");
912
TEMP_FAILURE_RETRY(close(plugin_fd));
872
perror("asprintf");
913
873
continue;
914
874
}
915
#endif /* O_CLOEXEC */
916
ret = (int)TEMP_FAILURE_RETRY(fstat(plugin_fd, &st));
875
876
ret = (int)TEMP_FAILURE_RETRY(stat(filename, &st));
917
877
if(ret == -1){
918
error(0, errno, "stat");
919
TEMP_FAILURE_RETRY(close(plugin_fd));
878
perror("stat");
879
free(filename);
920
880
continue;
921
881
}
922
882
923
883
/* Ignore non-executable files */
924
884
if(not S_ISREG(st.st_mode)
925
or (TEMP_FAILURE_RETRY(faccessat(dir_fd, dirst->d_name, X_OK,
926
0)) != 0)){
885
or (TEMP_FAILURE_RETRY(access(filename, X_OK)) != 0)){
927
886
if(debug){
928
fprintf(stderr, "Ignoring plugin dir entry \"%s/%s\""
929
" with bad type or mode\n",
930
plugindir != NULL ? plugindir : PDIR, dirst->d_name);
887
fprintf(stderr, "Ignoring plugin dir entry \"%s\""
888
" with bad type or mode\n", filename);
931
889
}
932
TEMP_FAILURE_RETRY(close(plugin_fd));
890
free(filename);
933
891
continue;
934
892
}
935
893
936
894
plugin *p = getplugin(dirst->d_name);
937
895
if(p == NULL){
938
error(0, errno, "getplugin");
939
TEMP_FAILURE_RETRY(close(plugin_fd));
896
perror("getplugin");
897
free(filename);
940
898
continue;
941
899
}
942
900
if(p->disabled){
944
902
fprintf(stderr, "Ignoring disabled plugin \"%s\"\n",
945
903
dirst->d_name);
946
904
}
947
TEMP_FAILURE_RETRY(close(plugin_fd));
905
free(filename);
948
906
continue;
949
907
}
950
908
{
953
911
if(g != NULL){
954
912
for(char **a = g->argv + 1; *a != NULL; a++){
955
913
if(not add_argument(p, *a)){
956
error(0, errno, "add_argument");
914
perror("add_argument");
957
915
}
958
916
}
959
917
/* Add global environment variables */
960
918
for(char **e = g->environ; *e != NULL; e++){
961
919
if(not add_environment(p, *e, false)){
962
error(0, errno, "add_environment");
920
perror("add_environment");
963
921
}
964
922
}
965
923
}
966
924
}
967
/* If this plugin has any environment variables, we need to
968
duplicate the environment from this process, too. */
925
/* If this plugin has any environment variables, we will call
926
using execve and need to duplicate the environment from this
927
process, too. */
969
928
if(p->environ[0] != NULL){
970
929
for(char **e = environ; *e != NULL; e++){
971
930
if(not add_environment(p, *e, false)){
972
error(0, errno, "add_environment");
931
perror("add_environment");
973
932
}
974
933
}
975
934
}
977
936
int pipefd[2];
978
937
ret = (int)TEMP_FAILURE_RETRY(pipe(pipefd));
979
938
if(ret == -1){
980
error(0, errno, "pipe");
981
exitstatus = EX_OSERR;
939
perror("pipe");
940
exitstatus = EXIT_FAILURE;
982
941
goto fallback;
983
942
}
984
943
/* Ask OS to automatic close the pipe on exec */
985
944
ret = set_cloexec_flag(pipefd[0]);
986
945
if(ret < 0){
987
error(0, errno, "set_cloexec_flag");
988
exitstatus = EX_OSERR;
946
perror("set_cloexec_flag");
947
exitstatus = EXIT_FAILURE;
989
948
goto fallback;
990
949
}
991
950
ret = set_cloexec_flag(pipefd[1]);
992
951
if(ret < 0){
993
error(0, errno, "set_cloexec_flag");
994
exitstatus = EX_OSERR;
952
perror("set_cloexec_flag");
953
exitstatus = EXIT_FAILURE;
995
954
goto fallback;
996
955
}
997
956
/* Block SIGCHLD until process is safely in process list */
999
958
&sigchld_action.sa_mask,
1000
959
NULL));
1001
960
if(ret < 0){
1002
error(0, errno, "sigprocmask");
1003
exitstatus = EX_OSERR;
961
perror("sigprocmask");
962
exitstatus = EXIT_FAILURE;
1004
963
goto fallback;
1005
964
}
1006
965
/* Starting a new process to be watched */
1009
968
pid = fork();
1010
969
} while(pid == -1 and errno == EINTR);
1011
970
if(pid == -1){
1012
error(0, errno, "fork");
1013
exitstatus = EX_OSERR;
971
perror("fork");
972
exitstatus = EXIT_FAILURE;
1014
973
goto fallback;
1015
974
}
1016
975
if(pid == 0){
1017
976
/* this is the child process */
1018
977
ret = sigaction(SIGCHLD, &old_sigchld_action, NULL);
1019
978
if(ret < 0){
1020
error(0, errno, "sigaction");
1021
_exit(EX_OSERR);
979
perror("sigaction");
980
_exit(EXIT_FAILURE);
1022
981
}
1023
982
ret = sigprocmask(SIG_UNBLOCK, &sigchld_action.sa_mask, NULL);
1024
983
if(ret < 0){
1025
error(0, errno, "sigprocmask");
1026
_exit(EX_OSERR);
984
perror("sigprocmask");
985
_exit(EXIT_FAILURE);
1027
986
}
1028
987
1029
988
ret = dup2(pipefd[1], STDOUT_FILENO); /* replace our stdout */
1030
989
if(ret == -1){
1031
error(0, errno, "dup2");
1032
_exit(EX_OSERR);
990
perror("dup2");
991
_exit(EXIT_FAILURE);
1033
992
}
1034
993
1035
994
if(dirfd(dir) < 0){
1037
996
above and must now close it manually here. */
1038
997
closedir(dir);
1039
998
}
1040
if(fexecve(plugin_fd, p->argv,
1041
(p->environ[0] != NULL) ? p->environ : environ) < 0){
1042
error(0, errno, "fexecve for %s/%s",
1043
plugindir != NULL ? plugindir : PDIR, dirst->d_name);
1044
_exit(EX_OSERR);
999
if(p->environ[0] == NULL){
1000
if(execv(filename, p->argv) < 0){
1001
perror("execv");
1002
_exit(EXIT_FAILURE);
1003
}
1004
} else {
1005
if(execve(filename, p->argv, p->environ) < 0){
1006
perror("execve");
1007
_exit(EXIT_FAILURE);
1008
}
1045
1009
}
1046
1010
/* no return */
1047
1011
}
1048
1012
/* Parent process */
1049
1013
TEMP_FAILURE_RETRY(close(pipefd[1])); /* Close unused write end of
1050
1014
pipe */
1051
TEMP_FAILURE_RETRY(close(plugin_fd));
1015
free(filename);
1052
1016
plugin *new_plugin = getplugin(dirst->d_name);
1053
1017
if(new_plugin == NULL){
1054
error(0, errno, "getplugin");
1018
perror("getplugin");
1055
1019
ret = (int)(TEMP_FAILURE_RETRY
1056
1020
(sigprocmask(SIG_UNBLOCK, &sigchld_action.sa_mask,
1057
1021
NULL)));
1058
1022
if(ret < 0){
1059
error(0, errno, "sigprocmask");
1023
perror("sigprocmask");
1060
1024
}
1061
exitstatus = EX_OSERR;
1025
exitstatus = EXIT_FAILURE;
1062
1026
goto fallback;
1063
1027
}
1064
1028
1071
1035
&sigchld_action.sa_mask,
1072
1036
NULL));
1073
1037
if(ret < 0){
1074
error(0, errno, "sigprocmask");
1075
exitstatus = EX_OSERR;
1038
perror("sigprocmask");
1039
exitstatus = EXIT_FAILURE;
1076
1040
goto fallback;
1077
1041
}
1078
1042
1079
#if defined (__GNUC__) and defined (__GLIBC__)
1080
#if not __GLIBC_PREREQ(2, 16)
1081
#pragma GCC diagnostic push
1082
#pragma GCC diagnostic ignored "-Wsign-conversion"
1083
#endif
1084
#endif
1085
1043
FD_SET(new_plugin->fd, &rfds_all); /* Spurious warning from
1086
-Wconversion in GNU libc
1087
before 2.16 */
1088
#if defined (__GNUC__) and defined (__GLIBC__)
1089
#if not __GLIBC_PREREQ(2, 16)
1090
#pragma GCC diagnostic pop
1091
#endif
1092
#endif
1044
-Wconversion */
1093
1045
1094
1046
if(maxfd < new_plugin->fd){
1095
1047
maxfd = new_plugin->fd;
1116
1068
fd_set rfds = rfds_all;
1117
1069
int select_ret = select(maxfd+1, &rfds, NULL, NULL, NULL);
1118
1070
if(select_ret == -1 and errno != EINTR){
1119
error(0, errno, "select");
1120
exitstatus = EX_OSERR;
1071
perror("select");
1072
exitstatus = EXIT_FAILURE;
1121
1073
goto fallback;
1122
1074
}
1123
1075
/* OK, now either a process completed, or something can be read
1149
1101
}
1150
1102
1151
1103
/* Remove the plugin */
1152
#if defined (__GNUC__) and defined (__GLIBC__)
1153
#if not __GLIBC_PREREQ(2, 16)
1154
#pragma GCC diagnostic push
1155
#pragma GCC diagnostic ignored "-Wsign-conversion"
1156
#endif
1157
#endif
1158
1104
FD_CLR(proc->fd, &rfds_all); /* Spurious warning from
1159
-Wconversion in GNU libc
1160
before 2.16 */
1161
#if defined (__GNUC__) and defined (__GLIBC__)
1162
#if not __GLIBC_PREREQ(2, 16)
1163
#pragma GCC diagnostic pop
1164
#endif
1165
#endif
1105
-Wconversion */
1166
1106
1167
1107
/* Block signal while modifying process_list */
1168
1108
ret = (int)TEMP_FAILURE_RETRY(sigprocmask
1170
1110
&sigchld_action.sa_mask,
1171
1111
NULL));
1172
1112
if(ret < 0){
1173
error(0, errno, "sigprocmask");
1174
exitstatus = EX_OSERR;
1113
perror("sigprocmask");
1114
exitstatus = EXIT_FAILURE;
1175
1115
goto fallback;
1176
1116
}
1177
1117
1184
1124
(sigprocmask(SIG_UNBLOCK,
1185
1125
&sigchld_action.sa_mask, NULL)));
1186
1126
if(ret < 0){
1187
error(0, errno, "sigprocmask");
1188
exitstatus = EX_OSERR;
1127
perror("sigprocmask");
1128
exitstatus = EXIT_FAILURE;
1189
1129
goto fallback;
1190
1130
}
1191
1131
1201
1141
bool bret = print_out_password(proc->buffer,
1202
1142
proc->buffer_length);
1203
1143
if(not bret){
1204
error(0, errno, "print_out_password");
1205
exitstatus = EX_IOERR;
1144
perror("print_out_password");
1145
exitstatus = EXIT_FAILURE;
1206
1146
}
1207
1147
goto fallback;
1208
1148
}
1209
1149
1210
1150
/* This process has not completed. Does it have any output? */
1211
#if defined (__GNUC__) and defined (__GLIBC__)
1212
#if not __GLIBC_PREREQ(2, 16)
1213
#pragma GCC diagnostic push
1214
#pragma GCC diagnostic ignored "-Wsign-conversion"
1215
#endif
1216
#endif
1217
1151
if(proc->eof or not FD_ISSET(proc->fd, &rfds)){ /* Spurious
1218
1152
warning from
1219
-Wconversion
1220
in GNU libc
1221
before
1222
2.16 */
1223
#if defined (__GNUC__) and defined (__GLIBC__)
1224
#if not __GLIBC_PREREQ(2, 16)
1225
#pragma GCC diagnostic pop
1226
#endif
1227
#endif
1153
-Wconversion */
1228
1154
/* This process had nothing to say at this time */
1229
1155
proc = proc->next;
1230
1156
continue;
1231
1157
}
1232
1158
/* Before reading, make the process' data buffer large enough */
1233
1159
if(proc->buffer_length + BUFFER_SIZE > proc->buffer_size){
1234
char *new_buffer = realloc(proc->buffer, proc->buffer_size
1235
+ (size_t) BUFFER_SIZE);
1236
if(new_buffer == NULL){
1237
error(0, errno, "malloc");
1238
exitstatus = EX_OSERR;
1160
proc->buffer = realloc(proc->buffer, proc->buffer_size
1161
+ (size_t) BUFFER_SIZE);
1162
if(proc->buffer == NULL){
1163
perror("malloc");
1164
exitstatus = EXIT_FAILURE;
1239
1165
goto fallback;
1240
1166
}
1241
proc->buffer = new_buffer;
1242
1167
proc->buffer_size += BUFFER_SIZE;
1243
1168
}
1244
1169
/* Read from the process */
1263
1188
1264
1189
fallback:
1265
1190
1266
if(plugin_list == NULL or (exitstatus != EXIT_SUCCESS
1267
and exitstatus != EX_OK)){
1191
if(plugin_list == NULL or exitstatus != EXIT_SUCCESS){
1268
1192
/* Fallback if all plugins failed, none are found or an error
1269
1193
occured */
1270
1194
bool bret;
1278
1202
}
1279
1203
bret = print_out_password(passwordbuffer, len);
1280
1204
if(not bret){
1281
error(0, errno, "print_out_password");
1282
exitstatus = EX_IOERR;
1205
perror("print_out_password");
1206
exitstatus = EXIT_FAILURE;
1283
1207
}
1284
1208
}
1285
1209
1286
1210
/* Restore old signal handler */
1287
1211
ret = sigaction(SIGCHLD, &old_sigchld_action, NULL);
1288
1212
if(ret == -1){
1289
error(0, errno, "sigaction");
1290
exitstatus = EX_OSERR;
1213
perror("sigaction");
1214
exitstatus = EXIT_FAILURE;
1291
1215
}
1292
1216
1293
1217
if(custom_argv != NULL){
1308
1232
ret = kill(p->pid, SIGTERM);
1309
1233
if(ret == -1 and errno != ESRCH){
1310
1234
/* Set-uid proccesses might not get closed */
1311
error(0, errno, "kill");
1235
perror("kill");
1312
1236
}
1313
1237
}
1314
1238
}
1318
1242
ret = wait(NULL);
1319
1243
} while(ret >= 0);
1320
1244
if(errno != ECHILD){
1321
error(0, errno, "wait");
1245
perror("wait");
1322
1246
}
1323
1247
1324
1248
free_plugin_list();
Loggerhead is a web-based interface for Breezy
Version: 2.0.2.dev0