/mandos/trunk

To get this branch, use:
bzr branch http://bzr.recompile.se/loggerhead/mandos/trunk

« back to all changes in this revision

Viewing changes to debian/mandos.prerm

  • Committer: Teddy Hogeborn
  • Date: 2009-10-24 19:17:52 UTC
  • Revision ID: teddy@fukt.bsnet.se-20091024191752-7g6xlf6wpp2pdexb
Convert some programs to use the exit codes from <sysexits.h>.  Change
all programs using the "argp" parsing functions to use them correctly;
checking return value, using argp_error() to report parse errors etc.

* plugin-runner.c: Use <sysexits.h> exit codes.  Always use fallback,
                   even on option errors, except for "--help", etc.
  (getplugin): Make sure "errno" is set correctly on return.
  (main): Declare our own "--help", "--usage", and "--version"
          options which do not cause the fallback to be invoked.
          In all other options, use fallback on any error.
  (parse_opt, parse_opt_config_file): Reset errno at start and return
                                      errno.  No need to check "arg"
                                      for NULL.  New "--help",
                                      "--usage", and "--version"
                                      options.
  (parse_opt): Accept empty string as global option.  Do not print
               errors which will be detected and reported later.  Do
               "argp_error()" on parse error or empty plugin names.
* plugins.d/mandos-client.c: Use <sysexits.h> exit codes.  Do not
                             return successful exit code on "--help",
                             etc. since this would give the wrong
                             message to "plugin-runner".
  (main): Declare our own "--help", "--usage", and "--version"
          options which do not return a successful exit code.
  (parse_opt): Reset errno at start and return errno.  Do
               "argp_error()" on parse errors.  New "--help",
               "--usage", and "--version" options.
* plugins.d/password-prompt.c: Use exit codes from <sysexits.h>.  Do
                               not return successful exit code on
                               "--help", etc. since this would give
                               the wrong message to "plugin-runner".
  (main): Declare our own "--help", "--usage", and "--version" options
          which do not return a successful exit code.  Do
          close(STDOUT_FILENO) after writing to check its return code.
  (parse_opt): Reset errno at start and return errno.

Show diffs side-by-side

added added

removed removed

Lines of Context:
6
6
set -e
7
7
 
8
8
# summary of how this script can be called:
9
 
#        * <prerm> `remove'
10
 
#        * <old-prerm> `upgrade' <new-version>
11
 
#        * <new-prerm> `failed-upgrade' <old-version>
12
 
#        * <conflictor's-prerm> `remove' `in-favour' <package> <new-version>
13
 
#        * <deconfigured's-prerm> `deconfigure' `in-favour'
14
 
#          <package-being-installed> <version> `removing'
 
9
#        * <prerm> 'remove'
 
10
#        * <old-prerm> 'upgrade' <new-version>
 
11
#        * <new-prerm> 'failed-upgrade' <old-version>
 
12
#        * <conflictor's-prerm> 'remove' 'in-favour' <package> <new-version>
 
13
#        * <deconfigured's-prerm> 'deconfigure' 'in-favour'
 
14
#          <package-being-installed> <version> 'removing'
15
15
#          <conflicting-package> <version>
16
16
# for details, see /usr/share/doc/packaging-manual/
17
17
 
28
28
    upgrade|failed-upgrade)
29
29
        ;;
30
30
    *)
31
 
        echo "prerm called with unknown argument \`$1'" >&2
 
31
        echo "prerm called with unknown argument '$1'" >&2
32
32
        exit 0
33
33
    ;;
34
34
esac