/mandos/trunk

To get this branch, use:
bzr branch http://bzr.recompile.se/loggerhead/mandos/trunk

« back to all changes in this revision

Viewing changes to Makefile

  • Committer: Teddy Hogeborn
  • Date: 2009-10-24 19:17:52 UTC
  • Revision ID: teddy@fukt.bsnet.se-20091024191752-7g6xlf6wpp2pdexb
Convert some programs to use the exit codes from <sysexits.h>.  Change
all programs using the "argp" parsing functions to use them correctly;
checking return value, using argp_error() to report parse errors etc.

* plugin-runner.c: Use <sysexits.h> exit codes.  Always use fallback,
                   even on option errors, except for "--help", etc.
  (getplugin): Make sure "errno" is set correctly on return.
  (main): Declare our own "--help", "--usage", and "--version"
          options which do not cause the fallback to be invoked.
          In all other options, use fallback on any error.
  (parse_opt, parse_opt_config_file): Reset errno at start and return
                                      errno.  No need to check "arg"
                                      for NULL.  New "--help",
                                      "--usage", and "--version"
                                      options.
  (parse_opt): Accept empty string as global option.  Do not print
               errors which will be detected and reported later.  Do
               "argp_error()" on parse error or empty plugin names.
* plugins.d/mandos-client.c: Use <sysexits.h> exit codes.  Do not
                             return successful exit code on "--help",
                             etc. since this would give the wrong
                             message to "plugin-runner".
  (main): Declare our own "--help", "--usage", and "--version"
          options which do not return a successful exit code.
  (parse_opt): Reset errno at start and return errno.  Do
               "argp_error()" on parse errors.  New "--help",
               "--usage", and "--version" options.
* plugins.d/password-prompt.c: Use exit codes from <sysexits.h>.  Do
                               not return successful exit code on
                               "--help", etc. since this would give
                               the wrong message to "plugin-runner".
  (main): Declare our own "--help", "--usage", and "--version" options
          which do not return a successful exit code.  Do
          close(STDOUT_FILENO) after writing to check its return code.
  (parse_opt): Reset errno at start and return errno.

Show diffs side-by-side

added added

removed removed

Lines of Context:
1
1
WARN=-O -Wall -Wformat=2 -Winit-self -Wmissing-include-dirs \
2
2
        -Wswitch-default -Wswitch-enum -Wunused-parameter \
3
 
        -Wstrict-aliasing=2 -Wextra -Wfloat-equal -Wundef -Wshadow \
 
3
        -Wstrict-aliasing=1 -Wextra -Wfloat-equal -Wundef -Wshadow \
4
4
        -Wunsafe-loop-optimizations -Wpointer-arith \
5
5
        -Wbad-function-cast -Wcast-qual -Wcast-align -Wwrite-strings \
6
6
        -Wconversion -Wstrict-prototypes -Wold-style-definition \
8
8
#       -Wunreachable-code 
9
9
#DEBUG=-ggdb3
10
10
# For info about _FORTIFY_SOURCE, see
11
 
# <http://gcc.gnu.org/ml/gcc-patches/2004-09/msg02055.html>
12
 
FORTIFY=-D_FORTIFY_SOURCE=2 -fstack-protector-all -fPIE -pie
13
 
LINK_FORTIFY=-z relro -pie
 
11
# <http://www.kernel.org/doc/man-pages/online/pages/man7/feature_test_macros.7.html>
 
12
# and <http://gcc.gnu.org/ml/gcc-patches/2004-09/msg02055.html>.
 
13
FORTIFY=-D_FORTIFY_SOURCE=2 -fstack-protector-all -fPIC -fPIE
 
14
LINK_FORTIFY_LD=-z relro -fPIE
 
15
LINK_FORTIFY=-pie
14
16
#COVERAGE=--coverage
15
17
OPTIMIZE=-Os
16
18
LANGUAGE=-std=gnu99
17
19
htmldir=man
18
 
version=1.0.3
 
20
version=1.0.13
19
21
SED=sed
20
22
 
21
23
## Use these settings for a traditional /usr/local install
34
36
INITRAMFSTOOLS=$(DESTDIR)/usr/share/initramfs-tools
35
37
##
36
38
 
37
 
GNUTLS_CFLAGS=$(shell libgnutls-config --cflags)
38
 
GNUTLS_LIBS=$(shell libgnutls-config --libs)
 
39
GNUTLS_CFLAGS=$(shell pkg-config --cflags-only-I gnutls)
 
40
GNUTLS_LIBS=$(shell pkg-config --libs gnutls)
39
41
AVAHI_CFLAGS=$(shell pkg-config --cflags-only-I avahi-core)
40
42
AVAHI_LIBS=$(shell pkg-config --libs avahi-core)
41
 
GPGME_CFLAGS=$(shell gpgme-config --cflags)
42
 
GPGME_LIBS=$(shell gpgme-config --libs)
 
43
GPGME_CFLAGS=$(shell gpgme-config --cflags; getconf LFS_CFLAGS)
 
44
GPGME_LIBS=$(shell gpgme-config --libs; getconf LFS_LIBS; \
 
45
        getconf LFS_LDFLAGS)
43
46
 
44
47
# Do not change these two
45
48
CFLAGS=$(WARN) $(DEBUG) $(FORTIFY) $(COVERAGE) $(OPTIMIZE) \
46
49
        $(LANGUAGE) $(GNUTLS_CFLAGS) $(AVAHI_CFLAGS) $(GPGME_CFLAGS) \
47
50
        -DVERSION='"$(version)"'
48
 
LDFLAGS=$(COVERAGE) $(foreach flag,$(LINK_FORTIFY),-Xlinker $(flag))
 
51
LDFLAGS=$(COVERAGE) $(LINK_FORTIFY) $(foreach flag,$(LINK_FORTIFY_LD),-Xlinker $(flag))
49
52
 
50
53
# Commands to format a DocBook <refentry> document into a manual page
51
54
DOCBOOKTOMAN=cd $(dir $<); xsltproc --nonet --xinclude \
76
79
PLUGINS=plugins.d/password-prompt plugins.d/mandos-client \
77
80
        plugins.d/usplash plugins.d/splashy plugins.d/askpass-fifo
78
81
CPROGS=plugin-runner $(PLUGINS)
79
 
PROGS=mandos mandos-keygen $(CPROGS)
 
82
PROGS=mandos mandos-keygen mandos-ctl $(CPROGS)
80
83
DOCS=mandos.8 plugin-runner.8mandos mandos-keygen.8 \
81
84
        plugins.d/mandos-client.8mandos \
82
85
        plugins.d/password-prompt.8mandos mandos.conf.5 \
150
153
# Update all these files with version number $(version)
151
154
common.ent: Makefile
152
155
        $(SED) --in-place \
153
 
                --expression='s/^\(<ENTITY VERSION "\)[^"]*">$$/\1$(version)"/' \
 
156
                --expression='s/^\(<!ENTITY version "\)[^"]*">$$/\1$(version)">/' \
154
157
                $@
155
158
 
156
159
mandos: Makefile
163
166
                --expression='s/^\(VERSION="\)[^"]*"$$/\1$(version)"/' \
164
167
                $@
165
168
 
 
169
mandos-ctl: Makefile
 
170
        $(SED) --in-place \
 
171
                --expression='s/^\(version = "\)[^"]*"$$/\1$(version)"/' \
 
172
                $@
 
173
 
166
174
mandos.lsm: Makefile
167
175
        $(SED) --in-place \
168
176
                --expression='s/^\(Version:\).*/\1\t$(version)/' \
170
178
        $(SED) --in-place \
171
179
                --expression='s/^\(Entered-date:\).*/\1\t$(shell date --rfc-3339=date --reference=Makefile)/' \
172
180
                $@
 
181
        $(SED) --in-place \
 
182
                --expression='s/\(mandos_\)[0-9.]\+\(\.orig\.tar\.gz\)/\1$(version)\2/' \
 
183
                $@
173
184
 
174
185
plugins.d/mandos-client: plugins.d/mandos-client.o
175
186
        $(LINK.o) $(GNUTLS_LIBS) $(AVAHI_LIBS) $(GPGME_LIBS) \
194
205
run-client: all keydir/seckey.txt keydir/pubkey.txt
195
206
        ./plugin-runner --plugin-dir=plugins.d \
196
207
                --config-file=plugin-runner.conf \
197
 
                --options-for=mandos-client:--seckey=keydir/seckey.txt,--pubkey=keydir/pubkey.txt
 
208
                --options-for=mandos-client:--seckey=keydir/seckey.txt,--pubkey=keydir/pubkey.txt \
 
209
                $(CLIENTARGS)
198
210
 
199
211
# Used by run-client
200
212
keydir/seckey.txt keydir/pubkey.txt: mandos-keygen
203
215
 
204
216
# Run the server with a local config
205
217
run-server: confdir/mandos.conf confdir/clients.conf
206
 
        ./mandos --debug --configdir=confdir
 
218
        ./mandos --debug --no-dbus --configdir=confdir $(SERVERARGS)
207
219
 
208
220
# Used by run-server
209
221
confdir/mandos.conf: mandos.conf
275
287
        install --mode=u=rw,go=r initramfs-tools-hook-conf \
276
288
                $(INITRAMFSTOOLS)/conf-hooks.d/mandos
277
289
        install initramfs-tools-script \
278
 
                $(INITRAMFSTOOLS)/scripts/local-top/mandos
 
290
                $(INITRAMFSTOOLS)/scripts/init-premount/mandos
279
291
        install --mode=u=rw,go=r plugin-runner.conf $(CONFDIR)
280
292
        gzip --best --to-stdout mandos-keygen.8 \
281
293
                > $(MANDIR)/man8/mandos-keygen.8.gz
322
334
                $(PREFIX)/lib/mandos/plugins.d/askpass-fifo \
323
335
                $(INITRAMFSTOOLS)/hooks/mandos \
324
336
                $(INITRAMFSTOOLS)/conf-hooks.d/mandos \
325
 
                $(INITRAMFSTOOLS)/scripts/local-top/mandos \
 
337
                $(INITRAMFSTOOLS)/scripts/init-premount/mandos \
326
338
                $(MANDIR)/man8/plugin-runner.8mandos.gz \
327
339
                $(MANDIR)/man8/mandos-keygen.8.gz \
328
340
                $(MANDIR)/man8/password-prompt.8mandos.gz \