/mandos/trunk : revision 392

1

/* -*- coding: utf-8 -*- */

1

/* -*- coding: utf-8; mode: c; mode: orgtbl -*- */

2

/*

3

* Mandos plugin runner - Run Mandos plugins

4

*

23

*/

24

25

#define _GNU_SOURCE /* TEMP_FAILURE_RETRY(), getline(),

26

asprintf() */

26

asprintf(), O_CLOEXEC */

27

#include <stddef.h> /* size_t, NULL */

28

#include <stdlib.h> /* malloc(), exit(), EXIT_FAILURE,

29

EXIT_SUCCESS, realloc() */

30

#include <stdbool.h> /* bool, true, false */

31

#include <stdio.h> /* perror, fileno(), fprintf(),

32

stderr, STDOUT_FILENO */

33

#include <sys/types.h> /* DIR, opendir(), stat(), struct

33

#include <sys/types.h> /* DIR, fdopendir(), stat(), struct

34

stat, waitpid(), WIFEXITED(),

35

WEXITSTATUS(), wait(), pid_t,

36

uid_t, gid_t, getuid(), getgid(),

38

#include <sys/select.h> /* fd_set, select(), FD_ZERO(),

39

FD_SET(), FD_ISSET(), FD_CLR */

40

#include <sys/wait.h> /* wait(), waitpid(), WIFEXITED(),

41

WEXITSTATUS() */

41

WEXITSTATUS(), WTERMSIG(),

42

WCOREDUMP() */

42

43

#include <sys/stat.h> /* struct stat, stat(), S_ISREG() */

43

44

#include <iso646.h> /* and, or, not */

44

#include <dirent.h> /* DIR, struct dirent, opendir(),

45

#include <dirent.h> /* DIR, struct dirent, fdopendir(),

45

46

readdir(), closedir(), dirfd() */

46

47

#include <unistd.h> /* struct stat, stat(), S_ISREG(),

47

48

fcntl(), setuid(), setgid(),

52

53

close() */

53

54

#include <fcntl.h> /* fcntl(), F_GETFD, F_SETFD,

54

55

FD_CLOEXEC */

55

#include <string.h> /* strsep, strlen(), asprintf() */

56

#include <string.h> /* strsep, strlen(), asprintf(),

57

strsignal() */

56

58

#include <errno.h> /* errno */

57

59

#include <argp.h> /* struct argp_option, struct

58

60

argp_state, struct argp,

62

64

#include <signal.h> /* struct sigaction, sigemptyset(),

63

65

sigaddset(), sigaction(),

64

66

sigprocmask(), SIG_BLOCK, SIGCHLD,

65

SIG_UNBLOCK, kill() */

67

SIG_UNBLOCK, kill(), sig_atomic_t

68

*/

66

69

#include <errno.h> /* errno, EBADF */

67

#include <inttypes.h> /* intmax_t, SCNdMAX, PRIdMAX, */

70

#include <inttypes.h> /* intmax_t, PRIdMAX, strtoimax() */

68

71

69

72

#define BUFFER_SIZE 256

70

73

81

84

char **environ;

82

85

int envc;

83

86

bool disabled;

84

87

85

88

/* Variables used for running processes*/

86

89

pid_t pid;

87

90

int fd;

89

92

size_t buffer_size;

90

93

size_t buffer_length;

91

94

bool eof;

92

volatile bool completed;

93

volatile int status;

95

volatile sig_atomic_t completed;

96

int status;

94

97

struct plugin *next;

95

98

} plugin;

96

99

107

110

}

108

111

}

109

112

/* Create a new plugin */

110

plugin *new_plugin = malloc(sizeof(plugin));

113

plugin *new_plugin = NULL;

114

do {

115

new_plugin = malloc(sizeof(plugin));

116

} while(new_plugin == NULL and errno == EINTR);

111

117

if(new_plugin == NULL){

112

118

return NULL;

113

119

}

114

120

char *copy_name = NULL;

115

121

if(name != NULL){

116

copy_name = strdup(name);

122

do {

123

copy_name = strdup(name);

124

} while(copy_name == NULL and errno == EINTR);

117

125

if(copy_name == NULL){

126

free(new_plugin);

118

127

return NULL;

119

128

}

120

129

}

121

130

122

*new_plugin = (plugin) { .name = copy_name,

123

.argc = 1,

124

.disabled = false,

125

.next = plugin_list };

131

*new_plugin = (plugin){ .name = copy_name,

132

.argc = 1,

133

.disabled = false,

134

.next = plugin_list };

126

135

127

new_plugin->argv = malloc(sizeof(char *) * 2);

136

do {

137

new_plugin->argv = malloc(sizeof(char *) * 2);

138

} while(new_plugin->argv == NULL and errno == EINTR);

128

139

if(new_plugin->argv == NULL){

129

140

free(copy_name);

130

141

free(new_plugin);

133

144

new_plugin->argv[0] = copy_name;

134

145

new_plugin->argv[1] = NULL;

135

146

136

new_plugin->environ = malloc(sizeof(char *));

147

do {

148

new_plugin->environ = malloc(sizeof(char *));

149

} while(new_plugin->environ == NULL and errno == EINTR);

137

150

if(new_plugin->environ == NULL){

138

151

free(copy_name);

139

152

free(new_plugin->argv);

151

164

static bool add_to_char_array(const char *new, char ***array,

152

165

int *len){

153

166

/* Resize the pointed-to array to hold one more pointer */

154

*array = realloc(*array, sizeof(char *)

155

* (size_t) ((*len) + 2));

167

do {

168

*array = realloc(*array, sizeof(char *)

169

* (size_t) ((*len) + 2));

170

} while(*array == NULL and errno == EINTR);

156

171

/* Malloc check */

157

172

if(*array == NULL){

158

173

return false;

159

174

}

160

175

/* Make a copy of the new string */

161

char *copy = strdup(new);

176

char *copy;

177

do {

178

copy = strdup(new);

179

} while(copy == NULL and errno == EINTR);

162

180

if(copy == NULL){

163

181

return false;

164

182

}

190

208

if(strncmp(*e, def, namelen + 1) == 0){

191

209

/* It already exists */

192

210

if(replace){

193

char *new = realloc(*e, strlen(def) + 1);

211

char *new;

212

do {

213

new = realloc(*e, strlen(def) + 1);

214

} while(new == NULL and errno == EINTR);

194

215

if(new == NULL){

195

216

return false;

196

217

}

206

227

/*

207

228

* Based on the example in the GNU LibC manual chapter 13.13 "File

208

229

* Descriptor Flags".

209

* *Note File Descriptor Flags:(libc)Descriptor Flags.

230

| [[info:libc:Descriptor%20Flags][File Descriptor Flags]] |

210

231

*/

211

232

static int set_cloexec_flag(int fd){

212

int ret = fcntl(fd, F_GETFD, 0);

233

int ret = (int)TEMP_FAILURE_RETRY(fcntl(fd, F_GETFD, 0));

213

234

/* If reading the flags failed, return error indication now. */

214

235

if(ret < 0){

215

236

return ret;

216

237

}

217

238

/* Store modified flag word in the descriptor. */

218

return fcntl(fd, F_SETFD, ret | FD_CLOEXEC);

239

return (int)TEMP_FAILURE_RETRY(fcntl(fd, F_SETFD,

240

ret | FD_CLOEXEC));

219

241

}

220

242

221

243

222

244

/* Mark processes as completed when they exit, and save their exit

223

245

status. */

224

246

static void handle_sigchld(__attribute__((unused)) int sig){

247

int old_errno = errno;

225

248

while(true){

226

249

plugin *proc = plugin_list;

227

250

int status;

231

254

break;

232

255

}

233

256

if(pid == -1){

234

if(errno != ECHILD){

235

perror("waitpid");

257

if(errno == ECHILD){

258

/* No child processes */

259

break;

236

260

}

237

/* No child processes */

238

break;

261

perror("waitpid");

239

262

}

240

263

241

264

/* A child exited, find it in process_list */

247

270

continue;

248

271

}

249

272

proc->status = status;

250

proc->completed = true;

273

proc->completed = 1;

251

274

}

275

errno = old_errno;

252

276

}

253

277

254

278

/* Prints out a password to stdout */

276

300

}

277

301

free(plugin_node->environ);

278

302

free(plugin_node->buffer);

279

303

280

304

/* Removes the plugin from the singly-linked list */

281

305

if(plugin_node == plugin_list){

282

306

/* First one - simple */

309

333

struct dirent *dirst;

310

334

struct stat st;

311

335

fd_set rfds_all;

312

int ret, numchars, maxfd = 0;

336

int ret, maxfd = 0;

313

337

ssize_t sret;

314

intmax_t tmpmax;

315

338

uid_t uid = 65534;

316

339

gid_t gid = 65534;

317

340

bool debug = false;

375

398

};

376

399

377

400

error_t parse_opt(int key, char *arg, __attribute__((unused))

378

struct argp_state *state) {

379

switch(key) {

401

struct argp_state *state){

402

switch(key){

403

char *tmp;

404

intmax_t tmpmax;

380

405

case 'g': /* --global-options */

381

406

if(arg != NULL){

382

char *p;

383

while((p = strsep(&arg, ",")) != NULL){

384

if(p[0] == '\0'){

407

char *plugin_option;

408

while((plugin_option = strsep(&arg, ",")) != NULL){

409

if(plugin_option[0] == '\0'){

385

410

continue;

386

411

}

387

if(not add_argument(getplugin(NULL), p)){

412

if(not add_argument(getplugin(NULL), plugin_option)){

388

413

perror("add_argument");

389

414

return ARGP_ERR_UNKNOWN;

390

415

}

401

426

break;

402

427

case 'o': /* --options-for */

403

428

if(arg != NULL){

404

char *p_name = strsep(&arg, ":");

405

if(p_name[0] == '\0' or arg == NULL){

406

break;

407

}

408

char *opt = strsep(&arg, ":");

409

if(opt[0] == '\0' or opt == NULL){

410

break;

411

}

412

char *p;

413

while((p = strsep(&opt, ",")) != NULL){

414

if(p[0] == '\0'){

415

continue;

416

}

417

if(not add_argument(getplugin(p_name), p)){

429

char *plugin_name = strsep(&arg, ":");

430

if(plugin_name[0] == '\0'){

431

break;

432

}

433

char *plugin_option;

434

while((plugin_option = strsep(&arg, ",")) != NULL){

435

if(not add_argument(getplugin(plugin_name), plugin_option)){

418

436

perror("add_argument");

419

437

return ARGP_ERR_UNKNOWN;

420

438

}

459

477

plugindir = strdup(arg);

460

478

if(plugindir == NULL){

461

479

perror("strdup");

462

}

480

}

463

481

break;

464

482

case 129: /* --config-file */

465

483

/* This is already done by parse_opt_config_file() */

466

484

break;

467

485

case 130: /* --userid */

468

ret = sscanf(arg, "%" SCNdMAX "%n", &tmpmax, &numchars);

469

if(ret < 1 or tmpmax != (uid_t)tmpmax

470

or arg[numchars] != '\0'){

486

errno = 0;

487

tmpmax = strtoimax(arg, &tmp, 10);

488

if(errno != 0 or tmp == arg or *tmp != '\0'

489

or tmpmax != (uid_t)tmpmax){

471

490

fprintf(stderr, "Bad user ID number: \"%s\", using %"

472

491

PRIdMAX "\n", arg, (intmax_t)uid);

473

492

} else {

475

494

}

476

495

break;

477

496

case 131: /* --groupid */

478

ret = sscanf(arg, "%" SCNdMAX "%n", &tmpmax, &numchars);

479

if(ret < 1 or tmpmax != (gid_t)tmpmax

480

or arg[numchars] != '\0'){

497

errno = 0;

498

tmpmax = strtoimax(arg, &tmp, 10);

499

if(errno != 0 or tmp == arg or *tmp != '\0'

500

or tmpmax != (gid_t)tmpmax){

481

501

fprintf(stderr, "Bad group ID number: \"%s\", using %"

482

502

PRIdMAX "\n", arg, (intmax_t)gid);

483

503

} else {

511

531

ignores everything but the --config-file option. */

512

532

error_t parse_opt_config_file(int key, char *arg,

513

533

__attribute__((unused))

514

struct argp_state *state) {

515

switch(key) {

534

struct argp_state *state){

535

switch(key){

516

536

case 'g': /* --global-options */

517

537

case 'G': /* --global-env */

518

538

case 'o': /* --options-for */

527

547

if(argfile == NULL){

528

548

perror("strdup");

529

549

}

530

break;

550

break;

531

551

case 130: /* --userid */

532

552

case 131: /* --groupid */

533

553

case 132: /* --debug */

562

582

conffp = fopen(AFILE, "r");

563

583

} else {

564

584

conffp = fopen(argfile, "r");

565

}

585

}

566

586

if(conffp != NULL){

567

587

char *org_line = NULL;

568

588

char *p, *arg, *new_arg, *line;

569

589

size_t size = 0;

570

590

const char whitespace_delims[] = " \r\t\f\v\n";

571

591

const char comment_delim[] = "#";

572

592

573

593

custom_argc = 1;

574

594

custom_argv = malloc(sizeof(char*) * 2);

575

595

if(custom_argv == NULL){

579

599

}

580

600

custom_argv[0] = argv[0];

581

601

custom_argv[1] = NULL;

582

602

583

603

/* for each line in the config file, strip whitespace and ignore

584

604

commented text */

585

605

while(true){

587

607

if(sret == -1){

588

608

break;

589

609

}

590

610

591

611

line = org_line;

592

612

arg = strsep(&line, comment_delim);

593

613

while((p = strsep(&arg, whitespace_delims)) != NULL){

612

632

goto fallback;

613

633

}

614

634

custom_argv[custom_argc-1] = new_arg;

615

custom_argv[custom_argc] = NULL;

635

custom_argv[custom_argc] = NULL;

616

636

}

617

637

}

638

do {

639

ret = fclose(conffp);

640

} while(ret == EOF and errno == EINTR);

641

if(ret == EOF){

642

perror("fclose");

643

exitstatus = EXIT_FAILURE;

644

goto fallback;

645

}

618

646

free(org_line);

619

647

} else {

620

648

/* Check for harmful errors and go to fallback. Other errors might

661

689

}

662

690

663

691

/* Strip permissions down to nobody */

692

setgid(gid);

693

if(ret == -1){

694

perror("setgid");

695

}

664

696

ret = setuid(uid);

665

697

if(ret == -1){

666

698

perror("setuid");

667

}

668

setgid(gid);

669

if(ret == -1){

670

perror("setgid");

671

}

672

673

if(plugindir == NULL){

674

dir = opendir(PDIR);

675

} else {

676

dir = opendir(plugindir);

677

}

678

679

if(dir == NULL){

680

perror("Could not open plugin dir");

681

exitstatus = EXIT_FAILURE;

682

goto fallback;

683

}

684

685

/* Set the FD_CLOEXEC flag on the directory, if possible */

699

}

700

701

/* Open plugin directory with close_on_exec flag */

686

702

{

687

int dir_fd = dirfd(dir);

688

if(dir_fd >= 0){

689

ret = set_cloexec_flag(dir_fd);

690

if(ret < 0){

691

perror("set_cloexec_flag");

692

exitstatus = EXIT_FAILURE;

693

goto fallback;

694

}

703

int dir_fd = -1;

704

if(plugindir == NULL){

705

dir_fd = open(PDIR, O_RDONLY |

706

#ifdef O_CLOEXEC

707

O_CLOEXEC

708

#else /* not O_CLOEXEC */

709

0

710

#endif /* not O_CLOEXEC */

711

);

712

} else {

713

dir_fd = open(plugindir, O_RDONLY |

714

#ifdef O_CLOEXEC

715

O_CLOEXEC

716

#else /* not O_CLOEXEC */

717

0

718

#endif /* not O_CLOEXEC */

719

);

720

}

721

if(dir_fd == -1){

722

perror("Could not open plugin dir");

723

exitstatus = EXIT_FAILURE;

724

goto fallback;

725

}

726

727

#ifndef O_CLOEXEC

728

/* Set the FD_CLOEXEC flag on the directory */

729

ret = set_cloexec_flag(dir_fd);

730

if(ret < 0){

731

perror("set_cloexec_flag");

732

TEMP_FAILURE_RETRY(close(dir_fd));

733

exitstatus = EXIT_FAILURE;

734

goto fallback;

735

}

736

#endif /* O_CLOEXEC */

737

738

dir = fdopendir(dir_fd);

739

if(dir == NULL){

740

perror("Could not open plugin dir");

741

TEMP_FAILURE_RETRY(close(dir_fd));

742

exitstatus = EXIT_FAILURE;

743

goto fallback;

695

744

}

696

745

}

697

746

699

748

700

749

/* Read and execute any executable in the plugin directory*/

701

750

while(true){

702

dirst = readdir(dir);

751

do {

752

dirst = readdir(dir);

753

} while(dirst == NULL and errno == EINTR);

703

754

704

755

/* All directory entries have been processed */

705

756

if(dirst == NULL){

756

807

continue;

757

808

}

758

809

}

759

810

760

811

char *filename;

761

812

if(plugindir == NULL){

762

ret = asprintf(&filename, PDIR "/%s", dirst->d_name);

813

ret = (int)TEMP_FAILURE_RETRY(asprintf(&filename, PDIR "/%s",

814

dirst->d_name));

763

815

} else {

764

ret = asprintf(&filename, "%s/%s", plugindir, dirst->d_name);

816

ret = (int)TEMP_FAILURE_RETRY(asprintf(&filename, "%s/%s",

817

plugindir,

818

dirst->d_name));

765

819

}

766

820

if(ret < 0){

767

821

perror("asprintf");

768

822

continue;

769

823

}

770

824

771

ret = stat(filename, &st);

825

ret = (int)TEMP_FAILURE_RETRY(stat(filename, &st));

772

826

if(ret == -1){

773

827

perror("stat");

774

828

free(filename);

775

829

continue;

776

830

}

777

831

778

832

/* Ignore non-executable files */

779

if(not S_ISREG(st.st_mode) or (access(filename, X_OK) != 0)){

833

if(not S_ISREG(st.st_mode)

834

or (TEMP_FAILURE_RETRY(access(filename, X_OK)) != 0)){

780

835

if(debug){

781

836

fprintf(stderr, "Ignoring plugin dir entry \"%s\""

782

837

" with bad type or mode\n", filename);

828

883

}

829

884

830

885

int pipefd[2];

831

ret = pipe(pipefd);

886

ret = (int)TEMP_FAILURE_RETRY(pipe(pipefd));

832

887

if(ret == -1){

833

888

perror("pipe");

834

889

exitstatus = EXIT_FAILURE;

848

903

goto fallback;

849

904

}

850

905

/* Block SIGCHLD until process is safely in process list */

851

ret = sigprocmask(SIG_BLOCK, &sigchld_action.sa_mask, NULL);

906

ret = (int)TEMP_FAILURE_RETRY(sigprocmask(SIG_BLOCK,

907

&sigchld_action.sa_mask,

908

NULL));

852

909

if(ret < 0){

853

910

perror("sigprocmask");

854

911

exitstatus = EXIT_FAILURE;

855

912

goto fallback;

856

913

}

857

914

/* Starting a new process to be watched */

858

pid_t pid = fork();

915

pid_t pid;

916

do {

917

pid = fork();

918

} while(pid == -1 and errno == EINTR);

859

919

if(pid == -1){

860

920

perror("fork");

861

921

exitstatus = EXIT_FAILURE;

899

959

/* no return */

900

960

}

901

961

/* Parent process */

902

close(pipefd[1]); /* Close unused write end of pipe */

962

TEMP_FAILURE_RETRY(close(pipefd[1])); /* Close unused write end of

963

pipe */

903

964

free(filename);

904

965

plugin *new_plugin = getplugin(dirst->d_name);

905

966

if(new_plugin == NULL){

906

967

perror("getplugin");

907

ret = sigprocmask(SIG_UNBLOCK, &sigchld_action.sa_mask, NULL);

968

ret = (int)(TEMP_FAILURE_RETRY

969

(sigprocmask(SIG_UNBLOCK, &sigchld_action.sa_mask,

970

NULL)));

908

971

if(ret < 0){

909

972

perror("sigprocmask");

910

973

}

917

980

918

981

/* Unblock SIGCHLD so signal handler can be run if this process

919

982

has already completed */

920

ret = sigprocmask(SIG_UNBLOCK, &sigchld_action.sa_mask, NULL);

983

ret = (int)TEMP_FAILURE_RETRY(sigprocmask(SIG_UNBLOCK,

984

&sigchld_action.sa_mask,

985

NULL));

921

986

if(ret < 0){

922

987

perror("sigprocmask");

923

988

exitstatus = EXIT_FAILURE;

924

989

goto fallback;

925

990

}

926

991

927

FD_SET(new_plugin->fd, &rfds_all);

992

FD_SET(new_plugin->fd, &rfds_all); /* Spurious warning from

993

-Wconversion */

928

994

929

995

if(maxfd < new_plugin->fd){

930

996

maxfd = new_plugin->fd;

931

997

}

932

998

}

933

999

934

closedir(dir);

1000

TEMP_FAILURE_RETRY(closedir(dir));

935

1001

dir = NULL;

1002

free_plugin(getplugin(NULL));

936

1003

937

1004

for(plugin *p = plugin_list; p != NULL; p = p->next){

938

1005

if(p->pid != 0){

949

1016

while(plugin_list){

950

1017

fd_set rfds = rfds_all;

951

1018

int select_ret = select(maxfd+1, &rfds, NULL, NULL, NULL);

952

if(select_ret == -1){

1019

if(select_ret == -1 and errno != EINTR){

953

1020

perror("select");

954

1021

exitstatus = EXIT_FAILURE;

955

1022

goto fallback;

958

1025

from one of them */

959

1026

for(plugin *proc = plugin_list; proc != NULL;){

960

1027

/* Is this process completely done? */

961

if(proc->eof and proc->completed){

1028

if(proc->completed and proc->eof){

962

1029

/* Only accept the plugin output if it exited cleanly */

963

1030

if(not WIFEXITED(proc->status)

964

1031

or WEXITSTATUS(proc->status) != 0){

965

1032

/* Bad exit by plugin */

966

1033

967

1034

if(debug){

968

1035

if(WIFEXITED(proc->status)){

969

fprintf(stderr, "Plugin %" PRIdMAX " exited with status"

970

" %d\n", (intmax_t) (proc->pid),

1036

fprintf(stderr, "Plugin %s [%" PRIdMAX "] exited with"

1037

" status %d\n", proc->name,

1038

(intmax_t) (proc->pid),

971

1039

WEXITSTATUS(proc->status));

972

} else if(WIFSIGNALED(proc->status)) {

973

fprintf(stderr, "Plugin %" PRIdMAX " killed by signal"

974

" %d\n", (intmax_t) (proc->pid),

975

WTERMSIG(proc->status));

1040

} else if(WIFSIGNALED(proc->status)){

1041

fprintf(stderr, "Plugin %s [%" PRIdMAX "] killed by"

1042

" signal %d: %s\n", proc->name,

1043

(intmax_t) (proc->pid),

1044

WTERMSIG(proc->status),

1045

strsignal(WTERMSIG(proc->status)));

976

1046

} else if(WCOREDUMP(proc->status)){

977

fprintf(stderr, "Plugin %" PRIdMAX " dumped core\n",

978

(intmax_t) (proc->pid));

1047

fprintf(stderr, "Plugin %s [%" PRIdMAX "] dumped"

1048

" core\n", proc->name, (intmax_t) (proc->pid));

979

1049

}

980

1050

}

981

1051

982

1052

/* Remove the plugin */

983

FD_CLR(proc->fd, &rfds_all);

984

1053

FD_CLR(proc->fd, &rfds_all); /* Spurious warning from

1054

-Wconversion */

1055

985

1056

/* Block signal while modifying process_list */

986

ret = sigprocmask(SIG_BLOCK, &sigchld_action.sa_mask, NULL);

1057

ret = (int)TEMP_FAILURE_RETRY(sigprocmask

1058

(SIG_BLOCK,

1059

&sigchld_action.sa_mask,

1060

NULL));

987

1061

if(ret < 0){

988

1062

perror("sigprocmask");

989

1063

exitstatus = EXIT_FAILURE;

995

1069

proc = next_plugin;

996

1070

997

1071

/* We are done modifying process list, so unblock signal */

998

ret = sigprocmask(SIG_UNBLOCK, &sigchld_action.sa_mask,

999

NULL);

1072

ret = (int)(TEMP_FAILURE_RETRY

1073

(sigprocmask(SIG_UNBLOCK,

1074

&sigchld_action.sa_mask, NULL)));

1000

1075

if(ret < 0){

1001

1076

perror("sigprocmask");

1002

1077

exitstatus = EXIT_FAILURE;

1022

1097

}

1023

1098

1024

1099

/* This process has not completed. Does it have any output? */

1025

if(proc->eof or not FD_ISSET(proc->fd, &rfds)){

1100

if(proc->eof or not FD_ISSET(proc->fd, &rfds)){ /* Spurious

1101

warning from

1102

-Wconversion */

1026

1103

/* This process had nothing to say at this time */

1027

1104

proc = proc->next;

1028

1105

continue;

1039

1116

proc->buffer_size += BUFFER_SIZE;

1040

1117

}

1041

1118

/* Read from the process */

1042

sret = read(proc->fd, proc->buffer + proc->buffer_length,

1043

BUFFER_SIZE);

1119

sret = TEMP_FAILURE_RETRY(read(proc->fd,

1120

proc->buffer

1121

+ proc->buffer_length,

1122

BUFFER_SIZE));

1044

1123

if(sret < 0){

1045

1124

/* Read error from this process; ignore the error */

1046

1125

proc = proc->next;

1054

1133

}

1055

1134

}

1056

1135

}

1057

1058

1136

1137

1059

1138

fallback:

1060

1139

1061

1140

if(plugin_list == NULL or exitstatus != EXIT_SUCCESS){

1108

1187

}

1109

1188

1110

1189

/* Wait for any remaining child processes to terminate */

1111

do{

1190

do {

1112

1191

ret = wait(NULL);

1113

1192

} while(ret >= 0);

1114

1193

if(errno != ECHILD){