/mandos/trunk : revision 392

1

/* -*- coding: utf-8 -*- */

1

/* -*- coding: utf-8; mode: c; mode: orgtbl -*- */

2

/*

3

* Mandos plugin runner - Run Mandos plugins

4

*

23

*/

24

25

#define _GNU_SOURCE /* TEMP_FAILURE_RETRY(), getline(),

26

asprintf() */

26

asprintf(), O_CLOEXEC */

27

#include <stddef.h> /* size_t, NULL */

28

#include <stdlib.h> /* malloc(), exit(), EXIT_FAILURE,

29

EXIT_SUCCESS, realloc() */

30

#include <stdbool.h> /* bool, true, false */

31

#include <stdio.h> /* perror, fileno(), fprintf(),

32

stderr, STDOUT_FILENO */

33

#include <sys/types.h> /* DIR, opendir(), stat(), struct

33

#include <sys/types.h> /* DIR, fdopendir(), stat(), struct

34

stat, waitpid(), WIFEXITED(),

35

WEXITSTATUS(), wait(), pid_t,

36

uid_t, gid_t, getuid(), getgid(),

38

#include <sys/select.h> /* fd_set, select(), FD_ZERO(),

39

FD_SET(), FD_ISSET(), FD_CLR */

40

#include <sys/wait.h> /* wait(), waitpid(), WIFEXITED(),

41

WEXITSTATUS() */

41

WEXITSTATUS(), WTERMSIG(),

42

WCOREDUMP() */

42

43

#include <sys/stat.h> /* struct stat, stat(), S_ISREG() */

43

44

#include <iso646.h> /* and, or, not */

44

#include <dirent.h> /* DIR, struct dirent, opendir(),

45

#include <dirent.h> /* DIR, struct dirent, fdopendir(),

45

46

readdir(), closedir(), dirfd() */

46

47

#include <unistd.h> /* struct stat, stat(), S_ISREG(),

47

48

fcntl(), setuid(), setgid(),

52

53

close() */

53

54

#include <fcntl.h> /* fcntl(), F_GETFD, F_SETFD,

54

55

FD_CLOEXEC */

55

#include <string.h> /* strsep, strlen(), asprintf() */

56

#include <string.h> /* strsep, strlen(), asprintf(),

57

strsignal() */

56

58

#include <errno.h> /* errno */

57

59

#include <argp.h> /* struct argp_option, struct

58

60

argp_state, struct argp,

62

64

#include <signal.h> /* struct sigaction, sigemptyset(),

63

65

sigaddset(), sigaction(),

64

66

sigprocmask(), SIG_BLOCK, SIGCHLD,

65

SIG_UNBLOCK, kill() */

67

SIG_UNBLOCK, kill(), sig_atomic_t

68

*/

66

69

#include <errno.h> /* errno, EBADF */

70

#include <inttypes.h> /* intmax_t, PRIdMAX, strtoimax() */

67

71

68

72

#define BUFFER_SIZE 256

69

73

80

84

char **environ;

81

85

int envc;

82

86

bool disabled;

83

87

84

88

/* Variables used for running processes*/

85

89

pid_t pid;

86

90

int fd;

88

92

size_t buffer_size;

89

93

size_t buffer_length;

90

94

bool eof;

91

volatile bool completed;

92

volatile int status;

95

volatile sig_atomic_t completed;

96

int status;

93

97

struct plugin *next;

94

98

} plugin;

95

99

103

or if none is found, creates a new one */

100

104

static plugin *getplugin(char *name){

101

105

/* Check for exiting plugin with that name */

102

for (plugin *p = plugin_list; p != NULL; p = p->next){

103

if ((p->name == name)

104

or (p->name and name and (strcmp(p->name, name) == 0))){

106

for(plugin *p = plugin_list; p != NULL; p = p->next){

107

if((p->name == name)

108

or (p->name and name and (strcmp(p->name, name) == 0))){

105

109

return p;

106

110

}

107

111

}

108

112

/* Create a new plugin */

109

plugin *new_plugin = malloc(sizeof(plugin));

110

if (new_plugin == NULL){

113

plugin *new_plugin = NULL;

114

do {

115

new_plugin = malloc(sizeof(plugin));

116

} while(new_plugin == NULL and errno == EINTR);

117

if(new_plugin == NULL){

111

118

return NULL;

112

119

}

113

120

char *copy_name = NULL;

114

121

if(name != NULL){

115

copy_name = strdup(name);

122

do {

123

copy_name = strdup(name);

124

} while(copy_name == NULL and errno == EINTR);

116

125

if(copy_name == NULL){

126

free(new_plugin);

117

127

return NULL;

118

128

}

119

129

}

120

130

121

*new_plugin = (plugin) { .name = copy_name,

122

.argc = 1,

123

.disabled = false,

124

.next = plugin_list };

131

*new_plugin = (plugin){ .name = copy_name,

132

.argc = 1,

133

.disabled = false,

134

.next = plugin_list };

125

135

126

new_plugin->argv = malloc(sizeof(char *) * 2);

127

if (new_plugin->argv == NULL){

136

do {

137

new_plugin->argv = malloc(sizeof(char *) * 2);

138

} while(new_plugin->argv == NULL and errno == EINTR);

139

if(new_plugin->argv == NULL){

128

140

free(copy_name);

129

141

free(new_plugin);

130

142

return NULL;

132

144

new_plugin->argv[0] = copy_name;

133

145

new_plugin->argv[1] = NULL;

134

146

135

new_plugin->environ = malloc(sizeof(char *));

147

do {

148

new_plugin->environ = malloc(sizeof(char *));

149

} while(new_plugin->environ == NULL and errno == EINTR);

136

150

if(new_plugin->environ == NULL){

137

151

free(copy_name);

138

152

free(new_plugin->argv);

150

164

static bool add_to_char_array(const char *new, char ***array,

151

165

int *len){

152

166

/* Resize the pointed-to array to hold one more pointer */

153

*array = realloc(*array, sizeof(char *)

154

* (size_t) ((*len) + 2));

167

do {

168

*array = realloc(*array, sizeof(char *)

169

* (size_t) ((*len) + 2));

170

} while(*array == NULL and errno == EINTR);

155

171

/* Malloc check */

156

172

if(*array == NULL){

157

173

return false;

158

174

}

159

175

/* Make a copy of the new string */

160

char *copy = strdup(new);

176

char *copy;

177

do {

178

copy = strdup(new);

179

} while(copy == NULL and errno == EINTR);

161

180

if(copy == NULL){

162

181

return false;

163

182

}

189

208

if(strncmp(*e, def, namelen + 1) == 0){

190

209

/* It already exists */

191

210

if(replace){

192

char *new = realloc(*e, strlen(def) + 1);

211

char *new;

212

do {

213

new = realloc(*e, strlen(def) + 1);

214

} while(new == NULL and errno == EINTR);

193

215

if(new == NULL){

194

216

return false;

195

217

}

205

227

/*

206

228

* Based on the example in the GNU LibC manual chapter 13.13 "File

207

229

* Descriptor Flags".

208

* *Note File Descriptor Flags:(libc)Descriptor Flags.

230

| [[info:libc:Descriptor%20Flags][File Descriptor Flags]] |

209

231

*/

210

232

static int set_cloexec_flag(int fd){

211

int ret = fcntl(fd, F_GETFD, 0);

233

int ret = (int)TEMP_FAILURE_RETRY(fcntl(fd, F_GETFD, 0));

212

234

/* If reading the flags failed, return error indication now. */

213

235

if(ret < 0){

214

236

return ret;

215

237

}

216

238

/* Store modified flag word in the descriptor. */

217

return fcntl(fd, F_SETFD, ret | FD_CLOEXEC);

239

return (int)TEMP_FAILURE_RETRY(fcntl(fd, F_SETFD,

240

ret | FD_CLOEXEC));

218

241

}

219

242

220

243

221

244

/* Mark processes as completed when they exit, and save their exit

222

245

status. */

223

246

static void handle_sigchld(__attribute__((unused)) int sig){

247

int old_errno = errno;

224

248

while(true){

225

249

plugin *proc = plugin_list;

226

250

int status;

230

254

break;

231

255

}

232

256

if(pid == -1){

233

if (errno != ECHILD){

234

perror("waitpid");

257

if(errno == ECHILD){

258

/* No child processes */

259

break;

235

260

}

236

/* No child processes */

237

break;

261

perror("waitpid");

238

262

}

239

263

240

264

/* A child exited, find it in process_list */

246

270

continue;

247

271

}

248

272

proc->status = status;

249

proc->completed = true;

273

proc->completed = 1;

250

274

}

275

errno = old_errno;

251

276

}

252

277

253

278

/* Prints out a password to stdout */

275

300

}

276

301

free(plugin_node->environ);

277

302

free(plugin_node->buffer);

278

303

279

304

/* Removes the plugin from the singly-linked list */

280

305

if(plugin_node == plugin_list){

281

306

/* First one - simple */

372

397

{ .name = NULL }

373

398

};

374

399

375

error_t parse_opt (int key, char *arg, __attribute__((unused))

376

struct argp_state *state) {

377

switch (key) {

400

error_t parse_opt(int key, char *arg, __attribute__((unused))

401

struct argp_state *state){

402

switch(key){

403

char *tmp;

404

intmax_t tmpmax;

378

405

case 'g': /* --global-options */

379

if (arg != NULL){

380

char *p;

381

while((p = strsep(&arg, ",")) != NULL){

382

if(p[0] == '\0'){

406

if(arg != NULL){

407

char *plugin_option;

408

while((plugin_option = strsep(&arg, ",")) != NULL){

409

if(plugin_option[0] == '\0'){

383

410

continue;

384

411

}

385

if(not add_argument(getplugin(NULL), p)){

412

if(not add_argument(getplugin(NULL), plugin_option)){

386

413

perror("add_argument");

387

414

return ARGP_ERR_UNKNOWN;

388

415

}

398

425

}

399

426

break;

400

427

case 'o': /* --options-for */

401

if (arg != NULL){

402

char *p_name = strsep(&arg, ":");

403

if(p_name[0] == '\0' or arg == NULL){

404

break;

405

}

406

char *opt = strsep(&arg, ":");

407

if(opt[0] == '\0' or opt == NULL){

408

break;

409

}

410

char *p;

411

while((p = strsep(&opt, ",")) != NULL){

412

if(p[0] == '\0'){

413

continue;

414

}

415

if(not add_argument(getplugin(p_name), p)){

428

if(arg != NULL){

429

char *plugin_name = strsep(&arg, ":");

430

if(plugin_name[0] == '\0'){

431

break;

432

}

433

char *plugin_option;

434

while((plugin_option = strsep(&arg, ",")) != NULL){

435

if(not add_argument(getplugin(plugin_name), plugin_option)){

416

436

perror("add_argument");

417

437

return ARGP_ERR_UNKNOWN;

418

438

}

435

455

}

436

456

break;

437

457

case 'd': /* --disable */

438

if (arg != NULL){

458

if(arg != NULL){

439

459

plugin *p = getplugin(arg);

440

460

if(p == NULL){

441

461

return ARGP_ERR_UNKNOWN;

444

464

}

445

465

break;

446

466

case 'e': /* --enable */

447

if (arg != NULL){

467

if(arg != NULL){

448

468

plugin *p = getplugin(arg);

449

469

if(p == NULL){

450

470

return ARGP_ERR_UNKNOWN;

457

477

plugindir = strdup(arg);

458

478

if(plugindir == NULL){

459

479

perror("strdup");

460

}

480

}

461

481

break;

462

482

case 129: /* --config-file */

463

483

/* This is already done by parse_opt_config_file() */

464

484

break;

465

485

case 130: /* --userid */

466

uid = (uid_t)strtol(arg, NULL, 10);

486

errno = 0;

487

tmpmax = strtoimax(arg, &tmp, 10);

488

if(errno != 0 or tmp == arg or *tmp != '\0'

489

or tmpmax != (uid_t)tmpmax){

490

fprintf(stderr, "Bad user ID number: \"%s\", using %"

491

PRIdMAX "\n", arg, (intmax_t)uid);

492

} else {

493

uid = (uid_t)tmpmax;

494

}

467

495

break;

468

496

case 131: /* --groupid */

469

gid = (gid_t)strtol(arg, NULL, 10);

497

errno = 0;

498

tmpmax = strtoimax(arg, &tmp, 10);

499

if(errno != 0 or tmp == arg or *tmp != '\0'

500

or tmpmax != (gid_t)tmpmax){

501

fprintf(stderr, "Bad group ID number: \"%s\", using %"

502

PRIdMAX "\n", arg, (intmax_t)gid);

503

} else {

504

gid = (gid_t)tmpmax;

505

}

470

506

break;

471

507

case 132: /* --debug */

472

508

debug = true;

473

509

break;

510

/*

511

* When adding more options before this line, remember to also add a

512

* "case" to the "parse_opt_config_file" function below.

513

*/

474

514

case ARGP_KEY_ARG:

475

515

/* Cryptsetup always passes an argument, which is an empty

476

516

string if "none" was specified in /etc/crypttab. So if

489

529

490

530

/* This option parser is the same as parse_opt() above, except it

491

531

ignores everything but the --config-file option. */

492

error_t parse_opt_config_file (int key, char *arg,

493

__attribute__((unused))

494

struct argp_state *state) {

495

switch (key) {

532

error_t parse_opt_config_file(int key, char *arg,

533

__attribute__((unused))

534

struct argp_state *state){

535

switch(key){

496

536

case 'g': /* --global-options */

497

537

case 'G': /* --global-env */

498

538

case 'o': /* --options-for */

507

547

if(argfile == NULL){

508

548

perror("strdup");

509

549

}

510

break;

550

break;

511

551

case 130: /* --userid */

512

552

case 131: /* --groupid */

513

553

case 132: /* --debug */

525

565

.args_doc = "",

526

566

.doc = "Mandos plugin runner -- Run plugins" };

527

567

528

/* Parse using the parse_opt_config_file in order to get the custom

568

/* Parse using parse_opt_config_file() in order to get the custom

529

569

config file location, if any. */

530

ret = argp_parse (&argp, argc, argv, ARGP_IN_ORDER, 0, NULL);

531

if (ret == ARGP_ERR_UNKNOWN){

570

ret = argp_parse(&argp, argc, argv, ARGP_IN_ORDER, 0, NULL);

571

if(ret == ARGP_ERR_UNKNOWN){

532

572

fprintf(stderr, "Unknown error while parsing arguments\n");

533

573

exitstatus = EXIT_FAILURE;

534

574

goto fallback;

538

578

argp.parser = parse_opt;

539

579

540

580

/* Open the configfile if available */

541

if (argfile == NULL){

581

if(argfile == NULL){

542

582

conffp = fopen(AFILE, "r");

543

583

} else {

544

584

conffp = fopen(argfile, "r");

545

}

585

}

546

586

if(conffp != NULL){

547

587

char *org_line = NULL;

548

588

char *p, *arg, *new_arg, *line;

549

589

size_t size = 0;

550

590

const char whitespace_delims[] = " \r\t\f\v\n";

551

591

const char comment_delim[] = "#";

552

592

553

593

custom_argc = 1;

554

594

custom_argv = malloc(sizeof(char*) * 2);

555

595

if(custom_argv == NULL){

559

599

}

560

600

custom_argv[0] = argv[0];

561

601

custom_argv[1] = NULL;

562

602

563

603

/* for each line in the config file, strip whitespace and ignore

564

604

commented text */

565

605

while(true){

567

607

if(sret == -1){

568

608

break;

569

609

}

570

610

571

611

line = org_line;

572

612

arg = strsep(&line, comment_delim);

573

613

while((p = strsep(&arg, whitespace_delims)) != NULL){

592

632

goto fallback;

593

633

}

594

634

custom_argv[custom_argc-1] = new_arg;

595

custom_argv[custom_argc] = NULL;

635

custom_argv[custom_argc] = NULL;

596

636

}

597

637

}

638

do {

639

ret = fclose(conffp);

640

} while(ret == EOF and errno == EINTR);

641

if(ret == EOF){

642

perror("fclose");

643

exitstatus = EXIT_FAILURE;

644

goto fallback;

645

}

598

646

free(org_line);

599

647

} else {

600

648

/* Check for harmful errors and go to fallback. Other errors might

601

649

not affect opening plugins */

602

if (errno == EMFILE or errno == ENFILE or errno == ENOMEM){

650

if(errno == EMFILE or errno == ENFILE or errno == ENOMEM){

603

651

perror("fopen");

604

652

exitstatus = EXIT_FAILURE;

605

653

goto fallback;

608

656

/* If there was any arguments from configuration file,

609

657

pass them to parser as command arguments */

610

658

if(custom_argv != NULL){

611

ret = argp_parse (&argp, custom_argc, custom_argv, ARGP_IN_ORDER,

612

0, NULL);

613

if (ret == ARGP_ERR_UNKNOWN){

659

ret = argp_parse(&argp, custom_argc, custom_argv, ARGP_IN_ORDER,

660

0, NULL);

661

if(ret == ARGP_ERR_UNKNOWN){

614

662

fprintf(stderr, "Unknown error while parsing arguments\n");

615

663

exitstatus = EXIT_FAILURE;

616

664

goto fallback;

619

667

620

668

/* Parse actual command line arguments, to let them override the

621

669

config file */

622

ret = argp_parse (&argp, argc, argv, ARGP_IN_ORDER, 0, NULL);

623

if (ret == ARGP_ERR_UNKNOWN){

670

ret = argp_parse(&argp, argc, argv, ARGP_IN_ORDER, 0, NULL);

671

if(ret == ARGP_ERR_UNKNOWN){

624

672

fprintf(stderr, "Unknown error while parsing arguments\n");

625

673

exitstatus = EXIT_FAILURE;

626

674

goto fallback;

633

681

for(char **a = p->argv; *a != NULL; a++){

634

682

fprintf(stderr, "\tArg: %s\n", *a);

635

683

}

636

fprintf(stderr, "...and %u environment variables\n", p->envc);

684

fprintf(stderr, "...and %d environment variables\n", p->envc);

637

685

for(char **a = p->environ; *a != NULL; a++){

638

686

fprintf(stderr, "\t%s\n", *a);

639

687

}

641

689

}

642

690

643

691

/* Strip permissions down to nobody */

692

setgid(gid);

693

if(ret == -1){

694

perror("setgid");

695

}

644

696

ret = setuid(uid);

645

if (ret == -1){

697

if(ret == -1){

646

698

perror("setuid");

647

}

648

setgid(gid);

649

if (ret == -1){

650

perror("setgid");

651

}

652

653

if (plugindir == NULL){

654

dir = opendir(PDIR);

655

} else {

656

dir = opendir(plugindir);

657

}

658

659

if(dir == NULL){

660

perror("Could not open plugin dir");

661

exitstatus = EXIT_FAILURE;

662

goto fallback;

663

}

664

665

/* Set the FD_CLOEXEC flag on the directory, if possible */

699

}

700

701

/* Open plugin directory with close_on_exec flag */

666

702

{

667

int dir_fd = dirfd(dir);

668

if(dir_fd >= 0){

669

ret = set_cloexec_flag(dir_fd);

670

if(ret < 0){

671

perror("set_cloexec_flag");

672

exitstatus = EXIT_FAILURE;

673

goto fallback;

674

}

703

int dir_fd = -1;

704

if(plugindir == NULL){

705

dir_fd = open(PDIR, O_RDONLY |

706

#ifdef O_CLOEXEC

707

O_CLOEXEC

708

#else /* not O_CLOEXEC */

709

0

710

#endif /* not O_CLOEXEC */

711

);

712

} else {

713

dir_fd = open(plugindir, O_RDONLY |

714

#ifdef O_CLOEXEC

715

O_CLOEXEC

716

#else /* not O_CLOEXEC */

717

0

718

#endif /* not O_CLOEXEC */

719

);

720

}

721

if(dir_fd == -1){

722

perror("Could not open plugin dir");

723

exitstatus = EXIT_FAILURE;

724

goto fallback;

725

}

726

727

#ifndef O_CLOEXEC

728

/* Set the FD_CLOEXEC flag on the directory */

729

ret = set_cloexec_flag(dir_fd);

730

if(ret < 0){

731

perror("set_cloexec_flag");

732

TEMP_FAILURE_RETRY(close(dir_fd));

733

exitstatus = EXIT_FAILURE;

734

goto fallback;

735

}

736

#endif /* O_CLOEXEC */

737

738

dir = fdopendir(dir_fd);

739

if(dir == NULL){

740

perror("Could not open plugin dir");

741

TEMP_FAILURE_RETRY(close(dir_fd));

742

exitstatus = EXIT_FAILURE;

743

goto fallback;

675

744

}

676

745

}

677

746

679

748

680

749

/* Read and execute any executable in the plugin directory*/

681

750

while(true){

682

dirst = readdir(dir);

751

do {

752

dirst = readdir(dir);

753

} while(dirst == NULL and errno == EINTR);

683

754

684

755

/* All directory entries have been processed */

685

756

if(dirst == NULL){

686

if (errno == EBADF){

757

if(errno == EBADF){

687

758

perror("readdir");

688

759

exitstatus = EXIT_FAILURE;

689

760

goto fallback;

736

807

continue;

737

808

}

738

809

}

739

810

740

811

char *filename;

741

812

if(plugindir == NULL){

742

ret = asprintf(&filename, PDIR "/%s", dirst->d_name);

813

ret = (int)TEMP_FAILURE_RETRY(asprintf(&filename, PDIR "/%s",

814

dirst->d_name));

743

815

} else {

744

ret = asprintf(&filename, "%s/%s", plugindir, dirst->d_name);

816

ret = (int)TEMP_FAILURE_RETRY(asprintf(&filename, "%s/%s",

817

plugindir,

818

dirst->d_name));

745

819

}

746

820

if(ret < 0){

747

821

perror("asprintf");

748

822

continue;

749

823

}

750

824

751

ret = stat(filename, &st);

752

if (ret == -1){

825

ret = (int)TEMP_FAILURE_RETRY(stat(filename, &st));

826

if(ret == -1){

753

827

perror("stat");

754

828

free(filename);

755

829

continue;

756

830

}

757

831

758

832

/* Ignore non-executable files */

759

if (not S_ISREG(st.st_mode) or (access(filename, X_OK) != 0)){

833

if(not S_ISREG(st.st_mode)

834

or (TEMP_FAILURE_RETRY(access(filename, X_OK)) != 0)){

760

835

if(debug){

761

836

fprintf(stderr, "Ignoring plugin dir entry \"%s\""

762

837

" with bad type or mode\n", filename);

808

883

}

809

884

810

885

int pipefd[2];

811

ret = pipe(pipefd);

812

if (ret == -1){

886

ret = (int)TEMP_FAILURE_RETRY(pipe(pipefd));

887

if(ret == -1){

813

888

perror("pipe");

814

889

exitstatus = EXIT_FAILURE;

815

890

goto fallback;

828

903

goto fallback;

829

904

}

830

905

/* Block SIGCHLD until process is safely in process list */

831

ret = sigprocmask (SIG_BLOCK, &sigchld_action.sa_mask, NULL);

906

ret = (int)TEMP_FAILURE_RETRY(sigprocmask(SIG_BLOCK,

907

&sigchld_action.sa_mask,

908

NULL));

832

909

if(ret < 0){

833

910

perror("sigprocmask");

834

911

exitstatus = EXIT_FAILURE;

835

912

goto fallback;

836

913

}

837

914

/* Starting a new process to be watched */

838

pid_t pid = fork();

915

pid_t pid;

916

do {

917

pid = fork();

918

} while(pid == -1 and errno == EINTR);

839

919

if(pid == -1){

840

920

perror("fork");

841

921

exitstatus = EXIT_FAILURE;

879

959

/* no return */

880

960

}

881

961

/* Parent process */

882

close(pipefd[1]); /* Close unused write end of pipe */

962

TEMP_FAILURE_RETRY(close(pipefd[1])); /* Close unused write end of

963

pipe */

883

964

free(filename);

884

965

plugin *new_plugin = getplugin(dirst->d_name);

885

if (new_plugin == NULL){

966

if(new_plugin == NULL){

886

967

perror("getplugin");

887

ret = sigprocmask (SIG_UNBLOCK, &sigchld_action.sa_mask, NULL);

968

ret = (int)(TEMP_FAILURE_RETRY

969

(sigprocmask(SIG_UNBLOCK, &sigchld_action.sa_mask,

970

NULL)));

888

971

if(ret < 0){

889

972

perror("sigprocmask");

890

973

}

897

980

898

981

/* Unblock SIGCHLD so signal handler can be run if this process

899

982

has already completed */

900

ret = sigprocmask (SIG_UNBLOCK, &sigchld_action.sa_mask, NULL);

983

ret = (int)TEMP_FAILURE_RETRY(sigprocmask(SIG_UNBLOCK,

984

&sigchld_action.sa_mask,

985

NULL));

901

986

if(ret < 0){

902

987

perror("sigprocmask");

903

988

exitstatus = EXIT_FAILURE;

904

989

goto fallback;

905

990

}

906

991

907

FD_SET(new_plugin->fd, &rfds_all);

992

FD_SET(new_plugin->fd, &rfds_all); /* Spurious warning from

993

-Wconversion */

908

994

909

if (maxfd < new_plugin->fd){

995

if(maxfd < new_plugin->fd){

910

996

maxfd = new_plugin->fd;

911

997

}

912

998

}

913

999

914

closedir(dir);

1000

TEMP_FAILURE_RETRY(closedir(dir));

915

1001

dir = NULL;

1002

free_plugin(getplugin(NULL));

916

1003

917

1004

for(plugin *p = plugin_list; p != NULL; p = p->next){

918

1005

if(p->pid != 0){

929

1016

while(plugin_list){

930

1017

fd_set rfds = rfds_all;

931

1018

int select_ret = select(maxfd+1, &rfds, NULL, NULL, NULL);

932

if (select_ret == -1){

1019

if(select_ret == -1 and errno != EINTR){

933

1020

perror("select");

934

1021

exitstatus = EXIT_FAILURE;

935

1022

goto fallback;

938

1025

from one of them */

939

1026

for(plugin *proc = plugin_list; proc != NULL;){

940

1027

/* Is this process completely done? */

941

if(proc->eof and proc->completed){

1028

if(proc->completed and proc->eof){

942

1029

/* Only accept the plugin output if it exited cleanly */

943

1030

if(not WIFEXITED(proc->status)

944

1031

or WEXITSTATUS(proc->status) != 0){

945

1032

/* Bad exit by plugin */

946

1033

947

1034

if(debug){

948

1035

if(WIFEXITED(proc->status)){

949

fprintf(stderr, "Plugin %u exited with status %d\n",

950

(unsigned int) (proc->pid),

1036

fprintf(stderr, "Plugin %s [%" PRIdMAX "] exited with"

1037

" status %d\n", proc->name,

1038

(intmax_t) (proc->pid),

951

1039

WEXITSTATUS(proc->status));

952

} else if(WIFSIGNALED(proc->status)) {

953

fprintf(stderr, "Plugin %u killed by signal %d\n",

954

(unsigned int) (proc->pid),

955

WTERMSIG(proc->status));

1040

} else if(WIFSIGNALED(proc->status)){

1041

fprintf(stderr, "Plugin %s [%" PRIdMAX "] killed by"

1042

" signal %d: %s\n", proc->name,

1043

(intmax_t) (proc->pid),

1044

WTERMSIG(proc->status),

1045

strsignal(WTERMSIG(proc->status)));

956

1046

} else if(WCOREDUMP(proc->status)){

957

fprintf(stderr, "Plugin %d dumped core\n",

958

(unsigned int) (proc->pid));

1047

fprintf(stderr, "Plugin %s [%" PRIdMAX "] dumped"

1048

" core\n", proc->name, (intmax_t) (proc->pid));

959

1049

}

960

1050

}

961

1051

962

1052

/* Remove the plugin */

963

FD_CLR(proc->fd, &rfds_all);

964

1053

FD_CLR(proc->fd, &rfds_all); /* Spurious warning from

1054

-Wconversion */

1055

965

1056

/* Block signal while modifying process_list */

966

ret = sigprocmask(SIG_BLOCK, &sigchld_action.sa_mask, NULL);

1057

ret = (int)TEMP_FAILURE_RETRY(sigprocmask

1058

(SIG_BLOCK,

1059

&sigchld_action.sa_mask,

1060

NULL));

967

1061

if(ret < 0){

968

1062

perror("sigprocmask");

969

1063

exitstatus = EXIT_FAILURE;

975

1069

proc = next_plugin;

976

1070

977

1071

/* We are done modifying process list, so unblock signal */

978

ret = sigprocmask (SIG_UNBLOCK, &sigchld_action.sa_mask,

979

NULL);

1072

ret = (int)(TEMP_FAILURE_RETRY

1073

(sigprocmask(SIG_UNBLOCK,

1074

&sigchld_action.sa_mask, NULL)));

980

1075

if(ret < 0){

981

1076

perror("sigprocmask");

982

1077

exitstatus = EXIT_FAILURE;

1002

1097

}

1003

1098

1004

1099

/* This process has not completed. Does it have any output? */

1005

if(proc->eof or not FD_ISSET(proc->fd, &rfds)){

1100

if(proc->eof or not FD_ISSET(proc->fd, &rfds)){ /* Spurious

1101

warning from

1102

-Wconversion */

1006

1103

/* This process had nothing to say at this time */

1007

1104

proc = proc->next;

1008

1105

continue;

1011

1108

if(proc->buffer_length + BUFFER_SIZE > proc->buffer_size){

1012

1109

proc->buffer = realloc(proc->buffer, proc->buffer_size

1013

1110

+ (size_t) BUFFER_SIZE);

1014

if (proc->buffer == NULL){

1111

if(proc->buffer == NULL){

1015

1112

perror("malloc");

1016

1113

exitstatus = EXIT_FAILURE;

1017

1114

goto fallback;

1019

1116

proc->buffer_size += BUFFER_SIZE;

1020

1117

}

1021

1118

/* Read from the process */

1022

sret = read(proc->fd, proc->buffer + proc->buffer_length,

1023

BUFFER_SIZE);

1119

sret = TEMP_FAILURE_RETRY(read(proc->fd,

1120

proc->buffer

1121

+ proc->buffer_length,

1122

BUFFER_SIZE));

1024

1123

if(sret < 0){

1025

1124

/* Read error from this process; ignore the error */

1026

1125

proc = proc->next;

1034

1133

}

1035

1134

}

1036

1135

}

1037

1038

1136

1137

1039

1138

fallback:

1040

1139

1041

1140

if(plugin_list == NULL or exitstatus != EXIT_SUCCESS){

1088

1187

}

1089

1188

1090

1189

/* Wait for any remaining child processes to terminate */

1091

do{

1190

do {

1092

1191

ret = wait(NULL);

1093

1192

} while(ret >= 0);

1094

1193

if(errno != ECHILD){