/mandos/trunk : revision 392

1

/* -*- coding: utf-8 -*- */

1

/* -*- coding: utf-8; mode: c; mode: orgtbl -*- */

2

/*

3

* Mandos plugin runner - Run Mandos plugins

4

*

5

6

7

*

7

8

* This program is free software: you can redistribute it and/or

8

9

* modify it under the terms of the GNU General Public License as

22

23

*/

23

24

25

#define _GNU_SOURCE /* TEMP_FAILURE_RETRY(), getline(),

25

asprintf() */

26

asprintf(), O_CLOEXEC */

26

27

#include <stddef.h> /* size_t, NULL */

27

28

#include <stdlib.h> /* malloc(), exit(), EXIT_FAILURE,

28

29

EXIT_SUCCESS, realloc() */

29

30

#include <stdbool.h> /* bool, true, false */

30

31

#include <stdio.h> /* perror, fileno(), fprintf(),

31

32

stderr, STDOUT_FILENO */

32

#include <sys/types.h> /* DIR, opendir(), stat(), struct

33

#include <sys/types.h> /* DIR, fdopendir(), stat(), struct

33

34

stat, waitpid(), WIFEXITED(),

34

35

WEXITSTATUS(), wait(), pid_t,

35

36

uid_t, gid_t, getuid(), getgid(),

37

38

#include <sys/select.h> /* fd_set, select(), FD_ZERO(),

38

39

FD_SET(), FD_ISSET(), FD_CLR */

39

40

#include <sys/wait.h> /* wait(), waitpid(), WIFEXITED(),

40

WEXITSTATUS() */

41

WEXITSTATUS(), WTERMSIG(),

42

WCOREDUMP() */

41

43

#include <sys/stat.h> /* struct stat, stat(), S_ISREG() */

42

44

#include <iso646.h> /* and, or, not */

43

#include <dirent.h> /* DIR, struct dirent, opendir(),

45

#include <dirent.h> /* DIR, struct dirent, fdopendir(),

44

46

readdir(), closedir(), dirfd() */

45

47

#include <unistd.h> /* struct stat, stat(), S_ISREG(),

46

48

fcntl(), setuid(), setgid(),

51

53

close() */

52

54

#include <fcntl.h> /* fcntl(), F_GETFD, F_SETFD,

53

55

FD_CLOEXEC */

54

#include <string.h> /* strsep, strlen(), asprintf() */

56

#include <string.h> /* strsep, strlen(), asprintf(),

57

strsignal() */

55

58

#include <errno.h> /* errno */

56

59

#include <argp.h> /* struct argp_option, struct

57

60

argp_state, struct argp,

61

64

#include <signal.h> /* struct sigaction, sigemptyset(),

62

65

sigaddset(), sigaction(),

63

66

sigprocmask(), SIG_BLOCK, SIGCHLD,

64

SIG_UNBLOCK, kill() */

67

SIG_UNBLOCK, kill(), sig_atomic_t

68

*/

65

69

#include <errno.h> /* errno, EBADF */

70

#include <inttypes.h> /* intmax_t, PRIdMAX, strtoimax() */

66

71

67

72

#define BUFFER_SIZE 256

68

73

79

84

char **environ;

80

85

int envc;

81

86

bool disabled;

82

87

83

88

/* Variables used for running processes*/

84

89

pid_t pid;

85

90

int fd;

87

92

size_t buffer_size;

88

93

size_t buffer_length;

89

94

bool eof;

90

volatile bool completed;

91

volatile int status;

95

volatile sig_atomic_t completed;

96

int status;

92

97

struct plugin *next;

93

98

} plugin;

94

99

98

103

or if none is found, creates a new one */

99

104

static plugin *getplugin(char *name){

100

105

/* Check for exiting plugin with that name */

101

for (plugin *p = plugin_list; p != NULL; p = p->next){

102

if ((p->name == name)

103

or (p->name and name and (strcmp(p->name, name) == 0))){

106

for(plugin *p = plugin_list; p != NULL; p = p->next){

107

if((p->name == name)

108

or (p->name and name and (strcmp(p->name, name) == 0))){

104

109

return p;

105

110

}

106

111

}

107

112

/* Create a new plugin */

108

plugin *new_plugin = malloc(sizeof(plugin));

109

if (new_plugin == NULL){

113

plugin *new_plugin = NULL;

114

do {

115

new_plugin = malloc(sizeof(plugin));

116

} while(new_plugin == NULL and errno == EINTR);

117

if(new_plugin == NULL){

110

118

return NULL;

111

119

}

112

120

char *copy_name = NULL;

113

121

if(name != NULL){

114

copy_name = strdup(name);

122

do {

123

copy_name = strdup(name);

124

} while(copy_name == NULL and errno == EINTR);

115

125

if(copy_name == NULL){

126

free(new_plugin);

116

127

return NULL;

117

128

}

118

129

}

119

130

120

*new_plugin = (plugin) { .name = copy_name,

121

.argc = 1,

122

.disabled = false,

123

.next = plugin_list };

131

*new_plugin = (plugin){ .name = copy_name,

132

.argc = 1,

133

.disabled = false,

134

.next = plugin_list };

124

135

125

new_plugin->argv = malloc(sizeof(char *) * 2);

126

if (new_plugin->argv == NULL){

136

do {

137

new_plugin->argv = malloc(sizeof(char *) * 2);

138

} while(new_plugin->argv == NULL and errno == EINTR);

139

if(new_plugin->argv == NULL){

127

140

free(copy_name);

128

141

free(new_plugin);

129

142

return NULL;

131

144

new_plugin->argv[0] = copy_name;

132

145

new_plugin->argv[1] = NULL;

133

146

134

new_plugin->environ = malloc(sizeof(char *));

147

do {

148

new_plugin->environ = malloc(sizeof(char *));

149

} while(new_plugin->environ == NULL and errno == EINTR);

135

150

if(new_plugin->environ == NULL){

136

151

free(copy_name);

137

152

free(new_plugin->argv);

149

164

static bool add_to_char_array(const char *new, char ***array,

150

165

int *len){

151

166

/* Resize the pointed-to array to hold one more pointer */

152

*array = realloc(*array, sizeof(char *)

153

* (size_t) ((*len) + 2));

167

do {

168

*array = realloc(*array, sizeof(char *)

169

* (size_t) ((*len) + 2));

170

} while(*array == NULL and errno == EINTR);

154

171

/* Malloc check */

155

172

if(*array == NULL){

156

173

return false;

157

174

}

158

175

/* Make a copy of the new string */

159

char *copy = strdup(new);

176

char *copy;

177

do {

178

copy = strdup(new);

179

} while(copy == NULL and errno == EINTR);

160

180

if(copy == NULL){

161

181

return false;

162

182

}

188

208

if(strncmp(*e, def, namelen + 1) == 0){

189

209

/* It already exists */

190

210

if(replace){

191

char *new = realloc(*e, strlen(def) + 1);

211

char *new;

212

do {

213

new = realloc(*e, strlen(def) + 1);

214

} while(new == NULL and errno == EINTR);

192

215

if(new == NULL){

193

216

return false;

194

217

}

204

227

/*

205

228

* Based on the example in the GNU LibC manual chapter 13.13 "File

206

229

* Descriptor Flags".

207

* *Note File Descriptor Flags:(libc)Descriptor Flags.

230

| [[info:libc:Descriptor%20Flags][File Descriptor Flags]] |

208

231

*/

209

232

static int set_cloexec_flag(int fd){

210

int ret = fcntl(fd, F_GETFD, 0);

233

int ret = (int)TEMP_FAILURE_RETRY(fcntl(fd, F_GETFD, 0));

211

234

/* If reading the flags failed, return error indication now. */

212

235

if(ret < 0){

213

236

return ret;

214

237

}

215

238

/* Store modified flag word in the descriptor. */

216

return fcntl(fd, F_SETFD, ret | FD_CLOEXEC);

239

return (int)TEMP_FAILURE_RETRY(fcntl(fd, F_SETFD,

240

ret | FD_CLOEXEC));

217

241

}

218

242

219

243

220

244

/* Mark processes as completed when they exit, and save their exit

221

245

status. */

222

246

static void handle_sigchld(__attribute__((unused)) int sig){

247

int old_errno = errno;

223

248

while(true){

224

249

plugin *proc = plugin_list;

225

250

int status;

229

254

break;

230

255

}

231

256

if(pid == -1){

232

if (errno != ECHILD){

233

perror("waitpid");

257

if(errno == ECHILD){

258

/* No child processes */

259

break;

234

260

}

235

/* No child processes */

236

break;

261

perror("waitpid");

237

262

}

238

263

239

264

/* A child exited, find it in process_list */

245

270

continue;

246

271

}

247

272

proc->status = status;

248

proc->completed = true;

273

proc->completed = 1;

249

274

}

275

errno = old_errno;

250

276

}

251

277

252

278

/* Prints out a password to stdout */

274

300

}

275

301

free(plugin_node->environ);

276

302

free(plugin_node->buffer);

277

303

278

304

/* Removes the plugin from the singly-linked list */

279

305

if(plugin_node == plugin_list){

280

306

/* First one - simple */

308

334

struct stat st;

309

335

fd_set rfds_all;

310

336

int ret, maxfd = 0;

337

ssize_t sret;

311

338

uid_t uid = 65534;

312

339

gid_t gid = 65534;

313

340

bool debug = false;

370

397

{ .name = NULL }

371

398

};

372

399

373

error_t parse_opt (int key, char *arg, __attribute__((unused))

374

struct argp_state *state) {

375

switch (key) {

400

error_t parse_opt(int key, char *arg, __attribute__((unused))

401

struct argp_state *state){

402

switch(key){

403

char *tmp;

404

intmax_t tmpmax;

376

405

case 'g': /* --global-options */

377

if (arg != NULL){

378

char *p;

379

while((p = strsep(&arg, ",")) != NULL){

380

if(p[0] == '\0'){

406

if(arg != NULL){

407

char *plugin_option;

408

while((plugin_option = strsep(&arg, ",")) != NULL){

409

if(plugin_option[0] == '\0'){

381

410

continue;

382

411

}

383

if(not add_argument(getplugin(NULL), p)){

412

if(not add_argument(getplugin(NULL), plugin_option)){

384

413

perror("add_argument");

385

414

return ARGP_ERR_UNKNOWN;

386

415

}

396

425

}

397

426

break;

398

427

case 'o': /* --options-for */

399

if (arg != NULL){

400

char *p_name = strsep(&arg, ":");

401

if(p_name[0] == '\0' or arg == NULL){

402

break;

403

}

404

char *opt = strsep(&arg, ":");

405

if(opt[0] == '\0' or opt == NULL){

406

break;

407

}

408

char *p;

409

while((p = strsep(&opt, ",")) != NULL){

410

if(p[0] == '\0'){

411

continue;

412

}

413

if(not add_argument(getplugin(p_name), p)){

428

if(arg != NULL){

429

char *plugin_name = strsep(&arg, ":");

430

if(plugin_name[0] == '\0'){

431

break;

432

}

433

char *plugin_option;

434

while((plugin_option = strsep(&arg, ",")) != NULL){

435

if(not add_argument(getplugin(plugin_name), plugin_option)){

414

436

perror("add_argument");

415

437

return ARGP_ERR_UNKNOWN;

416

438

}

433

455

}

434

456

break;

435

457

case 'd': /* --disable */

436

if (arg != NULL){

458

if(arg != NULL){

437

459

plugin *p = getplugin(arg);

438

460

if(p == NULL){

439

461

return ARGP_ERR_UNKNOWN;

442

464

}

443

465

break;

444

466

case 'e': /* --enable */

445

if (arg != NULL){

467

if(arg != NULL){

446

468

plugin *p = getplugin(arg);

447

469

if(p == NULL){

448

470

return ARGP_ERR_UNKNOWN;

455

477

plugindir = strdup(arg);

456

478

if(plugindir == NULL){

457

479

perror("strdup");

458

}

480

}

459

481

break;

460

482

case 129: /* --config-file */

461

483

/* This is already done by parse_opt_config_file() */

462

484

break;

463

485

case 130: /* --userid */

464

uid = (uid_t)strtol(arg, NULL, 10);

486

errno = 0;

487

tmpmax = strtoimax(arg, &tmp, 10);

488

if(errno != 0 or tmp == arg or *tmp != '\0'

489

or tmpmax != (uid_t)tmpmax){

490

fprintf(stderr, "Bad user ID number: \"%s\", using %"

491

PRIdMAX "\n", arg, (intmax_t)uid);

492

} else {

493

uid = (uid_t)tmpmax;

494

}

465

495

break;

466

496

case 131: /* --groupid */

467

gid = (gid_t)strtol(arg, NULL, 10);

497

errno = 0;

498

tmpmax = strtoimax(arg, &tmp, 10);

499

if(errno != 0 or tmp == arg or *tmp != '\0'

500

or tmpmax != (gid_t)tmpmax){

501

fprintf(stderr, "Bad group ID number: \"%s\", using %"

502

PRIdMAX "\n", arg, (intmax_t)gid);

503

} else {

504

gid = (gid_t)tmpmax;

505

}

468

506

break;

469

507

case 132: /* --debug */

470

508

debug = true;

471

509

break;

510

/*

511

* When adding more options before this line, remember to also add a

512

* "case" to the "parse_opt_config_file" function below.

513

*/

472

514

case ARGP_KEY_ARG:

473

515

/* Cryptsetup always passes an argument, which is an empty

474

516

string if "none" was specified in /etc/crypttab. So if

487

529

488

530

/* This option parser is the same as parse_opt() above, except it

489

531

ignores everything but the --config-file option. */

490

error_t parse_opt_config_file (int key, char *arg,

491

__attribute__((unused))

492

struct argp_state *state) {

493

switch (key) {

532

error_t parse_opt_config_file(int key, char *arg,

533

__attribute__((unused))

534

struct argp_state *state){

535

switch(key){

494

536

case 'g': /* --global-options */

495

537

case 'G': /* --global-env */

496

538

case 'o': /* --options-for */

505

547

if(argfile == NULL){

506

548

perror("strdup");

507

549

}

508

break;

550

break;

509

551

case 130: /* --userid */

510

552

case 131: /* --groupid */

511

553

case 132: /* --debug */

523

565

.args_doc = "",

524

566

.doc = "Mandos plugin runner -- Run plugins" };

525

567

526

/* Parse using the parse_opt_config_file in order to get the custom

568

/* Parse using parse_opt_config_file() in order to get the custom

527

569

config file location, if any. */

528

ret = argp_parse (&argp, argc, argv, ARGP_IN_ORDER, 0, NULL);

529

if (ret == ARGP_ERR_UNKNOWN){

570

ret = argp_parse(&argp, argc, argv, ARGP_IN_ORDER, 0, NULL);

571

if(ret == ARGP_ERR_UNKNOWN){

530

572

fprintf(stderr, "Unknown error while parsing arguments\n");

531

573

exitstatus = EXIT_FAILURE;

532

574

goto fallback;

536

578

argp.parser = parse_opt;

537

579

538

580

/* Open the configfile if available */

539

if (argfile == NULL){

581

if(argfile == NULL){

540

582

conffp = fopen(AFILE, "r");

541

583

} else {

542

584

conffp = fopen(argfile, "r");

543

}

585

}

544

586

if(conffp != NULL){

545

587

char *org_line = NULL;

546

588

char *p, *arg, *new_arg, *line;

547

589

size_t size = 0;

548

ssize_t sret;

549

590

const char whitespace_delims[] = " \r\t\f\v\n";

550

591

const char comment_delim[] = "#";

551

592

552

593

custom_argc = 1;

553

594

custom_argv = malloc(sizeof(char*) * 2);

554

595

if(custom_argv == NULL){

558

599

}

559

600

custom_argv[0] = argv[0];

560

601

custom_argv[1] = NULL;

561

602

562

603

/* for each line in the config file, strip whitespace and ignore

563

604

commented text */

564

605

while(true){

566

607

if(sret == -1){

567

608

break;

568

609

}

569

610

570

611

line = org_line;

571

612

arg = strsep(&line, comment_delim);

572

613

while((p = strsep(&arg, whitespace_delims)) != NULL){

591

632

goto fallback;

592

633

}

593

634

custom_argv[custom_argc-1] = new_arg;

594

custom_argv[custom_argc] = NULL;

635

custom_argv[custom_argc] = NULL;

595

636

}

596

637

}

638

do {

639

ret = fclose(conffp);

640

} while(ret == EOF and errno == EINTR);

641

if(ret == EOF){

642

perror("fclose");

643

exitstatus = EXIT_FAILURE;

644

goto fallback;

645

}

597

646

free(org_line);

598

647

} else {

599

648

/* Check for harmful errors and go to fallback. Other errors might

600

649

not affect opening plugins */

601

if (errno == EMFILE or errno == ENFILE or errno == ENOMEM){

650

if(errno == EMFILE or errno == ENFILE or errno == ENOMEM){

602

651

perror("fopen");

603

652

exitstatus = EXIT_FAILURE;

604

653

goto fallback;

607

656

/* If there was any arguments from configuration file,

608

657

pass them to parser as command arguments */

609

658

if(custom_argv != NULL){

610

ret = argp_parse (&argp, custom_argc, custom_argv, ARGP_IN_ORDER,

611

0, NULL);

612

if (ret == ARGP_ERR_UNKNOWN){

659

ret = argp_parse(&argp, custom_argc, custom_argv, ARGP_IN_ORDER,

660

0, NULL);

661

if(ret == ARGP_ERR_UNKNOWN){

613

662

fprintf(stderr, "Unknown error while parsing arguments\n");

614

663

exitstatus = EXIT_FAILURE;

615

664

goto fallback;

618

667

619

668

/* Parse actual command line arguments, to let them override the

620

669

config file */

621

ret = argp_parse (&argp, argc, argv, ARGP_IN_ORDER, 0, NULL);

622

if (ret == ARGP_ERR_UNKNOWN){

670

ret = argp_parse(&argp, argc, argv, ARGP_IN_ORDER, 0, NULL);

671

if(ret == ARGP_ERR_UNKNOWN){

623

672

fprintf(stderr, "Unknown error while parsing arguments\n");

624

673

exitstatus = EXIT_FAILURE;

625

674

goto fallback;

632

681

for(char **a = p->argv; *a != NULL; a++){

633

682

fprintf(stderr, "\tArg: %s\n", *a);

634

683

}

635

fprintf(stderr, "...and %u environment variables\n", p->envc);

684

fprintf(stderr, "...and %d environment variables\n", p->envc);

636

685

for(char **a = p->environ; *a != NULL; a++){

637

686

fprintf(stderr, "\t%s\n", *a);

638

687

}

640

689

}

641

690

642

691

/* Strip permissions down to nobody */

692

setgid(gid);

693

if(ret == -1){

694

perror("setgid");

695

}

643

696

ret = setuid(uid);

644

if (ret == -1){

697

if(ret == -1){

645

698

perror("setuid");

646

}

647

setgid(gid);

648

if (ret == -1){

649

perror("setgid");

650

}

651

652

if (plugindir == NULL){

653

dir = opendir(PDIR);

654

} else {

655

dir = opendir(plugindir);

656

}

657

658

if(dir == NULL){

659

perror("Could not open plugin dir");

660

exitstatus = EXIT_FAILURE;

661

goto fallback;

662

}

663

664

/* Set the FD_CLOEXEC flag on the directory, if possible */

699

}

700

701

/* Open plugin directory with close_on_exec flag */

665

702

{

666

int dir_fd = dirfd(dir);

667

if(dir_fd >= 0){

668

ret = set_cloexec_flag(dir_fd);

669

if(ret < 0){

670

perror("set_cloexec_flag");

671

exitstatus = EXIT_FAILURE;

672

goto fallback;

673

}

703

int dir_fd = -1;

704

if(plugindir == NULL){

705

dir_fd = open(PDIR, O_RDONLY |

706

#ifdef O_CLOEXEC

707

O_CLOEXEC

708

#else /* not O_CLOEXEC */

709

0

710

#endif /* not O_CLOEXEC */

711

);

712

} else {

713

dir_fd = open(plugindir, O_RDONLY |

714

#ifdef O_CLOEXEC

715

O_CLOEXEC

716

#else /* not O_CLOEXEC */

717

0

718

#endif /* not O_CLOEXEC */

719

);

720

}

721

if(dir_fd == -1){

722

perror("Could not open plugin dir");

723

exitstatus = EXIT_FAILURE;

724

goto fallback;

725

}

726

727

#ifndef O_CLOEXEC

728

/* Set the FD_CLOEXEC flag on the directory */

729

ret = set_cloexec_flag(dir_fd);

730

if(ret < 0){

731

perror("set_cloexec_flag");

732

TEMP_FAILURE_RETRY(close(dir_fd));

733

exitstatus = EXIT_FAILURE;

734

goto fallback;

735

}

736

#endif /* O_CLOEXEC */

737

738

dir = fdopendir(dir_fd);

739

if(dir == NULL){

740

perror("Could not open plugin dir");

741

TEMP_FAILURE_RETRY(close(dir_fd));

742

exitstatus = EXIT_FAILURE;

743

goto fallback;

674

744

}

675

745

}

676

746

678

748

679

749

/* Read and execute any executable in the plugin directory*/

680

750

while(true){

681

dirst = readdir(dir);

751

do {

752

dirst = readdir(dir);

753

} while(dirst == NULL and errno == EINTR);

682

754

683

755

/* All directory entries have been processed */

684

756

if(dirst == NULL){

685

if (errno == EBADF){

757

if(errno == EBADF){

686

758

perror("readdir");

687

759

exitstatus = EXIT_FAILURE;

688

760

goto fallback;

700

772

701

773

const char const *bad_suffixes[] = { "~", "#", ".dpkg-new",

702

774

".dpkg-old",

775

".dpkg-bak",

703

776

".dpkg-divert", NULL };

704

777

for(const char **pre = bad_prefixes; *pre != NULL; pre++){

705

778

size_t pre_len = strlen(*pre);

734

807

continue;

735

808

}

736

809

}

737

810

738

811

char *filename;

739

812

if(plugindir == NULL){

740

ret = asprintf(&filename, PDIR "/%s", dirst->d_name);

813

ret = (int)TEMP_FAILURE_RETRY(asprintf(&filename, PDIR "/%s",

814

dirst->d_name));

741

815

} else {

742

ret = asprintf(&filename, "%s/%s", plugindir, dirst->d_name);

816

ret = (int)TEMP_FAILURE_RETRY(asprintf(&filename, "%s/%s",

817

plugindir,

818

dirst->d_name));

743

819

}

744

820

if(ret < 0){

745

821

perror("asprintf");

746

822

continue;

747

823

}

748

824

749

ret = stat(filename, &st);

750

if (ret == -1){

825

ret = (int)TEMP_FAILURE_RETRY(stat(filename, &st));

826

if(ret == -1){

751

827

perror("stat");

752

828

free(filename);

753

829

continue;

754

830

}

755

831

756

832

/* Ignore non-executable files */

757

if (not S_ISREG(st.st_mode) or (access(filename, X_OK) != 0)){

833

if(not S_ISREG(st.st_mode)

834

or (TEMP_FAILURE_RETRY(access(filename, X_OK)) != 0)){

758

835

if(debug){

759

836

fprintf(stderr, "Ignoring plugin dir entry \"%s\""

760

837

" with bad type or mode\n", filename);

806

883

}

807

884

808

885

int pipefd[2];

809

ret = pipe(pipefd);

810

if (ret == -1){

886

ret = (int)TEMP_FAILURE_RETRY(pipe(pipefd));

887

if(ret == -1){

811

888

perror("pipe");

812

889

exitstatus = EXIT_FAILURE;

813

890

goto fallback;

826

903

goto fallback;

827

904

}

828

905

/* Block SIGCHLD until process is safely in process list */

829

ret = sigprocmask (SIG_BLOCK, &sigchld_action.sa_mask, NULL);

906

ret = (int)TEMP_FAILURE_RETRY(sigprocmask(SIG_BLOCK,

907

&sigchld_action.sa_mask,

908

NULL));

830

909

if(ret < 0){

831

910

perror("sigprocmask");

832

911

exitstatus = EXIT_FAILURE;

833

912

goto fallback;

834

913

}

835

914

/* Starting a new process to be watched */

836

pid_t pid = fork();

915

pid_t pid;

916

do {

917

pid = fork();

918

} while(pid == -1 and errno == EINTR);

837

919

if(pid == -1){

838

920

perror("fork");

839

921

exitstatus = EXIT_FAILURE;

877

959

/* no return */

878

960

}

879

961

/* Parent process */

880

close(pipefd[1]); /* Close unused write end of pipe */

962

TEMP_FAILURE_RETRY(close(pipefd[1])); /* Close unused write end of

963

pipe */

881

964

free(filename);

882

965

plugin *new_plugin = getplugin(dirst->d_name);

883

if (new_plugin == NULL){

966

if(new_plugin == NULL){

884

967

perror("getplugin");

885

ret = sigprocmask (SIG_UNBLOCK, &sigchld_action.sa_mask, NULL);

968

ret = (int)(TEMP_FAILURE_RETRY

969

(sigprocmask(SIG_UNBLOCK, &sigchld_action.sa_mask,

970

NULL)));

886

971

if(ret < 0){

887

972

perror("sigprocmask");

888

973

}

895

980

896

981

/* Unblock SIGCHLD so signal handler can be run if this process

897

982

has already completed */

898

ret = sigprocmask (SIG_UNBLOCK, &sigchld_action.sa_mask, NULL);

983

ret = (int)TEMP_FAILURE_RETRY(sigprocmask(SIG_UNBLOCK,

984

&sigchld_action.sa_mask,

985

NULL));

899

986

if(ret < 0){

900

987

perror("sigprocmask");

901

988

exitstatus = EXIT_FAILURE;

902

989

goto fallback;

903

990

}

904

991

905

FD_SET(new_plugin->fd, &rfds_all);

992

FD_SET(new_plugin->fd, &rfds_all); /* Spurious warning from

993

-Wconversion */

906

994

907

if (maxfd < new_plugin->fd){

995

if(maxfd < new_plugin->fd){

908

996

maxfd = new_plugin->fd;

909

997

}

910

998

}

911

999

912

closedir(dir);

1000

TEMP_FAILURE_RETRY(closedir(dir));

913

1001

dir = NULL;

1002

free_plugin(getplugin(NULL));

914

1003

915

1004

for(plugin *p = plugin_list; p != NULL; p = p->next){

916

1005

if(p->pid != 0){

927

1016

while(plugin_list){

928

1017

fd_set rfds = rfds_all;

929

1018

int select_ret = select(maxfd+1, &rfds, NULL, NULL, NULL);

930

if (select_ret == -1){

1019

if(select_ret == -1 and errno != EINTR){

931

1020

perror("select");

932

1021

exitstatus = EXIT_FAILURE;

933

1022

goto fallback;

936

1025

from one of them */

937

1026

for(plugin *proc = plugin_list; proc != NULL;){

938

1027

/* Is this process completely done? */

939

if(proc->eof and proc->completed){

1028

if(proc->completed and proc->eof){

940

1029

/* Only accept the plugin output if it exited cleanly */

941

1030

if(not WIFEXITED(proc->status)

942

1031

or WEXITSTATUS(proc->status) != 0){

943

1032

/* Bad exit by plugin */

944

1033

945

1034

if(debug){

946

1035

if(WIFEXITED(proc->status)){

947

fprintf(stderr, "Plugin %u exited with status %d\n",

948

(unsigned int) (proc->pid),

1036

fprintf(stderr, "Plugin %s [%" PRIdMAX "] exited with"

1037

" status %d\n", proc->name,

1038

(intmax_t) (proc->pid),

949

1039

WEXITSTATUS(proc->status));

950

} else if(WIFSIGNALED(proc->status)) {

951

fprintf(stderr, "Plugin %u killed by signal %d\n",

952

(unsigned int) (proc->pid),

953

WTERMSIG(proc->status));

1040

} else if(WIFSIGNALED(proc->status)){

1041

fprintf(stderr, "Plugin %s [%" PRIdMAX "] killed by"

1042

" signal %d: %s\n", proc->name,

1043

(intmax_t) (proc->pid),

1044

WTERMSIG(proc->status),

1045

strsignal(WTERMSIG(proc->status)));

954

1046

} else if(WCOREDUMP(proc->status)){

955

fprintf(stderr, "Plugin %d dumped core\n",

956

(unsigned int) (proc->pid));

1047

fprintf(stderr, "Plugin %s [%" PRIdMAX "] dumped"

1048

" core\n", proc->name, (intmax_t) (proc->pid));

957

1049

}

958

1050

}

959

1051

960

1052

/* Remove the plugin */

961

FD_CLR(proc->fd, &rfds_all);

962

1053

FD_CLR(proc->fd, &rfds_all); /* Spurious warning from

1054

-Wconversion */

1055

963

1056

/* Block signal while modifying process_list */

964

ret = sigprocmask(SIG_BLOCK, &sigchld_action.sa_mask, NULL);

1057

ret = (int)TEMP_FAILURE_RETRY(sigprocmask

1058

(SIG_BLOCK,

1059

&sigchld_action.sa_mask,

1060

NULL));

965

1061

if(ret < 0){

966

1062

perror("sigprocmask");

967

1063

exitstatus = EXIT_FAILURE;

973

1069

proc = next_plugin;

974

1070

975

1071

/* We are done modifying process list, so unblock signal */

976

ret = sigprocmask (SIG_UNBLOCK, &sigchld_action.sa_mask,

977

NULL);

1072

ret = (int)(TEMP_FAILURE_RETRY

1073

(sigprocmask(SIG_UNBLOCK,

1074

&sigchld_action.sa_mask, NULL)));

978

1075

if(ret < 0){

979

1076

perror("sigprocmask");

980

1077

exitstatus = EXIT_FAILURE;

1000

1097

}

1001

1098

1002

1099

/* This process has not completed. Does it have any output? */

1003

if(proc->eof or not FD_ISSET(proc->fd, &rfds)){

1100

if(proc->eof or not FD_ISSET(proc->fd, &rfds)){ /* Spurious

1101

warning from

1102

-Wconversion */

1004

1103

/* This process had nothing to say at this time */

1005

1104

proc = proc->next;

1006

1105

continue;

1009

1108

if(proc->buffer_length + BUFFER_SIZE > proc->buffer_size){

1010

1109

proc->buffer = realloc(proc->buffer, proc->buffer_size

1011

1110

+ (size_t) BUFFER_SIZE);

1012

if (proc->buffer == NULL){

1111

if(proc->buffer == NULL){

1013

1112

perror("malloc");

1014

1113

exitstatus = EXIT_FAILURE;

1015

1114

goto fallback;

1017

1116

proc->buffer_size += BUFFER_SIZE;

1018

1117

}

1019

1118

/* Read from the process */

1020

ret = read(proc->fd, proc->buffer + proc->buffer_length,

1021

BUFFER_SIZE);

1022

if(ret < 0){

1119

sret = TEMP_FAILURE_RETRY(read(proc->fd,

1120

proc->buffer

1121

+ proc->buffer_length,

1122

BUFFER_SIZE));

1123

if(sret < 0){

1023

1124

/* Read error from this process; ignore the error */

1024

1125

proc = proc->next;

1025

1126

continue;

1026

1127

}

1027

if(ret == 0){

1128

if(sret == 0){

1028

1129

/* got EOF */

1029

1130

proc->eof = true;

1030

1131

} else {

1031

proc->buffer_length += (size_t) ret;

1132

proc->buffer_length += (size_t) sret;

1032

1133

}

1033

1134

}

1034

1135

}

1035

1036

1136

1137

1037

1138

fallback:

1038

1139

1039

1140

if(plugin_list == NULL or exitstatus != EXIT_SUCCESS){

1086

1187

}

1087

1188

1088

1189

/* Wait for any remaining child processes to terminate */

1089

do{

1190

do {

1090

1191

ret = wait(NULL);

1091

1192

} while(ret >= 0);

1092

1193

if(errno != ECHILD){