3
3
* Mandos plugin runner - Run Mandos plugins
5
* Copyright © 2008-2018 Teddy Hogeborn
6
* Copyright © 2008-2018 Björn Påhlsson
8
* This file is part of Mandos.
10
* Mandos is free software: you can redistribute it and/or modify it
11
* under the terms of the GNU General Public License as published by
12
* the Free Software Foundation, either version 3 of the License, or
13
* (at your option) any later version.
15
* Mandos is distributed in the hope that it will be useful, but
5
* Copyright © 2008,2009 Teddy Hogeborn
6
* Copyright © 2008,2009 Björn Påhlsson
8
* This program is free software: you can redistribute it and/or
9
* modify it under the terms of the GNU General Public License as
10
* published by the Free Software Foundation, either version 3 of the
11
* License, or (at your option) any later version.
13
* This program is distributed in the hope that it will be useful, but
16
14
* WITHOUT ANY WARRANTY; without even the implied warranty of
17
15
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
18
16
* General Public License for more details.
20
18
* You should have received a copy of the GNU General Public License
21
* along with Mandos. If not, see <http://www.gnu.org/licenses/>.
19
* along with this program. If not, see
20
* <http://www.gnu.org/licenses/>.
23
* Contact the authors at <mandos@recompile.se>.
22
* Contact the authors at <mandos@fukt.bsnet.se>.
26
25
#define _GNU_SOURCE /* TEMP_FAILURE_RETRY(), getline(),
28
27
#include <stddef.h> /* size_t, NULL */
29
#include <stdlib.h> /* malloc(), exit(), EXIT_SUCCESS,
28
#include <stdlib.h> /* malloc(), exit(), EXIT_FAILURE,
29
EXIT_SUCCESS, realloc() */
31
30
#include <stdbool.h> /* bool, true, false */
32
#include <stdio.h> /* fileno(), fprintf(),
33
stderr, STDOUT_FILENO, fclose() */
34
#include <sys/types.h> /* fstat(), struct stat, waitpid(),
35
WIFEXITED(), WEXITSTATUS(), wait(),
36
pid_t, uid_t, gid_t, getuid(),
31
#include <stdio.h> /* perror, fileno(), fprintf(),
32
stderr, STDOUT_FILENO */
33
#include <sys/types.h> /* DIR, opendir(), stat(), struct
34
stat, waitpid(), WIFEXITED(),
35
WEXITSTATUS(), wait(), pid_t,
36
uid_t, gid_t, getuid(), getgid(),
38
38
#include <sys/select.h> /* fd_set, select(), FD_ZERO(),
39
39
FD_SET(), FD_ISSET(), FD_CLR */
40
40
#include <sys/wait.h> /* wait(), waitpid(), WIFEXITED(),
41
WEXITSTATUS(), WTERMSIG() */
42
#include <sys/stat.h> /* struct stat, fstat(), S_ISREG() */
41
WEXITSTATUS(), WTERMSIG(),
43
#include <sys/stat.h> /* struct stat, stat(), S_ISREG() */
43
44
#include <iso646.h> /* and, or, not */
44
#include <dirent.h> /* struct dirent, scandirat() */
45
#include <unistd.h> /* fcntl(), F_GETFD, F_SETFD,
46
FD_CLOEXEC, write(), STDOUT_FILENO,
47
struct stat, fstat(), close(),
48
setgid(), setuid(), S_ISREG(),
49
faccessat() pipe2(), fork(),
50
_exit(), dup2(), fexecve(), read()
45
#include <dirent.h> /* DIR, struct dirent, opendir(),
46
readdir(), closedir(), dirfd() */
47
#include <unistd.h> /* struct stat, stat(), S_ISREG(),
48
fcntl(), setuid(), setgid(),
49
F_GETFD, F_SETFD, FD_CLOEXEC,
50
access(), pipe(), fork(), close()
51
dup2(), STDOUT_FILENO, _exit(),
52
execv(), write(), read(),
52
54
#include <fcntl.h> /* fcntl(), F_GETFD, F_SETFD,
53
FD_CLOEXEC, openat(), scandirat(),
55
#include <string.h> /* strsep, strlen(), strsignal(),
56
strcmp(), strncmp() */
56
#include <string.h> /* strsep, strlen(), asprintf(),
57
58
#include <errno.h> /* errno */
58
59
#include <argp.h> /* struct argp_option, struct
59
60
argp_state, struct argp,
417
394
.doc = "Group ID the plugins will run as", .group = 3 },
418
395
{ .name = "debug", .key = 132,
419
396
.doc = "Debug mode", .group = 4 },
420
{ .name = "plugin-helper-dir", .key = 133,
422
.doc = "Specify a different plugin helper directory",
425
* These reproduce what we would get without ARGP_NO_HELP
427
{ .name = "help", .key = '?',
428
.doc = "Give this help list", .group = -1 },
429
{ .name = "usage", .key = -3,
430
.doc = "Give a short usage message", .group = -1 },
431
{ .name = "version", .key = 'V',
432
.doc = "Print program version", .group = -1 },
436
__attribute__((nonnull(3)))
437
error_t parse_opt(int key, char *arg, struct argp_state *state){
400
error_t parse_opt(int key, char *arg, __attribute__((unused))
401
struct argp_state *state){
442
405
case 'g': /* --global-options */
444
407
char *plugin_option;
445
408
while((plugin_option = strsep(&arg, ",")) != NULL){
409
if(plugin_option[0] == '\0'){
446
412
if(not add_argument(getplugin(NULL), plugin_option)){
413
perror("add_argument");
414
return ARGP_ERR_UNKNOWN;
453
419
case 'G': /* --global-env */
454
if(add_environment(getplugin(NULL), arg, true)){
423
if(not add_environment(getplugin(NULL), arg, true)){
424
perror("add_environment");
458
427
case 'o': /* --options-for */
460
char *option_list = strchr(arg, ':');
461
if(option_list == NULL){
462
argp_error(state, "No colon in \"%s\"", arg);
469
argp_error(state, "Empty plugin name");
474
while((option = strsep(&option_list, ",")) != NULL){
475
if(not add_argument(getplugin(arg), option)){
429
char *plugin_name = strsep(&arg, ":");
430
if(plugin_name[0] == '\0'){
434
while((plugin_option = strsep(&arg, ",")) != NULL){
435
if(not add_argument(getplugin(plugin_name), plugin_option)){
436
perror("add_argument");
437
return ARGP_ERR_UNKNOWN;
482
442
case 'E': /* --env-for */
484
447
char *envdef = strchr(arg, ':');
485
448
if(envdef == NULL){
486
argp_error(state, "No colon in \"%s\"", arg);
493
argp_error(state, "Empty plugin name");
497
if(add_environment(getplugin(arg), envdef, true)){
452
if(not add_environment(getplugin(arg), envdef+1, true)){
453
perror("add_environment");
502
457
case 'd': /* --disable */
504
459
plugin *p = getplugin(arg);
461
return ARGP_ERR_UNKNOWN;
511
466
case 'e': /* --enable */
513
468
plugin *p = getplugin(arg);
470
return ARGP_ERR_UNKNOWN;
520
475
case 128: /* --plugin-dir */
522
477
plugindir = strdup(arg);
523
if(plugindir != NULL){
478
if(plugindir == NULL){
527
482
case 129: /* --config-file */
528
483
/* This is already done by parse_opt_config_file() */
530
485
case 130: /* --userid */
531
tmp_id = strtoimax(arg, &tmp, 10);
487
tmpmax = strtoimax(arg, &tmp, 10);
532
488
if(errno != 0 or tmp == arg or *tmp != '\0'
533
or tmp_id != (uid_t)tmp_id){
534
argp_error(state, "Bad user ID number: \"%s\", using %"
535
PRIdMAX, arg, (intmax_t)uid);
489
or tmpmax != (uid_t)tmpmax){
490
fprintf(stderr, "Bad user ID number: \"%s\", using %"
491
PRIdMAX "\n", arg, (intmax_t)uid);
541
496
case 131: /* --groupid */
542
tmp_id = strtoimax(arg, &tmp, 10);
498
tmpmax = strtoimax(arg, &tmp, 10);
543
499
if(errno != 0 or tmp == arg or *tmp != '\0'
544
or tmp_id != (gid_t)tmp_id){
545
argp_error(state, "Bad group ID number: \"%s\", using %"
546
PRIdMAX, arg, (intmax_t)gid);
500
or tmpmax != (gid_t)tmpmax){
501
fprintf(stderr, "Bad group ID number: \"%s\", using %"
502
PRIdMAX "\n", arg, (intmax_t)gid);
552
507
case 132: /* --debug */
555
case 133: /* --plugin-helper-dir */
556
free(pluginhelperdir);
557
pluginhelperdir = strdup(arg);
558
if(pluginhelperdir != NULL){
563
* These reproduce what we would get without ARGP_NO_HELP
565
case '?': /* --help */
566
state->flags &= ~(unsigned int)ARGP_NO_EXIT; /* force exit */
567
argp_state_help(state, state->out_stream, ARGP_HELP_STD_HELP);
568
__builtin_unreachable();
569
case -3: /* --usage */
570
state->flags &= ~(unsigned int)ARGP_NO_EXIT; /* force exit */
571
argp_state_help(state, state->out_stream,
572
ARGP_HELP_USAGE | ARGP_HELP_EXIT_OK);
573
__builtin_unreachable();
574
case 'V': /* --version */
575
fprintf(state->out_stream, "%s\n", argp_program_version);
579
511
* When adding more options before this line, remember to also add a
580
512
* "case" to the "parse_opt_config_file" function below.
733
648
/* Check for harmful errors and go to fallback. Other errors might
734
649
not affect opening plugins */
735
650
if(errno == EMFILE or errno == ENFILE or errno == ENOMEM){
736
error(0, errno, "fopen");
737
exitstatus = EX_OSERR;
652
exitstatus = EXIT_FAILURE;
741
/* If there were any arguments from the configuration file, pass
742
them to parser as command line arguments */
656
/* If there was any arguments from configuration file,
657
pass them to parser as command arguments */
743
658
if(custom_argv != NULL){
744
ret = argp_parse(&argp, custom_argc, custom_argv,
745
ARGP_IN_ORDER | ARGP_NO_EXIT | ARGP_NO_HELP,
753
error(0, errno, "argp_parse");
754
exitstatus = EX_OSERR;
757
exitstatus = EX_CONFIG;
659
ret = argp_parse(&argp, custom_argc, custom_argv, ARGP_IN_ORDER,
661
if(ret == ARGP_ERR_UNKNOWN){
662
fprintf(stderr, "Unknown error while parsing arguments\n");
663
exitstatus = EXIT_FAILURE;
762
668
/* Parse actual command line arguments, to let them override the
764
ret = argp_parse(&argp, argc, argv,
765
ARGP_IN_ORDER | ARGP_NO_EXIT | ARGP_NO_HELP,
773
error(0, errno, "argp_parse");
774
exitstatus = EX_OSERR;
777
exitstatus = EX_USAGE;
782
char *pluginhelperenv;
784
ret = asprintf(&pluginhelperenv, "MANDOSPLUGINHELPERDIR=%s",
785
pluginhelperdir != NULL ? pluginhelperdir : PHDIR);
787
bret = add_environment(getplugin(NULL), pluginhelperenv, true);
789
if(ret == -1 or not bret){
790
error(0, errno, "Failed to set MANDOSPLUGINHELPERDIR"
791
" environment variable to \"%s\" for all plugins\n",
792
pluginhelperdir != NULL ? pluginhelperdir : PHDIR);
795
free(pluginhelperenv);
670
ret = argp_parse(&argp, argc, argv, ARGP_IN_ORDER, 0, NULL);
671
if(ret == ARGP_ERR_UNKNOWN){
672
fprintf(stderr, "Unknown error while parsing arguments\n");
673
exitstatus = EXIT_FAILURE;
800
for(plugin *p = plugin_list; p != NULL; p = p->next){
678
for(plugin *p = plugin_list; p != NULL; p=p->next){
801
679
fprintf(stderr, "Plugin: %s has %d arguments\n",
802
680
p->name ? p->name : "Global", p->argc - 1);
803
681
for(char **a = p->argv; *a != NULL; a++){
814
/* Work around Debian bug #633582:
815
<https://bugs.debian.org/633582> */
816
int plugindir_fd = open(/* plugindir or */ PDIR, O_RDONLY);
817
if(plugindir_fd == -1){
819
error(0, errno, "open(\"" PDIR "\")");
822
ret = (int)TEMP_FAILURE_RETRY(fstat(plugindir_fd, &st));
824
error(0, errno, "fstat");
826
if(S_ISDIR(st.st_mode) and st.st_uid == 0 and st.st_gid == 0){
827
ret = fchown(plugindir_fd, uid, gid);
829
error(0, errno, "fchown");
837
/* Lower permissions */
691
/* Strip permissions down to nobody */
840
error(0, errno, "setgid");
842
696
ret = setuid(uid);
844
error(0, errno, "setuid");
847
/* Open plugin directory with close_on_exec flag */
701
if(plugindir == NULL){
704
dir = opendir(plugindir);
708
perror("Could not open plugin dir");
709
exitstatus = EXIT_FAILURE;
713
/* Set the FD_CLOEXEC flag on the directory, if possible */
849
dir_fd = open(plugindir != NULL ? plugindir : PDIR, O_RDONLY |
852
#else /* not O_CLOEXEC */
854
#endif /* not O_CLOEXEC */
857
error(0, errno, "Could not open plugin dir");
858
exitstatus = EX_UNAVAILABLE;
863
/* Set the FD_CLOEXEC flag on the directory */
864
ret = set_cloexec_flag(dir_fd);
866
error(0, errno, "set_cloexec_flag");
867
exitstatus = EX_OSERR;
870
#endif /* O_CLOEXEC */
873
int good_name(const struct dirent * const dirent){
874
const char * const patterns[] = { ".*", "#*#", "*~", "*.dpkg-new",
875
"*.dpkg-old", "*.dpkg-bak",
876
"*.dpkg-divert", NULL };
878
#pragma GCC diagnostic push
879
#pragma GCC diagnostic ignored "-Wcast-qual"
881
for(const char **pat = (const char **)patterns;
882
*pat != NULL; pat++){
884
#pragma GCC diagnostic pop
886
if(fnmatch(*pat, dirent->d_name, FNM_FILE_NAME | FNM_PERIOD)
889
fprintf(stderr, "Ignoring plugin dir entry \"%s\""
890
" matching pattern %s\n", dirent->d_name, *pat);
715
int dir_fd = dirfd(dir);
717
ret = set_cloexec_flag(dir_fd);
719
perror("set_cloexec_flag");
720
exitstatus = EXIT_FAILURE;
898
int numplugins = scandirat(dir_fd, ".", &direntries, good_name,
900
if(numplugins == -1){
901
error(0, errno, "Could not scan plugin dir");
903
exitstatus = EX_OSERR;
907
726
FD_ZERO(&rfds_all);
909
728
/* Read and execute any executable in the plugin directory*/
910
for(int i = 0; i < numplugins; i++){
912
int plugin_fd = openat(dir_fd, direntries[i]->d_name, O_RDONLY);
914
error(0, errno, "Could not open plugin");
731
dirst = readdir(dir);
732
} while(dirst == NULL and errno == EINTR);
734
/* All directory entries have been processed */
738
exitstatus = EXIT_FAILURE;
744
d_name_len = strlen(dirst->d_name);
746
/* Ignore dotfiles, backup files and other junk */
748
bool bad_name = false;
750
const char const *bad_prefixes[] = { ".", "#", NULL };
752
const char const *bad_suffixes[] = { "~", "#", ".dpkg-new",
755
".dpkg-divert", NULL };
756
for(const char **pre = bad_prefixes; *pre != NULL; pre++){
757
size_t pre_len = strlen(*pre);
758
if((d_name_len >= pre_len)
759
and strncmp((dirst->d_name), *pre, pre_len) == 0){
761
fprintf(stderr, "Ignoring plugin dir entry \"%s\""
762
" with bad prefix %s\n", dirst->d_name, *pre);
771
for(const char **suf = bad_suffixes; *suf != NULL; suf++){
772
size_t suf_len = strlen(*suf);
773
if((d_name_len >= suf_len)
774
and (strcmp((dirst->d_name)+d_name_len-suf_len, *suf)
777
fprintf(stderr, "Ignoring plugin dir entry \"%s\""
778
" with bad suffix %s\n", dirst->d_name, *suf);
791
if(plugindir == NULL){
792
ret = (int)TEMP_FAILURE_RETRY(asprintf(&filename, PDIR "/%s",
795
ret = (int)TEMP_FAILURE_RETRY(asprintf(&filename, "%s/%s",
918
ret = (int)TEMP_FAILURE_RETRY(fstat(plugin_fd, &st));
804
ret = (int)TEMP_FAILURE_RETRY(stat(filename, &st));
920
error(0, errno, "stat");
926
811
/* Ignore non-executable files */
927
812
if(not S_ISREG(st.st_mode)
928
or (TEMP_FAILURE_RETRY(faccessat(dir_fd, direntries[i]->d_name,
813
or (TEMP_FAILURE_RETRY(access(filename, X_OK)) != 0)){
931
fprintf(stderr, "Ignoring plugin dir entry \"%s/%s\""
932
" with bad type or mode\n",
933
plugindir != NULL ? plugindir : PDIR,
934
direntries[i]->d_name);
815
fprintf(stderr, "Ignoring plugin dir entry \"%s\""
816
" with bad type or mode\n", filename);
941
plugin *p = getplugin(direntries[i]->d_name);
822
plugin *p = getplugin(dirst->d_name);
943
error(0, errno, "getplugin");
950
830
fprintf(stderr, "Ignoring disabled plugin \"%s\"\n",
951
direntries[i]->d_name);
961
840
for(char **a = g->argv + 1; *a != NULL; a++){
962
841
if(not add_argument(p, *a)){
963
error(0, errno, "add_argument");
842
perror("add_argument");
966
845
/* Add global environment variables */
967
846
for(char **e = g->environ; *e != NULL; e++){
968
847
if(not add_environment(p, *e, false)){
969
error(0, errno, "add_environment");
848
perror("add_environment");
974
/* If this plugin has any environment variables, we need to
975
duplicate the environment from this process, too. */
853
/* If this plugin has any environment variables, we will call
854
using execve and need to duplicate the environment from this
976
856
if(p->environ[0] != NULL){
977
857
for(char **e = environ; *e != NULL; e++){
978
858
if(not add_environment(p, *e, false)){
979
error(0, errno, "add_environment");
859
perror("add_environment");
986
865
ret = (int)TEMP_FAILURE_RETRY(pipe(pipefd));
987
#else /* O_CLOEXEC */
988
ret = (int)TEMP_FAILURE_RETRY(pipe2(pipefd, O_CLOEXEC));
989
#endif /* O_CLOEXEC */
991
error(0, errno, "pipe");
992
exitstatus = EX_OSERR;
996
if(pipefd[0] >= FD_SETSIZE){
997
fprintf(stderr, "pipe()[0] (%d) >= FD_SETSIZE (%d)", pipefd[0],
1001
exitstatus = EX_OSERR;
1002
free(direntries[i]);
868
exitstatus = EXIT_FAILURE;
1006
871
/* Ask OS to automatic close the pipe on exec */
1007
872
ret = set_cloexec_flag(pipefd[0]);
1009
error(0, errno, "set_cloexec_flag");
1012
exitstatus = EX_OSERR;
1013
free(direntries[i]);
874
perror("set_cloexec_flag");
875
exitstatus = EXIT_FAILURE;
1016
878
ret = set_cloexec_flag(pipefd[1]);
1018
error(0, errno, "set_cloexec_flag");
1021
exitstatus = EX_OSERR;
1022
free(direntries[i]);
880
perror("set_cloexec_flag");
881
exitstatus = EXIT_FAILURE;
1025
#endif /* not O_CLOEXEC */
1026
884
/* Block SIGCHLD until process is safely in process list */
1027
885
ret = (int)TEMP_FAILURE_RETRY(sigprocmask(SIG_BLOCK,
1028
886
&sigchld_action.sa_mask,
1031
error(0, errno, "sigprocmask");
1032
exitstatus = EX_OSERR;
1033
free(direntries[i]);
889
perror("sigprocmask");
890
exitstatus = EXIT_FAILURE;
1036
893
/* Starting a new process to be watched */
1040
897
} while(pid == -1 and errno == EINTR);
1042
error(0, errno, "fork");
1043
TEMP_FAILURE_RETRY(sigprocmask(SIG_UNBLOCK,
1044
&sigchld_action.sa_mask, NULL));
1047
exitstatus = EX_OSERR;
1048
free(direntries[i]);
900
exitstatus = EXIT_FAILURE;
1052
904
/* this is the child process */
1053
905
ret = sigaction(SIGCHLD, &old_sigchld_action, NULL);
1055
error(0, errno, "sigaction");
1058
910
ret = sigprocmask(SIG_UNBLOCK, &sigchld_action.sa_mask, NULL);
1060
error(0, errno, "sigprocmask");
912
perror("sigprocmask");
1064
916
ret = dup2(pipefd[1], STDOUT_FILENO); /* replace our stdout */
1066
error(0, errno, "dup2");
1070
if(fexecve(plugin_fd, p->argv,
1071
(p->environ[0] != NULL) ? p->environ : environ) < 0){
1072
error(0, errno, "fexecve for %s/%s",
1073
plugindir != NULL ? plugindir : PDIR,
1074
direntries[i]->d_name);
923
/* If dir has no file descriptor, we could not set FD_CLOEXEC
924
above and must now close it manually here. */
927
if(p->environ[0] == NULL){
928
if(execv(filename, p->argv) < 0){
933
if(execve(filename, p->argv, p->environ) < 0){
1079
940
/* Parent process */
1080
close(pipefd[1]); /* Close unused write end of pipe */
1082
plugin *new_plugin = getplugin(direntries[i]->d_name);
941
TEMP_FAILURE_RETRY(close(pipefd[1])); /* Close unused write end of
944
plugin *new_plugin = getplugin(dirst->d_name);
1083
945
if(new_plugin == NULL){
1084
error(0, errno, "getplugin");
1085
947
ret = (int)(TEMP_FAILURE_RETRY
1086
948
(sigprocmask(SIG_UNBLOCK, &sigchld_action.sa_mask,
1089
error(0, errno, "sigprocmask");
951
perror("sigprocmask");
1091
exitstatus = EX_OSERR;
1092
free(direntries[i]);
953
exitstatus = EXIT_FAILURE;
1095
free(direntries[i]);
1097
957
new_plugin->pid = pid;
1098
958
new_plugin->fd = pipefd[0];
1101
fprintf(stderr, "Plugin %s started (PID %" PRIdMAX ")\n",
1102
new_plugin->name, (intmax_t) (new_plugin->pid));
1105
960
/* Unblock SIGCHLD so signal handler can be run if this process
1106
961
has already completed */
1107
962
ret = (int)TEMP_FAILURE_RETRY(sigprocmask(SIG_UNBLOCK,
1108
963
&sigchld_action.sa_mask,
1111
error(0, errno, "sigprocmask");
1112
exitstatus = EX_OSERR;
966
perror("sigprocmask");
967
exitstatus = EXIT_FAILURE;
1116
FD_SET(new_plugin->fd, &rfds_all);
971
FD_SET(new_plugin->fd, &rfds_all); /* Spurious warning from
1118
974
if(maxfd < new_plugin->fd){
1119
975
maxfd = new_plugin->fd;
979
TEMP_FAILURE_RETRY(closedir(dir));
1127
981
free_plugin(getplugin(NULL));
1129
983
for(plugin *p = plugin_list; p != NULL; p = p->next){
1211
1069
bool bret = print_out_password(proc->buffer,
1212
1070
proc->buffer_length);
1214
error(0, errno, "print_out_password");
1215
exitstatus = EX_IOERR;
1072
perror("print_out_password");
1073
exitstatus = EXIT_FAILURE;
1220
1078
/* This process has not completed. Does it have any output? */
1221
if(proc->eof or not FD_ISSET(proc->fd, &rfds)){
1079
if(proc->eof or not FD_ISSET(proc->fd, &rfds)){ /* Spurious
1222
1082
/* This process had nothing to say at this time */
1223
1083
proc = proc->next;
1226
1086
/* Before reading, make the process' data buffer large enough */
1227
1087
if(proc->buffer_length + BUFFER_SIZE > proc->buffer_size){
1228
char *new_buffer = realloc(proc->buffer, proc->buffer_size
1229
+ (size_t) BUFFER_SIZE);
1230
if(new_buffer == NULL){
1231
error(0, errno, "malloc");
1232
exitstatus = EX_OSERR;
1088
proc->buffer = realloc(proc->buffer, proc->buffer_size
1089
+ (size_t) BUFFER_SIZE);
1090
if(proc->buffer == NULL){
1092
exitstatus = EXIT_FAILURE;
1235
proc->buffer = new_buffer;
1236
1095
proc->buffer_size += BUFFER_SIZE;
1238
1097
/* Read from the process */