19
19
* along with this program. If not, see
20
20
* <http://www.gnu.org/licenses/>.
22
* Contact the authors at <mandos@recompile.se>.
22
* Contact the authors at <mandos@fukt.bsnet.se>.
25
25
#define _GNU_SOURCE /* TEMP_FAILURE_RETRY(), getline(),
27
27
#include <stddef.h> /* size_t, NULL */
28
#include <stdlib.h> /* malloc(), exit(), EXIT_SUCCESS,
28
#include <stdlib.h> /* malloc(), exit(), EXIT_FAILURE,
29
EXIT_SUCCESS, realloc() */
30
30
#include <stdbool.h> /* bool, true, false */
31
#include <stdio.h> /* fileno(), fprintf(),
32
stderr, STDOUT_FILENO, fclose() */
33
#include <sys/types.h> /* fstat(), struct stat, waitpid(),
34
WIFEXITED(), WEXITSTATUS(), wait(),
35
pid_t, uid_t, gid_t, getuid(),
31
#include <stdio.h> /* perror, fileno(), fprintf(),
32
stderr, STDOUT_FILENO */
33
#include <sys/types.h> /* DIR, opendir(), stat(), struct
34
stat, waitpid(), WIFEXITED(),
35
WEXITSTATUS(), wait(), pid_t,
36
uid_t, gid_t, getuid(), getgid(),
37
38
#include <sys/select.h> /* fd_set, select(), FD_ZERO(),
38
39
FD_SET(), FD_ISSET(), FD_CLR */
39
40
#include <sys/wait.h> /* wait(), waitpid(), WIFEXITED(),
40
41
WEXITSTATUS(), WTERMSIG(),
42
#include <sys/stat.h> /* struct stat, fstat(), S_ISREG() */
43
#include <sys/stat.h> /* struct stat, stat(), S_ISREG() */
43
44
#include <iso646.h> /* and, or, not */
44
#include <dirent.h> /* struct dirent, scandirat() */
45
#include <unistd.h> /* fcntl(), F_GETFD, F_SETFD,
46
FD_CLOEXEC, write(), STDOUT_FILENO,
47
struct stat, fstat(), close(),
48
setgid(), setuid(), S_ISREG(),
49
faccessat() pipe2(), fork(),
50
_exit(), dup2(), fexecve(), read()
45
#include <dirent.h> /* DIR, struct dirent, opendir(),
46
readdir(), closedir(), dirfd() */
47
#include <unistd.h> /* struct stat, stat(), S_ISREG(),
48
fcntl(), setuid(), setgid(),
49
F_GETFD, F_SETFD, FD_CLOEXEC,
50
access(), pipe(), fork(), close()
51
dup2(), STDOUT_FILENO, _exit(),
52
execv(), write(), read(),
52
54
#include <fcntl.h> /* fcntl(), F_GETFD, F_SETFD,
53
FD_CLOEXEC, openat(), scandirat(),
55
#include <string.h> /* strsep, strlen(), strsignal(),
56
strcmp(), strncmp() */
56
#include <string.h> /* strsep, strlen(), asprintf(),
57
58
#include <errno.h> /* errno */
58
59
#include <argp.h> /* struct argp_option, struct
59
60
argp_state, struct argp,
414
377
.doc = "Group ID the plugins will run as", .group = 3 },
415
378
{ .name = "debug", .key = 132,
416
379
.doc = "Debug mode", .group = 4 },
418
* These reproduce what we would get without ARGP_NO_HELP
420
{ .name = "help", .key = '?',
421
.doc = "Give this help list", .group = -1 },
422
{ .name = "usage", .key = -3,
423
.doc = "Give a short usage message", .group = -1 },
424
{ .name = "version", .key = 'V',
425
.doc = "Print program version", .group = -1 },
429
__attribute__((nonnull(3)))
430
error_t parse_opt(int key, char *arg, struct argp_state *state){
383
error_t parse_opt(int key, char *arg, __attribute__((unused))
384
struct argp_state *state){
435
387
case 'g': /* --global-options */
437
389
char *plugin_option;
438
390
while((plugin_option = strsep(&arg, ",")) != NULL){
391
if(plugin_option[0] == '\0'){
439
394
if(not add_argument(getplugin(NULL), plugin_option)){
395
perror("add_argument");
396
return ARGP_ERR_UNKNOWN;
446
401
case 'G': /* --global-env */
447
if(add_environment(getplugin(NULL), arg, true)){
405
if(not add_environment(getplugin(NULL), arg, true)){
406
perror("add_environment");
451
409
case 'o': /* --options-for */
453
char *option_list = strchr(arg, ':');
454
if(option_list == NULL){
455
argp_error(state, "No colon in \"%s\"", arg);
462
argp_error(state, "Empty plugin name");
467
while((option = strsep(&option_list, ",")) != NULL){
468
if(not add_argument(getplugin(arg), option)){
411
char *plugin_name = strsep(&arg, ":");
412
if(plugin_name[0] == '\0'){
416
while((plugin_option = strsep(&arg, ",")) != NULL){
417
if(not add_argument(getplugin(plugin_name), plugin_option)){
418
perror("add_argument");
419
return ARGP_ERR_UNKNOWN;
475
424
case 'E': /* --env-for */
477
429
char *envdef = strchr(arg, ':');
478
430
if(envdef == NULL){
479
argp_error(state, "No colon in \"%s\"", arg);
486
argp_error(state, "Empty plugin name");
490
if(add_environment(getplugin(arg), envdef, true)){
434
if(not add_environment(getplugin(arg), envdef+1, true)){
435
perror("add_environment");
495
439
case 'd': /* --disable */
497
441
plugin *p = getplugin(arg);
443
return ARGP_ERR_UNKNOWN;
504
448
case 'e': /* --enable */
506
450
plugin *p = getplugin(arg);
452
return ARGP_ERR_UNKNOWN;
513
457
case 128: /* --plugin-dir */
515
459
plugindir = strdup(arg);
516
if(plugindir != NULL){
460
if(plugindir == NULL){
520
464
case 129: /* --config-file */
521
465
/* This is already done by parse_opt_config_file() */
523
467
case 130: /* --userid */
524
tmp_id = strtoimax(arg, &tmp, 10);
469
tmpmax = strtoimax(arg, &tmp, 10);
525
470
if(errno != 0 or tmp == arg or *tmp != '\0'
526
or tmp_id != (uid_t)tmp_id){
527
argp_error(state, "Bad user ID number: \"%s\", using %"
528
PRIdMAX, arg, (intmax_t)uid);
471
or tmpmax != (uid_t)tmpmax){
472
fprintf(stderr, "Bad user ID number: \"%s\", using %"
473
PRIdMAX "\n", arg, (intmax_t)uid);
534
478
case 131: /* --groupid */
535
tmp_id = strtoimax(arg, &tmp, 10);
480
tmpmax = strtoimax(arg, &tmp, 10);
536
481
if(errno != 0 or tmp == arg or *tmp != '\0'
537
or tmp_id != (gid_t)tmp_id){
538
argp_error(state, "Bad group ID number: \"%s\", using %"
539
PRIdMAX, arg, (intmax_t)gid);
482
or tmpmax != (gid_t)tmpmax){
483
fprintf(stderr, "Bad group ID number: \"%s\", using %"
484
PRIdMAX "\n", arg, (intmax_t)gid);
545
489
case 132: /* --debug */
549
* These reproduce what we would get without ARGP_NO_HELP
551
case '?': /* --help */
552
state->flags &= ~(unsigned int)ARGP_NO_EXIT; /* force exit */
553
argp_state_help(state, state->out_stream, ARGP_HELP_STD_HELP);
554
case -3: /* --usage */
555
state->flags &= ~(unsigned int)ARGP_NO_EXIT; /* force exit */
556
argp_state_help(state, state->out_stream,
557
ARGP_HELP_USAGE | ARGP_HELP_EXIT_OK);
558
case 'V': /* --version */
559
fprintf(state->out_stream, "%s\n", argp_program_version);
563
493
* When adding more options before this line, remember to also add a
564
494
* "case" to the "parse_opt_config_file" function below.
716
630
/* Check for harmful errors and go to fallback. Other errors might
717
631
not affect opening plugins */
718
632
if(errno == EMFILE or errno == ENFILE or errno == ENOMEM){
719
error(0, errno, "fopen");
720
exitstatus = EX_OSERR;
634
exitstatus = EXIT_FAILURE;
724
/* If there were any arguments from the configuration file, pass
725
them to parser as command line arguments */
638
/* If there was any arguments from configuration file,
639
pass them to parser as command arguments */
726
640
if(custom_argv != NULL){
727
ret = argp_parse(&argp, custom_argc, custom_argv,
728
ARGP_IN_ORDER | ARGP_NO_EXIT | ARGP_NO_HELP,
736
error(0, errno, "argp_parse");
737
exitstatus = EX_OSERR;
740
exitstatus = EX_CONFIG;
641
ret = argp_parse(&argp, custom_argc, custom_argv, ARGP_IN_ORDER,
643
if(ret == ARGP_ERR_UNKNOWN){
644
fprintf(stderr, "Unknown error while parsing arguments\n");
645
exitstatus = EXIT_FAILURE;
745
650
/* Parse actual command line arguments, to let them override the
747
ret = argp_parse(&argp, argc, argv,
748
ARGP_IN_ORDER | ARGP_NO_EXIT | ARGP_NO_HELP,
756
error(0, errno, "argp_parse");
757
exitstatus = EX_OSERR;
760
exitstatus = EX_USAGE;
652
ret = argp_parse(&argp, argc, argv, ARGP_IN_ORDER, 0, NULL);
653
if(ret == ARGP_ERR_UNKNOWN){
654
fprintf(stderr, "Unknown error while parsing arguments\n");
655
exitstatus = EXIT_FAILURE;
779
/* Work around Debian bug #633582:
780
<http://bugs.debian.org/633582> */
781
int plugindir_fd = open(/* plugindir or */ PDIR, O_RDONLY);
782
if(plugindir_fd == -1){
784
error(0, errno, "open(\"" PDIR "\")");
787
ret = (int)TEMP_FAILURE_RETRY(fstat(plugindir_fd, &st));
789
error(0, errno, "fstat");
791
if(S_ISDIR(st.st_mode) and st.st_uid == 0 and st.st_gid == 0){
792
ret = fchown(plugindir_fd, uid, gid);
794
error(0, errno, "fchown");
798
TEMP_FAILURE_RETRY(close(plugindir_fd));
802
/* Lower permissions */
673
/* Strip permissions down to nobody */
805
error(0, errno, "setgid");
807
678
ret = setuid(uid);
809
error(0, errno, "setuid");
812
/* Open plugin directory with close_on_exec flag */
683
if(plugindir == NULL){
686
dir = opendir(plugindir);
690
perror("Could not open plugin dir");
691
exitstatus = EXIT_FAILURE;
695
/* Set the FD_CLOEXEC flag on the directory, if possible */
814
dir_fd = open(plugindir != NULL ? plugindir : PDIR, O_RDONLY |
817
#else /* not O_CLOEXEC */
819
#endif /* not O_CLOEXEC */
822
error(0, errno, "Could not open plugin dir");
823
exitstatus = EX_UNAVAILABLE;
828
/* Set the FD_CLOEXEC flag on the directory */
829
ret = set_cloexec_flag(dir_fd);
831
error(0, errno, "set_cloexec_flag");
832
exitstatus = EX_OSERR;
835
#endif /* O_CLOEXEC */
838
int good_name(const struct dirent * const dirent){
839
const char * const patterns[] = { ".*", "#*#", "*~", "*.dpkg-new",
840
"*.dpkg-old", "*.dpkg-bak",
841
"*.dpkg-divert", NULL };
843
#pragma GCC diagnostic push
844
#pragma GCC diagnostic ignored "-Wcast-qual"
846
for(const char **pat = (const char **)patterns;
847
*pat != NULL; pat++){
849
#pragma GCC diagnostic pop
851
if(fnmatch(*pat, dirent->d_name, FNM_FILE_NAME | FNM_PERIOD)
854
fprintf(stderr, "Ignoring plugin dir entry \"%s\""
855
" matching pattern %s\n", dirent->d_name, *pat);
697
int dir_fd = dirfd(dir);
699
ret = set_cloexec_flag(dir_fd);
701
perror("set_cloexec_flag");
702
exitstatus = EXIT_FAILURE;
864
#if __GLIBC_PREREQ(2, 15)
865
int numplugins = scandirat(dir_fd, ".", &direntries, good_name,
867
#else /* not __GLIBC_PREREQ(2, 15) */
868
int numplugins = scandir(plugindir != NULL ? plugindir : PDIR,
869
&direntries, good_name, alphasort);
870
#endif /* not __GLIBC_PREREQ(2, 15) */
871
#else /* not __GLIBC__ */
872
int numplugins = scandir(plugindir != NULL ? plugindir : PDIR,
873
&direntries, good_name, alphasort);
874
#endif /* not __GLIBC__ */
875
if(numplugins == -1){
876
error(0, errno, "Could not scan plugin dir");
878
exitstatus = EX_OSERR;
882
708
FD_ZERO(&rfds_all);
884
710
/* Read and execute any executable in the plugin directory*/
885
for(int i = 0; i < numplugins; i++){
887
int plugin_fd = openat(dir_fd, direntries[i]->d_name, O_RDONLY);
889
error(0, errno, "Could not open plugin");
712
dirst = readdir(dir);
714
/* All directory entries have been processed */
718
exitstatus = EXIT_FAILURE;
724
d_name_len = strlen(dirst->d_name);
726
/* Ignore dotfiles, backup files and other junk */
728
bool bad_name = false;
730
const char const *bad_prefixes[] = { ".", "#", NULL };
732
const char const *bad_suffixes[] = { "~", "#", ".dpkg-new",
735
".dpkg-divert", NULL };
736
for(const char **pre = bad_prefixes; *pre != NULL; pre++){
737
size_t pre_len = strlen(*pre);
738
if((d_name_len >= pre_len)
739
and strncmp((dirst->d_name), *pre, pre_len) == 0){
741
fprintf(stderr, "Ignoring plugin dir entry \"%s\""
742
" with bad prefix %s\n", dirst->d_name, *pre);
751
for(const char **suf = bad_suffixes; *suf != NULL; suf++){
752
size_t suf_len = strlen(*suf);
753
if((d_name_len >= suf_len)
754
and (strcmp((dirst->d_name)+d_name_len-suf_len, *suf)
757
fprintf(stderr, "Ignoring plugin dir entry \"%s\""
758
" with bad suffix %s\n", dirst->d_name, *suf);
771
if(plugindir == NULL){
772
ret = asprintf(&filename, PDIR "/%s", dirst->d_name);
774
ret = asprintf(&filename, "%s/%s", plugindir, dirst->d_name);
893
ret = (int)TEMP_FAILURE_RETRY(fstat(plugin_fd, &st));
781
ret = stat(filename, &st);
895
error(0, errno, "stat");
896
TEMP_FAILURE_RETRY(close(plugin_fd));
901
788
/* Ignore non-executable files */
902
if(not S_ISREG(st.st_mode)
903
or (TEMP_FAILURE_RETRY(faccessat(dir_fd, direntries[i]->d_name,
789
if(not S_ISREG(st.st_mode) or (access(filename, X_OK) != 0)){
906
fprintf(stderr, "Ignoring plugin dir entry \"%s/%s\""
907
" with bad type or mode\n",
908
plugindir != NULL ? plugindir : PDIR,
909
direntries[i]->d_name);
791
fprintf(stderr, "Ignoring plugin dir entry \"%s\""
792
" with bad type or mode\n", filename);
911
TEMP_FAILURE_RETRY(close(plugin_fd));
916
plugin *p = getplugin(direntries[i]->d_name);
798
plugin *p = getplugin(dirst->d_name);
918
error(0, errno, "getplugin");
919
TEMP_FAILURE_RETRY(close(plugin_fd));
925
806
fprintf(stderr, "Ignoring disabled plugin \"%s\"\n",
926
direntries[i]->d_name);
928
TEMP_FAILURE_RETRY(close(plugin_fd));
936
816
for(char **a = g->argv + 1; *a != NULL; a++){
937
817
if(not add_argument(p, *a)){
938
error(0, errno, "add_argument");
818
perror("add_argument");
941
821
/* Add global environment variables */
942
822
for(char **e = g->environ; *e != NULL; e++){
943
823
if(not add_environment(p, *e, false)){
944
error(0, errno, "add_environment");
824
perror("add_environment");
949
/* If this plugin has any environment variables, we need to
950
duplicate the environment from this process, too. */
829
/* If this plugin has any environment variables, we will call
830
using execve and need to duplicate the environment from this
951
832
if(p->environ[0] != NULL){
952
833
for(char **e = environ; *e != NULL; e++){
953
834
if(not add_environment(p, *e, false)){
954
error(0, errno, "add_environment");
835
perror("add_environment");
961
ret = (int)TEMP_FAILURE_RETRY(pipe(pipefd));
962
#else /* O_CLOEXEC */
963
ret = (int)TEMP_FAILURE_RETRY(pipe2(pipefd, O_CLOEXEC));
964
#endif /* O_CLOEXEC */
966
error(0, errno, "pipe");
967
exitstatus = EX_OSERR;
971
if(pipefd[0] >= FD_SETSIZE){
972
fprintf(stderr, "pipe()[0] (%d) >= FD_SETSIZE (%d)", pipefd[0],
974
TEMP_FAILURE_RETRY(close(pipefd[0]));
975
TEMP_FAILURE_RETRY(close(pipefd[1]));
976
exitstatus = EX_OSERR;
844
exitstatus = EXIT_FAILURE;
981
847
/* Ask OS to automatic close the pipe on exec */
982
848
ret = set_cloexec_flag(pipefd[0]);
984
error(0, errno, "set_cloexec_flag");
985
TEMP_FAILURE_RETRY(close(pipefd[0]));
986
TEMP_FAILURE_RETRY(close(pipefd[1]));
987
exitstatus = EX_OSERR;
850
perror("set_cloexec_flag");
851
exitstatus = EXIT_FAILURE;
991
854
ret = set_cloexec_flag(pipefd[1]);
993
error(0, errno, "set_cloexec_flag");
994
TEMP_FAILURE_RETRY(close(pipefd[0]));
995
TEMP_FAILURE_RETRY(close(pipefd[1]));
996
exitstatus = EX_OSERR;
856
perror("set_cloexec_flag");
857
exitstatus = EXIT_FAILURE;
1000
#endif /* not O_CLOEXEC */
1001
860
/* Block SIGCHLD until process is safely in process list */
1002
ret = (int)TEMP_FAILURE_RETRY(sigprocmask(SIG_BLOCK,
1003
&sigchld_action.sa_mask,
861
ret = sigprocmask(SIG_BLOCK, &sigchld_action.sa_mask, NULL);
1006
error(0, errno, "sigprocmask");
1007
exitstatus = EX_OSERR;
1008
free(direntries[i]);
863
perror("sigprocmask");
864
exitstatus = EXIT_FAILURE;
1011
867
/* Starting a new process to be watched */
1015
} while(pid == -1 and errno == EINTR);
1017
error(0, errno, "fork");
1018
TEMP_FAILURE_RETRY(sigprocmask(SIG_UNBLOCK,
1019
&sigchld_action.sa_mask, NULL));
1020
TEMP_FAILURE_RETRY(close(pipefd[0]));
1021
TEMP_FAILURE_RETRY(close(pipefd[1]));
1022
exitstatus = EX_OSERR;
1023
free(direntries[i]);
871
exitstatus = EXIT_FAILURE;
1027
875
/* this is the child process */
1028
876
ret = sigaction(SIGCHLD, &old_sigchld_action, NULL);
1030
error(0, errno, "sigaction");
1033
881
ret = sigprocmask(SIG_UNBLOCK, &sigchld_action.sa_mask, NULL);
1035
error(0, errno, "sigprocmask");
883
perror("sigprocmask");
1039
887
ret = dup2(pipefd[1], STDOUT_FILENO); /* replace our stdout */
1041
error(0, errno, "dup2");
1045
if(fexecve(plugin_fd, p->argv,
1046
(p->environ[0] != NULL) ? p->environ : environ) < 0){
1047
error(0, errno, "fexecve for %s/%s",
1048
plugindir != NULL ? plugindir : PDIR,
1049
direntries[i]->d_name);
894
/* If dir has no file descriptor, we could not set FD_CLOEXEC
895
above and must now close it manually here. */
898
if(p->environ[0] == NULL){
899
if(execv(filename, p->argv) < 0){
904
if(execve(filename, p->argv, p->environ) < 0){
1054
911
/* Parent process */
1055
TEMP_FAILURE_RETRY(close(pipefd[1])); /* Close unused write end of
1057
TEMP_FAILURE_RETRY(close(plugin_fd));
1058
plugin *new_plugin = getplugin(direntries[i]->d_name);
912
close(pipefd[1]); /* Close unused write end of pipe */
914
plugin *new_plugin = getplugin(dirst->d_name);
1059
915
if(new_plugin == NULL){
1060
error(0, errno, "getplugin");
1061
ret = (int)(TEMP_FAILURE_RETRY
1062
(sigprocmask(SIG_UNBLOCK, &sigchld_action.sa_mask,
917
ret = sigprocmask(SIG_UNBLOCK, &sigchld_action.sa_mask, NULL);
1065
error(0, errno, "sigprocmask");
919
perror("sigprocmask");
1067
exitstatus = EX_OSERR;
1068
free(direntries[i]);
921
exitstatus = EXIT_FAILURE;
1071
free(direntries[i]);
1073
925
new_plugin->pid = pid;
1074
926
new_plugin->fd = pipefd[0];
1076
928
/* Unblock SIGCHLD so signal handler can be run if this process
1077
929
has already completed */
1078
ret = (int)TEMP_FAILURE_RETRY(sigprocmask(SIG_UNBLOCK,
1079
&sigchld_action.sa_mask,
930
ret = sigprocmask(SIG_UNBLOCK, &sigchld_action.sa_mask, NULL);
1082
error(0, errno, "sigprocmask");
1083
exitstatus = EX_OSERR;
932
perror("sigprocmask");
933
exitstatus = EXIT_FAILURE;
1087
#if defined (__GNUC__) and defined (__GLIBC__)
1088
#if not __GLIBC_PREREQ(2, 16)
1089
#pragma GCC diagnostic push
1090
#pragma GCC diagnostic ignored "-Wsign-conversion"
1093
FD_SET(new_plugin->fd, &rfds_all); /* Spurious warning from
1094
-Wconversion in GNU libc
1096
#if defined (__GNUC__) and defined (__GLIBC__)
1097
#if not __GLIBC_PREREQ(2, 16)
1098
#pragma GCC diagnostic pop
937
FD_SET(new_plugin->fd, &rfds_all);
1102
939
if(maxfd < new_plugin->fd){
1103
940
maxfd = new_plugin->fd;
1109
TEMP_FAILURE_RETRY(close(dir_fd));
1111
946
free_plugin(getplugin(NULL));
1113
948
for(plugin *p = plugin_list; p != NULL; p = p->next){
1211
1029
bool bret = print_out_password(proc->buffer,
1212
1030
proc->buffer_length);
1214
error(0, errno, "print_out_password");
1215
exitstatus = EX_IOERR;
1032
perror("print_out_password");
1033
exitstatus = EXIT_FAILURE;
1220
1038
/* This process has not completed. Does it have any output? */
1221
#if defined (__GNUC__) and defined (__GLIBC__)
1222
#if not __GLIBC_PREREQ(2, 16)
1223
#pragma GCC diagnostic push
1224
#pragma GCC diagnostic ignored "-Wsign-conversion"
1227
if(proc->eof or not FD_ISSET(proc->fd, &rfds)){ /* Spurious
1233
#if defined (__GNUC__) and defined (__GLIBC__)
1234
#if not __GLIBC_PREREQ(2, 16)
1235
#pragma GCC diagnostic pop
1039
if(proc->eof or not FD_ISSET(proc->fd, &rfds)){
1238
1040
/* This process had nothing to say at this time */
1239
1041
proc = proc->next;
1242
1044
/* Before reading, make the process' data buffer large enough */
1243
1045
if(proc->buffer_length + BUFFER_SIZE > proc->buffer_size){
1244
char *new_buffer = realloc(proc->buffer, proc->buffer_size
1245
+ (size_t) BUFFER_SIZE);
1246
if(new_buffer == NULL){
1247
error(0, errno, "malloc");
1248
exitstatus = EX_OSERR;
1046
proc->buffer = realloc(proc->buffer, proc->buffer_size
1047
+ (size_t) BUFFER_SIZE);
1048
if(proc->buffer == NULL){
1050
exitstatus = EXIT_FAILURE;
1251
proc->buffer = new_buffer;
1252
1053
proc->buffer_size += BUFFER_SIZE;
1254
1055
/* Read from the process */
1255
sret = TEMP_FAILURE_RETRY(read(proc->fd,
1257
+ proc->buffer_length,
1056
sret = read(proc->fd, proc->buffer + proc->buffer_length,
1260
1059
/* Read error from this process; ignore the error */
1261
1060
proc = proc->next;