/mandos/trunk : revision 276

1

/* -*- coding: utf-8; mode: c; mode: orgtbl -*- */

1

/* -*- coding: utf-8 -*- */

2

/*

3

* Mandos plugin runner - Run Mandos plugins

4

*

23

*/

24

25

#define _GNU_SOURCE /* TEMP_FAILURE_RETRY(), getline(),

26

asprintf(), O_CLOEXEC */

26

asprintf() */

27

#include <stddef.h> /* size_t, NULL */

28

#include <stdlib.h> /* malloc(), exit(), EXIT_FAILURE,

29

EXIT_SUCCESS, realloc() */

30

#include <stdbool.h> /* bool, true, false */

31

#include <stdio.h> /* perror, fileno(), fprintf(),

32

stderr, STDOUT_FILENO */

33

#include <sys/types.h> /* DIR, fdopendir(), stat(), struct

33

#include <sys/types.h> /* DIR, opendir(), stat(), struct

34

stat, waitpid(), WIFEXITED(),

35

WEXITSTATUS(), wait(), pid_t,

36

uid_t, gid_t, getuid(), getgid(),

38

#include <sys/select.h> /* fd_set, select(), FD_ZERO(),

39

FD_SET(), FD_ISSET(), FD_CLR */

40

#include <sys/wait.h> /* wait(), waitpid(), WIFEXITED(),

41

WEXITSTATUS(), WTERMSIG(),

42

WCOREDUMP() */

41

WEXITSTATUS() */

43

42

#include <sys/stat.h> /* struct stat, stat(), S_ISREG() */

44

43

#include <iso646.h> /* and, or, not */

45

#include <dirent.h> /* DIR, struct dirent, fdopendir(),

44

#include <dirent.h> /* DIR, struct dirent, opendir(),

46

45

readdir(), closedir(), dirfd() */

47

46

#include <unistd.h> /* struct stat, stat(), S_ISREG(),

48

47

fcntl(), setuid(), setgid(),

53

52

close() */

54

53

#include <fcntl.h> /* fcntl(), F_GETFD, F_SETFD,

55

54

FD_CLOEXEC */

56

#include <string.h> /* strsep, strlen(), asprintf(),

57

strsignal() */

55

#include <string.h> /* strsep, strlen(), asprintf() */

58

56

#include <errno.h> /* errno */

59

57

#include <argp.h> /* struct argp_option, struct

60

58

argp_state, struct argp,

64

62

#include <signal.h> /* struct sigaction, sigemptyset(),

65

63

sigaddset(), sigaction(),

66

64

sigprocmask(), SIG_BLOCK, SIGCHLD,

67

SIG_UNBLOCK, kill(), sig_atomic_t

68

*/

65

SIG_UNBLOCK, kill() */

69

66

#include <errno.h> /* errno, EBADF */

70

#include <inttypes.h> /* intmax_t, PRIdMAX, strtoimax() */

67

#include <inttypes.h> /* intmax_t, SCNdMAX, PRIdMAX, */

71

68

72

69

#define BUFFER_SIZE 256

73

70

84

81

char **environ;

85

82

int envc;

86

83

bool disabled;

87

84

88

85

/* Variables used for running processes*/

89

86

pid_t pid;

90

87

int fd;

92

89

size_t buffer_size;

93

90

size_t buffer_length;

94

91

bool eof;

95

volatile sig_atomic_t completed;

96

int status;

92

volatile bool completed;

93

volatile int status;

97

94

struct plugin *next;

98

95

} plugin;

99

96

110

107

}

111

108

}

112

109

/* Create a new plugin */

113

plugin *new_plugin = NULL;

114

do {

115

new_plugin = malloc(sizeof(plugin));

116

} while(new_plugin == NULL and errno == EINTR);

110

plugin *new_plugin = malloc(sizeof(plugin));

117

111

if(new_plugin == NULL){

118

112

return NULL;

119

113

}

120

114

char *copy_name = NULL;

121

115

if(name != NULL){

122

do {

123

copy_name = strdup(name);

124

} while(copy_name == NULL and errno == EINTR);

116

copy_name = strdup(name);

125

117

if(copy_name == NULL){

126

118

free(new_plugin);

127

119

return NULL;

128

120

}

129

121

}

130

122

131

*new_plugin = (plugin){ .name = copy_name,

132

.argc = 1,

133

.disabled = false,

134

.next = plugin_list };

123

*new_plugin = (plugin) { .name = copy_name,

124

.argc = 1,

125

.disabled = false,

126

.next = plugin_list };

135

127

136

do {

137

new_plugin->argv = malloc(sizeof(char *) * 2);

138

} while(new_plugin->argv == NULL and errno == EINTR);

128

new_plugin->argv = malloc(sizeof(char *) * 2);

139

129

if(new_plugin->argv == NULL){

140

130

free(copy_name);

141

131

free(new_plugin);

144

134

new_plugin->argv[0] = copy_name;

145

135

new_plugin->argv[1] = NULL;

146

136

147

do {

148

new_plugin->environ = malloc(sizeof(char *));

149

} while(new_plugin->environ == NULL and errno == EINTR);

137

new_plugin->environ = malloc(sizeof(char *));

150

138

if(new_plugin->environ == NULL){

151

139

free(copy_name);

152

140

free(new_plugin->argv);

164

152

static bool add_to_char_array(const char *new, char ***array,

165

153

int *len){

166

154

/* Resize the pointed-to array to hold one more pointer */

167

do {

168

*array = realloc(*array, sizeof(char *)

169

* (size_t) ((*len) + 2));

170

} while(*array == NULL and errno == EINTR);

155

*array = realloc(*array, sizeof(char *)

156

* (size_t) ((*len) + 2));

171

157

/* Malloc check */

172

158

if(*array == NULL){

173

159

return false;

174

160

}

175

161

/* Make a copy of the new string */

176

char *copy;

177

do {

178

copy = strdup(new);

179

} while(copy == NULL and errno == EINTR);

162

char *copy = strdup(new);

180

163

if(copy == NULL){

181

164

return false;

182

165

}

208

191

if(strncmp(*e, def, namelen + 1) == 0){

209

192

/* It already exists */

210

193

if(replace){

211

char *new;

212

do {

213

new = realloc(*e, strlen(def) + 1);

214

} while(new == NULL and errno == EINTR);

194

char *new = realloc(*e, strlen(def) + 1);

215

195

if(new == NULL){

216

196

return false;

217

197

}

227

207

/*

228

208

* Based on the example in the GNU LibC manual chapter 13.13 "File

229

209

* Descriptor Flags".

230

| [[info:libc:Descriptor%20Flags][File Descriptor Flags]] |

210

* *Note File Descriptor Flags:(libc)Descriptor Flags.

231

211

*/

232

212

static int set_cloexec_flag(int fd){

233

int ret = (int)TEMP_FAILURE_RETRY(fcntl(fd, F_GETFD, 0));

213

int ret = fcntl(fd, F_GETFD, 0);

234

214

/* If reading the flags failed, return error indication now. */

235

215

if(ret < 0){

236

216

return ret;

237

217

}

238

218

/* Store modified flag word in the descriptor. */

239

return (int)TEMP_FAILURE_RETRY(fcntl(fd, F_SETFD,

240

ret | FD_CLOEXEC));

219

return fcntl(fd, F_SETFD, ret | FD_CLOEXEC);

241

220

}

242

221

243

222

244

223

/* Mark processes as completed when they exit, and save their exit

245

224

status. */

246

225

static void handle_sigchld(__attribute__((unused)) int sig){

247

int old_errno = errno;

248

226

while(true){

249

227

plugin *proc = plugin_list;

250

228

int status;

254

232

break;

255

233

}

256

234

if(pid == -1){

257

if(errno == ECHILD){

258

/* No child processes */

259

break;

235

if(errno != ECHILD){

236

perror("waitpid");

260

237

}

261

perror("waitpid");

238

/* No child processes */

239

break;

262

240

}

263

241

264

242

/* A child exited, find it in process_list */

270

248

continue;

271

249

}

272

250

proc->status = status;

273

proc->completed = 1;

251

proc->completed = true;

274

252

}

275

errno = old_errno;

276

253

}

277

254

278

255

/* Prints out a password to stdout */

300

277

}

301

278

free(plugin_node->environ);

302

279

free(plugin_node->buffer);

303

280

304

281

/* Removes the plugin from the singly-linked list */

305

282

if(plugin_node == plugin_list){

306

283

/* First one - simple */

333

310

struct dirent *dirst;

334

311

struct stat st;

335

312

fd_set rfds_all;

336

int ret, maxfd = 0;

313

int ret, numchars, maxfd = 0;

337

314

ssize_t sret;

315

intmax_t tmpmax;

338

316

uid_t uid = 65534;

339

317

gid_t gid = 65534;

340

318

bool debug = false;

398

376

};

399

377

400

378

error_t parse_opt(int key, char *arg, __attribute__((unused))

401

struct argp_state *state){

402

switch(key){

403

char *tmp;

404

intmax_t tmpmax;

379

struct argp_state *state) {

380

switch(key) {

405

381

case 'g': /* --global-options */

406

382

if(arg != NULL){

407

char *plugin_option;

408

while((plugin_option = strsep(&arg, ",")) != NULL){

409

if(plugin_option[0] == '\0'){

383

char *p;

384

while((p = strsep(&arg, ",")) != NULL){

385

if(p[0] == '\0'){

410

386

continue;

411

387

}

412

if(not add_argument(getplugin(NULL), plugin_option)){

388

if(not add_argument(getplugin(NULL), p)){

413

389

perror("add_argument");

414

390

return ARGP_ERR_UNKNOWN;

415

391

}

426

402

break;

427

403

case 'o': /* --options-for */

428

404

if(arg != NULL){

429

char *plugin_name = strsep(&arg, ":");

430

if(plugin_name[0] == '\0'){

431

break;

432

}

433

char *plugin_option;

434

while((plugin_option = strsep(&arg, ",")) != NULL){

435

if(not add_argument(getplugin(plugin_name), plugin_option)){

405

char *p_name = strsep(&arg, ":");

406

if(p_name[0] == '\0' or arg == NULL){

407

break;

408

}

409

char *opt = strsep(&arg, ":");

410

if(opt[0] == '\0' or opt == NULL){

411

break;

412

}

413

char *p;

414

while((p = strsep(&opt, ",")) != NULL){

415

if(p[0] == '\0'){

416

continue;

417

}

418

if(not add_argument(getplugin(p_name), p)){

436

419

perror("add_argument");

437

420

return ARGP_ERR_UNKNOWN;

438

421

}

477

460

plugindir = strdup(arg);

478

461

if(plugindir == NULL){

479

462

perror("strdup");

480

}

463

}

481

464

break;

482

465

case 129: /* --config-file */

483

466

/* This is already done by parse_opt_config_file() */

484

467

break;

485

468

case 130: /* --userid */

486

errno = 0;

487

tmpmax = strtoimax(arg, &tmp, 10);

488

if(errno != 0 or tmp == arg or *tmp != '\0'

489

or tmpmax != (uid_t)tmpmax){

469

ret = sscanf(arg, "%" SCNdMAX "%n", &tmpmax, &numchars);

470

if(ret < 1 or tmpmax != (uid_t)tmpmax

471

or arg[numchars] != '\0'){

490

472

fprintf(stderr, "Bad user ID number: \"%s\", using %"

491

473

PRIdMAX "\n", arg, (intmax_t)uid);

492

474

} else {

494

476

}

495

477

break;

496

478

case 131: /* --groupid */

497

errno = 0;

498

tmpmax = strtoimax(arg, &tmp, 10);

499

if(errno != 0 or tmp == arg or *tmp != '\0'

500

or tmpmax != (gid_t)tmpmax){

479

ret = sscanf(arg, "%" SCNdMAX "%n", &tmpmax, &numchars);

480

if(ret < 1 or tmpmax != (gid_t)tmpmax

481

or arg[numchars] != '\0'){

501

482

fprintf(stderr, "Bad group ID number: \"%s\", using %"

502

483

PRIdMAX "\n", arg, (intmax_t)gid);

503

484

} else {

531

512

ignores everything but the --config-file option. */

532

513

error_t parse_opt_config_file(int key, char *arg,

533

514

__attribute__((unused))

534

struct argp_state *state){

535

switch(key){

515

struct argp_state *state) {

516

switch(key) {

536

517

case 'g': /* --global-options */

537

518

case 'G': /* --global-env */

538

519

case 'o': /* --options-for */

547

528

if(argfile == NULL){

548

529

perror("strdup");

549

530

}

550

break;

531

break;

551

532

case 130: /* --userid */

552

533

case 131: /* --groupid */

553

534

case 132: /* --debug */

582

563

conffp = fopen(AFILE, "r");

583

564

} else {

584

565

conffp = fopen(argfile, "r");

585

}

566

}

586

567

if(conffp != NULL){

587

568

char *org_line = NULL;

588

569

char *p, *arg, *new_arg, *line;

589

570

size_t size = 0;

590

571

const char whitespace_delims[] = " \r\t\f\v\n";

591

572

const char comment_delim[] = "#";

592

573

593

574

custom_argc = 1;

594

575

custom_argv = malloc(sizeof(char*) * 2);

595

576

if(custom_argv == NULL){

599

580

}

600

581

custom_argv[0] = argv[0];

601

582

custom_argv[1] = NULL;

602

583

603

584

/* for each line in the config file, strip whitespace and ignore

604

585

commented text */

605

586

while(true){

607

588

if(sret == -1){

608

589

break;

609

590

}

610

591

611

592

line = org_line;

612

593

arg = strsep(&line, comment_delim);

613

594

while((p = strsep(&arg, whitespace_delims)) != NULL){

632

613

goto fallback;

633

614

}

634

615

custom_argv[custom_argc-1] = new_arg;

635

custom_argv[custom_argc] = NULL;

616

custom_argv[custom_argc] = NULL;

636

617

}

637

618

}

638

do {

639

ret = fclose(conffp);

640

} while(ret == EOF and errno == EINTR);

641

if(ret == EOF){

642

perror("fclose");

643

exitstatus = EXIT_FAILURE;

644

goto fallback;

645

}

646

619

free(org_line);

647

620

} else {

648

621

/* Check for harmful errors and go to fallback. Other errors might

689

662

}

690

663

691

664

/* Strip permissions down to nobody */

665

ret = setuid(uid);

666

if(ret == -1){

667

perror("setuid");

668

}

692

669

setgid(gid);

693

670

if(ret == -1){

694

671

perror("setgid");

695

672

}

696

ret = setuid(uid);

697

if(ret == -1){

698

perror("setuid");

699

}

700

701

/* Open plugin directory with close_on_exec flag */

673

674

if(plugindir == NULL){

675

dir = opendir(PDIR);

676

} else {

677

dir = opendir(plugindir);

678

}

679

680

if(dir == NULL){

681

perror("Could not open plugin dir");

682

exitstatus = EXIT_FAILURE;

683

goto fallback;

684

}

685

686

/* Set the FD_CLOEXEC flag on the directory, if possible */

702

687

{

703

int dir_fd = -1;

704

if(plugindir == NULL){

705

dir_fd = open(PDIR, O_RDONLY |

706

#ifdef O_CLOEXEC

707

O_CLOEXEC

708

#else /* not O_CLOEXEC */

709

0

710

#endif /* not O_CLOEXEC */

711

);

712

} else {

713

dir_fd = open(plugindir, O_RDONLY |

714

#ifdef O_CLOEXEC

715

O_CLOEXEC

716

#else /* not O_CLOEXEC */

717

0

718

#endif /* not O_CLOEXEC */

719

);

720

}

721

if(dir_fd == -1){

722

perror("Could not open plugin dir");

723

exitstatus = EXIT_FAILURE;

724

goto fallback;

725

}

726

727

#ifndef O_CLOEXEC

728

/* Set the FD_CLOEXEC flag on the directory */

729

ret = set_cloexec_flag(dir_fd);

730

if(ret < 0){

731

perror("set_cloexec_flag");

732

TEMP_FAILURE_RETRY(close(dir_fd));

733

exitstatus = EXIT_FAILURE;

734

goto fallback;

735

}

736

#endif /* O_CLOEXEC */

737

738

dir = fdopendir(dir_fd);

739

if(dir == NULL){

740

perror("Could not open plugin dir");

741

TEMP_FAILURE_RETRY(close(dir_fd));

742

exitstatus = EXIT_FAILURE;

743

goto fallback;

688

int dir_fd = dirfd(dir);

689

if(dir_fd >= 0){

690

ret = set_cloexec_flag(dir_fd);

691

if(ret < 0){

692

perror("set_cloexec_flag");

693

exitstatus = EXIT_FAILURE;

694

goto fallback;

695

}

744

696

}

745

697

}

746

698

748

700

749

701

/* Read and execute any executable in the plugin directory*/

750

702

while(true){

751

do {

752

dirst = readdir(dir);

753

} while(dirst == NULL and errno == EINTR);

703

dirst = readdir(dir);

754

704

755

705

/* All directory entries have been processed */

756

706

if(dirst == NULL){

807

757

continue;

808

758

}

809

759

}

810

760

811

761

char *filename;

812

762

if(plugindir == NULL){

813

ret = (int)TEMP_FAILURE_RETRY(asprintf(&filename, PDIR "/%s",

814

dirst->d_name));

763

ret = asprintf(&filename, PDIR "/%s", dirst->d_name);

815

764

} else {

816

ret = (int)TEMP_FAILURE_RETRY(asprintf(&filename, "%s/%s",

817

plugindir,

818

dirst->d_name));

765

ret = asprintf(&filename, "%s/%s", plugindir, dirst->d_name);

819

766

}

820

767

if(ret < 0){

821

768

perror("asprintf");

822

769

continue;

823

770

}

824

771

825

ret = (int)TEMP_FAILURE_RETRY(stat(filename, &st));

772

ret = stat(filename, &st);

826

773

if(ret == -1){

827

774

perror("stat");

828

775

free(filename);

829

776

continue;

830

777

}

831

778

832

779

/* Ignore non-executable files */

833

if(not S_ISREG(st.st_mode)

834

or (TEMP_FAILURE_RETRY(access(filename, X_OK)) != 0)){

780

if(not S_ISREG(st.st_mode) or (access(filename, X_OK) != 0)){

835

781

if(debug){

836

782

fprintf(stderr, "Ignoring plugin dir entry \"%s\""

837

783

" with bad type or mode\n", filename);

883

829

}

884

830

885

831

int pipefd[2];

886

ret = (int)TEMP_FAILURE_RETRY(pipe(pipefd));

832

ret = pipe(pipefd);

887

833

if(ret == -1){

888

834

perror("pipe");

889

835

exitstatus = EXIT_FAILURE;

903

849

goto fallback;

904

850

}

905

851

/* Block SIGCHLD until process is safely in process list */

906

ret = (int)TEMP_FAILURE_RETRY(sigprocmask(SIG_BLOCK,

907

&sigchld_action.sa_mask,

908

NULL));

852

ret = sigprocmask(SIG_BLOCK, &sigchld_action.sa_mask, NULL);

909

853

if(ret < 0){

910

854

perror("sigprocmask");

911

855

exitstatus = EXIT_FAILURE;

912

856

goto fallback;

913

857

}

914

858

/* Starting a new process to be watched */

915

pid_t pid;

916

do {

917

pid = fork();

918

} while(pid == -1 and errno == EINTR);

859

pid_t pid = fork();

919

860

if(pid == -1){

920

861

perror("fork");

921

862

exitstatus = EXIT_FAILURE;

959

900

/* no return */

960

901

}

961

902

/* Parent process */

962

TEMP_FAILURE_RETRY(close(pipefd[1])); /* Close unused write end of

963

pipe */

903

close(pipefd[1]); /* Close unused write end of pipe */

964

904

free(filename);

965

905

plugin *new_plugin = getplugin(dirst->d_name);

966

906

if(new_plugin == NULL){

967

907

perror("getplugin");

968

ret = (int)(TEMP_FAILURE_RETRY

969

(sigprocmask(SIG_UNBLOCK, &sigchld_action.sa_mask,

970

NULL)));

908

ret = sigprocmask(SIG_UNBLOCK, &sigchld_action.sa_mask, NULL);

971

909

if(ret < 0){

972

910

perror("sigprocmask");

973

911

}

980

918

981

919

/* Unblock SIGCHLD so signal handler can be run if this process

982

920

has already completed */

983

ret = (int)TEMP_FAILURE_RETRY(sigprocmask(SIG_UNBLOCK,

984

&sigchld_action.sa_mask,

985

NULL));

921

ret = sigprocmask(SIG_UNBLOCK, &sigchld_action.sa_mask, NULL);

986

922

if(ret < 0){

987

923

perror("sigprocmask");

988

924

exitstatus = EXIT_FAILURE;

989

925

goto fallback;

990

926

}

991

927

992

FD_SET(new_plugin->fd, &rfds_all); /* Spurious warning from

993

-Wconversion */

928

FD_SET(new_plugin->fd, &rfds_all);

994

929

995

930

if(maxfd < new_plugin->fd){

996

931

maxfd = new_plugin->fd;

997

932

}

998

933

}

999

934

1000

TEMP_FAILURE_RETRY(closedir(dir));

935

closedir(dir);

1001

936

dir = NULL;

1002

free_plugin(getplugin(NULL));

1003

937

1004

938

for(plugin *p = plugin_list; p != NULL; p = p->next){

1005

939

if(p->pid != 0){

1016

950

while(plugin_list){

1017

951

fd_set rfds = rfds_all;

1018

952

int select_ret = select(maxfd+1, &rfds, NULL, NULL, NULL);

1019

if(select_ret == -1 and errno != EINTR){

953

if(select_ret == -1){

1020

954

perror("select");

1021

955

exitstatus = EXIT_FAILURE;

1022

956

goto fallback;

1025

959

from one of them */

1026

960

for(plugin *proc = plugin_list; proc != NULL;){

1027

961

/* Is this process completely done? */

1028

if(proc->completed and proc->eof){

962

if(proc->eof and proc->completed){

1029

963

/* Only accept the plugin output if it exited cleanly */

1030

964

if(not WIFEXITED(proc->status)

1031

965

or WEXITSTATUS(proc->status) != 0){

1032

966

/* Bad exit by plugin */

1033

967

1034

968

if(debug){

1035

969

if(WIFEXITED(proc->status)){

1036

fprintf(stderr, "Plugin %s [%" PRIdMAX "] exited with"

1037

" status %d\n", proc->name,

1038

(intmax_t) (proc->pid),

970

fprintf(stderr, "Plugin %" PRIdMAX " exited with status"

971

" %d\n", (intmax_t) (proc->pid),

1039

972

WEXITSTATUS(proc->status));

1040

} else if(WIFSIGNALED(proc->status)){

1041

fprintf(stderr, "Plugin %s [%" PRIdMAX "] killed by"

1042

" signal %d: %s\n", proc->name,

1043

(intmax_t) (proc->pid),

1044

WTERMSIG(proc->status),

1045

strsignal(WTERMSIG(proc->status)));

973

} else if(WIFSIGNALED(proc->status)) {

974

fprintf(stderr, "Plugin %" PRIdMAX " killed by signal"

975

" %d\n", (intmax_t) (proc->pid),

976

WTERMSIG(proc->status));

1046

977

} else if(WCOREDUMP(proc->status)){

1047

fprintf(stderr, "Plugin %s [%" PRIdMAX "] dumped"

1048

" core\n", proc->name, (intmax_t) (proc->pid));

978

fprintf(stderr, "Plugin %" PRIdMAX " dumped core\n",

979

(intmax_t) (proc->pid));

1049

980

}

1050

981

}

1051

982

1052

983

/* Remove the plugin */

1053

FD_CLR(proc->fd, &rfds_all); /* Spurious warning from

1054

-Wconversion */

1055

984

FD_CLR(proc->fd, &rfds_all);

985

1056

986

/* Block signal while modifying process_list */

1057

ret = (int)TEMP_FAILURE_RETRY(sigprocmask

1058

(SIG_BLOCK,

1059

&sigchld_action.sa_mask,

1060

NULL));

987

ret = sigprocmask(SIG_BLOCK, &sigchld_action.sa_mask, NULL);

1061

988

if(ret < 0){

1062

989

perror("sigprocmask");

1063

990

exitstatus = EXIT_FAILURE;

1069

996

proc = next_plugin;

1070

997

1071

998

/* We are done modifying process list, so unblock signal */

1072

ret = (int)(TEMP_FAILURE_RETRY

1073

(sigprocmask(SIG_UNBLOCK,

1074

&sigchld_action.sa_mask, NULL)));

999

ret = sigprocmask(SIG_UNBLOCK, &sigchld_action.sa_mask,

1000

NULL);

1075

1001

if(ret < 0){

1076

1002

perror("sigprocmask");

1077

1003

exitstatus = EXIT_FAILURE;

1097

1023

}

1098

1024

1099

1025

/* This process has not completed. Does it have any output? */

1100

if(proc->eof or not FD_ISSET(proc->fd, &rfds)){ /* Spurious

1101

warning from

1102

-Wconversion */

1026

if(proc->eof or not FD_ISSET(proc->fd, &rfds)){

1103

1027

/* This process had nothing to say at this time */

1104

1028

proc = proc->next;

1105

1029

continue;

1116

1040

proc->buffer_size += BUFFER_SIZE;

1117

1041

}

1118

1042

/* Read from the process */

1119

sret = TEMP_FAILURE_RETRY(read(proc->fd,

1120

proc->buffer

1121

+ proc->buffer_length,

1122

BUFFER_SIZE));

1043

sret = read(proc->fd, proc->buffer + proc->buffer_length,

1044

BUFFER_SIZE);

1123

1045

if(sret < 0){

1124

1046

/* Read error from this process; ignore the error */

1125

1047

proc = proc->next;

1133

1055

}

1134

1056

}

1135

1057

}

1136

1137

1058

1059

1138

1060

fallback:

1139

1061

1140

1062

if(plugin_list == NULL or exitstatus != EXIT_SUCCESS){

1187

1109

}

1188

1110

1189

1111

/* Wait for any remaining child processes to terminate */

1190

do {

1112

do{

1191

1113

ret = wait(NULL);

1192

1114

} while(ret >= 0);

1193

1115

if(errno != ECHILD){