/mandos/trunk

To get this branch, use:
bzr branch http://bzr.recompile.se/loggerhead/mandos/trunk

« back to all changes in this revision

Viewing changes to plugins.d/usplash.c

  • Committer: Teddy Hogeborn
  • Date: 2009-01-13 01:36:46 UTC
  • Revision ID: teddy@fukt.bsnet.se-20090113013646-1u21ie2oaotcekdz
* plugin-runner.c (main): Use "sscanf" instead of "strtol"; using the
                          correct type instead of casting.
* plugins.d/mandos-cliend.c (main): Detect an empty string when
                                    parsing DH bits and port number.
* plugins.d/splashy.c (main): Use "sscanf" instead of "strtoul"; using
                              the correct type instead of casting.
* plugins.d/usplash.c (main): - '' -

Show diffs side-by-side

added added

removed removed

Lines of Context:
plugins.d/usplash.c
1
1
/*  -*- coding: utf-8 -*- */
2
2
/*
3
 
 * Passprompt - Read a password from usplash and output it
 
3
 * Usplash - Read a password from usplash and output it
4
4
 * 
5
5
 * Copyright © 2008,2009 Teddy Hogeborn
6
6
 * Copyright © 2008,2009 Björn Påhlsson
36
36
                                   dirent */
37
37
#include <stddef.h>             /* NULL */
38
38
#include <string.h>             /* strlen(), memcmp() */
39
 
#include <stdio.h>              /* asprintf(), perror() */
 
39
#include <stdio.h>              /* asprintf(), perror(), sscanf() */
40
40
#include <unistd.h>             /* close(), write(), readlink(),
41
41
                                   read(), STDOUT_FILENO, sleep(),
42
42
                                   fork(), setuid(), geteuid(),
43
43
                                   setsid(), chdir(), dup2(),
44
44
                                   STDERR_FILENO, execv() */
45
 
#include <stdlib.h>             /* free(), EXIT_FAILURE, strtoul(),
46
 
                                   realloc(), EXIT_SUCCESS, malloc(),
47
 
                                   _exit() */
 
45
#include <stdlib.h>             /* free(), EXIT_FAILURE, realloc(),
 
46
                                   EXIT_SUCCESS, malloc(), _exit() */
48
47
#include <stdlib.h>             /* getenv() */
49
48
#include <dirent.h>             /* opendir(), readdir(), closedir() */
50
49
#include <sys/stat.h>           /* struct stat, lstat(), S_ISLNK */
92
91
  }
93
92
  
94
93
  size_t written = 0;
 
94
  ssize_t sret = 0;
95
95
  while(not interrupted_by_signal and written < cmd_line_len){
96
 
    ret = write(fifo_fd, cmd_line + written,
97
 
                cmd_line_len - written);
98
 
    if(ret == -1){
 
96
    sret = write(fifo_fd, cmd_line + written,
 
97
                 cmd_line_len - written);
 
98
    if(sret == -1){
99
99
      if(errno != EINTR or interrupted_by_signal){
100
100
        int e = errno;
101
101
        close(fifo_fd);
106
106
        continue;
107
107
      }
108
108
    }
109
 
    written += (size_t)ret;
 
109
    written += (size_t)sret;
110
110
  }
111
111
  free(cmd_line_alloc);
112
112
  do{
169
169
    for(struct dirent *proc_ent = readdir(proc_dir);
170
170
        proc_ent != NULL;
171
171
        proc_ent = readdir(proc_dir)){
172
 
      pid_t pid = (pid_t) strtoul(proc_ent->d_name, NULL, 10);
173
 
      if(pid == 0){
 
172
      pid_t pid;
 
173
      /* In the GNU C library, pid_t is always int */
 
174
      ret = sscanf(proc_ent->d_name, "%d", &pid);
 
175
      if(ret != 1){
174
176
        /* Not a process */
175
177
        continue;
176
178
      }
192
194
        struct stat exe_stat;
193
195
        ret = lstat(exe_link, &exe_stat);
194
196
        if(ret == -1){
 
197
          if(errno == ENOENT){
 
198
            free(exe_link);
 
199
            continue;
 
200
          }
195
201
          perror("lstat");
196
202
          free(exe_link);
197
203
          free(prompt);
207
213
        
208
214
        sret = readlink(exe_link, exe_target, sizeof(exe_target));
209
215
        free(exe_link);
210
 
        if(sret == -1){
211
 
          continue;
212
 
        }
213
216
      }
214
217
      if((sret == ((ssize_t)sizeof(exe_target)-1))
215
218
         and (memcmp(usplash_name, exe_target,