/mandos/trunk : revision 260

1

/* -*- coding: utf-8; mode: c; mode: orgtbl -*- */

1

/* -*- coding: utf-8 -*- */

2

/*

3

* Mandos plugin runner - Run Mandos plugins

4

*

23

*/

24

25

#define _GNU_SOURCE /* TEMP_FAILURE_RETRY(), getline(),

26

asprintf(), O_CLOEXEC */

26

asprintf() */

27

#include <stddef.h> /* size_t, NULL */

28

#include <stdlib.h> /* malloc(), exit(), EXIT_FAILURE,

29

EXIT_SUCCESS, realloc() */

30

#include <stdbool.h> /* bool, true, false */

31

#include <stdio.h> /* perror, fileno(), fprintf(),

32

stderr, STDOUT_FILENO */

33

#include <sys/types.h> /* DIR, fdopendir(), stat(), struct

33

#include <sys/types.h> /* DIR, opendir(), stat(), struct

34

stat, waitpid(), WIFEXITED(),

35

WEXITSTATUS(), wait(), pid_t,

36

uid_t, gid_t, getuid(), getgid(),

38

#include <sys/select.h> /* fd_set, select(), FD_ZERO(),

39

FD_SET(), FD_ISSET(), FD_CLR */

40

#include <sys/wait.h> /* wait(), waitpid(), WIFEXITED(),

41

WEXITSTATUS(), WTERMSIG(),

42

WCOREDUMP() */

41

WEXITSTATUS() */

43

42

#include <sys/stat.h> /* struct stat, stat(), S_ISREG() */

44

43

#include <iso646.h> /* and, or, not */

45

#include <dirent.h> /* DIR, struct dirent, fdopendir(),

44

#include <dirent.h> /* DIR, struct dirent, opendir(),

46

45

readdir(), closedir(), dirfd() */

47

46

#include <unistd.h> /* struct stat, stat(), S_ISREG(),

48

47

fcntl(), setuid(), setgid(),

53

52

close() */

54

53

#include <fcntl.h> /* fcntl(), F_GETFD, F_SETFD,

55

54

FD_CLOEXEC */

56

#include <string.h> /* strsep, strlen(), asprintf(),

57

strsignal() */

55

#include <string.h> /* strsep, strlen(), asprintf() */

58

56

#include <errno.h> /* errno */

59

57

#include <argp.h> /* struct argp_option, struct

60

58

argp_state, struct argp,

64

62

#include <signal.h> /* struct sigaction, sigemptyset(),

65

63

sigaddset(), sigaction(),

66

64

sigprocmask(), SIG_BLOCK, SIGCHLD,

67

SIG_UNBLOCK, kill(), sig_atomic_t

68

*/

65

SIG_UNBLOCK, kill() */

69

66

#include <errno.h> /* errno, EBADF */

70

#include <inttypes.h> /* intmax_t, PRIdMAX, strtoimax() */

71

67

72

68

#define BUFFER_SIZE 256

73

69

84

80

char **environ;

85

81

int envc;

86

82

bool disabled;

87

83

88

84

/* Variables used for running processes*/

89

85

pid_t pid;

90

86

int fd;

92

88

size_t buffer_size;

93

89

size_t buffer_length;

94

90

bool eof;

95

volatile sig_atomic_t completed;

96

int status;

91

volatile bool completed;

92

volatile int status;

97

93

struct plugin *next;

98

94

} plugin;

99

95

103

99

or if none is found, creates a new one */

104

100

static plugin *getplugin(char *name){

105

101

/* Check for exiting plugin with that name */

106

for(plugin *p = plugin_list; p != NULL; p = p->next){

107

if((p->name == name)

108

or (p->name and name and (strcmp(p->name, name) == 0))){

102

for (plugin *p = plugin_list; p != NULL; p = p->next){

103

if ((p->name == name)

104

or (p->name and name and (strcmp(p->name, name) == 0))){

109

105

return p;

110

106

}

111

107

}

112

108

/* Create a new plugin */

113

plugin *new_plugin = NULL;

114

do {

115

new_plugin = malloc(sizeof(plugin));

116

} while(new_plugin == NULL and errno == EINTR);

117

if(new_plugin == NULL){

109

plugin *new_plugin = malloc(sizeof(plugin));

110

if (new_plugin == NULL){

118

111

return NULL;

119

112

}

120

113

char *copy_name = NULL;

121

114

if(name != NULL){

122

do {

123

copy_name = strdup(name);

124

} while(copy_name == NULL and errno == EINTR);

115

copy_name = strdup(name);

125

116

if(copy_name == NULL){

126

free(new_plugin);

127

117

return NULL;

128

118

}

129

119

}

130

120

131

*new_plugin = (plugin){ .name = copy_name,

132

.argc = 1,

133

.disabled = false,

134

.next = plugin_list };

121

*new_plugin = (plugin) { .name = copy_name,

122

.argc = 1,

123

.disabled = false,

124

.next = plugin_list };

135

125

136

do {

137

new_plugin->argv = malloc(sizeof(char *) * 2);

138

} while(new_plugin->argv == NULL and errno == EINTR);

139

if(new_plugin->argv == NULL){

126

new_plugin->argv = malloc(sizeof(char *) * 2);

127

if (new_plugin->argv == NULL){

140

128

free(copy_name);

141

129

free(new_plugin);

142

130

return NULL;

144

132

new_plugin->argv[0] = copy_name;

145

133

new_plugin->argv[1] = NULL;

146

134

147

do {

148

new_plugin->environ = malloc(sizeof(char *));

149

} while(new_plugin->environ == NULL and errno == EINTR);

135

new_plugin->environ = malloc(sizeof(char *));

150

136

if(new_plugin->environ == NULL){

151

137

free(copy_name);

152

138

free(new_plugin->argv);

164

150

static bool add_to_char_array(const char *new, char ***array,

165

151

int *len){

166

152

/* Resize the pointed-to array to hold one more pointer */

167

do {

168

*array = realloc(*array, sizeof(char *)

169

* (size_t) ((*len) + 2));

170

} while(*array == NULL and errno == EINTR);

153

*array = realloc(*array, sizeof(char *)

154

* (size_t) ((*len) + 2));

171

155

/* Malloc check */

172

156

if(*array == NULL){

173

157

return false;

174

158

}

175

159

/* Make a copy of the new string */

176

char *copy;

177

do {

178

copy = strdup(new);

179

} while(copy == NULL and errno == EINTR);

160

char *copy = strdup(new);

180

161

if(copy == NULL){

181

162

return false;

182

163

}

208

189

if(strncmp(*e, def, namelen + 1) == 0){

209

190

/* It already exists */

210

191

if(replace){

211

char *new;

212

do {

213

new = realloc(*e, strlen(def) + 1);

214

} while(new == NULL and errno == EINTR);

192

char *new = realloc(*e, strlen(def) + 1);

215

193

if(new == NULL){

216

194

return false;

217

195

}

227

205

/*

228

206

* Based on the example in the GNU LibC manual chapter 13.13 "File

229

207

* Descriptor Flags".

230

| [[info:libc:Descriptor%20Flags][File Descriptor Flags]] |

208

* *Note File Descriptor Flags:(libc)Descriptor Flags.

231

209

*/

232

210

static int set_cloexec_flag(int fd){

233

int ret = (int)TEMP_FAILURE_RETRY(fcntl(fd, F_GETFD, 0));

211

int ret = fcntl(fd, F_GETFD, 0);

234

212

/* If reading the flags failed, return error indication now. */

235

213

if(ret < 0){

236

214

return ret;

237

215

}

238

216

/* Store modified flag word in the descriptor. */

239

return (int)TEMP_FAILURE_RETRY(fcntl(fd, F_SETFD,

240

ret | FD_CLOEXEC));

217

return fcntl(fd, F_SETFD, ret | FD_CLOEXEC);

241

218

}

242

219

243

220

244

221

/* Mark processes as completed when they exit, and save their exit

245

222

status. */

246

223

static void handle_sigchld(__attribute__((unused)) int sig){

247

int old_errno = errno;

248

224

while(true){

249

225

plugin *proc = plugin_list;

250

226

int status;

254

230

break;

255

231

}

256

232

if(pid == -1){

257

if(errno == ECHILD){

258

/* No child processes */

259

break;

233

if (errno != ECHILD){

234

perror("waitpid");

260

235

}

261

perror("waitpid");

236

/* No child processes */

237

break;

262

238

}

263

239

264

240

/* A child exited, find it in process_list */

270

246

continue;

271

247

}

272

248

proc->status = status;

273

proc->completed = 1;

249

proc->completed = true;

274

250

}

275

errno = old_errno;

276

251

}

277

252

278

253

/* Prints out a password to stdout */

300

275

}

301

276

free(plugin_node->environ);

302

277

free(plugin_node->buffer);

303

278

304

279

/* Removes the plugin from the singly-linked list */

305

280

if(plugin_node == plugin_list){

306

281

/* First one - simple */

397

372

{ .name = NULL }

398

373

};

399

374

400

error_t parse_opt(int key, char *arg, __attribute__((unused))

401

struct argp_state *state){

402

switch(key){

403

char *tmp;

404

intmax_t tmpmax;

375

error_t parse_opt (int key, char *arg, __attribute__((unused))

376

struct argp_state *state) {

377

switch (key) {

405

378

case 'g': /* --global-options */

406

if(arg != NULL){

407

char *plugin_option;

408

while((plugin_option = strsep(&arg, ",")) != NULL){

409

if(plugin_option[0] == '\0'){

379

if (arg != NULL){

380

char *p;

381

while((p = strsep(&arg, ",")) != NULL){

382

if(p[0] == '\0'){

410

383

continue;

411

384

}

412

if(not add_argument(getplugin(NULL), plugin_option)){

385

if(not add_argument(getplugin(NULL), p)){

413

386

perror("add_argument");

414

387

return ARGP_ERR_UNKNOWN;

415

388

}

425

398

}

426

399

break;

427

400

case 'o': /* --options-for */

428

if(arg != NULL){

429

char *plugin_name = strsep(&arg, ":");

430

if(plugin_name[0] == '\0'){

431

break;

432

}

433

char *plugin_option;

434

while((plugin_option = strsep(&arg, ",")) != NULL){

435

if(not add_argument(getplugin(plugin_name), plugin_option)){

401

if (arg != NULL){

402

char *p_name = strsep(&arg, ":");

403

if(p_name[0] == '\0' or arg == NULL){

404

break;

405

}

406

char *opt = strsep(&arg, ":");

407

if(opt[0] == '\0' or opt == NULL){

408

break;

409

}

410

char *p;

411

while((p = strsep(&opt, ",")) != NULL){

412

if(p[0] == '\0'){

413

continue;

414

}

415

if(not add_argument(getplugin(p_name), p)){

436

416

perror("add_argument");

437

417

return ARGP_ERR_UNKNOWN;

438

418

}

455

435

}

456

436

break;

457

437

case 'd': /* --disable */

458

if(arg != NULL){

438

if (arg != NULL){

459

439

plugin *p = getplugin(arg);

460

440

if(p == NULL){

461

441

return ARGP_ERR_UNKNOWN;

464

444

}

465

445

break;

466

446

case 'e': /* --enable */

467

if(arg != NULL){

447

if (arg != NULL){

468

448

plugin *p = getplugin(arg);

469

449

if(p == NULL){

470

450

return ARGP_ERR_UNKNOWN;

477

457

plugindir = strdup(arg);

478

458

if(plugindir == NULL){

479

459

perror("strdup");

480

}

460

}

481

461

break;

482

462

case 129: /* --config-file */

483

463

/* This is already done by parse_opt_config_file() */

484

464

break;

485

465

case 130: /* --userid */

486

errno = 0;

487

tmpmax = strtoimax(arg, &tmp, 10);

488

if(errno != 0 or tmp == arg or *tmp != '\0'

489

or tmpmax != (uid_t)tmpmax){

490

fprintf(stderr, "Bad user ID number: \"%s\", using %"

491

PRIdMAX "\n", arg, (intmax_t)uid);

492

} else {

493

uid = (uid_t)tmpmax;

494

}

466

uid = (uid_t)strtol(arg, NULL, 10);

495

467

break;

496

468

case 131: /* --groupid */

497

errno = 0;

498

tmpmax = strtoimax(arg, &tmp, 10);

499

if(errno != 0 or tmp == arg or *tmp != '\0'

500

or tmpmax != (gid_t)tmpmax){

501

fprintf(stderr, "Bad group ID number: \"%s\", using %"

502

PRIdMAX "\n", arg, (intmax_t)gid);

503

} else {

504

gid = (gid_t)tmpmax;

505

}

469

gid = (gid_t)strtol(arg, NULL, 10);

506

470

break;

507

471

case 132: /* --debug */

508

472

debug = true;

509

473

break;

510

/*

511

* When adding more options before this line, remember to also add a

512

* "case" to the "parse_opt_config_file" function below.

513

*/

514

474

case ARGP_KEY_ARG:

515

475

/* Cryptsetup always passes an argument, which is an empty

516

476

string if "none" was specified in /etc/crypttab. So if

529

489

530

490

/* This option parser is the same as parse_opt() above, except it

531

491

ignores everything but the --config-file option. */

532

error_t parse_opt_config_file(int key, char *arg,

533

__attribute__((unused))

534

struct argp_state *state){

535

switch(key){

492

error_t parse_opt_config_file (int key, char *arg,

493

__attribute__((unused))

494

struct argp_state *state) {

495

switch (key) {

536

496

case 'g': /* --global-options */

537

497

case 'G': /* --global-env */

538

498

case 'o': /* --options-for */

547

507

if(argfile == NULL){

548

508

perror("strdup");

549

509

}

550

break;

510

break;

551

511

case 130: /* --userid */

552

512

case 131: /* --groupid */

553

513

case 132: /* --debug */

565

525

.args_doc = "",

566

526

.doc = "Mandos plugin runner -- Run plugins" };

567

527

568

/* Parse using parse_opt_config_file() in order to get the custom

528

/* Parse using the parse_opt_config_file in order to get the custom

569

529

config file location, if any. */

570

ret = argp_parse(&argp, argc, argv, ARGP_IN_ORDER, 0, NULL);

571

if(ret == ARGP_ERR_UNKNOWN){

530

ret = argp_parse (&argp, argc, argv, ARGP_IN_ORDER, 0, NULL);

531

if (ret == ARGP_ERR_UNKNOWN){

572

532

fprintf(stderr, "Unknown error while parsing arguments\n");

573

533

exitstatus = EXIT_FAILURE;

574

534

goto fallback;

578

538

argp.parser = parse_opt;

579

539

580

540

/* Open the configfile if available */

581

if(argfile == NULL){

541

if (argfile == NULL){

582

542

conffp = fopen(AFILE, "r");

583

543

} else {

584

544

conffp = fopen(argfile, "r");

585

}

545

}

586

546

if(conffp != NULL){

587

547

char *org_line = NULL;

588

548

char *p, *arg, *new_arg, *line;

589

549

size_t size = 0;

590

550

const char whitespace_delims[] = " \r\t\f\v\n";

591

551

const char comment_delim[] = "#";

592

552

593

553

custom_argc = 1;

594

554

custom_argv = malloc(sizeof(char*) * 2);

595

555

if(custom_argv == NULL){

599

559

}

600

560

custom_argv[0] = argv[0];

601

561

custom_argv[1] = NULL;

602

562

603

563

/* for each line in the config file, strip whitespace and ignore

604

564

commented text */

605

565

while(true){

607

567

if(sret == -1){

608

568

break;

609

569

}

610

570

611

571

line = org_line;

612

572

arg = strsep(&line, comment_delim);

613

573

while((p = strsep(&arg, whitespace_delims)) != NULL){

632

592

goto fallback;

633

593

}

634

594

custom_argv[custom_argc-1] = new_arg;

635

custom_argv[custom_argc] = NULL;

595

custom_argv[custom_argc] = NULL;

636

596

}

637

597

}

638

do {

639

ret = fclose(conffp);

640

} while(ret == EOF and errno == EINTR);

641

if(ret == EOF){

642

perror("fclose");

643

exitstatus = EXIT_FAILURE;

644

goto fallback;

645

}

646

598

free(org_line);

647

599

} else {

648

600

/* Check for harmful errors and go to fallback. Other errors might

649

601

not affect opening plugins */

650

if(errno == EMFILE or errno == ENFILE or errno == ENOMEM){

602

if (errno == EMFILE or errno == ENFILE or errno == ENOMEM){

651

603

perror("fopen");

652

604

exitstatus = EXIT_FAILURE;

653

605

goto fallback;

656

608

/* If there was any arguments from configuration file,

657

609

pass them to parser as command arguments */

658

610

if(custom_argv != NULL){

659

ret = argp_parse(&argp, custom_argc, custom_argv, ARGP_IN_ORDER,

660

0, NULL);

661

if(ret == ARGP_ERR_UNKNOWN){

611

ret = argp_parse (&argp, custom_argc, custom_argv, ARGP_IN_ORDER,

612

0, NULL);

613

if (ret == ARGP_ERR_UNKNOWN){

662

614

fprintf(stderr, "Unknown error while parsing arguments\n");

663

615

exitstatus = EXIT_FAILURE;

664

616

goto fallback;

667

619

668

620

/* Parse actual command line arguments, to let them override the

669

621

config file */

670

ret = argp_parse(&argp, argc, argv, ARGP_IN_ORDER, 0, NULL);

671

if(ret == ARGP_ERR_UNKNOWN){

622

ret = argp_parse (&argp, argc, argv, ARGP_IN_ORDER, 0, NULL);

623

if (ret == ARGP_ERR_UNKNOWN){

672

624

fprintf(stderr, "Unknown error while parsing arguments\n");

673

625

exitstatus = EXIT_FAILURE;

674

626

goto fallback;

681

633

for(char **a = p->argv; *a != NULL; a++){

682

634

fprintf(stderr, "\tArg: %s\n", *a);

683

635

}

684

fprintf(stderr, "...and %d environment variables\n", p->envc);

636

fprintf(stderr, "...and %u environment variables\n", p->envc);

685

637

for(char **a = p->environ; *a != NULL; a++){

686

638

fprintf(stderr, "\t%s\n", *a);

687

639

}

689

641

}

690

642

691

643

/* Strip permissions down to nobody */

644

ret = setuid(uid);

645

if (ret == -1){

646

perror("setuid");

647

}

692

648

setgid(gid);

693

if(ret == -1){

649

if (ret == -1){

694

650

perror("setgid");

695

651

}

696

ret = setuid(uid);

697

if(ret == -1){

698

perror("setuid");

699

}

700

701

/* Open plugin directory with close_on_exec flag */

652

653

if (plugindir == NULL){

654

dir = opendir(PDIR);

655

} else {

656

dir = opendir(plugindir);

657

}

658

659

if(dir == NULL){

660

perror("Could not open plugin dir");

661

exitstatus = EXIT_FAILURE;

662

goto fallback;

663

}

664

665

/* Set the FD_CLOEXEC flag on the directory, if possible */

702

666

{

703

int dir_fd = -1;

704

if(plugindir == NULL){

705

dir_fd = open(PDIR, O_RDONLY |

706

#ifdef O_CLOEXEC

707

O_CLOEXEC

708

#else /* not O_CLOEXEC */

709

0

710

#endif /* not O_CLOEXEC */

711

);

712

} else {

713

dir_fd = open(plugindir, O_RDONLY |

714

#ifdef O_CLOEXEC

715

O_CLOEXEC

716

#else /* not O_CLOEXEC */

717

0

718

#endif /* not O_CLOEXEC */

719

);

720

}

721

if(dir_fd == -1){

722

perror("Could not open plugin dir");

723

exitstatus = EXIT_FAILURE;

724

goto fallback;

725

}

726

727

#ifndef O_CLOEXEC

728

/* Set the FD_CLOEXEC flag on the directory */

729

ret = set_cloexec_flag(dir_fd);

730

if(ret < 0){

731

perror("set_cloexec_flag");

732

TEMP_FAILURE_RETRY(close(dir_fd));

733

exitstatus = EXIT_FAILURE;

734

goto fallback;

735

}

736

#endif /* O_CLOEXEC */

737

738

dir = fdopendir(dir_fd);

739

if(dir == NULL){

740

perror("Could not open plugin dir");

741

TEMP_FAILURE_RETRY(close(dir_fd));

742

exitstatus = EXIT_FAILURE;

743

goto fallback;

667

int dir_fd = dirfd(dir);

668

if(dir_fd >= 0){

669

ret = set_cloexec_flag(dir_fd);

670

if(ret < 0){

671

perror("set_cloexec_flag");

672

exitstatus = EXIT_FAILURE;

673

goto fallback;

674

}

744

675

}

745

676

}

746

677

748

679

749

680

/* Read and execute any executable in the plugin directory*/

750

681

while(true){

751

do {

752

dirst = readdir(dir);

753

} while(dirst == NULL and errno == EINTR);

682

dirst = readdir(dir);

754

683

755

684

/* All directory entries have been processed */

756

685

if(dirst == NULL){

757

if(errno == EBADF){

686

if (errno == EBADF){

758

687

perror("readdir");

759

688

exitstatus = EXIT_FAILURE;

760

689

goto fallback;

807

736

continue;

808

737

}

809

738

}

810

739

811

740

char *filename;

812

741

if(plugindir == NULL){

813

ret = (int)TEMP_FAILURE_RETRY(asprintf(&filename, PDIR "/%s",

814

dirst->d_name));

742

ret = asprintf(&filename, PDIR "/%s", dirst->d_name);

815

743

} else {

816

ret = (int)TEMP_FAILURE_RETRY(asprintf(&filename, "%s/%s",

817

plugindir,

818

dirst->d_name));

744

ret = asprintf(&filename, "%s/%s", plugindir, dirst->d_name);

819

745

}

820

746

if(ret < 0){

821

747

perror("asprintf");

822

748

continue;

823

749

}

824

750

825

ret = (int)TEMP_FAILURE_RETRY(stat(filename, &st));

826

if(ret == -1){

751

ret = stat(filename, &st);

752

if (ret == -1){

827

753

perror("stat");

828

754

free(filename);

829

755

continue;

830

756

}

831

757

832

758

/* Ignore non-executable files */

833

if(not S_ISREG(st.st_mode)

834

or (TEMP_FAILURE_RETRY(access(filename, X_OK)) != 0)){

759

if (not S_ISREG(st.st_mode) or (access(filename, X_OK) != 0)){

835

760

if(debug){

836

761

fprintf(stderr, "Ignoring plugin dir entry \"%s\""

837

762

" with bad type or mode\n", filename);

883

808

}

884

809

885

810

int pipefd[2];

886

ret = (int)TEMP_FAILURE_RETRY(pipe(pipefd));

887

if(ret == -1){

811

ret = pipe(pipefd);

812

if (ret == -1){

888

813

perror("pipe");

889

814

exitstatus = EXIT_FAILURE;

890

815

goto fallback;

903

828

goto fallback;

904

829

}

905

830

/* Block SIGCHLD until process is safely in process list */

906

ret = (int)TEMP_FAILURE_RETRY(sigprocmask(SIG_BLOCK,

907

&sigchld_action.sa_mask,

908

NULL));

831

ret = sigprocmask (SIG_BLOCK, &sigchld_action.sa_mask, NULL);

909

832

if(ret < 0){

910

833

perror("sigprocmask");

911

834

exitstatus = EXIT_FAILURE;

912

835

goto fallback;

913

836

}

914

837

/* Starting a new process to be watched */

915

pid_t pid;

916

do {

917

pid = fork();

918

} while(pid == -1 and errno == EINTR);

838

pid_t pid = fork();

919

839

if(pid == -1){

920

840

perror("fork");

921

841

exitstatus = EXIT_FAILURE;

959

879

/* no return */

960

880

}

961

881

/* Parent process */

962

TEMP_FAILURE_RETRY(close(pipefd[1])); /* Close unused write end of

963

pipe */

882

close(pipefd[1]); /* Close unused write end of pipe */

964

883

free(filename);

965

884

plugin *new_plugin = getplugin(dirst->d_name);

966

if(new_plugin == NULL){

885

if (new_plugin == NULL){

967

886

perror("getplugin");

968

ret = (int)(TEMP_FAILURE_RETRY

969

(sigprocmask(SIG_UNBLOCK, &sigchld_action.sa_mask,

970

NULL)));

887

ret = sigprocmask (SIG_UNBLOCK, &sigchld_action.sa_mask, NULL);

971

888

if(ret < 0){

972

889

perror("sigprocmask");

973

890

}

980

897

981

898

/* Unblock SIGCHLD so signal handler can be run if this process

982

899

has already completed */

983

ret = (int)TEMP_FAILURE_RETRY(sigprocmask(SIG_UNBLOCK,

984

&sigchld_action.sa_mask,

985

NULL));

900

ret = sigprocmask (SIG_UNBLOCK, &sigchld_action.sa_mask, NULL);

986

901

if(ret < 0){

987

902

perror("sigprocmask");

988

903

exitstatus = EXIT_FAILURE;

989

904

goto fallback;

990

905

}

991

906

992

FD_SET(new_plugin->fd, &rfds_all); /* Spurious warning from

993

-Wconversion */

907

FD_SET(new_plugin->fd, &rfds_all);

994

908

995

if(maxfd < new_plugin->fd){

909

if (maxfd < new_plugin->fd){

996

910

maxfd = new_plugin->fd;

997

911

}

998

912

}

999

913

1000

TEMP_FAILURE_RETRY(closedir(dir));

914

closedir(dir);

1001

915

dir = NULL;

1002

free_plugin(getplugin(NULL));

1003

916

1004

917

for(plugin *p = plugin_list; p != NULL; p = p->next){

1005

918

if(p->pid != 0){

1016

929

while(plugin_list){

1017

930

fd_set rfds = rfds_all;

1018

931

int select_ret = select(maxfd+1, &rfds, NULL, NULL, NULL);

1019

if(select_ret == -1 and errno != EINTR){

932

if (select_ret == -1){

1020

933

perror("select");

1021

934

exitstatus = EXIT_FAILURE;

1022

935

goto fallback;

1025

938

from one of them */

1026

939

for(plugin *proc = plugin_list; proc != NULL;){

1027

940

/* Is this process completely done? */

1028

if(proc->completed and proc->eof){

941

if(proc->eof and proc->completed){

1029

942

/* Only accept the plugin output if it exited cleanly */

1030

943

if(not WIFEXITED(proc->status)

1031

944

or WEXITSTATUS(proc->status) != 0){

1032

945

/* Bad exit by plugin */

1033

946

1034

947

if(debug){

1035

948

if(WIFEXITED(proc->status)){

1036

fprintf(stderr, "Plugin %s [%" PRIdMAX "] exited with"

1037

" status %d\n", proc->name,

1038

(intmax_t) (proc->pid),

949

fprintf(stderr, "Plugin %u exited with status %d\n",

950

(unsigned int) (proc->pid),

1039

951

WEXITSTATUS(proc->status));

1040

} else if(WIFSIGNALED(proc->status)){

1041

fprintf(stderr, "Plugin %s [%" PRIdMAX "] killed by"

1042

" signal %d: %s\n", proc->name,

1043

(intmax_t) (proc->pid),

1044

WTERMSIG(proc->status),

1045

strsignal(WTERMSIG(proc->status)));

952

} else if(WIFSIGNALED(proc->status)) {

953

fprintf(stderr, "Plugin %u killed by signal %d\n",

954

(unsigned int) (proc->pid),

955

WTERMSIG(proc->status));

1046

956

} else if(WCOREDUMP(proc->status)){

1047

fprintf(stderr, "Plugin %s [%" PRIdMAX "] dumped"

1048

" core\n", proc->name, (intmax_t) (proc->pid));

957

fprintf(stderr, "Plugin %d dumped core\n",

958

(unsigned int) (proc->pid));

1049

959

}

1050

960

}

1051

961

1052

962

/* Remove the plugin */

1053

FD_CLR(proc->fd, &rfds_all); /* Spurious warning from

1054

-Wconversion */

1055

963

FD_CLR(proc->fd, &rfds_all);

964

1056

965

/* Block signal while modifying process_list */

1057

ret = (int)TEMP_FAILURE_RETRY(sigprocmask

1058

(SIG_BLOCK,

1059

&sigchld_action.sa_mask,

1060

NULL));

966

ret = sigprocmask(SIG_BLOCK, &sigchld_action.sa_mask, NULL);

1061

967

if(ret < 0){

1062

968

perror("sigprocmask");

1063

969

exitstatus = EXIT_FAILURE;

1069

975

proc = next_plugin;

1070

976

1071

977

/* We are done modifying process list, so unblock signal */

1072

ret = (int)(TEMP_FAILURE_RETRY

1073

(sigprocmask(SIG_UNBLOCK,

1074

&sigchld_action.sa_mask, NULL)));

978

ret = sigprocmask (SIG_UNBLOCK, &sigchld_action.sa_mask,

979

NULL);

1075

980

if(ret < 0){

1076

981

perror("sigprocmask");

1077

982

exitstatus = EXIT_FAILURE;

1097

1002

}

1098

1003

1099

1004

/* This process has not completed. Does it have any output? */

1100

if(proc->eof or not FD_ISSET(proc->fd, &rfds)){ /* Spurious

1101

warning from

1102

-Wconversion */

1005

if(proc->eof or not FD_ISSET(proc->fd, &rfds)){

1103

1006

/* This process had nothing to say at this time */

1104

1007

proc = proc->next;

1105

1008

continue;

1108

1011

if(proc->buffer_length + BUFFER_SIZE > proc->buffer_size){

1109

1012

proc->buffer = realloc(proc->buffer, proc->buffer_size

1110

1013

+ (size_t) BUFFER_SIZE);

1111

if(proc->buffer == NULL){

1014

if (proc->buffer == NULL){

1112

1015

perror("malloc");

1113

1016

exitstatus = EXIT_FAILURE;

1114

1017

goto fallback;

1116

1019

proc->buffer_size += BUFFER_SIZE;

1117

1020

}

1118

1021

/* Read from the process */

1119

sret = TEMP_FAILURE_RETRY(read(proc->fd,

1120

proc->buffer

1121

+ proc->buffer_length,

1122

BUFFER_SIZE));

1022

sret = read(proc->fd, proc->buffer + proc->buffer_length,

1023

BUFFER_SIZE);

1123

1024

if(sret < 0){

1124

1025

/* Read error from this process; ignore the error */

1125

1026

proc = proc->next;

1133

1034

}

1134

1035

}

1135

1036

}

1136

1137

1037

1038

1138

1039

fallback:

1139

1040

1140

1041

if(plugin_list == NULL or exitstatus != EXIT_SUCCESS){

1187

1088

}

1188

1089

1189

1090

/* Wait for any remaining child processes to terminate */

1190

do {

1091

do{

1191

1092

ret = wait(NULL);

1192

1093

} while(ret >= 0);

1193

1094

if(errno != ECHILD){