19
19
* along with this program. If not, see
20
20
* <http://www.gnu.org/licenses/>.
22
* Contact the authors at <mandos@recompile.se>.
22
* Contact the authors at <mandos@fukt.bsnet.se>.
25
25
#define _GNU_SOURCE /* TEMP_FAILURE_RETRY(), getline(),
27
27
#include <stddef.h> /* size_t, NULL */
28
#include <stdlib.h> /* malloc(), exit(), EXIT_SUCCESS,
28
#include <stdlib.h> /* malloc(), exit(), EXIT_FAILURE,
29
EXIT_SUCCESS, realloc() */
30
30
#include <stdbool.h> /* bool, true, false */
31
#include <stdio.h> /* fileno(), fprintf(),
32
stderr, STDOUT_FILENO, fclose() */
33
#include <sys/types.h> /* DIR, fdopendir(), fstat(), struct
31
#include <stdio.h> /* perror, fileno(), fprintf(),
32
stderr, STDOUT_FILENO */
33
#include <sys/types.h> /* DIR, opendir(), stat(), struct
34
34
stat, waitpid(), WIFEXITED(),
35
35
WEXITSTATUS(), wait(), pid_t,
36
36
uid_t, gid_t, getuid(), getgid(),
38
38
#include <sys/select.h> /* fd_set, select(), FD_ZERO(),
39
39
FD_SET(), FD_ISSET(), FD_CLR */
40
40
#include <sys/wait.h> /* wait(), waitpid(), WIFEXITED(),
41
WEXITSTATUS(), WTERMSIG(),
43
#include <sys/stat.h> /* struct stat, fstat(), S_ISREG() */
42
#include <sys/stat.h> /* struct stat, stat(), S_ISREG() */
44
43
#include <iso646.h> /* and, or, not */
45
#include <dirent.h> /* DIR, struct dirent, fdopendir(),
44
#include <dirent.h> /* DIR, struct dirent, opendir(),
46
45
readdir(), closedir(), dirfd() */
47
#include <unistd.h> /* fcntl(), F_GETFD, F_SETFD,
48
FD_CLOEXEC, write(), STDOUT_FILENO,
49
struct stat, fstat(), close(),
50
setgid(), setuid(), S_ISREG(),
51
faccessat() pipe(), fork(),
52
_exit(), dup2(), fexecve(), read()
46
#include <unistd.h> /* struct stat, stat(), S_ISREG(),
47
fcntl(), setuid(), setgid(),
48
F_GETFD, F_SETFD, FD_CLOEXEC,
49
access(), pipe(), fork(), close()
50
dup2(), STDOUT_FILENO, _exit(),
51
execv(), write(), read(),
54
53
#include <fcntl.h> /* fcntl(), F_GETFD, F_SETFD,
55
FD_CLOEXEC, openat() */
56
#include <string.h> /* strsep, strlen(), strsignal(),
57
strcmp(), strncmp() */
55
#include <string.h> /* strsep, strlen(), asprintf() */
58
56
#include <errno.h> /* errno */
59
57
#include <argp.h> /* struct argp_option, struct
60
58
argp_state, struct argp,
107
98
/* Gets an existing plugin based on name,
108
99
or if none is found, creates a new one */
109
__attribute__((warn_unused_result))
110
100
static plugin *getplugin(char *name){
111
/* Check for existing plugin with that name */
112
for(plugin *p = plugin_list; p != NULL; p = p->next){
114
or (p->name and name and (strcmp(p->name, name) == 0))){
101
/* Check for exiting plugin with that name */
102
for (plugin *p = plugin_list; p != NULL; p = p->next){
103
if ((p->name == name)
104
or (p->name and name and (strcmp(p->name, name) == 0))){
118
108
/* Create a new plugin */
119
plugin *new_plugin = NULL;
121
new_plugin = malloc(sizeof(plugin));
122
} while(new_plugin == NULL and errno == EINTR);
123
if(new_plugin == NULL){
109
plugin *new_plugin = malloc(sizeof(plugin));
110
if (new_plugin == NULL){
126
113
char *copy_name = NULL;
127
114
if(name != NULL){
129
copy_name = strdup(name);
130
} while(copy_name == NULL and errno == EINTR);
115
copy_name = strdup(name);
131
116
if(copy_name == NULL){
139
*new_plugin = (plugin){ .name = copy_name,
142
.next = plugin_list };
121
*new_plugin = (plugin) { .name = copy_name,
124
.next = plugin_list };
145
new_plugin->argv = malloc(sizeof(char *) * 2);
146
} while(new_plugin->argv == NULL and errno == EINTR);
147
if(new_plugin->argv == NULL){
126
new_plugin->argv = malloc(sizeof(char *) * 2);
127
if (new_plugin->argv == NULL){
150
129
free(new_plugin);
154
132
new_plugin->argv[0] = copy_name;
155
133
new_plugin->argv[1] = NULL;
158
new_plugin->environ = malloc(sizeof(char *));
159
} while(new_plugin->environ == NULL and errno == EINTR);
135
new_plugin->environ = malloc(sizeof(char *));
160
136
if(new_plugin->environ == NULL){
163
138
free(new_plugin->argv);
164
139
free(new_plugin);
168
142
new_plugin->environ[0] = NULL;
414
369
.doc = "Group ID the plugins will run as", .group = 3 },
415
370
{ .name = "debug", .key = 132,
416
371
.doc = "Debug mode", .group = 4 },
418
* These reproduce what we would get without ARGP_NO_HELP
420
{ .name = "help", .key = '?',
421
.doc = "Give this help list", .group = -1 },
422
{ .name = "usage", .key = -3,
423
.doc = "Give a short usage message", .group = -1 },
424
{ .name = "version", .key = 'V',
425
.doc = "Print program version", .group = -1 },
429
__attribute__((nonnull(3)))
430
error_t parse_opt(int key, char *arg, struct argp_state *state){
375
error_t parse_opt (int key, char *arg, __attribute__((unused))
376
struct argp_state *state) {
435
378
case 'g': /* --global-options */
438
while((plugin_option = strsep(&arg, ",")) != NULL){
439
if(not add_argument(getplugin(NULL), plugin_option)){
381
while((p = strsep(&arg, ",")) != NULL){
385
if(not add_argument(getplugin(NULL), p)){
386
perror("add_argument");
387
return ARGP_ERR_UNKNOWN;
446
392
case 'G': /* --global-env */
447
if(add_environment(getplugin(NULL), arg, true)){
396
if(not add_environment(getplugin(NULL), arg, true)){
397
perror("add_environment");
451
400
case 'o': /* --options-for */
453
char *option_list = strchr(arg, ':');
454
if(option_list == NULL){
455
argp_error(state, "No colon in \"%s\"", arg);
462
argp_error(state, "Empty plugin name");
467
while((option = strsep(&option_list, ",")) != NULL){
468
if(not add_argument(getplugin(arg), option)){
402
char *p_name = strsep(&arg, ":");
403
if(p_name[0] == '\0' or arg == NULL){
406
char *opt = strsep(&arg, ":");
407
if(opt[0] == '\0' or opt == NULL){
411
while((p = strsep(&opt, ",")) != NULL){
415
if(not add_argument(getplugin(p_name), p)){
416
perror("add_argument");
417
return ARGP_ERR_UNKNOWN;
475
422
case 'E': /* --env-for */
477
427
char *envdef = strchr(arg, ':');
478
428
if(envdef == NULL){
479
argp_error(state, "No colon in \"%s\"", arg);
486
argp_error(state, "Empty plugin name");
490
if(add_environment(getplugin(arg), envdef, true)){
432
if(not add_environment(getplugin(arg), envdef+1, true)){
433
perror("add_environment");
495
437
case 'd': /* --disable */
497
439
plugin *p = getplugin(arg);
441
return ARGP_ERR_UNKNOWN;
504
446
case 'e': /* --enable */
506
448
plugin *p = getplugin(arg);
450
return ARGP_ERR_UNKNOWN;
513
455
case 128: /* --plugin-dir */
515
457
plugindir = strdup(arg);
516
if(plugindir != NULL){
458
if(plugindir == NULL){
520
462
case 129: /* --config-file */
521
463
/* This is already done by parse_opt_config_file() */
523
465
case 130: /* --userid */
524
tmp_id = strtoimax(arg, &tmp, 10);
525
if(errno != 0 or tmp == arg or *tmp != '\0'
526
or tmp_id != (uid_t)tmp_id){
527
argp_error(state, "Bad user ID number: \"%s\", using %"
528
PRIdMAX, arg, (intmax_t)uid);
466
uid = (uid_t)strtol(arg, NULL, 10);
534
468
case 131: /* --groupid */
535
tmp_id = strtoimax(arg, &tmp, 10);
536
if(errno != 0 or tmp == arg or *tmp != '\0'
537
or tmp_id != (gid_t)tmp_id){
538
argp_error(state, "Bad group ID number: \"%s\", using %"
539
PRIdMAX, arg, (intmax_t)gid);
469
gid = (gid_t)strtol(arg, NULL, 10);
545
471
case 132: /* --debug */
549
* These reproduce what we would get without ARGP_NO_HELP
551
case '?': /* --help */
552
state->flags &= ~(unsigned int)ARGP_NO_EXIT; /* force exit */
553
argp_state_help(state, state->out_stream, ARGP_HELP_STD_HELP);
554
case -3: /* --usage */
555
state->flags &= ~(unsigned int)ARGP_NO_EXIT; /* force exit */
556
argp_state_help(state, state->out_stream,
557
ARGP_HELP_USAGE | ARGP_HELP_EXIT_OK);
558
case 'V': /* --version */
559
fprintf(state->out_stream, "%s\n", argp_program_version);
563
* When adding more options before this line, remember to also add a
564
* "case" to the "parse_opt_config_file" function below.
566
474
case ARGP_KEY_ARG:
567
475
/* Cryptsetup always passes an argument, which is an empty
568
476
string if "none" was specified in /etc/crypttab. So if
569
477
argument was empty, we ignore it silently. */
479
fprintf(stderr, "Ignoring unknown argument \"%s\"\n", arg);
574
485
return ARGP_ERR_UNKNOWN;
576
return errno; /* Set to 0 at start */
579
490
/* This option parser is the same as parse_opt() above, except it
580
491
ignores everything but the --config-file option. */
581
error_t parse_opt_config_file(int key, char *arg,
582
__attribute__((unused))
583
struct argp_state *state){
492
error_t parse_opt_config_file (int key, char *arg,
493
__attribute__((unused))
494
struct argp_state *state) {
586
496
case 'g': /* --global-options */
587
497
case 'G': /* --global-env */
588
498
case 'o': /* --options-for */
679
577
new_arg = strdup(p);
680
578
if(new_arg == NULL){
681
error(0, errno, "strdup");
682
exitstatus = EX_OSERR;
580
exitstatus = EXIT_FAILURE;
687
585
custom_argc += 1;
689
char **new_argv = realloc(custom_argv, sizeof(char *)
692
if(new_argv == NULL){
693
error(0, errno, "realloc");
694
exitstatus = EX_OSERR;
699
custom_argv = new_argv;
586
custom_argv = realloc(custom_argv, sizeof(char *)
587
* ((unsigned int) custom_argc + 1));
588
if(custom_argv == NULL){
590
exitstatus = EXIT_FAILURE;
702
594
custom_argv[custom_argc-1] = new_arg;
703
custom_argv[custom_argc] = NULL;
595
custom_argv[custom_argc] = NULL;
707
ret = fclose(conffp);
708
} while(ret == EOF and errno == EINTR);
710
error(0, errno, "fclose");
711
exitstatus = EX_IOERR;
716
600
/* Check for harmful errors and go to fallback. Other errors might
717
601
not affect opening plugins */
718
if(errno == EMFILE or errno == ENFILE or errno == ENOMEM){
719
error(0, errno, "fopen");
720
exitstatus = EX_OSERR;
602
if (errno == EMFILE or errno == ENFILE or errno == ENOMEM){
604
exitstatus = EXIT_FAILURE;
724
/* If there were any arguments from the configuration file, pass
725
them to parser as command line arguments */
608
/* If there was any arguments from configuration file,
609
pass them to parser as command arguments */
726
610
if(custom_argv != NULL){
727
ret = argp_parse(&argp, custom_argc, custom_argv,
728
ARGP_IN_ORDER | ARGP_NO_EXIT | ARGP_NO_HELP,
736
error(0, errno, "argp_parse");
737
exitstatus = EX_OSERR;
740
exitstatus = EX_CONFIG;
611
ret = argp_parse (&argp, custom_argc, custom_argv, ARGP_IN_ORDER,
613
if (ret == ARGP_ERR_UNKNOWN){
614
fprintf(stderr, "Unknown error while parsing arguments\n");
615
exitstatus = EXIT_FAILURE;
745
620
/* Parse actual command line arguments, to let them override the
747
ret = argp_parse(&argp, argc, argv,
748
ARGP_IN_ORDER | ARGP_NO_EXIT | ARGP_NO_HELP,
756
error(0, errno, "argp_parse");
757
exitstatus = EX_OSERR;
760
exitstatus = EX_USAGE;
622
ret = argp_parse (&argp, argc, argv, ARGP_IN_ORDER, 0, NULL);
623
if (ret == ARGP_ERR_UNKNOWN){
624
fprintf(stderr, "Unknown error while parsing arguments\n");
625
exitstatus = EXIT_FAILURE;
768
633
for(char **a = p->argv; *a != NULL; a++){
769
634
fprintf(stderr, "\tArg: %s\n", *a);
771
fprintf(stderr, "...and %d environment variables\n", p->envc);
636
fprintf(stderr, "...and %u environment variables\n", p->envc);
772
637
for(char **a = p->environ; *a != NULL; a++){
773
638
fprintf(stderr, "\t%s\n", *a);
779
/* Work around Debian bug #633582:
780
<http://bugs.debian.org/633582> */
781
int plugindir_fd = open(/* plugindir or */ PDIR, O_RDONLY);
782
if(plugindir_fd == -1){
784
error(0, errno, "open(\"" PDIR "\")");
787
ret = (int)TEMP_FAILURE_RETRY(fstat(plugindir_fd, &st));
789
error(0, errno, "fstat");
791
if(S_ISDIR(st.st_mode) and st.st_uid == 0 and st.st_gid == 0){
792
ret = fchown(plugindir_fd, uid, gid);
794
error(0, errno, "fchown");
798
TEMP_FAILURE_RETRY(close(plugindir_fd));
802
/* Lower permissions */
805
error(0, errno, "setgid");
643
/* Strip permissions down to nobody */
807
644
ret = setuid(uid);
809
error(0, errno, "setuid");
812
/* Open plugin directory with close_on_exec flag */
653
if (plugindir == NULL){
656
dir = opendir(plugindir);
660
perror("Could not open plugin dir");
661
exitstatus = EXIT_FAILURE;
665
/* Set the FD_CLOEXEC flag on the directory, if possible */
814
dir_fd = open(plugindir != NULL ? plugindir : PDIR, O_RDONLY |
817
#else /* not O_CLOEXEC */
819
#endif /* not O_CLOEXEC */
822
error(0, errno, "Could not open plugin dir");
823
exitstatus = EX_UNAVAILABLE;
828
/* Set the FD_CLOEXEC flag on the directory */
829
ret = set_cloexec_flag(dir_fd);
831
error(0, errno, "set_cloexec_flag");
832
TEMP_FAILURE_RETRY(close(dir_fd));
833
exitstatus = EX_OSERR;
836
#endif /* O_CLOEXEC */
838
dir = fdopendir(dir_fd);
840
error(0, errno, "Could not open plugin dir");
841
TEMP_FAILURE_RETRY(close(dir_fd));
842
exitstatus = EX_OSERR;
667
int dir_fd = dirfd(dir);
669
ret = set_cloexec_flag(dir_fd);
671
perror("set_cloexec_flag");
672
exitstatus = EXIT_FAILURE;
849
680
/* Read and execute any executable in the plugin directory*/
852
dirst = readdir(dir);
853
} while(dirst == NULL and errno == EINTR);
682
dirst = readdir(dir);
855
684
/* All directory entries have been processed */
856
685
if(dirst == NULL){
858
error(0, errno, "readdir");
859
exitstatus = EX_IOERR;
688
exitstatus = EXIT_FAILURE;
694
d_name_len = strlen(dirst->d_name);
865
696
/* Ignore dotfiles, backup files and other junk */
867
698
bool bad_name = false;
868
const char * const patterns[] = { ".*", "#*#", "*~",
869
"*.dpkg-new", "*.dpkg-old",
870
"*.dpkg-bak", "*.dpkg-divert",
873
#pragma GCC diagnostic push
874
#pragma GCC diagnostic ignored "-Wcast-qual"
876
for(const char **pat = (const char **)patterns;
877
*pat != NULL; pat++){
879
#pragma GCC diagnostic pop
881
if(fnmatch(*pat, dirst->d_name,
882
FNM_FILE_NAME | FNM_PERIOD) != FNM_NOMATCH){
884
fprintf(stderr, "Ignoring plugin dir entry \"%s\""
885
" matching pattern %s\n", dirst->d_name, *pat);
896
int plugin_fd = openat(dir_fd, dirst->d_name, O_RDONLY |
899
#else /* not O_CLOEXEC */
901
#endif /* not O_CLOEXEC */
904
error(0, errno, "Could not open plugin");
908
/* Set the FD_CLOEXEC flag on the plugin FD */
909
ret = set_cloexec_flag(plugin_fd);
700
const char const *bad_prefixes[] = { ".", "#", NULL };
702
const char const *bad_suffixes[] = { "~", "#", ".dpkg-new",
705
".dpkg-divert", NULL };
706
for(const char **pre = bad_prefixes; *pre != NULL; pre++){
707
size_t pre_len = strlen(*pre);
708
if((d_name_len >= pre_len)
709
and strncmp((dirst->d_name), *pre, pre_len) == 0){
711
fprintf(stderr, "Ignoring plugin dir entry \"%s\""
712
" with bad prefix %s\n", dirst->d_name, *pre);
721
for(const char **suf = bad_suffixes; *suf != NULL; suf++){
722
size_t suf_len = strlen(*suf);
723
if((d_name_len >= suf_len)
724
and (strcmp((dirst->d_name)+d_name_len-suf_len, *suf)
727
fprintf(stderr, "Ignoring plugin dir entry \"%s\""
728
" with bad suffix %s\n", dirst->d_name, *suf);
741
if(plugindir == NULL){
742
ret = asprintf(&filename, PDIR "/%s", dirst->d_name);
744
ret = asprintf(&filename, "%s/%s", plugindir, dirst->d_name);
911
error(0, errno, "set_cloexec_flag");
912
TEMP_FAILURE_RETRY(close(plugin_fd));
915
#endif /* O_CLOEXEC */
916
ret = (int)TEMP_FAILURE_RETRY(fstat(plugin_fd, &st));
918
error(0, errno, "stat");
919
TEMP_FAILURE_RETRY(close(plugin_fd));
751
ret = stat(filename, &st);
923
758
/* Ignore non-executable files */
924
if(not S_ISREG(st.st_mode)
925
or (TEMP_FAILURE_RETRY(faccessat(dir_fd, dirst->d_name, X_OK,
759
if (not S_ISREG(st.st_mode) or (access(filename, X_OK) != 0)){
928
fprintf(stderr, "Ignoring plugin dir entry \"%s/%s\""
929
" with bad type or mode\n",
930
plugindir != NULL ? plugindir : PDIR, dirst->d_name);
761
fprintf(stderr, "Ignoring plugin dir entry \"%s\""
762
" with bad type or mode\n", filename);
932
TEMP_FAILURE_RETRY(close(plugin_fd));
936
768
plugin *p = getplugin(dirst->d_name);
938
error(0, errno, "getplugin");
939
TEMP_FAILURE_RETRY(close(plugin_fd));
954
786
for(char **a = g->argv + 1; *a != NULL; a++){
955
787
if(not add_argument(p, *a)){
956
error(0, errno, "add_argument");
788
perror("add_argument");
959
791
/* Add global environment variables */
960
792
for(char **e = g->environ; *e != NULL; e++){
961
793
if(not add_environment(p, *e, false)){
962
error(0, errno, "add_environment");
794
perror("add_environment");
967
/* If this plugin has any environment variables, we need to
968
duplicate the environment from this process, too. */
799
/* If this plugin has any environment variables, we will call
800
using execve and need to duplicate the environment from this
969
802
if(p->environ[0] != NULL){
970
803
for(char **e = environ; *e != NULL; e++){
971
804
if(not add_environment(p, *e, false)){
972
error(0, errno, "add_environment");
805
perror("add_environment");
978
ret = (int)TEMP_FAILURE_RETRY(pipe(pipefd));
980
error(0, errno, "pipe");
981
exitstatus = EX_OSERR;
814
exitstatus = EXIT_FAILURE;
984
817
/* Ask OS to automatic close the pipe on exec */
985
818
ret = set_cloexec_flag(pipefd[0]);
987
error(0, errno, "set_cloexec_flag");
988
TEMP_FAILURE_RETRY(close(pipefd[0]));
989
TEMP_FAILURE_RETRY(close(pipefd[1]));
990
exitstatus = EX_OSERR;
820
perror("set_cloexec_flag");
821
exitstatus = EXIT_FAILURE;
993
824
ret = set_cloexec_flag(pipefd[1]);
995
error(0, errno, "set_cloexec_flag");
996
TEMP_FAILURE_RETRY(close(pipefd[0]));
997
TEMP_FAILURE_RETRY(close(pipefd[1]));
998
exitstatus = EX_OSERR;
826
perror("set_cloexec_flag");
827
exitstatus = EXIT_FAILURE;
1001
830
/* Block SIGCHLD until process is safely in process list */
1002
ret = (int)TEMP_FAILURE_RETRY(sigprocmask(SIG_BLOCK,
1003
&sigchld_action.sa_mask,
831
ret = sigprocmask (SIG_BLOCK, &sigchld_action.sa_mask, NULL);
1006
error(0, errno, "sigprocmask");
1007
exitstatus = EX_OSERR;
833
perror("sigprocmask");
834
exitstatus = EXIT_FAILURE;
1010
837
/* Starting a new process to be watched */
1014
} while(pid == -1 and errno == EINTR);
1016
error(0, errno, "fork");
1017
exitstatus = EX_OSERR;
841
exitstatus = EXIT_FAILURE;
1021
845
/* this is the child process */
1022
846
ret = sigaction(SIGCHLD, &old_sigchld_action, NULL);
1024
error(0, errno, "sigaction");
1027
851
ret = sigprocmask(SIG_UNBLOCK, &sigchld_action.sa_mask, NULL);
1029
error(0, errno, "sigprocmask");
853
perror("sigprocmask");
1033
857
ret = dup2(pipefd[1], STDOUT_FILENO); /* replace our stdout */
1035
error(0, errno, "dup2");
1039
863
if(dirfd(dir) < 0){
1041
865
above and must now close it manually here. */
1044
if(fexecve(plugin_fd, p->argv,
1045
(p->environ[0] != NULL) ? p->environ : environ) < 0){
1046
error(0, errno, "fexecve for %s/%s",
1047
plugindir != NULL ? plugindir : PDIR, dirst->d_name);
868
if(p->environ[0] == NULL){
869
if(execv(filename, p->argv) < 0){
874
if(execve(filename, p->argv, p->environ) < 0){
1052
881
/* Parent process */
1053
TEMP_FAILURE_RETRY(close(pipefd[1])); /* Close unused write end of
1055
TEMP_FAILURE_RETRY(close(plugin_fd));
882
close(pipefd[1]); /* Close unused write end of pipe */
1056
884
plugin *new_plugin = getplugin(dirst->d_name);
1057
if(new_plugin == NULL){
1058
error(0, errno, "getplugin");
1059
ret = (int)(TEMP_FAILURE_RETRY
1060
(sigprocmask(SIG_UNBLOCK, &sigchld_action.sa_mask,
885
if (new_plugin == NULL){
887
ret = sigprocmask (SIG_UNBLOCK, &sigchld_action.sa_mask, NULL);
1063
error(0, errno, "sigprocmask");
889
perror("sigprocmask");
1065
exitstatus = EX_OSERR;
891
exitstatus = EXIT_FAILURE;
1072
898
/* Unblock SIGCHLD so signal handler can be run if this process
1073
899
has already completed */
1074
ret = (int)TEMP_FAILURE_RETRY(sigprocmask(SIG_UNBLOCK,
1075
&sigchld_action.sa_mask,
900
ret = sigprocmask (SIG_UNBLOCK, &sigchld_action.sa_mask, NULL);
1078
error(0, errno, "sigprocmask");
1079
exitstatus = EX_OSERR;
902
perror("sigprocmask");
903
exitstatus = EXIT_FAILURE;
1083
#if defined (__GNUC__) and defined (__GLIBC__)
1084
#if not __GLIBC_PREREQ(2, 16)
1085
#pragma GCC diagnostic push
1086
#pragma GCC diagnostic ignored "-Wsign-conversion"
1089
FD_SET(new_plugin->fd, &rfds_all); /* Spurious warning from
1090
-Wconversion in GNU libc
1092
#if defined (__GNUC__) and defined (__GLIBC__)
1093
#if not __GLIBC_PREREQ(2, 16)
1094
#pragma GCC diagnostic pop
907
FD_SET(new_plugin->fd, &rfds_all);
1098
if(maxfd < new_plugin->fd){
909
if (maxfd < new_plugin->fd){
1099
910
maxfd = new_plugin->fd;
1103
TEMP_FAILURE_RETRY(closedir(dir));
1105
free_plugin(getplugin(NULL));
1107
917
for(plugin *p = plugin_list; p != NULL; p = p->next){
1108
918
if(p->pid != 0){
1119
929
while(plugin_list){
1120
930
fd_set rfds = rfds_all;
1121
931
int select_ret = select(maxfd+1, &rfds, NULL, NULL, NULL);
1122
if(select_ret == -1 and errno != EINTR){
1123
error(0, errno, "select");
1124
exitstatus = EX_OSERR;
932
if (select_ret == -1){
934
exitstatus = EXIT_FAILURE;
1127
937
/* OK, now either a process completed, or something can be read
1128
938
from one of them */
1129
939
for(plugin *proc = plugin_list; proc != NULL;){
1130
940
/* Is this process completely done? */
1131
if(proc->completed and proc->eof){
941
if(proc->eof and proc->completed){
1132
942
/* Only accept the plugin output if it exited cleanly */
1133
943
if(not WIFEXITED(proc->status)
1134
944
or WEXITSTATUS(proc->status) != 0){
1135
945
/* Bad exit by plugin */
1138
948
if(WIFEXITED(proc->status)){
1139
fprintf(stderr, "Plugin %s [%" PRIdMAX "] exited with"
1140
" status %d\n", proc->name,
1141
(intmax_t) (proc->pid),
949
fprintf(stderr, "Plugin %u exited with status %d\n",
950
(unsigned int) (proc->pid),
1142
951
WEXITSTATUS(proc->status));
1143
} else if(WIFSIGNALED(proc->status)){
1144
fprintf(stderr, "Plugin %s [%" PRIdMAX "] killed by"
1145
" signal %d: %s\n", proc->name,
1146
(intmax_t) (proc->pid),
1147
WTERMSIG(proc->status),
1148
strsignal(WTERMSIG(proc->status)));
952
} else if(WIFSIGNALED(proc->status)) {
953
fprintf(stderr, "Plugin %u killed by signal %d\n",
954
(unsigned int) (proc->pid),
955
WTERMSIG(proc->status));
1149
956
} else if(WCOREDUMP(proc->status)){
1150
fprintf(stderr, "Plugin %s [%" PRIdMAX "] dumped"
1151
" core\n", proc->name, (intmax_t) (proc->pid));
957
fprintf(stderr, "Plugin %d dumped core\n",
958
(unsigned int) (proc->pid));
1155
962
/* Remove the plugin */
1156
#if defined (__GNUC__) and defined (__GLIBC__)
1157
#if not __GLIBC_PREREQ(2, 16)
1158
#pragma GCC diagnostic push
1159
#pragma GCC diagnostic ignored "-Wsign-conversion"
1162
FD_CLR(proc->fd, &rfds_all); /* Spurious warning from
1163
-Wconversion in GNU libc
1165
#if defined (__GNUC__) and defined (__GLIBC__)
1166
#if not __GLIBC_PREREQ(2, 16)
1167
#pragma GCC diagnostic pop
963
FD_CLR(proc->fd, &rfds_all);
1171
965
/* Block signal while modifying process_list */
1172
ret = (int)TEMP_FAILURE_RETRY(sigprocmask
1174
&sigchld_action.sa_mask,
966
ret = sigprocmask(SIG_BLOCK, &sigchld_action.sa_mask, NULL);
1177
error(0, errno, "sigprocmask");
1178
exitstatus = EX_OSERR;
968
perror("sigprocmask");
969
exitstatus = EXIT_FAILURE;
1205
995
bool bret = print_out_password(proc->buffer,
1206
996
proc->buffer_length);
1208
error(0, errno, "print_out_password");
1209
exitstatus = EX_IOERR;
998
perror("print_out_password");
999
exitstatus = EXIT_FAILURE;
1214
1004
/* This process has not completed. Does it have any output? */
1215
#if defined (__GNUC__) and defined (__GLIBC__)
1216
#if not __GLIBC_PREREQ(2, 16)
1217
#pragma GCC diagnostic push
1218
#pragma GCC diagnostic ignored "-Wsign-conversion"
1221
if(proc->eof or not FD_ISSET(proc->fd, &rfds)){ /* Spurious
1227
#if defined (__GNUC__) and defined (__GLIBC__)
1228
#if not __GLIBC_PREREQ(2, 16)
1229
#pragma GCC diagnostic pop
1005
if(proc->eof or not FD_ISSET(proc->fd, &rfds)){
1232
1006
/* This process had nothing to say at this time */
1233
1007
proc = proc->next;
1236
1010
/* Before reading, make the process' data buffer large enough */
1237
1011
if(proc->buffer_length + BUFFER_SIZE > proc->buffer_size){
1238
char *new_buffer = realloc(proc->buffer, proc->buffer_size
1239
+ (size_t) BUFFER_SIZE);
1240
if(new_buffer == NULL){
1241
error(0, errno, "malloc");
1242
exitstatus = EX_OSERR;
1012
proc->buffer = realloc(proc->buffer, proc->buffer_size
1013
+ (size_t) BUFFER_SIZE);
1014
if (proc->buffer == NULL){
1016
exitstatus = EXIT_FAILURE;
1245
proc->buffer = new_buffer;
1246
1019
proc->buffer_size += BUFFER_SIZE;
1248
1021
/* Read from the process */
1249
sret = TEMP_FAILURE_RETRY(read(proc->fd,
1251
+ proc->buffer_length,
1022
sret = read(proc->fd, proc->buffer + proc->buffer_length,
1254
1025
/* Read error from this process; ignore the error */
1255
1026
proc = proc->next;