19
19
* along with this program. If not, see
20
20
* <http://www.gnu.org/licenses/>.
22
* Contact the authors at <mandos@recompile.se>.
22
* Contact the authors at <mandos@fukt.bsnet.se>.
25
25
#define _GNU_SOURCE /* TEMP_FAILURE_RETRY(), getline(),
26
asprintf(), O_CLOEXEC */
27
27
#include <stddef.h> /* size_t, NULL */
28
#include <stdlib.h> /* malloc(), exit(), EXIT_SUCCESS,
28
#include <stdlib.h> /* malloc(), exit(), EXIT_FAILURE,
29
EXIT_SUCCESS, realloc() */
30
30
#include <stdbool.h> /* bool, true, false */
31
#include <stdio.h> /* fileno(), fprintf(),
31
#include <stdio.h> /* perror, fileno(), fprintf(),
32
32
stderr, STDOUT_FILENO */
33
#include <sys/types.h> /* DIR, fdopendir(), stat(), struct
33
#include <sys/types.h> /* DIR, opendir(), stat(), struct
34
34
stat, waitpid(), WIFEXITED(),
35
35
WEXITSTATUS(), wait(), pid_t,
36
36
uid_t, gid_t, getuid(), getgid(),
38
38
#include <sys/select.h> /* fd_set, select(), FD_ZERO(),
39
39
FD_SET(), FD_ISSET(), FD_CLR */
40
40
#include <sys/wait.h> /* wait(), waitpid(), WIFEXITED(),
41
WEXITSTATUS(), WTERMSIG(),
43
42
#include <sys/stat.h> /* struct stat, stat(), S_ISREG() */
44
43
#include <iso646.h> /* and, or, not */
45
#include <dirent.h> /* DIR, struct dirent, fdopendir(),
44
#include <dirent.h> /* DIR, struct dirent, opendir(),
46
45
readdir(), closedir(), dirfd() */
47
46
#include <unistd.h> /* struct stat, stat(), S_ISREG(),
48
47
fcntl(), setuid(), setgid(),
106
98
/* Gets an existing plugin based on name,
107
99
or if none is found, creates a new one */
108
__attribute__((warn_unused_result))
109
100
static plugin *getplugin(char *name){
110
/* Check for existing plugin with that name */
111
for(plugin *p = plugin_list; p != NULL; p = p->next){
113
or (p->name and name and (strcmp(p->name, name) == 0))){
101
/* Check for exiting plugin with that name */
102
for (plugin *p = plugin_list; p != NULL; p = p->next){
103
if ((p->name == name)
104
or (p->name and name and (strcmp(p->name, name) == 0))){
117
108
/* Create a new plugin */
118
plugin *new_plugin = NULL;
120
new_plugin = malloc(sizeof(plugin));
121
} while(new_plugin == NULL and errno == EINTR);
122
if(new_plugin == NULL){
109
plugin *new_plugin = malloc(sizeof(plugin));
110
if (new_plugin == NULL){
125
113
char *copy_name = NULL;
126
114
if(name != NULL){
128
copy_name = strdup(name);
129
} while(copy_name == NULL and errno == EINTR);
115
copy_name = strdup(name);
130
116
if(copy_name == NULL){
138
*new_plugin = (plugin){ .name = copy_name,
141
.next = plugin_list };
121
*new_plugin = (plugin) { .name = copy_name,
124
.next = plugin_list };
144
new_plugin->argv = malloc(sizeof(char *) * 2);
145
} while(new_plugin->argv == NULL and errno == EINTR);
146
if(new_plugin->argv == NULL){
126
new_plugin->argv = malloc(sizeof(char *) * 2);
127
if (new_plugin->argv == NULL){
149
129
free(new_plugin);
153
132
new_plugin->argv[0] = copy_name;
154
133
new_plugin->argv[1] = NULL;
157
new_plugin->environ = malloc(sizeof(char *));
158
} while(new_plugin->environ == NULL and errno == EINTR);
135
new_plugin->environ = malloc(sizeof(char *));
159
136
if(new_plugin->environ == NULL){
162
138
free(new_plugin->argv);
163
139
free(new_plugin);
167
142
new_plugin->environ[0] = NULL;
413
369
.doc = "Group ID the plugins will run as", .group = 3 },
414
370
{ .name = "debug", .key = 132,
415
371
.doc = "Debug mode", .group = 4 },
417
* These reproduce what we would get without ARGP_NO_HELP
419
{ .name = "help", .key = '?',
420
.doc = "Give this help list", .group = -1 },
421
{ .name = "usage", .key = -3,
422
.doc = "Give a short usage message", .group = -1 },
423
{ .name = "version", .key = 'V',
424
.doc = "Print program version", .group = -1 },
428
__attribute__((nonnull(3)))
429
error_t parse_opt(int key, char *arg, struct argp_state *state){
375
error_t parse_opt (int key, char *arg, __attribute__((unused))
376
struct argp_state *state) {
434
378
case 'g': /* --global-options */
437
while((plugin_option = strsep(&arg, ",")) != NULL){
438
if(not add_argument(getplugin(NULL), plugin_option)){
381
while((p = strsep(&arg, ",")) != NULL){
385
if(not add_argument(getplugin(NULL), p)){
386
perror("add_argument");
387
return ARGP_ERR_UNKNOWN;
445
392
case 'G': /* --global-env */
446
if(add_environment(getplugin(NULL), arg, true)){
396
if(not add_environment(getplugin(NULL), arg, true)){
397
perror("add_environment");
450
400
case 'o': /* --options-for */
452
char *option_list = strchr(arg, ':');
453
if(option_list == NULL){
454
argp_error(state, "No colon in \"%s\"", arg);
461
argp_error(state, "Empty plugin name");
466
while((option = strsep(&option_list, ",")) != NULL){
467
if(not add_argument(getplugin(arg), option)){
402
char *p_name = strsep(&arg, ":");
403
if(p_name[0] == '\0' or arg == NULL){
406
char *opt = strsep(&arg, ":");
407
if(opt[0] == '\0' or opt == NULL){
411
while((p = strsep(&opt, ",")) != NULL){
415
if(not add_argument(getplugin(p_name), p)){
416
perror("add_argument");
417
return ARGP_ERR_UNKNOWN;
474
422
case 'E': /* --env-for */
476
427
char *envdef = strchr(arg, ':');
477
428
if(envdef == NULL){
478
argp_error(state, "No colon in \"%s\"", arg);
485
argp_error(state, "Empty plugin name");
489
if(add_environment(getplugin(arg), envdef, true)){
432
if(not add_environment(getplugin(arg), envdef+1, true)){
433
perror("add_environment");
494
437
case 'd': /* --disable */
496
439
plugin *p = getplugin(arg);
441
return ARGP_ERR_UNKNOWN;
503
446
case 'e': /* --enable */
505
448
plugin *p = getplugin(arg);
450
return ARGP_ERR_UNKNOWN;
512
455
case 128: /* --plugin-dir */
514
457
plugindir = strdup(arg);
515
if(plugindir != NULL){
458
if(plugindir == NULL){
519
462
case 129: /* --config-file */
520
463
/* This is already done by parse_opt_config_file() */
522
465
case 130: /* --userid */
523
tmp_id = strtoimax(arg, &tmp, 10);
524
if(errno != 0 or tmp == arg or *tmp != '\0'
525
or tmp_id != (uid_t)tmp_id){
526
argp_error(state, "Bad user ID number: \"%s\", using %"
527
PRIdMAX, arg, (intmax_t)uid);
466
uid = (uid_t)strtol(arg, NULL, 10);
533
468
case 131: /* --groupid */
534
tmp_id = strtoimax(arg, &tmp, 10);
535
if(errno != 0 or tmp == arg or *tmp != '\0'
536
or tmp_id != (gid_t)tmp_id){
537
argp_error(state, "Bad group ID number: \"%s\", using %"
538
PRIdMAX, arg, (intmax_t)gid);
469
gid = (gid_t)strtol(arg, NULL, 10);
544
471
case 132: /* --debug */
548
* These reproduce what we would get without ARGP_NO_HELP
550
case '?': /* --help */
551
state->flags &= ~(unsigned int)ARGP_NO_EXIT; /* force exit */
552
argp_state_help(state, state->out_stream, ARGP_HELP_STD_HELP);
553
case -3: /* --usage */
554
state->flags &= ~(unsigned int)ARGP_NO_EXIT; /* force exit */
555
argp_state_help(state, state->out_stream,
556
ARGP_HELP_USAGE | ARGP_HELP_EXIT_OK);
557
case 'V': /* --version */
558
fprintf(state->out_stream, "%s\n", argp_program_version);
562
* When adding more options before this line, remember to also add a
563
* "case" to the "parse_opt_config_file" function below.
565
474
case ARGP_KEY_ARG:
566
475
/* Cryptsetup always passes an argument, which is an empty
567
476
string if "none" was specified in /etc/crypttab. So if
568
477
argument was empty, we ignore it silently. */
479
fprintf(stderr, "Ignoring unknown argument \"%s\"\n", arg);
573
485
return ARGP_ERR_UNKNOWN;
575
return errno; /* Set to 0 at start */
578
490
/* This option parser is the same as parse_opt() above, except it
579
491
ignores everything but the --config-file option. */
580
error_t parse_opt_config_file(int key, char *arg,
581
__attribute__((unused))
582
struct argp_state *state){
492
error_t parse_opt_config_file (int key, char *arg,
493
__attribute__((unused))
494
struct argp_state *state) {
585
496
case 'g': /* --global-options */
586
497
case 'G': /* --global-env */
587
498
case 'o': /* --options-for */
678
577
new_arg = strdup(p);
679
578
if(new_arg == NULL){
680
error(0, errno, "strdup");
681
exitstatus = EX_OSERR;
580
exitstatus = EXIT_FAILURE;
686
585
custom_argc += 1;
688
char **new_argv = realloc(custom_argv, sizeof(char *)
691
if(new_argv == NULL){
692
error(0, errno, "realloc");
693
exitstatus = EX_OSERR;
698
custom_argv = new_argv;
586
custom_argv = realloc(custom_argv, sizeof(char *)
587
* ((unsigned int) custom_argc + 1));
588
if(custom_argv == NULL){
590
exitstatus = EXIT_FAILURE;
701
594
custom_argv[custom_argc-1] = new_arg;
702
custom_argv[custom_argc] = NULL;
595
custom_argv[custom_argc] = NULL;
706
ret = fclose(conffp);
707
} while(ret == EOF and errno == EINTR);
709
error(0, errno, "fclose");
710
exitstatus = EX_IOERR;
715
600
/* Check for harmful errors and go to fallback. Other errors might
716
601
not affect opening plugins */
717
if(errno == EMFILE or errno == ENFILE or errno == ENOMEM){
718
error(0, errno, "fopen");
719
exitstatus = EX_OSERR;
602
if (errno == EMFILE or errno == ENFILE or errno == ENOMEM){
604
exitstatus = EXIT_FAILURE;
723
/* If there were any arguments from the configuration file, pass
724
them to parser as command line arguments */
608
/* If there was any arguments from configuration file,
609
pass them to parser as command arguments */
725
610
if(custom_argv != NULL){
726
ret = argp_parse(&argp, custom_argc, custom_argv,
727
ARGP_IN_ORDER | ARGP_NO_EXIT | ARGP_NO_HELP,
735
error(0, errno, "argp_parse");
736
exitstatus = EX_OSERR;
739
exitstatus = EX_CONFIG;
611
ret = argp_parse (&argp, custom_argc, custom_argv, ARGP_IN_ORDER,
613
if (ret == ARGP_ERR_UNKNOWN){
614
fprintf(stderr, "Unknown error while parsing arguments\n");
615
exitstatus = EXIT_FAILURE;
744
620
/* Parse actual command line arguments, to let them override the
746
ret = argp_parse(&argp, argc, argv,
747
ARGP_IN_ORDER | ARGP_NO_EXIT | ARGP_NO_HELP,
755
error(0, errno, "argp_parse");
756
exitstatus = EX_OSERR;
759
exitstatus = EX_USAGE;
622
ret = argp_parse (&argp, argc, argv, ARGP_IN_ORDER, 0, NULL);
623
if (ret == ARGP_ERR_UNKNOWN){
624
fprintf(stderr, "Unknown error while parsing arguments\n");
625
exitstatus = EXIT_FAILURE;
767
633
for(char **a = p->argv; *a != NULL; a++){
768
634
fprintf(stderr, "\tArg: %s\n", *a);
770
fprintf(stderr, "...and %d environment variables\n", p->envc);
636
fprintf(stderr, "...and %u environment variables\n", p->envc);
771
637
for(char **a = p->environ; *a != NULL; a++){
772
638
fprintf(stderr, "\t%s\n", *a);
778
/* Work around Debian bug #633582:
779
<http://bugs.debian.org/633582> */
780
int plugindir_fd = open(/* plugindir or */ PDIR, O_RDONLY);
781
if(plugindir_fd == -1){
782
error(0, errno, "open");
784
ret = (int)TEMP_FAILURE_RETRY(fstat(plugindir_fd, &st));
786
error(0, errno, "fstat");
788
if(S_ISDIR(st.st_mode) and st.st_uid == 0 and st.st_gid == 0){
789
ret = fchown(plugindir_fd, uid, gid);
791
error(0, errno, "fchown");
795
TEMP_FAILURE_RETRY(close(plugindir_fd));
799
/* Lower permissions */
802
error(0, errno, "setgid");
643
/* Strip permissions down to nobody */
804
644
ret = setuid(uid);
806
error(0, errno, "setuid");
809
/* Open plugin directory with close_on_exec flag */
653
if (plugindir == NULL){
656
dir = opendir(plugindir);
660
perror("Could not open plugin dir");
661
exitstatus = EXIT_FAILURE;
665
/* Set the FD_CLOEXEC flag on the directory, if possible */
812
if(plugindir == NULL){
813
dir_fd = open(PDIR, O_RDONLY |
816
#else /* not O_CLOEXEC */
818
#endif /* not O_CLOEXEC */
821
dir_fd = open(plugindir, O_RDONLY |
824
#else /* not O_CLOEXEC */
826
#endif /* not O_CLOEXEC */
830
error(0, errno, "Could not open plugin dir");
831
exitstatus = EX_UNAVAILABLE;
836
/* Set the FD_CLOEXEC flag on the directory */
837
ret = set_cloexec_flag(dir_fd);
839
error(0, errno, "set_cloexec_flag");
840
TEMP_FAILURE_RETRY(close(dir_fd));
841
exitstatus = EX_OSERR;
844
#endif /* O_CLOEXEC */
846
dir = fdopendir(dir_fd);
848
error(0, errno, "Could not open plugin dir");
849
TEMP_FAILURE_RETRY(close(dir_fd));
850
exitstatus = EX_OSERR;
667
int dir_fd = dirfd(dir);
669
ret = set_cloexec_flag(dir_fd);
671
perror("set_cloexec_flag");
672
exitstatus = EXIT_FAILURE;
1001
802
if(p->environ[0] != NULL){
1002
803
for(char **e = environ; *e != NULL; e++){
1003
804
if(not add_environment(p, *e, false)){
1004
error(0, errno, "add_environment");
805
perror("add_environment");
1010
ret = (int)TEMP_FAILURE_RETRY(pipe(pipefd));
1012
error(0, errno, "pipe");
1013
exitstatus = EX_OSERR;
814
exitstatus = EXIT_FAILURE;
1016
817
/* Ask OS to automatic close the pipe on exec */
1017
818
ret = set_cloexec_flag(pipefd[0]);
1019
error(0, errno, "set_cloexec_flag");
1020
exitstatus = EX_OSERR;
820
perror("set_cloexec_flag");
821
exitstatus = EXIT_FAILURE;
1023
824
ret = set_cloexec_flag(pipefd[1]);
1025
error(0, errno, "set_cloexec_flag");
1026
exitstatus = EX_OSERR;
826
perror("set_cloexec_flag");
827
exitstatus = EXIT_FAILURE;
1029
830
/* Block SIGCHLD until process is safely in process list */
1030
ret = (int)TEMP_FAILURE_RETRY(sigprocmask(SIG_BLOCK,
1031
&sigchld_action.sa_mask,
831
ret = sigprocmask (SIG_BLOCK, &sigchld_action.sa_mask, NULL);
1034
error(0, errno, "sigprocmask");
1035
exitstatus = EX_OSERR;
833
perror("sigprocmask");
834
exitstatus = EXIT_FAILURE;
1038
837
/* Starting a new process to be watched */
1042
} while(pid == -1 and errno == EINTR);
1044
error(0, errno, "fork");
1045
exitstatus = EX_OSERR;
841
exitstatus = EXIT_FAILURE;
1049
845
/* this is the child process */
1050
846
ret = sigaction(SIGCHLD, &old_sigchld_action, NULL);
1052
error(0, errno, "sigaction");
1055
851
ret = sigprocmask(SIG_UNBLOCK, &sigchld_action.sa_mask, NULL);
1057
error(0, errno, "sigprocmask");
853
perror("sigprocmask");
1061
857
ret = dup2(pipefd[1], STDOUT_FILENO); /* replace our stdout */
1063
error(0, errno, "dup2");
1067
863
if(dirfd(dir) < 0){
1072
868
if(p->environ[0] == NULL){
1073
869
if(execv(filename, p->argv) < 0){
1074
error(0, errno, "execv for %s", filename);
1078
874
if(execve(filename, p->argv, p->environ) < 0){
1079
error(0, errno, "execve for %s", filename);
1085
881
/* Parent process */
1086
TEMP_FAILURE_RETRY(close(pipefd[1])); /* Close unused write end of
882
close(pipefd[1]); /* Close unused write end of pipe */
1089
884
plugin *new_plugin = getplugin(dirst->d_name);
1090
if(new_plugin == NULL){
1091
error(0, errno, "getplugin");
1092
ret = (int)(TEMP_FAILURE_RETRY
1093
(sigprocmask(SIG_UNBLOCK, &sigchld_action.sa_mask,
885
if (new_plugin == NULL){
887
ret = sigprocmask (SIG_UNBLOCK, &sigchld_action.sa_mask, NULL);
1096
error(0, errno, "sigprocmask");
889
perror("sigprocmask");
1098
exitstatus = EX_OSERR;
891
exitstatus = EXIT_FAILURE;
1105
898
/* Unblock SIGCHLD so signal handler can be run if this process
1106
899
has already completed */
1107
ret = (int)TEMP_FAILURE_RETRY(sigprocmask(SIG_UNBLOCK,
1108
&sigchld_action.sa_mask,
900
ret = sigprocmask (SIG_UNBLOCK, &sigchld_action.sa_mask, NULL);
1111
error(0, errno, "sigprocmask");
1112
exitstatus = EX_OSERR;
902
perror("sigprocmask");
903
exitstatus = EXIT_FAILURE;
1116
#if defined (__GNUC__) and defined (__GLIBC__)
1117
#if not __GLIBC_PREREQ(2, 16)
1118
#pragma GCC diagnostic push
1119
#pragma GCC diagnostic ignored "-Wsign-conversion"
1122
FD_SET(new_plugin->fd, &rfds_all); /* Spurious warning from
1123
-Wconversion in GNU libc
1125
#if defined (__GNUC__) and defined (__GLIBC__)
1126
#if not __GLIBC_PREREQ(2, 16)
1127
#pragma GCC diagnostic pop
907
FD_SET(new_plugin->fd, &rfds_all);
1131
if(maxfd < new_plugin->fd){
909
if (maxfd < new_plugin->fd){
1132
910
maxfd = new_plugin->fd;
1136
TEMP_FAILURE_RETRY(closedir(dir));
1138
free_plugin(getplugin(NULL));
1140
917
for(plugin *p = plugin_list; p != NULL; p = p->next){
1141
918
if(p->pid != 0){
1152
929
while(plugin_list){
1153
930
fd_set rfds = rfds_all;
1154
931
int select_ret = select(maxfd+1, &rfds, NULL, NULL, NULL);
1155
if(select_ret == -1 and errno != EINTR){
1156
error(0, errno, "select");
1157
exitstatus = EX_OSERR;
932
if (select_ret == -1){
934
exitstatus = EXIT_FAILURE;
1160
937
/* OK, now either a process completed, or something can be read
1161
938
from one of them */
1162
939
for(plugin *proc = plugin_list; proc != NULL;){
1163
940
/* Is this process completely done? */
1164
if(proc->completed and proc->eof){
941
if(proc->eof and proc->completed){
1165
942
/* Only accept the plugin output if it exited cleanly */
1166
943
if(not WIFEXITED(proc->status)
1167
944
or WEXITSTATUS(proc->status) != 0){
1168
945
/* Bad exit by plugin */
1171
948
if(WIFEXITED(proc->status)){
1172
fprintf(stderr, "Plugin %s [%" PRIdMAX "] exited with"
1173
" status %d\n", proc->name,
1174
(intmax_t) (proc->pid),
949
fprintf(stderr, "Plugin %u exited with status %d\n",
950
(unsigned int) (proc->pid),
1175
951
WEXITSTATUS(proc->status));
1176
} else if(WIFSIGNALED(proc->status)){
1177
fprintf(stderr, "Plugin %s [%" PRIdMAX "] killed by"
1178
" signal %d: %s\n", proc->name,
1179
(intmax_t) (proc->pid),
1180
WTERMSIG(proc->status),
1181
strsignal(WTERMSIG(proc->status)));
952
} else if(WIFSIGNALED(proc->status)) {
953
fprintf(stderr, "Plugin %u killed by signal %d\n",
954
(unsigned int) (proc->pid),
955
WTERMSIG(proc->status));
1182
956
} else if(WCOREDUMP(proc->status)){
1183
fprintf(stderr, "Plugin %s [%" PRIdMAX "] dumped"
1184
" core\n", proc->name, (intmax_t) (proc->pid));
957
fprintf(stderr, "Plugin %d dumped core\n",
958
(unsigned int) (proc->pid));
1188
962
/* Remove the plugin */
1189
#if defined (__GNUC__) and defined (__GLIBC__)
1190
#if not __GLIBC_PREREQ(2, 16)
1191
#pragma GCC diagnostic push
1192
#pragma GCC diagnostic ignored "-Wsign-conversion"
1195
FD_CLR(proc->fd, &rfds_all); /* Spurious warning from
1196
-Wconversion in GNU libc
1198
#if defined (__GNUC__) and defined (__GLIBC__)
1199
#if not __GLIBC_PREREQ(2, 16)
1200
#pragma GCC diagnostic pop
963
FD_CLR(proc->fd, &rfds_all);
1204
965
/* Block signal while modifying process_list */
1205
ret = (int)TEMP_FAILURE_RETRY(sigprocmask
1207
&sigchld_action.sa_mask,
966
ret = sigprocmask(SIG_BLOCK, &sigchld_action.sa_mask, NULL);
1210
error(0, errno, "sigprocmask");
1211
exitstatus = EX_OSERR;
968
perror("sigprocmask");
969
exitstatus = EXIT_FAILURE;
1238
995
bool bret = print_out_password(proc->buffer,
1239
996
proc->buffer_length);
1241
error(0, errno, "print_out_password");
1242
exitstatus = EX_IOERR;
998
perror("print_out_password");
999
exitstatus = EXIT_FAILURE;
1247
1004
/* This process has not completed. Does it have any output? */
1248
#if defined (__GNUC__) and defined (__GLIBC__)
1249
#if not __GLIBC_PREREQ(2, 16)
1250
#pragma GCC diagnostic push
1251
#pragma GCC diagnostic ignored "-Wsign-conversion"
1254
if(proc->eof or not FD_ISSET(proc->fd, &rfds)){ /* Spurious
1260
#if defined (__GNUC__) and defined (__GLIBC__)
1261
#if not __GLIBC_PREREQ(2, 16)
1262
#pragma GCC diagnostic pop
1005
if(proc->eof or not FD_ISSET(proc->fd, &rfds)){
1265
1006
/* This process had nothing to say at this time */
1266
1007
proc = proc->next;
1269
1010
/* Before reading, make the process' data buffer large enough */
1270
1011
if(proc->buffer_length + BUFFER_SIZE > proc->buffer_size){
1271
char *new_buffer = realloc(proc->buffer, proc->buffer_size
1272
+ (size_t) BUFFER_SIZE);
1273
if(new_buffer == NULL){
1274
error(0, errno, "malloc");
1275
exitstatus = EX_OSERR;
1012
proc->buffer = realloc(proc->buffer, proc->buffer_size
1013
+ (size_t) BUFFER_SIZE);
1014
if (proc->buffer == NULL){
1016
exitstatus = EXIT_FAILURE;
1278
proc->buffer = new_buffer;
1279
1019
proc->buffer_size += BUFFER_SIZE;
1281
1021
/* Read from the process */
1282
sret = TEMP_FAILURE_RETRY(read(proc->fd,
1284
+ proc->buffer_length,
1022
sret = read(proc->fd, proc->buffer + proc->buffer_length,
1287
1025
/* Read error from this process; ignore the error */
1288
1026
proc = proc->next;