1
/* -*- coding: utf-8; mode: c; mode: orgtbl -*- */
1
/* -*- coding: utf-8 -*- */
3
3
* Mandos plugin runner - Run Mandos plugins
5
* Copyright © 2008-2017 Teddy Hogeborn
6
* Copyright © 2008-2017 Björn Påhlsson
8
* This file is part of Mandos.
10
* Mandos is free software: you can redistribute it and/or modify it
11
* under the terms of the GNU General Public License as published by
12
* the Free Software Foundation, either version 3 of the License, or
13
* (at your option) any later version.
15
* Mandos is distributed in the hope that it will be useful, but
5
* Copyright © 2008,2009 Teddy Hogeborn
6
* Copyright © 2008,2009 Björn Påhlsson
8
* This program is free software: you can redistribute it and/or
9
* modify it under the terms of the GNU General Public License as
10
* published by the Free Software Foundation, either version 3 of the
11
* License, or (at your option) any later version.
13
* This program is distributed in the hope that it will be useful, but
16
14
* WITHOUT ANY WARRANTY; without even the implied warranty of
17
15
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
18
16
* General Public License for more details.
20
18
* You should have received a copy of the GNU General Public License
21
* along with Mandos. If not, see <http://www.gnu.org/licenses/>.
19
* along with this program. If not, see
20
* <http://www.gnu.org/licenses/>.
23
* Contact the authors at <mandos@recompile.se>.
22
* Contact the authors at <mandos@fukt.bsnet.se>.
26
25
#define _GNU_SOURCE /* TEMP_FAILURE_RETRY(), getline(),
28
27
#include <stddef.h> /* size_t, NULL */
29
#include <stdlib.h> /* malloc(), exit(), EXIT_SUCCESS,
28
#include <stdlib.h> /* malloc(), exit(), EXIT_FAILURE,
29
EXIT_SUCCESS, realloc() */
31
30
#include <stdbool.h> /* bool, true, false */
32
#include <stdio.h> /* fileno(), fprintf(),
33
stderr, STDOUT_FILENO, fclose() */
34
#include <sys/types.h> /* fstat(), struct stat, waitpid(),
35
WIFEXITED(), WEXITSTATUS(), wait(),
36
pid_t, uid_t, gid_t, getuid(),
31
#include <stdio.h> /* perror, fileno(), fprintf(),
32
stderr, STDOUT_FILENO */
33
#include <sys/types.h> /* DIR, opendir(), stat(), struct
34
stat, waitpid(), WIFEXITED(),
35
WEXITSTATUS(), wait(), pid_t,
36
uid_t, gid_t, getuid(), getgid(),
38
38
#include <sys/select.h> /* fd_set, select(), FD_ZERO(),
39
39
FD_SET(), FD_ISSET(), FD_CLR */
40
40
#include <sys/wait.h> /* wait(), waitpid(), WIFEXITED(),
41
WEXITSTATUS(), WTERMSIG() */
42
#include <sys/stat.h> /* struct stat, fstat(), S_ISREG() */
42
#include <sys/stat.h> /* struct stat, stat(), S_ISREG() */
43
43
#include <iso646.h> /* and, or, not */
44
#include <dirent.h> /* struct dirent, scandirat() */
45
#include <unistd.h> /* fcntl(), F_GETFD, F_SETFD,
46
FD_CLOEXEC, write(), STDOUT_FILENO,
47
struct stat, fstat(), close(),
48
setgid(), setuid(), S_ISREG(),
49
faccessat() pipe2(), fork(),
50
_exit(), dup2(), fexecve(), read()
44
#include <dirent.h> /* DIR, struct dirent, opendir(),
45
readdir(), closedir(), dirfd() */
46
#include <unistd.h> /* struct stat, stat(), S_ISREG(),
47
fcntl(), setuid(), setgid(),
48
F_GETFD, F_SETFD, FD_CLOEXEC,
49
access(), pipe(), fork(), close()
50
dup2(), STDOUT_FILENO, _exit(),
51
execv(), write(), read(),
52
53
#include <fcntl.h> /* fcntl(), F_GETFD, F_SETFD,
53
FD_CLOEXEC, openat(), scandirat(),
55
#include <string.h> /* strsep, strlen(), strsignal(),
56
strcmp(), strncmp() */
55
#include <string.h> /* strsep, strlen(), asprintf() */
57
56
#include <errno.h> /* errno */
58
57
#include <argp.h> /* struct argp_option, struct
59
58
argp_state, struct argp,
107
98
/* Gets an existing plugin based on name,
108
99
or if none is found, creates a new one */
109
__attribute__((warn_unused_result))
110
100
static plugin *getplugin(char *name){
111
/* Check for existing plugin with that name */
112
for(plugin *p = plugin_list; p != NULL; p = p->next){
114
or (p->name and name and (strcmp(p->name, name) == 0))){
101
/* Check for exiting plugin with that name */
102
for (plugin *p = plugin_list; p != NULL; p = p->next){
103
if ((p->name == name)
104
or (p->name and name and (strcmp(p->name, name) == 0))){
118
108
/* Create a new plugin */
119
plugin *new_plugin = NULL;
121
new_plugin = malloc(sizeof(plugin));
122
} while(new_plugin == NULL and errno == EINTR);
123
if(new_plugin == NULL){
109
plugin *new_plugin = malloc(sizeof(plugin));
110
if (new_plugin == NULL){
126
113
char *copy_name = NULL;
127
114
if(name != NULL){
129
copy_name = strdup(name);
130
} while(copy_name == NULL and errno == EINTR);
115
copy_name = strdup(name);
131
116
if(copy_name == NULL){
139
*new_plugin = (plugin){ .name = copy_name,
142
.next = plugin_list };
121
*new_plugin = (plugin) { .name = copy_name,
124
.next = plugin_list };
145
new_plugin->argv = malloc(sizeof(char *) * 2);
146
} while(new_plugin->argv == NULL and errno == EINTR);
147
if(new_plugin->argv == NULL){
126
new_plugin->argv = malloc(sizeof(char *) * 2);
127
if (new_plugin->argv == NULL){
150
129
free(new_plugin);
154
132
new_plugin->argv[0] = copy_name;
155
133
new_plugin->argv[1] = NULL;
158
new_plugin->environ = malloc(sizeof(char *));
159
} while(new_plugin->environ == NULL and errno == EINTR);
135
new_plugin->environ = malloc(sizeof(char *));
160
136
if(new_plugin->environ == NULL){
163
138
free(new_plugin->argv);
164
139
free(new_plugin);
168
142
new_plugin->environ[0] = NULL;
416
369
.doc = "Group ID the plugins will run as", .group = 3 },
417
370
{ .name = "debug", .key = 132,
418
371
.doc = "Debug mode", .group = 4 },
419
{ .name = "plugin-helper-dir", .key = 133,
421
.doc = "Specify a different plugin helper directory",
424
* These reproduce what we would get without ARGP_NO_HELP
426
{ .name = "help", .key = '?',
427
.doc = "Give this help list", .group = -1 },
428
{ .name = "usage", .key = -3,
429
.doc = "Give a short usage message", .group = -1 },
430
{ .name = "version", .key = 'V',
431
.doc = "Print program version", .group = -1 },
435
__attribute__((nonnull(3)))
436
error_t parse_opt(int key, char *arg, struct argp_state *state){
375
error_t parse_opt (int key, char *arg, __attribute__((unused))
376
struct argp_state *state) {
441
378
case 'g': /* --global-options */
444
while((plugin_option = strsep(&arg, ",")) != NULL){
445
if(not add_argument(getplugin(NULL), plugin_option)){
381
while((p = strsep(&arg, ",")) != NULL){
385
if(not add_argument(getplugin(NULL), p)){
386
perror("add_argument");
387
return ARGP_ERR_UNKNOWN;
452
392
case 'G': /* --global-env */
453
if(add_environment(getplugin(NULL), arg, true)){
396
if(not add_environment(getplugin(NULL), arg, true)){
397
perror("add_environment");
457
400
case 'o': /* --options-for */
459
char *option_list = strchr(arg, ':');
460
if(option_list == NULL){
461
argp_error(state, "No colon in \"%s\"", arg);
468
argp_error(state, "Empty plugin name");
473
while((option = strsep(&option_list, ",")) != NULL){
474
if(not add_argument(getplugin(arg), option)){
402
char *p_name = strsep(&arg, ":");
403
if(p_name[0] == '\0' or arg == NULL){
406
char *opt = strsep(&arg, ":");
407
if(opt[0] == '\0' or opt == NULL){
411
while((p = strsep(&opt, ",")) != NULL){
415
if(not add_argument(getplugin(p_name), p)){
416
perror("add_argument");
417
return ARGP_ERR_UNKNOWN;
481
422
case 'E': /* --env-for */
483
427
char *envdef = strchr(arg, ':');
484
428
if(envdef == NULL){
485
argp_error(state, "No colon in \"%s\"", arg);
492
argp_error(state, "Empty plugin name");
496
if(add_environment(getplugin(arg), envdef, true)){
432
if(not add_environment(getplugin(arg), envdef+1, true)){
433
perror("add_environment");
501
437
case 'd': /* --disable */
503
439
plugin *p = getplugin(arg);
441
return ARGP_ERR_UNKNOWN;
510
446
case 'e': /* --enable */
512
448
plugin *p = getplugin(arg);
450
return ARGP_ERR_UNKNOWN;
519
455
case 128: /* --plugin-dir */
521
457
plugindir = strdup(arg);
522
if(plugindir != NULL){
458
if(plugindir == NULL){
526
462
case 129: /* --config-file */
527
463
/* This is already done by parse_opt_config_file() */
529
465
case 130: /* --userid */
530
tmp_id = strtoimax(arg, &tmp, 10);
531
if(errno != 0 or tmp == arg or *tmp != '\0'
532
or tmp_id != (uid_t)tmp_id){
533
argp_error(state, "Bad user ID number: \"%s\", using %"
534
PRIdMAX, arg, (intmax_t)uid);
466
uid = (uid_t)strtol(arg, NULL, 10);
540
468
case 131: /* --groupid */
541
tmp_id = strtoimax(arg, &tmp, 10);
542
if(errno != 0 or tmp == arg or *tmp != '\0'
543
or tmp_id != (gid_t)tmp_id){
544
argp_error(state, "Bad group ID number: \"%s\", using %"
545
PRIdMAX, arg, (intmax_t)gid);
469
gid = (gid_t)strtol(arg, NULL, 10);
551
471
case 132: /* --debug */
554
case 133: /* --plugin-helper-dir */
555
free(pluginhelperdir);
556
pluginhelperdir = strdup(arg);
557
if(pluginhelperdir != NULL){
562
* These reproduce what we would get without ARGP_NO_HELP
564
case '?': /* --help */
565
state->flags &= ~(unsigned int)ARGP_NO_EXIT; /* force exit */
566
argp_state_help(state, state->out_stream, ARGP_HELP_STD_HELP);
567
case -3: /* --usage */
568
state->flags &= ~(unsigned int)ARGP_NO_EXIT; /* force exit */
569
argp_state_help(state, state->out_stream,
570
ARGP_HELP_USAGE | ARGP_HELP_EXIT_OK);
571
case 'V': /* --version */
572
fprintf(state->out_stream, "%s\n", argp_program_version);
576
* When adding more options before this line, remember to also add a
577
* "case" to the "parse_opt_config_file" function below.
579
474
case ARGP_KEY_ARG:
580
475
/* Cryptsetup always passes an argument, which is an empty
581
476
string if "none" was specified in /etc/crypttab. So if
582
477
argument was empty, we ignore it silently. */
479
fprintf(stderr, "Ignoring unknown argument \"%s\"\n", arg);
587
485
return ARGP_ERR_UNKNOWN;
589
return errno; /* Set to 0 at start */
592
490
/* This option parser is the same as parse_opt() above, except it
593
491
ignores everything but the --config-file option. */
594
error_t parse_opt_config_file(int key, char *arg,
595
__attribute__((unused))
596
struct argp_state *state){
492
error_t parse_opt_config_file (int key, char *arg,
493
__attribute__((unused))
494
struct argp_state *state) {
599
496
case 'g': /* --global-options */
600
497
case 'G': /* --global-env */
601
498
case 'o': /* --options-for */
693
577
new_arg = strdup(p);
694
578
if(new_arg == NULL){
695
error(0, errno, "strdup");
696
exitstatus = EX_OSERR;
580
exitstatus = EXIT_FAILURE;
701
585
custom_argc += 1;
703
char **new_argv = realloc(custom_argv, sizeof(char *)
704
* ((size_t)custom_argc + 1));
705
if(new_argv == NULL){
706
error(0, errno, "realloc");
707
exitstatus = EX_OSERR;
712
custom_argv = new_argv;
586
custom_argv = realloc(custom_argv, sizeof(char *)
587
* ((unsigned int) custom_argc + 1));
588
if(custom_argv == NULL){
590
exitstatus = EXIT_FAILURE;
715
594
custom_argv[custom_argc-1] = new_arg;
716
custom_argv[custom_argc] = NULL;
595
custom_argv[custom_argc] = NULL;
720
ret = fclose(conffp);
721
} while(ret == EOF and errno == EINTR);
723
error(0, errno, "fclose");
724
exitstatus = EX_IOERR;
729
600
/* Check for harmful errors and go to fallback. Other errors might
730
601
not affect opening plugins */
731
if(errno == EMFILE or errno == ENFILE or errno == ENOMEM){
732
error(0, errno, "fopen");
733
exitstatus = EX_OSERR;
602
if (errno == EMFILE or errno == ENFILE or errno == ENOMEM){
604
exitstatus = EXIT_FAILURE;
737
/* If there were any arguments from the configuration file, pass
738
them to parser as command line arguments */
608
/* If there was any arguments from configuration file,
609
pass them to parser as command arguments */
739
610
if(custom_argv != NULL){
740
ret = argp_parse(&argp, custom_argc, custom_argv,
741
ARGP_IN_ORDER | ARGP_NO_EXIT | ARGP_NO_HELP,
749
error(0, errno, "argp_parse");
750
exitstatus = EX_OSERR;
753
exitstatus = EX_CONFIG;
611
ret = argp_parse (&argp, custom_argc, custom_argv, ARGP_IN_ORDER,
613
if (ret == ARGP_ERR_UNKNOWN){
614
fprintf(stderr, "Unknown error while parsing arguments\n");
615
exitstatus = EXIT_FAILURE;
758
620
/* Parse actual command line arguments, to let them override the
760
ret = argp_parse(&argp, argc, argv,
761
ARGP_IN_ORDER | ARGP_NO_EXIT | ARGP_NO_HELP,
769
error(0, errno, "argp_parse");
770
exitstatus = EX_OSERR;
773
exitstatus = EX_USAGE;
778
char *pluginhelperenv;
780
ret = asprintf(&pluginhelperenv, "MANDOSPLUGINHELPERDIR=%s",
781
pluginhelperdir != NULL ? pluginhelperdir : PHDIR);
783
bret = add_environment(getplugin(NULL), pluginhelperenv, true);
785
if(ret == -1 or not bret){
786
error(0, errno, "Failed to set MANDOSPLUGINHELPERDIR"
787
" environment variable to \"%s\" for all plugins\n",
788
pluginhelperdir != NULL ? pluginhelperdir : PHDIR);
791
free(pluginhelperenv);
622
ret = argp_parse (&argp, argc, argv, ARGP_IN_ORDER, 0, NULL);
623
if (ret == ARGP_ERR_UNKNOWN){
624
fprintf(stderr, "Unknown error while parsing arguments\n");
625
exitstatus = EXIT_FAILURE;
796
for(plugin *p = plugin_list; p != NULL; p = p->next){
630
for(plugin *p = plugin_list; p != NULL; p=p->next){
797
631
fprintf(stderr, "Plugin: %s has %d arguments\n",
798
632
p->name ? p->name : "Global", p->argc - 1);
799
633
for(char **a = p->argv; *a != NULL; a++){
800
634
fprintf(stderr, "\tArg: %s\n", *a);
802
fprintf(stderr, "...and %d environment variables\n", p->envc);
636
fprintf(stderr, "...and %u environment variables\n", p->envc);
803
637
for(char **a = p->environ; *a != NULL; a++){
804
638
fprintf(stderr, "\t%s\n", *a);
810
/* Work around Debian bug #633582:
811
<https://bugs.debian.org/633582> */
812
int plugindir_fd = open(/* plugindir or */ PDIR, O_RDONLY);
813
if(plugindir_fd == -1){
815
error(0, errno, "open(\"" PDIR "\")");
818
ret = (int)TEMP_FAILURE_RETRY(fstat(plugindir_fd, &st));
820
error(0, errno, "fstat");
822
if(S_ISDIR(st.st_mode) and st.st_uid == 0 and st.st_gid == 0){
823
ret = fchown(plugindir_fd, uid, gid);
825
error(0, errno, "fchown");
833
/* Lower permissions */
836
error(0, errno, "setgid");
643
/* Strip permissions down to nobody */
838
644
ret = setuid(uid);
840
error(0, errno, "setuid");
843
/* Open plugin directory with close_on_exec flag */
653
if (plugindir == NULL){
656
dir = opendir(plugindir);
660
perror("Could not open plugin dir");
661
exitstatus = EXIT_FAILURE;
665
/* Set the FD_CLOEXEC flag on the directory, if possible */
845
dir_fd = open(plugindir != NULL ? plugindir : PDIR, O_RDONLY |
848
#else /* not O_CLOEXEC */
850
#endif /* not O_CLOEXEC */
853
error(0, errno, "Could not open plugin dir");
854
exitstatus = EX_UNAVAILABLE;
859
/* Set the FD_CLOEXEC flag on the directory */
860
ret = set_cloexec_flag(dir_fd);
862
error(0, errno, "set_cloexec_flag");
863
exitstatus = EX_OSERR;
866
#endif /* O_CLOEXEC */
869
int good_name(const struct dirent * const dirent){
870
const char * const patterns[] = { ".*", "#*#", "*~", "*.dpkg-new",
871
"*.dpkg-old", "*.dpkg-bak",
872
"*.dpkg-divert", NULL };
874
#pragma GCC diagnostic push
875
#pragma GCC diagnostic ignored "-Wcast-qual"
877
for(const char **pat = (const char **)patterns;
878
*pat != NULL; pat++){
880
#pragma GCC diagnostic pop
882
if(fnmatch(*pat, dirent->d_name, FNM_FILE_NAME | FNM_PERIOD)
885
fprintf(stderr, "Ignoring plugin dir entry \"%s\""
886
" matching pattern %s\n", dirent->d_name, *pat);
667
int dir_fd = dirfd(dir);
669
ret = set_cloexec_flag(dir_fd);
671
perror("set_cloexec_flag");
672
exitstatus = EXIT_FAILURE;
894
int numplugins = scandirat(dir_fd, ".", &direntries, good_name,
896
if(numplugins == -1){
897
error(0, errno, "Could not scan plugin dir");
899
exitstatus = EX_OSERR;
903
678
FD_ZERO(&rfds_all);
905
680
/* Read and execute any executable in the plugin directory*/
906
for(int i = 0; i < numplugins; i++){
908
int plugin_fd = openat(dir_fd, direntries[i]->d_name, O_RDONLY);
910
error(0, errno, "Could not open plugin");
914
ret = (int)TEMP_FAILURE_RETRY(fstat(plugin_fd, &st));
916
error(0, errno, "stat");
682
dirst = readdir(dir);
684
/* All directory entries have been processed */
688
exitstatus = EXIT_FAILURE;
694
d_name_len = strlen(dirst->d_name);
696
/* Ignore dotfiles, backup files and other junk */
698
bool bad_name = false;
700
const char const *bad_prefixes[] = { ".", "#", NULL };
702
const char const *bad_suffixes[] = { "~", "#", ".dpkg-new",
705
".dpkg-divert", NULL };
706
for(const char **pre = bad_prefixes; *pre != NULL; pre++){
707
size_t pre_len = strlen(*pre);
708
if((d_name_len >= pre_len)
709
and strncmp((dirst->d_name), *pre, pre_len) == 0){
711
fprintf(stderr, "Ignoring plugin dir entry \"%s\""
712
" with bad prefix %s\n", dirst->d_name, *pre);
721
for(const char **suf = bad_suffixes; *suf != NULL; suf++){
722
size_t suf_len = strlen(*suf);
723
if((d_name_len >= suf_len)
724
and (strcmp((dirst->d_name)+d_name_len-suf_len, *suf)
727
fprintf(stderr, "Ignoring plugin dir entry \"%s\""
728
" with bad suffix %s\n", dirst->d_name, *suf);
741
if(plugindir == NULL){
742
ret = asprintf(&filename, PDIR "/%s", dirst->d_name);
744
ret = asprintf(&filename, "%s/%s", plugindir, dirst->d_name);
751
ret = stat(filename, &st);
922
758
/* Ignore non-executable files */
923
if(not S_ISREG(st.st_mode)
924
or (TEMP_FAILURE_RETRY(faccessat(dir_fd, direntries[i]->d_name,
759
if (not S_ISREG(st.st_mode) or (access(filename, X_OK) != 0)){
927
fprintf(stderr, "Ignoring plugin dir entry \"%s/%s\""
928
" with bad type or mode\n",
929
plugindir != NULL ? plugindir : PDIR,
930
direntries[i]->d_name);
761
fprintf(stderr, "Ignoring plugin dir entry \"%s\""
762
" with bad type or mode\n", filename);
937
plugin *p = getplugin(direntries[i]->d_name);
768
plugin *p = getplugin(dirst->d_name);
939
error(0, errno, "getplugin");
946
776
fprintf(stderr, "Ignoring disabled plugin \"%s\"\n",
947
direntries[i]->d_name);
957
786
for(char **a = g->argv + 1; *a != NULL; a++){
958
787
if(not add_argument(p, *a)){
959
error(0, errno, "add_argument");
788
perror("add_argument");
962
791
/* Add global environment variables */
963
792
for(char **e = g->environ; *e != NULL; e++){
964
793
if(not add_environment(p, *e, false)){
965
error(0, errno, "add_environment");
794
perror("add_environment");
970
/* If this plugin has any environment variables, we need to
971
duplicate the environment from this process, too. */
799
/* If this plugin has any environment variables, we will call
800
using execve and need to duplicate the environment from this
972
802
if(p->environ[0] != NULL){
973
803
for(char **e = environ; *e != NULL; e++){
974
804
if(not add_environment(p, *e, false)){
975
error(0, errno, "add_environment");
805
perror("add_environment");
982
ret = (int)TEMP_FAILURE_RETRY(pipe(pipefd));
983
#else /* O_CLOEXEC */
984
ret = (int)TEMP_FAILURE_RETRY(pipe2(pipefd, O_CLOEXEC));
985
#endif /* O_CLOEXEC */
987
error(0, errno, "pipe");
988
exitstatus = EX_OSERR;
992
if(pipefd[0] >= FD_SETSIZE){
993
fprintf(stderr, "pipe()[0] (%d) >= FD_SETSIZE (%d)", pipefd[0],
997
exitstatus = EX_OSERR;
814
exitstatus = EXIT_FAILURE;
1002
817
/* Ask OS to automatic close the pipe on exec */
1003
818
ret = set_cloexec_flag(pipefd[0]);
1005
error(0, errno, "set_cloexec_flag");
1008
exitstatus = EX_OSERR;
1009
free(direntries[i]);
820
perror("set_cloexec_flag");
821
exitstatus = EXIT_FAILURE;
1012
824
ret = set_cloexec_flag(pipefd[1]);
1014
error(0, errno, "set_cloexec_flag");
1017
exitstatus = EX_OSERR;
1018
free(direntries[i]);
826
perror("set_cloexec_flag");
827
exitstatus = EXIT_FAILURE;
1021
#endif /* not O_CLOEXEC */
1022
830
/* Block SIGCHLD until process is safely in process list */
1023
ret = (int)TEMP_FAILURE_RETRY(sigprocmask(SIG_BLOCK,
1024
&sigchld_action.sa_mask,
831
ret = sigprocmask (SIG_BLOCK, &sigchld_action.sa_mask, NULL);
1027
error(0, errno, "sigprocmask");
1028
exitstatus = EX_OSERR;
1029
free(direntries[i]);
833
perror("sigprocmask");
834
exitstatus = EXIT_FAILURE;
1032
837
/* Starting a new process to be watched */
1036
} while(pid == -1 and errno == EINTR);
1038
error(0, errno, "fork");
1039
TEMP_FAILURE_RETRY(sigprocmask(SIG_UNBLOCK,
1040
&sigchld_action.sa_mask, NULL));
1043
exitstatus = EX_OSERR;
1044
free(direntries[i]);
841
exitstatus = EXIT_FAILURE;
1048
845
/* this is the child process */
1049
846
ret = sigaction(SIGCHLD, &old_sigchld_action, NULL);
1051
error(0, errno, "sigaction");
1054
851
ret = sigprocmask(SIG_UNBLOCK, &sigchld_action.sa_mask, NULL);
1056
error(0, errno, "sigprocmask");
853
perror("sigprocmask");
1060
857
ret = dup2(pipefd[1], STDOUT_FILENO); /* replace our stdout */
1062
error(0, errno, "dup2");
1066
if(fexecve(plugin_fd, p->argv,
1067
(p->environ[0] != NULL) ? p->environ : environ) < 0){
1068
error(0, errno, "fexecve for %s/%s",
1069
plugindir != NULL ? plugindir : PDIR,
1070
direntries[i]->d_name);
864
/* If dir has no file descriptor, we could not set FD_CLOEXEC
865
above and must now close it manually here. */
868
if(p->environ[0] == NULL){
869
if(execv(filename, p->argv) < 0){
874
if(execve(filename, p->argv, p->environ) < 0){
1075
881
/* Parent process */
1076
882
close(pipefd[1]); /* Close unused write end of pipe */
1078
plugin *new_plugin = getplugin(direntries[i]->d_name);
1079
if(new_plugin == NULL){
1080
error(0, errno, "getplugin");
1081
ret = (int)(TEMP_FAILURE_RETRY
1082
(sigprocmask(SIG_UNBLOCK, &sigchld_action.sa_mask,
884
plugin *new_plugin = getplugin(dirst->d_name);
885
if (new_plugin == NULL){
887
ret = sigprocmask (SIG_UNBLOCK, &sigchld_action.sa_mask, NULL);
1085
error(0, errno, "sigprocmask");
889
perror("sigprocmask");
1087
exitstatus = EX_OSERR;
1088
free(direntries[i]);
891
exitstatus = EXIT_FAILURE;
1091
free(direntries[i]);
1093
895
new_plugin->pid = pid;
1094
896
new_plugin->fd = pipefd[0];
1096
898
/* Unblock SIGCHLD so signal handler can be run if this process
1097
899
has already completed */
1098
ret = (int)TEMP_FAILURE_RETRY(sigprocmask(SIG_UNBLOCK,
1099
&sigchld_action.sa_mask,
900
ret = sigprocmask (SIG_UNBLOCK, &sigchld_action.sa_mask, NULL);
1102
error(0, errno, "sigprocmask");
1103
exitstatus = EX_OSERR;
902
perror("sigprocmask");
903
exitstatus = EXIT_FAILURE;
1107
907
FD_SET(new_plugin->fd, &rfds_all);
1109
if(maxfd < new_plugin->fd){
909
if (maxfd < new_plugin->fd){
1110
910
maxfd = new_plugin->fd;
1118
free_plugin(getplugin(NULL));
1120
917
for(plugin *p = plugin_list; p != NULL; p = p->next){
1121
918
if(p->pid != 0){
1132
929
while(plugin_list){
1133
930
fd_set rfds = rfds_all;
1134
931
int select_ret = select(maxfd+1, &rfds, NULL, NULL, NULL);
1135
if(select_ret == -1 and errno != EINTR){
1136
error(0, errno, "select");
1137
exitstatus = EX_OSERR;
932
if (select_ret == -1){
934
exitstatus = EXIT_FAILURE;
1140
937
/* OK, now either a process completed, or something can be read
1141
938
from one of them */
1142
939
for(plugin *proc = plugin_list; proc != NULL;){
1143
940
/* Is this process completely done? */
1144
if(proc->completed and proc->eof){
941
if(proc->eof and proc->completed){
1145
942
/* Only accept the plugin output if it exited cleanly */
1146
943
if(not WIFEXITED(proc->status)
1147
944
or WEXITSTATUS(proc->status) != 0){
1148
945
/* Bad exit by plugin */
1151
948
if(WIFEXITED(proc->status)){
1152
fprintf(stderr, "Plugin %s [%" PRIdMAX "] exited with"
1153
" status %d\n", proc->name,
1154
(intmax_t) (proc->pid),
949
fprintf(stderr, "Plugin %u exited with status %d\n",
950
(unsigned int) (proc->pid),
1155
951
WEXITSTATUS(proc->status));
1156
} else if(WIFSIGNALED(proc->status)){
1157
fprintf(stderr, "Plugin %s [%" PRIdMAX "] killed by"
1158
" signal %d: %s\n", proc->name,
1159
(intmax_t) (proc->pid),
1160
WTERMSIG(proc->status),
1161
strsignal(WTERMSIG(proc->status)));
952
} else if(WIFSIGNALED(proc->status)) {
953
fprintf(stderr, "Plugin %u killed by signal %d\n",
954
(unsigned int) (proc->pid),
955
WTERMSIG(proc->status));
956
} else if(WCOREDUMP(proc->status)){
957
fprintf(stderr, "Plugin %d dumped core\n",
958
(unsigned int) (proc->pid));
1165
962
/* Remove the plugin */
1166
963
FD_CLR(proc->fd, &rfds_all);
1168
965
/* Block signal while modifying process_list */
1169
ret = (int)TEMP_FAILURE_RETRY(sigprocmask
1171
&sigchld_action.sa_mask,
966
ret = sigprocmask(SIG_BLOCK, &sigchld_action.sa_mask, NULL);
1174
error(0, errno, "sigprocmask");
1175
exitstatus = EX_OSERR;
968
perror("sigprocmask");
969
exitstatus = EXIT_FAILURE;