1
/* -*- coding: utf-8; mode: c; mode: orgtbl -*- */
1
/* -*- coding: utf-8 -*- */
3
3
* Mandos plugin runner - Run Mandos plugins
5
* Copyright © 2008-2018 Teddy Hogeborn
6
* Copyright © 2008-2018 Björn Påhlsson
8
* This file is part of Mandos.
10
* Mandos is free software: you can redistribute it and/or modify it
11
* under the terms of the GNU General Public License as published by
12
* the Free Software Foundation, either version 3 of the License, or
13
* (at your option) any later version.
15
* Mandos is distributed in the hope that it will be useful, but
5
* Copyright © 2008,2009 Teddy Hogeborn
6
* Copyright © 2008,2009 Björn Påhlsson
8
* This program is free software: you can redistribute it and/or
9
* modify it under the terms of the GNU General Public License as
10
* published by the Free Software Foundation, either version 3 of the
11
* License, or (at your option) any later version.
13
* This program is distributed in the hope that it will be useful, but
16
14
* WITHOUT ANY WARRANTY; without even the implied warranty of
17
15
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
18
16
* General Public License for more details.
20
18
* You should have received a copy of the GNU General Public License
21
* along with Mandos. If not, see <http://www.gnu.org/licenses/>.
19
* along with this program. If not, see
20
* <http://www.gnu.org/licenses/>.
23
* Contact the authors at <mandos@recompile.se>.
22
* Contact the authors at <mandos@fukt.bsnet.se>.
26
25
#define _GNU_SOURCE /* TEMP_FAILURE_RETRY(), getline(),
28
27
#include <stddef.h> /* size_t, NULL */
29
#include <stdlib.h> /* malloc(), exit(), EXIT_SUCCESS,
28
#include <stdlib.h> /* malloc(), exit(), EXIT_FAILURE,
29
EXIT_SUCCESS, realloc() */
31
30
#include <stdbool.h> /* bool, true, false */
32
#include <stdio.h> /* fileno(), fprintf(),
33
stderr, STDOUT_FILENO, fclose() */
34
#include <sys/types.h> /* fstat(), struct stat, waitpid(),
35
WIFEXITED(), WEXITSTATUS(), wait(),
36
pid_t, uid_t, gid_t, getuid(),
31
#include <stdio.h> /* perror, fileno(), fprintf(),
32
stderr, STDOUT_FILENO */
33
#include <sys/types.h> /* DIR, opendir(), stat(), struct
34
stat, waitpid(), WIFEXITED(),
35
WEXITSTATUS(), wait(), pid_t,
36
uid_t, gid_t, getuid(), getgid(),
38
38
#include <sys/select.h> /* fd_set, select(), FD_ZERO(),
39
39
FD_SET(), FD_ISSET(), FD_CLR */
40
40
#include <sys/wait.h> /* wait(), waitpid(), WIFEXITED(),
41
WEXITSTATUS(), WTERMSIG() */
42
#include <sys/stat.h> /* struct stat, fstat(), S_ISREG() */
42
#include <sys/stat.h> /* struct stat, stat(), S_ISREG() */
43
43
#include <iso646.h> /* and, or, not */
44
#include <dirent.h> /* struct dirent, scandirat() */
45
#include <unistd.h> /* fcntl(), F_GETFD, F_SETFD,
46
FD_CLOEXEC, write(), STDOUT_FILENO,
47
struct stat, fstat(), close(),
48
setgid(), setuid(), S_ISREG(),
49
faccessat() pipe2(), fork(),
50
_exit(), dup2(), fexecve(), read()
44
#include <dirent.h> /* DIR, struct dirent, opendir(),
45
readdir(), closedir(), dirfd() */
46
#include <unistd.h> /* struct stat, stat(), S_ISREG(),
47
fcntl(), setuid(), setgid(),
48
F_GETFD, F_SETFD, FD_CLOEXEC,
49
access(), pipe(), fork(), close()
50
dup2(), STDOUT_FILENO, _exit(),
51
execv(), write(), read(),
52
53
#include <fcntl.h> /* fcntl(), F_GETFD, F_SETFD,
53
FD_CLOEXEC, openat(), scandirat(),
55
#include <string.h> /* strsep, strlen(), strsignal(),
56
strcmp(), strncmp() */
55
#include <string.h> /* strsep, strlen(), asprintf() */
57
56
#include <errno.h> /* errno */
58
57
#include <argp.h> /* struct argp_option, struct
59
58
argp_state, struct argp,
63
62
#include <signal.h> /* struct sigaction, sigemptyset(),
64
63
sigaddset(), sigaction(),
65
64
sigprocmask(), SIG_BLOCK, SIGCHLD,
66
SIG_UNBLOCK, kill(), sig_atomic_t
65
SIG_UNBLOCK, kill() */
68
66
#include <errno.h> /* errno, EBADF */
69
#include <inttypes.h> /* intmax_t, PRIdMAX, strtoimax() */
70
#include <sysexits.h> /* EX_OSERR, EX_USAGE, EX_IOERR,
71
EX_CONFIG, EX_UNAVAILABLE, EX_OK */
72
#include <errno.h> /* errno */
73
#include <error.h> /* error() */
74
#include <fnmatch.h> /* fnmatch() */
67
#include <inttypes.h> /* intmax_t, SCNdMAX, PRIdMAX, */
76
69
#define BUFFER_SIZE 256
78
71
#define PDIR "/lib/mandos/plugins.d"
79
#define PHDIR "/lib/mandos/plugin-helpers"
80
72
#define AFILE "/conf/conf.d/mandos/plugin-runner.conf"
82
74
const char *argp_program_version = "plugin-runner " VERSION;
83
const char *argp_program_bug_address = "<mandos@recompile.se>";
75
const char *argp_program_bug_address = "<mandos@fukt.bsnet.se>";
85
77
typedef struct plugin{
86
78
char *name; /* can be NULL or any plugin name */
416
374
.doc = "Group ID the plugins will run as", .group = 3 },
417
375
{ .name = "debug", .key = 132,
418
376
.doc = "Debug mode", .group = 4 },
419
{ .name = "plugin-helper-dir", .key = 133,
421
.doc = "Specify a different plugin helper directory",
424
* These reproduce what we would get without ARGP_NO_HELP
426
{ .name = "help", .key = '?',
427
.doc = "Give this help list", .group = -1 },
428
{ .name = "usage", .key = -3,
429
.doc = "Give a short usage message", .group = -1 },
430
{ .name = "version", .key = 'V',
431
.doc = "Print program version", .group = -1 },
435
__attribute__((nonnull(3)))
436
error_t parse_opt(int key, char *arg, struct argp_state *state){
380
error_t parse_opt(int key, char *arg, __attribute__((unused))
381
struct argp_state *state){
441
383
case 'g': /* --global-options */
444
while((plugin_option = strsep(&arg, ",")) != NULL){
445
if(not add_argument(getplugin(NULL), plugin_option)){
386
while((p = strsep(&arg, ",")) != NULL){
390
if(not add_argument(getplugin(NULL), p)){
391
perror("add_argument");
392
return ARGP_ERR_UNKNOWN;
452
397
case 'G': /* --global-env */
453
if(add_environment(getplugin(NULL), arg, true)){
401
if(not add_environment(getplugin(NULL), arg, true)){
402
perror("add_environment");
457
405
case 'o': /* --options-for */
459
char *option_list = strchr(arg, ':');
460
if(option_list == NULL){
461
argp_error(state, "No colon in \"%s\"", arg);
468
argp_error(state, "Empty plugin name");
473
while((option = strsep(&option_list, ",")) != NULL){
474
if(not add_argument(getplugin(arg), option)){
407
char *p_name = strsep(&arg, ":");
408
if(p_name[0] == '\0' or arg == NULL){
411
char *opt = strsep(&arg, ":");
412
if(opt[0] == '\0' or opt == NULL){
416
while((p = strsep(&opt, ",")) != NULL){
420
if(not add_argument(getplugin(p_name), p)){
421
perror("add_argument");
422
return ARGP_ERR_UNKNOWN;
481
427
case 'E': /* --env-for */
483
432
char *envdef = strchr(arg, ':');
484
433
if(envdef == NULL){
485
argp_error(state, "No colon in \"%s\"", arg);
492
argp_error(state, "Empty plugin name");
496
if(add_environment(getplugin(arg), envdef, true)){
437
if(not add_environment(getplugin(arg), envdef+1, true)){
438
perror("add_environment");
501
442
case 'd': /* --disable */
503
444
plugin *p = getplugin(arg);
446
return ARGP_ERR_UNKNOWN;
510
451
case 'e': /* --enable */
512
453
plugin *p = getplugin(arg);
455
return ARGP_ERR_UNKNOWN;
519
460
case 128: /* --plugin-dir */
521
462
plugindir = strdup(arg);
522
if(plugindir != NULL){
463
if(plugindir == NULL){
526
467
case 129: /* --config-file */
527
468
/* This is already done by parse_opt_config_file() */
529
470
case 130: /* --userid */
530
tmp_id = strtoimax(arg, &tmp, 10);
531
if(errno != 0 or tmp == arg or *tmp != '\0'
532
or tmp_id != (uid_t)tmp_id){
533
argp_error(state, "Bad user ID number: \"%s\", using %"
534
PRIdMAX, arg, (intmax_t)uid);
471
ret = sscanf(arg, "%" SCNdMAX "%n", &tmpmax, &numchars);
472
if(ret < 1 or tmpmax != (uid_t)tmpmax
473
or arg[numchars] != '\0'){
474
fprintf(stderr, "Bad user ID number: \"%s\", using %"
475
PRIdMAX "\n", arg, (intmax_t)uid);
540
480
case 131: /* --groupid */
541
tmp_id = strtoimax(arg, &tmp, 10);
542
if(errno != 0 or tmp == arg or *tmp != '\0'
543
or tmp_id != (gid_t)tmp_id){
544
argp_error(state, "Bad group ID number: \"%s\", using %"
545
PRIdMAX, arg, (intmax_t)gid);
481
ret = sscanf(arg, "%" SCNdMAX "%n", &tmpmax, &numchars);
482
if(ret < 1 or tmpmax != (gid_t)tmpmax
483
or arg[numchars] != '\0'){
484
fprintf(stderr, "Bad group ID number: \"%s\", using %"
485
PRIdMAX "\n", arg, (intmax_t)gid);
551
490
case 132: /* --debug */
554
case 133: /* --plugin-helper-dir */
555
free(pluginhelperdir);
556
pluginhelperdir = strdup(arg);
557
if(pluginhelperdir != NULL){
562
* These reproduce what we would get without ARGP_NO_HELP
564
case '?': /* --help */
565
state->flags &= ~(unsigned int)ARGP_NO_EXIT; /* force exit */
566
argp_state_help(state, state->out_stream, ARGP_HELP_STD_HELP);
567
case -3: /* --usage */
568
state->flags &= ~(unsigned int)ARGP_NO_EXIT; /* force exit */
569
argp_state_help(state, state->out_stream,
570
ARGP_HELP_USAGE | ARGP_HELP_EXIT_OK);
571
case 'V': /* --version */
572
fprintf(state->out_stream, "%s\n", argp_program_version);
576
494
* When adding more options before this line, remember to also add a
577
495
* "case" to the "parse_opt_config_file" function below.
693
600
new_arg = strdup(p);
694
601
if(new_arg == NULL){
695
error(0, errno, "strdup");
696
exitstatus = EX_OSERR;
603
exitstatus = EXIT_FAILURE;
701
608
custom_argc += 1;
703
char **new_argv = realloc(custom_argv, sizeof(char *)
704
* ((size_t)custom_argc + 1));
705
if(new_argv == NULL){
706
error(0, errno, "realloc");
707
exitstatus = EX_OSERR;
712
custom_argv = new_argv;
609
custom_argv = realloc(custom_argv, sizeof(char *)
610
* ((unsigned int) custom_argc + 1));
611
if(custom_argv == NULL){
613
exitstatus = EXIT_FAILURE;
715
617
custom_argv[custom_argc-1] = new_arg;
716
custom_argv[custom_argc] = NULL;
618
custom_argv[custom_argc] = NULL;
720
ret = fclose(conffp);
721
} while(ret == EOF and errno == EINTR);
723
error(0, errno, "fclose");
724
exitstatus = EX_IOERR;
729
623
/* Check for harmful errors and go to fallback. Other errors might
730
624
not affect opening plugins */
731
625
if(errno == EMFILE or errno == ENFILE or errno == ENOMEM){
732
error(0, errno, "fopen");
733
exitstatus = EX_OSERR;
627
exitstatus = EXIT_FAILURE;
737
/* If there were any arguments from the configuration file, pass
738
them to parser as command line arguments */
631
/* If there was any arguments from configuration file,
632
pass them to parser as command arguments */
739
633
if(custom_argv != NULL){
740
ret = argp_parse(&argp, custom_argc, custom_argv,
741
ARGP_IN_ORDER | ARGP_NO_EXIT | ARGP_NO_HELP,
749
error(0, errno, "argp_parse");
750
exitstatus = EX_OSERR;
753
exitstatus = EX_CONFIG;
634
ret = argp_parse(&argp, custom_argc, custom_argv, ARGP_IN_ORDER,
636
if(ret == ARGP_ERR_UNKNOWN){
637
fprintf(stderr, "Unknown error while parsing arguments\n");
638
exitstatus = EXIT_FAILURE;
758
643
/* Parse actual command line arguments, to let them override the
760
ret = argp_parse(&argp, argc, argv,
761
ARGP_IN_ORDER | ARGP_NO_EXIT | ARGP_NO_HELP,
769
error(0, errno, "argp_parse");
770
exitstatus = EX_OSERR;
773
exitstatus = EX_USAGE;
778
char *pluginhelperenv;
780
ret = asprintf(&pluginhelperenv, "MANDOSPLUGINHELPERDIR=%s",
781
pluginhelperdir != NULL ? pluginhelperdir : PHDIR);
783
bret = add_environment(getplugin(NULL), pluginhelperenv, true);
785
if(ret == -1 or not bret){
786
error(0, errno, "Failed to set MANDOSPLUGINHELPERDIR"
787
" environment variable to \"%s\" for all plugins\n",
788
pluginhelperdir != NULL ? pluginhelperdir : PHDIR);
791
free(pluginhelperenv);
645
ret = argp_parse(&argp, argc, argv, ARGP_IN_ORDER, 0, NULL);
646
if(ret == ARGP_ERR_UNKNOWN){
647
fprintf(stderr, "Unknown error while parsing arguments\n");
648
exitstatus = EXIT_FAILURE;
796
for(plugin *p = plugin_list; p != NULL; p = p->next){
653
for(plugin *p = plugin_list; p != NULL; p=p->next){
797
654
fprintf(stderr, "Plugin: %s has %d arguments\n",
798
655
p->name ? p->name : "Global", p->argc - 1);
799
656
for(char **a = p->argv; *a != NULL; a++){
810
/* Work around Debian bug #633582:
811
<https://bugs.debian.org/633582> */
812
int plugindir_fd = open(/* plugindir or */ PDIR, O_RDONLY);
813
if(plugindir_fd == -1){
815
error(0, errno, "open(\"" PDIR "\")");
818
ret = (int)TEMP_FAILURE_RETRY(fstat(plugindir_fd, &st));
820
error(0, errno, "fstat");
822
if(S_ISDIR(st.st_mode) and st.st_uid == 0 and st.st_gid == 0){
823
ret = fchown(plugindir_fd, uid, gid);
825
error(0, errno, "fchown");
833
/* Lower permissions */
666
/* Strip permissions down to nobody */
836
error(0, errno, "setgid");
838
671
ret = setuid(uid);
840
error(0, errno, "setuid");
843
/* Open plugin directory with close_on_exec flag */
676
if(plugindir == NULL){
679
dir = opendir(plugindir);
683
perror("Could not open plugin dir");
684
exitstatus = EXIT_FAILURE;
688
/* Set the FD_CLOEXEC flag on the directory, if possible */
845
dir_fd = open(plugindir != NULL ? plugindir : PDIR, O_RDONLY |
848
#else /* not O_CLOEXEC */
850
#endif /* not O_CLOEXEC */
853
error(0, errno, "Could not open plugin dir");
854
exitstatus = EX_UNAVAILABLE;
859
/* Set the FD_CLOEXEC flag on the directory */
860
ret = set_cloexec_flag(dir_fd);
862
error(0, errno, "set_cloexec_flag");
863
exitstatus = EX_OSERR;
866
#endif /* O_CLOEXEC */
869
int good_name(const struct dirent * const dirent){
870
const char * const patterns[] = { ".*", "#*#", "*~", "*.dpkg-new",
871
"*.dpkg-old", "*.dpkg-bak",
872
"*.dpkg-divert", NULL };
874
#pragma GCC diagnostic push
875
#pragma GCC diagnostic ignored "-Wcast-qual"
877
for(const char **pat = (const char **)patterns;
878
*pat != NULL; pat++){
880
#pragma GCC diagnostic pop
882
if(fnmatch(*pat, dirent->d_name, FNM_FILE_NAME | FNM_PERIOD)
885
fprintf(stderr, "Ignoring plugin dir entry \"%s\""
886
" matching pattern %s\n", dirent->d_name, *pat);
690
int dir_fd = dirfd(dir);
692
ret = set_cloexec_flag(dir_fd);
694
perror("set_cloexec_flag");
695
exitstatus = EXIT_FAILURE;
894
int numplugins = scandirat(dir_fd, ".", &direntries, good_name,
896
if(numplugins == -1){
897
error(0, errno, "Could not scan plugin dir");
899
exitstatus = EX_OSERR;
903
701
FD_ZERO(&rfds_all);
905
703
/* Read and execute any executable in the plugin directory*/
906
for(int i = 0; i < numplugins; i++){
908
int plugin_fd = openat(dir_fd, direntries[i]->d_name, O_RDONLY);
910
error(0, errno, "Could not open plugin");
705
dirst = readdir(dir);
707
/* All directory entries have been processed */
711
exitstatus = EXIT_FAILURE;
717
d_name_len = strlen(dirst->d_name);
719
/* Ignore dotfiles, backup files and other junk */
721
bool bad_name = false;
723
const char const *bad_prefixes[] = { ".", "#", NULL };
725
const char const *bad_suffixes[] = { "~", "#", ".dpkg-new",
728
".dpkg-divert", NULL };
729
for(const char **pre = bad_prefixes; *pre != NULL; pre++){
730
size_t pre_len = strlen(*pre);
731
if((d_name_len >= pre_len)
732
and strncmp((dirst->d_name), *pre, pre_len) == 0){
734
fprintf(stderr, "Ignoring plugin dir entry \"%s\""
735
" with bad prefix %s\n", dirst->d_name, *pre);
744
for(const char **suf = bad_suffixes; *suf != NULL; suf++){
745
size_t suf_len = strlen(*suf);
746
if((d_name_len >= suf_len)
747
and (strcmp((dirst->d_name)+d_name_len-suf_len, *suf)
750
fprintf(stderr, "Ignoring plugin dir entry \"%s\""
751
" with bad suffix %s\n", dirst->d_name, *suf);
764
if(plugindir == NULL){
765
ret = asprintf(&filename, PDIR "/%s", dirst->d_name);
767
ret = asprintf(&filename, "%s/%s", plugindir, dirst->d_name);
914
ret = (int)TEMP_FAILURE_RETRY(fstat(plugin_fd, &st));
774
ret = stat(filename, &st);
916
error(0, errno, "stat");
922
781
/* Ignore non-executable files */
923
if(not S_ISREG(st.st_mode)
924
or (TEMP_FAILURE_RETRY(faccessat(dir_fd, direntries[i]->d_name,
782
if(not S_ISREG(st.st_mode) or (access(filename, X_OK) != 0)){
927
fprintf(stderr, "Ignoring plugin dir entry \"%s/%s\""
928
" with bad type or mode\n",
929
plugindir != NULL ? plugindir : PDIR,
930
direntries[i]->d_name);
784
fprintf(stderr, "Ignoring plugin dir entry \"%s\""
785
" with bad type or mode\n", filename);
937
plugin *p = getplugin(direntries[i]->d_name);
791
plugin *p = getplugin(dirst->d_name);
939
error(0, errno, "getplugin");
946
799
fprintf(stderr, "Ignoring disabled plugin \"%s\"\n",
947
direntries[i]->d_name);
957
809
for(char **a = g->argv + 1; *a != NULL; a++){
958
810
if(not add_argument(p, *a)){
959
error(0, errno, "add_argument");
811
perror("add_argument");
962
814
/* Add global environment variables */
963
815
for(char **e = g->environ; *e != NULL; e++){
964
816
if(not add_environment(p, *e, false)){
965
error(0, errno, "add_environment");
817
perror("add_environment");
970
/* If this plugin has any environment variables, we need to
971
duplicate the environment from this process, too. */
822
/* If this plugin has any environment variables, we will call
823
using execve and need to duplicate the environment from this
972
825
if(p->environ[0] != NULL){
973
826
for(char **e = environ; *e != NULL; e++){
974
827
if(not add_environment(p, *e, false)){
975
error(0, errno, "add_environment");
828
perror("add_environment");
982
ret = (int)TEMP_FAILURE_RETRY(pipe(pipefd));
983
#else /* O_CLOEXEC */
984
ret = (int)TEMP_FAILURE_RETRY(pipe2(pipefd, O_CLOEXEC));
985
#endif /* O_CLOEXEC */
987
error(0, errno, "pipe");
988
exitstatus = EX_OSERR;
992
if(pipefd[0] >= FD_SETSIZE){
993
fprintf(stderr, "pipe()[0] (%d) >= FD_SETSIZE (%d)", pipefd[0],
997
exitstatus = EX_OSERR;
837
exitstatus = EXIT_FAILURE;
1002
840
/* Ask OS to automatic close the pipe on exec */
1003
841
ret = set_cloexec_flag(pipefd[0]);
1005
error(0, errno, "set_cloexec_flag");
1008
exitstatus = EX_OSERR;
1009
free(direntries[i]);
843
perror("set_cloexec_flag");
844
exitstatus = EXIT_FAILURE;
1012
847
ret = set_cloexec_flag(pipefd[1]);
1014
error(0, errno, "set_cloexec_flag");
1017
exitstatus = EX_OSERR;
1018
free(direntries[i]);
849
perror("set_cloexec_flag");
850
exitstatus = EXIT_FAILURE;
1021
#endif /* not O_CLOEXEC */
1022
853
/* Block SIGCHLD until process is safely in process list */
1023
ret = (int)TEMP_FAILURE_RETRY(sigprocmask(SIG_BLOCK,
1024
&sigchld_action.sa_mask,
854
ret = sigprocmask(SIG_BLOCK, &sigchld_action.sa_mask, NULL);
1027
error(0, errno, "sigprocmask");
1028
exitstatus = EX_OSERR;
1029
free(direntries[i]);
856
perror("sigprocmask");
857
exitstatus = EXIT_FAILURE;
1032
860
/* Starting a new process to be watched */
1036
} while(pid == -1 and errno == EINTR);
1038
error(0, errno, "fork");
1039
TEMP_FAILURE_RETRY(sigprocmask(SIG_UNBLOCK,
1040
&sigchld_action.sa_mask, NULL));
1043
exitstatus = EX_OSERR;
1044
free(direntries[i]);
864
exitstatus = EXIT_FAILURE;
1048
868
/* this is the child process */
1049
869
ret = sigaction(SIGCHLD, &old_sigchld_action, NULL);
1051
error(0, errno, "sigaction");
1054
874
ret = sigprocmask(SIG_UNBLOCK, &sigchld_action.sa_mask, NULL);
1056
error(0, errno, "sigprocmask");
876
perror("sigprocmask");
1060
880
ret = dup2(pipefd[1], STDOUT_FILENO); /* replace our stdout */
1062
error(0, errno, "dup2");
1066
if(fexecve(plugin_fd, p->argv,
1067
(p->environ[0] != NULL) ? p->environ : environ) < 0){
1068
error(0, errno, "fexecve for %s/%s",
1069
plugindir != NULL ? plugindir : PDIR,
1070
direntries[i]->d_name);
887
/* If dir has no file descriptor, we could not set FD_CLOEXEC
888
above and must now close it manually here. */
891
if(p->environ[0] == NULL){
892
if(execv(filename, p->argv) < 0){
897
if(execve(filename, p->argv, p->environ) < 0){
1075
904
/* Parent process */
1076
905
close(pipefd[1]); /* Close unused write end of pipe */
1078
plugin *new_plugin = getplugin(direntries[i]->d_name);
907
plugin *new_plugin = getplugin(dirst->d_name);
1079
908
if(new_plugin == NULL){
1080
error(0, errno, "getplugin");
1081
ret = (int)(TEMP_FAILURE_RETRY
1082
(sigprocmask(SIG_UNBLOCK, &sigchld_action.sa_mask,
910
ret = sigprocmask(SIG_UNBLOCK, &sigchld_action.sa_mask, NULL);
1085
error(0, errno, "sigprocmask");
912
perror("sigprocmask");
1087
exitstatus = EX_OSERR;
1088
free(direntries[i]);
914
exitstatus = EXIT_FAILURE;
1091
free(direntries[i]);
1093
918
new_plugin->pid = pid;
1094
919
new_plugin->fd = pipefd[0];
1096
921
/* Unblock SIGCHLD so signal handler can be run if this process
1097
922
has already completed */
1098
ret = (int)TEMP_FAILURE_RETRY(sigprocmask(SIG_UNBLOCK,
1099
&sigchld_action.sa_mask,
923
ret = sigprocmask(SIG_UNBLOCK, &sigchld_action.sa_mask, NULL);
1102
error(0, errno, "sigprocmask");
1103
exitstatus = EX_OSERR;
925
perror("sigprocmask");
926
exitstatus = EXIT_FAILURE;
1146
967
if(not WIFEXITED(proc->status)
1147
968
or WEXITSTATUS(proc->status) != 0){
1148
969
/* Bad exit by plugin */
1151
972
if(WIFEXITED(proc->status)){
1152
fprintf(stderr, "Plugin %s [%" PRIdMAX "] exited with"
1153
" status %d\n", proc->name,
1154
(intmax_t) (proc->pid),
973
fprintf(stderr, "Plugin %" PRIdMAX " exited with status"
974
" %d\n", (intmax_t) (proc->pid),
1155
975
WEXITSTATUS(proc->status));
1156
976
} else if(WIFSIGNALED(proc->status)){
1157
fprintf(stderr, "Plugin %s [%" PRIdMAX "] killed by"
1158
" signal %d: %s\n", proc->name,
1159
(intmax_t) (proc->pid),
1160
WTERMSIG(proc->status),
1161
strsignal(WTERMSIG(proc->status)));
977
fprintf(stderr, "Plugin %" PRIdMAX " killed by signal"
978
" %d\n", (intmax_t) (proc->pid),
979
WTERMSIG(proc->status));
980
} else if(WCOREDUMP(proc->status)){
981
fprintf(stderr, "Plugin %" PRIdMAX " dumped core\n",
982
(intmax_t) (proc->pid));
1165
986
/* Remove the plugin */
1166
987
FD_CLR(proc->fd, &rfds_all);
1168
989
/* Block signal while modifying process_list */
1169
ret = (int)TEMP_FAILURE_RETRY(sigprocmask
1171
&sigchld_action.sa_mask,
990
ret = sigprocmask(SIG_BLOCK, &sigchld_action.sa_mask, NULL);
1174
error(0, errno, "sigprocmask");
1175
exitstatus = EX_OSERR;
992
perror("sigprocmask");
993
exitstatus = EXIT_FAILURE;