1
/* -*- coding: utf-8 -*- */
1
/* -*- coding: utf-8; mode: c; mode: orgtbl -*- */
3
3
* Mandos plugin runner - Run Mandos plugins
5
* Copyright © 2008,2009 Teddy Hogeborn
6
* Copyright © 2008,2009 Björn Påhlsson
8
* This program is free software: you can redistribute it and/or
9
* modify it under the terms of the GNU General Public License as
10
* published by the Free Software Foundation, either version 3 of the
11
* License, or (at your option) any later version.
13
* This program is distributed in the hope that it will be useful, but
5
* Copyright © 2008-2021 Teddy Hogeborn
6
* Copyright © 2008-2021 Björn Påhlsson
8
* This file is part of Mandos.
10
* Mandos is free software: you can redistribute it and/or modify it
11
* under the terms of the GNU General Public License as published by
12
* the Free Software Foundation, either version 3 of the License, or
13
* (at your option) any later version.
15
* Mandos is distributed in the hope that it will be useful, but
14
16
* WITHOUT ANY WARRANTY; without even the implied warranty of
15
17
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
16
18
* General Public License for more details.
18
20
* You should have received a copy of the GNU General Public License
19
* along with this program. If not, see
20
* <http://www.gnu.org/licenses/>.
21
* along with Mandos. If not, see <http://www.gnu.org/licenses/>.
22
* Contact the authors at <mandos@fukt.bsnet.se>.
23
* Contact the authors at <mandos@recompile.se>.
25
#define _GNU_SOURCE /* TEMP_FAILURE_RETRY(), getline(),
26
#define _GNU_SOURCE /* strchrnul(), TEMP_FAILURE_RETRY(),
27
getline(), asprintf(), O_CLOEXEC,
28
scandirat(), pipe2() */
29
#include <argp.h> /* argp_program_version,
30
argp_program_bug_address,
32
struct argp_state, argp_error(),
33
ARGP_NO_EXIT, argp_state_help,
35
ARGP_HELP_USAGE, ARGP_HELP_EXIT_OK,
36
ARGP_KEY_ARG, ARGP_ERR_UNKNOWN,
37
struct argp, argp_parse(),
38
ARGP_IN_ORDER, ARGP_NO_HELP */
39
#include <stdbool.h> /* bool, false, true */
40
#include <sys/types.h> /* pid_t, sig_atomic_t, uid_t, gid_t,
41
getuid(), setgid(), setuid() */
27
42
#include <stddef.h> /* size_t, NULL */
28
#include <stdlib.h> /* malloc(), exit(), EXIT_FAILURE,
29
EXIT_SUCCESS, realloc() */
30
#include <stdbool.h> /* bool, true, false */
31
#include <stdio.h> /* perror, fileno(), fprintf(),
32
stderr, STDOUT_FILENO */
33
#include <sys/types.h> /* DIR, opendir(), stat(), struct
34
stat, waitpid(), WIFEXITED(),
35
WEXITSTATUS(), wait(), pid_t,
36
uid_t, gid_t, getuid(), getgid(),
38
#include <sys/select.h> /* fd_set, select(), FD_ZERO(),
39
FD_SET(), FD_ISSET(), FD_CLR */
40
#include <sys/wait.h> /* wait(), waitpid(), WIFEXITED(),
42
#include <sys/stat.h> /* struct stat, stat(), S_ISREG() */
43
#include <iso646.h> /* and, or, not */
44
#include <dirent.h> /* DIR, struct dirent, opendir(),
45
readdir(), closedir(), dirfd() */
46
#include <unistd.h> /* struct stat, stat(), S_ISREG(),
47
fcntl(), setuid(), setgid(),
48
F_GETFD, F_SETFD, FD_CLOEXEC,
49
access(), pipe(), fork(), close()
50
dup2(), STDOUT_FILENO, _exit(),
51
execv(), write(), read(),
43
#include <iso646.h> /* or, and, not */
44
#include <string.h> /* strcmp(), strdup(), strchrnul(),
45
strncmp(), strlen(), strcpy(),
46
strsep(), strchr(), strsignal() */
47
#include <stdlib.h> /* malloc(), free(), reallocarray(),
48
realloc(), EXIT_SUCCESS */
49
#include <errno.h> /* errno, EINTR, ENOMEM, ECHILD,
50
error_t, EINVAL, EMFILE, ENFILE,
52
#include <stdint.h> /* SIZE_MAX */
53
#define _GNU_SOURCE /* strchrnul(), TEMP_FAILURE_RETRY(),
54
getline(), asprintf(), O_CLOEXEC,
55
scandirat(), pipe2() */
56
#include <unistd.h> /* TEMP_FAILURE_RETRY(), ssize_t,
57
write(), STDOUT_FILENO, uid_t,
58
gid_t, getuid(), fchown(), close(),
59
symlink(), setgid(), setuid(),
60
faccessat(), X_OK, pipe(), pipe2(),
61
fork(), _exit(), dup2(), fexecve(),
53
63
#include <fcntl.h> /* fcntl(), F_GETFD, F_SETFD,
55
#include <string.h> /* strsep, strlen(), asprintf() */
56
#include <errno.h> /* errno */
57
#include <argp.h> /* struct argp_option, struct
58
argp_state, struct argp,
59
argp_parse(), ARGP_ERR_UNKNOWN,
60
ARGP_KEY_END, ARGP_KEY_ARG,
62
#include <signal.h> /* struct sigaction, sigemptyset(),
63
sigaddset(), sigaction(),
64
sigprocmask(), SIG_BLOCK, SIGCHLD,
65
SIG_UNBLOCK, kill() */
66
#include <errno.h> /* errno, EBADF */
64
FD_CLOEXEC, open(), O_RDONLY,
65
O_CLOEXEC, openat() */
66
#include <sys/wait.h> /* waitpid(), WNOHANG, WIFEXITED(),
67
WEXITSTATUS(), WIFSIGNALED(),
69
#include <error.h> /* error() */
70
#include <stdio.h> /* FILE, fprintf(), fopen(),
71
getline(), fclose(), EOF,
73
#include <dirent.h> /* struct dirent, scandirat(),
75
#include <sys/stat.h> /* struct stat, fstat(), S_ISDIR(),
77
#include <sys/select.h> /* fd_set, FD_ZERO(), FD_SETSIZE,
78
FD_SET(), select(), FD_CLR(),
80
#include <signal.h> /* struct sigaction, SA_NOCLDSTOP,
81
sigemptyset(), sigaddset(),
82
SIGCHLD, sigprocmask(), SIG_BLOCK,
83
SIG_UNBLOCK, kill(), SIGTERM */
84
#include <sysexits.h> /* EX_OSERR, EX_USAGE, EX_IOERR,
85
EX_CONFIG, EX_UNAVAILABLE, EX_OK */
86
#include <inttypes.h> /* intmax_t, strtoimax(), PRIdMAX */
87
#include <fnmatch.h> /* fnmatch(), FNM_FILE_NAME,
88
FNM_PERIOD, FNM_NOMATCH */
68
90
#define BUFFER_SIZE 256
70
92
#define PDIR "/lib/mandos/plugins.d"
93
#define PHDIR "/lib/mandos/plugin-helpers"
71
94
#define AFILE "/conf/conf.d/mandos/plugin-runner.conf"
73
96
const char *argp_program_version = "plugin-runner " VERSION;
74
const char *argp_program_bug_address = "<mandos@fukt.bsnet.se>";
97
const char *argp_program_bug_address = "<mandos@recompile.se>";
76
99
typedef struct plugin{
77
100
char *name; /* can be NULL or any plugin name */
369
442
.doc = "Group ID the plugins will run as", .group = 3 },
370
443
{ .name = "debug", .key = 132,
371
444
.doc = "Debug mode", .group = 4 },
445
{ .name = "plugin-helper-dir", .key = 133,
447
.doc = "Specify a different plugin helper directory",
450
* These reproduce what we would get without ARGP_NO_HELP
452
{ .name = "help", .key = '?',
453
.doc = "Give this help list", .group = -1 },
454
{ .name = "usage", .key = -3,
455
.doc = "Give a short usage message", .group = -1 },
456
{ .name = "version", .key = 'V',
457
.doc = "Print program version", .group = -1 },
375
error_t parse_opt(int key, char *arg, __attribute__((unused))
376
struct argp_state *state) {
461
__attribute__((nonnull(3)))
462
error_t parse_opt(int key, char *arg, struct argp_state *state){
378
467
case 'g': /* --global-options */
381
while((p = strsep(&arg, ",")) != NULL){
385
if(not add_argument(getplugin(NULL), p)){
386
perror("add_argument");
387
return ARGP_ERR_UNKNOWN;
470
while((plugin_option = strsep(&arg, ",")) != NULL){
471
if(not add_argument(getplugin(NULL), plugin_option)){
392
478
case 'G': /* --global-env */
396
if(not add_environment(getplugin(NULL), arg, true)){
397
perror("add_environment");
479
if(add_environment(getplugin(NULL), arg, true)){
400
483
case 'o': /* --options-for */
402
char *p_name = strsep(&arg, ":");
403
if(p_name[0] == '\0' or arg == NULL){
406
char *opt = strsep(&arg, ":");
407
if(opt[0] == '\0' or opt == NULL){
411
while((p = strsep(&opt, ",")) != NULL){
415
if(not add_argument(getplugin(p_name), p)){
416
perror("add_argument");
417
return ARGP_ERR_UNKNOWN;
485
char *option_list = strchr(arg, ':');
486
if(option_list == NULL){
487
argp_error(state, "No colon in \"%s\"", arg);
494
argp_error(state, "Empty plugin name");
499
while((option = strsep(&option_list, ",")) != NULL){
500
if(not add_argument(getplugin(arg), option)){
422
507
case 'E': /* --env-for */
427
509
char *envdef = strchr(arg, ':');
428
510
if(envdef == NULL){
511
argp_error(state, "No colon in \"%s\"", arg);
432
if(not add_environment(getplugin(arg), envdef+1, true)){
433
perror("add_environment");
518
argp_error(state, "Empty plugin name");
522
if(add_environment(getplugin(arg), envdef, true)){
437
527
case 'd': /* --disable */
439
529
plugin *p = getplugin(arg);
441
return ARGP_ERR_UNKNOWN;
446
536
case 'e': /* --enable */
448
538
plugin *p = getplugin(arg);
450
return ARGP_ERR_UNKNOWN;
455
545
case 128: /* --plugin-dir */
457
547
plugindir = strdup(arg);
458
if(plugindir == NULL){
548
if(plugindir != NULL){
462
552
case 129: /* --config-file */
463
553
/* This is already done by parse_opt_config_file() */
465
555
case 130: /* --userid */
466
/* In the GNU C library, uid_t is always unsigned int */
467
ret = sscanf(arg, "%u", &uid);
469
fprintf(stderr, "Bad user ID number: \"%s\", using %u\n", arg,
556
tmp_id = strtoimax(arg, &tmp, 10);
557
if(errno != 0 or tmp == arg or *tmp != '\0'
558
or tmp_id != (uid_t)tmp_id){
559
argp_error(state, "Bad user ID number: \"%s\", using %"
560
PRIdMAX, arg, (intmax_t)uid);
473
566
case 131: /* --groupid */
474
/* In the GNU C library, gid_t is always unsigned int */
475
ret = sscanf(arg, "%u", &gid);
477
fprintf(stderr, "Bad group ID number: \"%s\", using %u\n",
567
tmp_id = strtoimax(arg, &tmp, 10);
568
if(errno != 0 or tmp == arg or *tmp != '\0'
569
or tmp_id != (gid_t)tmp_id){
570
argp_error(state, "Bad group ID number: \"%s\", using %"
571
PRIdMAX, arg, (intmax_t)gid);
481
577
case 132: /* --debug */
580
case 133: /* --plugin-helper-dir */
581
free(pluginhelperdir);
582
pluginhelperdir = strdup(arg);
583
if(pluginhelperdir != NULL){
588
* These reproduce what we would get without ARGP_NO_HELP
590
case '?': /* --help */
591
state->flags &= ~(unsigned int)ARGP_NO_EXIT; /* force exit */
592
argp_state_help(state, state->out_stream, ARGP_HELP_STD_HELP);
593
__builtin_unreachable();
594
case -3: /* --usage */
595
state->flags &= ~(unsigned int)ARGP_NO_EXIT; /* force exit */
596
argp_state_help(state, state->out_stream,
597
ARGP_HELP_USAGE | ARGP_HELP_EXIT_OK);
598
__builtin_unreachable();
599
case 'V': /* --version */
600
fprintf(state->out_stream, "%s\n", argp_program_version);
485
604
* When adding more options before this line, remember to also add a
486
605
* "case" to the "parse_opt_config_file" function below.
591
726
new_arg = strdup(p);
592
727
if(new_arg == NULL){
594
exitstatus = EXIT_FAILURE;
728
error(0, errno, "strdup");
729
exitstatus = EX_OSERR;
599
734
custom_argc += 1;
600
custom_argv = realloc(custom_argv, sizeof(char *)
601
* ((unsigned int) custom_argc + 1));
602
if(custom_argv == NULL){
604
exitstatus = EXIT_FAILURE;
736
#if defined(__GLIBC_PREREQ) and __GLIBC_PREREQ(2, 26)
737
char **new_argv = reallocarray(custom_argv, (size_t)custom_argc + 1,
740
char **new_argv = NULL;
741
if(((size_t)custom_argc + 1) > (SIZE_MAX / sizeof(char *))){
745
new_argv = realloc(custom_argv, ((size_t)custom_argc + 1)
749
if(new_argv == NULL){
750
error(0, errno, "reallocarray");
751
exitstatus = EX_OSERR;
756
custom_argv = new_argv;
608
759
custom_argv[custom_argc-1] = new_arg;
609
custom_argv[custom_argc] = NULL;
760
custom_argv[custom_argc] = NULL;
764
ret = fclose(conffp);
765
} while(ret == EOF and errno == EINTR);
767
error(0, errno, "fclose");
768
exitstatus = EX_IOERR;
614
773
/* Check for harmful errors and go to fallback. Other errors might
615
774
not affect opening plugins */
616
775
if(errno == EMFILE or errno == ENFILE or errno == ENOMEM){
618
exitstatus = EXIT_FAILURE;
776
error(0, errno, "fopen");
777
exitstatus = EX_OSERR;
622
/* If there was any arguments from configuration file,
623
pass them to parser as command arguments */
781
/* If there were any arguments from the configuration file, pass
782
them to parser as command line arguments */
624
783
if(custom_argv != NULL){
625
ret = argp_parse(&argp, custom_argc, custom_argv, ARGP_IN_ORDER,
627
if(ret == ARGP_ERR_UNKNOWN){
628
fprintf(stderr, "Unknown error while parsing arguments\n");
629
exitstatus = EXIT_FAILURE;
784
ret = argp_parse(&argp, custom_argc, custom_argv,
785
ARGP_IN_ORDER | ARGP_NO_EXIT | ARGP_NO_HELP,
793
error(0, errno, "argp_parse");
794
exitstatus = EX_OSERR;
797
exitstatus = EX_CONFIG;
634
802
/* Parse actual command line arguments, to let them override the
636
ret = argp_parse(&argp, argc, argv, ARGP_IN_ORDER, 0, NULL);
637
if(ret == ARGP_ERR_UNKNOWN){
638
fprintf(stderr, "Unknown error while parsing arguments\n");
639
exitstatus = EXIT_FAILURE;
804
ret = argp_parse(&argp, argc, argv,
805
ARGP_IN_ORDER | ARGP_NO_EXIT | ARGP_NO_HELP,
813
error(0, errno, "argp_parse");
814
exitstatus = EX_OSERR;
817
exitstatus = EX_USAGE;
822
char *pluginhelperenv;
824
ret = asprintf(&pluginhelperenv, "MANDOSPLUGINHELPERDIR=%s",
825
pluginhelperdir != NULL ? pluginhelperdir : PHDIR);
827
bret = add_environment(getplugin(NULL), pluginhelperenv, true);
829
if(ret == -1 or not bret){
830
error(0, errno, "Failed to set MANDOSPLUGINHELPERDIR"
831
" environment variable to \"%s\" for all plugins\n",
832
pluginhelperdir != NULL ? pluginhelperdir : PHDIR);
835
free(pluginhelperenv);
644
for(plugin *p = plugin_list; p != NULL; p=p->next){
840
for(plugin *p = plugin_list; p != NULL; p = p->next){
645
841
fprintf(stderr, "Plugin: %s has %d arguments\n",
646
842
p->name ? p->name : "Global", p->argc - 1);
647
843
for(char **a = p->argv; *a != NULL; a++){
648
844
fprintf(stderr, "\tArg: %s\n", *a);
650
fprintf(stderr, "...and %u environment variables\n", p->envc);
846
fprintf(stderr, "...and %d environment variables\n", p->envc);
651
847
for(char **a = p->environ; *a != NULL; a++){
652
848
fprintf(stderr, "\t%s\n", *a);
657
/* Strip permissions down to nobody */
854
/* Work around Debian bug #633582:
855
<https://bugs.debian.org/633582> */
856
int plugindir_fd = open(/* plugindir or */ PDIR, O_RDONLY);
857
if(plugindir_fd == -1){
859
error(0, errno, "open(\"" PDIR "\")");
862
ret = (int)TEMP_FAILURE_RETRY(fstat(plugindir_fd, &st));
864
error(0, errno, "fstat");
866
if(S_ISDIR(st.st_mode) and st.st_uid == 0 and st.st_gid == 0){
867
ret = fchown(plugindir_fd, uid, gid);
869
error(0, errno, "fchown");
876
/* Work around Debian bug #981302
877
<https://bugs.debian.org/981302> */
878
if(lstat("/dev/fd", &st) != 0 and errno == ENOENT){
879
ret = symlink("/proc/self/fd", "/dev/fd");
881
error(0, errno, "Failed to create /dev/fd symlink");
886
/* Lower permissions */
889
error(0, errno, "setgid");
658
891
ret = setuid(uid);
667
if(plugindir == NULL){
670
dir = opendir(plugindir);
674
perror("Could not open plugin dir");
675
exitstatus = EXIT_FAILURE;
679
/* Set the FD_CLOEXEC flag on the directory, if possible */
893
error(0, errno, "setuid");
896
/* Open plugin directory with close_on_exec flag */
681
int dir_fd = dirfd(dir);
683
ret = set_cloexec_flag(dir_fd);
685
perror("set_cloexec_flag");
686
exitstatus = EXIT_FAILURE;
898
dir_fd = open(plugindir != NULL ? plugindir : PDIR, O_RDONLY |
901
#else /* not O_CLOEXEC */
903
#endif /* not O_CLOEXEC */
906
error(0, errno, "Could not open plugin dir");
907
exitstatus = EX_UNAVAILABLE;
912
/* Set the FD_CLOEXEC flag on the directory */
913
ret = set_cloexec_flag(dir_fd);
915
error(0, errno, "set_cloexec_flag");
916
exitstatus = EX_OSERR;
919
#endif /* O_CLOEXEC */
922
int good_name(const struct dirent * const dirent){
923
const char * const patterns[] = { ".*", "#*#", "*~", "*.dpkg-new",
924
"*.dpkg-old", "*.dpkg-bak",
925
"*.dpkg-divert", NULL };
927
#pragma GCC diagnostic push
928
#pragma GCC diagnostic ignored "-Wcast-qual"
930
for(const char **pat = (const char **)patterns;
931
*pat != NULL; pat++){
933
#pragma GCC diagnostic pop
935
if(fnmatch(*pat, dirent->d_name, FNM_FILE_NAME | FNM_PERIOD)
938
fprintf(stderr, "Ignoring plugin dir entry \"%s\""
939
" matching pattern %s\n", dirent->d_name, *pat);
947
int numplugins = scandirat(dir_fd, ".", &direntries, good_name,
949
if(numplugins == -1){
950
error(0, errno, "Could not scan plugin dir");
952
exitstatus = EX_OSERR;
692
956
FD_ZERO(&rfds_all);
694
958
/* Read and execute any executable in the plugin directory*/
696
dirst = readdir(dir);
698
/* All directory entries have been processed */
702
exitstatus = EXIT_FAILURE;
708
d_name_len = strlen(dirst->d_name);
710
/* Ignore dotfiles, backup files and other junk */
712
bool bad_name = false;
714
const char const *bad_prefixes[] = { ".", "#", NULL };
716
const char const *bad_suffixes[] = { "~", "#", ".dpkg-new",
719
".dpkg-divert", NULL };
720
for(const char **pre = bad_prefixes; *pre != NULL; pre++){
721
size_t pre_len = strlen(*pre);
722
if((d_name_len >= pre_len)
723
and strncmp((dirst->d_name), *pre, pre_len) == 0){
725
fprintf(stderr, "Ignoring plugin dir entry \"%s\""
726
" with bad prefix %s\n", dirst->d_name, *pre);
735
for(const char **suf = bad_suffixes; *suf != NULL; suf++){
736
size_t suf_len = strlen(*suf);
737
if((d_name_len >= suf_len)
738
and (strcmp((dirst->d_name)+d_name_len-suf_len, *suf)
741
fprintf(stderr, "Ignoring plugin dir entry \"%s\""
742
" with bad suffix %s\n", dirst->d_name, *suf);
755
if(plugindir == NULL){
756
ret = asprintf(&filename, PDIR "/%s", dirst->d_name);
758
ret = asprintf(&filename, "%s/%s", plugindir, dirst->d_name);
959
for(int i = 0; i < numplugins; i++){
961
int plugin_fd = openat(dir_fd, direntries[i]->d_name, O_RDONLY);
963
error(0, errno, "Could not open plugin");
765
ret = stat(filename, &st);
967
ret = (int)TEMP_FAILURE_RETRY(fstat(plugin_fd, &st));
969
error(0, errno, "stat");
772
975
/* Ignore non-executable files */
773
if(not S_ISREG(st.st_mode) or (access(filename, X_OK) != 0)){
976
if(not S_ISREG(st.st_mode)
977
or (TEMP_FAILURE_RETRY(faccessat(dir_fd, direntries[i]->d_name,
775
fprintf(stderr, "Ignoring plugin dir entry \"%s\""
776
" with bad type or mode\n", filename);
980
fprintf(stderr, "Ignoring plugin dir entry \"%s/%s\""
981
" with bad type or mode\n",
982
plugindir != NULL ? plugindir : PDIR,
983
direntries[i]->d_name);
782
plugin *p = getplugin(dirst->d_name);
990
plugin *p = getplugin(direntries[i]->d_name);
992
error(0, errno, "getplugin");
790
999
fprintf(stderr, "Ignoring disabled plugin \"%s\"\n",
1000
direntries[i]->d_name);
1003
free(direntries[i]);
800
1010
for(char **a = g->argv + 1; *a != NULL; a++){
801
1011
if(not add_argument(p, *a)){
802
perror("add_argument");
1012
error(0, errno, "add_argument");
805
1015
/* Add global environment variables */
806
1016
for(char **e = g->environ; *e != NULL; e++){
807
1017
if(not add_environment(p, *e, false)){
808
perror("add_environment");
1018
error(0, errno, "add_environment");
813
/* If this plugin has any environment variables, we will call
814
using execve and need to duplicate the environment from this
1023
/* If this plugin has any environment variables, we need to
1024
duplicate the environment from this process, too. */
816
1025
if(p->environ[0] != NULL){
817
1026
for(char **e = environ; *e != NULL; e++){
818
1027
if(not add_environment(p, *e, false)){
819
perror("add_environment");
1028
error(0, errno, "add_environment");
1035
ret = (int)TEMP_FAILURE_RETRY(pipe(pipefd));
1036
#else /* O_CLOEXEC */
1037
ret = (int)TEMP_FAILURE_RETRY(pipe2(pipefd, O_CLOEXEC));
1038
#endif /* O_CLOEXEC */
828
exitstatus = EXIT_FAILURE;
1040
error(0, errno, "pipe");
1041
exitstatus = EX_OSERR;
1042
free(direntries[i]);
1045
if(pipefd[0] >= FD_SETSIZE){
1046
fprintf(stderr, "pipe()[0] (%d) >= FD_SETSIZE (%d)", pipefd[0],
1050
exitstatus = EX_OSERR;
1051
free(direntries[i]);
831
1055
/* Ask OS to automatic close the pipe on exec */
832
1056
ret = set_cloexec_flag(pipefd[0]);
834
perror("set_cloexec_flag");
835
exitstatus = EXIT_FAILURE;
1058
error(0, errno, "set_cloexec_flag");
1061
exitstatus = EX_OSERR;
1062
free(direntries[i]);
838
1065
ret = set_cloexec_flag(pipefd[1]);
840
perror("set_cloexec_flag");
841
exitstatus = EXIT_FAILURE;
1067
error(0, errno, "set_cloexec_flag");
1070
exitstatus = EX_OSERR;
1071
free(direntries[i]);
1074
#endif /* not O_CLOEXEC */
844
1075
/* Block SIGCHLD until process is safely in process list */
845
ret = sigprocmask(SIG_BLOCK, &sigchld_action.sa_mask, NULL);
1076
ret = (int)TEMP_FAILURE_RETRY(sigprocmask(SIG_BLOCK,
1077
&sigchld_action.sa_mask,
847
perror("sigprocmask");
848
exitstatus = EXIT_FAILURE;
1080
error(0, errno, "sigprocmask");
1081
exitstatus = EX_OSERR;
1082
free(direntries[i]);
851
1085
/* Starting a new process to be watched */
1089
} while(pid == -1 and errno == EINTR);
855
exitstatus = EXIT_FAILURE;
1091
error(0, errno, "fork");
1092
TEMP_FAILURE_RETRY(sigprocmask(SIG_UNBLOCK,
1093
&sigchld_action.sa_mask, NULL));
1096
exitstatus = EX_OSERR;
1097
free(direntries[i]);
859
1101
/* this is the child process */
860
1102
ret = sigaction(SIGCHLD, &old_sigchld_action, NULL);
1104
error(0, errno, "sigaction");
865
1107
ret = sigprocmask(SIG_UNBLOCK, &sigchld_action.sa_mask, NULL);
867
perror("sigprocmask");
1109
error(0, errno, "sigprocmask");
871
1113
ret = dup2(pipefd[1], STDOUT_FILENO); /* replace our stdout */
1115
error(0, errno, "dup2");
878
/* If dir has no file descriptor, we could not set FD_CLOEXEC
879
above and must now close it manually here. */
882
if(p->environ[0] == NULL){
883
if(execv(filename, p->argv) < 0){
888
if(execve(filename, p->argv, p->environ) < 0){
1119
if(fexecve(plugin_fd, p->argv,
1120
(p->environ[0] != NULL) ? p->environ : environ) < 0){
1121
error(0, errno, "fexecve for %s/%s",
1122
plugindir != NULL ? plugindir : PDIR,
1123
direntries[i]->d_name);
895
1128
/* Parent process */
896
1129
close(pipefd[1]); /* Close unused write end of pipe */
898
plugin *new_plugin = getplugin(dirst->d_name);
1131
plugin *new_plugin = getplugin(direntries[i]->d_name);
899
1132
if(new_plugin == NULL){
901
ret = sigprocmask(SIG_UNBLOCK, &sigchld_action.sa_mask, NULL);
1133
error(0, errno, "getplugin");
1134
ret = (int)(TEMP_FAILURE_RETRY
1135
(sigprocmask(SIG_UNBLOCK, &sigchld_action.sa_mask,
903
perror("sigprocmask");
1138
error(0, errno, "sigprocmask");
905
exitstatus = EXIT_FAILURE;
1140
exitstatus = EX_OSERR;
1141
free(direntries[i]);
1144
free(direntries[i]);
909
1146
new_plugin->pid = pid;
910
1147
new_plugin->fd = pipefd[0];
1150
fprintf(stderr, "Plugin %s started (PID %" PRIdMAX ")\n",
1151
new_plugin->name, (intmax_t) (new_plugin->pid));
912
1154
/* Unblock SIGCHLD so signal handler can be run if this process
913
1155
has already completed */
914
ret = sigprocmask(SIG_UNBLOCK, &sigchld_action.sa_mask, NULL);
1156
ret = (int)TEMP_FAILURE_RETRY(sigprocmask(SIG_UNBLOCK,
1157
&sigchld_action.sa_mask,
916
perror("sigprocmask");
917
exitstatus = EXIT_FAILURE;
1160
error(0, errno, "sigprocmask");
1161
exitstatus = EX_OSERR;
943
1190
while(plugin_list){
944
1191
fd_set rfds = rfds_all;
945
1192
int select_ret = select(maxfd+1, &rfds, NULL, NULL, NULL);
946
if(select_ret == -1){
948
exitstatus = EXIT_FAILURE;
1193
if(select_ret == -1 and errno != EINTR){
1194
error(0, errno, "select");
1195
exitstatus = EX_OSERR;
951
1198
/* OK, now either a process completed, or something can be read
952
1199
from one of them */
953
1200
for(plugin *proc = plugin_list; proc != NULL;){
954
1201
/* Is this process completely done? */
955
if(proc->eof and proc->completed){
1202
if(proc->completed and proc->eof){
956
1203
/* Only accept the plugin output if it exited cleanly */
957
1204
if(not WIFEXITED(proc->status)
958
1205
or WEXITSTATUS(proc->status) != 0){
959
1206
/* Bad exit by plugin */
962
1209
if(WIFEXITED(proc->status)){
963
fprintf(stderr, "Plugin %u exited with status %d\n",
964
(unsigned int) (proc->pid),
1210
fprintf(stderr, "Plugin %s [%" PRIdMAX "] exited with"
1211
" status %d\n", proc->name,
1212
(intmax_t) (proc->pid),
965
1213
WEXITSTATUS(proc->status));
966
} else if(WIFSIGNALED(proc->status)) {
967
fprintf(stderr, "Plugin %u killed by signal %d\n",
968
(unsigned int) (proc->pid),
969
WTERMSIG(proc->status));
970
} else if(WCOREDUMP(proc->status)){
971
fprintf(stderr, "Plugin %u dumped core\n",
972
(unsigned int) (proc->pid));
1214
} else if(WIFSIGNALED(proc->status)){
1215
fprintf(stderr, "Plugin %s [%" PRIdMAX "] killed by"
1216
" signal %d: %s\n", proc->name,
1217
(intmax_t) (proc->pid),
1218
WTERMSIG(proc->status),
1219
strsignal(WTERMSIG(proc->status)));
976
1223
/* Remove the plugin */
977
1224
FD_CLR(proc->fd, &rfds_all);
979
1226
/* Block signal while modifying process_list */
980
ret = sigprocmask(SIG_BLOCK, &sigchld_action.sa_mask, NULL);
1227
ret = (int)TEMP_FAILURE_RETRY(sigprocmask
1229
&sigchld_action.sa_mask,
982
perror("sigprocmask");
983
exitstatus = EXIT_FAILURE;
1232
error(0, errno, "sigprocmask");
1233
exitstatus = EX_OSERR;