To get this branch, use:
bzr branch
http://bzr.recompile.se/loggerhead/mandos/trunk
« back to all changes in this revision
Viewing changes to plugin-runner.c
- browse files at revision 237.4.136
- compare with another revision
- download diff
- download tarball
- view history from revision 237.4.136
- Committer: Teddy Hogeborn
- Date: 2021-02-03 08:57:27 UTC
- mto: This revision was merged to the branch mainline in revision 1236.
- Revision ID: teddy@recompile.se-20210203085727-r2nseei71wb0clpf
Tags: version-1.8.14-1
Version 1.8.14-1
* Makefile (version): Change to "1.8.14".
* NEWS (Version 1.8.14): Add new entry.
* debian/changelog (1.8.14-1): - '' -
* Makefile (version): Change to "1.8.14".
* NEWS (Version 1.8.14): Add new entry.
* debian/changelog (1.8.14-1): - '' -
- files added:
- bugs.xml
- debian/tests
- dracut-module
- plugin-helpers
- files removed:
- initramfs-tools-hook-conf
- files modified:
- .bzrignore
added
removed
plugin-runner.c
2
2
/*
3
3
* Mandos plugin runner - Run Mandos plugins
4
4
*
5
* Copyright © 2008-2014 Teddy Hogeborn
6
* Copyright © 2008-2014 Björn Påhlsson
7
*
8
* This program is free software: you can redistribute it and/or
9
* modify it under the terms of the GNU General Public License as
10
* published by the Free Software Foundation, either version 3 of the
11
* License, or (at your option) any later version.
12
*
13
* This program is distributed in the hope that it will be useful, but
5
* Copyright © 2008-2021 Teddy Hogeborn
6
* Copyright © 2008-2021 Björn Påhlsson
7
*
8
* This file is part of Mandos.
9
*
10
* Mandos is free software: you can redistribute it and/or modify it
11
* under the terms of the GNU General Public License as published by
12
* the Free Software Foundation, either version 3 of the License, or
13
* (at your option) any later version.
14
*
15
* Mandos is distributed in the hope that it will be useful, but
14
16
* WITHOUT ANY WARRANTY; without even the implied warranty of
15
17
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
16
18
* General Public License for more details.
17
19
*
18
20
* You should have received a copy of the GNU General Public License
19
* along with this program. If not, see
20
* <http://www.gnu.org/licenses/>.
21
* along with Mandos. If not, see <http://www.gnu.org/licenses/>.
21
22
*
22
23
* Contact the authors at <mandos@recompile.se>.
23
24
*/
24
25
25
#define _GNU_SOURCE /* TEMP_FAILURE_RETRY(), getline(),
26
O_CLOEXEC */
26
#define _GNU_SOURCE /* strchrnul(), TEMP_FAILURE_RETRY(),
27
getline(), asprintf(), O_CLOEXEC,
28
scandirat(), pipe2() */
29
#include <argp.h> /* argp_program_version,
30
argp_program_bug_address,
31
struct argp_option,
32
struct argp_state, argp_error(),
33
ARGP_NO_EXIT, argp_state_help,
34
ARGP_HELP_STD_HELP,
35
ARGP_HELP_USAGE, ARGP_HELP_EXIT_OK,
36
ARGP_KEY_ARG, ARGP_ERR_UNKNOWN,
37
struct argp, argp_parse(),
38
ARGP_IN_ORDER, ARGP_NO_HELP */
39
#include <stdbool.h> /* bool, false, true */
40
#include <sys/types.h> /* pid_t, sig_atomic_t, uid_t, gid_t,
41
getuid(), setgid(), setuid() */
27
42
#include <stddef.h> /* size_t, NULL */
28
#include <stdlib.h> /* malloc(), exit(), EXIT_SUCCESS,
29
realloc() */
30
#include <stdbool.h> /* bool, true, false */
31
#include <stdio.h> /* fileno(), fprintf(),
32
stderr, STDOUT_FILENO, fclose() */
33
#include <sys/types.h> /* DIR, fdopendir(), fstat(), struct
34
stat, waitpid(), WIFEXITED(),
35
WEXITSTATUS(), wait(), pid_t,
36
uid_t, gid_t, getuid(), getgid(),
37
dirfd() */
38
#include <sys/select.h> /* fd_set, select(), FD_ZERO(),
39
FD_SET(), FD_ISSET(), FD_CLR */
40
#include <sys/wait.h> /* wait(), waitpid(), WIFEXITED(),
41
WEXITSTATUS(), WTERMSIG(),
42
WCOREDUMP() */
43
#include <sys/stat.h> /* struct stat, fstat(), S_ISREG() */
44
#include <iso646.h> /* and, or, not */
45
#include <dirent.h> /* DIR, struct dirent, fdopendir(),
46
readdir(), closedir(), dirfd() */
47
#include <unistd.h> /* fcntl(), F_GETFD, F_SETFD,
48
FD_CLOEXEC, write(), STDOUT_FILENO,
49
struct stat, fstat(), close(),
50
setgid(), setuid(), S_ISREG(),
51
faccessat() pipe(), fork(),
52
_exit(), dup2(), fexecve(), read()
53
*/
43
#include <iso646.h> /* or, and, not */
44
#include <string.h> /* strcmp(), strdup(), strchrnul(),
45
strncmp(), strlen(), strcpy(),
46
strsep(), strchr(), strsignal() */
47
#include <stdlib.h> /* malloc(), free(), reallocarray(),
48
realloc(), EXIT_SUCCESS */
49
#include <errno.h> /* errno, EINTR, ENOMEM, ECHILD,
50
error_t, EINVAL, EMFILE, ENFILE,
51
ENOENT, ESRCH */
52
#include <stdint.h> /* SIZE_MAX */
53
#define _GNU_SOURCE /* strchrnul(), TEMP_FAILURE_RETRY(),
54
getline(), asprintf(), O_CLOEXEC,
55
scandirat(), pipe2() */
56
#include <unistd.h> /* TEMP_FAILURE_RETRY(), ssize_t,
57
write(), STDOUT_FILENO, uid_t,
58
gid_t, getuid(), fchown(), close(),
59
symlink(), setgid(), setuid(),
60
faccessat(), X_OK, pipe(), pipe2(),
61
fork(), _exit(), dup2(), fexecve(),
62
read(), getpass() */
54
63
#include <fcntl.h> /* fcntl(), F_GETFD, F_SETFD,
55
FD_CLOEXEC, openat() */
56
#include <string.h> /* strsep, strlen(), strsignal(),
57
strcmp(), strncmp() */
58
#include <errno.h> /* errno */
59
#include <argp.h> /* struct argp_option, struct
60
argp_state, struct argp,
61
argp_parse(), ARGP_ERR_UNKNOWN,
62
ARGP_KEY_END, ARGP_KEY_ARG,
63
error_t */
64
#include <signal.h> /* struct sigaction, sigemptyset(),
65
sigaddset(), sigaction(),
66
sigprocmask(), SIG_BLOCK, SIGCHLD,
67
SIG_UNBLOCK, kill(), sig_atomic_t
68
*/
69
#include <errno.h> /* errno, EBADF */
70
#include <inttypes.h> /* intmax_t, PRIdMAX, strtoimax() */
64
FD_CLOEXEC, open(), O_RDONLY,
65
O_CLOEXEC, openat() */
66
#include <sys/wait.h> /* waitpid(), WNOHANG, WIFEXITED(),
67
WEXITSTATUS(), WIFSIGNALED(),
68
WTERMSIG(), wait() */
69
#include <error.h> /* error() */
70
#include <stdio.h> /* FILE, fprintf(), fopen(),
71
getline(), fclose(), EOF,
72
asprintf(), stderr */
73
#include <dirent.h> /* struct dirent, scandirat(),
74
alphasort() */
75
#include <sys/stat.h> /* struct stat, fstat(), S_ISDIR(),
76
lstat(), S_ISREG() */
77
#include <sys/select.h> /* fd_set, FD_ZERO(), FD_SETSIZE,
78
FD_SET(), select(), FD_CLR(),
79
FD_ISSET() */
80
#include <signal.h> /* struct sigaction, SA_NOCLDSTOP,
81
sigemptyset(), sigaddset(),
82
SIGCHLD, sigprocmask(), SIG_BLOCK,
83
SIG_UNBLOCK, kill(), SIGTERM */
71
84
#include <sysexits.h> /* EX_OSERR, EX_USAGE, EX_IOERR,
72
85
EX_CONFIG, EX_UNAVAILABLE, EX_OK */
73
#include <errno.h> /* errno */
74
#include <error.h> /* error() */
75
#include <fnmatch.h> /* fnmatch() */
86
#include <inttypes.h> /* intmax_t, strtoimax(), PRIdMAX */
87
#include <fnmatch.h> /* fnmatch(), FNM_FILE_NAME,
88
FNM_PERIOD, FNM_NOMATCH */
76
89
77
90
#define BUFFER_SIZE 256
78
91
79
92
#define PDIR "/lib/mandos/plugins.d"
93
#define PHDIR "/lib/mandos/plugin-helpers"
80
94
#define AFILE "/conf/conf.d/mandos/plugin-runner.conf"
81
95
82
96
const char *argp_program_version = "plugin-runner " VERSION;
179
193
/* Resize the pointed-to array to hold one more pointer */
180
194
char **new_array = NULL;
181
195
do {
182
new_array = realloc(*array, sizeof(char *)
183
* (size_t) ((*len) + 2));
196
#if defined(__GLIBC_PREREQ) and __GLIBC_PREREQ(2, 26)
197
new_array = reallocarray(*array, (size_t)((*len) + 2),
198
sizeof(char *));
199
#else
200
if(((size_t)((*len) + 2)) > (SIZE_MAX / sizeof(char *))){
201
/* overflow */
202
new_array = NULL;
203
errno = ENOMEM;
204
} else {
205
new_array = realloc(*array, (size_t)((*len) + 2)
206
* sizeof(char *));
207
}
208
#endif
184
209
} while(new_array == NULL and errno == EINTR);
185
210
/* Malloc check */
186
211
if(new_array == NULL){
241
266
return add_to_char_array(def, &(p->environ), &(p->envc));
242
267
}
243
268
269
#ifndef O_CLOEXEC
244
270
/*
245
271
* Based on the example in the GNU LibC manual chapter 13.13 "File
246
272
* Descriptor Flags".
257
283
return (int)TEMP_FAILURE_RETRY(fcntl(fd, F_SETFD,
258
284
ret | FD_CLOEXEC));
259
285
}
286
#endif /* not O_CLOEXEC */
260
287
261
288
262
289
/* Mark processes as completed when they exit, and save their exit
311
338
__attribute__((nonnull))
312
339
static void free_plugin(plugin *plugin_node){
313
340
314
for(char **arg = plugin_node->argv; *arg != NULL; arg++){
341
for(char **arg = (plugin_node->argv)+1; *arg != NULL; arg++){
315
342
free(*arg);
316
343
}
344
free(plugin_node->name);
317
345
free(plugin_node->argv);
318
346
for(char **env = plugin_node->environ; *env != NULL; env++){
319
347
free(*env);
346
374
347
375
int main(int argc, char *argv[]){
348
376
char *plugindir = NULL;
377
char *pluginhelperdir = NULL;
349
378
char *argfile = NULL;
350
379
FILE *conffp;
351
DIR *dir = NULL;
352
struct dirent *dirst;
380
struct dirent **direntries = NULL;
353
381
struct stat st;
354
382
fd_set rfds_all;
355
383
int ret, maxfd = 0;
363
391
.sa_flags = SA_NOCLDSTOP };
364
392
char **custom_argv = NULL;
365
393
int custom_argc = 0;
366
int dir_fd;
394
int dir_fd = -1;
367
395
368
396
/* Establish a signal handler */
369
397
sigemptyset(&sigchld_action.sa_mask);
414
442
.doc = "Group ID the plugins will run as", .group = 3 },
415
443
{ .name = "debug", .key = 132,
416
444
.doc = "Debug mode", .group = 4 },
445
{ .name = "plugin-helper-dir", .key = 133,
446
.arg = "DIRECTORY",
447
.doc = "Specify a different plugin helper directory",
448
.group = 2 },
417
449
/*
418
450
* These reproduce what we would get without ARGP_NO_HELP
419
451
*/
545
577
case 132: /* --debug */
546
578
debug = true;
547
579
break;
580
case 133: /* --plugin-helper-dir */
581
free(pluginhelperdir);
582
pluginhelperdir = strdup(arg);
583
if(pluginhelperdir != NULL){
584
errno = 0;
585
}
586
break;
548
587
/*
549
588
* These reproduce what we would get without ARGP_NO_HELP
550
589
*/
551
590
case '?': /* --help */
552
591
state->flags &= ~(unsigned int)ARGP_NO_EXIT; /* force exit */
553
592
argp_state_help(state, state->out_stream, ARGP_HELP_STD_HELP);
593
__builtin_unreachable();
554
594
case -3: /* --usage */
555
595
state->flags &= ~(unsigned int)ARGP_NO_EXIT; /* force exit */
556
596
argp_state_help(state, state->out_stream,
557
597
ARGP_HELP_USAGE | ARGP_HELP_EXIT_OK);
598
__builtin_unreachable();
558
599
case 'V': /* --version */
559
600
fprintf(state->out_stream, "%s\n", argp_program_version);
560
601
exit(EXIT_SUCCESS);
570
611
if(arg[0] == '\0'){
571
612
break;
572
613
}
614
#if __GNUC__ >= 7
615
__attribute__((fallthrough));
616
#else
617
/* FALLTHROUGH */
618
#endif
573
619
default:
574
620
return ARGP_ERR_UNKNOWN;
575
621
}
601
647
case 130: /* --userid */
602
648
case 131: /* --groupid */
603
649
case 132: /* --debug */
650
case 133: /* --plugin-helper-dir */
604
651
case '?': /* --help */
605
652
case -3: /* --usage */
606
653
case 'V': /* --version */
686
733
687
734
custom_argc += 1;
688
735
{
689
char **new_argv = realloc(custom_argv, sizeof(char *)
690
* ((unsigned int)
691
custom_argc + 1));
736
#if defined(__GLIBC_PREREQ) and __GLIBC_PREREQ(2, 26)
737
char **new_argv = reallocarray(custom_argv, (size_t)custom_argc + 1,
738
sizeof(char *));
739
#else
740
char **new_argv = NULL;
741
if(((size_t)custom_argc + 1) > (SIZE_MAX / sizeof(char *))){
742
/* overflow */
743
errno = ENOMEM;
744
} else {
745
new_argv = realloc(custom_argv, ((size_t)custom_argc + 1)
746
* sizeof(char *));
747
}
748
#endif
692
749
if(new_argv == NULL){
693
error(0, errno, "realloc");
750
error(0, errno, "reallocarray");
694
751
exitstatus = EX_OSERR;
695
752
free(new_arg);
696
753
free(org_line);
761
818
goto fallback;
762
819
}
763
820
821
{
822
char *pluginhelperenv;
823
bool bret = true;
824
ret = asprintf(&pluginhelperenv, "MANDOSPLUGINHELPERDIR=%s",
825
pluginhelperdir != NULL ? pluginhelperdir : PHDIR);
826
if(ret != -1){
827
bret = add_environment(getplugin(NULL), pluginhelperenv, true);
828
}
829
if(ret == -1 or not bret){
830
error(0, errno, "Failed to set MANDOSPLUGINHELPERDIR"
831
" environment variable to \"%s\" for all plugins\n",
832
pluginhelperdir != NULL ? pluginhelperdir : PHDIR);
833
}
834
if(ret != -1){
835
free(pluginhelperenv);
836
}
837
}
838
764
839
if(debug){
765
for(plugin *p = plugin_list; p != NULL; p=p->next){
840
for(plugin *p = plugin_list; p != NULL; p = p->next){
766
841
fprintf(stderr, "Plugin: %s has %d arguments\n",
767
842
p->name ? p->name : "Global", p->argc - 1);
768
843
for(char **a = p->argv; *a != NULL; a++){
777
852
778
853
if(getuid() == 0){
779
854
/* Work around Debian bug #633582:
780
<http://bugs.debian.org/633582> */
855
<https://bugs.debian.org/633582> */
781
856
int plugindir_fd = open(/* plugindir or */ PDIR, O_RDONLY);
782
857
if(plugindir_fd == -1){
783
858
if(errno != ENOENT){
795
870
}
796
871
}
797
872
}
798
TEMP_FAILURE_RETRY(close(plugindir_fd));
873
close(plugindir_fd);
874
}
875
876
/* Work around Debian bug #981302
877
<https://bugs.debian.org/981302> */
878
if(lstat("/dev/fd", &st) != 0 and errno == ENOENT){
879
ret = symlink("/proc/self/fd", "/dev/fd");
880
if(ret == -1){
881
error(0, errno, "Failed to create /dev/fd symlink");
882
}
799
883
}
800
884
}
801
885
829
913
ret = set_cloexec_flag(dir_fd);
830
914
if(ret < 0){
831
915
error(0, errno, "set_cloexec_flag");
832
TEMP_FAILURE_RETRY(close(dir_fd));
833
916
exitstatus = EX_OSERR;
834
917
goto fallback;
835
918
}
836
919
#endif /* O_CLOEXEC */
837
838
dir = fdopendir(dir_fd);
839
if(dir == NULL){
840
error(0, errno, "Could not open plugin dir");
841
TEMP_FAILURE_RETRY(close(dir_fd));
842
exitstatus = EX_OSERR;
843
goto fallback;
920
}
921
922
int good_name(const struct dirent * const dirent){
923
const char * const patterns[] = { ".*", "#*#", "*~", "*.dpkg-new",
924
"*.dpkg-old", "*.dpkg-bak",
925
"*.dpkg-divert", NULL };
926
#ifdef __GNUC__
927
#pragma GCC diagnostic push
928
#pragma GCC diagnostic ignored "-Wcast-qual"
929
#endif
930
for(const char **pat = (const char **)patterns;
931
*pat != NULL; pat++){
932
#ifdef __GNUC__
933
#pragma GCC diagnostic pop
934
#endif
935
if(fnmatch(*pat, dirent->d_name, FNM_FILE_NAME | FNM_PERIOD)
936
!= FNM_NOMATCH){
937
if(debug){
938
fprintf(stderr, "Ignoring plugin dir entry \"%s\""
939
" matching pattern %s\n", dirent->d_name, *pat);
940
}
941
return 0;
942
}
844
943
}
944
return 1;
945
}
946
947
int numplugins = scandirat(dir_fd, ".", &direntries, good_name,
948
alphasort);
949
if(numplugins == -1){
950
error(0, errno, "Could not scan plugin dir");
951
direntries = NULL;
952
exitstatus = EX_OSERR;
953
goto fallback;
845
954
}
846
955
847
956
FD_ZERO(&rfds_all);
848
957
849
958
/* Read and execute any executable in the plugin directory*/
850
while(true){
851
do {
852
dirst = readdir(dir);
853
} while(dirst == NULL and errno == EINTR);
854
855
/* All directory entries have been processed */
856
if(dirst == NULL){
857
if(errno == EBADF){
858
error(0, errno, "readdir");
859
exitstatus = EX_IOERR;
860
goto fallback;
861
}
862
break;
863
}
864
865
/* Ignore dotfiles, backup files and other junk */
866
{
867
bool bad_name = false;
868
const char * const patterns[] = { ".*", "#*#", "*~",
869
"*.dpkg-new", "*.dpkg-old",
870
"*.dpkg-bak", "*.dpkg-divert",
871
NULL };
872
#ifdef __GNUC__
873
#pragma GCC diagnostic push
874
#pragma GCC diagnostic ignored "-Wcast-qual"
875
#endif
876
for(const char **pat = (const char **)patterns;
877
*pat != NULL; pat++){
878
#ifdef __GNUC__
879
#pragma GCC diagnostic pop
880
#endif
881
if(fnmatch(*pat, dirst->d_name,
882
FNM_FILE_NAME | FNM_PERIOD) != FNM_NOMATCH){
883
if(debug){
884
fprintf(stderr, "Ignoring plugin dir entry \"%s\""
885
" matching pattern %s\n", dirst->d_name, *pat);
886
}
887
bad_name = true;
888
break;
889
}
890
}
891
if(bad_name){
892
continue;
893
}
894
}
895
896
int plugin_fd = openat(dir_fd, dirst->d_name, O_RDONLY |
897
#ifdef O_CLOEXEC
898
O_CLOEXEC
899
#else /* not O_CLOEXEC */
900
0
901
#endif /* not O_CLOEXEC */
902
);
959
for(int i = 0; i < numplugins; i++){
960
961
int plugin_fd = openat(dir_fd, direntries[i]->d_name, O_RDONLY);
903
962
if(plugin_fd == -1){
904
963
error(0, errno, "Could not open plugin");
905
continue;
906
}
907
#ifndef O_CLOEXEC
908
/* Set the FD_CLOEXEC flag on the plugin FD */
909
ret = set_cloexec_flag(plugin_fd);
910
if(ret < 0){
911
error(0, errno, "set_cloexec_flag");
912
TEMP_FAILURE_RETRY(close(plugin_fd));
913
continue;
914
}
915
#endif /* O_CLOEXEC */
964
free(direntries[i]);
965
continue;
966
}
916
967
ret = (int)TEMP_FAILURE_RETRY(fstat(plugin_fd, &st));
917
968
if(ret == -1){
918
969
error(0, errno, "stat");
919
TEMP_FAILURE_RETRY(close(plugin_fd));
970
close(plugin_fd);
971
free(direntries[i]);
920
972
continue;
921
973
}
922
974
923
975
/* Ignore non-executable files */
924
976
if(not S_ISREG(st.st_mode)
925
or (TEMP_FAILURE_RETRY(faccessat(dir_fd, dirst->d_name, X_OK,
926
0)) != 0)){
977
or (TEMP_FAILURE_RETRY(faccessat(dir_fd, direntries[i]->d_name,
978
X_OK, 0)) != 0)){
927
979
if(debug){
928
980
fprintf(stderr, "Ignoring plugin dir entry \"%s/%s\""
929
981
" with bad type or mode\n",
930
plugindir != NULL ? plugindir : PDIR, dirst->d_name);
982
plugindir != NULL ? plugindir : PDIR,
983
direntries[i]->d_name);
931
984
}
932
TEMP_FAILURE_RETRY(close(plugin_fd));
985
close(plugin_fd);
986
free(direntries[i]);
933
987
continue;
934
988
}
935
989
936
plugin *p = getplugin(dirst->d_name);
990
plugin *p = getplugin(direntries[i]->d_name);
937
991
if(p == NULL){
938
992
error(0, errno, "getplugin");
939
TEMP_FAILURE_RETRY(close(plugin_fd));
993
close(plugin_fd);
994
free(direntries[i]);
940
995
continue;
941
996
}
942
997
if(p->disabled){
943
998
if(debug){
944
999
fprintf(stderr, "Ignoring disabled plugin \"%s\"\n",
945
dirst->d_name);
1000
direntries[i]->d_name);
946
1001
}
947
TEMP_FAILURE_RETRY(close(plugin_fd));
1002
close(plugin_fd);
1003
free(direntries[i]);
948
1004
continue;
949
1005
}
950
1006
{
975
1031
}
976
1032
977
1033
int pipefd[2];
1034
#ifndef O_CLOEXEC
978
1035
ret = (int)TEMP_FAILURE_RETRY(pipe(pipefd));
1036
#else /* O_CLOEXEC */
1037
ret = (int)TEMP_FAILURE_RETRY(pipe2(pipefd, O_CLOEXEC));
1038
#endif /* O_CLOEXEC */
979
1039
if(ret == -1){
980
1040
error(0, errno, "pipe");
981
1041
exitstatus = EX_OSERR;
982
goto fallback;
983
}
1042
free(direntries[i]);
1043
goto fallback;
1044
}
1045
if(pipefd[0] >= FD_SETSIZE){
1046
fprintf(stderr, "pipe()[0] (%d) >= FD_SETSIZE (%d)", pipefd[0],
1047
FD_SETSIZE);
1048
close(pipefd[0]);
1049
close(pipefd[1]);
1050
exitstatus = EX_OSERR;
1051
free(direntries[i]);
1052
goto fallback;
1053
}
1054
#ifndef O_CLOEXEC
984
1055
/* Ask OS to automatic close the pipe on exec */
985
1056
ret = set_cloexec_flag(pipefd[0]);
986
1057
if(ret < 0){
987
1058
error(0, errno, "set_cloexec_flag");
1059
close(pipefd[0]);
1060
close(pipefd[1]);
988
1061
exitstatus = EX_OSERR;
1062
free(direntries[i]);
989
1063
goto fallback;
990
1064
}
991
1065
ret = set_cloexec_flag(pipefd[1]);
992
1066
if(ret < 0){
993
1067
error(0, errno, "set_cloexec_flag");
1068
close(pipefd[0]);
1069
close(pipefd[1]);
994
1070
exitstatus = EX_OSERR;
1071
free(direntries[i]);
995
1072
goto fallback;
996
1073
}
1074
#endif /* not O_CLOEXEC */
997
1075
/* Block SIGCHLD until process is safely in process list */
998
1076
ret = (int)TEMP_FAILURE_RETRY(sigprocmask(SIG_BLOCK,
999
1077
&sigchld_action.sa_mask,
1001
1079
if(ret < 0){
1002
1080
error(0, errno, "sigprocmask");
1003
1081
exitstatus = EX_OSERR;
1082
free(direntries[i]);
1004
1083
goto fallback;
1005
1084
}
1006
1085
/* Starting a new process to be watched */
1010
1089
} while(pid == -1 and errno == EINTR);
1011
1090
if(pid == -1){
1012
1091
error(0, errno, "fork");
1092
TEMP_FAILURE_RETRY(sigprocmask(SIG_UNBLOCK,
1093
&sigchld_action.sa_mask, NULL));
1094
close(pipefd[0]);
1095
close(pipefd[1]);
1013
1096
exitstatus = EX_OSERR;
1097
free(direntries[i]);
1014
1098
goto fallback;
1015
1099
}
1016
1100
if(pid == 0){
1032
1116
_exit(EX_OSERR);
1033
1117
}
1034
1118
1035
if(dirfd(dir) < 0){
1036
/* If dir has no file descriptor, we could not set FD_CLOEXEC
1037
above and must now close it manually here. */
1038
closedir(dir);
1039
}
1040
1119
if(fexecve(plugin_fd, p->argv,
1041
1120
(p->environ[0] != NULL) ? p->environ : environ) < 0){
1042
1121
error(0, errno, "fexecve for %s/%s",
1043
plugindir != NULL ? plugindir : PDIR, dirst->d_name);
1122
plugindir != NULL ? plugindir : PDIR,
1123
direntries[i]->d_name);
1044
1124
_exit(EX_OSERR);
1045
1125
}
1046
1126
/* no return */
1047
1127
}
1048
1128
/* Parent process */
1049
TEMP_FAILURE_RETRY(close(pipefd[1])); /* Close unused write end of
1050
pipe */
1051
TEMP_FAILURE_RETRY(close(plugin_fd));
1052
plugin *new_plugin = getplugin(dirst->d_name);
1129
close(pipefd[1]); /* Close unused write end of pipe */
1130
close(plugin_fd);
1131
plugin *new_plugin = getplugin(direntries[i]->d_name);
1053
1132
if(new_plugin == NULL){
1054
1133
error(0, errno, "getplugin");
1055
1134
ret = (int)(TEMP_FAILURE_RETRY
1059
1138
error(0, errno, "sigprocmask");
1060
1139
}
1061
1140
exitstatus = EX_OSERR;
1141
free(direntries[i]);
1062
1142
goto fallback;
1063
1143
}
1144
free(direntries[i]);
1064
1145
1065
1146
new_plugin->pid = pid;
1066
1147
new_plugin->fd = pipefd[0];
1067
1148
1149
if(debug){
1150
fprintf(stderr, "Plugin %s started (PID %" PRIdMAX ")\n",
1151
new_plugin->name, (intmax_t) (new_plugin->pid));
1152
}
1153
1068
1154
/* Unblock SIGCHLD so signal handler can be run if this process
1069
1155
has already completed */
1070
1156
ret = (int)TEMP_FAILURE_RETRY(sigprocmask(SIG_UNBLOCK,
1076
1162
goto fallback;
1077
1163
}
1078
1164
1079
#if defined (__GNUC__) and defined (__GLIBC__)
1080
#if not __GLIBC_PREREQ(2, 16)
1081
#pragma GCC diagnostic push
1082
#pragma GCC diagnostic ignored "-Wsign-conversion"
1083
#endif
1084
#endif
1085
FD_SET(new_plugin->fd, &rfds_all); /* Spurious warning from
1086
-Wconversion in GNU libc
1087
before 2.16 */
1088
#if defined (__GNUC__) and defined (__GLIBC__)
1089
#if not __GLIBC_PREREQ(2, 16)
1090
#pragma GCC diagnostic pop
1091
#endif
1092
#endif
1165
FD_SET(new_plugin->fd, &rfds_all);
1093
1166
1094
1167
if(maxfd < new_plugin->fd){
1095
1168
maxfd = new_plugin->fd;
1096
1169
}
1097
1170
}
1098
1171
1099
TEMP_FAILURE_RETRY(closedir(dir));
1100
dir = NULL;
1172
free(direntries);
1173
direntries = NULL;
1174
close(dir_fd);
1175
dir_fd = -1;
1101
1176
free_plugin(getplugin(NULL));
1102
1177
1103
1178
for(plugin *p = plugin_list; p != NULL; p = p->next){
1142
1217
(intmax_t) (proc->pid),
1143
1218
WTERMSIG(proc->status),
1144
1219
strsignal(WTERMSIG(proc->status)));
1145
} else if(WCOREDUMP(proc->status)){
1146
fprintf(stderr, "Plugin %s [%" PRIdMAX "] dumped"
1147
" core\n", proc->name, (intmax_t) (proc->pid));
1148
1220
}
1149
1221
}
1150
1222
1151
1223
/* Remove the plugin */
1152
#if defined (__GNUC__) and defined (__GLIBC__)
1153
#if not __GLIBC_PREREQ(2, 16)
1154
#pragma GCC diagnostic push
1155
#pragma GCC diagnostic ignored "-Wsign-conversion"
1156
#endif
1157
#endif
1158
FD_CLR(proc->fd, &rfds_all); /* Spurious warning from
1159
-Wconversion in GNU libc
1160
before 2.16 */
1161
#if defined (__GNUC__) and defined (__GLIBC__)
1162
#if not __GLIBC_PREREQ(2, 16)
1163
#pragma GCC diagnostic pop
1164
#endif
1165
#endif
1224
FD_CLR(proc->fd, &rfds_all);
1166
1225
1167
1226
/* Block signal while modifying process_list */
1168
1227
ret = (int)TEMP_FAILURE_RETRY(sigprocmask
1208
1267
}
1209
1268
1210
1269
/* This process has not completed. Does it have any output? */
1211
#if defined (__GNUC__) and defined (__GLIBC__)
1212
#if not __GLIBC_PREREQ(2, 16)
1213
#pragma GCC diagnostic push
1214
#pragma GCC diagnostic ignored "-Wsign-conversion"
1215
#endif
1216
#endif
1217
if(proc->eof or not FD_ISSET(proc->fd, &rfds)){ /* Spurious
1218
warning from
1219
-Wconversion
1220
in GNU libc
1221
before
1222
2.16 */
1223
#if defined (__GNUC__) and defined (__GLIBC__)
1224
#if not __GLIBC_PREREQ(2, 16)
1225
#pragma GCC diagnostic pop
1226
#endif
1227
#endif
1270
if(proc->eof or not FD_ISSET(proc->fd, &rfds)){
1228
1271
/* This process had nothing to say at this time */
1229
1272
proc = proc->next;
1230
1273
continue;
1297
1340
free(custom_argv);
1298
1341
}
1299
1342
1300
if(dir != NULL){
1301
closedir(dir);
1343
free(direntries);
1344
1345
if(dir_fd != -1){
1346
close(dir_fd);
1302
1347
}
1303
1348
1304
1349
/* Kill the processes */
1324
1369
free_plugin_list();
1325
1370
1326
1371
free(plugindir);
1372
free(pluginhelperdir);
1327
1373
free(argfile);
1328
1374
1329
1375
return exitstatus;
Loggerhead is a web-based interface for Breezy
Version: 2.0.2.dev0