19
18
* along with this program. If not, see
20
19
* <http://www.gnu.org/licenses/>.
22
* Contact the authors at <mandos@recompile.se>.
21
* Contact the authors at <mandos@fukt.bsnet.se>.
25
24
#define _GNU_SOURCE /* TEMP_FAILURE_RETRY(), getline(),
26
asprintf(), O_CLOEXEC */
27
26
#include <stddef.h> /* size_t, NULL */
28
#include <stdlib.h> /* malloc(), exit(), EXIT_SUCCESS,
27
#include <stdlib.h> /* malloc(), exit(), EXIT_FAILURE,
28
EXIT_SUCCESS, realloc() */
30
29
#include <stdbool.h> /* bool, true, false */
31
#include <stdio.h> /* fileno(), fprintf(),
30
#include <stdio.h> /* perror, fileno(), fprintf(),
32
31
stderr, STDOUT_FILENO */
33
#include <sys/types.h> /* DIR, fdopendir(), stat(), struct
32
#include <sys/types.h> /* DIR, opendir(), stat(), struct
34
33
stat, waitpid(), WIFEXITED(),
35
34
WEXITSTATUS(), wait(), pid_t,
36
35
uid_t, gid_t, getuid(), getgid(),
38
37
#include <sys/select.h> /* fd_set, select(), FD_ZERO(),
39
38
FD_SET(), FD_ISSET(), FD_CLR */
40
39
#include <sys/wait.h> /* wait(), waitpid(), WIFEXITED(),
41
WEXITSTATUS(), WTERMSIG(),
43
41
#include <sys/stat.h> /* struct stat, stat(), S_ISREG() */
44
42
#include <iso646.h> /* and, or, not */
45
#include <dirent.h> /* DIR, struct dirent, fdopendir(),
43
#include <dirent.h> /* DIR, struct dirent, opendir(),
46
44
readdir(), closedir(), dirfd() */
47
45
#include <unistd.h> /* struct stat, stat(), S_ISREG(),
48
46
fcntl(), setuid(), setgid(),
49
47
F_GETFD, F_SETFD, FD_CLOEXEC,
50
48
access(), pipe(), fork(), close()
51
49
dup2(), STDOUT_FILENO, _exit(),
52
execve(), write(), read(),
50
execv(), write(), read(),
54
52
#include <fcntl.h> /* fcntl(), F_GETFD, F_SETFD,
56
#include <string.h> /* strsep, strlen(), asprintf(),
57
strsignal(), strcmp(), strncmp() */
54
#include <string.h> /* strsep, strlen(), asprintf() */
58
55
#include <errno.h> /* errno */
59
56
#include <argp.h> /* struct argp_option, struct
60
57
argp_state, struct argp,
64
61
#include <signal.h> /* struct sigaction, sigemptyset(),
65
62
sigaddset(), sigaction(),
66
63
sigprocmask(), SIG_BLOCK, SIGCHLD,
67
SIG_UNBLOCK, kill(), sig_atomic_t
64
SIG_UNBLOCK, kill() */
69
65
#include <errno.h> /* errno, EBADF */
70
#include <inttypes.h> /* intmax_t, PRIdMAX, strtoimax() */
71
#include <sysexits.h> /* EX_OSERR, EX_USAGE, EX_IOERR,
72
EX_CONFIG, EX_UNAVAILABLE, EX_OK */
73
#include <errno.h> /* errno */
74
#include <error.h> /* error() */
76
67
#define BUFFER_SIZE 256
78
69
#define PDIR "/lib/mandos/plugins.d"
79
70
#define AFILE "/conf/conf.d/mandos/plugin-runner.conf"
81
const char *argp_program_version = "plugin-runner " VERSION;
82
const char *argp_program_bug_address = "<mandos@recompile.se>";
72
const char *argp_program_version = "plugin-runner 1.0";
73
const char *argp_program_bug_address = "<mandos@fukt.bsnet.se>";
84
75
typedef struct plugin{
85
76
char *name; /* can be NULL or any plugin name */
106
97
/* Gets an existing plugin based on name,
107
98
or if none is found, creates a new one */
108
__attribute__((warn_unused_result))
109
99
static plugin *getplugin(char *name){
110
/* Check for existing plugin with that name */
111
for(plugin *p = plugin_list; p != NULL; p = p->next){
113
or (p->name and name and (strcmp(p->name, name) == 0))){
100
/* Check for exiting plugin with that name */
101
for (plugin *p = plugin_list; p != NULL; p = p->next){
102
if ((p->name == name)
103
or (p->name and name and (strcmp(p->name, name) == 0))){
117
107
/* Create a new plugin */
118
plugin *new_plugin = NULL;
120
new_plugin = malloc(sizeof(plugin));
121
} while(new_plugin == NULL and errno == EINTR);
122
if(new_plugin == NULL){
108
plugin *new_plugin = malloc(sizeof(plugin));
109
if (new_plugin == NULL){
125
112
char *copy_name = NULL;
126
113
if(name != NULL){
128
copy_name = strdup(name);
129
} while(copy_name == NULL and errno == EINTR);
114
copy_name = strdup(name);
130
115
if(copy_name == NULL){
138
*new_plugin = (plugin){ .name = copy_name,
141
.next = plugin_list };
120
*new_plugin = (plugin) { .name = copy_name,
123
.next = plugin_list };
144
new_plugin->argv = malloc(sizeof(char *) * 2);
145
} while(new_plugin->argv == NULL and errno == EINTR);
146
if(new_plugin->argv == NULL){
125
new_plugin->argv = malloc(sizeof(char *) * 2);
126
if (new_plugin->argv == NULL){
149
128
free(new_plugin);
153
131
new_plugin->argv[0] = copy_name;
154
132
new_plugin->argv[1] = NULL;
157
new_plugin->environ = malloc(sizeof(char *));
158
} while(new_plugin->environ == NULL and errno == EINTR);
134
new_plugin->environ = malloc(sizeof(char *));
159
135
if(new_plugin->environ == NULL){
162
137
free(new_plugin->argv);
163
138
free(new_plugin);
167
141
new_plugin->environ[0] = NULL;
413
367
.doc = "Group ID the plugins will run as", .group = 3 },
414
368
{ .name = "debug", .key = 132,
415
369
.doc = "Debug mode", .group = 4 },
417
* These reproduce what we would get without ARGP_NO_HELP
419
{ .name = "help", .key = '?',
420
.doc = "Give this help list", .group = -1 },
421
{ .name = "usage", .key = -3,
422
.doc = "Give a short usage message", .group = -1 },
423
{ .name = "version", .key = 'V',
424
.doc = "Print program version", .group = -1 },
428
__attribute__((nonnull(3)))
429
error_t parse_opt(int key, char *arg, struct argp_state *state){
373
error_t parse_opt (int key, char *arg, __attribute__((unused))
374
struct argp_state *state) {
434
376
case 'g': /* --global-options */
437
while((plugin_option = strsep(&arg, ",")) != NULL){
438
if(not add_argument(getplugin(NULL), plugin_option)){
379
while((p = strsep(&arg, ",")) != NULL){
383
if(not add_argument(getplugin(NULL), p)){
384
perror("add_argument");
385
return ARGP_ERR_UNKNOWN;
445
390
case 'G': /* --global-env */
446
if(add_environment(getplugin(NULL), arg, true)){
394
if(not add_environment(getplugin(NULL), arg, true)){
395
perror("add_environment");
450
398
case 'o': /* --options-for */
452
char *option_list = strchr(arg, ':');
453
if(option_list == NULL){
454
argp_error(state, "No colon in \"%s\"", arg);
461
argp_error(state, "Empty plugin name");
466
while((option = strsep(&option_list, ",")) != NULL){
467
if(not add_argument(getplugin(arg), option)){
400
char *p_name = strsep(&arg, ":");
401
if(p_name[0] == '\0' or arg == NULL){
404
char *opt = strsep(&arg, ":");
405
if(opt[0] == '\0' or opt == NULL){
409
while((p = strsep(&opt, ",")) != NULL){
413
if(not add_argument(getplugin(p_name), p)){
414
perror("add_argument");
415
return ARGP_ERR_UNKNOWN;
474
420
case 'E': /* --env-for */
476
425
char *envdef = strchr(arg, ':');
477
426
if(envdef == NULL){
478
argp_error(state, "No colon in \"%s\"", arg);
485
argp_error(state, "Empty plugin name");
489
if(add_environment(getplugin(arg), envdef, true)){
430
if(not add_environment(getplugin(arg), envdef+1, true)){
431
perror("add_environment");
494
435
case 'd': /* --disable */
496
437
plugin *p = getplugin(arg);
439
return ARGP_ERR_UNKNOWN;
503
444
case 'e': /* --enable */
505
446
plugin *p = getplugin(arg);
448
return ARGP_ERR_UNKNOWN;
512
453
case 128: /* --plugin-dir */
514
455
plugindir = strdup(arg);
515
if(plugindir != NULL){
456
if(plugindir == NULL){
519
460
case 129: /* --config-file */
520
461
/* This is already done by parse_opt_config_file() */
522
463
case 130: /* --userid */
523
tmp_id = strtoimax(arg, &tmp, 10);
524
if(errno != 0 or tmp == arg or *tmp != '\0'
525
or tmp_id != (uid_t)tmp_id){
526
argp_error(state, "Bad user ID number: \"%s\", using %"
527
PRIdMAX, arg, (intmax_t)uid);
464
uid = (uid_t)strtol(arg, NULL, 10);
533
466
case 131: /* --groupid */
534
tmp_id = strtoimax(arg, &tmp, 10);
535
if(errno != 0 or tmp == arg or *tmp != '\0'
536
or tmp_id != (gid_t)tmp_id){
537
argp_error(state, "Bad group ID number: \"%s\", using %"
538
PRIdMAX, arg, (intmax_t)gid);
467
gid = (gid_t)strtol(arg, NULL, 10);
544
469
case 132: /* --debug */
548
* These reproduce what we would get without ARGP_NO_HELP
550
case '?': /* --help */
551
state->flags &= ~(unsigned int)ARGP_NO_EXIT; /* force exit */
552
argp_state_help(state, state->out_stream, ARGP_HELP_STD_HELP);
553
case -3: /* --usage */
554
state->flags &= ~(unsigned int)ARGP_NO_EXIT; /* force exit */
555
argp_state_help(state, state->out_stream,
556
ARGP_HELP_USAGE | ARGP_HELP_EXIT_OK);
557
case 'V': /* --version */
558
fprintf(state->out_stream, "%s\n", argp_program_version);
562
* When adding more options before this line, remember to also add a
563
* "case" to the "parse_opt_config_file" function below.
565
472
case ARGP_KEY_ARG:
566
473
/* Cryptsetup always passes an argument, which is an empty
567
474
string if "none" was specified in /etc/crypttab. So if
568
475
argument was empty, we ignore it silently. */
477
fprintf(stderr, "Ignoring unknown argument \"%s\"\n", arg);
573
483
return ARGP_ERR_UNKNOWN;
575
return errno; /* Set to 0 at start */
578
488
/* This option parser is the same as parse_opt() above, except it
579
489
ignores everything but the --config-file option. */
580
error_t parse_opt_config_file(int key, char *arg,
581
__attribute__((unused))
582
struct argp_state *state){
490
error_t parse_opt_config_file (int key, char *arg,
491
__attribute__((unused))
492
struct argp_state *state) {
585
494
case 'g': /* --global-options */
586
495
case 'G': /* --global-env */
587
496
case 'o': /* --options-for */
678
576
new_arg = strdup(p);
679
577
if(new_arg == NULL){
680
error(0, errno, "strdup");
681
exitstatus = EX_OSERR;
579
exitstatus = EXIT_FAILURE;
686
584
custom_argc += 1;
688
char **new_argv = realloc(custom_argv, sizeof(char *)
691
if(new_argv == NULL){
692
error(0, errno, "realloc");
693
exitstatus = EX_OSERR;
698
custom_argv = new_argv;
585
custom_argv = realloc(custom_argv, sizeof(char *)
586
* ((unsigned int) custom_argc + 1));
587
if(custom_argv == NULL){
589
exitstatus = EXIT_FAILURE;
701
593
custom_argv[custom_argc-1] = new_arg;
702
custom_argv[custom_argc] = NULL;
594
custom_argv[custom_argc] = NULL;
706
ret = fclose(conffp);
707
} while(ret == EOF and errno == EINTR);
709
error(0, errno, "fclose");
710
exitstatus = EX_IOERR;
715
599
/* Check for harmful errors and go to fallback. Other errors might
716
600
not affect opening plugins */
717
if(errno == EMFILE or errno == ENFILE or errno == ENOMEM){
718
error(0, errno, "fopen");
719
exitstatus = EX_OSERR;
601
if (errno == EMFILE or errno == ENFILE or errno == ENOMEM){
603
exitstatus = EXIT_FAILURE;
723
/* If there were any arguments from the configuration file, pass
724
them to parser as command line arguments */
607
/* If there was any arguments from configuration file,
608
pass them to parser as command arguments */
725
609
if(custom_argv != NULL){
726
ret = argp_parse(&argp, custom_argc, custom_argv,
727
ARGP_IN_ORDER | ARGP_NO_EXIT | ARGP_NO_HELP,
735
error(0, errno, "argp_parse");
736
exitstatus = EX_OSERR;
739
exitstatus = EX_CONFIG;
610
ret = argp_parse (&argp, custom_argc, custom_argv, ARGP_IN_ORDER,
612
if (ret == ARGP_ERR_UNKNOWN){
613
fprintf(stderr, "Unknown error while parsing arguments\n");
614
exitstatus = EXIT_FAILURE;
744
619
/* Parse actual command line arguments, to let them override the
746
ret = argp_parse(&argp, argc, argv,
747
ARGP_IN_ORDER | ARGP_NO_EXIT | ARGP_NO_HELP,
755
error(0, errno, "argp_parse");
756
exitstatus = EX_OSERR;
759
exitstatus = EX_USAGE;
621
ret = argp_parse (&argp, argc, argv, ARGP_IN_ORDER, 0, NULL);
622
if (ret == ARGP_ERR_UNKNOWN){
623
fprintf(stderr, "Unknown error while parsing arguments\n");
624
exitstatus = EXIT_FAILURE;
767
632
for(char **a = p->argv; *a != NULL; a++){
768
633
fprintf(stderr, "\tArg: %s\n", *a);
770
fprintf(stderr, "...and %d environment variables\n", p->envc);
635
fprintf(stderr, "...and %u environment variables\n", p->envc);
771
636
for(char **a = p->environ; *a != NULL; a++){
772
637
fprintf(stderr, "\t%s\n", *a);
778
/* Work around Debian bug #633582:
779
<http://bugs.debian.org/633582> */
780
int plugindir_fd = open(/* plugindir or */ PDIR, O_RDONLY);
781
if(plugindir_fd == -1){
782
error(0, errno, "open(\"" PDIR "\")");
784
ret = (int)TEMP_FAILURE_RETRY(fstat(plugindir_fd, &st));
786
error(0, errno, "fstat");
788
if(S_ISDIR(st.st_mode) and st.st_uid == 0 and st.st_gid == 0){
789
ret = fchown(plugindir_fd, uid, gid);
791
error(0, errno, "fchown");
795
TEMP_FAILURE_RETRY(close(plugindir_fd));
799
/* Lower permissions */
802
error(0, errno, "setgid");
642
/* Strip permissions down to nobody */
804
643
ret = setuid(uid);
806
error(0, errno, "setuid");
809
/* Open plugin directory with close_on_exec flag */
652
if (plugindir == NULL){
655
dir = opendir(plugindir);
659
perror("Could not open plugin dir");
660
exitstatus = EXIT_FAILURE;
664
/* Set the FD_CLOEXEC flag on the directory, if possible */
812
if(plugindir == NULL){
813
dir_fd = open(PDIR, O_RDONLY |
816
#else /* not O_CLOEXEC */
818
#endif /* not O_CLOEXEC */
821
dir_fd = open(plugindir, O_RDONLY |
824
#else /* not O_CLOEXEC */
826
#endif /* not O_CLOEXEC */
830
error(0, errno, "Could not open plugin dir");
831
exitstatus = EX_UNAVAILABLE;
836
/* Set the FD_CLOEXEC flag on the directory */
837
ret = set_cloexec_flag(dir_fd);
839
error(0, errno, "set_cloexec_flag");
840
TEMP_FAILURE_RETRY(close(dir_fd));
841
exitstatus = EX_OSERR;
844
#endif /* O_CLOEXEC */
846
dir = fdopendir(dir_fd);
848
error(0, errno, "Could not open plugin dir");
849
TEMP_FAILURE_RETRY(close(dir_fd));
850
exitstatus = EX_OSERR;
666
int dir_fd = dirfd(dir);
668
ret = set_cloexec_flag(dir_fd);
670
perror("set_cloexec_flag");
671
exitstatus = EXIT_FAILURE;
1001
800
if(p->environ[0] != NULL){
1002
801
for(char **e = environ; *e != NULL; e++){
1003
802
if(not add_environment(p, *e, false)){
1004
error(0, errno, "add_environment");
803
perror("add_environment");
1010
ret = (int)TEMP_FAILURE_RETRY(pipe(pipefd));
1012
error(0, errno, "pipe");
1013
exitstatus = EX_OSERR;
812
exitstatus = EXIT_FAILURE;
1016
815
/* Ask OS to automatic close the pipe on exec */
1017
816
ret = set_cloexec_flag(pipefd[0]);
1019
error(0, errno, "set_cloexec_flag");
1020
exitstatus = EX_OSERR;
818
perror("set_cloexec_flag");
819
exitstatus = EXIT_FAILURE;
1023
822
ret = set_cloexec_flag(pipefd[1]);
1025
error(0, errno, "set_cloexec_flag");
1026
exitstatus = EX_OSERR;
824
perror("set_cloexec_flag");
825
exitstatus = EXIT_FAILURE;
1029
828
/* Block SIGCHLD until process is safely in process list */
1030
ret = (int)TEMP_FAILURE_RETRY(sigprocmask(SIG_BLOCK,
1031
&sigchld_action.sa_mask,
829
ret = sigprocmask (SIG_BLOCK, &sigchld_action.sa_mask, NULL);
1034
error(0, errno, "sigprocmask");
1035
exitstatus = EX_OSERR;
831
perror("sigprocmask");
832
exitstatus = EXIT_FAILURE;
1038
835
/* Starting a new process to be watched */
1042
} while(pid == -1 and errno == EINTR);
1044
error(0, errno, "fork");
1045
exitstatus = EX_OSERR;
839
exitstatus = EXIT_FAILURE;
1049
843
/* this is the child process */
1050
844
ret = sigaction(SIGCHLD, &old_sigchld_action, NULL);
1052
error(0, errno, "sigaction");
1055
849
ret = sigprocmask(SIG_UNBLOCK, &sigchld_action.sa_mask, NULL);
1057
error(0, errno, "sigprocmask");
851
perror("sigprocmask");
1061
855
ret = dup2(pipefd[1], STDOUT_FILENO); /* replace our stdout */
1063
error(0, errno, "dup2");
1067
861
if(dirfd(dir) < 0){
1069
863
above and must now close it manually here. */
1072
if(execve(filename, p->argv,
1073
(p->environ[0] != NULL) ? p->environ : environ) < 0){
1074
error(0, errno, "execve for %s", filename);
866
if(p->environ[0] == NULL){
867
if(execv(filename, p->argv) < 0){
872
if(execve(filename, p->argv, p->environ) < 0){
1079
879
/* Parent process */
1080
TEMP_FAILURE_RETRY(close(pipefd[1])); /* Close unused write end of
880
close(pipefd[1]); /* Close unused write end of pipe */
1083
882
plugin *new_plugin = getplugin(dirst->d_name);
1084
if(new_plugin == NULL){
1085
error(0, errno, "getplugin");
1086
ret = (int)(TEMP_FAILURE_RETRY
1087
(sigprocmask(SIG_UNBLOCK, &sigchld_action.sa_mask,
883
if (new_plugin == NULL){
885
ret = sigprocmask (SIG_UNBLOCK, &sigchld_action.sa_mask, NULL);
1090
error(0, errno, "sigprocmask");
887
perror("sigprocmask");
1092
exitstatus = EX_OSERR;
889
exitstatus = EXIT_FAILURE;
1099
896
/* Unblock SIGCHLD so signal handler can be run if this process
1100
897
has already completed */
1101
ret = (int)TEMP_FAILURE_RETRY(sigprocmask(SIG_UNBLOCK,
1102
&sigchld_action.sa_mask,
898
ret = sigprocmask (SIG_UNBLOCK, &sigchld_action.sa_mask, NULL);
1105
error(0, errno, "sigprocmask");
1106
exitstatus = EX_OSERR;
900
perror("sigprocmask");
901
exitstatus = EXIT_FAILURE;
1110
#if defined (__GNUC__) and defined (__GLIBC__)
1111
#if not __GLIBC_PREREQ(2, 16)
1112
#pragma GCC diagnostic push
1113
#pragma GCC diagnostic ignored "-Wsign-conversion"
1116
FD_SET(new_plugin->fd, &rfds_all); /* Spurious warning from
1117
-Wconversion in GNU libc
1119
#if defined (__GNUC__) and defined (__GLIBC__)
1120
#if not __GLIBC_PREREQ(2, 16)
1121
#pragma GCC diagnostic pop
905
FD_SET(new_plugin->fd, &rfds_all);
1125
if(maxfd < new_plugin->fd){
907
if (maxfd < new_plugin->fd){
1126
908
maxfd = new_plugin->fd;
1130
TEMP_FAILURE_RETRY(closedir(dir));
1132
free_plugin(getplugin(NULL));
1134
915
for(plugin *p = plugin_list; p != NULL; p = p->next){
1135
916
if(p->pid != 0){
1146
927
while(plugin_list){
1147
928
fd_set rfds = rfds_all;
1148
929
int select_ret = select(maxfd+1, &rfds, NULL, NULL, NULL);
1149
if(select_ret == -1 and errno != EINTR){
1150
error(0, errno, "select");
1151
exitstatus = EX_OSERR;
930
if (select_ret == -1){
932
exitstatus = EXIT_FAILURE;
1154
935
/* OK, now either a process completed, or something can be read
1155
936
from one of them */
1156
937
for(plugin *proc = plugin_list; proc != NULL;){
1157
938
/* Is this process completely done? */
1158
if(proc->completed and proc->eof){
939
if(proc->eof and proc->completed){
1159
940
/* Only accept the plugin output if it exited cleanly */
1160
941
if(not WIFEXITED(proc->status)
1161
942
or WEXITSTATUS(proc->status) != 0){
1162
943
/* Bad exit by plugin */
1165
946
if(WIFEXITED(proc->status)){
1166
fprintf(stderr, "Plugin %s [%" PRIdMAX "] exited with"
1167
" status %d\n", proc->name,
1168
(intmax_t) (proc->pid),
947
fprintf(stderr, "Plugin %u exited with status %d\n",
948
(unsigned int) (proc->pid),
1169
949
WEXITSTATUS(proc->status));
1170
} else if(WIFSIGNALED(proc->status)){
1171
fprintf(stderr, "Plugin %s [%" PRIdMAX "] killed by"
1172
" signal %d: %s\n", proc->name,
1173
(intmax_t) (proc->pid),
1174
WTERMSIG(proc->status),
1175
strsignal(WTERMSIG(proc->status)));
950
} else if(WIFSIGNALED(proc->status)) {
951
fprintf(stderr, "Plugin %u killed by signal %d\n",
952
(unsigned int) (proc->pid),
953
WTERMSIG(proc->status));
1176
954
} else if(WCOREDUMP(proc->status)){
1177
fprintf(stderr, "Plugin %s [%" PRIdMAX "] dumped"
1178
" core\n", proc->name, (intmax_t) (proc->pid));
955
fprintf(stderr, "Plugin %d dumped core\n",
956
(unsigned int) (proc->pid));
1182
960
/* Remove the plugin */
1183
#if defined (__GNUC__) and defined (__GLIBC__)
1184
#if not __GLIBC_PREREQ(2, 16)
1185
#pragma GCC diagnostic push
1186
#pragma GCC diagnostic ignored "-Wsign-conversion"
1189
FD_CLR(proc->fd, &rfds_all); /* Spurious warning from
1190
-Wconversion in GNU libc
1192
#if defined (__GNUC__) and defined (__GLIBC__)
1193
#if not __GLIBC_PREREQ(2, 16)
1194
#pragma GCC diagnostic pop
961
FD_CLR(proc->fd, &rfds_all);
1198
963
/* Block signal while modifying process_list */
1199
ret = (int)TEMP_FAILURE_RETRY(sigprocmask
1201
&sigchld_action.sa_mask,
964
ret = sigprocmask(SIG_BLOCK, &sigchld_action.sa_mask, NULL);
1204
error(0, errno, "sigprocmask");
1205
exitstatus = EX_OSERR;
966
perror("sigprocmask");
967
exitstatus = EXIT_FAILURE;
1232
993
bool bret = print_out_password(proc->buffer,
1233
994
proc->buffer_length);
1235
error(0, errno, "print_out_password");
1236
exitstatus = EX_IOERR;
996
perror("print_out_password");
997
exitstatus = EXIT_FAILURE;
1241
1002
/* This process has not completed. Does it have any output? */
1242
#if defined (__GNUC__) and defined (__GLIBC__)
1243
#if not __GLIBC_PREREQ(2, 16)
1244
#pragma GCC diagnostic push
1245
#pragma GCC diagnostic ignored "-Wsign-conversion"
1248
if(proc->eof or not FD_ISSET(proc->fd, &rfds)){ /* Spurious
1254
#if defined (__GNUC__) and defined (__GLIBC__)
1255
#if not __GLIBC_PREREQ(2, 16)
1256
#pragma GCC diagnostic pop
1003
if(proc->eof or not FD_ISSET(proc->fd, &rfds)){
1259
1004
/* This process had nothing to say at this time */
1260
1005
proc = proc->next;
1263
1008
/* Before reading, make the process' data buffer large enough */
1264
1009
if(proc->buffer_length + BUFFER_SIZE > proc->buffer_size){
1265
char *new_buffer = realloc(proc->buffer, proc->buffer_size
1266
+ (size_t) BUFFER_SIZE);
1267
if(new_buffer == NULL){
1268
error(0, errno, "malloc");
1269
exitstatus = EX_OSERR;
1010
proc->buffer = realloc(proc->buffer, proc->buffer_size
1011
+ (size_t) BUFFER_SIZE);
1012
if (proc->buffer == NULL){
1014
exitstatus = EXIT_FAILURE;
1272
proc->buffer = new_buffer;
1273
1017
proc->buffer_size += BUFFER_SIZE;
1275
1019
/* Read from the process */
1276
sret = TEMP_FAILURE_RETRY(read(proc->fd,
1278
+ proc->buffer_length,
1020
ret = read(proc->fd, proc->buffer + proc->buffer_length,
1281
1023
/* Read error from this process; ignore the error */
1282
1024
proc = proc->next;
1287
1029
proc->eof = true;
1289
proc->buffer_length += (size_t) sret;
1031
proc->buffer_length += (size_t) ret;
1297
if(plugin_list == NULL or (exitstatus != EXIT_SUCCESS
1298
and exitstatus != EX_OK)){
1039
if(plugin_list == NULL or exitstatus != EXIT_SUCCESS){
1299
1040
/* Fallback if all plugins failed, none are found or an error