19
18
* along with this program. If not, see
20
19
* <http://www.gnu.org/licenses/>.
22
* Contact the authors at <mandos@recompile.se>.
21
* Contact the authors at <mandos@fukt.bsnet.se>.
25
24
#define _GNU_SOURCE /* TEMP_FAILURE_RETRY(), getline(),
26
asprintf(), O_CLOEXEC */
27
26
#include <stddef.h> /* size_t, NULL */
28
#include <stdlib.h> /* malloc(), exit(), EXIT_SUCCESS,
27
#include <stdlib.h> /* malloc(), exit(), EXIT_FAILURE,
28
EXIT_SUCCESS, realloc() */
30
29
#include <stdbool.h> /* bool, true, false */
31
#include <stdio.h> /* fileno(), fprintf(),
30
#include <stdio.h> /* perror, fileno(), fprintf(),
32
31
stderr, STDOUT_FILENO */
33
#include <sys/types.h> /* DIR, fdopendir(), stat(), struct
32
#include <sys/types.h> /* DIR, opendir(), stat(), struct
34
33
stat, waitpid(), WIFEXITED(),
35
34
WEXITSTATUS(), wait(), pid_t,
36
35
uid_t, gid_t, getuid(), getgid(),
38
37
#include <sys/select.h> /* fd_set, select(), FD_ZERO(),
39
38
FD_SET(), FD_ISSET(), FD_CLR */
40
39
#include <sys/wait.h> /* wait(), waitpid(), WIFEXITED(),
41
WEXITSTATUS(), WTERMSIG(),
43
41
#include <sys/stat.h> /* struct stat, stat(), S_ISREG() */
44
42
#include <iso646.h> /* and, or, not */
45
#include <dirent.h> /* DIR, struct dirent, fdopendir(),
43
#include <dirent.h> /* DIR, struct dirent, opendir(),
46
44
readdir(), closedir(), dirfd() */
47
45
#include <unistd.h> /* struct stat, stat(), S_ISREG(),
48
46
fcntl(), setuid(), setgid(),
64
61
#include <signal.h> /* struct sigaction, sigemptyset(),
65
62
sigaddset(), sigaction(),
66
63
sigprocmask(), SIG_BLOCK, SIGCHLD,
67
SIG_UNBLOCK, kill(), sig_atomic_t
64
SIG_UNBLOCK, kill() */
69
65
#include <errno.h> /* errno, EBADF */
70
#include <inttypes.h> /* intmax_t, PRIdMAX, strtoimax() */
71
#include <sysexits.h> /* EX_OSERR, EX_USAGE, EX_IOERR,
72
EX_CONFIG, EX_UNAVAILABLE, EX_OK */
73
#include <errno.h> /* errno */
74
#include <error.h> /* error() */
76
67
#define BUFFER_SIZE 256
78
69
#define PDIR "/lib/mandos/plugins.d"
79
70
#define AFILE "/conf/conf.d/mandos/plugin-runner.conf"
81
const char *argp_program_version = "plugin-runner " VERSION;
82
const char *argp_program_bug_address = "<mandos@recompile.se>";
72
const char *argp_program_version = "plugin-runner 1.0";
73
const char *argp_program_bug_address = "<mandos@fukt.bsnet.se>";
84
75
typedef struct plugin{
85
76
char *name; /* can be NULL or any plugin name */
106
97
/* Gets an existing plugin based on name,
107
98
or if none is found, creates a new one */
108
99
static plugin *getplugin(char *name){
109
/* Check for existing plugin with that name */
110
for(plugin *p = plugin_list; p != NULL; p = p->next){
112
or (p->name and name and (strcmp(p->name, name) == 0))){
100
/* Check for exiting plugin with that name */
101
for (plugin *p = plugin_list; p != NULL; p = p->next){
102
if ((p->name == name)
103
or (p->name and name and (strcmp(p->name, name) == 0))){
116
107
/* Create a new plugin */
117
plugin *new_plugin = NULL;
119
new_plugin = malloc(sizeof(plugin));
120
} while(new_plugin == NULL and errno == EINTR);
121
if(new_plugin == NULL){
108
plugin *new_plugin = malloc(sizeof(plugin));
109
if (new_plugin == NULL){
124
112
char *copy_name = NULL;
125
113
if(name != NULL){
127
copy_name = strdup(name);
128
} while(copy_name == NULL and errno == EINTR);
114
copy_name = strdup(name);
129
115
if(copy_name == NULL){
137
*new_plugin = (plugin){ .name = copy_name,
140
.next = plugin_list };
120
*new_plugin = (plugin) { .name = copy_name,
123
.next = plugin_list };
143
new_plugin->argv = malloc(sizeof(char *) * 2);
144
} while(new_plugin->argv == NULL and errno == EINTR);
145
if(new_plugin->argv == NULL){
125
new_plugin->argv = malloc(sizeof(char *) * 2);
126
if (new_plugin->argv == NULL){
148
128
free(new_plugin);
152
131
new_plugin->argv[0] = copy_name;
153
132
new_plugin->argv[1] = NULL;
156
new_plugin->environ = malloc(sizeof(char *));
157
} while(new_plugin->environ == NULL and errno == EINTR);
134
new_plugin->environ = malloc(sizeof(char *));
158
135
if(new_plugin->environ == NULL){
161
137
free(new_plugin->argv);
162
138
free(new_plugin);
166
141
new_plugin->environ[0] = NULL;
411
367
.doc = "Group ID the plugins will run as", .group = 3 },
412
368
{ .name = "debug", .key = 132,
413
369
.doc = "Debug mode", .group = 4 },
415
* These reproduce what we would get without ARGP_NO_HELP
417
{ .name = "help", .key = '?',
418
.doc = "Give this help list", .group = -1 },
419
{ .name = "usage", .key = -3,
420
.doc = "Give a short usage message", .group = -1 },
421
{ .name = "version", .key = 'V',
422
.doc = "Print program version", .group = -1 },
426
__attribute__((nonnull(3)))
427
error_t parse_opt(int key, char *arg, struct argp_state *state){
373
error_t parse_opt (int key, char *arg, __attribute__((unused))
374
struct argp_state *state) {
432
376
case 'g': /* --global-options */
435
while((plugin_option = strsep(&arg, ",")) != NULL){
436
if(not add_argument(getplugin(NULL), plugin_option)){
379
while((p = strsep(&arg, ",")) != NULL){
383
if(not add_argument(getplugin(NULL), p)){
384
perror("add_argument");
385
return ARGP_ERR_UNKNOWN;
442
390
case 'G': /* --global-env */
443
add_environment(getplugin(NULL), arg, true);
394
if(not add_environment(getplugin(NULL), arg, true)){
395
perror("add_environment");
445
398
case 'o': /* --options-for */
447
char *option_list = strchr(arg, ':');
448
if(option_list == NULL){
449
argp_error(state, "No colon in \"%s\"", arg);
456
argp_error(state, "Empty plugin name");
461
while((option = strsep(&option_list, ",")) != NULL){
462
if(not add_argument(getplugin(arg), option)){
400
char *p_name = strsep(&arg, ":");
401
if(p_name[0] == '\0' or arg == NULL){
404
char *opt = strsep(&arg, ":");
405
if(opt[0] == '\0' or opt == NULL){
409
while((p = strsep(&opt, ",")) != NULL){
413
if(not add_argument(getplugin(p_name), p)){
414
perror("add_argument");
415
return ARGP_ERR_UNKNOWN;
468
420
case 'E': /* --env-for */
470
425
char *envdef = strchr(arg, ':');
471
426
if(envdef == NULL){
472
argp_error(state, "No colon in \"%s\"", arg);
479
argp_error(state, "Empty plugin name");
430
if(not add_environment(getplugin(arg), envdef+1, true)){
431
perror("add_environment");
483
add_environment(getplugin(arg), envdef, true);
486
435
case 'd': /* --disable */
488
437
plugin *p = getplugin(arg);
439
return ARGP_ERR_UNKNOWN;
494
444
case 'e': /* --enable */
496
446
plugin *p = getplugin(arg);
448
return ARGP_ERR_UNKNOWN;
502
453
case 128: /* --plugin-dir */
504
455
plugindir = strdup(arg);
456
if(plugindir == NULL){
506
460
case 129: /* --config-file */
507
461
/* This is already done by parse_opt_config_file() */
509
463
case 130: /* --userid */
510
tmp_id = strtoimax(arg, &tmp, 10);
511
if(errno != 0 or tmp == arg or *tmp != '\0'
512
or tmp_id != (uid_t)tmp_id){
513
argp_error(state, "Bad user ID number: \"%s\", using %"
514
PRIdMAX, arg, (intmax_t)uid);
464
uid = (uid_t)strtol(arg, NULL, 10);
519
466
case 131: /* --groupid */
520
tmp_id = strtoimax(arg, &tmp, 10);
521
if(errno != 0 or tmp == arg or *tmp != '\0'
522
or tmp_id != (gid_t)tmp_id){
523
argp_error(state, "Bad group ID number: \"%s\", using %"
524
PRIdMAX, arg, (intmax_t)gid);
467
gid = (gid_t)strtol(arg, NULL, 10);
529
469
case 132: /* --debug */
533
* These reproduce what we would get without ARGP_NO_HELP
535
case '?': /* --help */
536
state->flags &= ~(unsigned int)ARGP_NO_EXIT; /* force exit */
537
argp_state_help(state, state->out_stream, ARGP_HELP_STD_HELP);
538
case -3: /* --usage */
539
state->flags &= ~(unsigned int)ARGP_NO_EXIT; /* force exit */
540
argp_state_help(state, state->out_stream,
541
ARGP_HELP_USAGE | ARGP_HELP_EXIT_OK);
542
case 'V': /* --version */
543
fprintf(state->out_stream, "%s\n", argp_program_version);
547
* When adding more options before this line, remember to also add a
548
* "case" to the "parse_opt_config_file" function below.
550
472
case ARGP_KEY_ARG:
551
473
/* Cryptsetup always passes an argument, which is an empty
552
474
string if "none" was specified in /etc/crypttab. So if
553
475
argument was empty, we ignore it silently. */
477
fprintf(stderr, "Ignoring unknown argument \"%s\"\n", arg);
558
483
return ARGP_ERR_UNKNOWN;
560
return errno; /* Set to 0 at start */
563
488
/* This option parser is the same as parse_opt() above, except it
564
489
ignores everything but the --config-file option. */
565
error_t parse_opt_config_file(int key, char *arg,
566
__attribute__((unused))
567
struct argp_state *state){
490
error_t parse_opt_config_file (int key, char *arg,
491
__attribute__((unused))
492
struct argp_state *state) {
570
494
case 'g': /* --global-options */
571
495
case 'G': /* --global-env */
572
496
case 'o': /* --options-for */
660
576
new_arg = strdup(p);
661
577
if(new_arg == NULL){
662
error(0, errno, "strdup");
663
exitstatus = EX_OSERR;
579
exitstatus = EXIT_FAILURE;
668
584
custom_argc += 1;
670
char **new_argv = realloc(custom_argv, sizeof(char *)
673
if(new_argv == NULL){
674
error(0, errno, "realloc");
675
exitstatus = EX_OSERR;
680
custom_argv = new_argv;
585
custom_argv = realloc(custom_argv, sizeof(char *)
586
* ((unsigned int) custom_argc + 1));
587
if(custom_argv == NULL){
589
exitstatus = EXIT_FAILURE;
683
593
custom_argv[custom_argc-1] = new_arg;
684
custom_argv[custom_argc] = NULL;
594
custom_argv[custom_argc] = NULL;
688
ret = fclose(conffp);
689
} while(ret == EOF and errno == EINTR);
691
error(0, errno, "fclose");
692
exitstatus = EX_IOERR;
697
599
/* Check for harmful errors and go to fallback. Other errors might
698
600
not affect opening plugins */
699
if(errno == EMFILE or errno == ENFILE or errno == ENOMEM){
700
error(0, errno, "fopen");
701
exitstatus = EX_OSERR;
601
if (errno == EMFILE or errno == ENFILE or errno == ENOMEM){
603
exitstatus = EXIT_FAILURE;
705
/* If there were any arguments from the configuration file, pass
706
them to parser as command line arguments */
607
/* If there was any arguments from configuration file,
608
pass them to parser as command arguments */
707
609
if(custom_argv != NULL){
708
ret = argp_parse(&argp, custom_argc, custom_argv,
709
ARGP_IN_ORDER | ARGP_NO_EXIT | ARGP_NO_HELP,
717
error(0, errno, "argp_parse");
718
exitstatus = EX_OSERR;
721
exitstatus = EX_CONFIG;
610
ret = argp_parse (&argp, custom_argc, custom_argv, ARGP_IN_ORDER,
612
if (ret == ARGP_ERR_UNKNOWN){
613
fprintf(stderr, "Unknown error while parsing arguments\n");
614
exitstatus = EXIT_FAILURE;
726
619
/* Parse actual command line arguments, to let them override the
728
ret = argp_parse(&argp, argc, argv,
729
ARGP_IN_ORDER | ARGP_NO_EXIT | ARGP_NO_HELP,
737
error(0, errno, "argp_parse");
738
exitstatus = EX_OSERR;
741
exitstatus = EX_USAGE;
621
ret = argp_parse (&argp, argc, argv, ARGP_IN_ORDER, 0, NULL);
622
if (ret == ARGP_ERR_UNKNOWN){
623
fprintf(stderr, "Unknown error while parsing arguments\n");
624
exitstatus = EXIT_FAILURE;
749
632
for(char **a = p->argv; *a != NULL; a++){
750
633
fprintf(stderr, "\tArg: %s\n", *a);
752
fprintf(stderr, "...and %d environment variables\n", p->envc);
635
fprintf(stderr, "...and %u environment variables\n", p->envc);
753
636
for(char **a = p->environ; *a != NULL; a++){
754
637
fprintf(stderr, "\t%s\n", *a);
760
/* Work around Debian bug #633582:
761
<http://bugs.debian.org/633582> */
762
int plugindir_fd = open(/* plugindir or */ PDIR, O_RDONLY);
763
if(plugindir_fd == -1){
764
error(0, errno, "open");
766
ret = (int)TEMP_FAILURE_RETRY(fstat(plugindir_fd, &st));
768
error(0, errno, "fstat");
770
if(S_ISDIR(st.st_mode) and st.st_uid == 0 and st.st_gid == 0){
771
ret = fchown(plugindir_fd, uid, gid);
773
error(0, errno, "fchown");
777
TEMP_FAILURE_RETRY(close(plugindir_fd));
781
/* Lower permissions */
784
error(0, errno, "setgid");
642
/* Strip permissions down to nobody */
786
643
ret = setuid(uid);
788
error(0, errno, "setuid");
791
/* Open plugin directory with close_on_exec flag */
652
if (plugindir == NULL){
655
dir = opendir(plugindir);
659
perror("Could not open plugin dir");
660
exitstatus = EXIT_FAILURE;
664
/* Set the FD_CLOEXEC flag on the directory, if possible */
794
if(plugindir == NULL){
795
dir_fd = open(PDIR, O_RDONLY |
798
#else /* not O_CLOEXEC */
800
#endif /* not O_CLOEXEC */
803
dir_fd = open(plugindir, O_RDONLY |
806
#else /* not O_CLOEXEC */
808
#endif /* not O_CLOEXEC */
812
error(0, errno, "Could not open plugin dir");
813
exitstatus = EX_UNAVAILABLE;
818
/* Set the FD_CLOEXEC flag on the directory */
819
ret = set_cloexec_flag(dir_fd);
821
error(0, errno, "set_cloexec_flag");
822
TEMP_FAILURE_RETRY(close(dir_fd));
823
exitstatus = EX_OSERR;
826
#endif /* O_CLOEXEC */
828
dir = fdopendir(dir_fd);
830
error(0, errno, "Could not open plugin dir");
831
TEMP_FAILURE_RETRY(close(dir_fd));
832
exitstatus = EX_OSERR;
666
int dir_fd = dirfd(dir);
668
ret = set_cloexec_flag(dir_fd);
670
perror("set_cloexec_flag");
671
exitstatus = EXIT_FAILURE;
983
800
if(p->environ[0] != NULL){
984
801
for(char **e = environ; *e != NULL; e++){
985
802
if(not add_environment(p, *e, false)){
986
error(0, errno, "add_environment");
803
perror("add_environment");
992
ret = (int)TEMP_FAILURE_RETRY(pipe(pipefd));
994
error(0, errno, "pipe");
995
exitstatus = EX_OSERR;
812
exitstatus = EXIT_FAILURE;
998
815
/* Ask OS to automatic close the pipe on exec */
999
816
ret = set_cloexec_flag(pipefd[0]);
1001
error(0, errno, "set_cloexec_flag");
1002
exitstatus = EX_OSERR;
818
perror("set_cloexec_flag");
819
exitstatus = EXIT_FAILURE;
1005
822
ret = set_cloexec_flag(pipefd[1]);
1007
error(0, errno, "set_cloexec_flag");
1008
exitstatus = EX_OSERR;
824
perror("set_cloexec_flag");
825
exitstatus = EXIT_FAILURE;
1011
828
/* Block SIGCHLD until process is safely in process list */
1012
ret = (int)TEMP_FAILURE_RETRY(sigprocmask(SIG_BLOCK,
1013
&sigchld_action.sa_mask,
829
ret = sigprocmask (SIG_BLOCK, &sigchld_action.sa_mask, NULL);
1016
error(0, errno, "sigprocmask");
1017
exitstatus = EX_OSERR;
831
perror("sigprocmask");
832
exitstatus = EXIT_FAILURE;
1020
835
/* Starting a new process to be watched */
1024
} while(pid == -1 and errno == EINTR);
1026
error(0, errno, "fork");
1027
exitstatus = EX_OSERR;
839
exitstatus = EXIT_FAILURE;
1031
843
/* this is the child process */
1032
844
ret = sigaction(SIGCHLD, &old_sigchld_action, NULL);
1034
error(0, errno, "sigaction");
1037
849
ret = sigprocmask(SIG_UNBLOCK, &sigchld_action.sa_mask, NULL);
1039
error(0, errno, "sigprocmask");
851
perror("sigprocmask");
1043
855
ret = dup2(pipefd[1], STDOUT_FILENO); /* replace our stdout */
1045
error(0, errno, "dup2");
1049
861
if(dirfd(dir) < 0){
1054
866
if(p->environ[0] == NULL){
1055
867
if(execv(filename, p->argv) < 0){
1056
error(0, errno, "execv for %s", filename);
1060
872
if(execve(filename, p->argv, p->environ) < 0){
1061
error(0, errno, "execve for %s", filename);
1067
879
/* Parent process */
1068
TEMP_FAILURE_RETRY(close(pipefd[1])); /* Close unused write end of
880
close(pipefd[1]); /* Close unused write end of pipe */
1071
882
plugin *new_plugin = getplugin(dirst->d_name);
1072
if(new_plugin == NULL){
1073
error(0, errno, "getplugin");
1074
ret = (int)(TEMP_FAILURE_RETRY
1075
(sigprocmask(SIG_UNBLOCK, &sigchld_action.sa_mask,
883
if (new_plugin == NULL){
885
ret = sigprocmask (SIG_UNBLOCK, &sigchld_action.sa_mask, NULL);
1078
error(0, errno, "sigprocmask");
887
perror("sigprocmask");
1080
exitstatus = EX_OSERR;
889
exitstatus = EXIT_FAILURE;
1087
896
/* Unblock SIGCHLD so signal handler can be run if this process
1088
897
has already completed */
1089
ret = (int)TEMP_FAILURE_RETRY(sigprocmask(SIG_UNBLOCK,
1090
&sigchld_action.sa_mask,
898
ret = sigprocmask (SIG_UNBLOCK, &sigchld_action.sa_mask, NULL);
1093
error(0, errno, "sigprocmask");
1094
exitstatus = EX_OSERR;
900
perror("sigprocmask");
901
exitstatus = EXIT_FAILURE;
1098
#if defined (__GNUC__) and defined (__GLIBC__)
1099
#if not __GLIBC_PREREQ(2, 16)
1100
#pragma GCC diagnostic push
1101
#pragma GCC diagnostic ignored "-Wsign-conversion"
1104
FD_SET(new_plugin->fd, &rfds_all); /* Spurious warning from
1105
-Wconversion in GNU libc
1107
#if defined (__GNUC__) and defined (__GLIBC__)
1108
#if not __GLIBC_PREREQ(2, 16)
1109
#pragma GCC diagnostic pop
905
FD_SET(new_plugin->fd, &rfds_all);
1113
if(maxfd < new_plugin->fd){
907
if (maxfd < new_plugin->fd){
1114
908
maxfd = new_plugin->fd;
1118
TEMP_FAILURE_RETRY(closedir(dir));
1120
free_plugin(getplugin(NULL));
1122
915
for(plugin *p = plugin_list; p != NULL; p = p->next){
1123
916
if(p->pid != 0){
1134
927
while(plugin_list){
1135
928
fd_set rfds = rfds_all;
1136
929
int select_ret = select(maxfd+1, &rfds, NULL, NULL, NULL);
1137
if(select_ret == -1 and errno != EINTR){
1138
error(0, errno, "select");
1139
exitstatus = EX_OSERR;
930
if (select_ret == -1){
932
exitstatus = EXIT_FAILURE;
1142
935
/* OK, now either a process completed, or something can be read
1143
936
from one of them */
1144
937
for(plugin *proc = plugin_list; proc != NULL;){
1145
938
/* Is this process completely done? */
1146
if(proc->completed and proc->eof){
939
if(proc->eof and proc->completed){
1147
940
/* Only accept the plugin output if it exited cleanly */
1148
941
if(not WIFEXITED(proc->status)
1149
942
or WEXITSTATUS(proc->status) != 0){
1150
943
/* Bad exit by plugin */
1153
946
if(WIFEXITED(proc->status)){
1154
fprintf(stderr, "Plugin %s [%" PRIdMAX "] exited with"
1155
" status %d\n", proc->name,
1156
(intmax_t) (proc->pid),
947
fprintf(stderr, "Plugin %u exited with status %d\n",
948
(unsigned int) (proc->pid),
1157
949
WEXITSTATUS(proc->status));
1158
} else if(WIFSIGNALED(proc->status)){
1159
fprintf(stderr, "Plugin %s [%" PRIdMAX "] killed by"
1160
" signal %d: %s\n", proc->name,
1161
(intmax_t) (proc->pid),
1162
WTERMSIG(proc->status),
1163
strsignal(WTERMSIG(proc->status)));
950
} else if(WIFSIGNALED(proc->status)) {
951
fprintf(stderr, "Plugin %u killed by signal %d\n",
952
(unsigned int) (proc->pid),
953
WTERMSIG(proc->status));
1164
954
} else if(WCOREDUMP(proc->status)){
1165
fprintf(stderr, "Plugin %s [%" PRIdMAX "] dumped"
1166
" core\n", proc->name, (intmax_t) (proc->pid));
955
fprintf(stderr, "Plugin %d dumped core\n",
956
(unsigned int) (proc->pid));
1170
960
/* Remove the plugin */
1171
#if defined (__GNUC__) and defined (__GLIBC__)
1172
#if not __GLIBC_PREREQ(2, 16)
1173
#pragma GCC diagnostic push
1174
#pragma GCC diagnostic ignored "-Wsign-conversion"
1177
FD_CLR(proc->fd, &rfds_all); /* Spurious warning from
1178
-Wconversion in GNU libc
1180
#if defined (__GNUC__) and defined (__GLIBC__)
1181
#if not __GLIBC_PREREQ(2, 16)
1182
#pragma GCC diagnostic pop
961
FD_CLR(proc->fd, &rfds_all);
1186
963
/* Block signal while modifying process_list */
1187
ret = (int)TEMP_FAILURE_RETRY(sigprocmask
1189
&sigchld_action.sa_mask,
964
ret = sigprocmask(SIG_BLOCK, &sigchld_action.sa_mask, NULL);
1192
error(0, errno, "sigprocmask");
1193
exitstatus = EX_OSERR;
966
perror("sigprocmask");
967
exitstatus = EXIT_FAILURE;
1220
993
bool bret = print_out_password(proc->buffer,
1221
994
proc->buffer_length);
1223
error(0, errno, "print_out_password");
1224
exitstatus = EX_IOERR;
996
perror("print_out_password");
997
exitstatus = EXIT_FAILURE;
1229
1002
/* This process has not completed. Does it have any output? */
1230
#if defined (__GNUC__) and defined (__GLIBC__)
1231
#if not __GLIBC_PREREQ(2, 16)
1232
#pragma GCC diagnostic push
1233
#pragma GCC diagnostic ignored "-Wsign-conversion"
1236
if(proc->eof or not FD_ISSET(proc->fd, &rfds)){ /* Spurious
1242
#if defined (__GNUC__) and defined (__GLIBC__)
1243
#if not __GLIBC_PREREQ(2, 16)
1244
#pragma GCC diagnostic pop
1003
if(proc->eof or not FD_ISSET(proc->fd, &rfds)){
1247
1004
/* This process had nothing to say at this time */
1248
1005
proc = proc->next;
1251
1008
/* Before reading, make the process' data buffer large enough */
1252
1009
if(proc->buffer_length + BUFFER_SIZE > proc->buffer_size){
1253
char *new_buffer = realloc(proc->buffer, proc->buffer_size
1254
+ (size_t) BUFFER_SIZE);
1255
if(new_buffer == NULL){
1256
error(0, errno, "malloc");
1257
exitstatus = EX_OSERR;
1010
proc->buffer = realloc(proc->buffer, proc->buffer_size
1011
+ (size_t) BUFFER_SIZE);
1012
if (proc->buffer == NULL){
1014
exitstatus = EXIT_FAILURE;
1260
proc->buffer = new_buffer;
1261
1017
proc->buffer_size += BUFFER_SIZE;
1263
1019
/* Read from the process */
1264
sret = TEMP_FAILURE_RETRY(read(proc->fd,
1266
+ proc->buffer_length,
1020
ret = read(proc->fd, proc->buffer + proc->buffer_length,
1269
1023
/* Read error from this process; ignore the error */
1270
1024
proc = proc->next;
1275
1029
proc->eof = true;
1277
proc->buffer_length += (size_t) sret;
1031
proc->buffer_length += (size_t) ret;
1285
if(plugin_list == NULL or (exitstatus != EXIT_SUCCESS
1286
and exitstatus != EX_OK)){
1039
if(plugin_list == NULL or exitstatus != EXIT_SUCCESS){
1287
1040
/* Fallback if all plugins failed, none are found or an error